#At the end of one extended sustain note, any lower notes are dropped along with it.

27 messages · Page 1 of 1 (latest)

alpine dew
#

can see that when ascending, note_ends are perfectly fine

#

when descending, they do not

#

likely because it considers holding two notes to not be valid the second the higher note ends, when it should instead be valid until the next time the user presses that higher note or the lower note ends

pallid kiln
#

@stoic ore poking you about this

#

this'll probably get fixed in the guitar engine rewrite Riley's working on

stoic ore
#

which is causing it to drop as soon as the blue ends

#

wait

#

give me 2 minutes to make sure i am not being stupid here

#

ok so the explanation i gave was correct its just the wrong explanation entirely lol

#

it shouldnt be marked as an extended sustain

#

if it was then this wouldnt happen (but it would also be wrong to do that)

#

so this requires additional stuff to handle

pallid kiln
#

hm, why shouldn't it be getting marked?

stoic ore
#

because an extended sustain is defined as "a sustain which has other notes being played on top of it"

#

the blue has already been played, its just being held during the yellow

#

the yellow comes after, no more notes are played during the yellow's length

pallid kiln
#

the blue is still active though

#

is there any other reason not to do it, other than a technicality in the definition?

stoic ore
#

as far as I can think of currently, no? It just may potentially add other quirkiness

#

this is probably what the lingering sustain thing they added into CH a while back does when I found a bug with sustains that completely defied chord hit logic and matt said it would be really hard to fix because of the lingering sustain system

#

maybe not though

#

(the bug in CH is really laughable though)

pallid kiln
#

guess we should play around with it and see if it does cause any problems

stoic ore
#

yeah we could do