I don't think this was happening before I updated to 0.10.4 (from 0.10.2) but often HO/PO chord sustains will drop on their own. (probably 1-4 notes of the chord, I haven't tried with more than 3 note chords) It seems to always leave at least one of the sustains going though, which is weird.
I have tried out the same guitars on CH as well as on YARG and they all drop on YARG but not CH.
#Dropping HO/PO Chord sustains
rough lintel
abstract torrent
could you send a video?
rough lintel
I didn't think to try other songs, after making a chart specifically for testing it wasn't happening, even though both songs were .mid
specifically Inamorata - Metallica was what it was happening on
abstract torrent
hmmmmm
i think the notes are misaligned
and they become extended sustains when they shouldnt?
rough lintel
so just a bad chart?
abstract torrent
weird though because even then they shouldnt drop
cant say for sure
can you send the chart over? might take a look later but no promises
rough lintel
abstract torrent
thanks
sturdy scroll
I have this problem too with hopo/tap note
rough lintel
on other songs?
sturdy scroll
Yeah
abstract torrent
took a quick look, couldnt find misaligned notes, so i'm probably wrong
could be something with the sustain dropping code, maybe it's not ignoring currently held notes if you hit the hopo notes slightly separately
dont really wanna take a look at this right now though
also since there's an ongoing engine rewrite, fixing this wouldnt be really urgent since all code is going to be redone anyway
rough lintel
fair enough
cursive path
I also been having this problem on multiple charts from multiple sources
And with chords sustains in general, not only hopo chords
(I was going nuts thinking my guitar where overtapping lol)
scenic depot
If you have that "forbidden" CH/YARG pack, Let Her Cry by Hootie and the Blowfish seemed to exhibit this well for me
cursive path
could be something with the sustain dropping code, maybe it's not ignoring curre...
I think the issue is that, cause the drops only occurs for me during sections with fast chord changes (with or without hopos)
scenic depot
I mean, the song I experienced it with didn't really have fast chord changes. It was an R strum followed by a Y hopo then a YB hopo with sustain. Happened more often than not when that particular sequence of notes came up (it happens a few times)
abstract torrent
taking a quick look through the code and i really dont know what could be going on
cursive path
Now that I'm thinking about, I guess it was only dropping when Orange was involved... I'll try to test a bit more tomorrow
abstract torrent
the spots where a sustain is released are:
- sustain ended (songtime > sustain time + length); clearly not the case here
- overstrum (also not the case because it releases ALL sustains)
- invalid fret pressed and not extended sustain (also not the case because it releases ALL sustains)
- held sustain fret released
- if its an extended sustain, release only that one sustain, rather than entire chord
- if its not, release ALL sustains
forgot discord does that now lol
so the bug is more subtle than just "sustain release not working"
either the extended sustain check is wrong for whatever reason (doesnt seem to be though)
or its something else entirely that's affecting the sustains for some reason
scenic depot
I'm playing mostly HMX content directly from HMX-format files (although Let Her Cry is in song.ini format), so in my case at least it's very possible HMX or RA fucked up and had a sustain that wasn't exactly the same length for each gem, making YARG think it's extended when it isn't. It dropped the B note in the YB chord sustain instantly, and did not miss
wrong song name on my part lmao
abstract torrent
my extended sustain code checks if notes overlap rather than if the lenghts are the same
so as long as two notes are in the same position, they wont be detected as ext sustains even if the length is different
i've read some stuff regarding chord snapping
apparently hmx has had some issues with chord notes being a few ticks apart and they implemented a chord snapping in that case? dunno but thats what i've heard
scenic depot
yea I consider that tech debt from way back in the Milo engine's history, and for compatibility they had to carry it forward even into the Forge days, they still rerelease old content and shit
I honestly think they originally did it just to paper over sloppy authoring, as far back as at least GH1 (idk about freq or amp on that front). It's certainly a lot easier to misalign something in a DAW as compared to a dedicated authoring tool like dB or MS