Yes this is intended to work with wocfmp for cinematic effect 
#Visual Revamp
warm pasture
summer yacht
Add a teto Easter egg somewhere
warm pasture
Add a teto Easter egg somewhere <:klueless:1084232164352209038>
i had this exact thought
summer yacht
Good
muted blade
Regarding ambient lighting, Planety can set the following values:
some_planet.lighting.ambient.day
some_planet.lighting.ambient.night
some_planet.lighting.ambient.scaled
some_planet.lighting.ambient.inner_altitude
some_planet.lighting.ambient.outer_altitude
warm pasture
Regarding ambient lighting, Planety can set the following values:
`some_planet.l...
what
does it work with existing planets, eg; kerbin?
muted blade
There's also some values in non-ambient lighting
some_planet.lighting.horizon_offset
some_planet.lighting.day_blend_range
some_planet.lighting.night_blend_range
some_planet.lighting.directional_inner_altitude
some_planet.lighting.directional_outer_altitude
but idk what they do
muted blade
does it work with existing planets, eg; kerbin?
I think so
If you're just doing that, you can put runs always in your mod header so it doesn't need to be enabled or restricted to new saves. See Joolian Rings for how that works.
warm pasture
If you're just doing that, you can put `runs always` in your mod header so it do...
okey dokie
woah okay i see what you mean
warm pasture
Just change the post processing
ohhhh ok
severe nova
i had this exact thought <:klueless:1084232164352209038>
teto pear sun
warm pasture
i'll probably need to do ui work then for something like this
warm pasture
teto pear sun
that is if i can even change the sunflare texture
muted blade
I should probably make Planety able to create PostProcessProfiles too tbh
severe nova
I should probably make Planety able to create `PostProcessProfile`s too tbh
Why do planets even have seperate profiles though
All are disabled except for Bop
But ye I agree
warm pasture
land on duna and your whole screen gets the breaking bad filter
warm pasture
Twas CelestialBodyLensFlareSystem responsible for the lens flares, and that was triggered by the LightingSystem script
warm pasture
Isn’t this already coming with redux?
the sunflare things with redux is changing the colours with the atmosphere
mine is just changing the style of the sunflares
severe nova
Ohh, so you’re gonna changing the look completely?
Yeah I think their goal is to get the sunflare to look like the ksp2 ea gameplay trailer sunflare
warm pasture
Yeah I think their goal is to get the sunflare to look like the ksp2 ea gameplay...
somewhat yeah
sort of similar
someway i just want it to look more appealing to some people instead of an eye sore
warm pasture
Oh the cinematic trailer flare?
i thought you were talking about the cinematics
which one were you referring to
severe nova
Maybe you can load the flare asset from the main menu
severe nova
which one were you referring to
The gameplay trailer they released I think on January 17th
severe nova
Yes
Should be way easier to do
Just disable all elements except the first one and second one
warm pasture
funnily enough thats easy
severe nova
Have you done it with code yet?
warm pasture
no not yet, i dont know exactly what i need to do to achieve it
something to do with the ProFlare properties is all im sure of
severe nova
Yeah
warm pasture
I think ProFlareBatch has it
severe nova
Just set visible to the other elements to false
warm pasture
Just set visible to the other elements to false
should be easy enough
now theres also something else i want thats been bugging me for a while
stars from planety
blue star = yellow sunflare very realistic
would there be a way to change a sunflares colours based off the texture of that star?
severe nova
Then you’d want to adjust the tint
But that won’t work in Redux as it doesn’t use the tint at all
warm pasture
Then you’d want to adjust the tint
But that won’t work in Redux as it doesn’t us...
okay nvm then
severe nova
But for now it should work
warm pasture
i do want to make sure this works with redux upon release
@muted blade did you plan any sunflare features with planety?
bc im wondering if you can change the sunflare textures with custom imgaes then if it would be possible to integrate it with planety stars
muted blade
There's some configurable settings, but nothing like that yet
I guess I could add it; I never looked much at how flares work though
warm pasture
errrrr, do i gotta like put this in a different cs script or something
im wondering if i just need to do this instead
naive thunder
You're redefining the variable
severe nova
errrrr, do i gotta like put this in a different cs script or something
You already have something called LightingSystem
naive thunder
Just leave out the type at the start
warm pasture
yeah thought so
severe nova
Just leave out the type at the start
Or that
Yeah that’s the issue
warm pasture
i dont have any more errors doing that so should be fine
it lied\
althought it seems to have executed fine without errors
its just
theres still a skybox..
either that or im just not reading a correct part of the code i need to disable
muted blade
I assume the skybox manager isn't the skybox, it just controls it
warm pasture
that could be it
muted blade
Look at what fields and methods SkyboxManager has, since it will likely need to hold a reference to the actual skybox
warm pasture
i wonder if its something to do with a galaxy addressable related to CB
muted blade
Galaxy in this game typically refers to the layout of the star systems
warm pasture
found it
DynamicAmbientLight is what has it
it actually holds quite a few values
i just need to work out how to apply this to my code now
any ideas?
naive thunder
well you need to find the game object which has a reference to this
actually you don't even need that, since the LightingSystem is referenced like everywhere, you can use the reference in the GraphicsManager for example (Game.GraphicsManager.LightingSystem.DynamicAmbientLight)
warm pasture
i was about to say dont make me look for the reference 😭
naive thunder
i was about to say dont make me look for the reference 😭
that's like 80% of modding, just looking for stuff
warm pasture
actually you don't even need that, since the LightingSystem is referenced like e...
couldnt i do GameObject.FindObjectsOfType<DynamicAmbientLight>().FirstOrDefault();
since i already have lightingsystems referenced
naive thunder
that would be extremely inefficient
warm pasture
im still learning
naive thunder
it would have to go through every single game object in the scene and check all of its components
rather than just directly grabbing the reference like I showed
warm pasture
gotcha
warm pasture
actually you don't even need that, since the LightingSystem is referenced like e...
how exactly would i apply that to this though
naive thunder
I'm not sure what you're trying to do there
warm pasture
ignore the LogInfo which has flarecamera
naive thunder
the first line doesn't do anything
warm pasture
thats unrelated
naive thunder
it just finds an object and throws it away
warm pasture
it just finds an object and throws it away
you see, i dont think half the time
naive thunder
where is your LightingSystem variable defined?
warm pasture
severe nova
I think you should create a different variable for the skybox
warm pasture
can do
severe nova
Right now it’s just disabling the lens flare twice
warm pasture
two is better than one am i right
severe nova
Either you assign the skybox to LightingSystem or you assign it to a different variable and disable it
warm pasture
i'll probably assign a different variable and see what happens
severe nova
i'll probably assign a different variable and see what happens
You should do that
SkyboxManager Skybox = gameobject.find yada yada
i think
naive thunder
having a constant wait time is not ideal, you might want to do something like:
...
Game.Messages.Subscribe<GameLoadFinishedMessage>(OnGameLoadFinishedMessage);
}
private static void OnGameLoadFinishedMessage(MessageCenterMessage msg)
{
if (!((GameLoadFinishedMessage)msg).IsSuccess)
{
return;
}
var lightingSystem = Game.GraphicsManager.LightingSystem;
lightingSystem.LensFlareSystem.enabled = false;
lightingSystem.SkyboxManager.enabled = false;
var dynamicAmbientLight = lightingSystem.DynamicAmbientLight;
// ... do what you want to do with the dynamic ambient light
}
so do i keep ` public override void OnInitialized()
{
base.OnInitialized();
Instance = this;
Logger.LogInfo("KillSunflarePlugin is go, awaiting next steps");
Logger.LogInfo("SkyBox disabled is go, awaiting next steps");
StartCoroutine(AssetsDisable());
}
private IEnumerator AssetsDisable()` or not really
well that formatted horribly
severe nova
naive thunder
the first line of what I showed you is meant to be a replacement for the StartCoroutine call
naive thunder
well that formatted horribly
btw if you want to write a multiline code block, you can do it like this:
```cs
// code
```
where the cs is an abbreviation of the language (in this case C# = C Sharp = CS)
oof
warm pasture
severe nova
I don’t think that’s right either
naive thunder
holy shit
severe nova
Bro
warm pasture
lmaoooo
naive thunder
does Discord actually have such a shit Markdown implementation that it's impossible to escape triple backtick inside a codeblock?
lmfao
warm pasture
why is the sunflare back
oh wait no nvm i know why
ok nvm i dont, i dont even know what im trying to do here
naive thunder
why did you change it from LensFlareSystem to CelestialBodyLensFlareSystem?
there's no such property
warm pasture
there's no such property
tbf i didnt know that, and bc it brought back the sunflare
severe nova
Well yeah
You aren’t disabling it anywhere
naive thunder
tbf i didnt know that, and bc it brought back the sunflare
I mean it's telling you by screaming at you in red
warm pasture
i noted that as well
naive thunder
you can just look into the LightingSystem class to see what the properties are called
severe nova
CelestialBodyLensFlareSystem.enabled = false; should do it
warm pasture
CelestialBodyLensFlareSystem.enabled = false; should do it
it does not
its screaming at me
severe nova
Why?
warm pasture
i dunno
naive thunder
yeah, giving it the same name as a class will cause issues
warm pasture
Change the variable name
to LensFlareSystem?
naive thunder
you're not defining the variable anywhere
warm pasture
you're not defining the variable anywhere
so like i'd need to do
Gameobject TetoPear = GameObject.Find("something"); TetoPear.enabled = false;
either that or im just lost
warm pasture
I mean I have no fucking clue what TetoPear means
its just an example lmao
naive thunder
ok but what is it supposed to be?
because you're disabling something that doesn't exist
warm pasture
tbf the lensflaresystem but im just extremely lost at this rate
naive thunder
but you are already disabling that above it
warm pasture
not trying to be intentionally dense
warm pasture
but you are already disabling that above it
yes but i still ended up having a lens flare when i actually built the csproj and put it ingame
naive thunder
then something else is wrong
warm pasture
probably
naive thunder
disabling the lens flare system by itself doesn't do anything
severe nova
I don’t think you’d even want to disable the lens flare
warm pasture
I don’t think you’d even want to disable the lens flare
twas mainly for testing purposes
naive thunder
yeah, if you destroy the component, the sun completely disappears
so that's not ideal
warm pasture
only the flare, kerbol itself still remained on the map
severe nova
You want to disable some elements in ProFlare
Or even add your own flare asset to it (not sure if it’s possible, munix can tell you if so)
naive thunder
on the map, yes, in flight view, no
warm pasture
You want to disable some elements in ProFlare
Or even add your own flare asset t...
i dont even know what parts i need to touch to disabled certain elements in ProFlare
severe nova
i dont even know what parts i need to touch to disabled certain elements in ProF...
Visible
That’s it
warm pasture
but certain elements, dont know how
referring to not doing visible on the whole code
for doing certain elements of ProFlare would i need to use NameSpace? or something
naive thunder
you had a Unity setup for running the game right?
warm pasture
you had a Unity setup for running the game right?
WorldVis yes
naive thunder
just experiment with modifying the components there while the game is running and then replicate the same exact steps in code
warm pasture
im at this rate guessing
im seriously gonna consider watching a 10 hour tutorial on c#
warm pasture
im seriously gonna consider watching a 10 hour tutorial on c# <:klueless:1084232...
yup im doing that, i'll come back to this project later
muted blade
does Discord actually have such a shit Markdown implementation that it's impossi...
Yes
I've had to make a workaround for that in my bot when it handles escaping
naive thunder
warm pasture
update to my progress learning c#
its not going well
its been like this since 2 days ago
severe nova
If I'm gonna be honest
You probably don't need all of that
naive thunder
it might be best to just do like a beginner C# tutorial/course and then some Unity basics