Patch Manager | KSP2 Redux | Page 7

upbeat hare Dec 15, 2023, 9:32 PM

#

@north mist i just thought of another use for this

#

Having completely different part definitions depending on installed mods

north mist Dec 15, 2023, 9:33 PM

#

like, for something like RO configs for parts?

upbeat hare Dec 15, 2023, 9:33 PM

#

Yeah

#

Or like having your parts have modules from other mods if they are installed

north mist Dec 15, 2023, 9:36 PM

#

wouldn't it be easier in both these use cases if there was just one definition and then extra patches for the extra cases, though?

upbeat hare Dec 15, 2023, 9:36 PM

#

Yes, but its still a possibility of something you can do

north mist Dec 15, 2023, 9:37 PM

#

the best I can think of is if the asset addressing thing was added, you could then very easily create multiple completely different parts using the same model

#

which for example RO does a lot

upbeat hare Dec 15, 2023, 9:38 PM

#

Thats gonna be a weird thing to do, for that we would need a way to copy assets to another location (or at least rename them)
Like we can have a base asset, and then copy and rename for every asset made off that model

north mist Dec 15, 2023, 9:39 PM

#

why would we need to?

#

you mean in case someone decides to edit the assets at runtime for some reason?

upbeat hare Dec 15, 2023, 9:40 PM

#

Cuz of how the game searches for the assets

#

Though I had another idea of injecting the load point of parts to load a superset of PartData that has a "PrefabAddress" and an "IconAddress" field

north mist Dec 15, 2023, 9:41 PM

#

yeah that's basically exactly what I meant

upbeat hare Dec 15, 2023, 9:41 PM

#

So we have a RelocatablePartData that extends part data or whatever (or we just look into the json file when loading part data)

#

Its gonna be a bit of a complex one though

#

For the patch itself

#

Harmony patch that is

#

And then when patching parts, we add this field if it doesnt exist already

#

So that people can easily select a different model for a part

north mist Dec 15, 2023, 9:43 PM

#

yeah

#

this should also enable people to create duplicates of stock parts without distributing the assets

#

which would be nice

upbeat hare Dec 15, 2023, 9:44 PM

#

Yep

north mist Dec 15, 2023, 9:44 PM

#

I can take a look at this thing tomorrow

#

I would do it right now but I have to at least look over the stuff for tomorrow's exam once lmao

upbeat hare Dec 15, 2023, 9:45 PM

#

For the purposes of that, just assume every parts_data jsonhas an extra 2 fields called PrefabAddress and IconAddress

upbeat hare Dec 15, 2023, 10:25 PM

#

@north mist how does this look

📎 message.patch

north mist Dec 15, 2023, 10:26 PM

#

looks good!

upbeat hare Dec 15, 2023, 10:26 PM

#

What do you think of me inlining the tooltips in the comments?

north mist Dec 15, 2023, 10:27 PM

#

yeah I like that a lot

upbeat hare Dec 15, 2023, 10:27 PM

#

This took no small amount of formatting work lol

#

I'm adding an API into KSP2UnityTools btw to output an object as a patch manager patch

#

But I'll complete that fully tomorrow

north mist Dec 15, 2023, 10:28 PM

#

I'm wondering, would it be possible (maybe optionally with a toggle) to leave out the fields that have default values?

upbeat hare Dec 15, 2023, 10:29 PM

#

Maybe, but I don't see the point

#

You want to see every value in case you want to edit some

#

Plus it helps others know where to look/patch

north mist Dec 15, 2023, 10:30 PM

#

yeah I guess

#

it was mainly because the PartData looks really crowded and the majority of the fields there is not being changed

#

at least not by current mods

upbeat hare Dec 15, 2023, 10:32 PM

#

I suppose but meh, it's not too important

north mist Dec 15, 2023, 10:32 PM

#

though, I have another suggestion, then

#

how about sorting it alphabetically?

#

that way it'd be way easier to find what you're looking for

#

without having to ctrl+f everything

#

(the top level fields I mean, at least)

upbeat hare Dec 15, 2023, 10:36 PM

#

I suppose thats possible yeah

#

Not too hard as well

#

Except prefab/asset address will always be on top

north mist Dec 15, 2023, 10:36 PM

#

yeah, that's fine

upbeat hare Dec 15, 2023, 10:36 PM

#

And the resources/modules always on the bottom

north mist Dec 15, 2023, 10:36 PM

#

and that makes sense

#

though I also wonder if it should be more like, the few fields that are absolutely necessary being on top, and then the rest sorted

#

(I know I'm complicating this, sorry lol)

upbeat hare Dec 15, 2023, 10:38 PM

#

I getcha

#

I'll see what I can do

#

Dnd now tho

north mist Dec 15, 2023, 10:38 PM

#

have fun

north mist Dec 16, 2023, 3:03 AM

#

Alright so I basically wrote the code for what we were talking about, but of course, it's not going to be as simple as I thought (and honestly it was stupid of me to completely forget this stuff)

#

The icon part is simple, but the mesh isn't

#

Because there is no guarantee how many meshes and in what hierarchy there will be in any prefab

#

Unless we're talking just completely replacing the entire game object

#

Then it might be doable with just removing its CorePartData and all PartComponentModules and replacing them with the proper ones

#

I'll continue working on it tomorrow, gotta go sleep now

upbeat hare Dec 16, 2023, 3:07 AM

#

I said prefabaddress for a reason, its just completely changing out the prefab gameobject

north mist Dec 16, 2023, 3:13 AM

#

I mean that doesn't really imply changing out the whole object, since the prefab address is the only way to access the new meshes and textures, but yeah, gotcha

upbeat hare Dec 16, 2023, 2:04 PM

#

@north mist instead of sorting the fields, I instead injected the headers into the file

📎 message.patch

north mist Dec 16, 2023, 2:04 PM

#

oh that's awesome!

#

is the partName field filled in automatically from the @new("...")?

upbeat hare Dec 16, 2023, 2:06 PM

#

Yes

north mist Dec 16, 2023, 2:06 PM

#

even better, less room for mistakes

upbeat hare Dec 16, 2023, 2:06 PM

#

mhm

north mist Dec 16, 2023, 2:07 PM

#

I just finished lunch so I'll get back to the game object stuff

#

seems like changing the module manager to internal caused some exceptions

#

[Error  :Patch Manager] System.MissingMethodException: Method not found: void PatchManager.Shared.Modules.ModuleManager.PreLoadAll()
  at SpaceWarp.Patching.LoadingActions.PreInitializeModAction.DoAction (System.Action resolve, System.Action`1[T] reject) [0x00050] in <39f0697ba36b449aa19b27f13be09abd>:0

#

then there's also this one

MissingMethodException: Method not found: void PatchManager.Shared.Modules.IModule.BindConfiguration(SpaceWarp.API.Configuration.IConfigFile)
UnityEngine.GameObject:Internal_AddComponentWithType(GameObject, Type)
UnityEngine.GameObject:AddComponent(Type)
BepInEx.Bootstrap.Chainloader:DMD<BepInEx.Bootstrap.Chainloader::Start>()
UnityEngine.Application:.cctor()
UnityEngine.InputSystem.InputManager:InitializeData()
UnityEngine.InputSystem.InputManager:Initialize(IInputRuntime, InputSettings)
UnityEngine.InputSystem.InputSystem:InitializeInPlayer(IInputRuntime, InputSettings)
UnityEngine.InputSystem.InputSystem:.cctor()

#

uhh

#

now I just completely deleted the PM folders from my game folder, rebuilt, and I'm somehow getting completely different exceptions that freeze the game loading

#

what is happening

#

lifesupport

upbeat hare Dec 16, 2023, 2:22 PM

#

north mist seems like changing the module manager to internal caused some exceptions

Just undo it then?

north mist Dec 16, 2023, 2:22 PM

#

[Error  :Patch Manager] System.TypeInitializationException: The type initializer for 'PatchManager.SassyPatching.Execution.Universe' threw an exception. ---> System.ArgumentException: An item with the same key has already been added. Key: list.map
  at System.Collections.Generic.Dictionary`2[TKey,TValue].TryInsert (TKey key, TValue value, System.Collections.Generic.InsertionBehavior behavior) [0x0015a] in <eef08f56e2e042f1b3027eca477293d9>:0
  at System.Collections.Generic.Dictionary`2[TKey,TValue].Add (TKey key, TValue value) [0x00000] in <eef08f56e2e042f1b3027eca477293d9>:0
  at System.Linq.Enumerable.ToDictionary[TSource,TKey,TElement] (System.Collections.Generic.IEnumerable`1[T] source, System.Func`2[T,TResult] keySelector, System.Func`2[T,TResult] elementSelector, System.Collections.Generic.IEqualityComparer`1[T] comparer) [0x0009e] in <de4a1a1490a74771a34fee0d1d586658>:0
  at System.Linq.Enumerable.ToDictionary[TSource,TKey,TElement] (System.Collections.Generic.IEnumerable`1[T] source, System.Func`2[T,TResult] keySelector, System.Func`2[T,TResult] elementSelector) [0x00000] in <de4a1a1490a74771a34fee0d1d586658>:0
  at PatchManager.SassyPatching.Execution.ManagedPatchLibrary..ctor (System.Reflection.IReflect libraryClass) [0x00008] in E:\KSP Stuff\KSP 2 Modding\Mods\PatchManager\src\PatchManager.SassyPatching\Execution\ManagedPatchLibrary.cs:14
  at PatchManager.SassyPatching.Execution.Universe..cctor () [0x000fa] in E:\KSP Stuff\KSP 2 Modding\Mods\PatchManager\src\PatchManager.SassyPatching\Execution\Universe.cs:56
   --- End of inner exception stack trace ---
  at (wrapper managed-to-native) System.Object.__icall_wrapper_mono_generic_class_init(intptr)
  at PatchManager.Core.Assets.PatchingManager.GenerateUniverse () [0x0004a] in E:\KSP Stuff\KSP 2 Modding\Mods\PatchManager\src\PatchManager.Core\Assets\PatchingManager.cs:41
  at PatchManager.Core.CoreModule.PreLoad () [0x00007] in E:\KSP Stuff\KSP 2 Modding\Mods\PatchManager\src\PatchManager.Core\CoreModule.cs:74
  at PatchManager.Shared.Modules.ModuleManager.PreLoadAll () [0x00018] in E:\KSP Stuff\KSP 2 Modding\Mods\PatchManager\src\PatchManager.Shared\Modules\ModuleManager.cs:67
  at PatchManager.PatchManagerPlugin.OnPreInitialized () [0x00001] in E:\KSP Stuff\KSP 2 Modding\Mods\PatchManager\src\PatchManager\PatchManagerPlugin.cs:71
  at SpaceWarp.Patching.LoadingActions.PreInitializeModAction.DoAction (System.Action resolve, System.Action`1[T] reject) [0x00050] in <39f0697ba36b449aa19b27f13be09abd>:0

[Error  : Unity Log] NullReferenceException: Object reference not set to an instance of an object
Stack trace:
PatchManager.Core.Assets.PatchingManager.RebuildAllCache (System.Action resolve, System.Action`1[T] reject) (at E:/KSP Stuff/KSP 2 Modding/Mods/PatchManager/src/PatchManager.Core/Assets/PatchingManager.cs:322)
KSP.Game.Flow.GenericFlowAction.DoAction (System.Action resolve, System.Action`1[T] reject) (at <483cd9805b7642b5be13e081b9a5d1b4>:0)
KSP.Game.Flow.FlowAction.Do (System.Action`1[T] resolve, System.Action`2[T1,T2] reject) (at <483cd9805b7642b5be13e081b9a5d1b4>:0)
(wrapper dynamic-method) KSP.Game.Flow.SequentialFlow.DMD<KSP.Game.Flow.SequentialFlow::NextFlowAction>(KSP.Game.Flow.SequentialFlow)
KSP.Game.Flow.SequentialFlow.Update () (at <483cd9805b7642b5be13e081b9a5d1b4>:0)

#

don't think these are caused by that change

upbeat hare Dec 16, 2023, 2:22 PM

#

north mist ``` [Error :Patch Manager] System.TypeInitializationException: The type initial...

that first error implies its iterating over every type twice

#

Or that a DLL is being loaded twice

north mist Dec 16, 2023, 2:25 PM

#

I'll just manually bisect the commits in dev, since main works fine

upbeat hare Dec 16, 2023, 2:25 PM

#

No wait

#

that first error is me being dumb

#

See the error here?

north mist Dec 16, 2023, 2:25 PM

#

oh lol

upbeat hare Dec 16, 2023, 2:27 PM

#

The second error is because I have to create the Universe later than the loading actions...

#

That's going to be an annoying one to fix

#

let me fix these 2 and you can do your stuff

north mist Dec 16, 2023, 2:27 PM

#

alright, thanks

upbeat hare Dec 16, 2023, 2:28 PM

#

Wait what

#

PreLoad is called in preinitialize

#

Which is before any loading actions

#

This is the line throwing a null reference exception

#

The Universe is created in PreLoad

#

Which doesn't finish

#

because of the other error

north mist Dec 16, 2023, 2:30 PM

#

makes sense

upbeat hare Dec 16, 2023, 2:30 PM

#

I fixed the other error

#

so it should work now

north mist Dec 16, 2023, 2:30 PM

#

got it, will try

#

yep works fine now, thanks

upbeat hare Dec 16, 2023, 2:46 PM

#

By the way this is what I've added to the KSP2UnityTools UI

#

Y'know all we need to add to patch manager is a png loader and an fbx loader ... and uhh yeah, suddenly we have unityless parts mods

north mist Dec 16, 2023, 2:54 PM

#

yeaaah but I'd rather avoid that

upbeat hare Dec 16, 2023, 2:55 PM

#

Yeah, and also like loading fbx at runtime seems to require a paid plugin

north mist Dec 16, 2023, 2:55 PM

#

though I'm thinking it may be worth it trying to somehow benchmark how much of a difference in loading times it would be, and how much of a difference our TextAsset cache already is compared to pure addressables

north mist Dec 16, 2023, 2:57 PM

#

upbeat hare Yeah, and also like loading fbx at runtime seems to require a paid plugin

tbh that probably shouldn't be the biggest issue, we could just support .obj which should be trivial to convert fbx to (for any interested modders)

#

if it came down to it

upbeat hare Dec 16, 2023, 2:57 PM

#

~~theres also .mu~~

#

But yeah we could support .obj

#

The problem then is loading all the materials and such

north mist Dec 16, 2023, 2:58 PM

#

me, an artist:

#

we should support Paint 3D's .glb

#

munley

north mist Dec 16, 2023, 2:59 PM

#

upbeat hare The problem then is loading all the materials and such

yeaah that would be the biggest pain point

upbeat hare Dec 16, 2023, 3:03 PM

#

north mist yeaah that would be the biggest pain point

All I can think of for that is having a json file to define all the materials for each mesh, with the texture file locations and whatever

north mist Dec 16, 2023, 3:05 PM

#

I guess that could work

upbeat hare Dec 16, 2023, 3:06 PM

#

But ... text asset loading is leagues faster than image/model assets if I had to guess

north mist Dec 16, 2023, 3:06 PM

#

but if we were to do this, I would still rather have it in a specialized "dev" plugin

#

that would make it clear it's not meant for production use, by something like adding a watermark

#

or, if it is possible, only allowing it to run with debug mode enabled

#

I think that would be good enough to prevent any misuse

#

it would give devs a way to do quick iteration without opening Unity

#

and then they'd just have to open Unity and rebuild addressables once per release

upbeat hare Dec 16, 2023, 3:08 PM

#

Ill be honest i almost never use debug mode when developing mods

#

Its too much a hassle

north mist Dec 16, 2023, 3:09 PM

#

I just always have it enabled on all my game instances lmao

upbeat hare Dec 16, 2023, 3:09 PM

#

And having multiple installs takes too much space

north mist Dec 16, 2023, 3:19 PM

#

ok icons are working, time to test the prefabs

upbeat hare Dec 16, 2023, 3:19 PM

#

That quick munix

#

goddamn

north mist Dec 16, 2023, 3:20 PM

#

tbh the way I did it was extremely easy

#

at first I was trying to force the custom subclasses of PartCore/PartData into the game systems but it's honestly not worth all the effort of copying all fields from the original objects to the new ones, etc., so I just used a regex to grab the new values directly from JSON and store them in internal dictionaries per partName

upbeat hare Dec 16, 2023, 3:22 PM

#

north mist at first I was trying to force the custom subclasses of PartCore/PartData into t...

I mean that latter thing is basically what I was thinking

#

Or instead just reading the json file, storing it into a jObject, checking if it has the key or not

#

and if it doesn't then just default the value to the partName.prefab/partName.png

north mist Dec 16, 2023, 3:30 PM

#

this is interesting lol

#

not sure I've seen it before

#

the loading screen disappears like 2 seconds before the loading bar

upbeat hare Dec 16, 2023, 3:30 PM

#

I've seen it before

north mist Dec 16, 2023, 3:38 PM

#

ughhh of course it's full of messy async stuff that's hard to patch

#

(the prefab loading)

upbeat hare Dec 16, 2023, 3:39 PM

#

aaaaaaaaaaaaaaaaaaaaaaaaa

north mist Dec 16, 2023, 3:40 PM

#

I feel like 90% of our issues with Patch Manager would be solved if they just had a AssetProvider.LoadSync(...) method lol

#

but that's not really on them, it's mostly the way the Addressables API is made

upbeat hare Dec 16, 2023, 3:49 PM

#

Yeahh

#

Also once you are done with this, I am going to create a custom adapter for Data_Engine such that you can PM index the engine modes a lot easier

#

As in you can index the engine modes at the top level just like a module data

#

Meaning the array here, just becomes a +Engine ... (or +(mode_id))

📎 old.patch

#

And I will reflect that in KSP2UnityTools as well

north mist Dec 16, 2023, 3:55 PM

#

sounds good

upbeat hare Dec 16, 2023, 3:56 PM

#

It's mostly cuz it irked me how hard it would be to patch engine modes normally

#

Anyways, I am going to go for now, ping me once you get prefab overriding working and its commited so I can work on this

north mist Dec 16, 2023, 3:57 PM

#

I mean you probably can, I'm working in a separate branch and I don't think there should be any conflicts

upbeat hare Dec 16, 2023, 3:57 PM

#

Alright, I still need to go for a bit tho

upbeat hare Dec 16, 2023, 5:26 PM

#

Alright I created the data_engine adapter

#

now I am going to test it with that crazy part I made using KSP2UnityTools and see how it goes

north mist Dec 16, 2023, 5:28 PM

#

I need a nap because I slept for like 4 hours last night, but I'll try to take a look at the issue with the materials after that

upbeat hare Dec 16, 2023, 5:28 PM

#

(just going to test the generated json file)

#

but I need to grab food first

upbeat hare Dec 16, 2023, 6:43 PM

#

📎 Internal_name.patch

#

There we go, with the engine mode as well

#

Bro what

north mist Dec 16, 2023, 7:04 PM

#

That's an interesting one lol

upbeat hare Dec 16, 2023, 7:05 PM

#

I forgot to add negation for integers into the code

#

god damn, whats up with this aaaaa

#

I see now

#

ffs

#

I'm just going to skip over all null fields

#

I got it to generate correctly!

📎 message.json

upbeat hare Dec 16, 2023, 8:04 PM

#

This next patch manager update is gonna be a banger

north mist Dec 16, 2023, 8:05 PM

#

sweet!

upbeat hare Dec 16, 2023, 8:06 PM

#

Now I think my next step for documentation is documenting the entirety of parts_data and all the modules

#

I might generate a script to autodocument the modules

#

And then do manual editing of data_engine

north mist Dec 16, 2023, 8:07 PM

#

wouldn't that be better on the regular wiki, with a link to it in the PM docs?

upbeat hare Dec 16, 2023, 8:07 PM

#

I want to document them in PM terms rather than C# terms

#

That means describing it in terms of classes and elements and PM types

north mist Dec 16, 2023, 8:08 PM

#

I guess, but it sounds like something that could be very useful also for people who don't care about using PM at all and just want to make a part in Unity

#

since the information is exactly the same, just structured slightly differently

upbeat hare Dec 16, 2023, 8:10 PM

#

It isnt exactly the same
Because im more so documenting the structure of the json file and abstract pm object itself

#

Whatever its mostly gonna be auto documented anyways

upbeat hare Dec 16, 2023, 8:26 PM

#

Also before I release the next update, I want to add a tech tree ruleset

north mist Dec 16, 2023, 8:27 PM

#

one thing I'm kinda worried about is the visual side

#

like, it doesn't look like there's much room to add any custom nodes

#

we'll probably have to implement some rescaling

upbeat hare Dec 16, 2023, 8:28 PM

#

I hope that they made those visuals procedural

north mist Dec 16, 2023, 8:28 PM

#

I really hope so too

#

but something tells me that it's all hardcoded

upbeat hare Dec 16, 2023, 8:28 PM

#

Thats gonna be fun to change if so

#

And then we may want to add more tiers as well

#

So we might have to add a scrollbar to the top

#

Or like a [<] and [>] button set

north mist Dec 16, 2023, 8:29 PM

#

I think that should be relatively easier, since there already is a scrollbar for it on the bottom

upbeat hare Dec 16, 2023, 8:29 PM

#

Alright then

#

I just hope that we dont have to add our own procedural ui code into patch manager aaaaaa

north mist Dec 16, 2023, 8:30 PM

#

at that point it'd probably be better as a separate mod tbh

#

which registers its own ruleset for PM

upbeat hare Dec 16, 2023, 8:30 PM

#

Yeah

#

Something like Tech Tree Patcher

#

Still one of my first things to do after the update

#

And maybe ill make a probe start mod for it

north mist Dec 16, 2023, 8:34 PM

#

hell yeah, that's always good to have

#

I honestly actually really want to give a try to some sort of a story-driven mod utilizing the missions framework

upbeat hare Dec 16, 2023, 8:35 PM

#

Ahh missions

#

Im going to have to add that to PM as well

north mist Dec 16, 2023, 8:35 PM

#

yeaah

upbeat hare Dec 16, 2023, 8:36 PM

#

Ill do that after tech

#

More important to do tech

#

Imo

north mist Dec 16, 2023, 8:36 PM

#

yeah, definitely

#

custom missions will be very useful for planet packs

#

but that seems like something with still a long way to go

#

though I think we should focus on planets after getting all the science stuff done

#

since it really is like the biggest modding part of KSP after parts

upbeat hare Dec 16, 2023, 8:37 PM

#

Yeahh

upbeat hare Dec 16, 2023, 11:08 PM

#

Am writing the autodocumenter atm

#

I think this will be useful for this at least

upbeat hare Dec 16, 2023, 11:44 PM

#

Wtf is this

#

screw it, I'm going to create a spacewarp mod with a document button

#

that will work

upbeat hare Dec 17, 2023, 1:05 AM

#

ALright, guess I'll have to do this another way

#

@north mist here's an example of autogeneration

#

https://pm.kerbal.wiki/enginemode.html

Patch Manager Help

EngineMode | Patch Manager

north mist Dec 17, 2023, 1:19 AM

#

damn, that's cool

upbeat hare Dec 17, 2023, 1:21 AM

#

north mist damn, that's cool

And a lot more manual work than you would think :p

#

Sorting through 106 files and touching them up when they need them is a bit of work

#

As some stuff wasn't properly grabbed or whatever

north mist Dec 17, 2023, 3:38 PM

#

I added doc comments to all the public stuff that didn't have them so that PM now builds with 0 warnings

#

however, the new Data_Engine selectable is broken

#

📎 message.txt

#

with the same exception popping up multiple times for every single engine part

upbeat hare Dec 17, 2023, 3:41 PM

#

wtf did I not fix that issue

#

@north mist try now

#

I forgot to push the fix

north mist Dec 17, 2023, 3:42 PM

#

ahh

#

will try

#

yep that got rid of it

#

thanks 👍

upbeat hare Dec 17, 2023, 3:47 PM

#

Yeah, I'm just a dumbass

#

Need to remember to push stuff

north mist Dec 17, 2023, 3:49 PM

#

I'm happy now, all green

#

lol

upbeat hare Dec 17, 2023, 11:02 PM

#

Have to update my autogen as it was calling all enums integers

upbeat hare Dec 18, 2023, 12:19 AM

#

@north mist what think you?
https://pm.kerbal.wiki/part-reference.html

Patch Manager Help

Part Reference | Patch Manager

#

Yes I know it needs completion, but I don't know what every field does

north mist Dec 18, 2023, 12:21 AM

#

can I just ask what a class selector for a simple type field like partName do?

#

just store the content of partName in $current/$$?

upbeat hare Dec 18, 2023, 12:22 AM

#

yes

#

But basically the point of class selectors are to check if something has an element or field

#

It's more useful in generic json contexts I suppose

north mist Dec 18, 2023, 12:22 AM

#

yeah gotcha

upbeat hare Dec 18, 2023, 12:23 AM

#

But like I updated the type hints some more

#

north mist Dec 18, 2023, 12:23 AM

#

oh nice, that's cool

upbeat hare Dec 18, 2023, 12:24 AM

#

This is going to be fun to update come 0.2.0

north mist Dec 18, 2023, 12:24 AM

#

LOABE
which has been broken for months

#

nooooooooo

upbeat hare Dec 18, 2023, 12:24 AM

#

I thought it worked still

#

shows how much I know

north mist Dec 18, 2023, 12:24 AM

#

nope

upbeat hare Dec 18, 2023, 12:24 AM

#

Well shit

#

we have to write our own then don't we

north mist Dec 18, 2023, 12:25 AM

#

I mean @maiden wraith said he would have time for modding in the last two weeks of December so let's pray

upbeat hare Dec 18, 2023, 12:26 AM

#

SuikaPray

north mist Dec 18, 2023, 12:30 AM

#

all I'm asking for is an update for LOABE and for the plume game objects for Merlin and Raptor in SORRY

#

upbeat hare Dec 19, 2023, 7:08 PM

#

:science #tNode_1v_start {
    UnlockedPartsIDs: +[
        "KLSS_life_support_tank_1v_1x1",
        "KLSS_life_support_tank_2v_1x1",
        "KLSS_food_tank_2v_1x2",
        "KLSS_water_tank_2v_1x2",
        "KLSS_oxygen_tank_2v_1x2",
        "KLSS_food_pack_0v_radial",
        "KLSS_food_pack_0v_radial",
        "KLSS_water_tank_0v_radial",
        "KLSS_oxygen_tank_0v_radial",
        "KLSS_food_pack_2v_radial",
        "KLSS_water_tank_2v_radial",
        "KLSS_oxygen_tank_2v_radial",
        "KLSS_greenhouse_2v_long",
        "KLSS_composter_2v_short"
    ];
}

Copying here, syntax for adding your part to the tech tree

upbeat hare Dec 19, 2023, 7:39 PM

#

#🔴mod-dev message

#

This inline with PMs scope I presume?

north mist Dec 19, 2023, 7:40 PM

#

yeah, makes sense

#

I just hope the way they did the coordinates scales well with resolution

upbeat hare Dec 19, 2023, 7:44 PM

#

Gods i love that we made this mod

#

It makes me doing simple patch mods so much easier

#

An entire programming language to edit the tech tree lol

north mist Dec 20, 2023, 1:33 AM

#

it also breaks the loading of the SpaceWarp and the whole game

upbeat hare Dec 20, 2023, 1:35 AM

#

north mist it also breaks the loading of the SpaceWarp and the whole game

It worked for

#

me

#

aaaaaaaaaaaaaaaaaaa

#

Okay, I can at least fix that bug

north mist Dec 20, 2023, 1:40 AM

#

I was going to ask why the version number of the DLL is 0.4.0.0

#

and immediately answered my own question

#

it's exactly because of the template issue I realized just a bit ago in SpaceWarp

north mist Dec 20, 2023, 1:41 AM

#

north mist it also breaks the loading of the SpaceWarp and the whole game

and nevermind, that was an issue on my side

#

PM works fine

upbeat hare Dec 20, 2023, 1:43 AM

#

Alright, well, I fixed that error anyways

#

That wouldn't break anything anyways lol

#

@north mist can you add gh actions to this as well :3

#

Redid the science stuff as well to handle tech node deletion, will be working more on this tomorrow in tandem with wmcc

upbeat hare Dec 20, 2023, 12:23 PM

#

Alright, I'm going to add the mission stuff and release a 0.6.0 soon, such that I can get started on wheres my crew capsule (I want to move the space walk mission later and add a lunar impactor mission in its place)

upbeat hare Dec 20, 2023, 1:24 PM

#

The sheer amount of wrangling for missions I have to do

upbeat hare Dec 20, 2023, 1:48 PM

#

So I figured that I'm going to make the element type/name on mission stages _{id}

#

So that it's easier to index them and such

north mist Dec 20, 2023, 1:51 PM

#

Makes sense

upbeat hare Dec 20, 2023, 2:00 PM

#

Aaaaaaaaaa this field is never used so I have to guess at it's usage from code

#

Ohh its to create more complex missions

#

that have different branches

#

but like they are only used in the tutorials\

#

I'll ignore them for now and add them later

#

mostly because thats going to be a complex thing to add

upbeat hare Dec 20, 2023, 2:21 PM

#

Also I'll likely release this at the same time as I release WMCC, because WMCC is going to be my test for it

#

aaaaaaaaaa

#

i'm about to just disable syntax validation on this

#

For the moment it doesn't matter

#

I'll fix it but for some reason sinons language server hates me

#

ohh its because of dumb shit again where I have to rename something in the grammar

#

@frail star can you accept my PR and update the language server extension

#

Pretty please

frail star Dec 20, 2023, 4:00 PM

#

🫡

upbeat hare Dec 20, 2023, 4:04 PM

#

frail star 🫡

One thing, I didn't update the version in the package itself, I likely shouldve

frail star Dec 20, 2023, 4:05 PM

#

i can do it, what do you want it to be

upbeat hare Dec 20, 2023, 4:06 PM

#

frail star i can do it, what do you want it to be

just bump up to the next 0.x.0 version

frail star Dec 20, 2023, 4:06 PM

#

sure

#

0.6.0 then

#

and, should i push it to marketplace?

upbeat hare Dec 20, 2023, 4:07 PM

#

yes please

frail star Dec 20, 2023, 4:11 PM

#

oh never mind :P

#

it's 0.7.0

#

i guess

#

done!

upbeat hare Dec 20, 2023, 4:19 PM

#

frail star done!

how long does it take the marketplace to realize there is an update

frail star Dec 20, 2023, 4:20 PM

#

a couple minutes

#

accoridng to them

#

upbeat hare Dec 20, 2023, 4:20 PM

#

alright

#

i'll wait a bit to write my patches then

frail star Dec 20, 2023, 4:21 PM

#

it shows 0.7 if i look it up

#

https://marketplace.visualstudio.com/items?itemName=Sinon.patcherls

Patcher Language Server - Visual Studio Marketplace

Extension for Visual Studio Code - Language server for KSP2 Patcher Manager

upbeat hare Dec 20, 2023, 4:23 PM

#

@frail star did you rerun the npm compile step????

#

because the highlighting is correct

#

but the error messages are wrong

frail star Dec 20, 2023, 4:23 PM

#

:/

upbeat hare Dec 20, 2023, 4:23 PM

#

frail star Dec 20, 2023, 4:24 PM

#

lol

#

i should add the grammar to the vsce prepublish step

upbeat hare Dec 20, 2023, 4:24 PM

#

add grammar and compiler to it please

frail star Dec 20, 2023, 4:24 PM

#

yeah it has the compiler

#

just not the grammar

upbeat hare Dec 20, 2023, 4:25 PM

#

yeahh, the grammar might be worth it, esp after I sanitized the grammar to not cause errors

frail star Dec 20, 2023, 4:26 PM

#

could you give me that patch quickly, to see if it worked?

#

also, what do you think about adding hover-over descriptions to the builtins

upbeat hare Dec 20, 2023, 4:30 PM

#

@create-config  "wmcc-unlocks", "tNode_1v_start": [
    "probe_0v_spherical_electricity", /* stayputnik tNode_0v_electronics */
    "storage_0v_battery_electricity_radial",
    "antenna_0v_16",
    "antenna_0v_16s",
    "engine_0v_methalox_spark", /* tNode_0v_rockets_01 */
    "fueltank_0v_inline_methalox",
];

@define-stage "wmcc_patch": @global;

@stage "wmcc_patch"
:tech {

}

upbeat hare Dec 20, 2023, 4:30 PM

#

frail star also, what do you think about adding hover-over descriptions to the builtins

Also, that would be nice

frail star Dec 20, 2023, 4:30 PM

#

#

works for me now

upbeat hare Dec 20, 2023, 4:30 PM

#

let me get you a list of builtins and their descriptions

frail star Dec 20, 2023, 4:31 PM

#

ill push + publish

#

should make it a webhook

#

push to main = publish

upbeat hare Dec 20, 2023, 4:35 PM

#

Builtins I'd want hover for

@use - Import a library, to import multiple libraries from a mod do mod:*
@function - Define a function to be used in your patches
@mixin - Define a mixin (A reusable selection block)
@set - Set the value of the object being modified
@merge - Merge a dictionary with the object being modified
@delete - Either delete the object being modified, or the variable this is being set to
@require - Perform a boolean expression on the loaded mods to conditionally enable a patch
@stage - Set the stage that a patch is running in
@define-stage - Define a stage to be used with the `@stage` builtin
@include - Include a mixin in your patch
@patch - Define a list of labels to be patched outside of those defined by rulesets
@new - Create a new instance of an object that a ruleset matches
@before - Make this stage run before another stage if that other stage exists
@after - Make this stage run after another stage if that other stage exists
@global - Define this stage to be a global stage (running after all mod stages)
@create-config - Create a config to be used within patches
@update-config - Update a previously created config

#

@frail star

frail star Dec 20, 2023, 4:36 PM

#

understood

upbeat hare Dec 20, 2023, 4:37 PM

#

and tell me when you have this update out so I can use it lol

frail star Dec 20, 2023, 4:37 PM

#

ok its all done

#

published 0.7.1, which has the correct grammar

frail star Dec 20, 2023, 4:38 PM

#

upbeat hare and tell me when you have this update out so I can use it lol

tonight probably, i have to go to my last day of class rn

upbeat hare Dec 20, 2023, 4:38 PM

#

gotcha

frail star Dec 20, 2023, 4:38 PM

#

i have a good idea of how to do it

upbeat hare Dec 20, 2023, 4:42 PM

#

Damn patch manager has a lot of libraries

frail star Dec 20, 2023, 4:46 PM

#

looks nice lol

upbeat hare Dec 20, 2023, 4:47 PM

#

frail star looks nice lol

Also, could you add hovers for these rulesets as well

:parts -> Patch the parts in the game (label: parts_data)
:resources -> Patch the games resource definitions (label: resources)
:missions -> Patch the missions in the game (label: missions)
:science -> Patch the tech tree (label: techNodeData)
:json -> Patch any json asset in the game

frail star Dec 20, 2023, 4:47 PM

#

yeah

#

so i kinda have two options here

#

either you write an official langref file, and i parse it to get that data.
or i just embed a langref into the project

upbeat hare Dec 20, 2023, 4:48 PM

#

Hmmm, alright

#

I'll have to figure that one out

frail star Dec 20, 2023, 5:12 PM

#

just saying, i mean a literal langref.html

upbeat hare Dec 20, 2023, 5:19 PM

#

frail star just saying, i mean a literal `langref.html`

I have no clue what that much means in the context of vscode here

frail star Dec 20, 2023, 5:20 PM

#

it has nothing to do with vscode at all

#

i think it'd be best for all of us, if we had a official langref file

upbeat hare Dec 20, 2023, 5:20 PM

#

I mean I have https://pm.kerbal.wiki

#

Which has a full syntax reference

frail star Dec 20, 2023, 5:21 PM

#

langrefs are usually written in pure html, so that they can be parsed super easily

upbeat hare Dec 20, 2023, 5:21 PM

#

aaaaa

frail star Dec 20, 2023, 5:21 PM

#

here's an example: https://opensource.apple.com/source/lldb/lldb-179.1/llvm/docs/LangRef.html

LLVM Assembly Language Reference Manual

LLVM Assembly Language Reference Manual.

upbeat hare Dec 20, 2023, 5:21 PM

#

I'll work on that at some point, I have other stuff I'm working on rn

frail star Dec 20, 2023, 5:22 PM

#

and then the actual langref: https://opensource.apple.com/source/lldb/lldb-179.1/llvm/docs/LangRef.html.auto.html

#

you would parse this ^ to get descriptions and such

north mist Dec 21, 2023, 1:02 AM

#

@upbeat hare pretty sure this was literally the whole fix

#

when you pull it, just delete the old build and dist folders to get rid of all the old stuff and restore

#

if you encounter the issues again, lmk

upbeat hare Dec 21, 2023, 1:03 AM

#

Aight

#

Anyways, I am currently cooking up a new tech tree

#

I'm going to reuse old nodes, but I'm likely going to rename them

#

or rather reorganize them I suppose

north mist Dec 21, 2023, 1:05 AM

#

that makes me think it would be really nice if tech trees + missions were something that the user can choose at the start of the campaign and be able to have multiple campaigns with different ones

upbeat hare Dec 21, 2023, 1:05 AM

#

that'd be really hard

#

at least on the tech tree part

#

because there is no master tech tree definition

north mist Dec 21, 2023, 1:06 AM

#

I mean, we could do what we did with the PrefabAddress and IconAddress fields

#

and add a field for the ID of the tech tree to the nodes

#

and then in code check for it

upbeat hare Dec 21, 2023, 1:07 AM

#

I guess yeah

north mist Dec 21, 2023, 1:07 AM

#

well actually no

#

at least not that simple

#

since some would be modifications of the stock ones, and some would be new

#

we'd have to only allow to make duplicates instead of edits

#

that way the stock tree could remain intact and mods could reuse nodes from it by duplication or something

#

yeah this is more difficult than I first thought

upbeat hare Dec 21, 2023, 1:09 AM

#

we might just have to design a master tech tree definition that is an asset that defines all the nodes in a tech tree

#

It's just a big list of nodes

north mist Dec 21, 2023, 1:10 AM

#

yeah, that'd be a better way to go about it

upbeat hare Dec 21, 2023, 1:11 AM

#

we might also want to actually define node relations there as well

#

and I suppose positions aaaa

#

this is a duplication of information, but we need these multiple definitons

upbeat hare Dec 21, 2023, 8:28 PM

#

@north mist I made a PR

#

Also the fix (I think)

:missions #KSP2Mission_Secondary_Kerbin_Experiment > missionStages > _0 > ConditionSet > PropertyCondition {
  @if ($$Inputstring == "collector_1v_science_general") {
    isInput: true;
  } @else {
    RequireCurrentValue: true;
  }
}

upbeat hare Dec 21, 2023, 8:32 PM

#

upbeat hare Also the fix (I think) ```scss :missions #KSP2Mission_Secondary_Kerbin_Experimen...

To put into community fixes

#

tho this will add a dependency on patch manager

north mist Dec 21, 2023, 10:15 PM

#

by the way, I've been seeing lots of requests for some very simple, single-file patches by people who don't care about making a full mod, they just want to tweak some stuff in their install

#

maybe we could "relax" the swinfo.json requirements

upbeat hare Dec 21, 2023, 10:15 PM

#

aaaaaaaaa, it uses those to determine a lot of stuff

north mist Dec 21, 2023, 10:16 PM

#

I was kinda thinking we could mostly autogenerate it

#

and just add some top-level statements for things like version and ID

#

to the patch itself

#

that would be required if there's no swinfo

#

to enable single-file patches

upbeat hare Dec 21, 2023, 10:19 PM

#

north mist and just add some top-level statements for things like version and ID

that's certainly a possibility, but the patch file name given depends on the ID aaaaaaaaa

#

I'll look into it

trail cradle Dec 21, 2023, 10:27 PM

#

is it possible to make jet engines produce more thrust

upbeat hare Dec 21, 2023, 10:27 PM

#

It is

trail cradle Dec 21, 2023, 10:33 PM

#

one word. How?

upbeat hare Dec 21, 2023, 10:34 PM

#

Can you give me a minute please, I am currently quite busy and focused on fixing a bug

trail cradle Dec 21, 2023, 10:34 PM

#

figured it out

north mist Dec 22, 2023, 2:30 PM

#

one tiny thing

#

could we do a bit of log cleaning up?

#

#

and make stuff like this debug logs rather than info logs?

upbeat hare Dec 22, 2023, 2:30 PM

#

Ah yeah

#

sure

north mist Dec 22, 2023, 2:30 PM

#

the logs are getting unbearably long with so many mods logging every small thing tbh

#

it's fine in debug

#

but info is a bit much

desert stirrup Dec 23, 2023, 9:07 PM

#

Are experiments ready to be patched with PM? I see there's ExperimentSelectable inside the Science folder.

upbeat hare Dec 23, 2023, 9:09 PM

#

desert stirrup Are experiments ready to be patched with PM? I see there's ExperimentSelectable ...

Yes

desert stirrup Dec 23, 2023, 9:10 PM

#

And how is it done (I didn't dig into it yet)? Do you add experiments to parts?

upbeat hare Dec 23, 2023, 9:10 PM

#

You have to define an experiment definition

desert stirrup Dec 23, 2023, 9:10 PM

#

ok, I've seen that part

upbeat hare Dec 23, 2023, 9:10 PM

#

and add a Module_ScienceExperiment to parts

desert stirrup Dec 23, 2023, 9:11 PM

#

ah there's a module for science experiments, nice

#

I'll look into it then

#

I have to see how to trigger them also. I'd like for Orbital Survey (mod) to trigger an experiment at given mapping percentages (like 25%, 50%, 75% and 100%)

#

I wish they named their "Orbital Survey" experiment differently sigh

upbeat hare Dec 23, 2023, 9:13 PM

#

Just name yours orbital scan

desert stirrup Dec 23, 2023, 9:13 PM

#

yeah, was thinking exactly that

#

and I'd like to add survey missions also, but later, first the experiment

upbeat hare Dec 24, 2023, 1:54 PM

#

I should add a list.slice method

#

so I have the whole set of map,filter,reduce,sort,slice

desert stirrup Dec 24, 2023, 5:28 PM

#

@upbeat hare, I'm trying to replicate what you've shown, but my experiment and science module isn't attached to parts. Don't know what I'm doing wrong. Maybe something in the definition of the experiment.
Experiment:

@new("orbital_survey_visual_mapping")
:experiments {
    DisplayName: "OrbitalSurvey/VisualMapping/DisplayName";
    DisplayRequirements: "OrbitalSurvey/VisualMapping/DisplayRequirements";
    ExperimentType: "Both";
    //DataFlavorDescriptions: "Data flavor descriptions text";
    //SampleFlavorDescriptions: "Sample flavor descriptions text";
    DataReportDisplayName: "OrbitalSurvey/VisualMapping/DataReportDisplayName";
    SampleReportDisplayName: "OrbitalSurvey/VisualMapping/SampleReportDisplayName";
    DataValue: 6;
    SampleValue: 14;
    TransmissionSize: 150;
    RequiresEVA: false;
}

Part patch:

:parts #antenna* +Module_ScienceExperiment +Data_ScienceExperiment {
    ExperimentsStandings: [];
    LastKnownValidSituation: {
        CelestialBodyScalar: 0.0,
        ScienceRegionScalar: 0.0,
        SituationScalar: 0.0,
        ResearchLocation: null,
    };
    Experiments: [
        {
            ExperimentDefinitionID: "orbital_survey_visual_mapping",
            CrewRequired: 0,
            TimeToComplete: 30.0,
            ContextualExperiment: false,
            ResourcesCost: [
                {
                    Rate: 1.0,
                    ResourceName: "ElectricCharge",
                    AcceptanceThreshold: 30.0
                }
            ],
            DenyInterruption: false,
            ExperimentUsesResources: true,
            DeployedBoolAnimatorParamName: "",
            CFXName: "fx_science",
            SFXEvent: "invalid"
        }
    ];
    NotifyOnCompletion: false;
    ResourceThresholdMultiplier: 0.25;
}

upbeat hare Dec 24, 2023, 5:29 PM

#

You need the pam override for one

desert stirrup Dec 24, 2023, 5:29 PM

#

Experiment definition gets created, I see it in the cache. Log says that PM is applying a patch to the part.

upbeat hare Dec 24, 2023, 5:29 PM

#

Also, you need to define the valid situations

upbeat hare Dec 24, 2023, 5:29 PM

#

upbeat hare You need the pam override for one

(Like the one you do for the orbital survey component)

desert stirrup Dec 24, 2023, 5:30 PM

#

ok, valid situations are:

"ValidLocations": [
      {
        "BodyName": "",
        "ScienceSituation": "HighOrbit",
        "RequiresRegion": false,
        "ScienceRegion": ""
      },
      {
        "BodyName": "",
        "ScienceSituation": "LowOrbit",
        "RequiresRegion": true,
        "ScienceRegion": ""
      }
    ],

will do that

#

PAM override? You mean this:

PAMModuleVisualsOverride: +[
                {
                    PartComponentModuleName: "PartComponentModule_OrbitalSurvey",
                    ModuleDisplayName: "PartModules/OrbitalSurvey/Name",
                    ShowHeader: true,
                    ShowFooter: true
                }
            ];

upbeat hare Dec 24, 2023, 5:30 PM

#

Yeah but for the experiment

#

Also there is a bug i need to hunt down with chained +x selectors

#

Where it doesnt create the second one

#

So you should nest it

+Module_ScienceExperiment {
    +Data_ScienceExperiment {
    }
}

desert stirrup Dec 24, 2023, 5:32 PM

#

PAM override, do you mean where the experiment is defined? So here:

@new("orbital_survey_visual_mapping")
:experiments {
...
}

That sounds strange as I don't see this in any other experiment definition

upbeat hare Dec 24, 2023, 5:32 PM

#

desert stirrup PAM override, do you mean where the experiment is defined? So here: ```cs @new("...

No

#

I mean like

PAMModuleVisualsOverride: +[
                {
                    PartComponentModuleName: "PartComponentModule_ScienceExperiment",
                    ModuleDisplayName: "OrbitalSurvey/VisualMapping/DisplayName",
                    ShowHeader: true,
                    ShowFooter: true
                }
            ];

#

On the part

desert stirrup Dec 24, 2023, 5:35 PM

#

Ah so on the part, not in the definition of the experiment, ok

upbeat hare Dec 24, 2023, 5:36 PM

#

Both of those together should show the experiment

desert stirrup Dec 24, 2023, 5:37 PM

#

It would be nice add warnings if stuff is missing from the patch, like ValidLocations missing. VSCode extension didn't complain about that. Is that possible to do?

upbeat hare Dec 24, 2023, 5:38 PM

#

That ... is possible but quite complex

desert stirrup Dec 24, 2023, 5:39 PM

#

Alright, you're the wiz, I trust you 🙂

#

Well aaaaalright! Thanks @upbeat hare! 🙂

desert stirrup Dec 24, 2023, 10:47 PM

#

Turns out neither PAMModuleVisualsOverride nor ValidLocations are needed to get the experiments to patch successfully.
It was the nested +Module... +Data that prevented patching.

upbeat hare Dec 24, 2023, 10:57 PM

#

I need to track down that bug

#

I think its just a bug with how multiple selectors are handled

#

Honestly it might not be possible to fix with the current semantics of selectors

#

Because chaining like that is adding both to the parent part, not to eachother individually

desert stirrup Dec 24, 2023, 11:00 PM

#

No need to solve it imo. I just used it cause I saw you doing it that way. It's more intuitive to me to nest it.

upbeat hare Dec 24, 2023, 11:00 PM

#

I was writing stuff fast forgetting how semantics woek

hexed yarrow Dec 25, 2023, 4:46 AM

#

Newbie question here... I'm trying to create my first patch file, but PatchManager seems to be scanning my mod directory but not finding the patch file. My mod diretory is in Kerbal Space Program 2\BepInEx\plugins\Dolphin. Inside that I have created a swinfo.json file like the wiki says, and a patches directory. In the patches directory I have a file named "pod_2v_cupola_crew.patch" which has the following content:

    * > Module_ReactionWheel {
        PitchTorque=*5;
        YawTorque=*5;
        RollTorque=*5;
    }
}```

I have gone into settings->mods->Patch Manager and set "Always Invalidate Cache" to "Yes".

When I restart KSP2, I see the following in BepInEx\LogOutput.log:

...
[Info   :Patch Manager] Loading patchers from C:\Program Files (x86)\Steam\steamapps\common\Kerbal Space Program 2\BepInEx\plugins\Dolphin
[Info   :Patch Manager] Loading patchers from C:\Program Files (x86)\Steam\steamapps\common\Kerbal Space Program 2\BepInEx\plugins\flight_plan
...
[Info   :Patch Manager] Registering all patches!
[Info   :Patch Manager] 0 patchers registered!
[Info   :Patch Manager] 0 generators registered!

You can see above that it didn't find my patcher even though it saw my plugin directory.  Am I interpreting that correctly?  My changes don't seem to take, and I'm not sure what I am doing wrong.

#

Also are there any example mods that already use patch manager which I could look at to get a feel for things? The docs actually seem pretty good on technical detail, but I haven't seen a working example and looking at one would probably help a lot.

desert stirrup Dec 25, 2023, 7:36 AM

#

@hexed yarrow Hmm, everything you mentioned sounds right. Maybe your swinfo isn't properly formatted (https://pm.kerbal.wiki/getting-started-with-patch-manager.html#setting-up-a-modding-environment-to-develop-patch-manager-patches) ? Is the mod present in Main Menu -> Mods and without errors?
Best way is to start is from a SpaceWarp template and go from there; everything should be set up correctly with the template.
You can see examples of working patches in Orbital Survey and Kerbal Life Support System mods.

Patch Manager Help

Getting Started With Patch Manager | Patch Manager

upbeat hare Dec 25, 2023, 11:48 AM

#

We definitely need a banner aaaa

north mist Dec 25, 2023, 12:12 PM

#

best I can offer rn is something very simple like this

#

(of course, colors can be changed)

#

or like this, with slighly different proportions and using one of the fonts I have in UitkForKsp2 that mimic the game fonts, that maybe fits a bit better since it's more angular

#

upbeat hare Dec 25, 2023, 12:19 PM

#

Hmm that looks decent

north mist Dec 25, 2023, 12:19 PM

#

any color preference?

upbeat hare Dec 25, 2023, 12:19 PM

#

A bit of a darker purple

hexed yarrow Dec 25, 2023, 12:22 PM

#

desert stirrup <@710886466519040020> Hmm, everything you mentioned sounds right. Maybe your sw...

Thanks for your response! Yes, my mod seems to be loading:

#

north mist Dec 25, 2023, 12:23 PM

#

upbeat hare A bit of a darker purple

and the other color?

hexed yarrow Dec 25, 2023, 12:23 PM

#

Here's my swinfo file, it is taken from the template you linked to, just changing a couple things:

    "spec": "2.0",
    "mod_id": "DolphinMod",
    "author": "Dolphin",
    "name": "DolphinMod",
    "description": "Does something",
    "version": "1.0.0",
    "ksp2_version": {
        "min": "0.2.0",
        "max": "*"
    },
    "dependencies": [
        {
            "id": "com.github.x606.spacewarp",
            "version": {
                "min": "1.5.0",
                "max": "*"
            }
        },
        {
            "id": "PatchManager",
            "version": {
                "min": "0.4.0",
                "max": "*"
            }
        }
    ]
}```

north mist Dec 25, 2023, 12:23 PM

#

north mist and the other color?

with the beige/peach one?

upbeat hare Dec 25, 2023, 12:24 PM

#

north mist with the beige/peach one?

Not sure on that one, maybe shift its hue more pink

upbeat hare Dec 25, 2023, 12:25 PM

#

hexed yarrow Here's my swinfo file, it is taken from the template you linked to, just changin...

That swinfo is correct

#

Can I see the patch file you are trying?

north mist Dec 25, 2023, 12:25 PM

#

upbeat hare Not sure on that one, maybe shift its hue more pink

?

upbeat hare Dec 25, 2023, 12:25 PM

#

I think that looks pretty decent

hexed yarrow Dec 25, 2023, 12:26 PM

#

upbeat hare That swinfo is correct

Here's my original post: #1115274490490929172 message

upbeat hare Dec 25, 2023, 12:27 PM

#

hexed yarrow Newbie question here... I'm trying to create my first patch file, but PatchManag...

Put a > Data_ReactionWheel after the > Module_ReactionWheel

#

Thats the first error I see

hexed yarrow Dec 25, 2023, 12:28 PM

#

ah, ok thanks!

upbeat hare Dec 25, 2023, 12:28 PM

#

And dont use =

#

Use :

#

Thatll cause a syntax error using equals, hence why PM isnt scanning your mod

hexed yarrow Dec 25, 2023, 12:29 PM

#

ha, I told you I was a newbie!

upbeat hare Dec 25, 2023, 12:29 PM

#

As to why PM isnt outputting syntax errors ... the PM syntax errors would be in KSP2.log due to some stuff I had to do

north mist Dec 25, 2023, 12:29 PM

#

so this should work

:parts #pod_2v_cupola_crew {
    * > Module_ReactionWheel > Data_ReactionWheel {
        PitchTorque: *5;
        YawTorque: *5;
        RollTorque: *5;
    }
}

upbeat hare Dec 25, 2023, 12:30 PM

#

Yes

upbeat hare Dec 25, 2023, 12:30 PM

#

upbeat hare As to why PM isnt outputting syntax errors ... the PM syntax errors would be in ...

I really need to see if I can get them in the bepinex log again

north mist Dec 25, 2023, 12:30 PM

#

though that syntax will likely change soon

#

from

PitchTorque: *5;

to

PitchTorque *: 5;

hexed yarrow Dec 25, 2023, 12:33 PM

#

north mist so this should work ```scss :parts #pod_2v_cupola_crew { * > Module_Reaction...

@upbeat hare it worked! Thanks so much to you all!!!

north mist Dec 25, 2023, 12:34 PM

#

upbeat hare I think that looks pretty decent

I think this looks fine as a logo, too

upbeat hare Dec 25, 2023, 12:34 PM

#

Dark mode logo for sure

north mist Dec 25, 2023, 12:34 PM

#

oh I just made it transparent

#

to show it off with both backgrounds

upbeat hare Dec 25, 2023, 12:34 PM

#

Ahh

#

Anyways im going to add that banner to the spacedock page

upbeat hare Dec 25, 2023, 12:35 PM

#

hexed yarrow <@299685147220115457> it worked! Thanks so much to you all!!!

No problem!

north mist Dec 25, 2023, 12:35 PM

#

upbeat hare Anyways im going to add that banner to the spacedock page

lemme get you an actual png

#

not this screenshot

#

ehh I uploaded it directly to SD

#

looks fine I think

#

upbeat hare Dec 25, 2023, 12:37 PM

#

Yep, that looks pretty good

north mist Dec 25, 2023, 12:37 PM

#

you can use the square one as a logo in the docs

upbeat hare Dec 25, 2023, 12:38 PM

#

Gotcha

north mist Dec 25, 2023, 12:38 PM

#

like this

#

https://www.jetbrains.com/help/writerside/styling-and-layout.html#accent-color and the "ruby" accent color might look nice with it

Writerside Help

Customize the look | Writerside

upbeat hare Dec 25, 2023, 12:39 PM

#

Gotcha

#

Ill do that soon enough

north mist Dec 25, 2023, 12:40 PM

#

sure, it's definitely not something urgent

upbeat hare Dec 25, 2023, 12:40 PM

#

Gods we are doing work on christmas

north mist Dec 25, 2023, 12:40 PM

#

I'm directly back to the mission editor lol

#

since I have covid, I'm not doing all the family visits this year anyway

upbeat hare Dec 25, 2023, 1:53 PM

#

Why I made that latest commit lol

@use "builtin:list";
@function not-in($values) {
    @return @function($check) {
        @each $v in $values {
            @if ($v == $check) {
                @return false;
            }
        }
        @return true;
    };
}
:science #node_id {
    UnlockedPartIds: $value:filter(not-in([/* ... */]));
}

north mist Dec 25, 2023, 1:54 PM

#

lol

upbeat hare Dec 25, 2023, 1:55 PM

#

north mist lol

Hey it shows how powerful PM can be though

north mist Dec 25, 2023, 1:56 PM

#

it sure does

upbeat hare Dec 25, 2023, 1:58 PM

#

Also if someone wants another example of quite a few different types of patches
https://github.com/cheese3660/WheresMyCrewCapsule/tree/main/patches

GitHub

WheresMyCrewCapsule/patches at main · cheese3660/WheresMyCrewCapsule

A probes before crew reimagining of the KSP2 Tech Tree - cheese3660/WheresMyCrewCapsule

upbeat hare Dec 25, 2023, 3:28 PM

#

Im going to be adding a - operation to lists as well

#

Its just going to remove all the values in the rhs from the lhs

#

Also I somewhat want to make a free floating identifier (like for a function call) automatically convert into a string

#

But im not sure

#

So like

... {
    x: y;
}
/* same as */
... {
    x: "y";
}

#

Thoughts?

north mist Dec 25, 2023, 3:32 PM

#

idk, I think it might lead to some confusion and misuse

upbeat hare Dec 25, 2023, 3:33 PM

#

Thats fair
Its basically already done on the lefthandside of : exprs in dictionaries though

#

But yeah i get ya

#

My thoughts were its something I already try to do when writing patches, and that it would make enum values look cleaner

#

Like instead of
Category: "Science";
Category: Science;
But i can totally see the confusion

north mist Dec 25, 2023, 3:36 PM

#

honestly I'm like 50/50 on this

#

not sure either way

upbeat hare Dec 25, 2023, 3:38 PM

#

Note: this is something SCSS does

north mist Dec 25, 2023, 3:38 PM

#

yeah, it's just a basic CSS thing

upbeat hare Dec 25, 2023, 3:38 PM

#

Im like 65/35 on it myself

north mist Dec 25, 2023, 3:39 PM

#

then sure, add it

#

I don't feel strongly about it

upbeat hare Dec 25, 2023, 3:40 PM

#

Gotcha
I also need to add like #"..." and strings as element selectors as well at some point

#

Its been on my todo list

north mist Dec 25, 2023, 3:40 PM

#

do we have escape sequences?

upbeat hare Dec 25, 2023, 3:40 PM

#

Yes

north mist Dec 25, 2023, 3:40 PM

#

nice

#

that should make that easier then

upbeat hare Dec 25, 2023, 3:40 PM

#

I just use regex.unescape

#

Which supports all C# escape sequences

north mist Dec 25, 2023, 3:41 PM

#

so something like #"\"hello there\"" should work

upbeat hare Dec 25, 2023, 3:41 PM

#

Yes

north mist Dec 25, 2023, 3:41 PM

#

awesome

upbeat hare Dec 25, 2023, 3:42 PM

#

~~I should make function names be strings to remove any ambiguity, "hello, I am a function"(5)~~

north mist Dec 25, 2023, 3:42 PM

#

oh my god

#

lmao

upbeat hare Dec 25, 2023, 3:42 PM

#

It wouldnt even be hard to implement

#

Plus you already do get-function with the function name as a string

#

But yeah ill add this all (except for maybe functions as strings) for a PM 0.7.0 release

#

Maybe I'll do the breaking +: change then as well

north mist Dec 25, 2023, 3:46 PM

#

CHEESE

#

😭

#

I finally had it all without warnings

upbeat hare Dec 25, 2023, 3:47 PM

#

Oh I need to write documentation

north mist Dec 25, 2023, 3:47 PM

#

lmao

#

I'm adding the release+nuget action to this

upbeat hare Dec 25, 2023, 3:47 PM

#

Awesome!

upbeat hare Dec 25, 2023, 3:50 PM

#

upbeat hare ~~I should make function names be strings to remove any ambiguity, `"hello, I am...

I ... dont see any argument against allowing this except for why?

north mist Dec 25, 2023, 3:51 PM

#

how is allowing spaces in function names good practice in any way, shape or form 😭

upbeat hare Dec 25, 2023, 3:51 PM

#

For when you want your functions to include unicode characters

north mist Dec 25, 2023, 3:52 PM

#

"👆 🟰 🤡 "()

#

munley

upbeat hare Dec 25, 2023, 3:52 PM

#

You might just need to put a BOM in front of your function name

north mist Dec 25, 2023, 3:52 PM

#

sometimes you truly terrify me Cheese

upbeat hare Dec 25, 2023, 3:53 PM

#

Good

north mist Dec 25, 2023, 5:00 PM

#

release action added, project files cleaned up, some code cleanup regarding things like unused imports and such, and all warnings fixed

#

hopefully the action works, but we'll only know after the next release

upbeat hare Dec 25, 2023, 5:00 PM

#

Yep

#

I can add the clean room disclaimer to PM now :3

#

You should add the release action into the template tbh

north mist Dec 25, 2023, 5:01 PM

#

yeah I'm going to

upbeat hare Dec 25, 2023, 5:04 PM

#

Aaa, Im gonna have to make a pr to all existing mods to switch around the prefix expressions

#

Plus tell the 2 people ive already taught to make patches that its going to change

north mist Dec 25, 2023, 5:04 PM

#

yeah... that was my other issue with it

#

though it's better sooner than later

#

if we really want to make the change

upbeat hare Dec 25, 2023, 5:05 PM

#

Im still 50/50 on it

upbeat hare Dec 25, 2023, 5:59 PM

#

Should I add custom mission categories to patch manager?

north mist Dec 25, 2023, 6:00 PM

#

I am all for it

upbeat hare Dec 25, 2023, 6:00 PM

#

Alright, aaa, I am going to have to do preanalysis to the patches though

north mist Dec 25, 2023, 6:01 PM

#

to just extend the enum with the new values?

upbeat hare Dec 25, 2023, 6:02 PM

#

If I want more than a static set of categories

north mist Dec 25, 2023, 6:02 PM

#

hmm

#

#

everything is done with switching on the enum, including rendering UI and stuff like that

#

so we'll have to patch everything that touches the enum, one way or another

#

I feel like it'd be easier to just look up the values in a custom dictionary or something, at that point

upbeat hare Dec 25, 2023, 6:04 PM

#

I feel like it'd be easier to just change that property to a string

#

and prepatch a lot of stuff

north mist Dec 25, 2023, 6:05 PM

#

yeah, or that

#

that way you don't have to analyze the patch files in a prepatch

upbeat hare Dec 25, 2023, 6:05 PM

#

Yeahh

#

I'll put this on my todo list

#

likely after 0.7.0

desert stirrup Dec 25, 2023, 6:08 PM

#

What are FTUE missions?
What would custom missions be? Missions that mods could trigger? How would that be different from secondary missions?

north mist Dec 25, 2023, 6:08 PM

#

First Time User Experience

#

they're the PAIGE stuff when you enable the first time user thing in the campaign creation

#

I think

upbeat hare Dec 25, 2023, 6:09 PM

#

desert stirrup 1. What are FTUE missions? 2. What would custom missions be? Missions that mods ...

I meant custom mission categories

north mist Dec 25, 2023, 6:09 PM

#

so other than Primary, Secondary, Tutorial, and FTUE

#

for example you could add missions of the type "Scanning"

#

for Orbital Survey

#

and they'd get their own box in the mission control

upbeat hare Dec 25, 2023, 6:10 PM

#

And I'll likely gen the loc key like MissionTypes/Scanning

desert stirrup Dec 25, 2023, 6:10 PM

#

That's what I meant with my question. Why would we define another category in addition to Secondary? I'm not saying that I wouldn't do that, just curiour what you're aiming at

north mist Dec 25, 2023, 6:11 PM

#

well, imagine building something like RP-1

#

and having all contracts in just 2 categories

#

or if a user installs 10 different mission packs at some point, imagine how cluttered the secondary missions would be

desert stirrup Dec 25, 2023, 6:12 PM

#

Ok so similar to what KSP1 was doing, mods could have their own category. Might be even something players could toggle off it they don't want them

north mist Dec 25, 2023, 6:13 PM

#

yep, pretty much that

desert stirrup Dec 25, 2023, 6:13 PM

#

sounds good

upbeat hare Dec 25, 2023, 6:13 PM

#

I was going to hide categories that don't have active missions

desert stirrup Dec 25, 2023, 6:13 PM

#

"CommunityMissionsCatagories"

north mist Dec 25, 2023, 6:13 PM

#

well, the idea is to let the modders use any string they want

upbeat hare Dec 25, 2023, 6:13 PM

#

I mean, why would it be community, I was going to allow mods to define any category they want

#

I was literally going to change the mission type from an enum to a string

desert stirrup Dec 25, 2023, 6:14 PM

#

I was kidding 🙂

#

Though there's a point to consider what would we do if different mods define the same string. Merge it or keep them separate.

upbeat hare Dec 25, 2023, 6:16 PM

#

desert stirrup Though there's a point to consider what would we do if different mods define the...

Merge it obviously

#

The patches won't know what mod the categories came from

#

anyways gtg for now

desert stirrup Dec 25, 2023, 6:17 PM

#

They could know, but ok, there's no reason to do it, I agree.

upbeat hare Dec 25, 2023, 6:50 PM

#

desert stirrup They _could_ know, but ok, there's no reason to do it, I agree.

Not easily no

upbeat hare Dec 25, 2023, 8:12 PM

#

Aaaa I'm really 50/50 on this : + -> +: change

desert stirrup Dec 25, 2023, 8:36 PM

#

I'm 100% for +:

upbeat hare Dec 25, 2023, 8:37 PM

#

It's going to be fun pinging sinon to update the LS again lol

#

But I have added the following so far

:experiments #"orbital_survey" {
  DataType: Both;
}

#

I'm going to add string interpolation in selectors at some point

#

(At the same time I add a top level @each)

#

I'll honestly do it like the following

$"{$xyz:...} + {$y:...}"

Which gets passed to String.Format with like the followint

String.Format("{0:...} + {1:...}",xyz,y);

upbeat hare Dec 25, 2023, 9:26 PM

#

alright, I'm implementing the +: thing

upbeat hare Dec 25, 2023, 9:29 PM

#

upbeat hare alright, I'm implementing the `+:` thing

Why are you crying munix

north mist Dec 25, 2023, 9:29 PM

#

I don't like it 😢

upbeat hare Dec 25, 2023, 9:29 PM

#

It's better than ambiguity

#

I could just s/:/= but aaaa

north mist Dec 25, 2023, 9:30 PM

#

noooo

#

that's even worse

#

keep +:

upbeat hare Dec 25, 2023, 9:30 PM

#

Alright

north mist Dec 25, 2023, 9:30 PM

#

let's get these breaking changes out of the way before 1.0

#

which by the way, I feel like the only puzzle piece that's missing now is celestial bodies and galaxy definitions

#

and then we're ready for 1.0

upbeat hare Dec 25, 2023, 9:32 PM

#

Yeah

#

that's why this next version is 0.7.0 still

#

Also literally everywhere you can use a string now, you can use the unquoted string form

#

@define-stage stage;

@stage stage
:parts {
}

Example

north mist Dec 25, 2023, 9:33 PM

#

alright, let's hope people don't try to use property names there

#

like

mass: mass + 2

#

since it kinda invites you to do that

upbeat hare Dec 25, 2023, 9:33 PM

#

well variables are already known to be $ is the thing

#

also that would tell you an error

#

and if we syntax highlight it as a string

north mist Dec 25, 2023, 9:34 PM

#

yeah, but the fact that the assignment also starts with no $ could lead someone to that conclusion

upbeat hare Dec 25, 2023, 9:34 PM

#

because technically assignment is a string

#

thats shorthand for

"mass": "mass" + 2;

north mist Dec 25, 2023, 9:35 PM

#

yeah

#

I think we better make this extra clear in the docs though

upbeat hare Dec 25, 2023, 9:35 PM

#

Yep

#

extra clear in docs

#

syntax highlight as string

north mist Dec 25, 2023, 9:36 PM

#

👍

upbeat hare Dec 26, 2023, 1:45 PM

#

@frail star new PR for the language server

frail star Dec 26, 2023, 1:45 PM

#

mmm

upbeat hare Dec 26, 2023, 1:45 PM

#

btw, don't worry about a lot more things being highlighted as strings

frail star Dec 26, 2023, 1:45 PM

#

@new("Stormlight")
@new(Stormlight)

upbeat hare Dec 26, 2023, 1:45 PM

#

Yes

frail star Dec 26, 2023, 1:45 PM

#

😬

#

no :grief:

upbeat hare Dec 26, 2023, 1:46 PM

#

Yes

north mist Dec 26, 2023, 1:46 PM

#

I was resisting a bit as well, but it makes sense since CSS considers most unquoted strings as strings, too

upbeat hare Dec 26, 2023, 1:47 PM

#

I also did a lot of stuff in the opposite direction

#

so

."$type" {
}

is correct

north mist Dec 26, 2023, 1:48 PM

#

https://i.imgflip.com/8aifao.gif

frail star Dec 26, 2023, 1:49 PM

#

wait

#

i just saw a person i know in the member list

#

from a completely different server

#

lol

north mist Dec 26, 2023, 1:49 PM

#

that was not the conclusion to "wait" that I was expecting

#

lmao

frail star Dec 26, 2023, 1:49 PM

#

i was trying to ping cheese, and i saw them

#

anyways

#

@upbeat hare

#

i am very mentally invested into optimizing my memeql, and i will do this in a bit

#

O(log n) best case is for weaklings

north mist Dec 26, 2023, 1:51 PM

#

O(1) or bust

frail star Dec 26, 2023, 1:51 PM

#

uh

#

sorry i mean, O(1) is best case

#

O(log n) is average

upbeat hare Dec 26, 2023, 1:52 PM

#

Just upgrade the CPU to have a 1 terabyte xor gate

frail star Dec 26, 2023, 1:52 PM

#

O(n) worst case 😬

#

still would probably be slower than my

#

simd comes so hard into play here

upbeat hare Dec 26, 2023, 2:05 PM

#

What I am not looking forward to is string interpolation

#

https://sass-lang.com/documentation/interpolation/

Sass: Interpolation

Syntactically Awesome Style Sheets

stiff crater Dec 26, 2023, 2:07 PM

#

Does the foo: +[bar]; -> foo+: [bar]; change have some level of backwards compatilibity or will all mods using this syntax break?

upbeat hare Dec 26, 2023, 2:07 PM

#

stiff crater Does the `foo: +[bar];` -> `foo+: [bar];` change have some level of backwards co...

I was thinking of adding backwards compatibility, but I was just going to go through every mod I know and make the change as a PR before release

north mist Dec 26, 2023, 2:08 PM

#

there aren't that many, anyway

stiff crater Dec 26, 2023, 2:08 PM

#

Just for info I won't be able to update KLSS until the 30th at the earliest

stiff crater Dec 26, 2023, 2:09 PM

#

stiff crater Just for info I won't be able to update KLSS until the 30th at the earliest

I would however still have access to SpaceDock & the forums so I can upload a zip if someone else builds the release

north mist Dec 26, 2023, 2:09 PM

#

what if we submit a PR for it and give you a zipped release

#

yeah, that was my thoughts as well

upbeat hare Dec 26, 2023, 2:12 PM

#

I'm going to be heading to grab breakfast for now tho

#

I have a ... really stupid idea

north mist Dec 26, 2023, 2:13 PM

#

unkekw

upbeat hare Dec 26, 2023, 2:13 PM

#

if file is older than release date
    file.replace(": +"," +: ")
    file.save()

north mist Dec 26, 2023, 2:14 PM

#

nooooooooo

upbeat hare Dec 26, 2023, 2:14 PM

#

I dont foresee any issues with this

north mist Dec 26, 2023, 7:53 PM

#

I also fixed the build script to work with the action, and added the two other actions from the new template version

#

let's see what it does

upbeat hare Dec 26, 2023, 7:54 PM

#

north mist let's see what it does

it fails at finding the antlr dll

north mist Dec 26, 2023, 7:55 PM

#

aaaaaaaaaaaa

upbeat hare Dec 26, 2023, 7:55 PM

#

north mist Dec 26, 2023, 7:55 PM

#

I forgot we do this sort of magic bullshit

#

can we just... copy them into plugin_template and commit them?

upbeat hare Dec 26, 2023, 7:57 PM

#

I suppose we could

#

I was hoping to avoid that

#

~/.local/share/NuGet/plugins-cache is the nuget cache location on linux

north mist Dec 26, 2023, 7:58 PM

#

huh why does MSBuild set the autogenerated property wrong

north mist Dec 26, 2023, 7:58 PM

#

upbeat hare `~/.local/share/NuGet/plugins-cache` is the nuget cache location on linux

but also I just tried that on WSL Ubuntu after restoring the solution and the folder doesn't exist

upbeat hare Dec 26, 2023, 7:59 PM

#

wait

#

google was wrong

north mist Dec 26, 2023, 7:59 PM

#

aafsjhsdfgjl

#

I know the issue

#

it's because we capitalize the folder name

#

and Linux is case sensitive

upbeat hare Dec 26, 2023, 7:59 PM

#

lifesupport

north mist Dec 26, 2023, 7:59 PM

#

upbeat hare Dec 26, 2023, 7:59 PM

#

thats an easy fix then

north mist Dec 26, 2023, 8:00 PM

#

yeah that was the whole issue

#

now it finds the file

#

lmao ok another easy fix

#

I just used the template's nuspec name which is Package.nuspec

#

but we have PatchManager.nuspec

upbeat hare Dec 26, 2023, 8:01 PM

#

Oh lol

north mist Dec 26, 2023, 8:03 PM

#

nice

upbeat hare Dec 26, 2023, 8:03 PM

#

Anyways my next project is to make SW compile without warnings and have doc comments

#

we really just need a doxygen site for spacewarp

north mist Dec 26, 2023, 8:03 PM

#

I already started work on it

#

so I'll at lease push what I have and you can continue, and I'll get on with the mission editor

#

though, could you please try to make the mission debug thing first, so I can release CF?

upbeat hare Dec 26, 2023, 8:04 PM

#

Oh I was just going to write a patch to give myself that mission at the start

north mist Dec 26, 2023, 8:05 PM

#

ah that works too

#

just want to verify the mission fix, doesn't really matter how

upbeat hare Dec 26, 2023, 8:06 PM

#

Lol I can use the standalone patch system I just wrote

north mist Dec 26, 2023, 8:06 PM

#

it's nice to have actions back for PM

#

I'm glad I put the effort into making all the nuget and powershell stuff work

upbeat hare Dec 26, 2023, 8:07 PM

#

Testing the release action now

north mist Dec 26, 2023, 8:07 PM

#

now it's time for the big one, the release action

#

yep

upbeat hare Dec 26, 2023, 8:08 PM

#

north mist Dec 26, 2023, 8:08 PM

#

ooh I know exactly what that is

upbeat hare Dec 26, 2023, 8:08 PM

#

Yep

north mist Dec 26, 2023, 8:08 PM

#

it's the SW specific path

upbeat hare Dec 26, 2023, 8:08 PM

#

I'm half tempted to delete the release and try again lmao

north mist Dec 26, 2023, 8:08 PM

#

why not tbh, you can just copy the markdown

upbeat hare Dec 26, 2023, 8:09 PM

#

Going to force merge

north mist Dec 26, 2023, 8:09 PM

#

lmao I made a PR but yeah, that's fine

upbeat hare Dec 26, 2023, 8:10 PM

#

Attempt no. 2

north mist Dec 26, 2023, 8:10 PM

#

I believe in it this time

#

hell yeah

upbeat hare Dec 26, 2023, 8:11 PM

#

WOOOO

north mist Dec 26, 2023, 8:11 PM

#

upbeat hare Dec 26, 2023, 8:11 PM

#

Everything worked!

north mist Dec 26, 2023, 8:12 PM

#

it wasn't without some small hiccups, but nothing major, I'm glad

upbeat hare Dec 26, 2023, 8:12 PM

#

there was a deprecation warning in one of the steps

north mist Dec 26, 2023, 8:12 PM

#

oh yeah I already have that action replaced in the template

#

let me make that change in dev

#

it's pretty cool that this also allows us to very easily do something like fix some small mistake in the code, just push the change into main, and create a release and then just grab it and upload it to spacedock (which we will also be able to automate), and all that without any dev environment set up or KSP2 installed

#

for example in situations like Safarte's right now, on vacation

#

in fact I think that in the next template version, I'd like to add a SpaceDock upload action

#

to make this complete

upbeat hare Dec 26, 2023, 8:16 PM

#

Yeah

#

Fully automated release pipelining

#

Also awesome!

north mist Dec 26, 2023, 8:17 PM

#

and I'm still very interested in this: https://game.ci/docs/github/builder

Builder | GameCI

Building the project as part of a workflow may help to create mind-space and focus on the project

#

it could allow us to fully automate even solutions with Unity projects

#

like automatically building SpaceWarpUI

upbeat hare Dec 26, 2023, 8:18 PM

#

That would be awesome

stiff crater Dec 26, 2023, 8:18 PM

#

north mist for example in situations like Safarte's right now, on vacation

yeah I need to update to the latest version of the template for my mods when I come home

north mist Dec 26, 2023, 8:19 PM

#

honestly out of everything I do here, the template is like my passion project

upbeat hare Dec 26, 2023, 8:19 PM

#

It also prevents any malware from getting into the release zips in case the devs computer is compromised

#

not that that is a big concern

lethal dome Dec 26, 2023, 9:12 PM

#

Hey Guys, long stint of absance but I am back. New update if fantastic, is it a known issue with the update that there is a bug with rebuilding the cache?

north mist Dec 26, 2023, 9:14 PM

#

not that I'm aware of, what is it specifically?

hexed yarrow Dec 26, 2023, 9:14 PM

#

I also hit it

#

EXC 15:07:43.710] NullReferenceException: Object reference not set to an instance of an object
PatchManager.Core.Assets.PatchingManager.RebuildAllCache (System.Action resolve, System.Action1[T] reject) (at <8466f18cf3c7417f87d171cc831cb24e>:0) KSP.Game.Flow.GenericFlowAction.DoAction (System.Action resolve, System.Action1[T] reject) (at <dd6137ea2e634c0ba20d8eb5ac23d499>:0)
KSP.Game.Flow.FlowAction.Do (System.Action1[T] resolve, System.Action2[T1,T2] reject) (at <dd6137ea2e634c0ba20d8eb5ac23d499>:0)
(wrapper dynamic-method) KSP.Game.Flow.SequentialFlow.DMDKSP.Game.Flow.SequentialFlow::NextFlowAction(KSP.Game.Flow.SequentialFlow)
KSP.Game.Flow.SequentialFlow.Update () (at <dd6137ea2e634c0ba20d8eb5ac23d499>:0)
[EXC 15:07:53.216] NullReferenceException: Object reference not set to an instance of an object
KSP.Rendering.CelestialBodyGIProbeManager.RemoveEvents () (at <dd6137ea2e634c0ba20d8eb5ac23d499>:0)
KSP.Rendering.LightingSystem.RemoveEvents () (at <dd6137ea2e634c0ba20d8eb5ac23d499>:0)
KSP.Rendering.GraphicsManager.RemoveEvents () (at <dd6137ea2e634c0ba20d8eb5ac23d499>:0)
KSP.Rendering.GraphicsManager.Cleanup () (at <dd6137ea2e634c0ba20d8eb5ac23d499>:0)
KSP.Rendering.GraphicsManager.OnDestroy () (at <dd6137ea2e634c0ba20d8eb5ac23d499>:0)
[WRN 15:07:53.248] KSPAudio: Unable to find AudioInputDefinition for hotkey binding!

north mist Dec 26, 2023, 9:14 PM

#

thanks for the report, I'm looking into it

hexed yarrow Dec 26, 2023, 9:15 PM

#

I thought it was my mod because I hadn't changed the way to do something+=else; but I get it when I move my mod out of the way

#

it it possible to download the previous version?

lethal dome Dec 26, 2023, 9:17 PM

#

Okay it loaded in after about 10 minutes. Just took a very long time.

north mist Dec 26, 2023, 9:17 PM

#

that's probably the action timing out

lethal dome Dec 26, 2023, 9:18 PM

#

Sorry for the bother.

#

If you need any logs let me know.

north mist Dec 26, 2023, 9:19 PM

#

I just tested with cache deleted, and then with cache existing, and haven't hit the exception either way

#

could you please send the full logs?

lethal dome Dec 26, 2023, 9:19 PM

#

Sure

#

Where will the logs sit?

north mist Dec 26, 2023, 9:20 PM

#

C:\Users\username\AppData\LocalLow\Intercept Games\Kerbal Space Program 2\Player.log contains everything

hexed yarrow Dec 26, 2023, 9:20 PM

#

I'll grab that.

#

I also found the previous version I think at https://github.com/KSP2Community/PatchManager/releases/tag/v0.6.1. Does that sound right?

north mist Dec 26, 2023, 9:20 PM

#

yes

lethal dome Dec 26, 2023, 9:21 PM

#

📎 Player.log

hexed yarrow Dec 26, 2023, 9:22 PM

#

📎 Player.log

#

let me know if you want KSP2.log, that is where I found that stack trace

north mist Dec 26, 2023, 9:22 PM

#

no need, this file should contain all that is in that one

#

and some extras

#

thank you both for the logs

hexed yarrow Dec 26, 2023, 9:24 PM

#

no problem, thank YOU for the mod!

north mist Dec 26, 2023, 9:24 PM

#

and I have already found the issue, thanks, this will be an easy fix

lethal dome Dec 26, 2023, 9:26 PM

#

hexed yarrow no problem, thank YOU for the mod!

Second this

north mist Dec 26, 2023, 9:34 PM

#

here's a (hopefully) fixed version, would you mind testing it for me?

📎 PatchManager-0.7.1.zip

#

https://github.com/KSP2Community/PatchManager/pull/24 @upbeat hare

GitHub

Fix bug when rebuilding cache by jan-bures · Pull Request #24 · KSP...

Fixes a bug where PM is trying to read from GameData/Mods without first checking if it exists.

upbeat hare Dec 26, 2023, 9:43 PM

#

north mist https://github.com/KSP2Community/PatchManager/pull/24 <@299685147220115457>

Force merge and release pls

north mist Dec 26, 2023, 9:44 PM

#

sure

upbeat hare Dec 26, 2023, 9:49 PM

#

Thank you

lethal dome Dec 26, 2023, 9:56 PM

#

Works perfectly, want the log?

north mist Dec 26, 2023, 9:58 PM

#

no need, thanks

#

glad it's fixed now

lethal dome Dec 26, 2023, 9:58 PM

#

Thanks

#

Amazing as always

upbeat hare Dec 26, 2023, 10:43 PM

#

Does the forum have an api

#

Can we auto forum post on update

north mist Dec 26, 2023, 10:43 PM

#

actually... I worked on a mobile app for an Invision-based forum years ago

#

lmao

#

but the API has to be specifically enabled by the admins

#

which I very much doubt they have

upbeat hare Dec 26, 2023, 10:44 PM

#

Darn

#

I just wanna be as lazy as possible

north mist Dec 26, 2023, 10:44 PM

#

I would love that as well

upbeat hare Dec 26, 2023, 10:45 PM

#

Setting up the spacedock uploader is the next step

north mist Dec 26, 2023, 10:45 PM

#

definitely

upbeat hare Dec 26, 2023, 10:45 PM

#

I already have the ksp2community bot username/pw in the secrets for spacewarp

desert stirrup Dec 26, 2023, 10:47 PM

#

oh I thought you were going to remove support for : + but I've updated to 0.7.1 and it's still working

upbeat hare Dec 26, 2023, 10:47 PM

#

desert stirrup oh I thought you were going to remove support for `: +` but I've updated to 0.7....

It is not

#

just returns the value on the righthandside

#

I should add a check that the value is an integer/real

#

So

X: +5;

Does not do $value+5
It just returns 5

#

It might still be working as your things are the only overrides for example

#

But there is no code for parsing that stuff explicitly now

desert stirrup Dec 26, 2023, 10:54 PM

#

ok, orbital survey is still working because

PAMModuleVisualsOverride: +[

is the same as

PAMModuleVisualsOverride: [

for the PAM override. Ok, gotcha

upbeat hare Dec 26, 2023, 10:54 PM

#

Exactly

upbeat hare Dec 27, 2023, 1:18 PM

#

@use 'builtin:list';
@use 'builtin:dictionary';
@function mult-by($ratio) {
  @return @function($v) {
    @return $v:set('value',$v['value']*$ratio);
  };
}
:parts #engine_id > Module_Engine > Data_Engine > Engine > atmosphereCurve > fCurve {
  keys: $value:map(mult-by(/* your ratio */));
}

I can't really do much better than this here, can I?

#

Maybe adding some curve builtins?

north mist Dec 27, 2023, 1:18 PM

#

I suppose that might be helpful, since ISP will probably be a relatively frequent patch target

upbeat hare Dec 27, 2023, 1:20 PM

#

Yeah, but I can't do anything about requiring function calls

#

This really do be looking like CSS lmao

north mist Dec 27, 2023, 1:23 PM

#

upbeat hare Yeah, but I can't do anything about requiring function calls

That's fine

upbeat hare Dec 27, 2023, 1:24 PM

#

Fair enough

#

Also, I'm thinking, should I allow

$v:value

With no function call to be the same as

$v[value]

north mist Dec 27, 2023, 1:30 PM

#

That's not a bad idea

#

Just using : as a general member access operator

upbeat hare Dec 27, 2023, 2:11 PM

#

Umm, so I also need to do a hotfix soon

#

The single file patches aren't being hashed for cache invalidation

upbeat hare Dec 27, 2023, 2:44 PM

#

Im still very glad I added higher order functions

upbeat hare Dec 28, 2023, 4:50 PM

#

I'm thinking we might have to change our caching system a bit

#

We compute the cache ... after we check cache validity now

north mist Dec 28, 2023, 4:50 PM

#

lifesupport

upbeat hare Dec 29, 2023, 1:15 PM

#

Also @north mist patch manager is going to start using C# 12 from my next commit

north mist Dec 29, 2023, 1:16 PM

#

sure

upbeat hare Dec 29, 2023, 1:16 PM

#

It's basically just us 2 so it won't be an issue

vagrant kiln Dec 29, 2023, 3:30 PM

#

hey, do u know if this supports float curve editing? if it has been tested

north mist Dec 29, 2023, 3:31 PM

#

not sure if tested, but it should work

vagrant kiln Dec 29, 2023, 3:31 PM

#

    "fCurve": {
      "keys": [
        {
          "time": 0.0,
          "value": 335.0,
          "inTangent": 0.0,
          "outTangent": 0.0,
          "inWeight": 0.0,
          "outWeight": 0.0,
          "weightedMode": "None",
          "tangentMode": 0
        },```

#

ok i will try to figure it out, thx

#

very good mod btw, its cool to finally have a MM style mod

#

took me a while to work out how to edit partmodule stats, but now its great

north mist Dec 29, 2023, 3:34 PM

#

yeah, we basically looked at MM, and tried to do something similar but make it much more powerful, and base the syntax on an existing language (SCSS) to make it easier to learn

upbeat hare Dec 29, 2023, 5:09 PM

#

I have a stupid idea once we fix caching

#

We should add the addressables catalogs and asset bundles for mods into the cache hash

vagrant kiln Dec 29, 2023, 6:34 PM

#

what is the syntax for editing a field inside an object which is inside a list? e.g. Experiments: [ { "ExperimentDefinitionID": "AtmosphereSurvey", ... } ]

upbeat hare Dec 29, 2023, 6:35 PM

#

vagrant kiln what is the syntax for editing a field inside an object which is inside a list? ...

Experiments[N]: {...}; where N is the zero based index for that list

vagrant kiln Dec 29, 2023, 6:39 PM

#

like this? * > Module_ScienceExperiment > Data_ScienceExperiment { Experiments[0]: { ExperimentDefinitionID: "AtmosphereSurvey", }; }

upbeat hare Dec 29, 2023, 6:40 PM

#

Nah, you might want to do this instead

vagrant kiln Dec 29, 2023, 6:40 PM

#

bc that patches but then throws the weird error in the vab where it just shows the color picker

upbeat hare Dec 29, 2023, 6:40 PM

#

@use "builtin:dictionary";
* > Module_ScienceExperiment > Data_ScienceExperiment {
            Experiments[0]: $value:set(ExperimentDefinitionID,AtmosphereSurvey);
        }

#

And then you can keep chaining :set

vagrant kiln Dec 29, 2023, 6:43 PM

#

not working, maybe i need to update

upbeat hare Dec 29, 2023, 6:44 PM

#

Can I see your full patch @vagrant kiln

#

And what version of PM

vagrant kiln Dec 29, 2023, 6:44 PM

#

0.6

upbeat hare Dec 29, 2023, 6:44 PM

#

Update to 0.7

#

though you will have to change all your : +/-/*// to +: -: *: /:

vagrant kiln Dec 29, 2023, 6:46 PM

#

is that supposed to break splash screen skipper?

upbeat hare Dec 29, 2023, 6:47 PM

#

lifesupport

#

@desert stirrup @north mist wtf

vagrant kiln Dec 29, 2023, 6:47 PM

#

cannot live without that mod lol

upbeat hare Dec 29, 2023, 6:47 PM

#

That mod is sentient I swear

#

but no it isn't supposed to break, I don't use it because it only works for 50% of people or something

vagrant kiln Dec 29, 2023, 6:49 PM

#

#

just from updating, nothing else changed

upbeat hare Dec 29, 2023, 6:49 PM

#

vagrant kiln

What do the logs say

vagrant kiln Dec 29, 2023, 6:50 PM

#

yeah i wanted to find those, where are they?

upbeat hare Dec 29, 2023, 6:50 PM

#

You'll want to look under BepInEx/logoutput.log

vagrant kiln Dec 29, 2023, 6:50 PM

#

  at SpaceWarp.Patching.LoadingActions.InitializeModAction.DoAction (System.Action resolve, System.Action`1[T] reject) [0x0000d] in <39f0697ba36b449aa19b27f13be09abd>:0 
[Error  :Space Warp] System.NullReferenceException: Object reference not set to an instance of an object
  at SpaceWarp.Patching.LoadingActions.PostInitializeModAction.DoAction (System.Action resolve, System.Action`1[T] reject) [0x0000d] in <39f0697ba36b449aa19b27f13be09abd>:0 ```

upbeat hare Dec 29, 2023, 6:51 PM

#

Can you send the full log please

vagrant kiln Dec 29, 2023, 6:51 PM

#

is there a patch manager log?

upbeat hare Dec 29, 2023, 6:52 PM

#

I meant send the full logoutput.log

#

bepinex should say what happend

vagrant kiln Dec 29, 2023, 6:52 PM

#

sorry nvm im a derp

#

[Error : BepInEx] Could not load [Patch Manager 0.7.1] because it has missing dependencies: com.github.x606.spacewarp (v1.7.0 or newer)

upbeat hare Dec 29, 2023, 6:52 PM

#

Ah yes, update spacewarp

#

and likely uitk

vagrant kiln Dec 29, 2023, 6:55 PM

#

nested fields inside objects inside lists are serious business, have to update everything lol

#

and pray the skipper still works

upbeat hare Dec 29, 2023, 6:56 PM

#

Are you patching the engine modes?

desert stirrup Dec 29, 2023, 6:56 PM

#

Arcane dark magic is breaking splash screen skipper. There is no hope for salvation.

upbeat hare Dec 29, 2023, 6:56 PM

#

> Data_Engine > #mode-id {
}

Is the easiest way to get to an engine with a certain mode

> Data_Engine > engine_mode {
}

Gets all engine modes

north mist Dec 29, 2023, 6:57 PM

#

upbeat hare <@378898832559439876> <@366972069440913418> wtf

vagrant kiln Dec 29, 2023, 7:01 PM

#

phew it works at least

upbeat hare Dec 29, 2023, 7:01 PM

#

desert stirrup Arcane dark magic is breaking splash screen skipper. There is no hope for salvat...

Good thing I'm a dark wizard

vagrant kiln Dec 29, 2023, 7:09 PM

#

gotta go back to basics, nothing works except the tech tree

#

        PitchTorque: *0.02;
        RollTorque: *0.02;
        YawTorque: *0.02;
    }```

#

that used to work and i didnt think that syntax changed?

#

in 0.7

upbeat hare Dec 29, 2023, 7:11 PM

#

It did change

#

* > Module_ReactionWheel > Data_ReactionWheel { 
        PitchTorque *: 0.02;
        RollTorque *: 0.02;
        YawTorque *: 0.02;
    }

upbeat hare Dec 29, 2023, 7:11 PM

#

upbeat hare though you will have to change all your `: +/-/*//` to `+: -: *: /:`

What I was trying to say up here

vagrant kiln Dec 29, 2023, 7:11 PM

#

ah i get u now, thanks

#

ok seems to be working, thx, just a last question - how to delete the object with lookup by name inside the list, like * > resourceContainers { ElectricCharge { @delete; } }

upbeat hare Dec 29, 2023, 7:20 PM

#

vagrant kiln ok seems to be working, thx, just a last question - how to delete the object wit...

* > resourceContainers > ElectricCharge {
  @delete;
}

Works

vagrant kiln Dec 29, 2023, 7:24 PM

#

hm, the resource doesnt get deleted

#

    @if $$crewCapacity > 0 {
        * > Module_ReactionWheel { @delete; }
        * > resourceContainers > ElectricCharge { @delete; }
    }
}```

upbeat hare Dec 29, 2023, 7:25 PM

#

vagrant kiln ```:parts { @if $$crewCapacity > 0 { * > Module_ReactionWheel { @del...

Give me one second I need to remember how I set this up

vagrant kiln Dec 29, 2023, 7:26 PM

#

np

upbeat hare Dec 29, 2023, 7:26 PM

#

vagrant kiln ```:parts { @if $$crewCapacity > 0 { * > Module_ReactionWheel { @del...

:parts {
    @if $$crewCapacity > 0 {
        * > Module_ReactionWheel { @delete; }
        * > resourceContainers > .ElectricCharge { @delete; }
    }
}

Try this

vagrant kiln Dec 29, 2023, 7:28 PM

#

yup! tysm

upbeat hare Dec 29, 2023, 7:28 PM

#

That needs to be changed, why did I use class there instead of element type or name like I do everywhere else

vagrant kiln Dec 29, 2023, 7:28 PM

#

ok

#

i might not use it anyway since the life support mods probably need EC on the pods

upbeat hare Dec 29, 2023, 7:29 PM

#

They don't

#

they just need it in the vessel

vagrant kiln Dec 29, 2023, 7:29 PM

#

ok

#

do u need to change it, i can wait if u do

#

its not a big deal

upbeat hare Dec 29, 2023, 7:30 PM

#

Nah, I'll change it in a backwards compatible way in a later update

vagrant kiln Dec 29, 2023, 7:30 PM

#

kk

desert stirrup Dec 29, 2023, 10:15 PM

#

Can I do something like this? And what would the syntax be?

$visual-parts: ["#antenna_0v_dish_ra-2", "#antenna_1v_parabolic_dts-m1", "antenna_1v_dish_hg55", "antenna_1v_dish_88-88"];
$biome-parts: ["antenna_0v_dish_ra-15", "antenna_1v_dish_ra-100"];

:parts $visual-parts {
    // do stuff
}

upbeat hare Dec 29, 2023, 10:20 PM

#

desert stirrup Can I do something like this? And what would the syntax be? ```css $visual-parts...

And this is planned once i implement string interpolation

#

The answer is not yet

#

But I want to

desert stirrup Dec 29, 2023, 10:21 PM

#

Alright, good to know

upbeat hare Dec 29, 2023, 10:22 PM

#

For reference, the syntax would be a top level each loop

desert stirrup Dec 29, 2023, 10:22 PM

#

I'm also looking forward to having Builtin Library References filled in, lists, dictionaries and the rest

upbeat hare Dec 29, 2023, 10:22 PM

#

But now that I have someone wanting it, ill move it up in priority

desert stirrup Dec 29, 2023, 10:23 PM

#

I mean I have an easy backup solution, but it would have been nice

north mist Dec 29, 2023, 10:23 PM

#

https://forum.kerbalspaceprogram.com/topic/221179-071-patch-manager/?do=findComment&comment=4353693 we also have someone wanting a way to replace the skybox with PM

Kerbal Space Program Forums

[0.7.1] Patch Manager

Patch Manager A mod for all your generic patching needs! Spacedock: https://spacedock.info/mod/3482/Patch Manager Github: https://github.com/KSP2Community/PatchManager Author: KSP2 Community Description Patch Manager is a mod for KSP2 that functions as a sort of spiritual successor to Module Mana...

#

lmao

upbeat hare Dec 29, 2023, 10:24 PM

#

Thats ... just not possible

north mist Dec 29, 2023, 10:24 PM

#

lmao that's what I told them

upbeat hare Dec 29, 2023, 10:25 PM

#

desert stirrup I mean I have an easy backup solution, but it would have been nice

Yeah, expect it soon tho

desert stirrup Dec 29, 2023, 10:54 PM

#

Also, I want to move all the constants Orbital Survey uses like min/ideal/max altitude to PM patches and I'm reading up on defining configs other mods could override, that would be a nice touch. But ideally I also need a way to access those value from inside my c# code, similar to how you'd do that in MM. Is this possible?

upbeat hare Dec 29, 2023, 10:55 PM

#

Umm, you can access the builtin get config function directly

#

You just need a reference to the Universe which is patchmanager.core.assets.patchingmanager I think

#

It returns a DataValue which will hold your valur

desert stirrup Dec 29, 2023, 10:56 PM

#

An API would be nice, I think that other modders would need that as well.

#

"Universe"? What is that? A namespace?

upbeat hare Dec 29, 2023, 10:57 PM

#

upbeat hare Umm, you can access the builtin get config function directly

The function js PatchManager.SassyPatching.Builtins.ConfigBuiltins.GetConfig

north mist Dec 29, 2023, 10:57 PM

#

well it kinda already is an API, I think we just need to document it

upbeat hare Dec 29, 2023, 10:57 PM

#

desert stirrup "Universe"? What is that? A namespace?

The state of the patch manager environment

desert stirrup Dec 29, 2023, 10:58 PM

#

I don't know what that is 🙂

north mist Dec 29, 2023, 10:58 PM

#

it's a class

desert stirrup Dec 29, 2023, 10:58 PM

#

Ok, I'll add PM as a reference and look around

upbeat hare Dec 29, 2023, 10:59 PM

#

I thought I made it public aaaa
https://github.com/KSP2Community/PatchManager/blob/main/src/PatchManager.Core/Assets/PatchingManager.cs

GitHub

PatchManager/src/PatchManager.Core/Assets/PatchingManager.cs at mai...

A mod for generic patching needs similar to KSP 1's Module Manager. - KSP2Community/PatchManager

north mist Dec 29, 2023, 11:00 PM

#

can't you just use PatchManager.Core.CoreModule.CurrentUniverse?

#

oh but there's no easily accessible instance of the core

upbeat hare Dec 29, 2023, 11:00 PM

#

I ... forgot to make that a static property facepalm

#Patch Manager