Patch Manager | KSP2 Redux | Page 5

upbeat hare Oct 22, 2023, 4:23 PM

#

Thats one issue that doesn't seem to be happening for me then
But the other issue of it not adding modules to stock vessel is still happening

#

Wait what

#

Completely broken on a stock kerbal K1, but it still exists??

stiff crater Oct 22, 2023, 4:24 PM

#

Huh that's different from what I had

#

Mine existed a bit less than that

upbeat hare Oct 22, 2023, 4:25 PM

#

Wait, thats cuz thats an MK1, which I already put the module on the prefab earlier, and it didn't load data ... cuz it didn't have any data in the save

#

Wait ... huh

#

Now it is adding the module, just broken

#

I need to grab unity explorer anyways

#

It does put all of this on the eva kerbal and it seems correct

stiff crater Oct 22, 2023, 4:32 PM

#

Yep, my code must be broken for eva kerbal somehow

upbeat hare Oct 22, 2023, 4:33 PM

#

And I don't understand whats wrong here?

stiff crater Oct 22, 2023, 4:33 PM

#

Is the data null?

#

And do you have errors in the logs?

upbeat hare Oct 22, 2023, 4:34 PM

#

stiff crater Oct 22, 2023, 4:34 PM

#

huh

upbeat hare Oct 22, 2023, 4:34 PM

#

I do have this error though

#

So something is null

#

#

So Mode is null now

#

#

Yep, mode is null

#

Which is what it is in the json as well

#

the context key is null

stiff crater Oct 22, 2023, 4:40 PM

#

Ah yeah the ModuleProperty fields are not default initialized by PM

upbeat hare Oct 22, 2023, 4:40 PM

#

Hmm, is that something we should do?

stiff crater Oct 22, 2023, 4:43 PM

#

Hmm those are in KSPState so I feel we wouldn't want people having to initialize them in their patches, the focus should be on the definitions

upbeat hare Oct 22, 2023, 4:43 PM

#

Mmmmm ... this is gonna be fun

#

Side note, I like how clean your patches are

#

Like the fact you use a constants library to help define everything without funky numbers

stiff crater Oct 22, 2023, 4:49 PM

#

Yeah I didn't want to have to change a bunch of magic numbers everywhere all the time, I could still move some more stuff to it too

upbeat hare Oct 22, 2023, 4:50 PM

#

Oh gosh, this module property initialization, I am gonna need to do a lot of magic ain't I...

#

Because this stuff is assumed to be initialized in the OAB

#

but since this stuff wasn't in the OAB, it was never initialized

stiff crater Oct 22, 2023, 4:51 PM

#

Arf that sounds annoying, getting the type T and initial value when iterating over the fields in the data is possible with reflection?

upbeat hare Oct 22, 2023, 4:52 PM

#

Surprisingly no
Take for example the resource converter mode, its default initialized based on formulae, isn't it?

stiff crater Oct 22, 2023, 4:53 PM

#

Hmm isn't the field just initialized with an empty string?

upbeat hare Oct 22, 2023, 4:53 PM

#

Wait no the field is initialized

#

the context key is never initialized

stiff crater Oct 22, 2023, 4:55 PM

#

Ah can't you just init it with the field name then?

upbeat hare Oct 22, 2023, 4:56 PM

#

Actually, I can do it another way

#

A much simpler way

#

.RebuildDataContext should work

#

@stiff crater

#

On the stock kerbal K2

stiff crater Oct 22, 2023, 5:01 PM

#

Niiice

upbeat hare Oct 22, 2023, 5:01 PM

#

There is also the issue of the timer not ticking down for this though

#

So it seems to be an issue of all crafts not created from the OAB while the mod was installed

#

And this is also wrong

stiff crater Oct 22, 2023, 5:04 PM

#

upbeat hare There is also the issue of the timer not ticking down for this though

Hmm, I'll check this on my side

upbeat hare Oct 22, 2023, 5:07 PM

#

stiff crater Hmm, I'll check this on my side

Do try with the latest dev branch of PM

#

And make sure to wipe whatever cached stuff

stiff crater Oct 22, 2023, 5:12 PM

#

No more null data bugs!

#

(Many other bugs in my code tho)

stiff crater Oct 22, 2023, 5:17 PM

#

upbeat hare And this is also wrong

And this is weird, I'll look into what could cause that

#

Hmmm we might have broken some stuff

upbeat hare Oct 22, 2023, 5:22 PM

#

The fuck

#

I'll do some more debugging in a minute

stiff crater Oct 22, 2023, 5:23 PM

#

stiff crater Hmmm we might have broken some stuff

Steps:
1 - Load a in-flight save created prior to mod install
2 - Go to main menu without saving
3 - Load a save which was in the VAB

#

My KSC is not happy

upbeat hare Oct 22, 2023, 5:24 PM

#

How in the name of all that is unholy

stiff crater Oct 22, 2023, 5:25 PM

#

stiff crater My KSC is not happy

flashing lights warning

upbeat hare Oct 22, 2023, 5:26 PM

#

I uhh ... okay ... what

#

Okay I think I know how I might fix this though

#

Maybe I don't add some stuff in the OAB like I have been

#

And only in flight

upbeat hare Oct 22, 2023, 5:54 PM

#

stiff crater Steps: 1 - Load a in-flight save created prior to mod install 2 - Go to main me...

Yep, can reproduce

#

Best I can tell, this bug existed before this fix :/

upbeat hare Oct 22, 2023, 6:16 PM

#

Probably an issue with not adding modules to already in flight craft

stiff crater Oct 22, 2023, 6:59 PM

#

upbeat hare And this is also wrong

Okay seems like the ComponentModule of the module is null, that must be the cause of the issue (and the reason why LS wasn't ticking, the resource consumption happens in the ComponentModule)

upbeat hare Oct 22, 2023, 7:00 PM

#

stiff crater Okay seems like the ComponentModule of the module is null, that must be the caus...

I'll have to look at what sets that

#

Well of course it isn't just made out of nowhere

#

Ahh so its synced in the InstantiateViewObjec function

stiff crater Oct 22, 2023, 7:58 PM

#

upbeat hare Ahh so its synced in the InstantiateViewObjec function

Does this make it hard to initialize for PM stuff?

#

(all this module shenanigans look annoying, I wonder if Module Manager in KSP1 needed those kind of fixes)

upbeat hare Oct 23, 2023, 1:38 AM

#

stiff crater Does this make it hard to initialize for PM stuff?

Yeahhh its gonna be annoying

#

I have to find the proper place to hook into the sim object

upbeat hare Oct 23, 2023, 11:56 AM

#

Alright is it time to delve 3 layers deep into hell?

#

I think it is

#

Maybe even 4

digital cloud Oct 23, 2023, 11:59 AM

#

Don't forget your boots and gloves!

#

Fire-proof skivvies may be in order too...

upbeat hare Oct 23, 2023, 12:00 PM

#

Dont worry im an expert in diving into hell by now

stiff crater Oct 23, 2023, 12:02 PM

#

Next we need a mod that revamps the async asset loading system, just to really get to know the deepest darkest parts of hell klueless

upbeat hare Oct 23, 2023, 12:02 PM

#

IG should just hire me to make these tools, it'd be a lot easier

#

Alright, I need to make an updated estimate

#

5 layers

#

But I think I found the code I want to hook

#

It was somewhere slightly different ... but I think I have a course of action

#

Also @stiff crater kerbals are prefabs lol

#

Hell if I do this magic correctly, I might be able to fix other bugs

stiff crater Oct 23, 2023, 12:38 PM

#

upbeat hare Also <@192177564800909312> kerbals are prefabs lol

So they are different from normal parts? (Don't know what them being prefabs implies)

upbeat hare Oct 23, 2023, 12:38 PM

#

stiff crater So they are different from normal parts? (Don't know what them being prefabs imp...

Nah they are basically the same

#

Just means we have to hook adding components a different way

#

[HarmonyPrefix]
    [HarmonyPatch(typeof(PartComponent), nameof(PartComponent.MergePartModuleData))]
    internal static void SetDefinition(object definitionData)
    {
        if (definitionData is PartDefinition partDefinition)
        {
            var name = partDefinition.Properties.partName;
            var def = GameManager.Instance.Game.Parts.Get(name);
            for (var i = partDefinition.Modules.Count - 1; i >= 0; i--)
            {
                if (def.data.serializedPartModules.All(x => x.Name != partDefinition.Modules[i].Name))
                {
                    partDefinition.Modules.RemoveAt(i);
                }
            }

            foreach (var mod in def.data.serializedPartModules)
            {
                if (partDefinition.Modules.All(x => x.Name != mod.Name))
                {
                    partDefinition.Modules.Add(mod);
                }
            }
        }
    }

Anyways heres hoping this works

#

But wait, I may be better off yet completely hooking something

#

Not yet thouhg

#

Cuz if I can find where that data is set lol

#

I can just modify it there once

#

and have magic occur

#

Nope, in fact stuff was more broken after that "fix"

#

Ahhhh

#

The fuck

#

Ahhh I was being an idiot

#

Ayooooo

#

Thats a stock vehicle spawned on the launchpad from the KSC

#

Getting this still from the EVA kerbal

stiff crater Oct 23, 2023, 1:28 PM

#

upbeat hare Getting this still from the EVA kerbal

Might be my bad, I'll try to check later today

#

If both the ComponentModule & ModuleData are correctly initialized, this should be a bug on my end

upbeat hare Oct 23, 2023, 1:33 PM

#

No I think its one on my end

upbeat hare Oct 23, 2023, 1:53 PM

#

Added to an existing vessel

#

The last one is going to have to be the kerbal

#

Alright, I see both ComponentModule and ModuleData being initialized

#

So it might be on your end

stiff crater Oct 23, 2023, 2:07 PM

#

I'll have a look, thanks for all your work on this issue!

upbeat hare Oct 23, 2023, 2:09 PM

#

I also pushed all the stuff I just did

#

Damn that person who made the hooks for campaign loading in spacewarp however long ago, their work came in handy

#

(I use that to update already extant vessels)

stiff crater Oct 23, 2023, 4:08 PM

#

upbeat hare Getting this still from the EVA kerbal

I didn't encounter the issue so an unrelated thing that I fixed yesterday might have fixed that, could you try again with this version if you have some time?

📎 KerbalLifeSupportSystem-0.1.0.zip

#

But all in all I think PM is nearing a decent state for a first release!

stiff crater Oct 23, 2023, 4:09 PM

#

stiff crater My KSC is not happy

Was this fixed by your many fixes or is this still an issue?

upbeat hare Oct 23, 2023, 4:09 PM

#

I'm not sure if that was fixed I did not test

stiff crater Oct 23, 2023, 4:09 PM

#

Alr I'll test it rq

upbeat hare Oct 23, 2023, 4:10 PM

#

Did you encounter any issues?

#

This is something I think may be caused by PM but I'm not sure

stiff crater Oct 23, 2023, 4:11 PM

#

upbeat hare This is something I think may be caused by PM but I'm not sure

How did this happen?

upbeat hare Oct 23, 2023, 4:12 PM

#

stiff crater How did this happen?

Not sure, it happened when loading into a save

stiff crater Oct 23, 2023, 4:14 PM

#

Hmm I have an issue with LS resources not ticking when loading a save that predates mod install, I'll check what is going on rq

upbeat hare Oct 23, 2023, 4:16 PM

#

Odd, I'm not having that issue

stiff crater Oct 23, 2023, 4:18 PM

#

stiff crater Hmm I have an issue with LS resources not ticking when loading a save that preda...

Ok nvm that was an issue of my UI vessel list not refreshing correctly (as well as the CR UI resize, I'll have a look at that)

upbeat hare Oct 23, 2023, 4:46 PM

#

stiff crater Ok nvm that was an issue of my UI vessel list not refreshing correctly (as well ...

So basically everything is working?

stiff crater Oct 23, 2023, 4:46 PM

#

As far as I can see yeah

stiff crater Oct 23, 2023, 4:48 PM

#

stiff crater My KSC is not happy

I'll try to repdroduce this

desert stirrup Oct 23, 2023, 4:49 PM

#

upbeat hare This is something I think may be caused by PM but I'm not sure

If you have H.U.M.A.N.S. installed, empty portraits can sometimes happen on game load or scene changes.

upbeat hare Oct 23, 2023, 4:49 PM

#

desert stirrup If you have H.U.M.A.N.S. installed, empty portraits can sometimes happen on game...

Just PM, CR, and KLSS in my test install

desert stirrup Oct 23, 2023, 4:50 PM

#

(good to know it's not caused by HUMANS. Offtopic, sorry)

upbeat hare Oct 23, 2023, 4:50 PM

#

Might just be a base game bug

desert stirrup Oct 23, 2023, 4:51 PM

#

But it's not caused by PM, CR and KLSS as I don't have them in my dev install and it still happens, so yeah, game bug

stiff crater Oct 23, 2023, 4:51 PM

#

Huh

#

(was still doing some loading in-flight save -> return to menu without saving -> loading other in-flight save)

upbeat hare Oct 23, 2023, 4:54 PM

#

I dont understand, I dont touch those functuons

stiff crater Oct 23, 2023, 4:55 PM

#

Might be some other mod doing some weird stuff, but the only one I opened was the Message watcher one

desert stirrup Oct 23, 2023, 4:56 PM

#

ShowKSP2Events? It doesn't touch those as well. Game bug probably?

upbeat hare Oct 23, 2023, 4:56 PM

#

Would have to reproduce in stock

upbeat hare Oct 23, 2023, 5:05 PM

#

desert stirrup (good to know it's not caused by HUMANS. Offtopic, sorry)

Also dw i dont bite about offtopicness unless its really offtopi"

stiff crater Oct 23, 2023, 5:07 PM

#

stiff crater Ok nvm that was an issue of my UI vessel list not refreshing correctly (as well ...

Oh I see why this is happening, the MessageCenter is shut down when quitting to main menu, so I'd need to resubscribe at each reload? (How? Could the SpaceWarp loading hooks help me here?)

upbeat hare Oct 23, 2023, 5:12 PM

#

stiff crater Oh I see why this is happening, the MessageCenter is shut down when quitting to ...

... I think I need to modify some sw stuff then

north mist Oct 23, 2023, 5:13 PM

#

one solution I can think of is to just keep checking whether Game.GlobalGameState.GetGameState().GameState == GameState.MainMenu in an Update method, but that's obviously not ideal

stiff crater Oct 23, 2023, 5:25 PM

#

stiff crater Oh I see why this is happening, the MessageCenter is shut down when quitting to ...

Update, when subscribing to a message you can set the handle to be persistent so it isn't removed on shutdown

upbeat hare Oct 23, 2023, 5:25 PM

#

stiff crater Update, when subscribing to a message you can set the handle to be persistent so...

Ahh sw automatically makes its subscriptions persistent

stiff crater Oct 23, 2023, 5:29 PM

#

It indeed works way better with PersistentSubscribe<> x)

upbeat hare Oct 24, 2023, 12:45 PM

#

We should set up a gh action to auto build patch manager

maiden wraith Oct 24, 2023, 2:54 PM

#

any significant changes to PM?

stiff crater Oct 24, 2023, 2:55 PM

#

It works now! (Module & recipe patching had some issues)

#

No celestial body stuff yet tho

upbeat hare Oct 24, 2023, 2:56 PM

#

Oh yeah I figured out how to add modules to already existing vessels in a save

upbeat hare Oct 24, 2023, 10:38 PM

#

If munix concurs, we should release this once 0.1.5 comes out

north mist Oct 24, 2023, 10:43 PM

#

yep, it's high time, now that people are actually using this to make mods!

digital cloud Oct 24, 2023, 11:07 PM

#

north mist yep, it's high time, now that people are actually using this to make mods!

Yay! I’ll have a new version of SPARK ready to go

upbeat hare Oct 24, 2023, 11:08 PM

#

Should it be named 0.2.0 or 1.0.0?

desert stirrup Oct 24, 2023, 11:13 PM

#

1.0.0

north mist Oct 24, 2023, 11:38 PM

#

1.0.0 to me kinda evokes it being a feature-finished thing (which will get extra features later)

#

which I don't think I would consider it to be

desert stirrup Oct 24, 2023, 11:43 PM

#

I consider 1.0.0 to be the first publicly available version, not in beta, but fully functional. Not necessarily feature complete.

#

But both approaches are valid.

#

then there's RSS that's on v20 currently 🙂
https://github.com/KSP-RO/RealSolarSystem/releases

upbeat hare Oct 24, 2023, 11:45 PM

#

1.0.0 also means we cant change api

north mist Oct 24, 2023, 11:46 PM

#

yeah, that's another thing

#

we use semantic versioning, unlike RSS or software like Chrome

upbeat hare Oct 25, 2023, 9:05 PM

#

So yeah, once space warp is updated, I am pushing this out :3

upbeat hare Oct 26, 2023, 11:03 AM

#

Anyways ... I need to update PM then likely need to wait for a klss update from @stiff crater to test with and push this out

#

Alright, PM has been updated and I tested with my crew cap patch on a save without the mod

upbeat hare Oct 26, 2023, 11:47 AM

#

@north mist thoughts?

north mist Oct 26, 2023, 11:48 AM

#

nice!

upbeat hare Oct 26, 2023, 11:49 AM

#

having a generic UITK element there for stuff is nice

#

Anyways going to add a configuration option and that should be it

#

Or rather a way for modules to bind their own configurations

#

Added a config option to always invalidate the cache as well

#

#

And here's what that details pain looks like with an invalidated cache

north mist Oct 26, 2023, 12:01 PM

#

very useful, cool!

upbeat hare Oct 26, 2023, 12:02 PM

#

(if you could add to the cache a summary of all the patches and such that would be useful)

#

Honestly I'd prefer a summary of patches and new asset creations per label

#

Is that something that is doable munix?

north mist Oct 26, 2023, 12:06 PM

#

it should be I guess?

#

I'll look into it after I fix UitkForKsp2

upbeat hare Oct 26, 2023, 12:06 PM

#

Its not critical

upbeat hare Oct 27, 2023, 12:56 PM

#

@digital cloud try setting PM to always rebuild cache

#

tis in the latest build as a setting

digital cloud Oct 27, 2023, 2:16 PM

#

Dumb question. I think my local copy is fully synced with the dev branch, but when I build for deploy it does not put it in the game folder and I also don't get it here

#

upbeat hare Oct 27, 2023, 2:17 PM

#

I honestly never use deploy

digital cloud Oct 27, 2023, 2:17 PM

#

📎 message.txt

#

What's your process?

north mist Oct 27, 2023, 2:17 PM

#

that's weird, I'll need to take a look at that

upbeat hare Oct 27, 2023, 2:18 PM

#

digital cloud What's your process?

I always build using debug and let munix handle the nuget

digital cloud Oct 27, 2023, 2:18 PM

#

📎 message.txt

#

Not even a Dubug folder made

#

upbeat hare Oct 27, 2023, 2:19 PM

#

Oddd

digital cloud Oct 27, 2023, 2:20 PM

#

The stuff in build\ob and build\bin is all from 9/30

#

Not that's not right. Only the parent folders are that old. There's this buried deep inside it

#

upbeat hare Oct 27, 2023, 2:22 PM

#

Waiitt

#

I know

#

We are likely copying from netstandard2.0

digital cloud Oct 27, 2023, 2:22 PM

#

Doh!

upbeat hare Oct 27, 2023, 2:23 PM

#

@north mist does this make sense?

digital cloud Oct 27, 2023, 2:23 PM

#

Hell yes it does

#

#

Those files are a match for what I've got installed in the game

#

No, the names are diff

#

The times are the same

upbeat hare Oct 27, 2023, 2:25 PM

#

Gimme a minute

#

I need to do some chores

digital cloud Oct 27, 2023, 2:25 PM

#

Me too... And Off I go!

north mist Oct 27, 2023, 2:26 PM

#

upbeat hare We are likely copying from netstandard2.0

that shouldn't matter

#

it's not hardcoded anywhere afaik

#

it's all MSBuild variables

#

so it should update accordingly

upbeat hare Oct 27, 2023, 2:35 PM

#

@digital cloud I just ran deploy on the latest dev branch ... and it worked perfectly fine creating a folder in the deploy directory

north mist Oct 27, 2023, 2:35 PM

#

yeah I was just about to say, I tested it right now and it did everything correctly

#

with DeployAndRun

#

though it doesn't actually seem to work in-game, there were some exceptions

#

upbeat hare Oct 27, 2023, 2:37 PM

#

I thought I fixed that

north mist Oct 27, 2023, 2:37 PM

#

I did fetch and pull before

#

so I'm sure I have the latest version

upbeat hare Oct 27, 2023, 2:37 PM

#

Thats the line that error references though

#

Are you on main or dev?

north mist Oct 27, 2023, 2:37 PM

#

dev

upbeat hare Oct 27, 2023, 2:38 PM

#

Yeah thate rror makes no sense

#

Like legit that error shouldn't be happening

north mist Oct 27, 2023, 2:39 PM

#

this was on a clean install where PM had never been installed before, either

#

wait wtf

#

now I deleted it, rebuilt

#

and it works

#

ok I'm not even gonna question it

#

lol

#

should it be showing patched labels even though I have 0 patches?

upbeat hare Oct 27, 2023, 2:41 PM

#

0 patches

#

but it did have creations

#

wait you odn't have CR

north mist Oct 27, 2023, 2:41 PM

#

yeah I don't

upbeat hare Oct 27, 2023, 2:41 PM

#

patched labels is more gonna be meant for a breakdown

#

but I want that info in the cache

north mist Oct 27, 2023, 2:42 PM

#

interesting

#

yeah my cache is currently completely empty

#

no inventory file or nothing

upbeat hare Oct 27, 2023, 2:42 PM

#

Might want to deal with this error if it crops up

upbeat hare Oct 27, 2023, 2:42 PM

#

north mist no inventory file or nothing

Thats normal

#

you don't have any patches

north mist Oct 27, 2023, 2:43 PM

#

yeah yeah

#

I meant more so for the "parts_data" and "resources" labels

upbeat hare Oct 27, 2023, 2:43 PM

#

Actually wait I have an idea of how to deal with that error

#

Yeah, the cache shouldn't be built if nothing changred

north mist Oct 27, 2023, 2:44 PM

#

huh the Community Resources solution has no configurations

#

so I can't build it from Rider

stiff crater Oct 27, 2023, 2:45 PM

#

north mist huh the Community Resources solution has no configurations

That's not normal it had some last I checked

upbeat hare Oct 27, 2023, 2:45 PM

#

It has some for me

north mist Oct 27, 2023, 2:45 PM

#

#

it definitely should

#

weird

#

I had a very old version of the repo open in Rider and just did a pull

#

but when I closed and reopened it, they now appeared

#

ah yeah

#

so now I'm on the same error as schlosrat

#

[Info   :Patch Manager] Loading patchers from C:\Games\KSP Instances\KSP 2 Debug\BepInEx\plugins\CommunityResources
[Error  :Patch Manager] error parsing C:\Games\KSP Instances\KSP 2 Debug\BepInEx\plugins:base_fuels.patch - 1:7: mismatched input '<EOF>' expecting {'@use', '@function', '@if', '@mixin', '@require', '@require-not', '@stage', '@define-stage', '@patch', '@new', '(', '+', '*', '~', NAME, CLASS, VARIABLE, RULESET, ENSURE, ELEMENT}
[Error  :Patch Manager] Could not run patch: C:\Games\KSP Instances\KSP 2 Debug\BepInEx\plugins:base_fuels.patch due to: parser errors detected
[Error  :Patch Manager] Could not run patch: C:\Games\KSP Instances\KSP 2 Debug\BepInEx\plugins:life_support.patch due to: C:\Games\KSP Instances\KSP 2 Debug\BepInEx\plugins\CommunityResources\patches\life_support.patch:39:14: Numbers must be parsable as a double precision floating point number
[Error  :Patch Manager] Could not run patch: C:\Games\KSP Instances\KSP 2 Debug\BepInEx\plugins:recipes.patch due to: C:\Games\KSP Instances\KSP 2 Debug\BepInEx\plugins\CommunityResources\patches\recipes.patch:10:28: Numbers must be parsable as a double precision floating point number

upbeat hare Oct 27, 2023, 2:49 PM

#

Waht is that file name

#

why is it doing that

north mist Oct 27, 2023, 2:49 PM

#

#

LOL

#

ok that explains it

upbeat hare Oct 27, 2023, 2:49 PM

#

Yeah that will break it

north mist Oct 27, 2023, 2:50 PM

#

I'm assuming a regular /* */ CSS comment will work?

#

yep it does

#

let me change that

upbeat hare Oct 27, 2023, 2:51 PM

#

The parser skips over comments

#

so its expecting there to be something in the file

north mist Oct 27, 2023, 2:51 PM

#

it works with the /**/ comment though

#

// isn't a valid CSS comment

upbeat hare Oct 27, 2023, 2:51 PM

#

wtf antlr

desert stirrup Oct 27, 2023, 2:51 PM

#

life_support.patch has plently of single comments //

north mist Oct 27, 2023, 2:52 PM

#

ah ok

#

then that's definitely weird

#

[Error  : Unity Log] NullReferenceException: Object reference not set to an instance of an object
Stack trace:
PatchManager.Parts.Patchers.UpdateSavedVesselPartDefinitions.DoAction (System.Action resolve, System.Action`1[T] reject) (at C:/Games/KSP Stuff/KSP 2 Modding/Mods/PatchManager/src/PatchManager.Parts/Patchers/UpdateSavedVesselPartDefinitions.cs:18)
KSP.Game.Flow.FlowAction.Do (System.Action`1[T] resolve, System.Action`2[T1,T2] reject) (at <483cd9805b7642b5be13e081b9a5d1b4>:0)
(wrapper dynamic-method) KSP.Game.Flow.SequentialFlow.DMD<KSP.Game.Flow.SequentialFlow::NextFlowAction>(KSP.Game.Flow.SequentialFlow)
KSP.Game.Flow.SequentialFlow.Update () (at <483cd9805b7642b5be13e081b9a5d1b4>:0)

#

campaign loading stuck on this

upbeat hare Oct 27, 2023, 2:52 PM

#

Did they change something again

north mist Oct 27, 2023, 2:53 PM

#

probably

upbeat hare Oct 27, 2023, 2:54 PM

#

Ahh wtf

#

That error makes sense'nt

#

can you show the full log

north mist Oct 27, 2023, 2:56 PM

#

📎 Player.log

#

but there isn't much else in there

#

either _loadGameData or SavedGame is null

upbeat hare Oct 27, 2023, 2:56 PM

#

Or vessels

north mist Oct 27, 2023, 2:57 PM

#

or

#

yeah

upbeat hare Oct 27, 2023, 2:57 PM

#

Hmm, was that in campaign creation or campaign load

north mist Oct 27, 2023, 2:57 PM

#

campaign creation

#

I deleted the old one to start fresh

upbeat hare Oct 27, 2023, 2:58 PM

#

Ohh

#

Okay maybe the default one has a null vessels field and I didn't know

#

Gonna do some debug logging

#

The odd part is I'm not getting the same errors you are from CR I don't think

north mist Oct 27, 2023, 3:00 PM

#

I just deleted the base fuels file for now

#

but yeah that always pops up

upbeat hare Oct 27, 2023, 3:00 PM

#

No I am

#

And of course the error is preventing PM from doing its job

north mist Oct 27, 2023, 3:01 PM

#

huh? do debug logs from flow actions not show up?

upbeat hare Oct 27, 2023, 3:02 PM

#

Use the logging class

north mist Oct 27, 2023, 3:02 PM

#

and now I'm also getting this

[Info   :Patch Manager] Loading patchers from C:\Games\KSP Instances\KSP 2 Debug\BepInEx\plugins\CommunityResources
[Error  :Patch Manager] Could not run patch: C:\Games\KSP Instances\KSP 2 Debug\BepInEx\plugins:life_support.patch due to: C:\Games\KSP Instances\KSP 2 Debug\BepInEx\plugins\CommunityResources\patches\life_support.patch:39:14: Numbers must be parsable as a double precision floating point number
[Error  :Patch Manager] Could not run patch: C:\Games\KSP Instances\KSP 2 Debug\BepInEx\plugins:recipes.patch due to: C:\Games\KSP Instances\KSP 2 Debug\BepInEx\plugins\CommunityResources\patches\recipes.patch:10:28: Numbers must be parsable as a double precision floating point number

upbeat hare Oct 27, 2023, 3:03 PM

#

Show those lines

#

I'm having a thing where PM thinks its inventory is always correct

north mist Oct 27, 2023, 3:05 PM

#

north mist huh? do debug logs from flow actions not show up?

nevermind I'm once again after quite some time getting that annoying thing where DeployAndRun doesn't seem to copy over the newest assemblies

#

ahhhh

upbeat hare Oct 27, 2023, 3:05 PM

#

north mist Oct 27, 2023, 3:06 PM

#

buh

upbeat hare Oct 27, 2023, 3:07 PM

#

I broke stuff trying to add an always invalidate option lol

#

Fixing now

north mist Oct 27, 2023, 3:08 PM

#

costPerUnit: 0.8;

#

this line throws the error that Numbers must be parsable as a double precision floating point number

upbeat hare Oct 27, 2023, 3:08 PM

#

That is obviously incorrect

north mist Oct 27, 2023, 3:09 PM

#

the number or the error?

upbeat hare Oct 27, 2023, 3:09 PM

#

The error

#

That makes no sense

north mist Oct 27, 2023, 3:09 PM

#

yeah...

upbeat hare Oct 27, 2023, 3:09 PM

#

Its vessels thats null

north mist Oct 27, 2023, 3:09 PM

#

apparently doubles are now broken

upbeat hare Oct 27, 2023, 3:09 PM

#

simple enough to fix

digital cloud Oct 27, 2023, 3:10 PM

#

Hey, I'm having an issue here. I think my local copy is synced with the dev branch, but when I do a Debug or Deploy I get bupkis

#

On my GitHib fork it shows this

upbeat hare Oct 27, 2023, 3:10 PM

#

I just pushed some more stuff fixing some of my issues

digital cloud Oct 27, 2023, 3:10 PM

#

north mist Oct 27, 2023, 3:10 PM

#

digital cloud Hey, I'm having an issue here. I *think* my local copy is synced with the dev br...

both PM and CR are currently somewhat broken

#

so I don't know if it's any use

#

but building works fine for me

digital cloud Oct 27, 2023, 3:11 PM

#

Yeah, but still, I'm either not getting anything to build here, or not understanding what it's doing and where to get what it builds

north mist Oct 27, 2023, 3:11 PM

#

what are those extra 7 commits?

digital cloud Oct 27, 2023, 3:11 PM

#

#

#

There are 7 commits, but in total only 1 file changed and the change should not be an issue

#

I think...

north mist Oct 27, 2023, 3:13 PM

#

yeah it shouldn't

#

try deleting the build and dist folders, do a nuget restore, and rebuild

#

though Cheese did just push another update to the dev branch a couple of minutes ago

#

so you might also want to pull that in

upbeat hare Oct 27, 2023, 3:15 PM

#

I don't think its fixing that error that you encountered though munix...

#

I added this to the top of that function but I still can't load into a new game

north mist Oct 27, 2023, 3:15 PM

#

upbeat hare Oct 27, 2023, 3:15 PM

#

Back when I only had half a shield

north mist Oct 27, 2023, 3:15 PM

#

lol

digital cloud Oct 27, 2023, 3:16 PM

#

OK I re-synced and picked up whatever Cheese did.

#

Remind me, what do I need to do to do a nuget restore?

#

That's a command line thing, right?

north mist Oct 27, 2023, 3:17 PM

#

there definitely is a UI thing for it in VS

digital cloud Oct 27, 2023, 3:17 PM

#

even better!

north mist Oct 27, 2023, 3:17 PM

#

I just don't know where, I don't use that steaming load of garbage

#

munley

upbeat hare Oct 27, 2023, 3:17 PM

#

OHH

#

I'm a dumbass

#

I know what I broke

digital cloud Oct 27, 2023, 3:18 PM

#

I like this steaming load of garbage! It's way cheaper that that hunk of junk you're flying

upbeat hare Oct 27, 2023, 3:18 PM

#

I never called resolve

digital cloud Oct 27, 2023, 3:18 PM

#

And it works just fine for me!

north mist Oct 27, 2023, 3:18 PM

#

digital cloud I like this steaming load of garbage! It's way cheaper that that hunk of junk yo...

I mean, I'm flying it for free, with a student license

#

klueless

digital cloud Oct 27, 2023, 3:18 PM

#

LOL!

#

Long gone are my days of that

upbeat hare Oct 27, 2023, 3:19 PM

#

I mean, just become a long time contributor on a project and maybe we can convince jetbrains to give it to you

#

Hmm adding a call to resolve did not wokr

#

I pushed my stuff

#

I need to go grab lunch

north mist Oct 27, 2023, 3:20 PM

#

north mist I just don't know where, I don't use that steaming load of garbage

ok you need to right click your solution and there click Restore NuGet packages

upbeat hare Oct 27, 2023, 3:20 PM

#

I'll do more bug fixing after lunch

north mist Oct 27, 2023, 3:22 PM

#

that fixed the campaign loading bug after creation for me

digital cloud Oct 27, 2023, 3:22 PM

#

https://learn.microsoft.com/en-us/nuget/consume-packages/package-restore

NuGet Package Restore

See an overview of how NuGet restores packages a project depends on, including how to disable restore and constrain versions.

#

Piece of cake!

north mist Oct 27, 2023, 3:23 PM

#

north mist ok you need to right click your solution and there click Restore NuGet packages

.

upbeat hare Oct 27, 2023, 3:24 PM

#

north mist that fixed the campaign loading bug after creation for me

Wtf

digital cloud Oct 27, 2023, 3:25 PM

#

north mist .

Yeah I did that. And then I re-did the sync, and then did a pull down to my local machine, then a Deploy.

north mist Oct 27, 2023, 3:25 PM

#

well if it compiled without errors, then the restore worked

digital cloud Oct 27, 2023, 3:25 PM

#

And now I've got an new build folder, but not a dist

north mist Oct 27, 2023, 3:25 PM

#

lifesupport

digital cloud Oct 27, 2023, 3:26 PM

#

📎 message.txt

north mist Oct 27, 2023, 3:26 PM

#

can you try to Rebuild?

#

not build

#

though that probably won't help

digital cloud Oct 27, 2023, 3:27 PM

#

Done, and you're right

north mist Oct 27, 2023, 3:27 PM

#

ok let me try to clone your repo

#

I cloned the repo, opened it in VS, tried a Debug build, and it created the dist/Debug folder like it should

#

so I would suggest just completely deleting your local version and cloning it again

#

no clue how else to help

digital cloud Oct 27, 2023, 3:32 PM

#

Will do.

#

That worked.

north mist Oct 27, 2023, 3:35 PM

#

good to hear

digital cloud Oct 27, 2023, 3:38 PM

#

#

I probably have something goofed up in CR

north mist Oct 27, 2023, 3:38 PM

#

you don't

#

#1115274490490929172 message

#

it's another PM bug

#

which causes the CR patches not to load

digital cloud Oct 27, 2023, 3:40 PM

#

The above errors occured when I placed a lithium tank on my contraption. Placing an lithium engine gives rise to a total freakout

north mist Oct 27, 2023, 3:40 PM

#

yeah, that's probably to be expected if the resources don't exist

digital cloud Oct 27, 2023, 3:40 PM

#

Seems reasonable

north mist Oct 27, 2023, 3:41 PM

#

hopefully we'll be able to fix this today to get everything ready for tomorrow

digital cloud Oct 27, 2023, 3:41 PM

#

No worries. I'm going to go work on making a simple methylox engine - the kind without a plume apparently 😉

#

Changing it over to be an OP engine will be a no brainer once you guys have this working.

upbeat hare Oct 27, 2023, 3:46 PM

#

I dont know whats causing doubles to stop working suddenly

north mist Oct 27, 2023, 3:46 PM

#

yeah that's really weird

#

upbeat hare Oct 27, 2023, 3:46 PM

#

I bet its the 2.0 to 2.1 change for some reason

north mist Oct 27, 2023, 3:46 PM

#

like why would double.TryParse fail on these

upbeat hare Oct 27, 2023, 3:47 PM

#

:/

north mist Oct 27, 2023, 3:47 PM

#

does it happen for you too?

#

because

#

localization

#

I have Czech, and we use decimal comma, not dot

upbeat hare Oct 27, 2023, 3:47 PM

#

Not when I last checked

#

Wait

north mist Oct 27, 2023, 3:47 PM

#

https://stackoverflow.com/a/8463665

Stack Overflow

Why double.TryParse("0.0000", out doubleValue) returns false ?

I am trying to parse string "0.0000" with double.TryParse() but I have no idea why would it return false in this particular example. When I pass integer-like strings e.g. "5" it parses correctly to...

upbeat hare Oct 27, 2023, 3:48 PM

#

That should be an easy fix then?

north mist Oct 27, 2023, 3:48 PM

#

we probably need to add the culture info

#

yeah

upbeat hare Oct 27, 2023, 3:49 PM

#

Invariant culture

north mist Oct 27, 2023, 3:50 PM

#

yep that fixed it

upbeat hare Oct 27, 2023, 3:50 PM

#

Wow

#

I hate localization

north mist Oct 27, 2023, 3:50 PM

#

so theoretically this isn't the bug @digital cloud has been encountering

#

since he's probably using US settings in Windows

upbeat hare Oct 27, 2023, 3:51 PM

#

He was encountering the base furls one

#

Push it anyeays

north mist Oct 27, 2023, 3:51 PM

#

ah

#

I'm adding it to all .TryParse calls in the code, just to make sure

#

since it could affect ints as well

stiff crater Oct 27, 2023, 3:54 PM

#

upbeat hare I hate localization

I had a friend at a previous internship that spent multiple days going mad at an incomprehensible bug in Java that was actually just a localization issue due to a mismatch between his computer & the servers

north mist Oct 27, 2023, 3:54 PM

#

yeah these are the absolute worst

upbeat hare Oct 27, 2023, 3:54 PM

#

Did this restaurant just start playing never gonna give you up

north mist Oct 27, 2023, 3:55 PM

#

lmao

#

rickrolled while eating

upbeat hare Oct 27, 2023, 3:55 PM

#

I normally dont pay attention to the music

#

But when its a rickroll

#

Why are there even languages that use a comma as the radix point

north mist Oct 27, 2023, 3:57 PM

#

no clue

#

our number format is 1 000 000,000

upbeat hare Oct 27, 2023, 3:58 PM

#

Eww

north mist Oct 27, 2023, 3:58 PM

#

compared to 1,000,000.000

#

though I prefer the US one, to be honest

#

that's like the one thing from math/physics that I feel like the US makes more sense in

#

munley

stiff crater Oct 27, 2023, 3:59 PM

#

north mist our number format is `1 000 000,000`

Same in French yeah

upbeat hare Oct 27, 2023, 3:59 PM

#

Thats cuz its Fr*nch

north mist Oct 27, 2023, 3:59 PM

#

@digital cloud do you have the Lithium patch anywhere so I can test it with SPARK?

digital cloud Oct 27, 2023, 4:00 PM

#

📎 base_fuels.patch

#

📎 recipes.patch

north mist Oct 27, 2023, 4:00 PM

#

thanks!

digital cloud Oct 27, 2023, 4:00 PM

#

Hang on, the recipies is wrong

upbeat hare Oct 27, 2023, 4:00 PM

#

upbeat hare Thats cuz its Fr*nch

Yall have a language standardization institution and still cant decide on objectively correct standards

north mist Oct 27, 2023, 4:01 PM

#

I think we can all agree French is weird

#

klueless

#

like wtf is a quatre-vingt-quatre

digital cloud Oct 27, 2023, 4:02 PM

#

📎 recipes.patch

#

Try that one instead

upbeat hare Oct 27, 2023, 4:02 PM

#

That feels like either 100 or 64 to me

north mist Oct 27, 2023, 4:02 PM

#

84

#

4*20+4

stiff crater Oct 27, 2023, 4:02 PM

#

upbeat hare Yall have a language standardization institution and still cant decide on object...

It's not a standardization institution, it's just a bunch of old annoying dudes that publish 1 dictionary per century klueless

upbeat hare Oct 27, 2023, 4:03 PM

#

And think they are objectively correct about languafe

#

While also being prescriptivist

stiff crater Oct 27, 2023, 4:03 PM

#

Yep, I don't like them a bit (but we're getting off-topic)

upbeat hare Oct 27, 2023, 4:03 PM

#

True

north mist Oct 27, 2023, 4:08 PM

#

there we go

#

LithiumEC works!

#

but

#

it doesn't show up in flight view

#

stiff crater Oct 27, 2023, 4:09 PM

#

On the staging?

north mist Oct 27, 2023, 4:09 PM

#

in the vessel-resources window

#

and elsewhere I just see "R..."

stiff crater Oct 27, 2023, 4:10 PM

#

That's normal, only "non fuel" resources (except monoprop) show up here

north mist Oct 27, 2023, 4:10 PM

#

stiff crater Oct 27, 2023, 4:10 PM

#

north mist and elsewhere I just see "R..."

Localization issue most likely

north mist Oct 27, 2023, 4:10 PM

#

yep

#

but other than that, the engine is running!

#

so that's good news

#

and in the OAB it correctly shows Lithium

stiff crater Oct 27, 2023, 4:11 PM

#

Nice, I'm going to test module patching as soon as I upgrade my unity project for klss

north mist Oct 27, 2023, 4:12 PM

#

so, now we're basically just missing LFO and we can make engines with any fuels

#

awesome

digital cloud Oct 27, 2023, 4:16 PM

#

There is one other problem, though unrelated to these. I'm messing around with the engine module parameters and it wont let me edit the animation curves like normal. Ordinarly you can Add Key, Edit Key and Delete Key. Now I can only Add Key, and editing it purely a graphical thing which is very much a holy PITA.

#

This has nothing to do with PM - sorry off topic

#

Wait, I can delete keys by selecting them and pressing delete...

#

And I can edit them by selecting and pressing enter!

#

Not a perfect world, but perfectly serviceable

#

You may now go on about your normal PM shenanigans. Carry on.

#

Oh.. Wait... Should the localization stuff for fuels and categories go into CR instead of in my engine mod? Does it matter?

north mist Oct 27, 2023, 4:20 PM

#

yeah it definitely should

#

since that's where they're defined

upbeat hare Oct 27, 2023, 4:20 PM

#

If the fuels themselves are in cr then their localization should

north mist Oct 27, 2023, 4:20 PM

#

other mods might use the resources and not everyone may have your mod installed

digital cloud Oct 27, 2023, 4:20 PM

#

Excellent point!

#

📎 english.csv

#

Help yourself!

upbeat hare Oct 27, 2023, 4:21 PM

#

And most resources mods use should go into community resources

digital cloud Oct 27, 2023, 4:21 PM

#

You only need a wee bit

upbeat hare Oct 27, 2023, 4:21 PM

#

As we dont want them to be doubly defined

digital cloud Oct 27, 2023, 4:21 PM

#

Agree!

#

Mind the Lithium. Do not allow it to come into contact with Perspiration whatever you do. Optimism should be OK.

north mist Oct 27, 2023, 4:23 PM

#

do we want perspiration and optimism in the community resources? it would make more sense to me to split them into a separate mod for the purposes of the workshop

upbeat hare Oct 27, 2023, 4:23 PM

#

And also having too many resources defined wont cause issues

#

Hmm maybe

#

I mean the separate mod would just be a swinfo, and 2 patch files

digital cloud Oct 27, 2023, 4:24 PM

#

📎 english.csv 📎 french.csv

north mist Oct 27, 2023, 4:24 PM

#

ideally they'd be in the inidivual modders' plugin_template patches

digital cloud Oct 27, 2023, 4:24 PM

#

My bad, those were from SPARK, these are from CR

north mist Oct 27, 2023, 4:24 PM

#

so they also see how to create custom resources

upbeat hare Oct 27, 2023, 4:24 PM

#

Yeah but when people actually publish the mods if they do

north mist Oct 27, 2023, 4:25 PM

#

hm

#

do we have that "create if not exists" thing in PM yet?

upbeat hare Oct 27, 2023, 4:25 PM

#

For modules

#

Not on assets

north mist Oct 27, 2023, 4:25 PM

#

ah

upbeat hare Oct 27, 2023, 4:26 PM

#

But hmm I could just do a check

#

Ideally though, if 2 assets collide it should be an error

#

It feels like a bandaid to have each mod create an asset if it does not exist

north mist Oct 27, 2023, 4:29 PM

#

yeah, I mean we can also just create a mod with just swinfo.json and these two resource definitions and localizations

#

and have people download the zip for the workshop

#

I guess that's the best compromise

stiff crater Oct 27, 2023, 4:30 PM

#

Would creating new fuels / recipes not be in the scope of the workshop tbh @digital cloud ?

digital cloud Oct 27, 2023, 4:31 PM

#

If the mods are working, then definitely yes. I've promissed as much

north mist Oct 27, 2023, 4:31 PM

#

oh btw @digital cloud before I commit the lithium/argon stuff to Community Resources, do you want to add an ArgonEC recipe?

#

since there currently isn't one

digital cloud Oct 27, 2023, 4:31 PM

#

We'll talk about using OP for fuel

#

The ArgonEC reciepie is the same as LithiumEC whcih is the same as XenonEC, except that it calls for Argon.

#

It's 1:1 with the actual control set as an override in the engine

north mist Oct 27, 2023, 4:33 PM

#

alrighty

digital cloud Oct 27, 2023, 4:33 PM

#

Please do add it!

north mist Oct 27, 2023, 4:33 PM

#

oh and one more thing

digital cloud Oct 27, 2023, 4:33 PM

#

Yes sir?

north mist Oct 27, 2023, 4:33 PM

#

there's Resources/DisplayName/Hydrolox, Resources/Abbreviation/HO, and the same for XE, but those localizations aren't in the file

#

I'm assuming I should add those, too

digital cloud Oct 27, 2023, 4:34 PM

#

Are those not in there?

north mist Oct 27, 2023, 4:34 PM

#

digital cloud Oct 27, 2023, 4:34 PM

#

Or do you mean OP?

north mist Oct 27, 2023, 4:34 PM

#

not in the files you sent

digital cloud Oct 27, 2023, 4:35 PM

#

I think I might have stepped on them when I was messing with PM and CR earlier

#

I'll get those to you ASAP

north mist Oct 27, 2023, 4:35 PM

#

thank you!

#

there are localizations for the individual resources, but not for the combined recipes

digital cloud Oct 27, 2023, 4:37 PM

#

Not sure if you need localization for the recipies. Those don't get displayed to players do they?

#

We need definitions for them, certainly

#

But localizations?

north mist Oct 27, 2023, 4:38 PM

#

I don't know, tbh

#

but it's a bit strange that the localization keys for them are used in the patches, but never defined anywhere

#

digital cloud Oct 27, 2023, 4:39 PM

#

📎 base_fuels.patch 📎 recipes.patch

#

Those are from my earlier effor in 0.1.4.1

#

I think they're correct, and they apply to CR/patches

upbeat hare Oct 27, 2023, 4:41 PM

#

I need to fix that hydrolox recipy

north mist Oct 27, 2023, 4:41 PM

#

digital cloud I think they're correct, and they apply to CR/patches

I've got those

#

but what I'm saying is

#

you have for example

    displayNameKey: "Resources/DisplayName/ArgonEC";
    abbreviationKey: "Resource/Abbreviation/AE";

#

aka it's using those two localization keys

#

but the localizations aren't defined anywhere

#

even if they aren't currently displayed in the UI, I think we should still provide them, to not leave any loose ends

digital cloud Oct 27, 2023, 4:43 PM

#

📎 english.csv

#

Hows this?

north mist Oct 27, 2023, 4:43 PM

#

if you look at that, there's no "Resources/DisplayName/ArgonEC"

#

etc

#

maybe I'm just being pedantic, but I think that if we use the keys, we should also define them

digital cloud Oct 27, 2023, 4:44 PM

#

Working on it.

stiff crater Oct 27, 2023, 4:44 PM

#

digital cloud

So we'll put OP in CR or in a separate mod? (I don't feel they fit CR)

north mist Oct 27, 2023, 4:45 PM

#

yeah, I'd do a separate mod

#

just for the purposes of the workshop

digital cloud Oct 27, 2023, 4:46 PM

#

📎 recipes.patch

#

📎 english.csv

#

We can split out the OP stuff if you like.

#

But I think thik sets things correctly. Note I made a small change to the recipie name to conform to the others

north mist Oct 27, 2023, 4:48 PM

#

thank you! I'll just do a minor correction to it

digital cloud Oct 27, 2023, 4:48 PM

#

As they are case sensitive

north mist Oct 27, 2023, 4:48 PM

#

since the recipes are plural Resources

digital cloud Oct 27, 2023, 4:48 PM

#

Of course!

upbeat hare Oct 27, 2023, 4:48 PM

#

I am so glad we got this all working today

digital cloud Oct 27, 2023, 4:48 PM

#

north mist since the recipes are plural Resources

Do you mean in the localization?

north mist Oct 27, 2023, 4:48 PM

#

yeah

#

but no problem

digital cloud Oct 27, 2023, 4:49 PM

#

I think that should remain sigula

#

Like XenonEC is just a "resource"

north mist Oct 27, 2023, 4:49 PM

#

I mean it would make sense to have singular resources as singular, and multiple as plural

#

but I think @stiff crater made those

#

what do you think?

digital cloud Oct 27, 2023, 4:49 PM

#

like in this? Resource/DisplayName/ArgonEC,Text,,ArgonEC

stiff crater Oct 27, 2023, 4:50 PM

#

iirc I just copied how it was done for stock stuff

digital cloud Oct 27, 2023, 4:50 PM

#

Isn't Resource a particular thing we're affecting and to change it would make it not work?

north mist Oct 27, 2023, 4:50 PM

#

no, it could be "MyFunnyResource/MyDisplayName/Hahaha" for all it cares

#

it's just a key

#

at least I think in this case, since you have to provide the key in the patch

digital cloud Oct 27, 2023, 4:51 PM

#

{
"name": "XenonEC",
"displayNameKey": "Resource/DisplayName/Xenon",
"abbreviationKey": "Resource/Abbreviation/Xe",
"resourceIconAssetAddress": "",
"ingredients":

#

That's how the game handles one

north mist Oct 27, 2023, 4:51 PM

#

it just has to be whatever you put here

north mist Oct 27, 2023, 4:51 PM

#

digital cloud { "name": "XenonEC", "displayNameKey": "Resource/DisplayName/Xen...

ah so it's using the same localization for both Xenon and XenonEC

#

but I'm pretty sure for Methalox it will be different

#

can you check that?

digital cloud Oct 27, 2023, 4:52 PM

#

Nope

#

"recipeData":
{
"name": "Methalox",
"displayNameKey": "Resource/DisplayName/Methalox",
"abbreviationKey": "Resource/Abbreviation/MO",
"resourceIconAssetAddress": "",
"ingredients":

north mist Oct 27, 2023, 4:52 PM

#

good to know

#

I'll update the patch then

#

and for LithiumEC and ArgonEC I'll simply use Lithium and Argon

#

to follow the scheme used for Xenon

digital cloud Oct 27, 2023, 4:54 PM

#

I think those should be LE and AE, and the game is wrong with Xe where it should be XE

#

MethylOx is MO

#

So first initials all caps

north mist Oct 27, 2023, 4:56 PM

#

I mean, you would call an engine runing on methane and oxygen a "methalox" engine (never seen anyone refer to it with capital O), but for an engine using xenon and electricity you wouldn't call it a "xenonEc" engine, you would just call it a "xenon engine"

#

since electricity is not a fuel

#

in real life

#

at least that's my thinking, and I'm assuming the devs' as well

upbeat hare Oct 27, 2023, 4:57 PM

#

I should make an electric engine

digital cloud Oct 27, 2023, 4:58 PM

#

Well, the devs used MO for one and Xe for the other, so they were inconsistent

digital cloud Oct 27, 2023, 4:58 PM

#

upbeat hare I should make an electric engine

You should! They're awesome!

north mist Oct 27, 2023, 4:58 PM

#

I mean that's what I'm saying

upbeat hare Oct 27, 2023, 4:58 PM

#

Cuz Xe stands for Xenon

north mist Oct 27, 2023, 4:58 PM

#

they name all the propellants used

digital cloud Oct 27, 2023, 4:58 PM

#

Also aabout 1000x OP

north mist Oct 27, 2023, 4:58 PM

#

and electricity is not a propellant

upbeat hare Oct 27, 2023, 4:58 PM

#

its the periodic table name of Xenon

north mist Oct 27, 2023, 4:58 PM

#

so Xenon and Methalox

#

are the two fuel mixtures

#

that these engines run on

#

realistically

#

electricity is just required to run the xenon engine but it's not a fuel or oxidizer or anything of that sort

digital cloud Oct 27, 2023, 4:59 PM

#

I think we're mixing up the Name property and the abbreviationKey.

#

With the later they did use MO

#

Although they also used Xe...

upbeat hare Oct 27, 2023, 5:00 PM

#

Well I'm saying MO is because Methane Oxygen
Xe is because Xenon

north mist Oct 27, 2023, 5:00 PM

#

yeah

#

that's what I mean

#

electricity is not a propellant and therefore shouldn't be in the name

digital cloud Oct 27, 2023, 5:00 PM

#

So then for OptiPersp it's OP, but for Lithium and Argon it's just Lithum and Argon

north mist Oct 27, 2023, 5:00 PM

#

yep

digital cloud Oct 27, 2023, 5:01 PM

#

I can live with that as the display name, but they still need to be LithiumEC and ArgonEC for configuring engines

north mist Oct 27, 2023, 5:01 PM

#

I'm just trying to think of it in terms of real life nomenclature, and not the fact that the game treats electricity as a fuel

north mist Oct 27, 2023, 5:01 PM

#

digital cloud I can live with that as the *display* name, but they still need to be LithiumEC ...

yeah, this was all just about the localization

digital cloud Oct 27, 2023, 5:01 PM

#

Then we're good!

upbeat hare Oct 27, 2023, 5:02 PM

#

And the abbreviations for Lithium and Argon should be Li and Ar

digital cloud Oct 27, 2023, 5:02 PM

#

Yep, to follow Xe

north mist Oct 27, 2023, 5:02 PM

#

alright then, so I'll make these changes and push them to dev

digital cloud Oct 27, 2023, 5:02 PM

#

Thanks!

north mist Oct 27, 2023, 5:05 PM

#

@stiff crater any specific way I should translate "Hydrolox" into French? or is that good as is?

stiff crater Oct 27, 2023, 5:06 PM

#

north mist <@192177564800909312> any specific way I should translate "Hydrolox" into French...

Hydrolox is good

north mist Oct 27, 2023, 5:06 PM

#

thanks!

#

one more annoying question

#

#

this is in the base_fuels.patch file

#

so is the abbreviation XE or Xe?

#

oh and Resource/DisplayName/Xenon is "Xenon Gas"

#

so should it be "Lithium Gas" and "Argon Gas"?

stiff crater Oct 27, 2023, 5:10 PM

#

I think schlosrat's Lithium is stored as a solid iirc

north mist Oct 27, 2023, 5:10 PM

#

yeah that definitely makes sense

#

but argon I'm assuming is gaseous?

stiff crater Oct 27, 2023, 5:11 PM

#

Most likely ( @digital cloud just in case)

north mist Oct 27, 2023, 5:12 PM

#

from this it would appear that yes, only Lithium is stored as a solid for ion propulsion

digital cloud Oct 27, 2023, 5:14 PM

#

north mist so should it be "Lithium Gas" and "Argon Gas"?

Definitely not Lithum gas. Safarte is correct. That's stored as a solid (ingots)

north mist Oct 27, 2023, 5:14 PM

#

so, "Gaz Argon" in French? @stiff crater

digital cloud Oct 27, 2023, 5:14 PM

#

Argon is a gas though

stiff crater Oct 27, 2023, 5:15 PM

#

north mist so, "Gaz Argon" in French? <@192177564800909312>

Just "Argon" would do it, but I don't know what the game displays for Xenon (my game is in english)

digital cloud Oct 27, 2023, 5:15 PM

#

north mist from this it would appear that yes, only Lithium is stored as a solid for ion pr...

Not entirely, there are a few engines that burn teflon...

north mist Oct 27, 2023, 5:15 PM

#

oh god

digital cloud Oct 27, 2023, 5:15 PM

#

I've not made any yet, and there used to be ones that burned Bismuth I think

north mist Oct 27, 2023, 5:15 PM

#

I mean I meant specifically out of xenon, argon and lithium 😆

#

but good to know

#

lmao

digital cloud Oct 27, 2023, 5:16 PM

#

Or was it berylium?

#

In spheres?

#

I dunno

#

But electric engines can be weird!

north mist Oct 27, 2023, 5:17 PM

#

stiff crater Just "Argon" would do it, but I don't know what the game displays for Xenon (my ...

well...

#

apparently the game doesn't translate it at all

#

lol

digital cloud Oct 27, 2023, 5:18 PM

#

Hmmm....

stiff crater Oct 27, 2023, 5:18 PM

#

lmao, I'd just put "Argon" in CR

#

adding gas sounds weird in french

north mist Oct 27, 2023, 5:18 PM

#

or I'll just follow their example and use the english term there

stiff crater Oct 27, 2023, 5:19 PM

#

Or, if you want to keep it "Argon Gazeux"

digital cloud Oct 27, 2023, 5:19 PM

#

It may be I do have the first KSP2 parts mod if Kesa requires LFO!

#

#

Hmm.. need to update the dependency on SW...

desert stirrup Oct 27, 2023, 5:56 PM

#

patch filename can begin with an underscore, right? _gasses.patch

north mist Oct 27, 2023, 5:57 PM

#

those should be reserved for libraries, I'm pretty sure

desert stirrup Oct 27, 2023, 5:57 PM

#

oh right

#

nevermind then

upbeat hare Oct 27, 2023, 5:58 PM

#

Patches in those will not be run

stiff crater Oct 27, 2023, 8:04 PM

#

Module patches seem to be working without any issue

upbeat hare Oct 27, 2023, 8:05 PM

#

good to know

#

im done for the day

#

need to relax

stiff crater Oct 27, 2023, 9:05 PM

#

For reference: #1145349899777478759 message (I tried looking at the parsing code but I don't see how a 0 can appear)

north mist Oct 27, 2023, 9:06 PM

#

I'll take a quick look at this first

upbeat hare Oct 27, 2023, 9:07 PM

#

Thank you

north mist Oct 27, 2023, 10:01 PM

#

oh and btw Cheese

#

this is probably something wrong with logging

#

since all the pods have correct units in game

#

but in the logs it always says 0

upbeat hare Oct 27, 2023, 10:07 PM

#

Nah thats correct

#

Its showing the default state

#

Before the fields are actually set

north mist Oct 27, 2023, 10:07 PM

#

ahh ok

#

nevermind then!

#

it was just confusing me a little

upbeat hare Oct 28, 2023, 12:01 AM

#

@north mist now errors are more accurate

#

it doesn't give the weird directory for the name, but rather the mod id

north mist Oct 28, 2023, 12:01 AM

#

that's always nice

upbeat hare Oct 28, 2023, 12:02 AM

#

Gonna test one final thing and push this

#

Maybe even release it after I get rid of some logs

#

Test complete

#

pushing now

#

@north mist should I release PM onto CKAN in its current state?

#

and spacedock

north mist Oct 28, 2023, 12:11 AM

#

I think so

upbeat hare Oct 28, 2023, 12:11 AM

#

and all that jazz?

#

Alright

north mist Oct 28, 2023, 12:11 AM

#

to get it ready for the workshop

#

I'm glad at least something is working

upbeat hare Oct 28, 2023, 12:34 AM

#

Patch manager is now on CKAN after I got its netkan working

#

I'll write the forum post tomorrow

#

Also munix I added you as an author on space dock

stiff crater Oct 28, 2023, 10:20 AM

#

What was the status of the syntax highlighting & LSP?

north mist Oct 28, 2023, 10:20 AM

#

I don't think @frail star finished that

frail star Oct 28, 2023, 10:55 AM

#

oh yeah

#

lol i’ve completely forgotten about it

#

i have everything working except auto complete

north mist Oct 28, 2023, 10:55 AM

#

that sounds good enough for a first release

frail star Oct 28, 2023, 10:55 AM

#

ye

north mist Oct 28, 2023, 10:56 AM

#

at least the highlighting would be nice

frail star Oct 28, 2023, 10:56 AM

#

eh what the hell i don’t need sleep

upbeat hare Oct 28, 2023, 10:56 AM

#

Could you put its source on github too

frail star Oct 28, 2023, 10:56 AM

#

it’s on my git, but it’s open

#

there’s a reason why i moved to another git server, and that would defeat the whole point

#

hey could someone try it quickly

#

i have a builtin version already... i dont remember if it works

#

📎 patcherls-0.1.0.vsix

#

also i assume you guys have much more updated grammar

#

so im gonna update the grammar files

north mist Oct 28, 2023, 11:01 AM

#

probably not much more, but there may be some additions

upbeat hare Oct 28, 2023, 11:06 AM

#

I'll try it in a minute

#

How does this handle built in libraries and the like

north mist Oct 28, 2023, 11:07 AM

#

I know this is slightly late to mention that, but perhaps we should use a different extension than .patch

#

since most editors will assume those are Git patch files

#

lifesupport

frail star Oct 28, 2023, 11:09 AM

#

upbeat hare How does this handle built in libraries and the like

i mean...

#

its just syntax checking and highlighting

#

so 0

frail star Oct 28, 2023, 11:09 AM

#

north mist since most editors will assume those are Git patch files

git uses .diff

north mist Oct 28, 2023, 11:10 AM

#

I mean, all Git patch files I generate with PhpStorm are always .patch

frail star Oct 28, 2023, 11:11 AM

#

interesting 🤔

north mist Oct 28, 2023, 11:11 AM

#

and VS Code recognizes them as Git files

frail star Oct 28, 2023, 11:11 AM

#

actually i dont think the extension matters of the git patch files

#

yeah wait im dumb, it doesnt matter

#

ive always seen them as .diff, but i digress

upbeat hare Oct 28, 2023, 11:12 AM

#

its kind of barebones

frail star Oct 28, 2023, 11:13 AM

#

yeah i should actually work on the syntax highlighting

#

i just have the engine working

#

i have basically 0 time now a days, so you guys can work on it

upbeat hare Oct 28, 2023, 11:15 AM

#

Can you link the source then?

frail star Oct 28, 2023, 11:16 AM

#

sec making the release rn

#

https://git.vortan.dev/Sinon/PatcherLS

Sinon's Git Server

PatcherLS

A language server for the PM language.

#

made the release also

#

ok sleep

#

its like 5am

#

lifesupport

upbeat hare Oct 28, 2023, 11:32 AM

#

Sinon what am I supposed to do with this

frail star Oct 28, 2023, 11:35 AM

#

whatever you want….

upbeat hare Oct 28, 2023, 9:07 PM

#

todo: fix libraries

stiff crater Oct 28, 2023, 9:07 PM

#

libraries broken?

upbeat hare Oct 28, 2023, 9:07 PM

#

if you use one from another mod

north mist Oct 28, 2023, 9:13 PM

#

yep, during the workshop I was scrambling to write a patch for OptiPersp, and adding

@use 'CommunityResources:flowmodes';
@use 'CommunityResources:transfermodes';

didn't work

#

currently it only works within the same mod

digital cloud Oct 28, 2023, 9:39 PM

#

Huh. I hadn't run into this. Does it mean that the lithium ingots in one tank can't be easily transfered to another? How perfectly realistic!

#

Now, Argon on the other hand... There ought to be a way to get that stuff flowing form one container to another.

upbeat hare Oct 28, 2023, 9:40 PM

#

thatsnot what this bug is

north mist Oct 28, 2023, 9:41 PM

#

it only means that if one mod defines some variables or functions in its Patch Manager library, they can't be used from other mods

digital cloud Oct 28, 2023, 9:42 PM

#

Ahh!

digital cloud Oct 28, 2023, 10:24 PM

#

Is this normal?

[Error : Unity Log] [Serialization] Unexpected character encountered while parsing value: . Path '', line 0, position 0.
[Error : Unity Log] SpaceWarp.VersionChecking: Unable to check version for PatchManager due to error System.NullReferenceException: Object reference not set to an instance of an object

north mist Oct 28, 2023, 10:25 PM

#

I've also noticed it

#

and it makes no sense to me

#

the version_check property is set correctly to https://raw.githubusercontent.com/KSP2Community/PatchManager/main/plugin_template/swinfo.json

#

and in that, the version is also set correctly

upbeat hare Oct 28, 2023, 10:26 PM

#

What the fuck I thought we stopped type load exceptions from throwing errors

#

Is it because we do the Preload from start instead of onpreinit

#

no it can't be

stiff crater Oct 29, 2023, 9:33 AM

#

FYI the custom resource units do not seem to apply to OAB tooltips

upbeat hare Oct 29, 2023, 9:37 AM

#

This is a community resources bug

stiff crater Oct 29, 2023, 9:38 AM

#

Ah I thought the custom resource units were defined though a patch, my bad I'll take it there

upbeat hare Oct 29, 2023, 9:38 AM

#

They are, but community resources is what actually defines that ruleset

stiff crater Oct 29, 2023, 9:39 AM

#

Roger that

upbeat hare Oct 29, 2023, 3:00 PM

#

I guess while I wait to continue work on KSP2UT I shall debug PM

upbeat hare Oct 29, 2023, 4:30 PM

#

r.e. libraries bug

#

I'll work on KSP2UT now

north mist Oct 30, 2023, 4:14 PM

#

by the way, I've realized one more edge case where we need to clear cache

#

and that is if the game version changes

#

since all mods may be able to work with a minor update, but a new part might be introduced

#

it might be nice to add a manual "delete cache" button to the mod list details foldout actually? (for the next start of the game)

#

as well

#

just throwing out ideas as I'm getting them

upbeat hare Oct 30, 2023, 10:51 PM

#

north mist it might be nice to add a manual "delete cache" button to the mod list details f...

Good idea

upbeat hare Oct 31, 2023, 6:06 PM

#

I suppose I should finish sinons language server later as well

frail star Oct 31, 2023, 6:07 PM

#

the point was to make a platform for it 😭 . actually adding syntax highlighting and stuff is just time consuming, time i don’t have

north mist Oct 31, 2023, 6:08 PM

#

I mean no one is chastising you for not completing it

frail star Oct 31, 2023, 6:08 PM

#

no no i get that

#

i’m not being defensive

upbeat hare Oct 31, 2023, 6:09 PM

#

I just need to figure out where I need to hook to add the highlighting

frail star Oct 31, 2023, 6:09 PM

#

i guess the sob emoji might have been interpreted as that

frail star Oct 31, 2023, 6:09 PM

#

upbeat hare I just need to figure out where I need to hook to add the highlighting

it’s just in the .yaml file

north mist Oct 31, 2023, 6:09 PM

#

frail star i guess the sob emoji might have been interpreted as that

possibly lmao

frail star Oct 31, 2023, 6:09 PM

#

you add regex cases

#

and you assign a namespace

upbeat hare Oct 31, 2023, 6:09 PM

#

Ahh I thought you were doing it all from the LSP

frail star Oct 31, 2023, 6:10 PM

#

the actual colors are dealt by the theme you have installed

frail star Oct 31, 2023, 6:10 PM

#

upbeat hare Ahh I thought you were doing it all from the LSP

i highly recommend using the .yaml. i translate it into json for the actual extension

#

yaml just let’s everything be a lot more readable

upbeat hare Oct 31, 2023, 6:11 PM

#

Aight

#

And then I can see about adding actual language server stuff like jumping to definitions and the like

frail star Oct 31, 2023, 6:12 PM

#

sounds good

#

ill help with that when i get a chance

#

absolutely swamped with current project

upbeat hare Oct 31, 2023, 6:12 PM

#

What project is that

frail star Oct 31, 2023, 6:13 PM

#

well ive got two rn, a bigger one and a smaller one.
big one is some machine learning stuff for a research paper im writing
small one is a c compiler im writing because idk

#

ive spent like 30 hours in the past 3 days 💀 on the first one

north mist Nov 1, 2023, 1:07 PM

#

I kept getting annoyed by this error

#

[Error  : Unity Log] [Serialization] Unexpected character encountered while parsing value: . Path '', line 0, position 0.
[Error  : Unity Log] SpaceWarp.VersionChecking: Unable to check version for PatchManager due to error System.NullReferenceException: Object reference not set to an instance of an object
  at SpaceWarp.Modules.VersionChecking.CheckJsonVersion (System.String guid, System.String version, System.String json, System.Boolean& unsupported, SpaceWarp.API.Mods.JSON.SupportedVersionsInfo& checkVersions) [0x0000f] in <f56332410c244eaba6e3918a99ad21a2>:0
  at SpaceWarp.Modules.VersionChecking+<CheckVersion>d__12.MoveNext () [0x00126] in <f56332410c244eaba6e3918a99ad21a2>:0

#

not knowing what's wrong

#

Patch Manager's swinfo.json is using UTF-8 with BOM

#

lifesupport

#

that's the '.' SW can't read

upbeat hare Nov 1, 2023, 1:08 PM

#

Pain

north mist Nov 1, 2023, 1:08 PM

#

let me quickly push a fixed one

#

to see if it helps

#

that should hopefully fix the online version check

#

with no need to update the mod

#

just need a review on it

#

hurray

#

no more version checking error

#

lmao

#

that was an easy fix

#

don't know why I haven't though of the BOM bullshit earlier

#

it's interesting that SW deals with it fine when it comes to the local swinfo

#

but not the remote one

upbeat hare Nov 1, 2023, 1:21 PM

#

I have no clue

upbeat hare Nov 1, 2023, 1:57 PM

#

@frail star do I have to make an account on your git server if I want to contribute

frail star Nov 1, 2023, 4:29 PM

#

oh yeah sure

#

i need to figure out how to upload the extension to the registry

#

not that its in a useable state, just for future knowledge

#

oh its really easy lol

upbeat hare Nov 1, 2023, 4:34 PM

#

Also @frail star how do I convert the yaml into json when I want to test?

#

Ah I see it

frail star Nov 1, 2023, 4:35 PM

#

👍

upbeat hare Nov 1, 2023, 4:43 PM

#

@frail star how do I test this?

frail star Nov 1, 2023, 4:44 PM

#

🤣 thats an interesting subject

#

so

#

assuming you have the launch.json that you need:

// A launch configuration that compiles the extension and then opens it inside a new window
{
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Attach",
            "port": 6009,
            "request": "attach",
            "skipFiles": [
                "<node_internals>/**"
            ],
            "type": "node",
        },
        {
            "type": "extensionHost",
            "request": "launch",
            "name": "Launch Client",
            "runtimeExecutable": "${execPath}",
            "args": ["--extensionDevelopmentPath=${workspaceRoot}"],
            "outFiles": ["${workspaceRoot}/client/out/**/*.js"],
            "preLaunchTask": {
                "type": "npm",
                "script": "watch"
            }
        },
        {
            "name": "Language Server E2E Test",
            "type": "extensionHost",
            "request": "launch",
            "runtimeExecutable": "${execPath}",
            "args": [
                "--extensionDevelopmentPath=${workspaceRoot}",
                "--extensionTestsPath=${workspaceRoot}/client/out/test/index",
                "${workspaceRoot}/client/testFixture"
            ],
            "outFiles": ["${workspaceRoot}/client/out/test/**/*.js"]
        }
    ],
    "compounds": [
        {
            "name": "Compound",
            "configurations": ["Launch Client", "Attach"],
            "stopAll": true
        },
    ]
}

#

#

you need to "launch cllient"

#

compound is for debugging with console output

#

tbh i dont remember if it works... i was having some issues

#

after you press it, itll open up a developer vscode window

#

which has your plugin running

#

to not close and reopen the window every 3 seconds, you can press ctrl shift + p and select "Reload Window" or whatever its called

upbeat hare Nov 1, 2023, 4:47 PM

#

Hmmm, alright, maybe I'll rollback my changes and try again

#

Actually, no I didn't change much

#

I keep getting this error Sinon

#

Do I have to regenerate the grammar?

frail star Nov 1, 2023, 4:49 PM

#

so

#

open the sassy_parser.js file

#

are there any errors

upbeat hare Nov 1, 2023, 4:50 PM

#

Mp

#

No

frail star Nov 1, 2023, 4:50 PM

#

you followed the instructions in the readme?

upbeat hare Nov 1, 2023, 4:51 PM

#

frail star Nov 1, 2023, 4:51 PM

#

.... yeah i imagine getting the command might help

#

https://github.com/tunnelvisionlabs/antlr4ts

GitHub

GitHub - tunnelvisionlabs/antlr4ts: Optimized TypeScript target for...

Optimized TypeScript target for ANTLR 4. Contribute to tunnelvisionlabs/antlr4ts development by creating an account on GitHub.

upbeat hare Nov 1, 2023, 4:54 PM

#

Getting the same error again

frail star Nov 1, 2023, 4:54 PM

#

you ran npm install antlr4ts-cli --save-dev?

upbeat hare Nov 1, 2023, 4:54 PM

#

No I meant the same error in the LS

upbeat hare Nov 1, 2023, 4:54 PM

#

upbeat hare I keep getting this error Sinon

This

frail star Nov 1, 2023, 4:55 PM

#

oh i forgot that i pushed the grammar typescript files also

#

lol

#

i could swear i gitignored them

#

um

upbeat hare Nov 1, 2023, 4:55 PM

#

Can I just delete them?

#

and regenerate them

frail star Nov 1, 2023, 4:56 PM

#

yeah sure

#

that error is really sus

#

that place doesnt even exist lmao

#

36:81

#

oh

#

its in the javascript files

#

minor dyslexia

north mist Nov 1, 2023, 4:57 PM

#

frail star 36:81

I don't think a bible verse will help here

frail star Nov 1, 2023, 4:57 PM

#

north mist I don't think a bible verse will help here

if it comes to that

#

😔

upbeat hare Nov 1, 2023, 5:03 PM

#

Oh I get where the errors come from

#

I might have to rename some stuff in the grammar used for this

#

Ahh

frail star Nov 1, 2023, 5:04 PM

#

no clue, the grammar is dark magic to me

upbeat hare Nov 1, 2023, 5:08 PM

#

I'm getting no syntax highlighting at all while debuggin???

#

north mist Nov 1, 2023, 5:10 PM

#

that's interesting, it did work with the pre-release vsix that Sinon sent earlier

frail star Nov 1, 2023, 5:10 PM

#

i just pushed directly what i had lol

#

um

#

are you sure the .json file has stuff in it?

#

can i see it

#

also whats it called

upbeat hare Nov 1, 2023, 5:11 PM

#

{
  "scopeName": "source.patch",
  "fileTypes": "patch",
  "name": "Patch",
  "patterns": [
    {
      "include": "#comment"
    },
    {
      "include": "#keywords"
    },
    {
      "include": "#values"
    },
    {
      "include": "#fragments"
    }
  ],
  "repository": {
    "comment": {
      "patterns": [
        {
          "include": "#comment_line"
        },
        {
          "include": "#comment_block"
        }
      ]
    },
    "comment_line": {
      "name": "comment.line.double-slash.patch",
      "match": "^\\/\\/.*"
    },
    "comment_block": {
      "name": "comment.block.patch",
      "begin": "\\/\\*",
      "captures": {
        "0": {
          "name": "punctuation.definition.comment.patch"
        }
      },
      "end": "\\*\\/"
    },
    "keywords": {
      "patterns": [
        {
          "include": "#keyword-base"
        }
      ]
    },
    "keyword-base": {
      "name": "keyword.control.patch",
      "match": "@[a-z0-9]+"
    },
    "values": {
      "patterns": [
        {
          "include": "#string-double"
        },
        {
          "include": "#string-single"
        }
      ]
    },
    "string-double": {
      "name": "string.quoted.double.patch",
      "begin": "\"",
      "beginCaptures": {
        "0": {
          "name": "punctuation.definition.string.begin.patch"
        }
      },
      "end": "\"",
      "endCaptures": {
        "0": {
          "name": "punctuation.definition.string.end.patch"
        }
      }
    },
    "string-single": {
      "name": "string.quoted.single.patch",
      "begin": "'",
      "beginCaptures": {
        "0": {
          "name": "punctuation.definition.string.begin.patch"
        }
      },
      "end": "'",
      "endCaptures": {
        "0": {
          "name": "punctuation.definition.string.end.patch"
        }
      }
    },
    "fragments": {
      "patterns": [
        {
          "include": "#fragment-base"
        }
      ]
    }
  }
}

#

frail star Nov 1, 2023, 5:12 PM

#

hm thats right

#

        "grammars": [
            {
                "language": "patch",
                "scopeName": "source.patch",
                "path": "./syntaxes/patch.tmLanguage.json"
            }
        ]

#

and you have this in your package.json?

#

and the file you're trying is .patch?

upbeat hare Nov 1, 2023, 5:14 PM

#

yes, and yes

frail star Nov 1, 2023, 5:14 PM

#

here lemme try just cloning from scratch and see

#

#

yeah it works perfectly

#

#

#

i literally just cloned it and compiled

upbeat hare Nov 1, 2023, 5:18 PM

#

Ahh

#

its because I had a syntax error

#

In the patch file

frail star Nov 1, 2023, 5:18 PM

#

i mean... that shouldnt break the highlighting lol

upbeat hare Nov 1, 2023, 5:18 PM

#

Well, it did

frail star Nov 1, 2023, 5:18 PM

#

??

#

ok

#

lmao

#

well have fun, ive gotta run to school

#

prepare for the literal worst dev environemnt youve ever seen

#

you touch anything, and it breaks

north mist Nov 1, 2023, 5:20 PM

#

lifesupport

frail star Nov 1, 2023, 5:20 PM

#

and theres no error or anything

north mist Nov 1, 2023, 5:20 PM

#

that's reassuring

#

lmao

frail star Nov 1, 2023, 5:20 PM

#

its absolutely stupid

#

this is a big reason why it took me so goddam long

#

literally just guessing what could have broken it

#

also a shit ton of bisects

#

yeah get ready for those

upbeat hare Nov 1, 2023, 5:21 PM

#

No it only broke the highlighting when it opened broken

#

Not otherwise

frail star Nov 1, 2023, 5:21 PM

#

interesting

#

no clue why

#

um if you made an account on my server, i can add you as an admin on the repo

#

#

yep doen

#

knock yourself out

upbeat hare Nov 1, 2023, 5:31 PM

#

Function name highlighting

frail star Nov 1, 2023, 5:33 PM

#

nice

upbeat hare Nov 1, 2023, 5:33 PM

#

Getting more useful yet

frail star Nov 1, 2023, 5:35 PM

#

happy to see my environment being put to good use lol

#

setting it all up was such a massive pain

#

also i got it to publish!

#

it just updated

#

https://marketplace.visualstudio.com/items?itemName=Sinon.patcherls

Patcher Language Server - Visual Studio Marketplace

Extension for Visual Studio Code - Language server for KSP2 Patcher Manager

#

cool

#

“free” 🤨 i can make it paid

#

that’s it patcherls is becoming paywall

#

30$ a month

#

it’s basically as useful as rider

north mist Nov 1, 2023, 5:41 PM

#

GPL is a bit useless for that

frail star Nov 1, 2023, 5:41 PM

#

yeah but then cheese would have never even touched it

#

i keep most of my code reserved now a days

#

because it’s mine and you can’t have it klueless

frail star Nov 1, 2023, 5:42 PM

#

north mist GPL is a bit useless for that

honor system

north mist Nov 1, 2023, 5:42 PM

#

I thought you were an OSS fan

#

klueless

frail star Nov 1, 2023, 5:43 PM

#

where it counts sure, i feel like it’s a cool thing to partake in

#

but when i spend a long time doing something i wanna keep it mine lol

north mist Nov 1, 2023, 5:44 PM

#

https://tenor.com/view/steal-stole-burglary-thief-monkeys-gif-18165371

Tenor

#

mine now

frail star Nov 1, 2023, 5:44 PM

#

romania 😔

upbeat hare Nov 1, 2023, 5:54 PM

#

north mist Nov 1, 2023, 5:54 PM

#

wooo colors

upbeat hare Nov 1, 2023, 5:54 PM

#

Could be better, but I will implement that stuff in the language server

frail star Nov 1, 2023, 6:02 PM

#

nice!

upbeat hare Nov 1, 2023, 6:03 PM

#

I'll commit what I have now though

frail star Nov 1, 2023, 6:03 PM

#

when are we writing a lsp backend in .patch?

#

self hosted?

upbeat hare Nov 1, 2023, 6:03 PM

#

It's not that type of language

frail star Nov 1, 2023, 6:04 PM

#

🗿 my attempted joke

upbeat hare Nov 1, 2023, 6:04 PM

#

I gitignored src/generated btw

#

@frail star can I just merge the commit?

frail star Nov 1, 2023, 6:06 PM

#

youre admin

#

maybe make a dev branch….

upbeat hare Nov 1, 2023, 6:06 PM

#

Too late

frail star Nov 1, 2023, 6:06 PM

#

ok well make a dev branch now lol

#

also i’ll add workflow when i get home

upbeat hare Nov 1, 2023, 6:07 PM

#

There is now

frail star Nov 1, 2023, 6:07 PM

#

both on release and on push

upbeat hare Nov 1, 2023, 6:07 PM

#

Also publish the package when you get home?

#Patch Manager