LFO - Lux's Flames and Ornaments | KSP2 Redux | Page 4

split geyser Nov 5, 2023, 2:03 AM

#

Nope, still crappy even with the noise, opactity and falloff lines removed

#

Still, it could be a messed up thing in SPARK

#

I'm gonna call it a night, but I'll work on this some more tomorrow.

#

From what I can see I think LFO 0.10.0 is OK

#

There's some madness with one of my plumes, but since the others in that family are all behaving I don't think it's anything to do with LFO

brittle tendon Nov 5, 2023, 2:07 AM

#

the plumes look just fine for me

#

when I edited the JSON

split geyser Nov 5, 2023, 2:08 AM

#

Interesting!

#

All the more reason to think it's a weird issue on my end

brittle tendon Nov 5, 2023, 2:08 AM

#

here's the file if you want to test it out tomorrow

📎 spark_mpd_md_v2.json

split geyser Nov 5, 2023, 2:09 AM

#

Thanks! I'll check that against what I've got to see what the matter may be.

brittle tendon Nov 5, 2023, 2:14 AM

#

seems like the current GitHub action is not equipped to handle projects with dependency on submodules

#

MSBuild version 17.7.3+4fca21998 for .NET
  Determining projects to restore...
  Restored /home/runner/work/LFO/LFO/src/LFO.Editor/LFO.Editor.csproj (in 4.72 sec).
  Restored /home/runner/work/LFO/LFO/src/LFO/LFO.csproj (in 4.87 sec).
  LFO.Editor -> /home/runner/work/LFO/LFO/build/bin/plugin/LFO.Editor/Debug/netstandard2.1/LFO.Editor.dll
/home/runner/work/LFO/LFO/src/LFO/LFOPlugin.cs(11,21): error CS0234: The type or namespace name 'Shared' does not exist in the namespace 'LFO' (are you missing an assembly reference?) [/home/runner/work/LFO/LFO/src/LFO/LFO.csproj]
/home/runner/work/LFO/LFO/src/LFO/LFOPlugin.cs(5,11): error CS0234: The type or namespace name 'Shared' does not exist in the namespace 'LFO' (are you missing an assembly reference?) [/home/runner/work/LFO/LFO/src/LFO/LFO.csproj]
/home/runner/work/LFO/LFO/src/LFO/LFOPlugin.cs(6,11): error CS0234: The type or namespace name 'Shared' does not exist in the namespace 'LFO' (are you missing an assembly reference?) [/home/runner/work/LFO/LFO/src/LFO/LFO.csproj]
/home/runner/work/LFO/LFO/src/LFO/Patcher.cs(10,21): error CS0234: The type or namespace name 'Shared' does not exist in the namespace 'LFO' (are you missing an assembly reference?) [/home/runner/work/LFO/LFO/src/LFO/LFO.csproj]
/home/runner/work/LFO/LFO/src/LFO/Patcher.cs(6,11): error CS0234: The type or namespace name 'Shared' does not exist in the namespace 'LFO' (are you missing an assembly reference?) [/home/runner/work/LFO/LFO/src/LFO/LFO.csproj]
/home/runner/work/LFO/LFO/src/LFO/Patcher.cs(7,11): error CS0234: The type or namespace name 'Shared' does not exist in the namespace 'LFO' (are you missing an assembly reference?) [/home/runner/work/LFO/LFO/src/LFO/LFO.csproj]
/home/runner/work/LFO/LFO/src/LFO/Patcher.cs(8,11): error CS0234: The type or namespace name 'Shared' does not exist in the namespace 'LFO' (are you missing an assembly reference?) [/home/runner/work/LFO/LFO/src/LFO/LFO.csproj]
/home/runner/work/LFO/LFO/src/LFO/Services/AssetManager.cs(3,21): error CS0234: The type or namespace name 'Shared' does not exist in the namespace 'LFO' (are you missing an assembly reference?) [/home/runner/work/LFO/LFO/src/LFO/LFO.csproj]
/home/runner/work/LFO/LFO/src/LFO/Services/AssetManager.cs(1,11): error CS0234: The type or namespace name 'Shared' does not exist in the namespace 'LFO' (are you missing an assembly reference?) [/home/runner/work/LFO/LFO/src/LFO/LFO.csproj]
/home/runner/work/LFO/LFO/src/LFO/Services/BepInExLogger.cs(2,11): error CS0234: The type or namespace name 'Shared' does not exist in the namespace 'LFO' (are you missing an assembly reference?) [/home/runner/work/LFO/LFO/src/LFO/LFO.csproj]
/home/runner/work/LFO/LFO/src/LFO/Services/BepInExLogger.cs(6,34): error CS0246: The type or namespace name 'ILogger' could not be found (are you missing a using directive or an assembly reference?) [/home/runner/work/LFO/LFO/src/LFO/LFO.csproj]
/home/runner/work/LFO/LFO/src/LFO/Services/AssetManager.cs(8,33): error CS0246: The type or namespace name 'IAssetManager' could not be found (are you missing a using directive or an assembly reference?) [/home/runner/work/LFO/LFO/src/LFO/LFO.csproj]
/home/runner/work/LFO/LFO/src/LFO/Patcher.cs(50,46): error CS0246: The type or namespace name 'LFOConfig' could not be found (are you missing a using directive or an assembly reference?) [/home/runner/work/LFO/LFO/src/LFO/LFO.csproj]
/home/runner/work/LFO/LFO/src/LFO/Patcher.cs(118,13): error CS0246: The type or namespace name 'PlumeConfig' could not be found (are you missing a using directive or an assembly reference?) [/home/runner/work/LFO/LFO/src/LFO/LFO.csproj]
/home/runner/work/LFO/LFO/src/LFO/Patcher.cs(19,33): error CS0246: The type or namespace name 'IAssetManager' could not be found (are you missing a using directive or an assembly reference?) [/home/runner/work/LFO/LFO/src/LFO/LFO.csproj]

Build FAILED.

#

if any kind soul could approve my PR

#

ooor I'll just force merge lol

split geyser Nov 5, 2023, 2:42 AM

#

Looks done?

brittle tendon Nov 5, 2023, 2:42 AM

#

@grim bridge I forgot this was a thing when trying to delete a release...

#

I guess for now I'll just edit the old releases, replacing the download with a text file that says that the original had to be taken down, or something

brittle tendon Nov 5, 2023, 2:48 AM

#

split geyser Looks done?

alright, now it should be all done

#

all the old GitHub releases are deleted, new one up, and for SpaceDock, I replaced the downloads with a zip containing this README.txt:
This version of Lux's Flames and Ornaments (LFO) has been taken down due to some issues. Please see the latest version here: https://spacedock.info/mod/3383

#

and I added a notice to the changelogs of the old versions, too

#

so I think this is the best we can do for now

#

now to fix the shaders...

split geyser Nov 5, 2023, 2:50 AM

#

So much progress today!

brittle tendon Nov 5, 2023, 2:55 AM

#

what a day...

#

but I'm sure we'll have plenty more fun dealing with the shaders

deep surge Nov 5, 2023, 4:51 AM

#

i just want to quickly say i'll never take LFO for granted again and will remember the sacrifices you guys have made to get these pretty plumes working whenever i see them, lol

storm ore Nov 5, 2023, 7:15 AM

#

Congrat guys. What a great job !
I can't check it today but as soon as possible. Respect for your work !!!

balmy tide Nov 5, 2023, 8:33 AM

#

Amazing job, congrats!

lilac dawn Nov 5, 2023, 9:44 AM

#

@brittle tendon Thanks for the update! Amazing work at getting this working again!

storm ore Nov 5, 2023, 12:35 PM

#

Console message (unity 2022) :
Assembly 'Assets/LFO/LFO.dll' will not be loaded due to errors:
Unable to resolve reference 'SpaceWarp.Core'. Is the assembly missing or incompatible with the current platform?
Reference validation can be disabled in the Plugin Inspector.
Something is missing ?

brittle tendon Nov 5, 2023, 12:40 PM

#

That looks like you're using an old version of LFO in Unity

#

You have to delete the LFO folder in Assets and install the new package from the Git URL https://github.com/KSP2Community/LFO.Editor.git

GitHub

GitHub - KSP2Community/LFO.Editor: Unity package for creating LFO p...

Unity package for creating LFO plumes. Contribute to KSP2Community/LFO.Editor development by creating an account on GitHub.

storm ore Nov 5, 2023, 12:46 PM

#

thanks munix. I will try

storm ore Nov 5, 2023, 1:01 PM

#

Works fine ! Thanks.
I'll rebuild each part and push a mod update.
Really, thank you to everyone who contributed to this LFO upgrade

#

it didn't look easy

#

Saving plume json works nice in Assets\plugin_template\assets\plumes
loading plume json config too, except for noise texture (in LFO/Additive shader). In Unity, no noise texture reference, but exists in json
Not blocking me, just for info

split geyser Nov 5, 2023, 2:02 PM

#

storm ore Works fine ! Thanks. I'll rebuild each part and push a mod update. Really, thank...

@brittle tendon and @grim bridge did all the heavy lifting! I mainly contributed moral support, encouragement, a little bit of testing, some frankly useless kibitzing, and some new meshes for some of the plumes. If it weren't for the amazing work munix and cheese put in we would not have a new LFO for 0.1.5!

storm ore Nov 5, 2023, 2:11 PM

#

storm ore Saving plume json works nice in Assets\plugin_template\assets\plumes loading plu...

I made a mistake on install. Sorry

#

it's ok

split geyser Nov 5, 2023, 2:36 PM

#

@brittle tendon I dumped my old LFO and synched to 0.10.0, added an Archive folder on my local repo that's now ignored in the .gitignore, added a Meshes folder under src, and put updated blends and fbx files there with the units now in m instead of mm. There's a PR for you.

#

We're not gonna get into a situation where whe can't rebuild!

brittle tendon Nov 5, 2023, 2:40 PM

#

thank you

#

however, a few things - the fbx files still contain the cameras and lights, which they shouldn't, and then, do we need two versions of each fbx to be in the repo?

#

I think just the blend files would be fine

split geyser Nov 5, 2023, 2:41 PM

#

Oh! So sorry. let me fix thos rn

brittle tendon Nov 5, 2023, 2:41 PM

#

no need!

split geyser Nov 5, 2023, 2:41 PM

#

They're easy to fix!

brittle tendon Nov 5, 2023, 2:41 PM

#

since the working exported fbxs are already in the Assets folder of the Unity project

#

it makes no sense to have them duplicated

split geyser Nov 5, 2023, 2:42 PM

#

Well, I'll fix the blends to remove those so that if we ever need to remake them we don't get those things

#

I assume it probably does make sense to have things scaled in m since pretty much 100% of modders will be scaling their engines like that.

brittle tendon Nov 5, 2023, 2:44 PM

#

split geyser Well, I'll fix the blends to remove those so that if we ever need to remake them...

it's fine to have the lights and cameras in the blend, you just have to select only the mesh when doing an export

#

but if you want to update them, there's one thing I've noticed now

#

the mesh is called "bell_j_01.002"

#

but to be loaded properly in the game when exported, it needs to have just the name without the .002

#

oh and one more thing, could you please move the folder with these out of src? into something like <root>/blender or similar?

#

I'd prefer to keep the src folder only for the C# projects

#

(which inevitably also includes the Unity project in the hierarchy in our case, because the LFO.Editor C# project needs to compile files that are inside the Unity project)

#

but for asset sources, I'd prefer to have them in a different folder in the root

#

sorry if I'm asking a lot 😅

#

I just really want to have some good structure in the project so that it doesn't devolve into a similar state to how it was before

split geyser Nov 5, 2023, 2:50 PM

#

I think I fixed the naming - though I didn't see what you're showing up there. When I look at the blends they all look like this

brittle tendon Nov 5, 2023, 2:50 PM

#

ahhh yeah that's actually my mistake, sorry

#

I opened the blend and then imported the fbx into it, to see both at once

split geyser Nov 5, 2023, 2:51 PM

#

I think it's fine to remove the camera and lights, it makes generating the fbx bulletproof and we don't need them. When are we going to render these things in blender? And we could always add the default camera and lights back in quite easily if we did want to.

brittle tendon Nov 5, 2023, 2:51 PM

#

and of course, since a mesh with the same name already existed, it named the imported one with the .002

#

so that's totally on me!

brittle tendon Nov 5, 2023, 2:52 PM

#

split geyser I think it's fine to remove the camera and lights, it makes generating the fbx b...

yeah, sure, that makes sense

split geyser Nov 5, 2023, 2:52 PM

#

No worries. I renamed the folder blender and moved it to the root. I'll update my repo. Do I need to make another push or will updating my repo get you the update?

#

<- is a Git git

brittle tendon Nov 5, 2023, 2:53 PM

#

the pull request is from one of your branches to one of the project's branches, so when you update yours, so will the pull request

split geyser Nov 5, 2023, 2:53 PM

#

I thought it might be like that

#

I've pushed to my branch so it should be good to go. My tiny little contribution to this effort!

brittle tendon Nov 5, 2023, 2:56 PM

#

the folder still contains the fbx files with the lights and cameras, and ideally there should be no fbx files in it

split geyser Nov 5, 2023, 2:57 PM

#

That's weird. I re-exported after removing the camera and lights.

#

If you prefer I'll just delete the fbx's, but I thought you might like to have them in m

brittle tendon Nov 5, 2023, 2:57 PM

#

if you want them to be updated to use meters, then you could make a PR to where they actually are in the project: https://github.com/KSP2Community/LFO.Editor/tree/main/Assets/Meshes

#

in the LFO.Editor repo

split geyser Nov 5, 2023, 2:58 PM

#

brittle tendon the folder still contains the fbx files with the lights and cameras, and ideally...

Hang on, I may know what's happening - I've got a hunch. When you say there is a camera and a light in the fbx are you determining this by importing the fbx into an empty blend?

brittle tendon Nov 5, 2023, 2:58 PM

#

yeah, and that resulted in two cameras and two lights

#

but maybe I just imported the wrong old file

split geyser Nov 5, 2023, 2:58 PM

#

Hmm...

#

Weird

brittle tendon Nov 5, 2023, 2:59 PM

#

let me try again

#

ah yeah it looks alright now, I probably clicked the wrong file, sorry!

#

my downloads folder is getting slightly messy lol

split geyser Nov 5, 2023, 3:01 PM

#

Oh good, cause I tried that on my end and it worked. I thought I was going mad

#

I'll move the fbx's to the LFO.Editor folder where they belong

brittle tendon Nov 5, 2023, 3:04 PM

#

when I try the new ones, it does result in this in Unity:

#

where the tiny speck is the old one and the big one is the new one

#

it automatically gets created at 100x scale for some reason

#

but when I set the scale to 1, it's fine

#

so hopefully it will be ok

#

it seems like the 100 scale comes from the fbx itself

split geyser Nov 5, 2023, 3:07 PM

#

Hmm... Then I've messed up something in my attempt to get it to be scaled in m.

#

That's no good. I'd like these to be left in a state where anyone can use them and it's easy to update

brittle tendon Nov 5, 2023, 3:07 PM

#

honestly this whole thing about units and scales is so annoying

split geyser Nov 5, 2023, 3:07 PM

#

It is!

#

And I'm sure it's my fault for being stubborn and going with mm at the begining.

#

I set that as my defauilt in blender, and I really should fix that

brittle tendon Nov 5, 2023, 3:08 PM

#

what worked for me was what I showed you earlier, setting the units to cm and unit scale to 0.01

#

that resulted in the correct size by default in Unity

#

but why, I have no clue

#

since units as meters and scale of 1 should be pretty much the same thing

split geyser Nov 5, 2023, 3:09 PM

#

Well, I can scale everything down by 100x very easily in blender, but I suspect there's something else I'm missing. Though why 100x and not 1000x?

brittle tendon Nov 5, 2023, 3:10 PM

#

well, probably because 100 cm is 1 m

split geyser Nov 5, 2023, 3:10 PM

#

OIC. You could have used a scale of .0001 and set the units to mm and had the same effect.

#

You're really just saying 1 = 1

brittle tendon Nov 5, 2023, 3:11 PM

#

yeah, to be honest I really have no clue how all these scales work and interact

#

you have blender units, blender unit scale, blender mesh scale, and unity scale

split geyser Nov 5, 2023, 3:12 PM

#

I'm not finding the folder to drop the fbx's into. What I see under LFO.Editor is this for content in the Assets folder

#

I found it!

#

brittle tendon Nov 5, 2023, 3:13 PM

#

it's a separate repository which is linked as a submodule in the main repository

split geyser Nov 5, 2023, 3:13 PM

#

I want to get these right before I move them in though

brittle tendon Nov 5, 2023, 3:13 PM

#

and yeah it's under Packages

split geyser Nov 5, 2023, 3:14 PM

#

Let's see, the ones that are there are OK now? They work as is, but when you import them into a blend with the new ones then they're scaled wrong, correct?

#

Well, the new ones are scaled wrong.

brittle tendon Nov 5, 2023, 3:15 PM

#

yeah, basically

split geyser Nov 5, 2023, 3:16 PM

#

So if I manage to get the blends to where, if I were to import an fbx from the lfo.editor/Assests/Meshes folder, they basically overlay, then I will have gotten my blend to perhaps be scaled correctly.

#

Or rather, that a new blend importing both fbx's would have them overlaying.

brittle tendon Nov 5, 2023, 3:17 PM

#

this is such a mess, jesus

split geyser Nov 5, 2023, 3:17 PM

#

If I can get them to that state (and I'm sure I can), then the blends I'm submitting will be OK

brittle tendon Nov 5, 2023, 3:17 PM

#

this is the scale of the one that currently works

#

when I set it to 1, it's the same size as the new one

split geyser Nov 5, 2023, 3:18 PM

#

Which also makes it 100x to big, right?

brittle tendon Nov 5, 2023, 3:18 PM

#

(oh because now I have the units set to meters)

#

when I had them set to cm, the scale was 1

split geyser Nov 5, 2023, 3:19 PM

#

You mean the scale in Unity, right?

brittle tendon Nov 5, 2023, 3:19 PM

#

in Blender

#

when my units are set to cm, and unit scale to 0.01, then the old fbx is imported at 1x scale, and the new one at 100x scale, when I set the units to meters and unit scale to 1, then the old fbx is imported at 0.01 scale and the new one at 1x scale

#

ahhhh I hate everything about this

split geyser Nov 5, 2023, 3:25 PM

#

Let me work on this and you relax. I'll sort this out so that the new fbx's are the same scale as the old one, and as the stock stuff from the game. I'm sure whatever we do it will be best to be at the same scale as stock.

brittle tendon Nov 5, 2023, 3:33 PM

#

thank you for dealing with this, this has been making me lose the last bits of sanity I have left after all the updates for UITK and LFO

#

lifesupport

#

but at least we know it works in the current form

split geyser Nov 5, 2023, 3:47 PM

#

I think I've got it sorted now. Once again, the problem was at my end. The fix was stupidly easy, and I should have known. All I needed to do was go into it in Object mode and click Apply Rotation and Scale. I think what happened was that in changing the units this gave it an automatically applied scale transformation to keep it the same size, and Blender was relying on me to know that I would then need to go in and also click on Apply Scale and Rotation. Silly Blender! This is schlosrat! Here's a video from a test blend where you can see I've imported the original game objects as well as some brand new fbx's, and they look like they're very close but not quite identical.

#

Ditto for the bel_p2_1

#

Which is huge next to the shock diamonds...

#

Likewise for bel_j_1

brittle tendon Nov 5, 2023, 3:50 PM

#

awesome! no clue why the bell meshes are so huge compared to the shock ones lol

split geyser Nov 5, 2023, 3:50 PM

#

I'll move the test.blend to Archive so it doesn't get commited, and the new FBX's to where they need to go

brittle tendon Nov 5, 2023, 3:50 PM

#

but it seems like they work fine that way, so that's all that matters

split geyser Nov 5, 2023, 3:51 PM

#

Oh, the bell is used I think when you're modeling a plume expanding in space maybe?

brittle tendon Nov 5, 2023, 3:51 PM

#

actually I think those may be placed, as the name suggests, inside the engine bell

split geyser Nov 5, 2023, 3:51 PM

#

But yeah, if they work then they work, and now we've got blends that can generate proper fbx's (I hope!)

#

Well then, I have no idea why they're such a different scale.

#

Hmmm... before I just haul off and drop new FBX's into a unity project folder... Can I do that without messing up the .meta files? Should I do that in Unity instead?

brittle tendon Nov 5, 2023, 3:56 PM

#

yeah, that's probably for the best

split geyser Nov 5, 2023, 3:56 PM

#

I'll do it that way then

brittle tendon Nov 5, 2023, 3:56 PM

#

just delete the old files and their meta files, and drop in the new ones

#

so that new meta files are generated for them

#

and please assign them to the lfo-resources bundle

split geyser Nov 5, 2023, 3:57 PM

#

The project is 2022.3.5f1, right?

brittle tendon Nov 5, 2023, 3:57 PM

#

yep

split geyser Nov 5, 2023, 3:58 PM

#

brittle tendon Nov 5, 2023, 3:58 PM

#

that's not a Unity project

#

it's just a package inside a project

#

you need to open src/LFO.Editor/Unity

split geyser Nov 5, 2023, 3:58 PM

#

Ahh!

#

Good thing I clicked Quit then.

brittle tendon Nov 5, 2023, 3:59 PM

#

the way packages work is that you create a project that will hold the package, and create a folder for it in the Packages folder

#

and then you edit it through the project

split geyser Nov 5, 2023, 4:00 PM

#

Yeah, well now I've got a Project called "Unity" in my hub... That'll be easy to remember!

#

Also this

brittle tendon Nov 5, 2023, 4:00 PM

#

it's not the greatest name, I could probably rename the folder to something like LFOUnity

split geyser Nov 5, 2023, 4:00 PM

#

Expected?

brittle tendon Nov 5, 2023, 4:00 PM

#

split geyser Also this

because it doesn't have KSP2 imported, yeah

split geyser Nov 5, 2023, 4:01 PM

#

OK.

brittle tendon Nov 5, 2023, 4:01 PM

#

this is really annoying but there's not much we can do about it

#

you may have to do some shuffling around to get ThunderKit to show up

#

LFO depends on KSP2_x64, but obviously we can't put that on GitHub, so there are compile errors when you clone and open the project

split geyser Nov 5, 2023, 4:02 PM

#

So, for my local copy, it's safe to install TK, import the game, etc.?

#

And that won't mess up the repo?

#

Seems like TK is installed, it popped up the Settings dialog

brittle tendon Nov 5, 2023, 4:03 PM

#

ah great, that makes things easier

#

sometimes TK doesn't pop up because of the compile errors, and you have to take the lfo.editor package, move it out of Packages, import KSP2, and then move it back in

split geyser Nov 5, 2023, 4:05 PM

#

So, I'm seeing LFO Editor Tools int he Packages. I thought things in Packages are RO.

brittle tendon Nov 5, 2023, 4:05 PM

#

RO?

split geyser Nov 5, 2023, 4:05 PM

#

Will I be able to drop in new mesh FBXs?

#

Read Only

brittle tendon Nov 5, 2023, 4:05 PM

#

oh

#

well usually packages are not actually in the Packages folder

#

this one is

#

because the project is the source of the package

#

so nope, it is not read-only

#

because it's not just a cached remote package, it's a local one

split geyser Nov 5, 2023, 4:07 PM

#

OK, I was able to delete the old ones and drop in the new ones, but they look rotated by 90deg

#

The ones I found in there were all horizontal.

brittle tendon Nov 5, 2023, 4:08 PM

#

well what happens when you drop them into the scene?

split geyser Nov 5, 2023, 4:08 PM

#

I'm concerned I might have messed something up, but OTOH I know that in Blender I can import these and the stock .obj's and they're oriented the same

split geyser Nov 5, 2023, 4:09 PM

#

brittle tendon well what happens when you drop them into the scene?

Looks horizontal to me!

#

#

Hi, I'm Hugh. Hugh Jass. Pleased to meetcha

brittle tendon Nov 5, 2023, 4:09 PM

#

well then, you can try to build the bundle and drop it into your game, and see if they work fine

#

or send the bundle to me to test with SORRY

#

since I have various vessels and save files ready for quick testing

split geyser Nov 5, 2023, 4:10 PM

#

Presumably I need to install KSP2UT then

brittle tendon Nov 5, 2023, 4:11 PM

#

no

#

just build the bundle

#

from the Assets menu

#

KSP2UT messes up the project, because it usually prevents ThunderKit from working when KSP2 is not imported

#

it's only really needed/useful for parts

split geyser Nov 5, 2023, 4:12 PM

#

Hmmm... Need to import the game looks like

#

Are we OK to do Include Everything again?

brittle tendon Nov 5, 2023, 4:12 PM

#

no, that still doesn't work

#

at least not in the main TK repo

#

Cheese has a hotfix in her fork, but I didn't want to add a dependency to a fork

split geyser Nov 5, 2023, 4:14 PM

#

Makes sense

#

From errors to warnings. Are these expected?

brittle tendon Nov 5, 2023, 4:15 PM

#

yep

split geyser Nov 5, 2023, 4:15 PM

#

There are a lot. 999+

brittle tendon Nov 5, 2023, 4:15 PM

#

huh?

split geyser Nov 5, 2023, 4:15 PM

#

Should be 666 I think...

brittle tendon Nov 5, 2023, 4:15 PM

#

there should be like ~10 of them

#

all they all coming from the shader?

split geyser Nov 5, 2023, 4:15 PM

#

brittle tendon Nov 5, 2023, 4:16 PM

#

hide the warnings, seems like there are also 5 errors

split geyser Nov 5, 2023, 4:16 PM

#

There are a lot of these hash conflicts

brittle tendon Nov 5, 2023, 4:16 PM

#

what the fuck

#

lifesupport

split geyser Nov 5, 2023, 4:16 PM

#

The errors are the old ones

brittle tendon Nov 5, 2023, 4:16 PM

#

alright

#

so if you clear the console, everything is good?

split geyser Nov 5, 2023, 4:17 PM

#

I'll clear the log and rebuild

brittle tendon Nov 5, 2023, 4:17 PM

#

yep, thanks!

split geyser Nov 5, 2023, 4:18 PM

#

Now it doesn't build. Like nada. No errors, warnings, or anything.

brittle tendon Nov 5, 2023, 4:18 PM

#

is there an old built bundle? if so, delete it

#

it doesn't rebuild if there are no changes

split geyser Nov 5, 2023, 4:18 PM

#

Where will it be?

brittle tendon Nov 5, 2023, 4:18 PM

#

in AssetBundles

#

in the project's Assets, not in Packages

split geyser Nov 5, 2023, 4:20 PM

#

Delete in Unity or in file explorer?

brittle tendon Nov 5, 2023, 4:21 PM

#

it doesn't matter

split geyser Nov 5, 2023, 4:21 PM

#

'cause it had no effect deleting in file explorer

#

There's a 25MB file from 11:14 am in there

brittle tendon Nov 5, 2023, 4:21 PM

#

ok and if you delete the whole AssetBundles folder?

split geyser Nov 5, 2023, 4:22 PM

#

That got it moving

brittle tendon Nov 5, 2023, 4:23 PM

#

alright, finally! 😆

split geyser Nov 5, 2023, 4:23 PM

#

Sorta...

brittle tendon Nov 5, 2023, 4:23 PM

#

oh god

split geyser Nov 5, 2023, 4:23 PM

#

It created the folder and put stuff in it

#

But there's nothing in the Addressables Report and nothing in the console

brittle tendon Nov 5, 2023, 4:24 PM

#

this isn't addressables

#

asset bundles and addressables are completely separate

split geyser Nov 5, 2023, 4:24 PM

#

Oh wait! I'd hidden the warnings...

#

I'm a dufus

#

12 warnings

brittle tendon Nov 5, 2023, 4:24 PM

#

alright, that seems like the normal amount

#

it's just some inefficiencies in the shaders

#

I didn't want to mess around with them for now, when it works

split geyser Nov 5, 2023, 4:25 PM

#

Like this stuff?

brittle tendon Nov 5, 2023, 4:25 PM

#

yeah, exactly

split geyser Nov 5, 2023, 4:25 PM

#

There you go then. A test bundle.

#

📎 lfo-resources

#

I'll be happy to test it as well, but most likely it needs to be tested with SORRY engines.

brittle tendon Nov 5, 2023, 4:26 PM

#

yeah, those most notably make use of those meshes

#

it seems like you didn't add the new meshes to the bundle

split geyser Nov 5, 2023, 4:27 PM

#

Nope, 'cause I'm a dufus

#

Is this not already established?

brittle tendon Nov 5, 2023, 4:28 PM

#

I prefer to call it "gaining experience" 😆

split geyser Nov 5, 2023, 4:29 PM

#

LOL, if you say so!

#

<- slow learner

#

📎 lfo-resources

#

Here in 'merica we say "rides the short bus", but I'm sure that it would be insensitive to imply that I measure up to that standard.

#

There was a guild in WoW called "Rides the Short Bus"... That was a lot of fun to see under a character name

brittle tendon Nov 5, 2023, 4:32 PM

#

😆 never heard that one before

split geyser Nov 5, 2023, 4:32 PM

#

Now what about this issue?

#

I've put the meshes into the proper folder, made them part of the bundle, and still my GitHub doesn't see them in that folder?

brittle tendon Nov 5, 2023, 4:33 PM

#

ah alright, so seems like .vsconfig needs to be added to the .gitignore

brittle tendon Nov 5, 2023, 4:33 PM

#

split geyser I've put the meshes into the proper folder, made them part of the bundle, and st...

it's a whole different repository, remember

#

LFO.Editor

#

not LFO

#

you should be able to see it by opening the Packages/lfo.editor folder in GH Desktop

split geyser Nov 5, 2023, 4:34 PM

#

Ahhh... I thought we'd already established my bus?

#

I'll yank them out of the blender folder, then push

brittle tendon Nov 5, 2023, 4:34 PM

#

wait with that push

split geyser Nov 5, 2023, 4:34 PM

#

waiting...

#

#

Not pushing some stuff... but also waiting

brittle tendon Nov 5, 2023, 4:35 PM

#

I still see one .fbx checked, that's one thing

split geyser Nov 5, 2023, 4:35 PM

#

Yeah, you don't want that one anyway

#

It's also not in the bundle

brittle tendon Nov 5, 2023, 4:36 PM

#

also we probably don't want to push all the other files below

#

the project and TK settings

#

and I have no clue why your packages-lock.json is different

split geyser Nov 5, 2023, 4:37 PM

#

How about this? Just the new blends

brittle tendon Nov 5, 2023, 4:37 PM

#

yeah, that would be ideal

split geyser Nov 5, 2023, 4:37 PM

#

And maybe the .gitignore needs some fresh love

brittle tendon Nov 5, 2023, 4:37 PM

#

well, most of the ones that are unchecked are supposed to be in the repo

#

but there shouldn't be any need to update them

#

but the .vsconfig folder should definitely be added to .gitignore

#

ahh I see another issue now that I'm testing with SORRY

split geyser Nov 5, 2023, 4:40 PM

#

QA!

brittle tendon Nov 5, 2023, 4:40 PM

#

two of the files start with bel_*

#

but I named them bell_*

split geyser Nov 5, 2023, 4:41 PM

#

I can change those, the stock one's have bel_j_xxxx

#

I'm not sure what j is for. I assumed jar

brittle tendon Nov 5, 2023, 4:41 PM

#

also one of them has a capital J in the bel_J_1 in the mesh name

#

but a lowercase j in the file name

split geyser Nov 5, 2023, 4:41 PM

#

OK, I fiX!

#

(The capital X was intentional bTw...)

brittle tendon Nov 5, 2023, 4:42 PM

#

by the way the originals had "bell", I double checked

split geyser Nov 5, 2023, 4:42 PM

#

Do you want the exxact same names?

#

I had assumed that since we're different we'd have at least slightly different names.

brittle tendon Nov 5, 2023, 4:43 PM

#

definitely not, but it makes more sense to keep it a real word 😆

split geyser Nov 5, 2023, 4:43 PM

#

Would you like it to be just bell and bell_p2 then?

brittle tendon Nov 5, 2023, 4:43 PM

#

I'm really annoying today with all these requests and corrections, aren't I

split geyser Nov 5, 2023, 4:44 PM

#

Nope, not at all!

brittle tendon Nov 5, 2023, 4:44 PM

#

split geyser Would you like it to be just bell and bell_p2 then?

eh I'd rather not change it now

#

since it's already hardcoded in C#

split geyser Nov 5, 2023, 4:45 PM

#

hardcoded as bel_j_1 and bell_p2_1?

#

I wanna be sure I fix it right

brittle tendon Nov 5, 2023, 4:45 PM

#

double l

#

for both

split geyser Nov 5, 2023, 4:45 PM

#

Oh that... Picky picky picky

brittle tendon Nov 5, 2023, 4:46 PM

#

basically I have a dictionary that maps the old names to the new ones

#

#

so that plumes made for older LFO can still work

split geyser Nov 5, 2023, 4:50 PM

#

What should I be saving this unity project as?

brittle tendon Nov 5, 2023, 4:50 PM

#

that's just a scene, not a Unity project

#

and you don't need to be saving it at all

#

whenever there are some changes there, I just do this

#

#

since we don't need anything to be in the scene in the repo

split geyser Nov 5, 2023, 4:54 PM

#

The only issue with that is that where you have SampleScene* I've got Untitled* and so Discard changes is grayed out for me

#

In other news...

📎 lfo-resources

brittle tendon Nov 5, 2023, 4:56 PM

#

huh why do you have an untitled scene at all

#

you should see the SampleScene under Assets/Scenes, right?

split geyser Nov 5, 2023, 4:56 PM

#

Cause I dropped a mesh onto the scene to see if it was horrizontal or vertical

brittle tendon Nov 5, 2023, 4:56 PM

#

that doesn't really answer the question

#

since I do that as well, but in the SampleScene

#

not a new untitled one

split geyser Nov 5, 2023, 4:57 PM

#

Ha! I got around it!

#

I double clicked on Sample Scene to open it and that let me discard the changes

brittle tendon Nov 5, 2023, 4:57 PM

#

basically, there always has to be an open scene, so you should just be able to discard it by opening SampleScene

#

yeah, exactly

split geyser Nov 5, 2023, 4:58 PM

#

If this bundle works then it will mean there are at least two (or three counting Cheese) who can readily build and export the lfo bundle.

#

There is safety in numbers! And you are worth 2 or 3 at least

#

Did you ever play the old Baulders Gate game?

brittle tendon Nov 5, 2023, 4:59 PM

#

nope, I've only played BG 3

split geyser Nov 5, 2023, 5:01 PM

#

There was this big strong character (don't recall the name) who had a pet giant minature space hamster (a real hamster, but that's not what he thought), who would say "there is safety in numbers, and I'm worth 2 or 3 at least". And you know what, he was!

brittle tendon Nov 5, 2023, 5:01 PM

#

😆

#

guess what

#

I also had a bug in LFO

#

[Error :Lux's Flames and Ornaments] Couldn't find asset vfx_exh_bell_j_01_0

#

split geyser Nov 5, 2023, 5:03 PM

#

Minsc! https://dnd.wizards.com/lore/minsc

D&D Official | Dungeons & Dragons

Minsc & Boo | Dungeons & Dragons

Learn about the origins of Minsc, a bald, purple-tattooed ranger and his loyal companion, a miniature giant space hamster known as Boo.

brittle tendon Nov 5, 2023, 5:03 PM

#

I was missing the _0 in my dictionary

split geyser Nov 5, 2023, 5:03 PM

#

The hamster's name was Boo!

brittle tendon Nov 5, 2023, 5:03 PM

#

I guess it's time for LFO 0.10.1

split geyser Nov 5, 2023, 5:03 PM

#

brittle tendon I was missing the _0 in my dictionary

What!?

#

Oh FFS!

brittle tendon Nov 5, 2023, 5:05 PM

#

split geyser Minsc! https://dnd.wizards.com/lore/minsc

oh that's adorable lol

split geyser Nov 5, 2023, 5:06 PM

#

Damn, it makes me wanna go play the game!

#

It takes me back decades...

brittle tendon Nov 5, 2023, 5:07 PM

#

if you haven't played the new Baldur's Gate 3, I strongly recommend it

#

one of the best games I've ever played

split geyser Nov 5, 2023, 5:08 PM

#

I haven't actually. I should play it. I've heard good things!

brittle tendon Nov 5, 2023, 5:08 PM

#

seems like the meshes are still not scaling well

#

and it is indeed oriented wrong

split geyser Nov 5, 2023, 5:10 PM

#

Wow... I don't get it. I imported both the new one and the stock one and they were oriented, positioned, and scaled basically the exact same

#

If it's wrong, it's on me.

#

But... how?

brittle tendon Nov 5, 2023, 5:10 PM

#

check your meshes for these settings

#

(when you click on the mesh in the Meshes folder directly, and scroll down in the inspector

#

they should look like this, with 0 rotation and 1 scale

tranquil plank Nov 5, 2023, 5:12 PM

#

There are import settings in unity that will try to automatically fix orientation of meshes. And then theres the options in a blender export that also try to do the same.

split geyser Nov 5, 2023, 5:13 PM

#

brittle tendon Nov 5, 2023, 5:13 PM

#

yeah, as expected

tranquil plank Nov 5, 2023, 5:13 PM

#

I think the best practice for unity is to turn off the Y-Up setting in blender(so blender gets to use what ever its orientation is), and let unity try and correct the orientation

#

Or vice versa

#

But not both

split geyser Nov 5, 2023, 5:14 PM

#

tranquil plank I think the best practice for unity is to turn off the Y-Up setting in blender(s...

I could see that fixing the orientation, but why is my scale wonky?

tranquil plank Nov 5, 2023, 5:15 PM

#

split geyser I could see that fixing the orientation, but why is my scale wonky?

Is the scale in unity wonky? Or the scale in blender?

split geyser Nov 5, 2023, 5:15 PM

#

Unity is wonky

tranquil plank Nov 5, 2023, 5:15 PM

#

Cause unity also has a convert scale button that will convert real measurements into unity units. This scale depends on the scale set in the blender mesh

split geyser Nov 5, 2023, 5:16 PM

#

When I import both the FBX and the stock game's OBJ files into the same empty blend they are scaled and oriented just fine

brittle tendon Nov 5, 2023, 5:16 PM

#

I hope you don't mind if I get back to something else for now, since we've already spent 3 hours on this

#

and the version we had before works fine

split geyser Nov 5, 2023, 5:16 PM

#

Sure. No worries. Eventually I'll get these blends to make FBXs that work straight out of the box

tranquil plank Nov 5, 2023, 5:17 PM

#

split geyser When I import both the FBX and the stock game's OBJ files into the same empty bl...

And when you export them, is there an option to set a scale?

#

Cause and fbx export and obj export will have different settings

split geyser Nov 5, 2023, 5:17 PM

#

Interesting, there is this

brittle tendon Nov 5, 2023, 5:17 PM

#

yeah, I did have to uncheck that for my fbx files

#

but also it makes no sense, 1cm is 0.01m

tranquil plank Nov 5, 2023, 5:18 PM

#

(Also that bake Axis Conversion button the orientation import setting i mentioned earlier)

split geyser Nov 5, 2023, 5:19 PM

#

tranquil plank Nov 5, 2023, 5:19 PM

#

split geyser Interesting, there is this

Try switching that on and off

tranquil plank Nov 5, 2023, 5:19 PM

#

split geyser

And what are the export settings for a obj?

split geyser Nov 5, 2023, 5:20 PM

#

tranquil plank Nov 5, 2023, 5:21 PM

#

Hmm the scales are normal in blender. Which probably means you've got the "convert units" option turned on when importing to unity

#

This could be different per mesh type

brittle tendon Nov 5, 2023, 5:22 PM

#

tranquil plank And what are the export settings for a obj?

well the obj files we are using for comparison were not exported by us from Blender, they were extracted from the game's assets

#

so who knows what export settings they used for them

split geyser Nov 5, 2023, 5:22 PM

#

For importing into Unity all I did was darg and drop the fbx's into the folder

tranquil plank Nov 5, 2023, 5:23 PM

#

Ah, i see. Then OBJs are most likely already in a proper unity scale

#

The fbx then needs to be converted to the right scale. Either through the import setting or changing the scale of the mesh in blender. (I would reccomend doing this on the unity side)

split geyser Nov 5, 2023, 5:26 PM

#

tranquil plank The fbx then needs to be converted to the right scale. Either through the import...

I think that's just a matter of unchecking the Conver Units box

tranquil plank Nov 5, 2023, 5:26 PM

#

Give it a shot

split geyser Nov 5, 2023, 5:28 PM

#

This version has both Convert Units and Bake Axis Conversion OFF

📎 lfo-resources

brittle tendon Nov 5, 2023, 5:29 PM

#

it's interesting that the file size keeps changing by a couple of kB

tranquil plank Nov 5, 2023, 5:30 PM

#

Its probably the extra information from. The convert units, and bake axis conversion settings

split geyser Nov 5, 2023, 5:30 PM

#

This version has Convert Units OFF and Bake Axis Conversion ON

📎 lfo-resources

#

For reference, the previous version I posted had Convert Units ON and Bake Axis Conversion OFF. #1092613573290754108 message

brittle tendon Nov 5, 2023, 5:31 PM

#

#

that doesn't look right

#

this is the first file

split geyser Nov 5, 2023, 5:31 PM

#

LOL

tranquil plank Nov 5, 2023, 5:32 PM

#

Lmao

split geyser Nov 5, 2023, 5:32 PM

#

Those look a tad large...

brittle tendon Nov 5, 2023, 5:32 PM

#

actually I think the size is right

#

the orientation is wrong

#

I'll try the second bundle

#

well that changed nothing

#

so the axis conversion doesn't seem to have any effect

tranquil plank Nov 5, 2023, 5:35 PM

#

Hmm, can you make sure that the axis conversion option is actually checked

#

I'm not sure if the settings travel with the mesh or the meshes .meta file

split geyser Nov 5, 2023, 5:36 PM

#

tranquil plank Nov 5, 2023, 5:36 PM

#

Huh

split geyser Nov 5, 2023, 5:36 PM

#

I clicked the box and hit apply for each one

tranquil plank Nov 5, 2023, 5:36 PM

#

I meant @brittle tendon

brittle tendon Nov 5, 2023, 5:37 PM

#

I'm just dropping the built bundle into the game

tranquil plank Nov 5, 2023, 5:37 PM

#

Ooh

#

Nvm then

#

Huh weird

#

Looks like each child/sub mesh is being oriented in world space. Maybe adjust the settings from blender? Try "Apply Transforms"?

brittle tendon Nov 5, 2023, 5:40 PM

#

the files each only contain one mesh, and the plume is composed of multiple of them

tranquil plank Nov 5, 2023, 5:41 PM

#

Oh, how does the plume work exactly?

split geyser Nov 5, 2023, 5:42 PM

#

tranquil plank Looks like each child/sub mesh is being oriented in world space. Maybe adjust th...

I did apply scale and rotation, but not apply transforms. I can do that real quick

split geyser Nov 5, 2023, 5:43 PM

#

tranquil plank Oh, how does the plume work exactly?

Is there anything you recommend I do with the Up setting in the Blender export?

brittle tendon Nov 5, 2023, 5:44 PM

#

tranquil plank Oh, how does the plume work exactly?

basically it's composed of a hierarchy of objects in Unity, you can add as many meshes as you want, choose the appropriate shader for each, toy with the shader parameters until you're happy, and then a JSON config file is exported for the plume, dropped into the game, and the mod then recreates the plume hierarchy and appends it to the engine's root "plume" object

tranquil plank Nov 5, 2023, 5:45 PM

#

split geyser Is there anything you recommend I do with the Up setting in the Blender export?

Um, usually i wouldnt touch it, cause theres all sorts of issues that can come from messing around with the orientation. But maybe try and set them back to there defaulta

split geyser Nov 5, 2023, 5:45 PM

#

They are at default. I've never messed with those settings

#

I'm going to give it a go with just the Apply Transforms done in Blender and see what they look like in the Unity project

tranquil plank Nov 5, 2023, 5:47 PM

#

brittle tendon basically it's composed of a hierarchy of objects in Unity, you can add as many ...

Ah i see. Ok, then the axis conversion should remain off, cause the game will handle the orientation of the little cones

brittle tendon Nov 5, 2023, 5:48 PM

#

for reference these are the settings from other custom meshes in the project

tranquil plank Nov 5, 2023, 5:48 PM

#

split geyser I'm going to give it a go with just the Apply Transforms done in Blender and se...

Yeah try this, if that fails, try removing any rotation from the cone models, so that the rotation should say 0,0,0

brittle tendon Nov 5, 2023, 5:49 PM

#

however the ones that we have replaced with the new ones were the game objs, so the import settings could have looked different

split geyser Nov 5, 2023, 5:49 PM

#

OK, so I did one, and it came in like this

#

If I place it in a scene though, it orients like this

brittle tendon Nov 5, 2023, 5:50 PM

#

yeah, but the game ignores these position/rotation/scale parameters

#

so it's important that they're at 0, 0 and 1

split geyser Nov 5, 2023, 5:51 PM

#

Why are they not though?

brittle tendon Nov 5, 2023, 5:51 PM

#

I would like to know that, too

storm ore Nov 5, 2023, 5:51 PM

#

When i export fbx from blender :

Rotate -90 to X
Object -> apply rotation
3 rotate 90 to X
Then export fbx

tranquil plank Nov 5, 2023, 5:52 PM

#

I've gotta head out, hope this gets figured out. Converting of axis and scale units has always been and will always be a pain. Good luck yall

brittle tendon Nov 5, 2023, 5:52 PM

#

though for example Lux's Flames mesh also has those wrong:

#

and it shows, because when you're making a plume with it, it's oriented incorrectly and you have to manually rotate it back

split geyser Nov 5, 2023, 5:54 PM

#

storm ore When i export fbx from blender : 1. Rotate -90 to X 2. Object -> apply rotation ...

I'm gonna try Jim's approach and see what I get, although I'm really puzzled by the whole scale thing

brittle tendon Nov 5, 2023, 5:54 PM

#

there's actually a lot of weird rotations happening in general with LFO

#

but we can't really go back and fix it without breaking current plumes (even more)

split geyser Nov 5, 2023, 5:56 PM

#

Success! Maybe...

#

I'll do the others this way (thanks Jim!) and we'll see soon enough if this sorts the rotation problem.

brittle tendon Nov 5, 2023, 5:56 PM

#

except it's not supposed to be oriented that way

split geyser Nov 5, 2023, 5:57 PM

#

Sure it is.

brittle tendon Nov 5, 2023, 5:57 PM

#

(if that is the current one)

split geyser Nov 5, 2023, 5:57 PM

#

You mean in the scene? I think it should be

#

My engines are all oriented like that with thrust pointed down

brittle tendon Nov 5, 2023, 5:57 PM

#

I mean it should but the obj wasn't like that originally

#

which means plumes are not made with this (correct) orientation

split geyser Nov 5, 2023, 5:58 PM

#

The object was originally like this, right?

brittle tendon Nov 5, 2023, 5:58 PM

#

yeah

split geyser Nov 5, 2023, 5:58 PM

#

And it is again!

#

The scene is rotated from the view of the obj

brittle tendon Nov 5, 2023, 5:58 PM

#

oh...

split geyser Nov 5, 2023, 5:58 PM

#

Wacky, huh?

brittle tendon Nov 5, 2023, 5:59 PM

#

jesus this is such a mess

#

how come it was so easy for me to fix the ones you originally made

#

I simply imported the fbx into Blender, changed units to cm and scale to 0.01, exported, and then in Unity I unchecked Convert Units

#

and that was it

#

and it works fine

#

no rotation issues or anything

#

nooooooooo

split geyser Nov 5, 2023, 6:05 PM

#

I call this one El Beuno!

📎 lfo-resources

brittle tendon Nov 5, 2023, 6:06 PM

#

🤞

#

let's see

split geyser Nov 5, 2023, 6:06 PM

#

The one before was El malo...

#

And the next one will be El Feo!

brittle tendon Nov 5, 2023, 6:07 PM

#

no bueno...

split geyser Nov 5, 2023, 6:07 PM

#

Poo!

#

Scale, though and not orientation?

brittle tendon Nov 5, 2023, 6:07 PM

#

yes

#

orientation seems correct now

split geyser Nov 5, 2023, 6:08 PM

#

We can try the same GD trick with scale then. How about I convert the model to use cm?

#

I bet that's what it needs.

brittle tendon Nov 5, 2023, 6:08 PM

#

you can try

#

but it should be possible to get this working using whichever units you choose

split geyser Nov 5, 2023, 6:09 PM

#

Yeah, it seems the problem is here where the scale shows 100x

#

brittle tendon Nov 5, 2023, 6:09 PM

#

it should just be possible to apply the new scale in Blender

#

and have the mesh itself scaled to 1x

split geyser Nov 5, 2023, 6:10 PM

#

Didn't that get solved by me unlicking the Convert Units?

#

At one point the scale was OK. Let me do that rn and try again.

#

Though I suspect the more long term solution will involve changing the blends to be in cm.

#

📎 lfo-resources

brittle tendon Nov 5, 2023, 6:15 PM

#

there we go, finally

split geyser Nov 5, 2023, 6:16 PM

#

Converting a blend to be scaled in cm gives this when I bring in the FBX

storm ore Nov 5, 2023, 6:16 PM

#

to export fbx with correct units for unity

split geyser Nov 5, 2023, 6:16 PM

#

That's with Convert Units checked

split geyser Nov 5, 2023, 6:18 PM

#

storm ore to export fbx with correct units for unity

This also works (as it appears in the Unity project)

#

I'm going to do this with the others, then rebuild the bundle

brittle tendon Nov 5, 2023, 6:19 PM

#

I really hope that this was worth the 4 hours it took

#

https://tenor.com/view/dying-monkey-dying-gif-13123180

Tenor

split geyser Nov 5, 2023, 6:24 PM

#

If it puts this problem behind us and establishes a documented path forward, then it was time well spent. Behold! I present to you Tiempo Bien Gastado!

📎 lfo-resources

brittle tendon Nov 5, 2023, 6:26 PM

#

nope

#

too small again

split geyser Nov 5, 2023, 6:29 PM

#

Behold, Tiempo Gastado?

📎 lfo-resources

#

This was the same FBXs, but with Convert Units unchecked.

brittle tendon Nov 5, 2023, 6:31 PM

#

yeah, that works

brittle tendon Nov 6, 2023, 2:06 PM

#

alright so I recreated the hierarchy of the SORRY Raptor plume

#

and managed to load the JSON config into it

#

#

safe to say that there is no difference in the shader between the game and the editor

#

the shader is just incorrect/unfinished

#

or

#

it' just new and the old plumes were supposed to be remade

#

(the sizes and positions of the elements don't match because I'd have to do that manually, but the general shape is the same as in the game)

#

brittle tendon Nov 6, 2023, 2:26 PM

#

one thing I want to do is enable the loading of the full plume, including its object hierarchy, all the objects' positions, rotations and scales, and all that, from an existing JSON config

pliant widget Nov 6, 2023, 2:26 PM

#

brittle tendon

Almost looks like an expansion ratio somewhere was set to be negative instead of positive

brittle tendon Nov 6, 2023, 2:27 PM

#

because currently the way it works is that you have to have the object hierarchy already fully created, and have to set up the position/rotation/scale of every object manually, and add all the components to all the objects

#

and then you can press "Load Config" and it just loads the material properties from it

#

I think it shouldn't be too difficult to make it so that it instead creates the full plume for you

brittle tendon Nov 6, 2023, 2:30 PM

#

pliant widget Almost looks like an expansion ratio somewhere was set to be negative instead of...

it's more like the min-max scale is wrong

#

I took an already existing SORRY plume

#

and the linear expansion is set to -1 on the main mesh

#

but that worked well with LFO 0.2.1 and the older shader

#

it's possible that the old shader was "broken" and this one is working as intended

#

but in that case, plumes will have to be remade

grim bridge Nov 6, 2023, 2:34 PM

#

brittle tendon alright so I recreated the hierarchy of the SORRY Raptor plume

Can you send me a unitypackage of that prefab

#

I want to mess with some stuff

brittle tendon Nov 6, 2023, 2:36 PM

#

📎 engine.unitypackage

grim bridge Nov 6, 2023, 2:37 PM

#

getting a bunch of NREs

brittle tendon Nov 6, 2023, 2:37 PM

#

with LFO and KSP2?

grim bridge Nov 6, 2023, 2:37 PM

#

Yep

brittle tendon Nov 6, 2023, 2:38 PM

#

btw this one I unchecked "include dependencies"

📎 engine.unitypackage

#

but it looks to be the same size so idk

grim bridge Nov 6, 2023, 2:38 PM

#

#

I should have the latest version of LFO.Editor]

brittle tendon Nov 6, 2023, 2:39 PM

#

what line is that?

grim bridge Nov 6, 2023, 2:39 PM

#

brittle tendon Nov 6, 2023, 2:40 PM

#

wut

#

it says the error is in a whole different file though

grim bridge Nov 6, 2023, 2:40 PM

#

wtf

brittle tendon Nov 6, 2023, 2:40 PM

#

I see FloatParam.cs

grim bridge Nov 6, 2023, 2:40 PM

#

#

Thats the line its actually referencing

#

idk but double clicking on it brought me to the mastergroup

brittle tendon Nov 6, 2023, 2:41 PM

#

weird

grim bridge Nov 6, 2023, 2:41 PM

#

I see what happened

brittle tendon Nov 6, 2023, 2:41 PM

#

but yeah that makes sense, since materials are created programmatically and assigned directly to the objects

grim bridge Nov 6, 2023, 2:41 PM

#

it didn't apply the materials corrrectly

brittle tendon Nov 6, 2023, 2:42 PM

#

not actually saved to files

#

so the object will have references to non-existing materials

grim bridge Nov 6, 2023, 2:42 PM

#

So can you send me the config?

brittle tendon Nov 6, 2023, 2:42 PM

#

you'll still need to create them all manually probably but sure

#

the config only applies values to existing materials

#

📎 Reiptor-12.json

grim bridge Nov 6, 2023, 2:46 PM

#

When attempting to load the config

#

(I added a material instance ot every child beforehand

brittle tendon Nov 6, 2023, 2:46 PM

#

the plume is not really complicated to recreate anyway, I just created this object hierarchy, where Engine is just a cube cube, thrustTransform is simply moved below the engine, Plume is an empty object with the master group component, and then Screen and all the Scatter objects are just unpacked Flame prefabs, Mach 1-3 are unpacked shock_1_pt2 prefabs, and Bell is an unpacked bell_p2_1 prefab, and these all need a LFO Throttle Data component, where you click New material instance

brittle tendon Nov 6, 2023, 2:47 PM

#

grim bridge (I added a material instance ot every child beforehand

ah, well that was easier than I thought it would be lol

brittle tendon Nov 6, 2023, 2:47 PM

#

grim bridge

do a search+replace for LFOAdditive 2.0, replace it with LFO/Additive

#

in the config

#

that's another thing I'm adding to the editor scripts, being able to load the shader from materials and shaders

#

just like the runtime can

#

the Editor is severely lacking in features that exist in the runtime

grim bridge Nov 6, 2023, 2:48 PM

#

Now I have the issue of the Mach 3 scatter being way too big

brittle tendon Nov 6, 2023, 2:48 PM

#

ah yeah, same, didn't even notice it lol

#

it doesn't matter all that much

grim bridge Nov 6, 2023, 2:49 PM

#

Scaling that down helped

brittle tendon Nov 6, 2023, 2:49 PM

#

like I said, none of the positions/rotations/scales are correct

#

since that info isn't loaded from the config in the current version

grim bridge Nov 6, 2023, 2:49 PM

#

But yeah, that is wrong in the editor

brittle tendon Nov 6, 2023, 2:49 PM

#

I wouldn't even say it's wrong

#

it just has linear expansion set to -1

#

so it makes sense it looks like this

#

it looks fine with values ~0-1

#

I think the fix for this is to just remake the plumes that look wrong

#

for example Kesa plumes look just fine, because I'm guessing they were remade with the newer (0.9) version

#

and to make remaking existing plumes not as tedious, since going from older LFO to current LFO breaks everything in the editor, I'll just add a button to (hopefully) completely re-create the plume from JSON

#

and then the few wrong values can just be easily readjusted

grim bridge Nov 6, 2023, 2:53 PM

#

Setting the linear expansion to zero in the throttle data while keeping the same curve looks aight

brittle tendon Nov 6, 2023, 2:54 PM

#

yeah

grim bridge Nov 6, 2023, 2:54 PM

#

I still need to plan out the KSP2UnityTools/LFO integration, and also how to ignore files, which is actually quite simple

#

I want LFO to keep its stuff in its bundle so it doesn't mess with addressable groups itself, so at the runtime it will load either from its bundle or addressables

brittle tendon Nov 6, 2023, 2:56 PM

#

I don't even know if it wouldn't be better to keep all that functionality in LFO itself

#

(except for the ignoring stuff)

grim bridge Nov 6, 2023, 2:56 PM

#

Well, KSP2 Unity Tools sets up a custom addressables group for everything

#

And for asset deduplication it makes sense to have the plumes keys be like {mod_id}/plumes/{part}.json

brittle tendon Nov 6, 2023, 2:58 PM

#

yeah it does

#

I just wish KSP2UT didn't mess with ThunderKit when KSP2 is not imported

grim bridge Nov 6, 2023, 2:59 PM

#

How does it mess with thunderkit?

#

I've never had this happen to me

brittle tendon Nov 6, 2023, 2:59 PM

#

LFO also depends on KSP2 code but it doesn't seem to break it

brittle tendon Nov 6, 2023, 2:59 PM

#

grim bridge I've never had this happen to me

when you clone a project that has ThunderKit and KSP2UT installed as a dependencies, ThunderKit will not load and you're not able to import KSP2

#

at least whenever I tried

#

because of the compile errors presumably

#

but LFO doesn't do it

#

even though it also has compile errors

#

so you can go and import the game and everything works fine

#

usually

#

with KSP2UT, you have to uninstall the package, import KSP2, and reinstall it

#

I hit the issue when I added KSP2UT as a dependency for my LFO project

#

so I removed it

grim bridge Nov 6, 2023, 3:01 PM

#

wtf

#

I am literally doing nothing w/ thunderkit though in KSP2UnityTools

brittle tendon Nov 6, 2023, 3:02 PM

#

yeah I know

#

idk why it happens

grim bridge Nov 6, 2023, 3:03 PM

#

Alright, I'm going to try myself

brittle tendon Nov 6, 2023, 3:03 PM

#

it's why I originally told you that Unity templates won't work

#

because I noticed that you can't import KSP2 when KSP2UT is installed

#

but then I saw that it's not the case always, since with LFO it was fine

grim bridge Nov 6, 2023, 3:03 PM

#

I removed KSP2_x64 as a package from my own KSP2UT testing project

#

now lets restart it

brittle tendon Nov 6, 2023, 3:04 PM

#

I can't guarantee it will always happen, since I didn't test it extensively, but it definitely happened the few times I tried

grim bridge Nov 6, 2023, 3:05 PM

#

It works fine for me though...

brittle tendon Nov 6, 2023, 3:06 PM

#

https://tenor.com/view/dying-monkey-dying-gif-13123180

Tenor

#

bruh

#

now I can't replicate it either

#

but I swear to god it happened to me at least 4-5 times

#

with various projects

#

no TK menu, no TK window

#

oh well

#

let's just ignore that lmao

#

I'll let you know if I encounter it again

#

but for now I guess it's ok

grim bridge Nov 6, 2023, 3:19 PM

#

Alright
In that case, can you review my PR for KSP2UnityTools

brittle tendon Nov 6, 2023, 3:19 PM

#

sure

grim bridge Nov 6, 2023, 3:19 PM

#

Wait

brittle tendon Nov 6, 2023, 3:19 PM

#

btw I think you skipped a version

grim bridge Nov 6, 2023, 3:19 PM

#

I did a dumb

#

I did not

#

I bumped the version in my editor

#

but ehh I need to fix something rq

brittle tendon Nov 6, 2023, 3:20 PM

#

this was the version I just installed from main

#

that's why I said it

#

ah yeah, I see

grim bridge Nov 6, 2023, 3:21 PM

#

Ohh I named it 0.6.4 in the pr, but 0.6.3 in the package.json

brittle tendon Nov 6, 2023, 3:22 PM

#

Rider used to correctly inform about stuff that wasn't available in the current Unity version of C#

#

but now it doesn't seem to anymore

#

I also had that thing with file scoped namespaces happen multiple times, when they don't work in Unity

#

idk why it no longer recognizes that

grim bridge Nov 6, 2023, 3:23 PM

#

I am going to set rider to force block scoping

brittle tendon Nov 6, 2023, 3:23 PM

#

yeah, that's what I did, for the specific project

grim bridge Nov 6, 2023, 3:24 PM

#

But anyways, that PR should actually be right now

brittle tendon Nov 6, 2023, 3:30 PM

#

also I'm going to comment out the KSP2 Builder GH action in LFO for now

#

since it doesn't clone the submodule and thus doesn't work

grim bridge Nov 6, 2023, 3:34 PM

#

Hmm, one thing with loading from addressables ... if we put textures and such in addressables, then they won't be loaded properly in the editor when loading a config

brittle tendon Nov 6, 2023, 3:35 PM

#

hm why not?

#

the files still have to be in the project somewhere

#

and the search is done by name

#

in both editor and runtime

#

at runtime we just need to load everything from a specific label, and then find the asset with the correct name among the loaded ones

#

and in the editor, it's just about doing AssetDatabase.FindAssets("name")

#

(and also checking the type, since there can be technically multiple assets with the same name, but different type)

#

such as a shader and its material

#

I don't see a problem though

grim bridge Nov 6, 2023, 3:38 PM

#

Alright

#

I'm going to work on the editor side of this for the moment

brittle tendon Nov 6, 2023, 3:39 PM

#

alright

#

let me push what I have for now so you have the latest version

grim bridge Nov 6, 2023, 3:39 PM

#

Darn I was already pushing something to dev

#

Though all I pushed was having it reference KSP2UT, and then changing the load json button to be a lot more usable

brittle tendon Nov 6, 2023, 3:40 PM

#

oh well

#

time to get merging

#

lmao

#

it's just the one file

grim bridge Nov 6, 2023, 3:43 PM

#

Aight, time to fix what you just pushed

brittle tendon Nov 6, 2023, 3:44 PM

#

this is gonna get messy lifesupport

#

lmao

#

I still plan on refactoring some stuff

storm ore Nov 7, 2023, 5:20 AM

#

Hy. Everything works fine. Great work guys. Mods updated with unity2022 and LFO 0.10.0
When i edit curves for engine, i can't edit values. I have to move dots manualy. It seems to be general with all curves edition. Is it same for you ?

pliant widget Nov 7, 2023, 6:22 AM

#

Yeah they changed the curve editor since Unity 2020, to edit the values of the key you have to: select the dot by drawing a rectangle over it and then press Enter it'll allow you to modify the x,y values

storm ore Nov 7, 2023, 5:00 PM

#

Thanks Safarte

brittle tendon Nov 7, 2023, 11:15 PM

#

very interesting

#

seems like this particular bug only occurs when there's more than one active engine

#

oh and not even that, it looks like it may be specific engines that trigger it?

brittle tendon Nov 7, 2023, 11:50 PM

#

aaand I got it figured out I guess

#

it's only SORRY engines that do this

#

and the SORRY engines also have all the objects, components and materials directly on the prefab, which they shouldn't

#

alright, not all SORRY engines, the only ones I see this happen with are the sea level Reiptor, sea level Kheap and the Mk2 double-nozzle engine

#

and I can confirm it's not related to the "Error assigning 3D texture to 2D texture property" errors

brittle tendon Nov 8, 2023, 12:04 AM

#

brittle tendon and the SORRY engines also have all the objects, components and materials direct...

soo that isn't the cause either, since all the SORRY engines have this, and only 3 of them break the shaders

#

this would be much easier to debug if I could see how the SORRY prefabs are set up

#

I mean I can in Asset Studio

#

but it's not great

brittle tendon Nov 8, 2023, 12:33 AM

#

also this makes me think the new shader is working like it's supposed to

#

since this is for one of the newest SORRY engines iirc

#

and its plume looks good, unlike the old ones

#

so the plume was probably created using the new shader

#

and the older ones were either not tested, or Lux was planning on updating them

#

SORRY also demonstrates really nicely why having the plumes in addressables is important - if they were, we could just release a separate PM patch for the SORRY plumes

#

without Lux having to update the core mod

brittle tendon Nov 8, 2023, 12:58 PM

#

alright, the first half of the addressables support (the editor side) is done

#

the KSP2UT API makes it dead simple - just needed to call the AddressablesTools.MakeAddressable method

#

thanks for that @grim bridge!

grim bridge Nov 8, 2023, 1:07 PM

#

You are welcome!

brittle tendon Nov 8, 2023, 1:09 PM

#

one thing I've noticed that happens when I call that method is that in the Addressables Groups window, the label appears as crossed out, if it hasn't been used before, but unchecking and checking it again in the dropdown gets rid of that

#

is that expected?

grim bridge Nov 8, 2023, 1:09 PM

#

Ahh no

#

I can fix that tho

#

I was wondering what would happen if I add a label that isnt defined yet

brittle tendon Nov 8, 2023, 1:11 PM

#

I couldn't even find anything about it online

grim bridge Nov 8, 2023, 1:12 PM

#

Because technically the addressables API is undocumented :3

brittle tendon Nov 8, 2023, 1:13 PM

#

lifesupport

#

we love Unity

grim bridge Nov 8, 2023, 1:16 PM

#

https://github.com/KSP2Community/KSP2UnityTools/pull/7

GitHub

0.6.4 hotfix by cheese3660 · Pull Request #7 · KSP2Community/KSP2Un...

Hotfix that automatically adds labels when they are not yet defined :3

brittle tendon Nov 8, 2023, 1:50 PM

#

hm

#

[Error :Lux's Flames and Ornaments] Failed to load assets from lfo_assets: UnityEngine.AddressableAssets.InvalidKeyException: Exception of type 'UnityEngine.AddressableAssets.InvalidKeyException' was thrown. No Location found for Key=lfo_assets

#

i have my catalog/settings/StandaloneWindows64/AddressablesLink in LFO/addressables, as usual

#

and all the settings look correct afaik

#

I used the group created by KSP2UT

grim bridge Nov 8, 2023, 1:53 PM

#

Thats quite odd

#

I've tested the addressables built by KSP2UT before

brittle tendon Nov 8, 2023, 1:56 PM

#

do I need to add a custom loading action or something?

#

I don't really need to pre-process the assets in any way, I just need them accessible through Addressables.LoadAssetsAsync

grim bridge Nov 8, 2023, 1:57 PM

#

brittle tendon do I need to add a custom loading action or something?

You shouldn't?

brittle tendon Nov 8, 2023, 2:02 PM

#

weird, as far as I can tell, the structure, location, the catalog, the settings, everything looks fine (and equivant to those of other mods using addressables)

#

oh duh

#

I'm trying to access the addressables in OnPreInitialized but SpaceWarp loads them later

#

lifesupport

#

aaand done

#

#

addressables support finished

#

reworking the entire asset workflow in LFO previously made this change extremely easy to implement at runtime

#

just need to make a test mod with addressable assets and configs to test that part out

grim bridge Nov 8, 2023, 2:16 PM

#

How does it deal with deduplication against the builtin bundles?

brittle tendon Nov 8, 2023, 2:16 PM

#

but I'm pretty happy with the progress, 0.11 so far includes a dropdown for shader params in the FloatParams editor, the option to completely create a plume from a JSON, and addressables support

brittle tendon Nov 8, 2023, 2:16 PM

#

grim bridge How does it deal with deduplication against the builtin bundles?

does it need to?

#

and if so, how? 😅

grim bridge Nov 8, 2023, 2:17 PM

#

2 assets can't have the same key

brittle tendon Nov 8, 2023, 2:17 PM

#

why would they have the same key?

#

I did check the builtinshaders bundle and it contains nothing

#

shaders are all included in the main bundle, with their whole path, like Packages/lfo.editor/Assets/Shaders/...

grim bridge Nov 8, 2023, 2:19 PM

#

Gotcha

#

Is stuff like noise includde in the bundles?

brittle tendon Nov 8, 2023, 2:20 PM

#

everything that was in the lfo_resources asset bundle is now in the main addressable bundle

#

including the noise textures

grim bridge Nov 8, 2023, 2:20 PM

#

And what if a mod wants to add noise?

brittle tendon Nov 8, 2023, 2:21 PM

#

then they add it, just need to use a different name for it than the ones included in LFO

#

the way I handle the adding of assets to addressables during the saving of the plume is that I go through the whole object hierarchy, gather all the mesh and texture names, then find their paths, and if the path begins with Packages/lfo.editor, it's ignored

#

otherwise the asset is added into addressables

#

I could theoretically do something like add a prefix for the asset names in the addressables, like lfo-*

#

so that they can't conflict with other non-LFO assets

grim bridge Nov 8, 2023, 2:37 PM

#

Gotcha

#

Well shit, we might wanna start working on a PM addon for this now

#

It can still load json files the old way as well right?

#

I really need to be 100% sure that the addressables loading actions run after all the PM stuff

#

which means I might need to do some PM shenanigans

brittle tendon Nov 8, 2023, 2:42 PM

#

grim bridge It can still load json files the old way as well right?

yep

#

the plumes in the screenshot are loaded from JSON

#

haven't actually tested loading the JSON from addressables yet

#

I'll make a plume for the Community Parts Pack engine to test it out, and add a custom mesh and noise for good measure

grim bridge Nov 8, 2023, 2:43 PM

#

I'm gonna see what I can do in PM to make its actions the first ones

#

This is going to involve some reflection, or more accurately publicizing spacewarp

brittle tendon Nov 8, 2023, 2:45 PM

#

actually now that I'm thinking about it, instead of just directly loading the plumes from the JSON files, I could add a custom resource locator/provider pair and add even the old .json plumes to the addressables system

#

theoretically that would allow for the patching of even those old plumes

#

but then that would have to be done before Patch Manager stuff runs lol

grim bridge Nov 8, 2023, 2:47 PM

#

That'd have to be done in PreInitialize

brittle tendon Nov 8, 2023, 2:48 PM

#

well, then that should work I suppose

#

I can try to do that

#

after I make the test plume mod

grim bridge Nov 8, 2023, 2:52 PM

#

https://github.com/KSP2Community/PatchManager/pull/16
Anyways, this should also be reviewed

GitHub

Patchmanager 0.3.2 by cheese3660 · Pull Request #16 · KSP2Community...

This is a simple fix that makes patch managers loading actions always be the first ones run (uses unstable parts of spacewarp so will likely have to be maintained on updates to spacewarp, or have t...

#

Actually wait

#

lemme fix one thing

#

This is necessary to ensure patch manager gets run and registers its locators before any other mod does

#

Alright, now lemme make that release

#

Hmmm, would it be a stupid idea if we create an LFO/PM addon to have an export as PM patch button?

#

it'd at least make the process of completely swapping out plumes a lot easier

#

it'd still have to put everything else in addressables tho

brittle tendon Nov 8, 2023, 3:10 PM

#

I mean I don't hate the idea, it would make the patching of plumes much easier

#

you'd just import a plume using the new Create plume from JSON functionality, change stuff, and then press Export as PM patch

#

and you could patch any existing plumes from any mod that way

grim bridge Nov 8, 2023, 6:32 PM

#

Did you do the CPP test?

brittle tendon Nov 8, 2023, 6:33 PM

#

I had to go take care of some work stuff, but I'll finish dinner and get to it

grim bridge Nov 8, 2023, 6:35 PM

#

Aight

#

No rush, was just curious if it worked

#

And once that is done mayhaps I'll start on a PM Addon for LFO

brittle tendon Nov 8, 2023, 6:36 PM

#

I was also kinda thinking

#

could we do kinda the opposite maybe?

#

basically allow embedding raw JSON into a patch

grim bridge Nov 8, 2023, 6:37 PM

#

You already can

brittle tendon Nov 8, 2023, 6:37 PM

#

to simply replace either an entire JSON file or a part of it, like an object

#

ah

grim bridge Nov 8, 2023, 6:37 PM

#

@set-value

brittle tendon Nov 8, 2023, 6:37 PM

#

that makes it really simple then

grim bridge Nov 8, 2023, 6:37 PM

#

Raw json is a valid patch manager literal

brittle tendon Nov 8, 2023, 6:38 PM

#

you've really thought of everything huh

#

😆

grim bridge Nov 8, 2023, 6:38 PM

#

That was actually unintentional at first

#

But it just came naturally from the syntax I was designing

#

Set-value was intentional though

#

I should add an @embed, but that would make caching weird

#

So no

brittle tendon Nov 8, 2023, 7:05 PM

#

alright time to try this out

brittle tendon Nov 8, 2023, 7:30 PM

#

[Error : Unity Log] AssetProvider unable to find assets with label 'lfo_configs'. these are so annoying, it's the same thing as the one with the localization label

#

(this is before adding the new plume)

grim bridge Nov 8, 2023, 7:35 PM

#

Not much can be done about that

brittle tendon Nov 8, 2023, 7:36 PM

#

I mean

#

we could just not log that specific exception as an error

#

instead just make it an info message or something

#

in AddressableAction

#

we could even just do a check like this before the try block, and it it returns false, just info log it and resolve:

grim bridge Nov 8, 2023, 7:44 PM

#

I suppose yeah

brittle tendon Nov 8, 2023, 7:44 PM

#

I'll test it and PR it to dev then

grim bridge Nov 8, 2023, 8:47 PM

#

Did the test work

brittle tendon Nov 8, 2023, 8:47 PM

#

yep

grim bridge Nov 8, 2023, 8:47 PM

#

Pog

brittle tendon Nov 8, 2023, 8:47 PM

#

and now I'm in the process of making my own pretty flame

#

munley

storm ore Nov 8, 2023, 9:15 PM

#

You built your flame mesh ?

brittle tendon Nov 8, 2023, 9:16 PM

#

that's just the default Flame mesh from LFO with some noise on it, but I am adding a custom mesh, the purple part is just a default Unity capsule mesh

#

just to test out the adding of assets to addressables

storm ore Nov 8, 2023, 9:17 PM

#

Nice

brittle tendon Nov 8, 2023, 9:17 PM

#

(and of course I've already found a couple of bugs)

storm ore Nov 8, 2023, 9:17 PM

#

🙂 Never stops

grim bridge Nov 8, 2023, 9:19 PM

#

Welcome to mr. bugs wild ride, the bughunting never ends

storm ore Nov 8, 2023, 9:20 PM

#

Someone d seen if xenon is integrated in natives resources in ksp2 ?

brittle tendon Nov 8, 2023, 9:21 PM

#

Xenon is a stock resource, yeah

storm ore Nov 8, 2023, 9:21 PM

#

Cool

brittle tendon Nov 8, 2023, 9:31 PM

#

alright yeah the prefixing of the assets is a must

#

this will obviously not work

#

I just changed the code to save and read the LFO assets with the prefix "lfo/"

grim bridge Nov 8, 2023, 9:32 PM

#

Definitely nott

brittle tendon Nov 8, 2023, 9:33 PM

#

that should hopefully prevent any conflicts

#

and I will definitely recommend to also prefix the name of any custom assets with the name of the mod, similarly to parts

#

so that two mods don't add the same "Capsule" mesh for example

grim bridge Nov 8, 2023, 9:34 PM

#

I was thinking of having the editor automatically doing the prefixing

#

{sanitizedmodid}/{asset}
It shouldnt be hard to reverse that at runtime if need be

brittle tendon Nov 8, 2023, 9:35 PM

#

so upon saving, it would go through all the meshes from Assets that are used in the plume config, and rename them?

#

ah

#

I mean, that could also work

#

it shouldn't theoretically cause issues since mod IDs really shouldn't be changing

brittle tendon Nov 8, 2023, 9:58 PM

#

grim bridge I was thinking of having the editor automatically doing the prefixing

actually, thinking about it, that would make things pretty difficult

#

currently all assets are simply cached in a dictionary with their name as key

#

and while we probably could just store them with the mod ID prefix, it would also mean that the prefix would have to be part of the name of the asset in the configs themselves

#

oh nevermind, it doesn't even work like that

#

I didn't realize that when you load addressables from a label, you don't get to know their addresses at all

#

you just get the asset name, which has nothing to do with the name in the addressables group settings

#

so we really will just need people to name their assets with the name of their mod as a prefix or something, because the address setting won't prevent collisions of assets of the same name

#

within the lfo_assets label

brittle tendon Nov 8, 2023, 10:35 PM

#

alright, we've officially got addressable plume configs with custom addressable assets

#

there are some obvious issues with that plume, but it wasn't made to be actually used anywhere, it's just a test of the system

#

overall I'm very happy with where LFO is right now, so I think it may be time for a 1.0.0 release pretty soon

brittle tendon Nov 8, 2023, 11:04 PM

#

next step before the release will probably be to write documentation for this

grim bridge Nov 9, 2023, 4:23 PM

#

Hmm, then maybes I can use this to fix LFOs plumes using patch manager (if you do the thing where you put json plumes into addressables)

#

I mean SORRY's plumes

brittle tendon Nov 9, 2023, 4:44 PM

#

yeah, that was really my main reasoning for that feature

#

I have some work stuff I need to finish today, and work all day tomorrow, but I'll try to take a look at it either later tonight or tomorrow after work

#

it shouldn't be too difficult

brittle tendon Nov 11, 2023, 5:17 AM

#

alright, it seems to be working, though I'm not 100% sure if it's done in time for Patch Manager to patch the plumes

#

but it probably should be?

#

the plumes are registered as addressables in an action added through Loading.AddAssetLoadingAction in Awake

#

and also the one plume that is actually in addressables seems to be loaded twice for some reason

#

(though it just means that the 2nd time will overwrite the 1st time)

#

I'll push it to dev anyway, since it seems to not have broken anything so far

grim bridge Nov 12, 2023, 11:47 AM

#

You said its being loaded twice?

#

Where did you build the plume to

#

Did you put it under plugin_template/assets/plumes?

brittle tendon Nov 12, 2023, 11:48 AM

#

no

#

it's only in the addressables

#

you can see here that it's definitely not coming from the file system, since it doesn't have a full path as its name

grim bridge Nov 12, 2023, 11:54 AM

#

Hmm, it is being loaded twice for some reason

brittle tendon Nov 12, 2023, 11:55 AM

#

yeah, and it's the only thing in the addressables with the lfo_configs label

grim bridge Nov 12, 2023, 11:56 AM

#

Can you send your ksp.log?

brittle tendon Nov 12, 2023, 11:57 AM

#

here's both

📎 Player.log

grim bridge Nov 12, 2023, 11:58 AM

#

It only calls the loading action once ... hmmm

#

Are you sure you didn't accidentally put it into 2 groups or something

brittle tendon Nov 12, 2023, 11:59 AM

#

grim bridge Nov 12, 2023, 11:59 AM

#

Gotcha

#

I am utterly confused

brittle tendon Nov 12, 2023, 12:02 PM

#

same

grim bridge Nov 12, 2023, 12:03 PM

#

And the addressable action just does a load by label with the game ... hmmm

pliant widget Nov 18, 2023, 1:31 PM

#

When this in LFO klueless

grim bridge Nov 18, 2023, 1:32 PM

#

Gods I cant imagine the work needed for that, to combine multiple plumes into one

brittle tendon Nov 18, 2023, 1:33 PM

#

Lux was working on it

#

😭

#

or planning to

deep surge Nov 18, 2023, 1:58 PM

#

grim bridge Gods I cant imagine the work needed for that, to combine multiple plumes into on...

Cheese just look at these mach diamonds Cheese do it for them

brittle tendon Nov 18, 2023, 1:58 PM

#

I mean it would be relatively easy to make with current LFO if someone made a single SH engine, like in Starship Expansion Project

deep surge Nov 18, 2023, 2:00 PM

#

wouldnt it be very difficult to have it behave realistically though, since the inner 13 engines can all gimbal independantly?

eternal robin Nov 18, 2023, 3:10 PM

#

Not rlly

#

Its been done with ksp1 waterfall

brittle tendon Nov 18, 2023, 3:13 PM

#

Tundra and SEP for KSP1 both have single engines with 9/33 nozzles

#

and they all gimbal correctly as they should

eternal robin Nov 18, 2023, 4:44 PM

#

Is LFO for v.1.5 out yet?

brittle tendon Nov 18, 2023, 5:42 PM

#

#1170561870026002433 message

grim bridge Nov 18, 2023, 5:43 PM

#

We should release the version with addressables

brittle tendon Nov 19, 2023, 1:17 AM

#

grim bridge We should release the version with addressables

ah yeah, you're right, I should probably just do that

#

though I feel like I'd rather do some more testing first

#

considering that weird asset duplication bug

#

and the major architecture rewrite

#

maybe a prerelease?

brittle tendon Nov 19, 2023, 2:37 AM

#

well fuck me, I just spent like 30 minutes typing up a detailed changelog along with instructions for the 1.0 prerelease

#

and then I fucking misclicked and left the GH page and it's all lost

#

lmao

#

I am so not redoing that tonight

eternal robin Nov 19, 2023, 11:56 PM

#

is there a new dev kit for making plumes for the new version?

brittle tendon Nov 19, 2023, 11:57 PM

#

the Unity package is already at 1.0 on the main branch, since I was going to release the 1.0 mod as well yesterday

#

so I might as well just do that now

#

install from Git URL https://github.com/KSP2Community/LFO.Editor.git

#

also have to delete the old LFO folder

#

in your project

#

and existing plume components will almost definitely be broken, but that's why I added an option to fully create the plume object hierarchy from a JSON config, so redoing it shouldn't take long

#

at most you should have to move/scale/rotate the root plume object since LFO doesn't know anything about your original transform

eternal robin Nov 20, 2023, 12:00 AM

#

Thanks

brittle tendon Nov 20, 2023, 12:01 AM

#

I hate that I lost all the text I was writing yesterday because it explained everything in detail

#

nooooooooo

eternal robin Nov 20, 2023, 12:01 AM

#

this is so sad

brittle tendon Nov 20, 2023, 12:01 AM

#

I was going to write docs and then release 1.0

#

but I'll just do the opposite lol

#

since plumes made with the new editor (if using addressables) will only work with LFO 1.0

#

(old plumes will still work as well though)

eternal robin Nov 20, 2023, 12:21 AM

#

i gotta make new plumes since my old ones are distorted

brittle tendon Nov 20, 2023, 12:22 AM

#

yeah, Lux either updated or rewrote the mesh additive shader for 0.9

#

so old plumes don't look great, the issue is mostly with the linear and quadratic expansion parameters from what I've seen

#

well, not sure if I'd call it "issue", I feel like it makes more sense the way it's set up now

#

but we don't have the source for the old version of the shader so there's no way to compare the code

brittle tendon Nov 20, 2023, 12:43 AM

#

it is done

#

1.0 is released

#

now let's just hope I don't get a flurry of bug reports lmao

tranquil plank Nov 20, 2023, 2:18 PM

#

grim bridge Gods I cant imagine the work needed for that, to combine multiple plumes into on...

i would image it could either be, a set of 3 plumes for different states, like a plume for each ring, and then a combined plume. or if you really wanna get crazy, some light raymarching for each plume

brittle tendon Nov 20, 2023, 2:19 PM

#

I'm pretty sure raymarching was what Lux was working on

tranquil plank Nov 20, 2023, 2:19 PM

#

yeah that makes sense

#

those are gonna be some computationally expensive plumes

brittle tendon Nov 20, 2023, 2:20 PM

#

but since I kinda took over this project (at least until Lux is hopefully back), guess I'll have to learn shader programming and all these techniques lmao

#

that's going to be fun, coming from a place where I have like 0 experience with graphics munley

tranquil plank Nov 20, 2023, 2:21 PM

#

oof, good luck. you know about the youtuber sebastian lague?

brittle tendon Nov 20, 2023, 2:21 PM

#

yep, love his videos

tranquil plank Nov 20, 2023, 2:21 PM

#

dope, then you already know about his raymarching vid(s)

brittle tendon Nov 20, 2023, 2:22 PM

#

yeah

tranquil plank Nov 20, 2023, 2:22 PM

#

brittle tendon that's going to be fun, coming from a place where I have like 0 experience with ...

graphics is fun........after you've gone through the hell making it work. It looks pretty!

brittle tendon Nov 20, 2023, 2:22 PM

#

guess my uni linear algebra course will come in handy now lol

tranquil plank Nov 20, 2023, 2:24 PM

#

oh yeah it will lmao. 3D math is vital to a lot of game programming, especially graphics. Did your linear algebra course cover matrices, and quaternions, and transforming vectors?

brittle tendon Nov 20, 2023, 2:26 PM

#

not quaternions, but other than that it was pretty in-depth (and also the course with the lowest passing rate of the whole software engineering program, at like 15% lifesupport )

tranquil plank Nov 20, 2023, 2:26 PM

#

oooof

tranquil plank Nov 20, 2023, 2:26 PM

#

brittle tendon not quaternions, but other than that it was pretty in-depth (and also the course...

yeah, for games the only thing you really need to know about quaternions is that they rotate stuff good

#

anything more would require a math degree

grim bridge Nov 20, 2023, 2:27 PM

#

Quaternions are fun

#

4 dimensional complex numbers

#

Just do everything with transformation matrices lol

tranquil plank Nov 20, 2023, 2:27 PM

#

grim bridge 4 dimensional complex numbers

woo hell yeah

pliant widget Nov 20, 2023, 2:29 PM

#

I really like this talk to understand where quaternions come from mathematically: https://youtu.be/htYh-Tq7ZBI

YouTube

Freya Holmér

Why can't you multiply vectors?

..or can you? A deceptively simple question with a complex answer – come join a mathematical journey into madness and wonder, in search of answers that might just give you a new perspective on the mathematical constructs we use in our games

Recorded at Dutch Game Day 2023, October 4th

Timestamps:
00:00 Intro
04:34 Talk Start
05:17 Anatomy of a...

▶ Play video

grim bridge Nov 20, 2023, 2:30 PM

#

I mean ive watched that video yeah

brittle tendon Nov 20, 2023, 2:30 PM

#

nice, thanks, I'll definitely watch it

grim bridge Nov 20, 2023, 2:30 PM

#

And quaternions do actually describe certain 4x4 matrices

hybrid sonnet Dec 22, 2023, 7:16 PM

#

are there configs for the vanilla engines?

brittle tendon Dec 22, 2023, 7:17 PM

#

nope, it would require some extra work in removing the stock engine plumes, which I haven't gotten around to

eternal robin Dec 25, 2023, 2:32 PM

#

any documentation available on controllers (like atmoDepth or throttle) and exporting plumes?

brittle tendon Dec 25, 2023, 2:33 PM

#

I don't think Lux has written any docs for this, and I haven't gotten to it yet (in addition to not even completely understanding everything 100% yet myself)

#

but I can try to assist

eternal robin Dec 25, 2023, 2:39 PM

#

i will probably need that help when i get back from my trip

#

i need to make new plumes since my old ones are not working properly in the new LFO

brittle tendon Dec 25, 2023, 2:40 PM

#

yeah, Lux made some changes in the shader in 0.9 before he took off

#

but it should only be a matter of changing a "-1" to "0" in one spot

eternal robin Dec 25, 2023, 2:53 PM

#

Oh cool

#

so i dont have to redo them

brittle tendon Dec 25, 2023, 2:54 PM

#

Well, the LFO editor import has now been changed to an actual Unity package installed in the Package Manager, and most of the backend and editor stuff has been rewritten

#

but

#

I added a button for "Create plume from JSON"

#

so even though the old plume objects won't work with the new LFO version, you can just import your JSON plumes back into the editor with one click

#

and then just fix up the number stuff and correctly rotate/scale the plume (since the exported JSON has no fields for the root transform)

#

it should be relatively straight-forward, I tried to make the "remaking" process as simple as possible

eternal robin Dec 25, 2023, 2:56 PM

#

nicee

brittle tendon Dec 25, 2023, 2:57 PM

#

and then you just click a button to export the plumes and you'll get the addressables to put into your mod folder

#

(new plumes are in addressables instead of just in JSON files)

#

it allows other people to patch your plumes with Patch Manager if they want

eternal robin Dec 25, 2023, 2:57 PM

#

cool

#

thx for keeping it simple

eternal robin Dec 29, 2023, 7:16 PM

#

brittle tendon I added a button for "Create plume from JSON"

where is this button?

brittle tendon Dec 29, 2023, 8:38 PM

#

When you right click on an object in the scene hierarchy (for example your thrust transform), there should be a for LFO

#

Under create or something like that probably

#

I'll take a look at soon as I get to my computer

brittle tendon Dec 29, 2023, 9:09 PM

#

eternal robin where is this button?

#

by the way, you will need to delete any old LFO files you may have imported into your project

#

I think it was just a folder called LFO

#

and add the new Unity package

#

in Package Manager, add from git url: https://github.com/KSP2Community/LFO.Editor.git

brittle tendon Dec 30, 2023, 5:10 PM

#

@eternal robin here's a video that should hopefully help with the whole updating process

eternal robin Dec 30, 2023, 5:10 PM

#

thanks

brittle tendon Dec 30, 2023, 5:11 PM

#

the only thing I didn't show off at the end is that when you are done with all of that and have the plume file in your addressables group, you can simply delete the old assets/plumes folder, and just rebuild the addressables and replace the old ones with the new version, since the plume will now be in them

#

though, if you do not have KSP2 Unity Tools set up like this, you'll want to do that first (the window is in Tools -> KSP2 Unity Tools)

#

you can import your swinfo.json instead of typing it manually

#

and after setting that up, when you click "Set Up Addressables From Mod Info", you should get a new addressables group labeled with the name of your mod below the Default Local Group

#

you'll want to move all the assets from the default group into the new one

#

(not sure if this is something you already have or not)

#

oh and another tiny thing, at first I accidentally clicked "Save plume" before unchecking "Don't use addressables", that will simply save the JSON file into plugin_template/assets/plume_name.json, and we don't want that

brittle tendon Dec 31, 2023, 11:54 AM

#

@final plaza

final plaza Dec 31, 2023, 11:54 AM

#

nice

brittle tendon Dec 31, 2023, 11:54 AM

#

I make a couple of mistakes during the video, but I correct them

#

so hopefully it will not be too confusing

#

(I barely knew myself how LFO works, I only took it up during Lux's absence to update and maintain it)

#LFO - Lux's Flames and Ornaments