Space Warp | KSP2 Redux | Page 6

timber cedar Mar 23, 2023, 5:44 AM

#

i think your not beliving enough

little bay Mar 23, 2023, 6:37 AM

#

(it doesn't compile btw)

timber cedar Mar 23, 2023, 6:40 AM

#

xdd

#

just dont belive enough

timber cedar Mar 23, 2023, 9:04 AM

#

https://devhub.checkmarx.com/cve-details/Cx46691637-14e8/

DevHub

Improper Handling of Exceptional Conditions in Newtonsoft.Json - Cx...

Newtonsoft.Json prior to version 13.0.1 is vulnerable to Insecure Defaults due to improper handling of StackOverFlow exception (SOE) whenever nested expressions are being processed. Exploiting this vulnerability results in Denial Of Service (DoS), and it is exploitable when an attacker sends 5 requests that cause SOE in time frame of 5 minutes. ...

sacred jasper Mar 23, 2023, 11:05 AM

#

We cant change the newtonsoft version

#

We are stuck with what ksp uses

sacred jasper Mar 23, 2023, 12:11 PM

#

A bit too shrunk

#

@gilded kettle This is what you wanted somewhat?

#

How did the blank space at the top get added back @timber cedar?

gilded kettle Mar 23, 2023, 12:14 PM

#

sacred jasper <@135118540377161728> This is what you wanted somewhat?

Yup it looks good!

#

btw what field is that? Plugin_Name?

#

or is it the swinfo?

sacred jasper Mar 23, 2023, 12:15 PM

#

gilded kettle or is it the swinfo?

Its the swinfo

#

I might actually play some KSP2 for a bit

gilded kettle Mar 23, 2023, 12:41 PM

#

lmao havent done that in a while ngl

sacred jasper Mar 23, 2023, 12:50 PM

#

I still don't know what to work on w/ space warp rn, nobody makes feature requests ree

gilded kettle Mar 23, 2023, 12:52 PM

#

I'll make one

#

Ability to reload files

#

i want that to be able to reload textures on TUX so that artists dont have to reopen the game everytime they change a texture

#

Maybe only allow reloading textures that have already been loaded, so you only have to look at a limited number of paths

#

also the ability to load .cfg files, my plan is to make TUX export .cfg with the textures and settings that the artists set, this would work with configuration manager (i think)
Also the ability to get .jsons!!

#

and when present in the Mod/assets/images/partName/shader.cfg it would be loaded by TUX (or Colors) with the right configuration

#

this would also allow for part configuration out of the json i believe, but still have to dive into that

#

want me to put all this on a feature request?

#

Also would be nice to be able to get assets by their name, ignoring the rest of the path since thats how KSP2 does too(mostly), right now Colors has to store the modGUID in order to find the textures

sacred jasper Mar 23, 2023, 12:58 PM

#

Only problem w/ that is if 2 mods define an asset by the same name

gilded kettle Mar 23, 2023, 1:04 PM

#

hmm true, well i can always get the modguids on the SpaceWarp so its all good

#

but the .cfg and .json is a must!

#

and the Reload or ReImport

sacred jasper Mar 23, 2023, 1:09 PM

#

Also soontm

gilded kettle Mar 23, 2023, 1:10 PM

#

patrickpray

sacred jasper Mar 23, 2023, 1:11 PM

#

Broken for the moment?

gilded kettle Mar 23, 2023, 1:13 PM

#

loc is quite annoying tbh

#

what are u using to edit the csv?

sacred jasper Mar 23, 2023, 1:14 PM

#

Excel, but the CSV looks fine?

Key,Type,Description,English
SpaceWarp/ModList/Header,Text,,spacewarp.modlist
SpaceWarp/ModList/SpaceWarpMods,Text,,SpaceWarp Mods
SpaceWarp/ModList/UnmanagedMods,Text,,Unmanaged Mods
SpaceWarp/ModList/Version,Text,,Version
SpaceWarp/ModList/Author,Text,,Author
SpaceWarp/ModList/outdated,Text,,outdated
SpaceWarp/ModList/Source,Text,,Source
SpaceWarp/ModList/Description,Text,,Description
SpaceWarp/ModList/KSP2Version,Text,,KSP2 Version
SpaceWarp/ModList/Dependencies,Text,,Dependencies
SpaceWarp/ModList/OpenConfigManager,Text,,Open Configuration Manager
SpaceWarp/ModList/unsupported,Text,,unsupported
SpaceWarp/Mods,Text,,Mods

#

@gilded kettle it's loading the terms it seems?

#

But why isn't it localizing them

gilded kettle Mar 23, 2023, 1:25 PM

#

hmm yeah everything seems fine, thats very wierd, probably you need to acess them differently

#

these are custom fields, only tried to loc KSP2 fields

sacred jasper Mar 23, 2023, 1:25 PM

#

#

This is how I access them

#

Localization sus?

#

Cool, got it to show the missing translation warning

#

If any <@&1078770539688112168> or <@&1079271050644303922> wants to try and figure out what I am doing wrong w/ localizing?
https://github.com/SpaceWarpDev/SpaceWarp/tree/localizations

GitHub

GitHub - SpaceWarpDev/SpaceWarp at localizations

A C# modding API for KSP2 built off of BepInEx. Contribute to SpaceWarpDev/SpaceWarp development by creating an account on GitHub.

lime plaza Mar 23, 2023, 1:44 PM

#

sacred jasper Excel, but the CSV looks fine? ``` Key,Type,Description,English SpaceWarp/ModLis...

Change your line endings to lf

sacred jasper Mar 23, 2023, 1:44 PM

#

Are you kidding me

lime plaza Mar 23, 2023, 1:44 PM

#

sacred jasper Are you kidding me

That is specified in the docs I wrote

sacred jasper Mar 23, 2023, 1:45 PM

#

lime plaza That is specified in the docs I wrote

I'm about to commit crime over this, I forgot that excel saved w/ crlf

#

That worked

#

@lime plaza thank you for reminding me

#

@timber cedar can you do russian localization of Space Warps UI text?
Or was someone else doing russian

gilded kettle Mar 23, 2023, 2:07 PM

#

sacred jasper I'm about to commit crime over this, I forgot that excel saved w/ crlf

i thought about that but i assumed u already checked that 😭

#

I can do portuguese

#

wheres the spreadsheet?

#

also, i wonder whats the language name... Cuz theres Portuguese, Portuguese-PT and portuguese-BR

sacred jasper Mar 23, 2023, 2:10 PM

#

gilded kettle wheres the spreadsheet?

SpaceWarpBuildTempate/Localizations

gilded kettle Mar 23, 2023, 2:10 PM

#

okdoki, any idea where i can find the correct language name?

#

http://inter-illusion.com/assets/I2LocalizationManual/LanguagesTab.html tells me its set on unity....

sacred jasper Mar 23, 2023, 2:11 PM

#

Just try each one?

#

Ive no clue

gilded kettle Mar 23, 2023, 2:11 PM

#

ig, works too lmao

sacred jasper Mar 23, 2023, 2:14 PM

#

Xd

gilded kettle Mar 23, 2023, 2:24 PM

#

semiComma Separated Values

#

thx microsoft .D

sacred jasper Mar 23, 2023, 2:29 PM

#

bruh

gilded kettle Mar 23, 2023, 2:47 PM

#

i dont think that in Excel 2022 you can change this wtf

sacred jasper Mar 23, 2023, 2:47 PM

#

#

Is this what you have?

gilded kettle Mar 23, 2023, 2:50 PM

#

mine doesnt show that

#

it goes straight to the windows file manager when i click on the path

#

#

I really hate that microsfot defaults all my programs with portuguese

#

im not used to this at all

#

i'll use notepad++ for now ig

wicked wyvern Mar 23, 2023, 3:00 PM

#

I'll be sitting in the office for another two hours in case anyone needs something but I'm bored af so might as well try to finish the mod toggling lol

gilded kettle Mar 23, 2023, 3:03 PM

#

bro why didnt they use the gobally used pt-pt, en-us, en-gb format????

sacred jasper Mar 23, 2023, 3:04 PM

#

@hard ruin why

#

I did not mean to ping

gilded kettle Mar 23, 2023, 3:04 PM

#

LMAO

sacred jasper Mar 23, 2023, 3:04 PM

#

I didn't select anyone to ping

gilded kettle Mar 23, 2023, 3:04 PM

#

he is all the devs at the same time

sacred jasper Mar 23, 2023, 3:04 PM

#

discord why

wicked wyvern Mar 23, 2023, 3:05 PM

#

kekw

wicked wyvern Mar 23, 2023, 3:06 PM

#

gilded kettle bro why didnt they use the gobally used pt-pt, en-us, en-gb format????

Well, you can specify those

#

Instead of just English you can use English[en-US] etc

wicked wyvern Mar 23, 2023, 3:08 PM

#

gilded kettle he is all the devs at the same time

https://tenor.com/view/star-wars-rise-of-skywalker-emperor-palpatine-i-am-all-the-sith-power-gif-16611942

Tenor

#

All the ~~Sith~~ Devs

sacred jasper Mar 23, 2023, 3:09 PM

#

They aren't even in the IG server

#

lol

gilded kettle Mar 23, 2023, 3:12 PM

#

wicked wyvern Instead of just `English` you can use `English[en-US]` etc

Portuguese should work then, why does it not? buh

wicked wyvern Mar 23, 2023, 3:12 PM

#

It should

gilded kettle Mar 23, 2023, 3:12 PM

#

lol ok

wicked wyvern Mar 23, 2023, 3:12 PM

#

If you don't use CRLF

gilded kettle Mar 23, 2023, 3:12 PM

#

just copy what it says on the settings

#

ok i'll pr the loc

#

wicked wyvern Mar 23, 2023, 3:13 PM

#

Oops

gilded kettle Mar 23, 2023, 3:13 PM

#

cries in çõ

wicked wyvern Mar 23, 2023, 3:13 PM

#

Dumb font with no international support

#

But since it's just the SpaceWarp font, it can be changed

gilded kettle Mar 23, 2023, 3:14 PM

#

or dumb language with stupid chars thinkaboutit

#

i'll pr like this, its still readable

wicked wyvern Mar 23, 2023, 3:14 PM

#

*cries in UITK being a buggy mess*

#

If we could get it to work properly it would make things so much easier lol

gilded kettle Mar 23, 2023, 3:15 PM

#

whats the current problem?

#

iirc it has color selection and i'd like to add that to TUX

wicked wyvern Mar 23, 2023, 3:16 PM

#

https://discord.com/channels/1078696971088433153/1085537097714245662 you can look here

#

Basically the UI seems to be taking on colors from the background (probably some shader issue?) and fonts are either rendering as rectangles or not rendering at all

#

Specifically this: #1085537097714245662 message

gilded kettle Mar 23, 2023, 3:19 PM

#

doesnt it use a material for the font?

#

hmm thats such a wierd bug tho

#

i wonder whats the default uitk shader

wicked wyvern Mar 23, 2023, 3:21 PM

#

When you export a prefab with a UITK UIDocument into a bundle, it includes the font and the shaders

#

The shaders it uses are called Hidden/UIE-Runtime, Hidden/UIE-RuntimeWorld and Hidden/UIE-AtlasBlit

gilded kettle Mar 23, 2023, 3:22 PM

#

have u tried exporting it as an addressable?, doenst make that much sense but idk

#

Since KSP shader are also in addressables ie

#

and fonts too iirc

wicked wyvern Mar 23, 2023, 3:23 PM

#

Still, the prefab can be loaded just fine from the bundle and it should contain references to all those things

gilded kettle Mar 23, 2023, 3:23 PM

#

references are clearly broken tho

wicked wyvern Mar 23, 2023, 3:23 PM

#

Actually

gilded kettle Mar 23, 2023, 3:23 PM

#

or either referencing another thing

wicked wyvern Mar 23, 2023, 3:24 PM

#

I know for a fact that the shaders are loaded

gilded kettle Mar 23, 2023, 3:24 PM

#

font seems to be getting a camera shader

wicked wyvern Mar 23, 2023, 3:24 PM

#

Because I even load them manually

#

Since I want to enable using just pure UXML and USS to render the UIs (without any bundles), I have a bundle with all three of the shaders exported and load them all manually, then I Harmony patch all the methods in the UITK namespace which try to Shader.Find(...) these shaders and instead inject the manually loaded ones

#

Since as far as I know, there's no way to allow shaders that are loaded at runtime dynamically to be found using Shader.Find(...)

#

And I'm sure that these shaders are being used since I can see their names in the UIDocument properties in UnityExplorer

gilded kettle Mar 23, 2023, 3:28 PM

#

hmmm

#

Shaders do have properties, i think shader.find just gives a default one

#

so maybe you'd need to do material.set[etc...]

wicked wyvern Mar 23, 2023, 3:29 PM

#

Well i just patched the already existing code in the UITK assembly

#

And they don't seem to be doing any of it

#

So idk

gilded kettle Mar 23, 2023, 3:30 PM

#

can you decompile the shader?

#

i can do it too if you show me where it is

wicked wyvern Mar 23, 2023, 3:31 PM

#

Well there are some shader disassembly not supported on DXBC messages in there

gilded kettle Mar 23, 2023, 3:31 PM

#

my guess is that the font shader points to a 2d coordinate where the leter is, no 2d coordinate it just uses the whole camera and tahts what were seeing in the fonts

gilded kettle Mar 23, 2023, 3:31 PM

#

wicked wyvern Well there are some `shader disassembly not supported on DXBC` messages in there

just the properties is enough to test i think

wicked wyvern Mar 23, 2023, 3:31 PM

#

Sure, can send you those

gilded kettle Mar 23, 2023, 3:32 PM

#

as for background, it either is average color or color under a pixel, but i couldnt figure out what pixel it was getting it from......

wicked wyvern Mar 23, 2023, 3:32 PM

#

Yeah it seems to be from a specific pixel but can't tell where

gilded kettle Mar 23, 2023, 3:32 PM

#

my guess is, if its not set its 0,0, so left bottom

wicked wyvern Mar 23, 2023, 3:32 PM

#

That makes sense

gilded kettle Mar 23, 2023, 3:33 PM

#

the OAB has the green lines and the yellow lines

wicked wyvern Mar 23, 2023, 3:33 PM

#

Since on the main menu screen it would change color pretty much only when a Kerbal starts flying in from the bottom left corner

gilded kettle Mar 23, 2023, 3:33 PM

#

yes then i think we found the problem

#

shader properties have to be set

#

Font uses a 2d coordinate, and height and width probably on the font texture, no font texture it just uses default

#

Background color probably has some shenanigan for getting the color, maybe a texture with all the used colors? idk

#

its possible that this is all done inside unity editor thus u not finding it on the UITK source

wicked wyvern Mar 23, 2023, 3:35 PM

#

Yeah it is

#

I was testing it in an empty Unity project with just UITK installed

#

Made a UI with UXML, ran the scene, looked just fine

#

Then i exported the prefab and tried to load it in KSP

#

And the result is what you saw

gilded kettle Mar 23, 2023, 3:36 PM

#

probably decompile the editor, and search for Shader.Find(UITK shader)

#

i'm heading out but i can help you figure out the values once im back

#

in about 2h

wicked wyvern Mar 23, 2023, 3:37 PM

#

Works fine from me, that's around when I'll be getting home from work

gilded kettle Mar 23, 2023, 3:37 PM

#

also look at #1087665539264020540 source code, i already have a shader editing base there, you can copy it for tests

#

all in Patch.cs and TUXPlugin.cs iirc

#

repo is on my profile btw, idk if it is on the forum here on disc

sacred jasper Mar 23, 2023, 4:42 PM

#

@gilded kettle did you ever get portuguese translations to work

gilded kettle Mar 23, 2023, 4:42 PM

#

Yup, didnt i pr it?

#

Its Portuguese BR

sacred jasper Mar 23, 2023, 4:51 PM

#

gilded kettle Yup, didnt i pr it?

I dont see a pr lemme check again

gilded kettle Mar 23, 2023, 4:53 PM

#

sacred jasper I dont see a pr lemme check again

Oh yeah i was having auth issues when pring from github desktop

#

Btw if u need i can also help on spacewarp development in general not just colors

sacred jasper Mar 23, 2023, 4:55 PM

#

gilded kettle Btw if u need i can also help on spacewarp development in general not just color...

Would be helpful

gilded kettle Mar 23, 2023, 4:55 PM

#

Great! Ill see what i can do!

gilded kettle Mar 23, 2023, 5:19 PM

#

#1088215385490333706 message
should we add a message if the player as an outdated spacewarp?

#

Using the url for the swinfo of the most recent one

sacred jasper Mar 23, 2023, 5:20 PM

#

gilded kettle https://discord.com/channels/1078696971088433153/1088215385490333706/10885092609...

We do already

#

Space Warp version checks itself post 1.0.0

gilded kettle Mar 23, 2023, 5:20 PM

#

Oh ok so 0.4 it doenst hmm

#

Welp 🤷‍♂️

timber cedar Mar 23, 2023, 5:23 PM

#

sacred jasper How did the blank space at the top get added back <@533428547705110549>?

my mistake sorry i added an extra Guilayout.label(“”) by accident

#

it’s right above the GUILayout.Button(“SpaceWarp Mods”)

#

i think ^
that’s just from memory

sacred jasper Mar 23, 2023, 5:24 PM

#

I fixed ity

timber cedar Mar 23, 2023, 5:24 PM

#

ye

wicked wyvern Mar 23, 2023, 5:26 PM

#

I can confidently say that I don't look forward to merging all these changes into my current code

#

munley

timber cedar Mar 23, 2023, 5:28 PM

#

nooooooooo

#

forgive me my lord

timber cedar Mar 23, 2023, 5:33 PM

#

sacred jasper I fixed ity

combining it and ty klueless
optimized

gilded kettle Mar 23, 2023, 6:16 PM

#

should this happen?

[Info :sorry/images/t-38_v1.rar] registering path "sorry/images/t-38_v1.rar"

#

it loaded a .rar

sacred jasper Mar 23, 2023, 6:16 PM

#

It doesnt check image extensions

timber cedar Mar 23, 2023, 6:17 PM

#

why would it?
that would prevent you from doing anything :D

gilded kettle Mar 23, 2023, 6:34 PM

#

so in theory the "load .cfg and .json" is already implemented, great work guys :D

#

oh yeah, @timber cedar config manager cant really load it from custom paths right?

timber cedar Mar 23, 2023, 6:36 PM

#

it’s the bepinex confit manger :D

#

so i mean, in what way

#

do you want a drag and drop files

#

i guess you could give it an absolute path

gilded kettle Mar 23, 2023, 6:45 PM

#

hmmm, idk if would be optimal, will look into it tho

#

cuz suposedly, every parts would have a config for their shader settings

#

well no need to be every part obviouslyt

#

only if the artist desires so

timber cedar Mar 23, 2023, 6:46 PM

#

theres an "advanced" tab for the config manager, i guess you could use that :D idk

sacred jasper Mar 23, 2023, 7:24 PM

#

@wicked wyvern do you wanna look into creating UITK UIs for space warp
As that would be a great feature to release 1.1.0 w/

wicked wyvern Mar 23, 2023, 7:24 PM

#

I can try

#

just need to finish the toggle feature first

#

quick q: would it be bad to straight up copy one method from BIE source code?

#

I'd rather not have to do a transpiler

sacred jasper Mar 23, 2023, 7:29 PM

#

wicked wyvern quick q: would it be bad to straight up copy one method from BIE source code?

Licensing...

wicked wyvern Mar 23, 2023, 7:29 PM

#

it's not even MIT right

#

well, time to learn IL lol

sacred jasper Mar 23, 2023, 7:30 PM

#

@little bay can help ya w/ this one

little bay Mar 23, 2023, 7:31 PM

#

wha

little bay Mar 23, 2023, 7:31 PM

#

wicked wyvern it's not even MIT right

bepinex 5 is MIT

#

6 is lgpl

wicked wyvern Mar 23, 2023, 7:31 PM

#

oooh

#

does that help my case?

little bay Mar 23, 2023, 7:32 PM

#

but what method are you thinking of copying

wicked wyvern Mar 23, 2023, 7:32 PM

#

I'll need to most likely patch Chainloader.Start

little bay Mar 23, 2023, 7:32 PM

#

yeah thought so

wicked wyvern Mar 23, 2023, 7:32 PM

#

and do lots of stuff there

little bay Mar 23, 2023, 7:34 PM

#

I can do it in like an hour or two

#

just tell me what you need and where

wicked wyvern Mar 23, 2023, 7:37 PM

#

oh damn, thanks

#

I'll quickly put together the resulting "patched" method I need until then

little bay Mar 23, 2023, 7:39 PM

#

just try to keep the number of "blocks" you add fairly low to make it easier on me 😅

#

a block being like

#

if you add three statements between two lines, I can emit all of those at once really easy

wicked wyvern Mar 23, 2023, 7:39 PM

#

yep, got it, will try my best

little bay Mar 23, 2023, 7:40 PM

#

if you put 3 statements in completely different places, I have to jump around to emit them

#

yeah

timber cedar Mar 23, 2023, 7:48 PM

#

https://tenor.com/view/3d-saul-saul-goodman-adamghik-gif-23876766

Tenor

#

aaron

little bay Mar 23, 2023, 8:50 PM

#

yes

wicked wyvern Mar 23, 2023, 9:55 PM

#

@little bay actually the patch might be as simple as this:

#

foreach (var plugin in pluginInfos)
{
    if (File.ReadAllLines(DisabledPluginsFilepath).Contains(plugin.Metadata.GUID))
    {
        DisabledPlugins.Add(plugin);
        pluginInfos.Remove(plugin);
    }
}

#

I don't think I actually need it to do anything else, just need it to prevent plugins with GUIDs from that file from being loaded and to instead get their PluginInfos into my own property

sacred jasper Mar 23, 2023, 9:59 PM

#

Where is the disabled plugins list?

#

Wait brain dumb

wicked wyvern Mar 23, 2023, 9:59 PM

#

it's just a public static property in the patch's class

#

which I then fetch in SpaceWarp

#

I just wrote the code inside the actual BIE file to be able to inspect the code more easily

sacred jasper Mar 23, 2023, 10:01 PM

#

That looks like an easy enough patch

#

I think I could maybe take a look at how to do that for you

#

@wicked wyvern what function is that?

wicked wyvern Mar 23, 2023, 10:05 PM

#

Chainloader.Start()

sacred jasper Mar 23, 2023, 10:06 PM

#

So here

wicked wyvern Mar 23, 2023, 10:07 PM

#

yep between the first two lines should be it

#

but doesn't really matter

#

can be below any of them

#

all the way up to the first foreach that follows, really

sacred jasper Mar 23, 2023, 10:12 PM

#

Actually wait I can just go to an index, as BIEs dll will not update

wicked wyvern Mar 23, 2023, 10:13 PM

#

oh yeah actually that's true

#

lol

#

to be fair I expected the patch to be much more complex but then I kinda just built the rest of the feature around it to make it as simple as possible

#

so I might have as well just done it myself in the end without annoying everyone else here to help

#

😅

sacred jasper Mar 23, 2023, 10:17 PM

#

I'm getting close

#

@little bay this should work?

#

I'm doing it before, so it modifies the item on the stack just before storing it

#

I think I need to return it though

#

@wicked wyvern

using System;
using System.Collections.Generic;
using System.IO;
using BepInEx;
using BepInEx.Bootstrap;
using HarmonyLib;
using MonoMod.Cil;

namespace SpaceWarp.Patching;
[HarmonyPatch]
public static class ExampleHarmonyPatchMunix
{
    const int BepinexChainloaderIndex = 116;
    public static List<PluginInfo> DisabledPlugins = new();
    public static string DisabledPluginsFilepath = "";
    [HarmonyILManipulator]
    [HarmonyPatch(typeof(Chainloader), nameof(Chainloader.Start))]
    private static void PatchInitializationsIL(ILContext ilContext, ILLabel endLabel)
    {
        ILCursor ilCursor = new(ilContext);

        // ilCursor.Goto(BepinexChainloaderIndex, MoveType.After);
        ilCursor.GotoNext(MoveType.Before, instruction => instruction.MatchStloc(3));
        ilCursor.EmitDelegate<Func<List<PluginInfo>,List<PluginInfo>>>(static (pluginInfos) =>
        {
            foreach (var plugin in pluginInfos)
            {
                if (File.ReadAllLines(DisabledPluginsFilepath).Contains(plugin.Metadata.GUID))
                {
                    DisabledPlugins.Add(plugin);
                    pluginInfos.Remove(plugin);
                }
            }
            return pluginInfos;
        });
    }
}

Try this

#

Modify it to reference the correct things, but this should be correct

#

This was useful
https://github-wiki-see.page/m/xiaoxiao921/R2Wiki/wiki/Working-with-IL

Working with IL - xiaoxiao921/R2Wiki GitHub Wiki

wicked wyvern Mar 24, 2023, 12:35 AM

#

It's entirely possible I'm just being dumb again, but the patch doesn't seem to be doing anything

#

as in, I can see the Harmony patch loading in the preloader section in console

#

but can't actually get the code to do anything, including logging

timber cedar Mar 24, 2023, 12:38 AM

#

hm klueless

wicked wyvern Mar 24, 2023, 12:39 AM

#

timber cedar hm <:klueless:1084232164352209038>

it's definitely because of your refactor klueless

timber cedar Mar 24, 2023, 12:39 AM

#

^ yes

#

munley

wicked wyvern Mar 24, 2023, 12:39 AM

#

even though I haven't even merged it into my branch

#

klueless

timber cedar Mar 24, 2023, 12:39 AM

#

always blame the healer husK

wicked wyvern Mar 24, 2023, 12:40 AM

#

well actually

#

I have like the first one you did

#

and there are some exceptions because of it

#

so who knows munley

timber cedar Mar 24, 2023, 12:40 AM

#

...

#

the first one was broken

#

xdd

#

you need to get the current one

wicked wyvern Mar 24, 2023, 12:41 AM

#

most stuff works and I need to test this code and make it work before I break it again completely with another batch of conflicts munley

timber cedar Mar 24, 2023, 12:41 AM

#

https://github.com/SpaceWarpDev/SpaceWarp/commit/6fadf311773194f02ab21fa12a40c1df12a096c0

GitHub

Config Manger fix · SpaceWarpDev/SpaceWarp@6fadf31

#

need this one

#

can we please switch the console font to the rounded

#

like jetbrains mono

#

because the pixel one is fucking unreadable xdd

wicked wyvern Mar 24, 2023, 12:44 AM

#

I just use the BepInEx console tbh

timber cedar Mar 24, 2023, 12:45 AM

#

munley

#

for the rest of us mortals

#

@sacred jasper

#

why use worst font in console

wicked wyvern Mar 24, 2023, 12:46 AM

#

well

#

the whole SpaceWarp UI will (hopefully) soon be rewritten using UITK

timber cedar Mar 24, 2023, 12:46 AM

#

:hope:

wicked wyvern Mar 24, 2023, 12:46 AM

#

(I'll be attempting to do it)

#

so you better pray

#

vaultpeter

timber cedar Mar 24, 2023, 12:47 AM

#

i wanna help

#

xd

#

what is uitk

wicked wyvern Mar 24, 2023, 12:47 AM

#

Unity UI Toolkit

#

you write the UI using XML and something similar to CSS

timber cedar Mar 24, 2023, 12:47 AM

#

:D

#

lets goooo

#

WOOOOOOO

#

YEAHHHHHHHH

#

i get to channel my frontend coding ability

wicked wyvern Mar 24, 2023, 12:48 AM

#

thanks to cheese noticing one dumb mistake of mine, I finally managed to get it working within KSP2

timber cedar Mar 24, 2023, 12:48 AM

#

lol

sacred jasper Mar 24, 2023, 12:48 AM

#

timber cedar <@299685147220115457>

y ping

timber cedar Mar 24, 2023, 12:48 AM

#

asked why such bad font

#

in console

wicked wyvern Mar 24, 2023, 12:49 AM

#

sacred jasper y ping

while you're here: #1079531175380521043 message

sacred jasper Mar 24, 2023, 12:49 AM

#

timber cedar in console

not my choice

timber cedar Mar 24, 2023, 12:49 AM

#

i think shbox choice

#

sacred jasper Mar 24, 2023, 12:49 AM

#

wicked wyvern while you're here: https://discord.com/channels/1078696971088433153/107953117538...

am in vr no can look

wicked wyvern Mar 24, 2023, 12:49 AM

#

heh

timber cedar Mar 24, 2023, 12:49 AM

#

in the metaverse

storm quail Mar 24, 2023, 12:50 AM

#

Cheese, ill send you the youtube link tommarow once the 1080p version is odne processing to youtube

wicked wyvern Mar 24, 2023, 12:50 AM

#

timber cedar in the metaverse

meatverse is the opposite of VR munley

storm quail Mar 24, 2023, 12:50 AM

#

its taking forever to process the 1080p

timber cedar Mar 24, 2023, 12:50 AM

#

sacred jasper am in vr no can look

cheese we should play vr chat

storm quail Mar 24, 2023, 12:50 AM

#

apparently 40 minute long 1080p video is too good for youtube

timber cedar Mar 24, 2023, 12:51 AM

#

wicked wyvern meatverse is the opposite of VR <:munley:1079151401801879582>

munley

#

im quite the meatverse enjoyer

wicked wyvern Mar 24, 2023, 12:52 AM

#

omg noo

#

I just rebased my branch to the current 1.1.0

#

just kill me now

#

so many conflicts

#

🥲

timber cedar Mar 24, 2023, 12:53 AM

#

how many

#

:D

#

i think you should force merge right

sacred jasper Mar 24, 2023, 1:10 AM

#

this is irrelevant to the channel

timber cedar Mar 24, 2023, 1:10 AM

#

good point

wicked wyvern Mar 24, 2023, 1:46 AM

#

well

#

if anyone wants to have a look at it, it's here: https://github.com/jan-bures/SpaceWarp/tree/feature-mod-toggles

GitHub

GitHub - jan-bures/SpaceWarp at feature-mod-toggles

Contribute to jan-bures/SpaceWarp development by creating an account on GitHub.

#

I think most of it is done but the transpiler just doesn't seem to be doing anything

timber cedar Mar 24, 2023, 1:49 AM

#

i mean if there was a specific pr that i could see the dif in klueless

wicked wyvern Mar 24, 2023, 1:49 AM

#

there's 1 commit

#

you can see the diff there

timber cedar Mar 24, 2023, 1:49 AM

#

ah okok

wicked wyvern Mar 24, 2023, 1:49 AM

#

(just check the only one from me at the end of the list)

timber cedar Mar 24, 2023, 1:50 AM

#

it looks p good :D

wicked wyvern Mar 24, 2023, 1:50 AM

#

but it doesn't work

timber cedar Mar 24, 2023, 1:50 AM

#

oh

#

:C

#

oh

wicked wyvern Mar 24, 2023, 1:50 AM

#

that's the issue lol

timber cedar Mar 24, 2023, 1:50 AM

#

wicked wyvern I think most of it is done but the transpiler just doesn't seem to be doing anyt...

^

#

i see now

little bay Mar 24, 2023, 1:55 AM

#

@wicked wyvernyou could try this instead

using System;
using System.Collections.Generic;
using System.IO;
using BepInEx.Bootstrap;
using BepInEx.Logging;
using HarmonyLib;
using Mono.Cecil;
using Mono.Cecil.Cil;
using MonoMod.Cil;

namespace SpaceWarpPatcher;

public sealed class Patcher
{
    public static IEnumerable<string> TargetDLLs
    {
        get
        {
            Harmony.CreateAndPatchAll(typeof(ChainloaderPatch), "SpaceWarpChainloaderPatch");
            ChainloaderPatch.DisabledPlugins = File.ReadAllLines("some path here");
            ChainloaderPatch.Logger = Logger.CreateLogSource("SpaceWarp Disabled Plugins");
            return Array.Empty<string>();
        }
    }

    public static void Patch(AssemblyDefinition unused) { }
}

[HarmonyPatch]
internal static class ChainloaderPatch
{
    public static string[] DisabledPlugins;
    public static ManualLogSource Logger;
    
    [HarmonyILManipulator]
    [HarmonyPatch(typeof(Chainloader), nameof(Chainloader.Start))]
    private static void DisablePluginsIL(ILContext il)
    {
        ILCursor c = new(il);

        c.GotoNext(MoveType.Before,
            x => x.MatchLdcI4(0),
            x => x.MatchStloc(24)
        );

        c.Emit(OpCodes.Ldloc, 24); // current plugin guid
        c.Emit(OpCodes.Ldloc, 5); // set of denied plugins so far
        // false means skip to this plugin, true means continue loading it
        c.EmitDelegate(static bool(string pluginGuid, HashSet<string> deniedSet) =>
        {
            if (Array.IndexOf(DisabledPlugins, pluginGuid) != -1)
            {
                deniedSet.Add(pluginGuid);
                Logger.LogInfo($"{pluginGuid} was disabled, skipping loading...");
                return false;
            }
            return true;
        });
        var continueLabel = c.DefineLabel();
        c.Emit(OpCodes.Brfalse, continueLabel);

        ILLabel realContinueLabel = default;
        c.GotoNext(
            x => x.MatchLdloc(29), // some log message, just need this to find where to branch to
            x => x.MatchCall(AccessTools.DeclaredMethod(typeof(Logger), "LogWarning")),
            x => x.MatchBr(out realContinueLabel)
        );

        continueLabel.Target = realContinueLabel.Target;
    }
}

#

no idea what you guys want the path for this file to be, or its format

wicked wyvern Mar 24, 2023, 1:57 AM

#

alright, will try, thanks!

little bay Mar 24, 2023, 2:00 AM

#

nevermind sad

#

it doesnt work

wicked wyvern Mar 24, 2023, 2:01 AM

#

😆

timber cedar Mar 24, 2023, 2:05 AM

#

nooooooooo

little bay Mar 24, 2023, 2:10 AM

#

debugging at its finest

wicked wyvern Mar 24, 2023, 2:10 AM

#

looks familiar munley

little bay Mar 24, 2023, 2:11 AM

#

oh

#

i'm stupid

#

i used the wrong local index

#

10/10

timber cedar Mar 24, 2023, 2:12 AM

#

little bay i used the wrong local index

localization ^

wicked wyvern Mar 24, 2023, 2:13 AM

#

file localization, index localization, term localization klueless

little bay Mar 24, 2023, 2:13 AM

#

oh well its simpler now anyway

timber cedar Mar 24, 2023, 2:16 AM

#

wicked wyvern file localization, index localization, term localization <:klueless:108423216435...

a true coder klueless

little bay Mar 24, 2023, 2:16 AM

#

i think my game is now failing to load

#

but like

#

not because of this?

#

kekw

wicked wyvern Mar 24, 2023, 2:18 AM

#

husK

timber cedar Mar 24, 2023, 2:19 AM

#

skullissue

#

i should make a discord bot for this server

little bay Mar 24, 2023, 2:20 AM

#

idk you see if this DLL in your patchers folder breaks your game

📎 SpaceWarpPatcher.dll

timber cedar Mar 24, 2023, 2:20 AM

#

virus

little bay Mar 24, 2023, 2:20 AM

#

you literally have a decompiler

#

its 64 lines

timber cedar Mar 24, 2023, 2:21 AM

#

you obfuscated it to look like real code

#

it breaks sw if i launch with it

#

little bay Mar 24, 2023, 2:21 AM

#

oh, also

#

make a random file called test.txt in your game directory

#

it can be empty

#

just needs to exist

timber cedar Mar 24, 2023, 2:22 AM

#

ok

little bay Mar 24, 2023, 2:22 AM

#

i was lazy and just did

ChainloaderPatch.DisabledPlugins = File.ReadAllLines(Path.Combine(Paths.GameRootPath, "test.txt"));

lmao

timber cedar Mar 24, 2023, 2:22 AM

#

xd what

#

thats the disable part?

little bay Mar 24, 2023, 2:23 AM

#

thats how it reads them

#

because i'm lazy

timber cedar Mar 24, 2023, 2:23 AM

#

should be .csv

#

^ .xml

little bay Mar 24, 2023, 2:23 AM

#

okay sure

wicked wyvern Mar 24, 2023, 2:23 AM

#

it's literally just a file with one BIE GUID per line

wicked wyvern Mar 24, 2023, 2:23 AM

#

timber cedar should be .csv

.

timber cedar Mar 24, 2023, 2:23 AM

#

.o file

little bay Mar 24, 2023, 2:23 AM

#

i mean

timber cedar Mar 24, 2023, 2:23 AM

#

.d

little bay Mar 24, 2023, 2:23 AM

#

i guess that is technically a csv

timber cedar Mar 24, 2023, 2:23 AM

#

for disabled

wicked wyvern Mar 24, 2023, 2:24 AM

#

little bay i guess that is technically a csv

I mean technically kekw

wicked wyvern Mar 24, 2023, 2:24 AM

#

timber cedar for disabled

it's just called disabled_plugins in the repo lol

little bay Mar 24, 2023, 2:24 AM

#

anyway, does that freeze your game

timber cedar Mar 24, 2023, 2:24 AM

#

no

#

wiat

#

wait

#

didnt relaunch the game

#

yes

#

little bay Mar 24, 2023, 2:25 AM

#

lovely

timber cedar Mar 24, 2023, 2:25 AM

#

is that good xd

little bay Mar 24, 2023, 2:25 AM

#

no

#

lmao

timber cedar Mar 24, 2023, 2:25 AM

#

xd

wicked wyvern Mar 24, 2023, 2:25 AM

#

yep, stuck on preloader finished

little bay Mar 24, 2023, 2:25 AM

#

which is really weird

#

it should at least get to chainloader ready

wicked wyvern Mar 24, 2023, 2:25 AM

#

timber cedar Mar 24, 2023, 2:26 AM

#

aaron not using __result

little bay Mar 24, 2023, 2:26 AM

#

spinthink

timber cedar Mar 24, 2023, 2:26 AM

#

xdd

#

wtf is that

wicked wyvern Mar 24, 2023, 2:26 AM

#

it's beautiful that's what that is

little bay Mar 24, 2023, 2:26 AM

#

what method is missing

wicked wyvern Mar 24, 2023, 2:26 AM

#

I need it here kekw

timber cedar Mar 24, 2023, 2:26 AM

#

little bay what method is missing

a

wicked wyvern Mar 24, 2023, 2:27 AM

#

little bay what method is missing

that's all there is in the Unity debug console

little bay Mar 24, 2023, 2:27 AM

#

fun

wicked wyvern Mar 24, 2023, 2:27 AM

#

logs don't even get written into

little bay Mar 24, 2023, 2:27 AM

#

i can try to attach a debugger

timber cedar Mar 24, 2023, 2:28 AM

#

rider moment

#

#

🤔

#

what branch is that

wicked wyvern Mar 24, 2023, 2:30 AM

#

that's a different thing

#

this is in 1.1.0

#

and I haven't even made a PR

timber cedar Mar 24, 2023, 2:30 AM

#

#

i think ghost branch

wicked wyvern Mar 24, 2023, 2:31 AM

#

wdym?

timber cedar Mar 24, 2023, 2:31 AM

#

where spacewarp-1.1.0

#

1.0.1

wicked wyvern Mar 24, 2023, 2:32 AM

#

well, merged into main

timber cedar Mar 24, 2023, 2:32 AM

#

but.

#

why is it

#

showign

little bay Mar 24, 2023, 2:32 AM

#

thats nice

wicked wyvern Mar 24, 2023, 2:32 AM

#

timber cedar

that's a tag

#

not a branch

timber cedar Mar 24, 2023, 2:32 AM

#

oh

#

i see

#

blind

timber cedar Mar 24, 2023, 2:33 AM

#

little bay thats nice

:wow:

#

oh wait im poor

wicked wyvern Mar 24, 2023, 2:33 AM

#

little bay thats nice

https://tenor.com/view/sadcat-gif-25701972

Tenor

timber cedar Mar 24, 2023, 2:33 AM

#

munix can you buy me nitro

wicked wyvern Mar 24, 2023, 2:34 AM

#

why does everything I work on end up like this with 86746815 people debugging it and it not working

#

🥲

timber cedar Mar 24, 2023, 2:34 AM

#

munley

wicked wyvern Mar 24, 2023, 2:34 AM

#

timber cedar munix can you buy me nitro

https://tenor.com/view/willj-oprah-oprah-winfrey-winfrey-you-get-a-car-gif-5778731

Tenor

timber cedar Mar 24, 2023, 2:34 AM

#

oprah

wicked wyvern Mar 24, 2023, 2:34 AM

#

EVERYBODY GETS NITRO

timber cedar Mar 24, 2023, 2:34 AM

#

you get a car

#

and

#

you

#

get

#

a

#

car

little bay Mar 24, 2023, 2:44 AM

#

ahhhhh

#

i see now

#

i think

#

i think i'm making BepInEx.dll load too early?

#

or at least i'm forcing it to compile Start too early

wicked wyvern Mar 24, 2023, 2:46 AM

#

would removing the reference to BIE in the patcher and changing typeof(Chainloader) and nameof(Chainloader.Start) to literals help?

little bay Mar 24, 2023, 2:46 AM

#

no, harmony would force it to compile

#

i just need to delay patching start

wicked wyvern Mar 24, 2023, 2:47 AM

#

oh alright

little bay Mar 24, 2023, 2:48 AM

#

yep, that fixed it

#

or, at least

#

the game now loads?

wicked wyvern Mar 24, 2023, 2:57 AM

#

is that good news or bad news? lol

#

my experience with Harmony has so far been "if the game breaks, at least you know the patch is being run" munley

timber cedar Mar 24, 2023, 3:01 AM

#

munley

little bay Mar 24, 2023, 3:01 AM

#

i am currently very confused

timber cedar Mar 24, 2023, 3:01 AM

#

i think thats why munix is not sw dev

little bay Mar 24, 2023, 3:01 AM

#

i mean

wicked wyvern Mar 24, 2023, 3:01 AM

#

timber cedar i think thats why munix is not sw dev

says the refactor master vaultpeter

timber cedar Mar 24, 2023, 3:01 AM

#

correct.

#

i eat my shame with pride

wicked wyvern Mar 24, 2023, 3:02 AM

#

little bay i mean

what's wrong?

timber cedar Mar 24, 2023, 3:03 AM

#

💀 aaron

#

he was never seen again

wicked wyvern Mar 24, 2023, 3:04 AM

#

the Chainloader consumed him

little bay Mar 24, 2023, 3:04 AM

#

i'm dying, sorry

#

okay

timber cedar Mar 24, 2023, 3:04 AM

#

husK

little bay Mar 24, 2023, 3:04 AM

#

i have a new way to make this work

timber cedar Mar 24, 2023, 3:04 AM

#

thats what they all say

wicked wyvern Mar 24, 2023, 3:05 AM

#

timber cedar Mar 24, 2023, 3:06 AM

#

^

#

guys here me out

#

omg

#

ok

#

so

#

we should make a mod

#

that skips loading screens

#

???? GENUIS

wicked wyvern Mar 24, 2023, 3:08 AM

#

make a mod that gives everyone +300 fps

#

5head move

timber cedar Mar 24, 2023, 3:08 AM

#

AWDAWIJDIOAWDIOJ

#

OGM

wicked wyvern Mar 24, 2023, 3:08 AM

#

"Game studios hate this simple trick"

timber cedar Mar 24, 2023, 3:08 AM

#

frfr

#

hear me otu

#

like fr

#

make mod

#

that gives the game 10ms

#

if it takes longer it just cuts it and breaks the update loop

#

🧠

#

i think klueless is the best thing ever made

#

its the pinicle of human creation

wicked wyvern Mar 24, 2023, 3:12 AM

#

it's definitely up there

#

klueless

timber cedar Mar 24, 2023, 3:12 AM

#

munix why no vc

wicked wyvern Mar 24, 2023, 3:14 AM

#

vaultpeter

timber cedar Mar 24, 2023, 3:15 AM

#

neither do i o-o

#

but i vc

maiden abyssBOT Mar 24, 2023, 3:15 AM

#

wicked wyvern Mar 24, 2023, 3:15 AM

#

and I'm extremely insecure about my spoken English lol

timber cedar Mar 24, 2023, 3:15 AM

#

i can barely speak it

little bay Mar 24, 2023, 3:15 AM

#

you speak it fine

timber cedar Mar 24, 2023, 3:16 AM

#

little bay you speak it fine

stfu im trying to make him feel better

wicked wyvern Mar 24, 2023, 3:16 AM

#

klueless

timber cedar Mar 24, 2023, 3:16 AM

#

munix we can speak insert your language here

little bay Mar 24, 2023, 3:17 AM

#

klueless

wicked wyvern Mar 24, 2023, 3:17 AM

#

I mean I used to go to all sorts of competitions during elementary and high school and would usually win or at least place in the top 3, but I haven't been speaking for quite a while now and it's just getting worse and worse

timber cedar Mar 24, 2023, 3:17 AM

#

u should vc

little bay Mar 24, 2023, 3:17 AM

#

all it took was

public static class Patcher
{
    public static IEnumerable<string> TargetDLLs => new[] { "UnityEngine.CoreModule.dll" };

    public static void Patch(AssemblyDefinition asm)
    {
        var targetType = asm.MainModule.GetType("UnityEngine.Application");
        var targetMethod = targetType.Methods.Single(x => x.Name == ".cctor");
        
        using var thisAsm = AssemblyDefinition.ReadAssembly(typeof(Patcher).Assembly.Location);
        var delayer = thisAsm.MainModule.GetType("SpaceWarpPatcher.Delayer");
        var patchMethod = delayer.Methods.Single(m => m.Name == "PatchChainloaderStart");
        
        ILContext il = new(targetMethod);
        ILCursor c = new(il);
        c.GotoNext(MoveType.Before,
            x => x.MatchCall("BepInEx.Bootstrap.Chainloader", "Start")
        );

        c.Emit(OpCodes.Call, il.Module.ImportReference(patchMethod));
    }
}

internal static class Delayer
{
    public static void PatchChainloaderStart()
    {
        ChainloaderPatch.Logger = Logger.CreateLogSource("SpaceWarp Disabled Plugins");
        ChainloaderPatch.DisabledPlugins = File.ReadAllLines(Path.Combine(Paths.GameRootPath, "test.txt"));
        Harmony.CreateAndPatchAll(typeof(ChainloaderPatch));
    }
}

wicked wyvern Mar 24, 2023, 3:17 AM

#

little bay

omg

#

huh

#

interesting

little bay Mar 24, 2023, 3:18 AM

#

basically inserting myself in the same place bepinex does

#

immediately in between Chainloader.Initialize and Chainloader.Start

#

patching Start immediately before it runs

timber cedar Mar 24, 2023, 3:19 AM

#

^^ i almost had him vc
and you distracted him

wicked wyvern Mar 24, 2023, 3:19 AM

#

awesome, thanks a lot!

wicked wyvern Mar 24, 2023, 3:19 AM

#

timber cedar ^^ i almost had him vc and you distracted him

I mean it's 4 am and my flatmate is asleep and working tomorrow

#

so there was no chance anyway munley

timber cedar Mar 24, 2023, 3:20 AM

#

i couldnt see a better time

#

munley

wicked wyvern Mar 24, 2023, 3:20 AM

#

klueless

timber cedar Mar 24, 2023, 3:20 AM

#

i need to make a discord bot for the server

little bay Mar 24, 2023, 3:20 AM

#

for what

timber cedar Mar 24, 2023, 3:20 AM

#

to truly track the munley and klueless counts

wicked wyvern Mar 24, 2023, 3:21 AM

#

better include MunixApproved

#

klueless

little bay Mar 24, 2023, 3:21 AM

#

anyway how does this file work

#

where does it go

#

what is it called

timber cedar Mar 24, 2023, 3:21 AM

#

which

#

who

#

what

little bay Mar 24, 2023, 3:21 AM

#

the disabled plugins file

timber cedar Mar 24, 2023, 3:22 AM

#

just put it in the plugins folder

wicked wyvern Mar 24, 2023, 3:22 AM

#

little bay the disabled plugins file

Path.Combine(Paths.PluginPath, "SpaceWarp", "disabled_plugins"); originally here

little bay Mar 24, 2023, 3:22 AM

#

i think it would make more sense in the main bepinex folder

timber cedar Mar 24, 2023, 3:22 AM

#

you should put it in the downloads folder

wicked wyvern Mar 24, 2023, 3:22 AM

#

would it? even if it's SpaceWarp that creates/uses it?

little bay Mar 24, 2023, 3:23 AM

#

the spacewarp plugin doesnt use it

wicked wyvern Mar 24, 2023, 3:23 AM

#

it does

little bay Mar 24, 2023, 3:23 AM

#

the patcher does

wicked wyvern Mar 24, 2023, 3:23 AM

#

that's where I set the values from

timber cedar Mar 24, 2023, 3:23 AM

#

a stale mate

little bay Mar 24, 2023, 3:23 AM

#

well since its used by both, might as well go to the common place between them, the main folder :p

wicked wyvern Mar 24, 2023, 3:23 AM

#

from SpaceWarp's ModListUI class

little bay Mar 24, 2023, 3:23 AM

#

but i'll put it there for now

sacred jasper Mar 24, 2023, 3:24 AM

#

put it in the common place

little bay Mar 24, 2023, 3:24 AM

#

at least give it a .txt extension though

sacred jasper Mar 24, 2023, 3:24 AM

#

easier for users

little bay Mar 24, 2023, 3:24 AM

#

so its openable in a text editor (easily)

wicked wyvern Mar 24, 2023, 3:24 AM

#

that's what I kinda wanted to prevent with the no-extension thing

#

munley

timber cedar Mar 24, 2023, 3:25 AM

#

dont give it extension

#

be a linux man

sacred jasper Mar 24, 2023, 3:25 AM

#

wicked wyvern that's what I kinda wanted to prevent with the no-extension thing

no

#

text editor

wicked wyvern Mar 24, 2023, 3:25 AM

#

ok what about like .cfg or something then?

timber cedar Mar 24, 2023, 3:25 AM

#

.conf

wicked wyvern Mar 24, 2023, 3:26 AM

#

to make it obvious it's important and not just a random text file

timber cedar Mar 24, 2023, 3:26 AM

#

.bat

wicked wyvern Mar 24, 2023, 3:26 AM

#

.mp4

timber cedar Mar 24, 2023, 3:26 AM

#

xdd

#

.nap

little bay Mar 24, 2023, 3:26 AM

#

cfg should be fine, i suppose

#

just files with no extension are annoying on windows

#

so

wicked wyvern Mar 24, 2023, 3:27 AM

#

little bay just files with no extension are annoying on windows

or I could just make it .disabled-plugins or something

sacred jasper Mar 24, 2023, 3:27 AM

#

eww

little bay Mar 24, 2023, 3:27 AM

#

that would make it hidden by default on linux

wicked wyvern Mar 24, 2023, 3:27 AM

#

oh yeah lol

#

nvm, I'll do cfg

timber cedar Mar 24, 2023, 3:28 AM

#

on windows to

wicked wyvern Mar 24, 2023, 3:28 AM

#

seems like a good compromise

timber cedar Mar 24, 2023, 3:28 AM

#

yeah

little bay Mar 24, 2023, 3:28 AM

#

no, windows doesnt use that rule

timber cedar Mar 24, 2023, 3:28 AM

#

call it cfg.cfg

#

little bay Mar 24, 2023, 3:28 AM

#

anyway i'll let you change it

#

can i PR this somewhere

timber cedar Mar 24, 2023, 3:28 AM

#

1.1.0

#

???

#

?.?.?

wicked wyvern Mar 24, 2023, 3:28 AM

#

little bay can i PR this somewhere

https://github.com/jan-bures/SpaceWarp/tree/feature-mod-toggles

GitHub

GitHub - jan-bures/SpaceWarp at feature-mod-toggles

Contribute to jan-bures/SpaceWarp development by creating an account on GitHub.

little bay Mar 24, 2023, 3:28 AM

#

i thought munix had his own branch he was working on

#

yeah

#

i'll PR into that

timber cedar Mar 24, 2023, 3:29 AM

#

munix trying to take over spacewarp

wicked wyvern Mar 24, 2023, 3:29 AM

#

thanks again

sacred jasper Mar 24, 2023, 3:29 AM

#

timber cedar call it cfg.cfg

bruh

wicked wyvern Mar 24, 2023, 3:29 AM

#

timber cedar munix trying to take over spacewarp

https://tenor.com/view/star-wars-i-am-the-senate-gif-10270130

Tenor

#

~~Senate~~ SpaceWarp

timber cedar Mar 24, 2023, 3:29 AM

#

Saint

wicked wyvern Mar 24, 2023, 3:29 AM

#

true and real

little bay Mar 24, 2023, 3:30 AM

#

i'm going to do some other random things real quick

#

now that this has multiple projects in it

wicked wyvern Mar 24, 2023, 3:30 AM

#

sure thing

timber cedar Mar 24, 2023, 3:30 AM

#

all this coding stuff is too hard for me

#

im gonna go back to scratch

wicked wyvern Mar 24, 2023, 3:30 AM

#

timber cedar im gonna go back to scratch

learn Shakespeare

timber cedar Mar 24, 2023, 3:31 AM

#

esolang ^

#

🤮

wicked wyvern Mar 24, 2023, 3:31 AM

#

you could say you're both a programmer and a linguist

#

klueless

timber cedar Mar 24, 2023, 3:31 AM

#

why dosth thou not learnth it thy self

#

idk

sacred jasper Mar 24, 2023, 3:31 AM

#

munix could get org inv tbh

timber cedar Mar 24, 2023, 3:31 AM

#

maybe 🤔

#

jk y ^

sacred jasper Mar 24, 2023, 3:32 AM

#

theyve done a lot

wicked wyvern Mar 24, 2023, 3:32 AM

#

well, not really that much on the actual code of SpaceWarp

#

but I'll happily accept and contribute more

#

vaultpeter

timber cedar Mar 24, 2023, 3:32 AM

#

i think bride ^

sacred jasper Mar 24, 2023, 3:33 AM

#

wicked wyvern but I'll happily accept and contribute more

aight bet

#

Invitation sent

timber cedar Mar 24, 2023, 3:34 AM

#

:O

wicked wyvern Mar 24, 2023, 3:34 AM

#

🥳

#

time to get started on that new KSP2 UITK stylesheet

#

munley

sacred jasper Mar 24, 2023, 3:35 AM

#

Pog

timber cedar Mar 24, 2023, 3:35 AM

#

pog

little bay Mar 24, 2023, 3:35 AM

#

wicked wyvern 🥳

bring it all down

#

immediately

wicked wyvern Mar 24, 2023, 3:35 AM

#

I haven't even tried to import .uss into the game yet, so this might be fun

sacred jasper Mar 24, 2023, 3:36 AM

#

Just use asset bundles :3

wicked wyvern Mar 24, 2023, 3:36 AM

#

also first I need to figure out whether UITK now works with all three of my methods

#

complete UITK prefab in a bundle (we know this works)
UXML and USS in a bundle
UXML and USS loaded from disk

#

since the goal is to allow modders to write the UI without using Unity

sacred jasper Mar 24, 2023, 3:43 AM

#

Fair
But at some point I feel like using unity is going to be inevitable

#

Honestly, I just realized an idea that might be useful ... making our own editor scripts for unity

#

like for part definitions

wicked wyvern Mar 24, 2023, 3:45 AM

#

Yeah that would be really helpful

#

Like a SpaceWarp mini-SDK vaultpeter

timber cedar Mar 24, 2023, 3:49 AM

#

we should just write a ui library

#

klueless

#

munix where to start on this

wicked wyvern Mar 24, 2023, 3:52 AM

#

well UITK already is a UI library basically

#

but I want to make a default KSP2 theme for it to include with SpaceWarp

#

like it already has a skin for IMGUI

timber cedar Mar 24, 2023, 3:54 AM

#

u gonna make a new branch for this?

#

or which branch

wicked wyvern Mar 24, 2023, 3:55 AM

#

first I just want to finish the plugin itself, it's pretty barebones and without any API

timber cedar Mar 24, 2023, 3:55 AM

#

i just wanna push all 425k lines of code i wrote for this

#

munley

wicked wyvern Mar 24, 2023, 3:55 AM

#

#1085537097714245662 message

little bay Mar 24, 2023, 4:01 AM

#

this is the new spacewarp csproj btw

<?xml version="1.0" encoding="utf-8"?>
<Project Sdk="Microsoft.NET.Sdk">
    <PropertyGroup>
        <Version>$(SpaceWarpVersion)</Version>
    </PropertyGroup>
    <ItemGroup>
        <Reference Include="Assembly-CSharp" Private="false" Publicize="true" />
        <Reference Include="Unity.TextMeshPro" Private="false" />
        <Reference Include="UnityEngine.UI" Private="false" />
        <Reference Include="Unity.Addressables" Private="false" />
        <Reference Include="Unity.ResourceManager" Private="false" />
        <Reference Include="KSPLogging" Private="false" />
        <Reference Include="BepInEx.ConfigurationManager" Private="false" Publicize="true">
            <HintPath>..\ThirdParty\ConfigurationManager\ConfigurationManager.dll</HintPath>
        </Reference>
    </ItemGroup>
    <ItemGroup>
        <PackageReference Include="BepInEx.BaseLib" Version="5.4.21" Publicize="true"/>
        <PackageReference Include="HarmonyX" Version="2.10.1"/>
        <PackageReference Include="BepInEx.PluginInfoProps" Version="2.1.0" PrivateAssets="all"/>
        <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.5.0"/>
        <PackageReference Include="Newtonsoft.Json" Version="12.0.1"/>
        <PackageReference Include="UnityEngine.Modules" Version="2020.3.33"/>
        <PackageReference Include="BepInEx.AssemblyPublicizer.MSBuild" Version="0.4.0" PrivateAssets="all"/>
    </ItemGroup>
</Project>

#

chefskiss

wicked wyvern Mar 24, 2023, 4:02 AM

#

does that even work without the lang version specified?

little bay Mar 24, 2023, 4:02 AM

#

it is specified

#

just in a different place

wicked wyvern Mar 24, 2023, 4:02 AM

#

oh

little bay Mar 24, 2023, 4:03 AM

#

#

this file applies to all projects in the solution

sacred jasper Mar 24, 2023, 4:03 AM

#

Damnn

wicked wyvern Mar 24, 2023, 4:03 AM

#

ooh nice

sacred jasper Mar 24, 2023, 4:03 AM

#

Someone should remake configmanager with UITK /hj

little bay Mar 24, 2023, 4:03 AM

#

i just wanted to move the SpaceWarp version into it at first

#

since i wanted the patcher to have the same version

#

but... if i'm already here... might as well

wicked wyvern Mar 24, 2023, 4:04 AM

#

munley

little bay Mar 24, 2023, 4:04 AM

#

also this file

#

which is why the HintPaths disappeared

#

it now just knows to look in external_dlls

#

kekw

wicked wyvern Mar 24, 2023, 4:04 AM

#

very nice

#

project wizard over here

little bay Mar 24, 2023, 4:05 AM

#

you see enough nice projects and pick up a thing or two

wicked wyvern Mar 24, 2023, 4:05 AM

#

there are so many overlapping/similar properties and files to set them etc

#

munley

#

it gives me anxiety how little standardized it feels

#

in .NET

little bay Mar 24, 2023, 4:06 AM

#

its kinda hard to find documentation too

wicked wyvern Mar 24, 2023, 4:06 AM

#

yeah

little bay Mar 24, 2023, 4:08 AM

#

there's https://learn.microsoft.com/en-us/dotnet/core/project-sdk/msbuild-props and https://learn.microsoft.com/en-us/visualstudio/msbuild/msbuild-reserved-and-well-known-properties?view=vs-2022 and https://learn.microsoft.com/en-us/visualstudio/msbuild/common-msbuild-project-properties?view=vs-2022

MSBuild properties for Microsoft.NET.Sdk - .NET

Reference for the MSBuild properties and items that are understood by the .NET SDK.

MSBuild Reserved and Well-known Properties - MSBuild

Learn about the MSBuild reserved and well-known properties, predefined properties that store information about the project file and the MSBuild binaries.

Common MSBuild Project Properties - MSBuild

Learn about common MSBuild project properties that can be defined or used in project files or included in .targets files that MSBuild provides.

#

and that's just for properties, not even items

#

happysad

sacred jasper Mar 24, 2023, 4:08 AM

#

I head sleep now

timber cedar Mar 24, 2023, 4:08 AM

#

👀

#

cya

wicked wyvern Mar 24, 2023, 4:08 AM

#

sacred jasper I head sleep now

I should too, I'm like 6 hours ahead of your time zone munley

little bay Mar 24, 2023, 4:25 AM

#

@wicked wyvern https://github.com/jan-bures/SpaceWarp/pull/1

GitHub

Finish patcher, csproj improvements by Windows10CE · Pull Request #...

timber cedar Mar 24, 2023, 4:26 AM

#

looks cool

wicked wyvern Mar 24, 2023, 4:26 AM

#

awesome, thanks

timber cedar Mar 24, 2023, 4:28 AM

#

@wicked wyvern sleep

#

munley

#

https://tenor.com/view/im-the-boss-now-look-at-me-look-at-me-im-the-boss-now-gif-12198178

Tenor

wicked wyvern Mar 24, 2023, 4:28 AM

#

yeah yeah munley just tested that UITK works even without the markup being loaded through a bundle

timber cedar Mar 24, 2023, 4:29 AM

#

thats good right??

wicked wyvern Mar 24, 2023, 4:31 AM

#

yep

timber cedar Mar 24, 2023, 4:32 AM

#

YAY

#

WOO

#

5head

#

where is some of the uitk code?

#

i wanna read through some of it

wicked wyvern Mar 24, 2023, 4:38 AM

#

uh oh

#

did SpaceWarp switch from referencing Unity dlls in 0.4 to using its nuget package in 1.0 by any chance

#

because that kinda broke my test project after I updated the SpaceWarp dependency

#

is there any way to force the project use the referenced .dlls instead of a dependency of a dependecy?

#

I can just stick with the 0.4 nuget package for testing purposes, since I don't use any 1.0 APIs anyway

#

but it complicates things just a little

#

nice, so all my methods seem to work fine for rendering

#

this is the method that creates that UI with just C#

#

<ui:UXML xmlns:ui="UnityEngine.UIElements" xmlns:uie="UnityEditor.UIElements"
        xsi="http://www.w3.org/2001/XMLSchema-instance" engine="UnityEngine.UIElements" editor="UnityEditor.UIElements"
        noNamespaceSchemaLocation="../UIElementsSchema/UIElements.xsd" editor-extension-mode="False">
    <ui:VisualElement style="flex-grow: 1;">
        <ui:Label text="This is a Label" display-tooltip-when-elided="true"/>
        <ui:Button text="This is a Button" display-tooltip-when-elided="true" name="button"/>
        <ui:Toggle label="Display the counter?" name="toggle"/>
        <ui:TextField picking-mode="Ignore" label="Text Field" text="filler text" name="input-message" />
    </ui:VisualElement>
</ui:UXML>

and this is the equivalent UXML

#

now that I know it's all working well, time for bed

#

and in the morning, ~~I'm making waffles~~ time to finish up the KSP2UITK library and then finally make some actual UI with it

#

🥳

little bay Mar 24, 2023, 4:59 AM

#

wicked wyvern is there any way to force the project use the referenced .dlls instead of a depe...

it should just do that, i think

#

what dependency are you trying to fix

wicked wyvern Mar 24, 2023, 5:01 AM

#

I'm referencing custom versions (the ones from the UITK package) of UnityEngine.UIElements.dll and a few other related assemblies

#

And when I add a nuget reference to Unity, they don't get picked up, UIDocument and other types can't be found and can't build

#

Same when I switched SpaceWarp nuget package from 0.4 to 1.0.1

#

And when I removed it, UITK stuff was working again

timber cedar Mar 24, 2023, 5:03 AM

#

removing = good

#

its the golden rule

wicked wyvern Mar 24, 2023, 5:03 AM

#

Less SpaceWarp less trouble munley

#

Too bad it's a SpaceWarp mod

timber cedar Mar 24, 2023, 5:06 AM

#

wicked wyvern Less SpaceWarp less trouble <:munley:1079151401801879582>

pin please

wicked wyvern Mar 24, 2023, 5:07 AM

#

I just got into the org I'm not about to f around and find out munley

timber cedar Mar 24, 2023, 5:07 AM

#

:D

#

the third sentinel of syntax allows it

wicked wyvern Mar 24, 2023, 5:08 AM

#

Alright, really time to sleep now, the sun is up

timber cedar Mar 24, 2023, 5:08 AM

#

plz sleep

#

munley

#

uwu :3 pwease slep

mossy kraken Mar 24, 2023, 11:50 AM

#

Sorry I been away this whole week, got Covid 🤒

wicked wyvern Mar 24, 2023, 11:50 AM

#

Aw that sucks, hope you're doing better

mossy kraken Mar 24, 2023, 11:51 AM

#

Starting to feel better now 😄

sacred jasper Mar 24, 2023, 12:05 PM

#

Damn that sucks, glad your feeling better

timber cedar Mar 24, 2023, 12:57 PM

#

💀

#

that sucks

#

hope you feel even better

sacred jasper Mar 24, 2023, 1:24 PM

#

Damn ewy, I just looked at your curseforge page and that is impressive

mossy kraken Mar 24, 2023, 1:43 PM

#

😄 Thanks

#

I been doing Minecraft modding for way over 10 years now 😄
Here are some numbers

#

sacred jasper Mar 24, 2023, 1:47 PM

#

That is hella impressive

mossy kraken Mar 24, 2023, 1:50 PM

#

Thank you!
One of the main reasons I wanted to mod KSP2 is because I am kinda burned out on modding MC right now and wanted to try something else

sacred jasper Mar 24, 2023, 1:51 PM

#

Thats completely fair

mossy kraken Mar 24, 2023, 1:52 PM

#

But I also quickly found out that it was way more fun to work on Space Warp instead of my own mods 😛

sacred jasper Mar 24, 2023, 1:54 PM

#

Got tired of Java?

#

/j

mossy kraken Mar 24, 2023, 1:58 PM

#

Been doing java for 15 years now and I have not really got tired of it.
But I much more prefer C# over it

wicked wyvern Mar 24, 2023, 1:58 PM

#

who wouldn't 👀

#

there are definitely worse languages than Java but that doesn't mean I like it tbh

mossy kraken Mar 24, 2023, 1:58 PM

#

I am mostly tired of the JVM itself

wicked wyvern Mar 24, 2023, 1:59 PM

#

understandable

mossy kraken Mar 24, 2023, 1:59 PM

#

The lang itself it pretty nice.

sacred jasper Mar 24, 2023, 2:00 PM

#

Java to CIL compiler? /hj

#

https://manpages.ubuntu.com/manpages/xenial/man1/ikvmc.1.html

wicked wyvern Mar 24, 2023, 2:03 PM

#

Java.NET sounds like the stuff of nightmares

sacred jasper Mar 24, 2023, 2:03 PM

#

Why does it actually exist

#

https://github.com/ikvm-revived/ikvm

GitHub

GitHub - ikvm-revived/ikvm: A Java Virtual Machine and Bytecode-to-...

A Java Virtual Machine and Bytecode-to-IL Converter for .NET - GitHub - ikvm-revived/ikvm: A Java Virtual Machine and Bytecode-to-IL Converter for .NET

#

It's latest release was on february seventh

timber cedar Mar 24, 2023, 2:10 PM

#

mossy kraken I been doing Minecraft modding for way over 10 years now 😄 Here are some number...

goddam

#

klueless

mossy kraken Mar 24, 2023, 2:22 PM

#

sacred jasper https://github.com/ikvm-revived/ikvm

This is real nightmare fuel

sacred jasper Mar 24, 2023, 2:23 PM

#

mossy kraken This is real nightmare fuel

Is it?

#

Nope it is

#

using java.util;

That is cursed

wicked wyvern Mar 24, 2023, 2:24 PM

#

🤮

sacred jasper Mar 24, 2023, 2:26 PM

#

Should I add this to space warp so people can make java mods for KSP2?

#

For legal reasons thats a joke

wicked wyvern Mar 24, 2023, 2:26 PM

#

husK

#

I'd rather just write mods in brainfuck

sacred jasper Mar 24, 2023, 2:27 PM

#

Imagine you go to a github repository for a KSP2 mod and it's written in fucking Java

wicked wyvern Mar 24, 2023, 2:27 PM

#

kekw

#

Scala mods when

sacred jasper Mar 24, 2023, 2:31 PM

#

Nononono

import cli.System.IO.*;

public class ShowDir{

   public static void main(String[] args){
       String[] files = Directory.GetFiles(".");
       for(String file : files){
           System.out.println(file);
       }
   }
}

mossy kraken Mar 24, 2023, 2:31 PM

#

Kotlin plz

wicked wyvern Mar 24, 2023, 2:32 PM

#

"Your scientists were so preoccupied with whether they could, they didn’t stop to think if they should."

sacred jasper Mar 24, 2023, 2:34 PM

#

I can't find much IKVM documentation

timber cedar Mar 24, 2023, 2:36 PM

#

wtf

timber cedar Mar 24, 2023, 2:36 PM

#

sacred jasper Should I add this to space warp so people can make java mods for KSP2?

…

#

munley

little bay Mar 24, 2023, 3:36 PM

#

mossy kraken I been doing Minecraft modding for way over 10 years now 😄 Here are some number...

cf has a rewards program right? if you don't mind me asking, how many points do you normally get for download counts like that?

#

I know that nexus generally pays fairly little, but I've never gotten to ask anyone on curse

mossy kraken Mar 24, 2023, 4:10 PM

#

Let me check

#

Its around 500$ USD /month ish

#

for 1 million monthly downloads

gilded kettle Mar 24, 2023, 4:14 PM

#

sacred jasper For legal reasons thats a joke

good

#

good

mossy kraken Mar 24, 2023, 4:16 PM

#

So around $0.50 per 1000 downloads ish

late condor Mar 24, 2023, 4:18 PM

#

Thats not bad

#

Especially considering it must be mostly passive income at this point

mossy kraken Mar 24, 2023, 4:20 PM

#

Ohh yes it definitely is just passive income at this point.
I just do general maintenance work like critical bug fixes etc

alpine tendon Mar 24, 2023, 5:49 PM

#

@sacred jasper how is it going with the GUI skin? I haven't been able to keep track of development recently

sacred jasper Mar 24, 2023, 5:50 PM

#

alpine tendon <@299685147220115457> how is it going with the GUI skin? I haven't been able to ...

We've paused that on work of implementing a different UI framework into KSP2
#1085537097714245662
Something more modern than IMGUI but relatively easy to use

alpine tendon Mar 24, 2023, 5:50 PM

#

ah good idea

#

can you create UIs programmatically with that?

sacred jasper Mar 24, 2023, 5:51 PM

#

alpine tendon can you create UIs programmatically with that?

Yep

alpine tendon Mar 24, 2023, 5:51 PM

#

sweet

sacred jasper Mar 24, 2023, 5:52 PM

#

@wicked wyvern can confirm and/or give an example

wicked wyvern Mar 24, 2023, 5:52 PM

#

Will be able to be helpful in ~an hour

#

Connection is almost nonexistent at this point in the train ride

timber cedar Mar 24, 2023, 6:57 PM

#

where example

#

i’ve been watching channel for an hour

#

:(

wicked wyvern Mar 24, 2023, 6:57 PM

#

Just got to my computer

timber cedar Mar 24, 2023, 6:57 PM

#

i’m extremely disappointed

#

husK

wicked wyvern Mar 24, 2023, 6:58 PM

#

had to first say hi to the ratties and doggo munley

timber cedar Mar 24, 2023, 6:58 PM

#

munley can i have one rat plz

#

u can send by mail

wicked wyvern Mar 24, 2023, 6:59 PM

#

two at least, they need a companion 👀

timber cedar Mar 24, 2023, 6:59 PM

#

ofc

#

^^^^

wicked wyvern Mar 24, 2023, 6:59 PM

#

keeping a single rat is cruel tbh

timber cedar Mar 24, 2023, 6:59 PM

#

can i have two rattos plz

#

#

needs friends ^^^

#

he was woked

late condor Mar 24, 2023, 7:03 PM

#

wicked wyvern keeping a single rat is cruel tbh

I think the same is true for all pets really

timber cedar Mar 24, 2023, 7:03 PM

#

@sacred jasper we need donate button on github readme klueless

sacred jasper Mar 24, 2023, 7:03 PM

#

what

timber cedar Mar 24, 2023, 7:03 PM

#

donate button

#

so people can give money to hard working devs

timber cedar Mar 24, 2023, 7:04 PM

#

late condor I think the same is true for all pets really

unless they hate each other

sacred jasper Mar 24, 2023, 7:05 PM

#

timber cedar so people can give money to hard working devs

How would I split money and such?

late condor Mar 24, 2023, 7:11 PM

#

You really need to come up with a well thought out thorough plan for that kind of thing

#

You want to remove as much possible abuse as you can to avoid bad feelings

#

Opencollective is built for that kind of thing

sacred jasper Mar 24, 2023, 7:13 PM

#

Yeah, if this were an individual project, I'd slap my kofi link in there and be done

#

but nope

alpine tendon Mar 24, 2023, 7:14 PM

#

it's okay you can just put my donation link and have that be the only one

#

that way everyone's happy

sacred jasper Mar 24, 2023, 7:18 PM

#

late condor Opencollective is built for that kind of thing

That looks interesting, but not necessary for this
We can go about without having donations and stuff lol

#

@wicked wyvern I was gonna add the open mods folder button, then I just realized its gonna be changed w/ UITK so

wicked wyvern Mar 24, 2023, 7:19 PM

#

oh yeah, good call to just wait for that

sacred jasper Mar 24, 2023, 7:20 PM

#

honestly all my next plans are dependent on it

wicked wyvern Mar 24, 2023, 7:20 PM

#

I'll try to prioritize it then

#

guides and other stuff can come later

timber cedar Mar 24, 2023, 7:33 PM

#

sacred jasper How would I split money and such?

by lines of code written munley

sacred jasper Mar 24, 2023, 7:33 PM

#

timber cedar by lines of code written <:munley:1079151401801879582>

I'm not elon musk

timber cedar Mar 24, 2023, 7:33 PM

#

xdddd

#

u got the reference

#

could be 1:7 klueless

#

/j

sacred jasper Mar 24, 2023, 7:45 PM

#

@timber cedar getting called out

timber cedar Mar 24, 2023, 7:46 PM

#

?

#

called out for what

sacred jasper Mar 24, 2023, 7:46 PM

#

look in #🟣space-warp-dev

timber cedar Mar 24, 2023, 7:46 PM

#

xd

wicked wyvern Mar 24, 2023, 7:46 PM

#

Also someone (Sinon) removed all the braces from all the if and foreach statements. This just ends up looking like shit. This is not python. We have braces for a reason. 😅 So I added them all back.
THANK YOU @mossy kraken

timber cedar Mar 24, 2023, 7:46 PM

#

nooooo

#

braces bad

#

indentation matters

wicked wyvern Mar 24, 2023, 7:47 PM

#

go program in python

#

you heathen

timber cedar Mar 24, 2023, 7:47 PM

#

:D

mossy kraken Mar 24, 2023, 7:47 PM

#

😄

timber cedar Mar 24, 2023, 7:47 PM

#

braces < indentation

sacred jasper Mar 24, 2023, 7:47 PM

#

Did you see my comment about not liking my programming language then @mossy kraken lol

wicked wyvern Mar 24, 2023, 7:47 PM

#

if the language is designed around it then sure

#

but not in C-like syntax languages ffs

#

nooooooooo

timber cedar Mar 24, 2023, 7:48 PM

#

c# supports indentation for a reason

#

munley

mossy kraken Mar 24, 2023, 7:48 PM

#

I did 😄
But if it is its own language I prob like it.

I like python. But I can't mix python and C#. I need my own style for both of em

#

So I don't like mixing the two

timber cedar Mar 24, 2023, 7:48 PM

#

valid

#

late condor Mar 24, 2023, 7:48 PM

#

balance in all things

mossy kraken Mar 24, 2023, 7:49 PM

#

Its either all indents or all braces

wicked wyvern Mar 24, 2023, 7:49 PM

#

timber cedar c# supports indentation for a reason

what indentation, you can just do

if (true)
doSomething();

#

that's just nasty

late condor Mar 24, 2023, 7:49 PM

#

mossy kraken Its either all indents or all braces

Don't look at the thunderkit code base

timber cedar Mar 24, 2023, 7:49 PM

#

wicked wyvern what indentation, you can just do ``` if (true) doSomething(); ```

no.

alpine tendon Mar 24, 2023, 7:49 PM

#

One line if statement 🤩

timber cedar Mar 24, 2023, 7:49 PM

#

i write in apple basic so idk

sacred jasper Mar 24, 2023, 7:50 PM

#

if true then doSomething()

or

if true
  doSomething

timber cedar Mar 24, 2023, 7:50 PM

#

we should just make spacewarp a one liner

sacred jasper Mar 24, 2023, 7:50 PM

#

or

if true
{
  doSomething()
  doSomethingElse()
}

timber cedar Mar 24, 2023, 7:50 PM

#

sacred jasper ``` if true then doSomething() ``` or ``` if true doSomething ```

bottom one is best

wicked wyvern Mar 24, 2023, 7:50 PM

#

but not in C#

#

pls

timber cedar Mar 24, 2023, 7:50 PM

#

okok

#

fineeeeee

#

not very minimalistic klueless

wicked wyvern Mar 24, 2023, 7:51 PM

#

verbose and readable > minimalistic

sacred jasper Mar 24, 2023, 7:51 PM

#

minimalistic isn't always good

#

brainfuck is minimalistic

wicked wyvern Mar 24, 2023, 7:51 PM

#

lmao

#

just write in 0s and 1s

#

that's minimalistic af

timber cedar Mar 24, 2023, 7:52 PM

#

just write in

#

there’s a white space esolang

#

i forgot what it’s called

wicked wyvern Mar 24, 2023, 7:52 PM

#

husK

late condor Mar 24, 2023, 7:53 PM

#

timber cedar i forgot what it’s called

Too hard to read the title right?

timber cedar Mar 24, 2023, 7:54 PM

#

maybe yeah

wicked wyvern Mar 24, 2023, 7:54 PM

#

https://en.wikipedia.org/wiki/Whitespace_(programming_language)

Whitespace (programming language)

Whitespace is an esoteric programming language developed by Edwin Brady and Chris Morris at the University of Durham (also developers of the Kaya and Idris programming languages). It was released on 1 April 2003 (April Fool's Day). Its name is a reference to whitespace characters. Unlike most programming languages, which ignore or assign little ...

#

not that difficult to find klueless

sacred jasper Mar 24, 2023, 7:54 PM

#

Should add a whitespace interface to space warp

timber cedar Mar 24, 2023, 7:54 PM

#

yes

sacred jasper Mar 24, 2023, 7:55 PM

#

Or a white space implementation of CIL

timber cedar Mar 24, 2023, 7:55 PM

#

white space os

wicked wyvern Mar 24, 2023, 7:56 PM

#

sacred jasper Should add a whitespace interface to space warp

Shakespeare first pls

wicked wyvern Mar 24, 2023, 8:29 PM

#

timber cedar where example

I had some other stuff to do but I'm here now

timber cedar Mar 24, 2023, 8:30 PM

#

:o

#

video tutorial example

wicked wyvern Mar 24, 2023, 8:30 PM

#

it's nowhere near finished so nope

#

https://github.com/jan-bures/KSP2UITK but you can get the lib here

GitHub

GitHub - jan-bures/KSP2UITK: Unity UI Toolkit support for KSP 2

Unity UI Toolkit support for KSP 2. Contribute to jan-bures/KSP2UITK development by creating an account on GitHub.

#

I'm not adding a release for now (and the two pre-releases don't work fully), I want to finish making an API first

#

but you can download and compile the stuff in master

timber cedar Mar 24, 2023, 8:31 PM

#

gogo

#

when i get home

wicked wyvern Mar 24, 2023, 8:31 PM

#

and it will work

timber cedar Mar 24, 2023, 8:31 PM

#

nice exit

#

how to rest

wicked wyvern Mar 24, 2023, 8:31 PM

#

husK

timber cedar Mar 24, 2023, 8:32 PM

#

munix are you french

#

i forgor

wicked wyvern Mar 24, 2023, 8:33 PM

#

Czech

#

lol

timber cedar Mar 24, 2023, 8:35 PM

#

potato potato

#

i should visit czechland

#

i was in vienna a month ago :(

wicked wyvern Mar 24, 2023, 8:38 PM

#

oh damn, I've never actually been in Austria, other than passing through it

#

even though it's one of our neighboring countries

#

weird

timber cedar Mar 24, 2023, 8:39 PM

#

skiing is 😎 there

wicked wyvern Mar 24, 2023, 8:39 PM

#

I don't ski munley

#

never have been once

timber cedar Mar 24, 2023, 8:39 PM

#

munley

#

i think you hate happiness

wicked wyvern Mar 24, 2023, 8:39 PM

#

I'd rather go somewhere warm than in the mountains, thanks

#

vaultpeter

timber cedar Mar 24, 2023, 8:40 PM

#

timber cedar Mar 24, 2023, 8:40 PM

#

wicked wyvern I'd rather go somewhere warm than in the mountains, thanks

i think you biker

#

you should go mountain biking

#

in austria

wicked wyvern Mar 24, 2023, 8:43 PM

#

timber cedar i think you biker

https://tenor.com/view/wrong-not-nope-gif-22294097

Tenor

timber cedar Mar 24, 2023, 8:44 PM

#

do u not excerise

#

are u 300lbs

#

get it american units for fat ^^^

wicked wyvern Mar 24, 2023, 8:47 PM

#

I don't speak freedom units

timber cedar Mar 24, 2023, 8:47 PM

#

idk either do i

#

i think 300 a lot

wicked wyvern Mar 24, 2023, 9:09 PM

#

when I'm done with all this UI stuff, the next thing I want to do it add more templates to the SpaceWarp.Template package

#

so far it only has one with some basic examples of doing stuff like IMGUI, app bar buttons, using SW's API extensions, etc

#

I'd like to have at least three

#

empty project, basic project (the current one), part mod project

timber cedar Mar 24, 2023, 9:46 PM

#

sounds good

wicked wyvern Mar 24, 2023, 9:46 PM

#

oh I forgot to mention

#

I pushed my testing UITK mod to GitHub just for you 😛

#

https://github.com/jan-bures/UitkTestMod

GitHub

GitHub - jan-bures/UitkTestMod: Test plugin for KSP 2 UITK

Test plugin for KSP 2 UITK . Contribute to jan-bures/UitkTestMod development by creating an account on GitHub.

timber cedar Mar 24, 2023, 9:47 PM

#

lol

#

i’m on ski lift 👀 can’t really look

sacred jasper Mar 25, 2023, 12:47 AM

#

is still waiting for UITK stuff

timber cedar Mar 25, 2023, 12:59 AM

#

do we not have install instructions on the wiki

#

or on the github

#

???

sacred jasper Mar 25, 2023, 1:00 AM

#

For space warp specifically

timber cedar Mar 25, 2023, 1:00 AM

#

yes

#

we need to add to the spacedock

wicked wyvern Mar 25, 2023, 1:00 AM

#

sacred jasper *is still waiting for UITK stuff*

sorry, I've been spending the evening with mod channels shenanigans, I'll start working on it right away

timber cedar Mar 25, 2023, 1:00 AM

#

#1088988819266740224 message

wicked wyvern Mar 25, 2023, 1:41 AM

#

for the love of all that is holy how many times am I going to have to rebase that fork

#

🥲

sacred jasper Mar 25, 2023, 1:41 AM

#

Blame Ewy this time

#

He undid some of Sinon's changes

#Space Warp