Space Warp | KSP2 Redux | Page 4

timber cedar Mar 13, 2023, 9:28 AM

#

you cant iframe

#

i tried xd

#

i was trying to make a three.js embed in a readme

#

and you cant

mossy kraken Mar 13, 2023, 9:29 AM

#

ahh, you are correct

#

Might work if we generate with an unique id and make it so the script can edit our readme file

timber cedar Mar 13, 2023, 9:32 AM

#

no thats not how to do it one sec

#

i got it

#

yep

#

works

#

by adding a query, github doesnt cache it

mossy kraken Mar 13, 2023, 9:33 AM

#

LOL 😄 Nice workaround

timber cedar Mar 13, 2023, 9:33 AM

#

ye

#

let me try rebuilding the images

#

:c maybe it doesnt work

#

should be 707 now

mossy kraken Mar 13, 2023, 9:34 AM

#

damn

timber cedar Mar 13, 2023, 9:41 AM

#

oh

#

i understand how they do it

mossy kraken Mar 13, 2023, 9:42 AM

#

😮

timber cedar Mar 13, 2023, 9:42 AM

#

access-control-allow-origin: *
alt-svc: h3=":443"; ma=86400, h3-29=":443"; ma=86400
cache-control: max-age=120, s-maxage=120
cf-cache-status: MISS
cf-ray: 7a7353b11d9e6420-SJC
content-encoding: br

#

here is the response header of the shields.io badge

#

cache-control

#

u see

#

expires: Mon, 13 Mar 2023 09:44:27 GMT

mossy kraken Mar 13, 2023, 9:43 AM

#

Ahh yes, you can define a age and maxage

timber cedar Mar 13, 2023, 9:43 AM

#

ye

#

ok i need to figure out how

#

xdd

#

ok

#

ok

#

ok

#

#

this should be it

#

hm maybe that wont work

#

im gonna copy the one sheilds.io uses

timber cedar Mar 13, 2023, 10:18 AM

#

xdd

#

my server time is off

#

by 17 minutes

#

no wonder the expire commands are broken

timber cedar Mar 13, 2023, 10:34 AM

#

@mossy kraken

#

xdd

#

im so dumb

#

i did it

#

now for the cron job

#

ok i think its done?

#

yep

#

you can just copy paste it now

mossy kraken Mar 13, 2023, 10:52 AM

#

Wow!

timber cedar Mar 13, 2023, 10:52 AM

#

works for you?

mossy kraken Mar 13, 2023, 10:54 AM

#

Gonna check later

timber cedar Mar 13, 2023, 11:40 AM

#

xd its insane that in the like 2 hours i spent doing that

#

we got like 35 downloads

sacred jasper Mar 13, 2023, 12:36 PM

#

Ayo so im off spring break so am more able to work on this

timber cedar Mar 13, 2023, 12:37 PM

#

:O

#

insane

#

https://github.com/SpaceWarpDev/SpaceWarpDownloads

GitHub

GitHub - SpaceWarpDev/SpaceWarpDownloads: A repository to keep trac...

A repository to keep track of all the Space Warp downloads from all the different platforms. - GitHub - SpaceWarpDev/SpaceWarpDownloads: A repository to keep track of all the Space Warp downloads f...

#

look at the sexy live counter

lime plaza Mar 13, 2023, 2:48 PM

#

Which line endings are you using?

wicked wyvern Mar 13, 2023, 2:49 PM

#

it wasn't the issue, and it's already working

#

https://discordapp.com/channels/1078696971088433153/1079531175380521043/1084284408284065792

#

just had to figure out the correct format for language columns

lime plaza Mar 13, 2023, 2:58 PM

#

wicked wyvern https://discordapp.com/channels/1078696971088433153/1079531175380521043/10842844...

Language code is optional for English

wicked wyvern Mar 13, 2023, 2:59 PM

#

I did it without and the terms did not get automatically translated when using the game's LocKey properties

#

only when I added the language code

#

the localizations that are already in the game also had their language code set to "en"

#

so i did the same

lime plaza Mar 13, 2023, 3:47 PM

#

wicked wyvern I did it without and the terms did not get automatically translated when using t...

What line endings are you using?

#

I found crlf will include the carriage return in the language name

sacred jasper Mar 13, 2023, 3:56 PM

#

Crlf was a mistake

wicked wyvern Mar 13, 2023, 4:02 PM

#

Yep, CRLF

wicked wyvern Mar 13, 2023, 4:02 PM

#

sacred jasper Crlf was a mistake

and agreed

sacred jasper Mar 13, 2023, 4:53 PM

#

Hey instead of one character for new lines have two~

lime plaza Mar 13, 2023, 6:25 PM

#

wicked wyvern Yep, CRLF

Swap to LF, it will allow you to leave off the code

wicked wyvern Mar 13, 2023, 6:27 PM

#

Will try

timber cedar Mar 13, 2023, 7:39 PM

#

average windows crlf user

mossy kraken Mar 13, 2023, 9:25 PM

#

timber cedar https://github.com/SpaceWarpDev/SpaceWarpDownloads

Looks like the pie chart is not updating its download to me : O

timber cedar Mar 13, 2023, 9:31 PM

#

same

#

hmmm

timber cedar Mar 13, 2023, 9:33 PM

#

mossy kraken Looks like the pie chart is not updating its download to me : O

forgot to update url

#

done

mossy kraken Mar 13, 2023, 10:05 PM

#

woo nice, awesome job sinon!

sacred jasper Mar 13, 2023, 10:43 PM

#

Anyways, time to get back to work on SW after I do homework

sacred jasper Mar 13, 2023, 11:26 PM

#

Homework is complete

sacred jasper Mar 13, 2023, 11:42 PM

#

@mossy kraken ftilly very much feels like a bot to me

wicked wyvern Mar 13, 2023, 11:42 PM

#

honestly it was kinda funny but confusing as hell

sacred jasper Mar 13, 2023, 11:49 PM

#

Anyways, going to work on .version checking

#

Or basically

Okay, so the KSP .version format has so much overlapping metadata with swinfo.json, that its a better idea to add an optional field to the swinfo.json called "version_check" which just points to a place to pull an online swinfo from the web

wicked wyvern Mar 13, 2023, 11:56 PM

#

I'd just like to mention that when CKAN for KSP 2 comes out, most mods are probably going to need the .version file anyway

sacred jasper Mar 13, 2023, 11:58 PM

#

wicked wyvern I'd just like to mention that when CKAN for KSP 2 comes out, most mods are proba...

The issue being, that its basically a subset of swinfo.json

wicked wyvern Mar 13, 2023, 11:58 PM

#

Yeah, I get it, but still, I doubt that they will be open to parsing the information from swinfo.json, so the duplication will most likely happen

lime plaza Mar 13, 2023, 11:59 PM

#

Pretty sure ckan is going to parse swinfo.json

wicked wyvern Mar 13, 2023, 11:59 PM

#

Really? I'd have expected a more universal solution that would also support BIE and internal mod loader

#

in that case nevermind

sacred jasper Mar 14, 2023, 12:04 AM

#

Should I prompt for each new mod if their versions should be checked or if space warp as a whole should check all mods versions?

#

@wicked wyvern

wicked wyvern Mar 14, 2023, 12:05 AM

#

I'd be probably just for the second approach

sacred jasper Mar 14, 2023, 12:44 AM

#

Fuck I have nothing to test version checking with/

#

hmm, actually

#

I can quickly test space warps version

#

We need to find a good place to host space warps version info

wicked wyvern Mar 14, 2023, 12:49 AM

#

shouldn't the main branch on GitHub be enough?

sacred jasper Mar 14, 2023, 12:49 AM

#

Fair actually, I'll keep it like that

#

thats how I was gonna test

wicked wyvern Mar 14, 2023, 12:50 AM

#

as long as it always contains the latest released version, it should be just fine

sacred jasper Mar 14, 2023, 12:50 AM

#

yep

sacred jasper Mar 14, 2023, 1:06 AM

#

@wicked wyvern Here we go

wicked wyvern Mar 14, 2023, 1:07 AM

#

Nice!

sacred jasper Mar 14, 2023, 1:07 AM

#

I should do KSP version checking and highlight the mods as red that don't "support" the current KSP version

wicked wyvern Mar 14, 2023, 1:08 AM

#

Sounds like a good idea

sacred jasper Mar 14, 2023, 1:14 AM

#

Just need to figure out where I can get KSP2 versionj

wicked wyvern Mar 14, 2023, 1:24 AM

#

#

it's a non-namespaced class

sacred jasper Mar 14, 2023, 1:42 AM

#

#

Why is it not namespace

wicked wyvern Mar 14, 2023, 1:44 AM

#

no idea, but there are tons of classes like that in the dll

sacred jasper Mar 14, 2023, 1:48 AM

#

Anyways made the PRs

sacred jasper Mar 14, 2023, 2:26 AM

#

@mossy kraken you wanna look over them?

timber cedar Mar 14, 2023, 2:45 AM

#

i can merge them?

#

if ewy ded

sacred jasper Mar 14, 2023, 3:01 AM

#

timber cedar if ewy ded

sure

timber cedar Mar 14, 2023, 3:06 AM

#

both?

sacred jasper Mar 14, 2023, 3:07 AM

#

yes

timber cedar Mar 14, 2023, 3:08 AM

#

k

wicked wyvern Mar 14, 2023, 4:07 AM

#

@sacred jasper about the latest issue on UI: I think it might not be a bad idea to use something like what Twiner/Got suggested here: #🔴mod-dev message

#

From what I'm reading, it seems to be equivalent to the Unity UI in-editor stuff, but with the additional ability to create the UI at runtime

sacred jasper Mar 14, 2023, 4:09 AM

#

Hmm, maybe

wicked wyvern Mar 14, 2023, 4:09 AM

#

https://docs.unity3d.com/2020.3/Documentation/Manual/UI-system-compare.html

#

the main issue is that afaik, it's not included with the game's assemblies, and would need to be basically added as a dependency in a mod

little bay Mar 14, 2023, 8:04 AM

#

@sacred jasper do not just do VersionID.VERSION_TEXT

#

in case you did that

#

use reflection to get the value at runtime instead

#

otherwise you won't actually be checking the version of the running KSP

#

you'll be checking against the version of KSP that SpaceWarp was compiled against

sacred jasper Mar 14, 2023, 11:33 AM

#

little bay <@299685147220115457> do not just do VersionID.VERSION_TEXT

Ohhh

#

facepalm

#

I forgot thats how const worked

sacred jasper Mar 14, 2023, 12:06 PM

#

I blame KSP2s versionid class for this blunder

#

/hj

#

I shouldve looked closer

sacred jasper Mar 14, 2023, 1:31 PM

#

@little bay it hath been fixed

#

var kspVersion = typeof(VersionID).GetField("VERSION_TEXT",BindingFlags.Static | BindingFlags.Public)?.GetValue(null) as string;

sacred jasper Mar 14, 2023, 3:22 PM

#

@wicked wyvern I just need to make it look a bit better

#

wicked wyvern Mar 14, 2023, 3:22 PM

#

awesome

sacred jasper Mar 14, 2023, 3:23 PM

#

And its displaying all the space warp mods twice for some reason

wicked wyvern Mar 14, 2023, 3:23 PM

#

oh yeah, didn't even notice that 😆

sacred jasper Mar 14, 2023, 3:23 PM

#

I figured out why

wicked wyvern Mar 14, 2023, 3:24 PM

#

btw I just noticed that "ModListHeader" label at the top

sacred jasper Mar 14, 2023, 3:24 PM

#

changing it

#

Going to add an empty space between them but @wicked wyvern @late condor how does this look

wicked wyvern Mar 14, 2023, 3:29 PM

#

I'd suggest maybe adding a matching header like "SpaceWarp Mods" on the top

sacred jasper Mar 14, 2023, 3:30 PM

#

wicked wyvern I'd suggest maybe adding a matching header like "SpaceWarp Mods" on the top

Gotcha

#

Almost there, accidentally added a space

#

It hath been added to 1.0.0

wicked wyvern Mar 14, 2023, 3:33 PM

#

nice

sacred jasper Mar 14, 2023, 3:42 PM

#

<@&1078770539688112168> <@&1079271050644303922> could we push for having 1.0.0 be released on the same day as the first patch if it comes thursday?

lime plaza Mar 14, 2023, 3:43 PM

#

sacred jasper <@&1078770539688112168> <@&1079271050644303922> could we push for having 1.0.0 b...

Let’s hope the patch doesn’t break anything

bronze anchor Mar 14, 2023, 3:44 PM

#

sacred jasper <@&1078770539688112168> <@&1079271050644303922> could we push for having 1.0.0 b...

If after patch space warp works correctly then I am not against it

mossy kraken Mar 14, 2023, 5:29 PM

#

Sounds good to me

timber cedar Mar 14, 2023, 6:11 PM

#

idm

sacred jasper Mar 14, 2023, 11:19 PM

#

@wicked wyvern do you think we should add abstractions for active vessels a la this issue
https://github.com/SpaceWarpDev/SpaceWarp/issues/141

GitHub

[FEATURE] Add abstractions for setting the active vehicles throttle...

Feature Information Feature description Currently to set an active vehicles throttle you have to do this. GameManager.Instance.Game.ViewController.flightInputHandler.OverrideInputThrottle(float del...

wicked wyvern Mar 14, 2023, 11:20 PM

#

Hm

#

On one hand it does seem like something very useful

#

but it seems like it there would be A LOT of it

sacred jasper Mar 14, 2023, 11:22 PM

#

wicked wyvern but it seems like it there would be A LOT of it

Elaborate?

#

The other option is extension method hell :3

wicked wyvern Mar 14, 2023, 11:25 PM

#

What I mean is, I think the abstracted API would have to cover a lot of ground to be really useful and to avoid having to mix and match with the game API

sacred jasper Mar 14, 2023, 11:25 PM

#

wicked wyvern What I mean is, I think the abstracted API would have to cover a lot of ground t...

Fair
I might just add extension methods for updating specific flight controls to the dismay of Aaron

#

Thoughts?

#

Asking you specifically munix

wicked wyvern Mar 14, 2023, 11:29 PM

#

Not sure if extension methods are the way to go, it might be a bit disorienting, but I don't know

sacred jasper Mar 14, 2023, 11:30 PM

#

wicked wyvern Not sure if extension methods are the way to go, it might be a bit disorienting,...

Disorienting?

wicked wyvern Mar 14, 2023, 11:32 PM

#

I just feel like in this case it might be a bit confusing to be able to call some methods on existing types that you can't find when for example looking through the original types in a disassembler

sacred jasper Mar 14, 2023, 11:32 PM

#

I don't know how much of an issue that is?

wicked wyvern Mar 14, 2023, 11:33 PM

#

I'm definitely not an expert in designing library APIs or anything of that sort, so it might as well just be completely fine and I'm just paranoid

sacred jasper Mar 14, 2023, 11:34 PM

#

Also is it a dumb idea to just grab a private property like this?
public static VesselVehicle ActiveVesselVehicle => GameManager.Instance.Game.ViewController._activeVesselVehicle;

wicked wyvern Mar 14, 2023, 11:34 PM

#

You will get tons of exceptions before ViewController is instantiated

#

happened to me in Kerbonaut Manager

sacred jasper Mar 14, 2023, 11:34 PM

#

wicked wyvern You will get tons of exceptions before ViewController is instantiated

This getter won't be used before then?

wicked wyvern Mar 14, 2023, 11:34 PM

#

oh I'm dumb, nvm

sacred jasper Mar 14, 2023, 11:35 PM

#

It's literally exposing it for people to quickly grab the active vehicle

wicked wyvern Mar 14, 2023, 11:35 PM

#

I didn't notice the ">"

sacred jasper Mar 14, 2023, 11:49 PM

#

@wicked wyvern look at the latest branch i made, and see what you think

#

I gtg for now

wicked wyvern Mar 14, 2023, 11:51 PM

#

Yeah I guess that works

wise swift Mar 15, 2023, 12:07 AM

#

if you get errors make sure its in flight mode first
GameManager.Instance.Game.GlobalGameState.GetGameState()

storm quail Mar 15, 2023, 12:08 AM

#

Cheese how did you handle such a ginormous growth in the discord server in the first week

sacred jasper Mar 15, 2023, 12:09 AM

#

storm quail Cheese how did you handle such a ginormous growth in the discord server in the f...

pain

storm quail Mar 15, 2023, 12:09 AM

#

lol

wicked wyvern Mar 15, 2023, 12:43 AM

#

Alright, seems like I got UITK loaded successfully, but still don't know fully how to use it from code without loading bundles

sacred jasper Mar 15, 2023, 1:34 AM

#

wicked wyvern Alright, seems like I got UITK loaded successfully, but still don't know fully h...

Aight

#

It's gonna be weird to have that as an external dependency as we package everything in space warp already

wicked wyvern Mar 15, 2023, 1:37 AM

#

I get it, but also it will be nice to provide that for BIE-only mods, too

#

since it has nothing to do with SpaceWarp

sacred jasper Mar 15, 2023, 1:38 AM

#

One thing, I doubt much of anyone will be using BIE only mods

#

but yeah I get that

#

I meant exclusively

#

fuck

#

missed a word only BIE only mods

wicked wyvern Mar 15, 2023, 1:39 AM

#

yeah, but even then, if someone wanted to build a mod without SpaceWarp and use UITK, they would still have to have a SW dependency

sacred jasper Mar 15, 2023, 1:40 AM

#

Not necessarily, I mean just package the entire plugin in the thirdparty folder, like we do w/ bie and configuration manager, we can still put it separately out

#

@wicked wyvern waddya think of that?

wicked wyvern Mar 15, 2023, 1:45 AM

#

I guess so

sacred jasper Mar 15, 2023, 1:46 AM

#

wicked wyvern I guess so

It's for ease of SW installation is all

wicked wyvern Mar 15, 2023, 1:46 AM

#

yeah it makes sense

#

I was mostly against making it an inseparable part of SpaceWarp itself

#

don't really care if it's packaged with it though

sacred jasper Mar 15, 2023, 1:46 AM

#

oh for sure no

wicked wyvern Mar 15, 2023, 1:52 AM

#

https://github.com/jan-bures/KSP2UITK

GitHub

GitHub - jan-bures/KSP2UITK: Unity UI Toolkit support for KSP 2

Unity UI Toolkit support for KSP 2. Contribute to jan-bures/KSP2UITK development by creating an account on GitHub.

#

it's very much just an experimental version

#

I can build it and when I put it in the game, I can access some UI Toolkit types, that's as far as I've verified it so far

#

it might not need all the .dlls specified, and it might need more for other stuff that I haven't tested yet

#

added an experimental pre-release, too

wicked wyvern Mar 15, 2023, 3:30 AM

#

I don't think there's any way yet to dynamically load UXML from a file/string, seems like the only way for now is bundles

#

but it should be possible to create the UI tree just using C# instead of UXML

sacred jasper Mar 15, 2023, 10:55 AM

#

wicked wyvern I don't think there's any way yet to dynamically load UXML from a file/string, s...

@wise swift is not gonna like this

wise swift Mar 15, 2023, 10:56 AM

#

sacred jasper <@436565164674908170> is not gonna like this

I will find a way. I always do.

wise swift Mar 15, 2023, 10:57 AM

#

wicked wyvern I don't think there's any way yet to dynamically load UXML from a file/string, s...

wise swift Mar 15, 2023, 11:41 AM

#

going to try out your 0.0.1

wicked wyvern Mar 15, 2023, 11:46 AM

#

That seems to be an editor-only thing

#

Not for runtime

wise swift Mar 15, 2023, 11:47 AM

#

we will see

wicked wyvern Mar 15, 2023, 11:53 AM

#

Also, the pre-release I have does allow you to use the types from UITK, but it's not complete

#

I tried making a C#-only UI before I went to bed and ended up with a loop of exceptions saying that a shader that it needs couldn't be found

#

I'm pretty sure I'll have to include a default bundle with it

#

About parsing UXML during runtime: https://forum.unity.com/threads/loading-uxml-and-uss-from-text-in-runtime.1200964/

Unity Forum

Question - Loading UXML and USS from Text in Runtime

I'm trying to load uxml and uss from textasset in runtime.
Is this possible in common way now?

Currently, ScriptedImporter generates VisualTreeAsset...

#

Seems that someone made USS loading work at runtime, but not UXML yet

wicked wyvern Mar 15, 2023, 12:17 PM

#

Made a separate post in Projects so we don't clutter this/other channels: https://discord.com/channels/1078696971088433153/1085537097714245662

sacred jasper Mar 15, 2023, 1:06 PM

#

wise swift we will see

EditorGUI stuff is typically not available at runtime unfortunatels

sacred jasper Mar 15, 2023, 6:13 PM

#

@wise swift how did you do the input block for notepad, as I was trying to do something similar for the console to no avail

wise swift Mar 15, 2023, 6:14 PM

#

sacred jasper <@436565164674908170> how did you do the input block for notepad, as I was tryin...

GameManager.Instance.Game.Input.Enable();
InputEnabled = true;

#

sacred jasper Mar 15, 2023, 6:14 PM

#

Its ... that easy? facepalm

#

I was trying to do control locks

wise swift Mar 15, 2023, 6:15 PM

#

yes. would like to have some automatic detection when user is inputting to a text area but IDK how.

#

so I just did the manual button

sacred jasper Mar 15, 2023, 6:16 PM

#

Wait till we use uitk basically

wise swift Mar 15, 2023, 6:16 PM

#

exactly why im excited for it

gilded kettle Mar 15, 2023, 6:19 PM

#

is there any easy way to add a module to all X type parts? just like @Module[Antenna]

#

or would i need to go through all parts and filter by what i want (probably in category or family)

sacred jasper Mar 15, 2023, 6:27 PM

#

gilded kettle is there any easy way to add a module to all X type parts? just like @Module[Ant...

Not as of yet, make a feature request maybe, or I'll write one later

#

Can you show how you want to add modules?

gilded kettle Mar 15, 2023, 6:32 PM

#

so i just wanted to do something like, on postInitialized or smth, remove all Module_Antenna and then add a custom Module_NSRTAntenna

#

something like a Parts.GetByModule<ModuleType>() would be nice cause then ican just foreach it

#

but feel free to implement it as you think is best

sacred jasper Mar 15, 2023, 6:41 PM

#

aaron about to yell at me for extension methods again
But yeah that makes sense

#

Can't be an extension method I don't think but I have an idea

#

Actually nope, I found the partsprovider class

#

@gilded kettle it should hopefully be in the next versions

#

Just working on it rn

gilded kettle Mar 15, 2023, 6:49 PM

#

great :) no need to be an extension tho, if we can get an IEnumerator with the parts thats enough

sacred jasper Mar 15, 2023, 6:49 PM

#

Or in a bit cuz rider is being annoying

gilded kettle Mar 15, 2023, 6:49 PM

#

lmao tyt

sacred jasper Mar 15, 2023, 6:49 PM

#

It makes sense as an extension though

gilded kettle Mar 15, 2023, 6:49 PM

#

it does

sacred jasper Mar 15, 2023, 6:50 PM

#

lemme just quickly work on this in visual studio if rider is gonna be dumb

#


    public static IEnumerable<PartCore> WithModule<T>(this PartProvider provider) where T : ModuleData
    {
        return provider._partData.Values.Where(part => part.modules.OfType<T>().ToArray().Length > 0);
    }

#

So you can do Parts.WithModule<Antenna>

#

gonna quickly make it slightly better

#

@gilded kettle it will be in the next update

#

Would it be worth adding extensions to add/replace modules to parts with a module kinda like a module manager kinda thing

wicked wyvern Mar 15, 2023, 7:07 PM

#

honestly I'd leave that to a tool more like MM in scope

sacred jasper Mar 15, 2023, 7:08 PM

#

That's fair yeah

wicked wyvern Mar 15, 2023, 7:08 PM

#

although, I suppose there is no reason SpaceWarp can't try to do something like that (using some sort of json schema for similar purposes to MM patches perhaps)

#

it's already sort of an all-in-one kind of project

#

but that would be a pretty big undertaking for now

sacred jasper Mar 15, 2023, 7:09 PM

#

Might be worth looking into, but as you said seems a bit much for now

wicked wyvern Mar 15, 2023, 7:10 PM

#

and considering there are 0 released parts mods as of now, it makes sense to wait a bit

gilded kettle Mar 15, 2023, 7:23 PM

#

wicked wyvern and considering there are 0 released parts mods as of now, it makes sense to wai...

if SAS wasn't as it is rn, i'd release my gridfins... But the craft gets wobbly when using them... they do work tho, 40m/s reduction from a 5km drop, its a very good low profile alternative to Reaction Wheels

#

i'm guessing this is the culprit https://forum.kerbalspaceprogram.com/index.php?/topic/213439-sas-oscillations-diagnosed/#comment-4245017

Kerbal Space Program Forums

SAS Oscillations (diagnosed)

The SAS appears to be miss aligned and it takes Roll inputs and produces a Yaw output and then takes Yaw inputs and produces a Roll output. I compared control surface movement to the SAS reaction while in orbit (so control surfaces had no authority) and that was the result I found.

wicked wyvern Mar 15, 2023, 7:24 PM

#

That's such a dumb bug if it's true husK

gilded kettle Mar 15, 2023, 7:26 PM

#

hmm i wonder, a channel for sharing unfinished mods for testing would be nice... Like i'd like to make de gridfins available to who wants to use them even tho their state, but i dont think that creating a new project would be right

#

or maybe i just create a project for the mod and mark it as alpha or smth

wicked wyvern Mar 15, 2023, 7:27 PM

#

I'd say just go for it and make a project post, since #1079110458969165864 is for finished mods

#

so you can totally post WIP stuff in #1078701690762571866

gilded kettle Mar 15, 2023, 7:27 PM

#

hmm ok will look into it then

sacred jasper Mar 15, 2023, 9:37 PM

#

Time for some fun

#

documentation&+

#

Imma quickly run down our entire API and document it ahead of tomorrow

#

Also, I updated rider, bad idea

#

it no work for me now

#

have to use VS for the time being

wise swift Mar 15, 2023, 10:03 PM

#

wicked wyvern honestly I'd leave that to a tool more like MM in scope

would make sense for spacewarp to do it.

wicked wyvern Mar 15, 2023, 10:09 PM

#

Yeah I agree (in my next message after that)

#

but I don't think it needs to be a priority right now

sacred jasper Mar 15, 2023, 10:24 PM

#

@lime plaza when you create localizations to put in an addressables bundle do you still need to create a csv file for the LanguageSourceAsset or do you have the editor script?

lime plaza Mar 15, 2023, 10:25 PM

#

sacred jasper <@177073258716200961> when you create localizations to put in an addressables bu...

You add the terms into the language source asset data

sacred jasper Mar 15, 2023, 10:25 PM

#

lime plaza You add the terms into the language source asset data

What do the terms look like for KSP2 do they still have the / format if you are using the addressables

lime plaza Mar 15, 2023, 10:25 PM

#

sacred jasper What do the terms look like for KSP2 do they still have the `/` format if you ar...

These are different than addressables

sacred jasper Mar 15, 2023, 10:26 PM

#

lime plaza These are different than addressables

I know, misspoke, I'm just asking if the I2Localization terms have the Parts/Title/etc... name or are those terms preexistent and you create a special one for the part

lime plaza Mar 15, 2023, 10:26 PM

#

You add them

#

sacred jasper Mar 15, 2023, 10:27 PM

#

Gotcha

#

I'm just trying to update documentation

sacred jasper Mar 15, 2023, 10:48 PM

#

Example of the updated documentation

#

Im hoping to finish this tomorrow for the space warp release

lime plaza Mar 15, 2023, 10:58 PM

#

If another mod depends on my mod, my mod's onInit will run before theirs right?

sacred jasper Mar 15, 2023, 11:01 PM

#

lime plaza If another mod depends on my mod, my mod's onInit will run before theirs right?

yes

sacred jasper Mar 16, 2023, 3:15 AM

#

@timber cedar I created a PR on the docs repository for version 1.0.0 documentation

timber cedar Mar 16, 2023, 3:15 AM

#

:O kk

#

goddam nice job 👍

#

a couple fixes

#

probably should have not merged that branch, and left it as a 1.0.0 branch

#

because i can assign differenent version in readthedocs

sacred jasper Mar 16, 2023, 3:19 AM

#

rip

#

you can undo

timber cedar Mar 16, 2023, 3:19 AM

#

yeah ik

#

ok ik how to fix

sacred jasper Mar 16, 2023, 3:24 AM

#

Pog

#

Imma sleep now

#

I was just speedrunning documentation

timber cedar Mar 16, 2023, 3:25 AM

#

xd

#

cya

#

#

should be good now

mossy kraken Mar 16, 2023, 12:12 PM

#

Sorry I been a bit busy, it is spring break here in Norway this week 😄
Have the new patch come out of KSP2?

gilded kettle Mar 16, 2023, 12:14 PM

#

[Info :Asset Loader] Did not load asset bundles for Spaceplace and Orbital Recovery and Reutilize companY as no asset bundles folder existed!

Is this only meant for UI? cuz for now all adressables are being loaded from the addressables folder right?

wicked wyvern Mar 16, 2023, 12:19 PM

#

you can use both bundles and addressables

#

but for parts you need addressables

gilded kettle Mar 16, 2023, 12:21 PM

#

oh ok, will this be changed? it makes more sense for all bundles to be there

wicked wyvern Mar 16, 2023, 12:22 PM

#

I mean, they are two different types of bundles

#

so it makes sense for them to be separated

gilded kettle Mar 16, 2023, 12:23 PM

#

oh wtf ok, thought they were the same

wicked wyvern Mar 16, 2023, 12:27 PM

#

I mean, addressables are a subtype of asset bundles

#

https://gamedev.stackexchange.com/questions/184228/advantage-of-using-addressable-over-asset-bundles-in-unity

late condor Mar 16, 2023, 12:32 PM

#

You can use both, but its really a good idea to only use one or the other and do it well

wicked wyvern Mar 16, 2023, 12:33 PM

#

yeah, what I really meant was that SpaceWarp allows you to use either

sacred jasper Mar 16, 2023, 12:46 PM

#

Theoretically everyone should use addressables buttt

sacred jasper Mar 16, 2023, 12:46 PM

#

mossy kraken Sorry I been a bit busy, it is spring break here in Norway this week 😄 Have the...

Not sure yet Im waiting for class

#

I did speedrun writing documentation yesterday

#

So if people wanna write tutorials

timber cedar Mar 16, 2023, 12:49 PM

#

mossy kraken Sorry I been a bit busy, it is spring break here in Norway this week 😄 Have the...

today in theory :/

mossy kraken Mar 16, 2023, 12:49 PM

#

Alright

timber cedar Mar 16, 2023, 12:50 PM

#

xd waiting

sacred jasper Mar 16, 2023, 12:50 PM

#

Itll be at least an hour I presume

timber cedar Mar 16, 2023, 12:50 PM

#

hope

#

#

they already have it up i think

#

just not public

late condor Mar 16, 2023, 12:54 PM

#

Patch suddenly experiences RUD

timber cedar Mar 16, 2023, 12:54 PM

#

RUD?

late condor Mar 16, 2023, 12:57 PM

#

Rapid, unplanned, disassembly

timber cedar Mar 16, 2023, 1:01 PM

#

xd

#

yeah

#

very likely

wicked wyvern Mar 16, 2023, 2:00 PM

#

Not sure if UITK is worth pursuing for now, at least I personally can't seem to make it work

#

but this might be worth taking a look at: https://github.com/sinai-dev/UniverseLib/wiki/User-Interface-(UI)

GitHub

User Interface (UI)

A library for making plugins which target IL2CPP and Mono Unity games. - sinai-dev/UniverseLib

#

It's what Unity Explorer and BIE Configuration Manager are built with

sacred jasper Mar 16, 2023, 2:01 PM

#

wicked wyvern Not sure if UITK is worth pursuing for now, at least I personally can't seem to ...

What are the issues you are having?

wicked wyvern Mar 16, 2023, 2:01 PM

#

it's using the Unity UI framework rather than UI Toolkit, but it allows you to build UIs using C# without Unity Editor, too

wicked wyvern Mar 16, 2023, 2:03 PM

#

sacred jasper What are the issues you are having?

well, I can get a game object with a UIDocument component into the scene hierarchy, types load fine, I patched in the needed shaders, but still can't figure out how to actually get anything rendered

#

tried both creating it fully from C# and injecting it into the scene, and loading a prefab with UI made in the Editor

#

neither shows up

sacred jasper Mar 16, 2023, 2:04 PM

#

Alright, if you can share what you have, I'll take a look later

wicked wyvern Mar 16, 2023, 2:04 PM

#

it's all here: #1085537097714245662 message

sacred jasper Mar 16, 2023, 5:09 PM

#

Alright, I am doing school work right now

#

can someone confirm that SW works on 0.1.1

mossy kraken Mar 16, 2023, 5:09 PM

#

Patch looks really good

#

I will test

#

Updating as we speak

sacred jasper Mar 16, 2023, 5:28 PM

#

Alright, imma grab lunch rq then work on pushing out v1.0.0

mossy kraken Mar 16, 2023, 5:30 PM

#

It booted

#

Have not tested with v1.0.0 yet

wicked wyvern Mar 16, 2023, 5:31 PM

#

all mods I've tested so far work, too

silk wigeon Mar 16, 2023, 5:35 PM

#

Some people talking in KSP general are saying that some mods work

#

Still, I'd update SW to make sure everything still works

mossy kraken Mar 16, 2023, 5:37 PM

#

I just built myself a v1.0.0 of Space Warp and it just booted up flawlessly!

#

This is really promising

silk wigeon Mar 16, 2023, 5:37 PM

#

Das good

mossy kraken Mar 16, 2023, 5:38 PM

#

Gonna check the performance of the game itself

#

If it feels any better

gilded kettle Mar 16, 2023, 5:40 PM

#

SpaceWorp 0.4.1 wen?

mossy kraken Mar 16, 2023, 5:40 PM

#

never

#

We are releasing v1.0.0 instead

wicked wyvern Mar 16, 2023, 5:40 PM

#

1.0.0 is coming today (most likely)

mossy kraken Mar 16, 2023, 5:40 PM

#

Out of beta, releasing on time

gilded kettle Mar 16, 2023, 5:41 PM

#

no i want 0.4.1 wtf

#

😭

mossy kraken Mar 16, 2023, 5:41 PM

#

rip 🪦🥲

#

PR is up
https://github.com/SpaceWarpDev/SpaceWarp/pull/177

GitHub

Space Warp - v1.0.0 Release by EwyBoy · Pull Request #177 · SpaceWa...

This is the v1.0.0 release of Space Warp for Kerbal Space Program 2 (KSP2). The pull request includes various improvements and features:

DLL autofinder functionality added by Rexicon226.
Ebic game...

gilded kettle Mar 16, 2023, 5:56 PM

#

Ebic gamers, is this right? or is it a typo? sauhsahusa

#

sounds funny eitherway

mossy kraken Mar 16, 2023, 5:57 PM

#

prob typo 😮

gilded kettle Mar 16, 2023, 5:57 PM

#

Extensions for vehicle controls and getting parts added by cheese3660. the one im most excited to play around ngl

sacred jasper Mar 16, 2023, 6:06 PM

#

@wicked wyvern should I still provide the standalone Space Warp, or just only provide BIE packaged in

wicked wyvern Mar 16, 2023, 6:07 PM

#

I mean, I don't see much use for a standalone download, and it seems to only confuse people

mossy kraken Mar 16, 2023, 6:08 PM

#

^

wicked wyvern Mar 16, 2023, 6:08 PM

#

does this version still need the bepinex config file?

sacred jasper Mar 16, 2023, 6:08 PM

#

Gotcha
Yes it still needs the change in the configuration.

wicked wyvern Mar 16, 2023, 6:09 PM

#

it would make sense to release the standalone for the very few people who already have BIE and want to keep their config

#

but if we overwrite it anyway, then there's no point

mossy kraken Mar 16, 2023, 6:11 PM

#

Its going to be fun to see how many days it will take until v1.0.0 shows up on the graph

68747470733a2f2f766f7274616e2e6465762f7370616365776172702d737461746973746963732f7069655f63686172742e706e673f.png

#

Released!
https://github.com/SpaceWarpDev/SpaceWarp/releases/tag/spacewarp-1.0.0

GitHub

Release 1.0.0 · SpaceWarpDev/SpaceWarp

V1.0.0
Changelog

Updated documentation site to reflect latest version
Added localization loading from addressables
Some UI changes
Added some more UI functions
Added automatic version checking, fo...

sacred jasper Mar 16, 2023, 6:21 PM

#

And updated on space dock, and curseforge

#

just the forum post needs to be updated

inland lichen Mar 16, 2023, 6:49 PM

#

does the sw1.0.0 download zip still include bepinex?

wicked wyvern Mar 16, 2023, 6:50 PM

#

yeah, it's the only version now

#

to reduce confusion

sacred jasper Mar 16, 2023, 7:43 PM

#

So CKAN does use swinfo files, independently of dependency on SpaceWarp

#

https://github.com/KSP-CKAN/CKAN/blob/master/Netkan/Transformers/SpaceWarpInfoTransformer.cs

GitHub

CKAN/SpaceWarpInfoTransformer.cs at master · KSP-CKAN/CKAN

The Comprehensive Kerbal Archive Network. Contribute to KSP-CKAN/CKAN development by creating an account on GitHub.

wicked wyvern Mar 16, 2023, 7:59 PM

#

Nice to see

timber cedar Mar 16, 2023, 8:26 PM

#

mossy kraken Its going to be fun to see how many days it will take until v1.0.0 shows up on t...

the other one has it

inland lichen Mar 16, 2023, 9:12 PM

#

Usability issue: SpaceWarp UI does not scale with game UI scale. Text is unreadably tiny when game is at 4k resolution.

sacred jasper Mar 16, 2023, 9:13 PM

#

inland lichen Usability issue: SpaceWarp UI does not scale with game UI scale. Text is unrea...

@mossy kraken you were doing the UI scaling stuff, maybe you can take a look at this

inland lichen Mar 16, 2023, 9:14 PM

#

for reference, this is on a completely clean install of the new game patch.

mossy kraken Mar 16, 2023, 9:18 PM

#

sacred jasper <@113812902724632580> you were doing the UI scaling stuff, maybe you can take a ...

It is on my todo list 😄
Gonna take a look once I get home from spring break on Sunday/ Monday

sacred jasper Mar 16, 2023, 9:30 PM

#

@wicked wyvern you should likely update the mod templat

wicked wyvern Mar 16, 2023, 9:30 PM

#

yeah that's a good idea

sacred jasper Mar 16, 2023, 9:31 PM

#

fuck I need to update the space warp nuget package

#

yet I suck at nuget packages

wicked wyvern Mar 16, 2023, 9:31 PM

#

anything important that I should update/add?

sacred jasper Mar 16, 2023, 9:31 PM

#

The version check field?

wicked wyvern Mar 16, 2023, 9:31 PM

#

that's about it, right?

#

maybe an example of vessel control

sacred jasper Mar 16, 2023, 9:32 PM

#

yee

#

I'll work on the UITK stuff tomorrow, I have a pathfinder game soon

#

@wicked wyvern as well, if you wouldn't mind creating an updated nuget package that I can publish?

wicked wyvern Mar 16, 2023, 9:51 PM

#

FYI, the SpaceWarp.csproj file still has version tag set to 0.4.0

sacred jasper Mar 16, 2023, 9:52 PM

#

F

#

That should be fixed

gilded kettle Mar 16, 2023, 9:56 PM

#

wicked wyvern FYI, the SpaceWarp.csproj file still has version tag set to 0.4.0

Ohhh so thats on VisualStudio decompiler it said 0.4.0, i thought i had the wrong dll 😭

wicked wyvern Mar 16, 2023, 9:56 PM

#

heh

gilded kettle Mar 16, 2023, 9:57 PM

#

Ctrl+click on any SpaceWarp class

wicked wyvern Mar 16, 2023, 10:19 PM

#

should version_check be required?

#

sacred jasper Mar 16, 2023, 10:19 PM

#

wicked wyvern

No

#

It shouldn't be?

wicked wyvern Mar 16, 2023, 10:20 PM

#

I'm just asking since I'm getting all these errors with old mods (which is pretty much all of them)

mossy kraken Mar 16, 2023, 10:22 PM

#

v1.0.0 just hit 200 downloads

sacred jasper Mar 16, 2023, 10:22 PM

#

wicked wyvern I'm just asking since I'm getting all these errors with old mods (which is prett...

Fuck I made a mistake

#

I'm dumb

#

required.allow null makes the thing required

wicked wyvern Mar 16, 2023, 10:23 PM

#

1.0.1 might not be a bad idea, with a couple of hotfixes like this + the project version

sacred jasper Mar 16, 2023, 10:24 PM

#

wicked wyvern 1.0.1 might not be a bad idea, with a couple of hotfixes like this + the project...

Fair
Am kinda busy atm

wicked wyvern Mar 16, 2023, 10:25 PM

#

I can take care of those two things quickly and PR

mossy kraken Mar 16, 2023, 10:27 PM

#

@timber cedar I made a few tiny updates to https://github.com/SpaceWarpDev/SpaceWarpDownloads/blob/main/downloads.py

It is now sorted by versions with major.minor.patch for both graphs and updated some color and font stuff
https://github.com/SpaceWarpDev/SpaceWarpDownloads/blob/main/downloads.py

Not sure if you have to manually update the script on your server thingy or if it pulls it from git on commit

GitHub

SpaceWarpDownloads/downloads.py at main · SpaceWarpDev/SpaceWarpDow...

A repository to keep track of all the Space Warp downloads from all the different platforms. - SpaceWarpDownloads/downloads.py at main · SpaceWarpDev/SpaceWarpDownloads

#

Are we going for a v1.0.1 patch?

sacred jasper Mar 16, 2023, 10:31 PM

#

mossy kraken Are we going for a v1.0.1 patch?

yes cuz I made some dumb mistakes

#

but I'm unable to release it today ree

mossy kraken Mar 16, 2023, 10:31 PM

#

Game breaking?

sacred jasper Mar 16, 2023, 10:31 PM

#

not really?

mossy kraken Mar 16, 2023, 10:31 PM

#

Nice

wicked wyvern Mar 16, 2023, 10:32 PM

#

nah, just some unneeded errors and one that prevents a NuGet package from being uploaded

#

also for some reason modders seem to use "dependencies": ["SpaceWarp"] when that's not supported

#

just a thing I noticed

timber cedar Mar 16, 2023, 10:37 PM

#

mossy kraken <@533428547705110549> I made a few tiny updates to https://github.com/SpaceWarpD...

gotcha

#

thx

#

ill update it now

#

cool thing about the system i made is that i can just drop and replace the file :D

#

ok

#

i think i updated it

mossy kraken Mar 16, 2023, 10:40 PM

#

Cool! Just gotta wait for it to have it scheduled run again in a min or two

timber cedar Mar 16, 2023, 10:40 PM

#

it updated

#

dw

mossy kraken Mar 16, 2023, 10:40 PM

#

yeah

timber cedar Mar 16, 2023, 10:40 PM

#

mossy kraken Mar 16, 2023, 10:40 PM

#

just saw it

timber cedar Mar 16, 2023, 10:40 PM

#

:D

mossy kraken Mar 16, 2023, 10:40 PM

#

68747470733a2f2f766f7274616e2e6465762f7370616365776172702d737461746973746963732f6261725f63686172742e706e673f.png

timber cedar Mar 16, 2023, 10:40 PM

#

i did the change just in time

mossy kraken Mar 16, 2023, 10:40 PM

#

timber cedar Mar 16, 2023, 10:41 PM

#

yep

#

should put the actual number of downloads above each bar

#

on the top image

mossy kraken Mar 16, 2023, 10:42 PM

#

Font has to be tiny then, I tested it and did not like it

timber cedar Mar 16, 2023, 10:42 PM

#

hm

#

ill try

#

good point though

sacred jasper Mar 16, 2023, 10:43 PM

#

I'll accept the pr then update it tomorrow

wicked wyvern Mar 16, 2023, 10:44 PM

#

am dumb

#

forgot swinfo.json lol

timber cedar Mar 16, 2023, 10:44 PM

#

xd

wicked wyvern Mar 16, 2023, 10:44 PM

#

the exact opposite problem of the original

wicked wyvern Mar 16, 2023, 11:28 PM

#

actually now that I'm writing the example code for SpaceWarp.Template, I still think it might have been a better idea to instead of

public static VesselVehicle ActiveVesselVehicle => GameManager.Instance.Game.ViewController._activeVesselVehicle;
public static VesselComponent ActiveSimVessel => GameManager.Instance.Game.ViewController.GetActiveSimVessel();

do something like

public static VesselVehicle ActiveVesselVehicle => GameManager.Instance.Game?.ViewController?._activeVesselVehicle;
public static VesselComponent ActiveSimVessel => GameManager.Instance.Game?.ViewController?.GetActiveSimVessel();

so that accessing these properties at the wrong time gives you a null instead of an exception

#

but that might just be me

little bay Mar 17, 2023, 1:24 AM

#

sacred jasper ```cs public static IEnumerable<PartCore> WithModule<T>(this PartProvider p...

.Any() aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa

#

to be clear, I don't actually hate extension methods

#

the idea is just to get you to seriously consider how much each extension actually helps

#

so you don't go overboard

little bay Mar 17, 2023, 1:32 AM

#

little bay .Any() <a:aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa:968122539077402685>

but yeah, .OfType<T>().Any() or .Any(m => m is T), either works

sacred jasper Mar 17, 2023, 1:37 AM

#

little bay .Any() <a:aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa:968122539077402685>

Visual studio didn't suggest this to me when I was trying to look for it nooooooooo

#

Why I normally use rider

rocky pollen Mar 17, 2023, 7:55 AM

#

Hey, is there a working version of Unity Explorer for SpaceWarp 1.0.0?

wise swift Mar 17, 2023, 9:40 AM

#

yes the normal unity explorer https://github.com/sinai-dev/UnityExplorer/releases/latest/download/UnityExplorer.BepInEx5.Mono.zip

rocky pollen Mar 17, 2023, 10:33 AM

#

wise swift yes the normal unity explorer https://github.com/sinai-dev/UnityExplorer/release...

Thanks

sacred jasper Mar 17, 2023, 4:44 PM

#

Oh I can push out the 1.0.1 patch

#

After lunch

wicked wyvern Mar 17, 2023, 4:50 PM

#

(pls merge the latest PR first, it has the updated swinfo.json version which i stupidly forgot in the first one)

wise swift Mar 17, 2023, 5:15 PM

#

could we get a dark mode for the docs

sacred jasper Mar 17, 2023, 6:23 PM

#

wise swift could we get a dark mode for the docs

@timber cedar

#

@wicked wyvern sw patch has been pushed out, next should I work on MM-esque stuff or UI

wicked wyvern Mar 17, 2023, 6:30 PM

#

it's totally up to you, but I'd personally like to get the UI working first

sacred jasper Mar 17, 2023, 6:30 PM

#

I'm still waiting on UITK to work
Good thing is they are 2 separate things so I can just make branches for each

wicked wyvern Mar 17, 2023, 6:31 PM

#

sacred jasper I'm still waiting on UITK to work Good thing is they are 2 separate things so I ...

that makes two of us munley

#

it doesn't seem to want to

#

but I'm not sure whether it's a KSP-related bug or just me doing something wrong/missing something and not realizing

sacred jasper Mar 17, 2023, 6:36 PM

#

Hmm, I want to see if theres a way to get a module type by string

#

Gods the amount of reflection this MM thing will have to do will be insane, but fun

#

Okay this looks like pain if I wanna stick to a text format

timber cedar Mar 17, 2023, 6:48 PM

#

sacred jasper <@533428547705110549>

got it in a bit

late condor Mar 17, 2023, 6:48 PM

#

If you're doing reflection for access purposes you might try using linq expressions instead, they have less overhead

#

As long as you cache it

#

If you're using reflection for discovery, they don't help with that afaik, but you could still stich together the end result with linq expressions

sacred jasper Mar 17, 2023, 6:57 PM

#

Okay, I have no clue how the entire module system works atm

wicked wyvern Mar 17, 2023, 6:58 PM

#

it's definitely a huge project, from figuring out how the in-game system works, to defining a full-featured schema for the patch format (in JSON i presume), to implementing it

sacred jasper Mar 17, 2023, 6:59 PM

#

It seems there are ModuleData and PartBehaviourModules, PartCore, and IInteractivePart, and looking into it I'm trying to find the difference

wicked wyvern Mar 17, 2023, 6:59 PM

#

we've been trying to do that as well

#

#🔴mod-dev message

sacred jasper Mar 17, 2023, 7:01 PM

#

Yeah it seems to be a mess

wicked wyvern Mar 17, 2023, 7:02 PM

#

the engine modules are particularly messy

#

like 0 apparent separation of concerns

#

I'm looking into UniverseLib but I can't say I love what I'm seeing

#

UITK would definitely be preferred if it can be actually made to work

timber cedar Mar 17, 2023, 7:27 PM

#

@sacred jasper done

wicked wyvern Mar 18, 2023, 12:44 AM

#

could you upload a 1.0.1 nuget package please?

wicked wyvern Mar 18, 2023, 2:06 PM

#

here's a package built from the main branch if that helps

📎 SpaceWarp.1.0.1.nupkg

#

not sure if any other configuration is needed, I literally just ran "Pack Selected Project" in Rider

sacred jasper Mar 18, 2023, 2:15 PM

#

wicked wyvern not sure if any other configuration is needed, I literally just ran "Pack Select...

Wait thats a thing you can do

wicked wyvern Mar 18, 2023, 2:15 PM

#

Yeah, since it seems to be configured in the .csproj

#

Although, actually looking into the project file, it might need more configuration there to correctly set all the nuget stuff

#

How did you package it?

sacred jasper Mar 18, 2023, 2:18 PM

#

Manually

wicked wyvern Mar 18, 2023, 2:19 PM

#

https://github.com/jan-bures/SpaceWarp.Template/blob/master/SpaceWarp.Template/SpaceWarp.Template.csproj

GitHub

SpaceWarp.Template/SpaceWarp.Template.csproj at master · jan-bures/...

C# project template for SpaceWarp. Contribute to jan-bures/SpaceWarp.Template development by creating an account on GitHub.

#

This is how I set the properties for nuget

#

And <GeneratePackageOnBuild> makes it so i don't even have to package it in a separate step, just need to build

sacred jasper Mar 18, 2023, 2:23 PM

#

I uploaded the package you sent me so it should be about an hour

wicked wyvern Mar 18, 2023, 2:26 PM

#

Alright, thanks

wicked wyvern Mar 18, 2023, 5:04 PM

#

https://forum.kerbalspaceprogram.com/index.php?/topic/215442-enabledisable-mods-from-ksp2-main-menu-mod-list-manager/

Kerbal Space Program Forums

Enable/Disable Mods from KSP2 Main Menu Mod List Manager?

Will the ability to Enable/Disable Installed Mods from the ModList Manager at the Main Menu Screen, be added to SpaceWarp/BepInEx? It would be helpful to have for Debugging issues in game. To help determine if it is an issue with the Mod or the Base Game. Instead of having to delete/move the plug...

#

Was I just hallucinating or was that already a feature before 1.0?

#

Was that removed because of the switch to BIE?

timber cedar Mar 18, 2023, 6:29 PM

#

It was, I implemented it

little bay Mar 19, 2023, 6:06 AM

#

wicked wyvern Was that removed because of the switch to BIE?

yes, because BIE doesn't have that capability

#

its possible to force SpaceWarp plugins to have that functionality

#

but i guess that wasn't done?

sacred jasper Mar 19, 2023, 12:39 PM

#

Itd be an interesting thing to implement

#

We'd have to force BIE not to load the dll, so renaming it

#

But im not sure we can rename the dll while the game is running

wicked wyvern Mar 19, 2023, 1:47 PM

#

https://learn.microsoft.com/en-us/dotnet/api/system.runtime.loader.assemblyloadcontext https://learn.microsoft.com/en-us/dotnet/api/system.appdomain are either of those possible to be used to that effect? (even if it might require a custom BepInEx fork)

AssemblyLoadContext Class (System.Runtime.Loader)

Represents the runtime's concept of a scope for assembly loading.

AppDomain Class (System)

Represents an application domain, which is an isolated environment where applications execute. This class cannot be inherited.

#

Seems like they both support creating a context/domain for loading and unloading assemblies

#

it's the closest thing to unloading an assembly at runtime that I could find

gilded kettle Mar 19, 2023, 5:14 PM

#

Hey cool people

#

can you check the Colors documentation pls?

#

already found an incosistency, textureMapType should be marked as code

wicked wyvern Mar 19, 2023, 5:16 PM

#

do you have a repo somewhere with it where I could submit a PR with some minor edits or anything like that?

#

(e.g. your fork of the official SpaceWarpDocs)

gilded kettle Mar 19, 2023, 5:18 PM

#

yup

#

https://github.com/LuxStice/SpaceWarpDocs/blob/main/source-en/pages/CustomParts.rst

GitHub

SpaceWarpDocs/CustomParts.rst at main · LuxStice/SpaceWarpDocs

Docs for SpaceWarp. Contribute to LuxStice/SpaceWarpDocs development by creating an account on GitHub.

#

i'll also add the How to create custom modules and the whole json thing in this fork

#

wtf, just realized that the code examples for DelcareParts dont show

#

updated

wicked wyvern Mar 19, 2023, 5:29 PM

#

I'm a bit confused by the setup of branches in the SpaceWarpDev/SpaceWarpDocs repo

#

why is the en branch 8 commits ahead and 36 commits behind main?

#

As far as I understand it, the actual live docs are taken from the language branches and not main

#

So what are commits to main for?

wicked wyvern Mar 19, 2023, 5:31 PM

#

gilded kettle https://github.com/LuxStice/SpaceWarpDocs/blob/main/source-en/pages/CustomParts....

I noticed this because you were adding stuff to main but the text in the rest of the file didn't match with what's in the live docs

#

For example, this is in main (and by extension in your fork)

#

While this is in the live docs

gilded kettle Mar 19, 2023, 5:33 PM

#

yeah wtf

#

hmm maybe it uses en, ru, etc etc for live docs depending on the selected language

wicked wyvern Mar 19, 2023, 5:34 PM

#

it does

gilded kettle Mar 19, 2023, 5:34 PM

#

instead of using main for all

wicked wyvern Mar 19, 2023, 5:34 PM

#

but I don't understand the purpose of the main branch then

gilded kettle Mar 19, 2023, 5:34 PM

#

which isnt optimal? ig?

#

it should be all in main no?

wicked wyvern Mar 19, 2023, 5:34 PM

#

gilded kettle which isnt optimal? ig?

it might just be how readthedocs.io requires it to be set up

gilded kettle Mar 19, 2023, 5:35 PM

#

yeah maybe, well its just a matter of copy paste into en

wicked wyvern Mar 19, 2023, 5:35 PM

#

Ok, turns out all the newest commits to main were just updates of README

gilded kettle Mar 19, 2023, 5:35 PM

#

lmao

wicked wyvern Mar 19, 2023, 5:36 PM

#

The last commit that was actually editing any of the documentation happened two weeks ago, and then the language branches were created

gilded kettle Mar 19, 2023, 5:37 PM

#

maybe i should do the same as addresablles loading and lead into a new file?

wicked wyvern Mar 19, 2023, 5:38 PM

#

whichever way you do it, just do it in the en branch

#

😆

gilded kettle Mar 19, 2023, 5:38 PM

#

lmao, will do! i'll commit now then

#

https://github.com/LuxStice/SpaceWarpDocs/blob/en/pages/CustomParts.rst

GitHub

SpaceWarpDocs/CustomParts.rst at en · LuxStice/SpaceWarpDocs

Docs for SpaceWarp. Contribute to LuxStice/SpaceWarpDocs development by creating an account on GitHub.

#

feel free to do your changes

wicked wyvern Mar 19, 2023, 5:40 PM

#

By the way is there even need for the source-en and source-ru folders in main? It just makes it more confusing and doesn't seem to be used anyway, and if that's the case, it would be better to just delete them in the next commit

#

(that's not directed to you as much as it is the docs contributors)

timber cedar Mar 19, 2023, 5:56 PM

#

wicked wyvern (that's not directed to you as much as it is the docs contributors)

nah i’m going to delete them

wicked wyvern Mar 19, 2023, 5:56 PM

#

thanks

timber cedar Mar 19, 2023, 5:56 PM

#

just have the readme and listened

#

liscense

#

they were there before i realized how read the docs really works

gilded kettle Mar 19, 2023, 5:57 PM

#

wait so you, to update the docs, will accept all prs when the new version releases?

timber cedar Mar 19, 2023, 5:58 PM

#

... not all prs

#

all good ones :D

gilded kettle Mar 19, 2023, 5:58 PM

#

yeah lmao

#

hmm, ok, as soon as munix does his pass on the docs i'll pr

timber cedar Mar 19, 2023, 5:58 PM

#

i need to clean up the docs repo a bit

#

ok a deleted some stuff :D

#

now im going to remove the 0.4 docs

gilded kettle Mar 19, 2023, 6:47 PM

#

@timber cedar https://github.com/SpaceWarpDev/SpaceWarpDocs/pull/5

GitHub

Colors feature documentation by LuxStice · Pull Request #5 · SpaceW...

hey :D

timber cedar Mar 19, 2023, 6:48 PM

#

:D

#

merged

#

nice work

gilded kettle Mar 19, 2023, 6:51 PM

#

THE FEATURE ISNT IN YET nooooooooo

#

but thx <3

timber cedar Mar 19, 2023, 7:16 PM

#

xd then what

#

was the r

#

docs

#

xdddd

#

eh it’s fineeee

#

guys if u want to

#

make docs for new version

#

please checkout the branch with en-<version>

gilded kettle Mar 19, 2023, 7:18 PM

#

the doc is for something that was already merged on the 1.1.0 version

timber cedar Mar 19, 2023, 7:18 PM

#

which is a not released

#

xd it’s fine just later

gilded kettle Mar 19, 2023, 7:18 PM

#

yes exactly, yeah

#

no cuz i was expecting you to leave it as a pr till the version released lmao

timber cedar Mar 19, 2023, 7:19 PM

#

xdd

#

ist good

#

just make the pr immediately to new branch

#

illl update readme to say that

little bay Mar 20, 2023, 7:52 AM

#

wicked wyvern https://learn.microsoft.com/en-us/dotnet/api/system.runtime.loader.assemblyloadc...

ALCs don't exist in Mono, and Unity doesn't support AppDomains

#

my idea would be to let the plugin load through bep, but then just not do the spacewarp stuff

#

so instead of disabled mods not being loaded, they're loaded, but disabled

wicked wyvern Mar 20, 2023, 10:38 AM

#

They wouldn't be disabled, their lifecycle methods will still run

#

Not loading them in SpaceWarp will only cause On(Pre/Post)Initialized to not be run, right?

sacred jasper Mar 20, 2023, 11:40 AM

#

Yeahh

#

It might cause error spam

sacred jasper Mar 20, 2023, 6:26 PM

#

Should we push out a 1.1.0 with just the colors patch

#

Or is there any other in progress feature close to being finished

gilded kettle Mar 20, 2023, 6:27 PM

#

i can pack my mods with my version of colors patch until 1.1.0

wicked wyvern Mar 20, 2023, 6:27 PM

#

it doesn't seem like a big enough thing for a minor version update but idk

gilded kettle Mar 20, 2023, 6:28 PM

#

wicked wyvern it doesn't seem like a big enough thing for a minor version update but idk

its a whole new feature, i see it as x.y.z
x total rewrite or something major
y new features
z fixes to features added

#

but usually y has more than 1 feature added

wicked wyvern Mar 20, 2023, 6:29 PM

#

yeah that's what I mean

#

it seems like a very small update considering the scope of the previous updates

sacred jasper Mar 20, 2023, 6:29 PM

#

I'm just wondering moreso what stuff is being worked on

#

And what I should be working on

gilded kettle Mar 20, 2023, 6:30 PM

#

work on fixing ksp bugs 🙏

#

we need a pepe pray in here

#

or a variant of pray

wicked wyvern Mar 20, 2023, 6:30 PM

#

I think the priority should be bug fixes

sacred jasper Mar 20, 2023, 6:30 PM

#

Thats #1081724578822377522

gilded kettle Mar 20, 2023, 6:30 PM

#

doge pray ie

wicked wyvern Mar 20, 2023, 6:30 PM

#

which would be the version checking bug for now

#

0.2 isn't recognized as > 0.1.1

gilded kettle Mar 20, 2023, 6:31 PM

#

oh also, big names bugs the alt-m

sacred jasper Mar 20, 2023, 6:31 PM

#

I do need to see why

#

On both of those

#

Just don't use big names munley

gilded kettle Mar 20, 2023, 6:31 PM

#

my mod has a bigname you can test with it

#

tbh i can just put SORRY as a name

wicked wyvern Mar 20, 2023, 6:31 PM

#

sacred jasper Just don't use big names <:munley:1079151401801879582>

apply the KISS principle to your names munley

gilded kettle Mar 20, 2023, 6:32 PM

#

you can just check the size of the name string, and if over x put [...] in the end

sacred jasper Mar 20, 2023, 6:32 PM

#

Inb4 someone pulls out an arabic name

gilded kettle Mar 20, 2023, 6:32 PM

#

theres no arabic support yet?

#

shame on you

sacred jasper Mar 20, 2023, 6:32 PM

#

Depends on unity's IMGui support for arabic

gilded kettle Mar 20, 2023, 6:33 PM

#

i can think of a quick fix for the version checker, why not just make versions as a struct of int
Major
Minor
(forgot the other one)

#

then just check per int

sacred jasper Mar 20, 2023, 6:33 PM

#

Cuz that'd break every single mod in existence

gilded kettle Mar 20, 2023, 6:34 PM

#

"Modders, update your .swinfo" :D

#

let me take a look into the version checker

sacred jasper Mar 20, 2023, 6:34 PM

#

I might just be doing something dumb to be honest

#

The versionsutility class is not the correct version checker btw

wicked wyvern Mar 20, 2023, 6:34 PM

#

sacred jasper Cuz that'd break every single mod in existence

I mean you can just parse the version string into like 2-5 integers

#

and compare them consecutively

sacred jasper Mar 20, 2023, 6:34 PM

#

wicked wyvern I mean you can just parse the version string into like 2-5 integers

(That is basically how its done)

#

So I might of just flipped a comparison

timber cedar Mar 20, 2023, 6:35 PM

#

just add a "first time" part to the reader

#

itll auto-update the mods if they dont exist

#

idk

sacred jasper Mar 20, 2023, 6:35 PM

#

That sounds like pain

timber cedar Mar 20, 2023, 6:37 PM

#

wicked wyvern 0.2 isn't recognized as > 0.1.1

... are you trying to just compare them

late condor Mar 20, 2023, 6:37 PM

#

Why not just use the .net Version class

sacred jasper Mar 20, 2023, 6:37 PM

#

Wai- wha

wicked wyvern Mar 20, 2023, 6:37 PM

#

timber cedar ... are you trying to just compare them

I'm not doing anything with them

sacred jasper Mar 20, 2023, 6:37 PM

#

Cuz we have the "*" in the versions for some reason

#

Though I can just replace ".*" with ""

timber cedar Mar 20, 2023, 6:39 PM

#

if you have * you should replace with "any" so its a little more readable

#

also you should force version

late condor Mar 20, 2023, 6:39 PM

#

is any value right?

sacred jasper Mar 20, 2023, 6:39 PM

#

eys

timber cedar Mar 20, 2023, 6:39 PM

#

because obv

late condor Mar 20, 2023, 6:39 PM

#

So just exclude that value from both sides

timber cedar Mar 20, 2023, 6:39 PM

#

hm

#

just make a custom reader function for comparing and reading

#

0.2.* = 0.2.3

late condor Mar 20, 2023, 6:40 PM

#

Mod says "1.1.*"
SpaceDock says "1.2.4"
FileVersionInfo.Parse("1.1.0") > FileVersionInfo.Parse("1.2.0")

#

You'd have to cascade down'

#

so

timber cedar Mar 20, 2023, 6:40 PM

#

yeah

late condor Mar 20, 2023, 6:40 PM

#

1.*.5 would technically be invalid

#

but you just ignore that

timber cedar Mar 20, 2023, 6:41 PM

#

late condor 1.*.5 would technically be invalid

no

#

bad

#

💀

sacred jasper Mar 20, 2023, 6:41 PM

#

If someone does that, they deserve their ankles broken

late condor Mar 20, 2023, 6:41 PM

#

FileVersionInfo.Parse("1.0.0") > FileVersionInfo.Parse("2.1.2")

wicked wyvern Mar 20, 2023, 6:41 PM

#

I only accept mod version *.*.5

#

klueless

late condor Mar 20, 2023, 6:41 PM

#

lol

timber cedar Mar 20, 2023, 6:41 PM

#

nooooooooo

late condor Mar 20, 2023, 6:42 PM

#

my point is that you basically just 0 out any value starting from * to the last version element

timber cedar Mar 20, 2023, 6:42 PM

#

yeah

late condor Mar 20, 2023, 6:42 PM

#

and then your check is still valid

#

and let .NET do the rest for you

#

you can use > < >= <= == with FileVersionInfo

#

so FileVersionInfo.Parse(versionString.Replace("*", "0"))

timber cedar Mar 20, 2023, 6:43 PM

#

internal static void CheckKspVersions()
    { 
        var kspVersion = typeof(VersionID).GetField("VERSION_TEXT",BindingFlags.Static | BindingFlags.Public)?.GetValue(null) as string;
        foreach (var plugin in SpaceWarpPlugins)
        {
            ModsUnsupported[plugin.SpaceWarpMetadata.ModID] =
                !plugin.SpaceWarpMetadata.SupportedKsp2Versions.IsSupported(kspVersion);
        }

        foreach (var info in NonSpaceWarpInfos)
        {
            ModsUnsupported[info.ModID] = !info.SupportedKsp2Versions.IsSupported(kspVersion);
        }
    }

#

is this the current one?

wicked wyvern Mar 20, 2023, 6:43 PM

#

well that's just for KSP

timber cedar Mar 20, 2023, 6:43 PM

#

💀

#

one sec

late condor Mar 20, 2023, 6:44 PM

#

And if people make invalid versions, thats on them

wicked wyvern Mar 20, 2023, 6:44 PM

#

you also need checking for dependency version and for the mod updates

gilded kettle Mar 20, 2023, 6:44 PM

#

wait its the ksp version and not the mods version?

lime plaza Mar 20, 2023, 6:44 PM

#

late condor so `FileVersionInfo.Parse(versionString.Replace("*", "0"))`

Would this not make 1.1.* reject 1.1.1?

gilded kettle Mar 20, 2023, 6:44 PM

#

        {
            string[] strings = versionString.Split('.');
            int[] ints = new int[3];

            for (int i = 0; i < 3; i++)
            {
                string s = strings[i];

                if (s != "*")
                {
                    if(int.TryParse(s, out int version))
                    {
                        ints[i] = version;
                    }
                    else
                    {
                        ints[i] = int.MinValue;
                    }
                }
                else
                {
                    ints[i] = int.MaxValue;
                }
            }

this should parse no?

late condor Mar 20, 2023, 6:44 PM

#

lime plaza Would this not make 1.1.* reject 1.1.1?

You'd zero it out on both sides

#

So you have to do a little legwork i guess

gilded kettle Mar 20, 2023, 6:44 PM

#

then i have a Compare on the Version class

wicked wyvern Mar 20, 2023, 6:45 PM

#

this is getting wild considering we're only talking version checking 😆

late condor Mar 20, 2023, 6:45 PM

#

You need to identify the position that * shows up in, and update the version string on. Kth sides

#

Eh, a custom type is probably better for this

timber cedar Mar 20, 2023, 6:45 PM

#

    IEnumerator CheckVersion(ModInfo pluginInfo)
    {
        var www = UnityWebRequest.Get(pluginInfo.VersionCheck);
        yield return www.SendWebRequest();

        if (www.result != UnityWebRequest.Result.Success)
        {
            Logger.LogInfo($"Unable to check version for {pluginInfo.ModID} due to error {www.error}");
        }
        else
        {
            
            var results = www.downloadHandler.text;
            var checkInfo = JsonConvert.DeserializeObject<ModInfo>(results);
            SpaceWarpManager.ModsOutdated[pluginInfo.ModID] = OlderThan(pluginInfo.Version, checkInfo.Version);
        }
    }
```what is this 💀  why do we have network checking

late condor Mar 20, 2023, 6:45 PM

#

wicked wyvern this is getting wild considering we're only talking version checking 😆

Tbh, its one of those topics that are deceiving

sacred jasper Mar 20, 2023, 6:45 PM

#

timber cedar ```cs IEnumerator CheckVersion(ModInfo pluginInfo) { var www = U...

For online version checking

#

Why would we not?

late condor Mar 20, 2023, 6:45 PM

#

We aren't even considering the wider implications of these things

timber cedar Mar 20, 2023, 6:46 PM

#

is it breaking if you're offline

sacred jasper Mar 20, 2023, 6:46 PM

#

No

timber cedar Mar 20, 2023, 6:46 PM

#

good

late condor Mar 20, 2023, 6:46 PM

#

Is that code not run if there is no network?

#

Because that code will error if there is no network

sacred jasper Mar 20, 2023, 6:46 PM

#

It just fails

timber cedar Mar 20, 2023, 6:46 PM

#

hm

sacred jasper Mar 20, 2023, 6:47 PM

#

UnityWebRequest returns a failure if there isn't network right?

late condor Mar 20, 2023, 6:47 PM

#

Hmm, I have error handling anywhere i use it, but now I'm not sure I'm recalling why correctly

timber cedar Mar 20, 2023, 6:47 PM

#

yeah, but the problem is that it gives errors

#

i dont like that it gives errors if you're offline

#

should just stay silent

late condor Mar 20, 2023, 6:48 PM

#

Thats a messy one

#

Sometimes you might want the errors

lime plaza Mar 20, 2023, 6:48 PM

#

sacred jasper For online version checking

Will it tell you to update to an incompatible version? What if I need not the latest either because out of date game or dependencies

sacred jasper Mar 20, 2023, 6:48 PM

#

timber cedar i dont like that it gives errors if you're offline

It just logs

timber cedar Mar 20, 2023, 6:48 PM

#

yeahhhh but ehhhh
i can just block the specific no connection errors

late condor Mar 20, 2023, 6:49 PM

#

timber cedar yeahhhh but ehhhh i can just block the specific no connection errors

The problem is, no connection and "your internet choked" are not identifiably different

#

Networking is pain

timber cedar Mar 20, 2023, 6:49 PM

#

^ but why would you need either

#

internet down isnt spacewarps problem

sacred jasper Mar 20, 2023, 6:50 PM

#

lime plaza Will it tell you to update to an incompatible version? What if I need not the la...

For the moment yes
But like it doesn't really yell at you per se, just marks it yellow in the mod list
I could add a check on KSP version of the latest version of it but

gilded kettle Mar 20, 2023, 6:50 PM

#

what are the current problems of the version checking?

wicked wyvern Mar 20, 2023, 6:51 PM

#

lime plaza Will it tell you to update to an incompatible version? What if I need not the la...

oh wow

#

now we're getting recursive

#

haven't even thought about that

gilded kettle Mar 20, 2023, 6:51 PM

#

PLEACE DONT

lime plaza Mar 20, 2023, 6:51 PM

#

sacred jasper For the moment yes But like it doesn't really yell at you per se, just marks it ...

That still doesn’t allow for someone running Foo 1.0.0, which releases a breaking change, version 2.0.0, but I want Bar 1.0.0, which depends on Foo 1.0.0

wicked wyvern Mar 20, 2023, 6:52 PM

#

check KSP version supported by mod -> check mod update -> check mod update's KSP version -> check mod update's dependencies updates -> check mod update's dependencies' KSP version -> ... munley

#

we could go on forever

late condor Mar 20, 2023, 6:53 PM

#

timber cedar internet down isnt spacewarps problem

No, but it might be the users problem

#

Perhaps they are blocking the connection accidentally

#

Or they have some other local issue preventing them from getting what they want rhat they need to resolve

gilded kettle Mar 20, 2023, 6:53 PM

#

wtf why are u thinking about the user experience?

#

ur not a real programmer

timber cedar Mar 20, 2023, 6:53 PM

#

gilded kettle wtf why are u thinking about the user experience?

fr

sacred jasper Mar 20, 2023, 6:53 PM

#

lime plaza That still doesn’t allow for someone running Foo 1.0.0, which releases a breakin...

That'd be a pain of a thing to implement, technically possible but

late condor Mar 20, 2023, 6:53 PM

#

Lol, only good programmers think about user experience :p

timber cedar Mar 20, 2023, 6:54 PM

#

late condor Perhaps they are blocking the connection accidentally

guess thats true, because we only call this function once

#

it wouldnt be spam every time it fails

late condor Mar 20, 2023, 6:54 PM

#

I might not be real, but neither is PI, and just think about how useful PI is 😉

timber cedar Mar 20, 2023, 6:54 PM

#

you dont use PI in programming

#

you use an approximation

lime plaza Mar 20, 2023, 6:54 PM

#

wicked wyvern check KSP version supported by mod -> check mod update -> check mod update's KSP...

Or make it handled server side, pass KSP version, and versions of dependencies (or full mod list)

timber cedar Mar 20, 2023, 6:54 PM

#

a real number

late condor Mar 20, 2023, 6:54 PM

#

Shhhh

lime plaza Mar 20, 2023, 6:55 PM

#

late condor I might not be real, but neither is PI, and just think about how useful PI is 😉

3 is useful

late condor Mar 20, 2023, 6:55 PM

#

timber cedar a real number

You might say it's not real PI

#

😄

timber cedar Mar 20, 2023, 6:55 PM

#

:O

late condor Mar 20, 2023, 6:55 PM

#

You have engaged in battle with dad

timber cedar Mar 20, 2023, 6:55 PM

#

no kidding ^

sacred jasper Mar 20, 2023, 6:56 PM

#

lime plaza Or make it handled server side, pass KSP version, and versions of dependencies (...

That'd require a server that can scale to the amount of user's KSP 2 has, and that would be a b*tch to maintain.

It'd be better to try it client side

wicked wyvern Mar 20, 2023, 6:56 PM

#

that PI discussion reminds me of this: https://en.wikipedia.org/wiki/Indiana_Pi_Bill

timber cedar Mar 20, 2023, 6:56 PM

#

sacred jasper That'd require a server that can scale to the amount of user's KSP 2 has, and th...

its like a 200 byte request for like 5k people

#

thats completely managable

wicked wyvern Mar 20, 2023, 6:57 PM

#

I don't think it's necessary anyway

#

all you need is to download the mod's online swinfo.json, check the version in it and at most check the KSP version in it

#

easy

lime plaza Mar 20, 2023, 6:57 PM

#

sacred jasper That'd require a server that can scale to the amount of user's KSP 2 has, and th...

I’m saying make them mod dev handle those checks

timber cedar Mar 20, 2023, 6:57 PM

#

wicked wyvern all you need is to download the mod's online swinfo.json, check the version in i...

also online swinfo.json is dangerous because it might be changed, while the currently installed mod inst

late condor Mar 20, 2023, 6:58 PM

#

Why even solve this independently

wicked wyvern Mar 20, 2023, 6:58 PM

#

timber cedar also online swinfo.json is dangerous because it might be changed, while the curr...

that's what it's for

late condor Mar 20, 2023, 6:58 PM

#

Ckan handles all of this

#

If you want to auto update mods why not use ckan to do it

sacred jasper Mar 20, 2023, 6:58 PM

#

It doesn't auto update :/

#

It just checks a version

late condor Mar 20, 2023, 6:58 PM

#

Its a library

#

It does what you tell it to do

timber cedar Mar 20, 2023, 6:58 PM

#

ckan doesnt solve the version :D

wicked wyvern Mar 20, 2023, 6:58 PM

#

timber cedar also online swinfo.json is dangerous because it might be changed, while the curr...

you provide the swinfo.json in (for example) the main branch of your mod so that SpaceWarp can check whether the version has been changed

sacred jasper Mar 20, 2023, 6:59 PM

#

KSPAvc exists for a reason, and is used by lots of KSP players, and does basically the same thing as this feature

wicked wyvern Mar 20, 2023, 6:59 PM

#

and so it can tell you whether you should update

late condor Mar 20, 2023, 6:59 PM

#

Can ckan tell you that there is a newer version of a mod?

timber cedar Mar 20, 2023, 6:59 PM

#

wicked wyvern you provide the swinfo.json in (for example) the main branch of your mod so that...

for update requests, not for currently compatible versions

sacred jasper Mar 20, 2023, 6:59 PM

#

Update requests??

timber cedar Mar 20, 2023, 6:59 PM

#

difference between having an update, and an incompatible version of the mod installed

timber cedar Mar 20, 2023, 6:59 PM

#

sacred jasper Update requests??

update notifications idk

sacred jasper Mar 20, 2023, 7:01 PM

#

So we shouldn't check if mods have updated versions? Yet our users do want that to be a thing?

#

I am confused

wicked wyvern Mar 20, 2023, 7:01 PM

#

timber cedar difference between having an update, and an incompatible version of the mod inst...

SpaceWarp does both

#

if your mod is incompatible, it's in red

#

if there's an update, it's in yellow

#

it's basically two separate features

timber cedar Mar 20, 2023, 7:02 PM

#

wicked wyvern if there's an update, it's in yellow

if the update is compatible with your current version ^

timber cedar Mar 20, 2023, 7:02 PM

#

wicked wyvern it's basically two separate features

yeah i completely agree

wicked wyvern Mar 20, 2023, 7:02 PM

#

timber cedar if the update is compatible with your current version ^

what?

#

no

#

it does nothing like that

sacred jasper Mar 20, 2023, 7:02 PM

#

Sinon's saying it should

timber cedar Mar 20, 2023, 7:02 PM

#

im saying that it should

wicked wyvern Mar 20, 2023, 7:02 PM

#

oh

#

well yeah, that's also what I was saying

timber cedar Mar 20, 2023, 7:02 PM

#

xD

sacred jasper Mar 20, 2023, 7:03 PM

#

It's something that shan't be too hard

#

I do need to add a log if the online swinfo is an incorrect format

timber cedar Mar 20, 2023, 7:03 PM

#

#

saved

wicked wyvern Mar 20, 2023, 7:03 PM

#

munley

late condor Mar 20, 2023, 7:03 PM

#

Thats cruel

wicked wyvern Mar 20, 2023, 7:03 PM

#

archived in #🔹admins-best-hits

timber cedar Mar 20, 2023, 7:03 PM

#

anytime theres a new feature request

#

late condor Mar 20, 2023, 7:04 PM

#

Whenever I tell my boss it will take me an hour it takes me 3 months

#

Whenever I tell him it till take 3 months, it will take an hour

sacred jasper Mar 20, 2023, 7:04 PM

#

Okay

#

It's something extremely hard

#

I have to go in and patch the KSP2 dll manually to add spacewarp and bepinex straight into the DLL, which will take years

timber cedar Mar 20, 2023, 7:05 PM

#

just rewrite ksp2 🙄

sacred jasper Mar 20, 2023, 7:05 PM

#

Imma rewrite KSP2 in cheese

timber cedar Mar 20, 2023, 7:05 PM

#

cheese_pl gogogo

wicked wyvern Mar 20, 2023, 7:06 PM

#

cheeselang.org

sacred jasper Mar 20, 2023, 7:06 PM

#

fn ksp2 => void
  runPerfectlyWithoutBugs()

timber cedar Mar 20, 2023, 7:07 PM

#

wicked wyvern cheeselang.org

when

#

learncheese.com

sacred jasper Mar 20, 2023, 7:07 PM

#

if bug
  dont(bug)

wicked wyvern Mar 20, 2023, 7:07 PM

#

Dakota already tried hitting the "fix performance" button and it didn't work

timber cedar Mar 20, 2023, 7:07 PM

#

fr ^

sacred jasper Mar 20, 2023, 7:07 PM

#

Cheese is still in progress

timber cedar Mar 20, 2023, 7:07 PM

#

commit today

sacred jasper Mar 20, 2023, 7:07 PM

#

I've only just finished the parser to a degree that it works

timber cedar Mar 20, 2023, 7:07 PM

#

i think breaking changes

sacred jasper Mar 20, 2023, 7:07 PM

#

look at the github repo for cheese lol

timber cedar Mar 20, 2023, 7:07 PM

#

yeah ik i looked in the morning

#

i look everyday in case 1.0.0. release

sacred jasper Mar 20, 2023, 7:08 PM

#

bruh, the first version will be 0.0.1

#

https://github.com/cheese3660/cheese_pl

GitHub

GitHub - cheese3660/cheese_pl: Git repository for the cheese progra...

Git repository for the cheese programming language! - GitHub - cheese3660/cheese_pl: Git repository for the cheese programming language!

timber cedar Mar 20, 2023, 7:08 PM

#

wicked wyvern Mar 20, 2023, 7:08 PM

#

oh lol I thought you were memeing

timber cedar Mar 20, 2023, 7:08 PM

#

xdd

wicked wyvern Mar 20, 2023, 7:08 PM

#

didn't know it was an actual thing

#

kekw

timber cedar Mar 20, 2023, 7:08 PM

#

ofc it is

wicked wyvern Mar 20, 2023, 7:09 PM

#

to be fair I'm not even surprised

#

seems like a cheese thing to do

timber cedar Mar 20, 2023, 7:09 PM

#

sacred jasper Mar 20, 2023, 7:10 PM

#

wicked wyvern seems like a cheese thing to do

really?

wicked wyvern Mar 20, 2023, 7:10 PM

#

can't say I know you very well, but this tracks

#

vaultpeter

timber cedar Mar 20, 2023, 7:10 PM

#

best buds

little bay Mar 20, 2023, 8:10 PM

#

wicked wyvern They wouldn't be disabled, their lifecycle methods will still run

you can also disable the component

wicked wyvern Mar 20, 2023, 8:10 PM

#

hm

#

it still isn't very clean though

#

it could already have had some side effects at that point

#

like setting up Harmony patches etc

little bay Mar 20, 2023, 8:11 PM

#

sure

#

which is why you would need to enforce having OnDisable implemented

wicked wyvern Mar 20, 2023, 8:12 PM

#

I guess that could be doable

#

and if the mods don't properly clean up, it's on them and not SpaceWarp

little bay Mar 20, 2023, 8:12 PM

#

that would also mean mods could be enabled and disabled without restarting the game

wicked wyvern Mar 20, 2023, 8:12 PM

#

yeah that was the idea

#

AppDomain still would have been the best way

#

dumb Unity

#

nooooooooo

little bay Mar 20, 2023, 8:13 PM

#

no, it really wouldn't

#

AppDomains suck ass

#

even if they were supported

#

to get data between them, you effectively have to marshal things over all the time

#

like

#

assemblies in another AppDomain effectively exist in a different world

wicked wyvern Mar 20, 2023, 8:14 PM

#

yeah i know the general gist of it

little bay Mar 20, 2023, 8:14 PM

#

like it were a new process

#

they wouldn't be able to interact with the running game

wicked wyvern Mar 20, 2023, 8:15 PM

#

https://www.brad-smith.info/blog/archives/500 this is somewhat how i imagined it

little bay Mar 20, 2023, 8:15 PM

#

which is why AppDomains no longer exist in .NET

#

they've been replaced by AssemblyLoadContexts

#

which actually do what you want

#

but they don't exist yet

wicked wyvern Mar 20, 2023, 8:15 PM

#

well they do

#

just not in mono

little bay Mar 20, 2023, 8:15 PM

#

don't exist in unity

#

I mean

wicked wyvern Mar 20, 2023, 8:16 PM

#

yeah that's basically the same thing

little bay Mar 20, 2023, 8:17 PM

#

wicked wyvern https://www.brad-smith.info/blog/archives/500 this is somewhat how i imagined it

yeah, mods would have to do reflection all the time to interact with the game

wicked wyvern Mar 20, 2023, 8:17 PM

#

it's not ideal, yeah

#

but in general I like the idea of sandboxing them

#

at least to some degree

#

so they can be loaded/reloaded/unloaded

#

still, much of the useful functionality in current mods is implemented with Harmony patches, and I don't think that would interact well

little bay Mar 20, 2023, 8:19 PM

#

sandboxing and C# just really do not mix

wicked wyvern Mar 20, 2023, 8:19 PM

#

yeah :/

timber cedar Mar 20, 2023, 8:19 PM

#

i think we should rewrite to cheese

little bay Mar 20, 2023, 8:20 PM

#

lua mods can totally work like that though

wicked wyvern Mar 20, 2023, 8:20 PM

#

JavaScript rewrite of KSP 2 wen

#

kekw

timber cedar Mar 20, 2023, 8:20 PM

#

no.

#

i think we should add js mod support

#

js roslyn compiler

wicked wyvern Mar 20, 2023, 8:21 PM

#

well it wouldn't be impossible

#

it could be pretty much the same thing as the (already kinda existing half-baked) Lua support

timber cedar Mar 20, 2023, 8:22 PM

#

it is impossible

#

because no one would work on it

wicked wyvern Mar 20, 2023, 8:22 PM

#

well

#

technically possible

timber cedar Mar 20, 2023, 8:22 PM

#

xd

#

yes

wicked wyvern Mar 20, 2023, 8:22 PM

#

=/= usable

#

klueless

timber cedar Mar 20, 2023, 8:23 PM

#

klueless = munix

wicked wyvern Mar 20, 2023, 8:23 PM

#

it is my favorite emoji on the server

#

so maybe that speaks for something

timber cedar Mar 20, 2023, 8:23 PM

#

nooooooooo > klueless

wicked wyvern Mar 20, 2023, 8:24 PM

#

fair, my top three in no particular order are munley klueless nooooooooo

timber cedar Mar 20, 2023, 8:24 PM

#

munley is 💯

wicked wyvern Mar 20, 2023, 8:24 PM

#

but anyway back on topic, I actually really like Aaron's suggestion

wicked wyvern Mar 20, 2023, 8:25 PM

#

little bay which is why you would need to enforce having OnDisable implemented

.

timber cedar Mar 20, 2023, 8:25 PM

#

wait let me reaed it

#

ok

#

...

timber cedar Mar 20, 2023, 8:25 PM

#

little bay you can also disable the component

this is how you should do it

wicked wyvern Mar 20, 2023, 8:26 PM

#

We could toggle a mod off by disabling its component and enforcing OnDisable

little bay Mar 20, 2023, 8:26 PM

#

you can just add public abstract void OnDisable(); to BaseSpaceWarpPlugin

#

10/10 no problems

wicked wyvern Mar 20, 2023, 8:26 PM

#

leave it to the mods to clean up their stuff after themselves instead of BIE or SW

#

I like it

timber cedar Mar 20, 2023, 8:26 PM

#

OnDisable(
Application.Quit();
);

little bay Mar 20, 2023, 8:26 PM

#

lgtm

timber cedar Mar 20, 2023, 8:27 PM

#

^^ was a joke that will kill ksp2

wicked wyvern Mar 20, 2023, 8:27 PM

#

OnDisable() {throw new Exception("You can't stop me");}

timber cedar Mar 20, 2023, 8:27 PM

#

GameObject.Destroy()

timber cedar Mar 20, 2023, 8:28 PM

#

wicked wyvern OnDisable() {throw new Exception("You can't stop me");}

this should be the default error of sw

wicked wyvern Mar 20, 2023, 8:28 PM

#

lmao

sacred jasper Mar 20, 2023, 8:49 PM

#

Enforcing ondisable would be breaking though would it not

wicked wyvern Mar 20, 2023, 8:50 PM

#

yeah, you could keep it on the backburner for 2.0

#

but I'm thinking - is there at least some way to make BepInEx not load certain .dlls (other than moving/renaming/deleting them)?

#

I don't think mod disabling needs to be a runtime thing, it's almost a bit unreasonable to require

#

but it be nice to at least have after game restart

sacred jasper Mar 20, 2023, 8:51 PM

#

At runtime itd have to unregister a lot of shit

#

Addressable bundles and such

wicked wyvern Mar 20, 2023, 8:51 PM

#

yeah exactly

sacred jasper Mar 20, 2023, 8:52 PM

#

Wait can KSP2s part system support runtime part welding?

wicked wyvern Mar 20, 2023, 8:52 PM

#

so I'm wondering if BepInEx might maybe have some API hooks for loading mods

#

I haven't really looked into it at all tbh

wicked wyvern Mar 20, 2023, 8:54 PM

#

sacred jasper Wait can KSP2s part system support runtime part welding?

I think it could be doable at least to some degree

#

don't really know how the part system handles/would handle for example multiple Modules of the same type

timber cedar Mar 20, 2023, 9:11 PM

#

that sounds like the most laggy thing ever created

wicked wyvern Mar 20, 2023, 9:11 PM

#

well I think the goal is the opposite

#

to reduce part count lag

timber cedar Mar 20, 2023, 9:12 PM

#

some guy was doing a rewrite for the craft json

#

i think

#

should ask him

timber cedar Mar 20, 2023, 9:42 PM

#

hear me out

to convert 2.1.* and stuff like that to a comparitve state

public static int CompareSemanticVersionStrings(string version1, string version2)
{

#

wait

#

wait

#

dumb

#

nvm

#

i give up

#

too hard

#

gonna go back to writing kernel

wicked wyvern Mar 20, 2023, 9:59 PM

#

fixed it for ya

#

(including some tests)

#

I think it should be working fine

#

📎 versions.cs

timber cedar Mar 20, 2023, 10:09 PM

#

yeah

#

thats what i was going for

#

👍

#

wait can you run c# standalon

wicked wyvern Mar 20, 2023, 10:10 PM

#

in what sense?

timber cedar Mar 20, 2023, 10:10 PM

#

like not in game

#

just

#

script

#

like nodejs

wicked wyvern Mar 20, 2023, 10:11 PM

#

https://dotnetfiddle.net/ I didn't feel like creating and compiling a file so I just ran it here

C# Online Compiler | .NET Fiddle

Test your C# code online with .NET Fiddle code editor.

late condor Mar 20, 2023, 10:11 PM

#

timber cedar because no one would work on it

it wouldn't really be hard

#

https://github.com/fholm/IronJS

GitHub

GitHub - fholm/IronJS: IronJS - A JavaScript implementation for .NET

IronJS - A JavaScript implementation for .NET. Contribute to fholm/IronJS development by creating an account on GitHub.

timber cedar Mar 20, 2023, 10:11 PM

#

late condor it wouldn't really be hard

do it 😉

timber cedar Mar 20, 2023, 10:11 PM

#

wicked wyvern https://dotnetfiddle.net/ I didn't feel like creating and compiling a file so I ...

ah yeah okok

late condor Mar 20, 2023, 10:11 PM

#

no, I hate javascript :p

wicked wyvern Mar 20, 2023, 10:11 PM

#

yeah I was going to say that I'm 99% sure there's an interpreter already

late condor Mar 20, 2023, 10:11 PM

#

but its really just about exposing stuff to IronJS

timber cedar Mar 20, 2023, 10:12 PM

#

Console.WriteLine(CompareSemanticVersionStrings("1.*.5", "1.0.1"));

#

nononon

#

nnonoonon

#

onnonono

#

no

#

nononononon

#Space Warp