#Signal gateway not sending encoded account info to Signal Cli.

1 messages · Page 1 of 1 (latest)

tropic zealot
#

Its sending +32612444422 without encoding to cli causing errors in processing. Signal is receiving, but my interactions are not going through. Its fixed on my end but every time I update, it writes over the changes.

#

I’m sorry, but currently drinking the Hermes fire hydrant, learning every hour, minute, second. Last time I touched a line of script or code was 15 years ago. Let alone know how to change the relevant lines in github and serve a pull request.

royal helm
#

hey

#

no worries

#

can you elaborate the issue

#

i still dont understand it

#

send the ss or logs perhaps?

tropic zealot
#

So I have +31612345678 setup as the bot number and +31687654321 as my approved number. Because of an encoding error it screws up and needed a fix. This is hermes explanation

Summary of Both Fixes:

Bug 1 - SSE Connection Failure:

  • Phone numbers with + weren't URL-encoded
  • Caused 400 Bad Request errors
  • Fix: Use quote(self.account, safe='') in SSE URL

Bug 2 - Signal Attachment Download Failure:

  • RPC used wrong parameter name attachmentId instead of id
  • Caused NullPointerException in signal-cli
  • Fix: Change parameter to id
#

That also includes the fix I did for retrieving attachments from signal messages. Worth your while too because it cant read for example images with default upstream code

royal helm
#

fixing

tropic zealot
royal helm
#

no sir

#

adding soon

royal helm
#

@polar skiff do the honors 🫡

royal helm
#

@tropic zealot merged on main

#

test now

tropic zealot
#

Love the speed and transparancy here!

tropic zealot
#

Can confirm it works ootb now

pale badger
#

Did you just leak your own number???