lethal lichen
When I run loccaly my app I have perfect icons but after path in my phone are some chinese characters. Do you know why? 😄
📱 App: joemonster_pro (df139678-42f5-4a58-ac68-46f5aa318dff)
📦 Release Version: 1.0.0+5
🕹️ Platform: Android [arm32 (1.34 MB), arm64 (1.24 MB), x86_64 (1.24 MB)]
🟢 Track: Stable
wintry jewel
Shorebird doesn't support changing assets in patches currently
If you try to make asset changes in your patch you'll see a warning and ignoring it can result in this type of behavior
daring fjord
flutter automatically "tree shakes" fonts down to only their used characters
You can disable this with --no-tree-shake-fonts I believe
wintry jewel
Looks like you did in fact have asset changes in this patch (patch 5 for release 1.0.0+5)
daring fjord
The real fix is for us to support assets: https://github.com/shorebirdtech/shorebird/issues/318
But that's several months away (we're a very small team fixing other issues for customers atm)
lethal lichen
I know about not supporting assets, but there are custom icons not from assets:
const Icon(Icons.thumb_up_alt_outlined, color: AppColors.dark_40, size: 16.0),
const Icon(Icons.mode_comment_sharp, color: AppColors.dark_40, size: 16.0),
sullen quail
You can disable this with --no-tree-shake-fonts I believe
@lethal lichen try this
daring fjord
The problem is that the fancy font tree-shaking that flutter does (which is cool!) ties code and assets together intimately. So since Shorebird currently can only replace code, it becomes very easy to also cause asset changes by accident (simply by adding/removing an icon usage)
once we add asset support this all goes away
lethal lichen
@daring fjord how should I use that parametr in patch?
shorebird patch android --no-tree-shake-fonts doesn't work