#Slow performance on IOS after shorebird 1.1.22 version

1 messages · Page 1 of 1 (latest)

forest sand
quasi kestrel
#

Can you share your app ID

forest sand
#

fcad3e6b-111d-44b2-aa1b-bdda4842d081

quasi kestrel
#

And which release was this?

forest sand
quasi kestrel
#

40% is quite low. Eric and Felix are more knowledeable about this part of the system, but can you describe the changes you made?

forest sand
quaint granite
#

Yeah, that defintely shouldn't happen. 🤔

#

looks like it was with flutter 19f36dba936d7c1406a470366a3a936f1242eeb5

#

which is only last week 🤔

#

When you run shorebird patch and it fails like that, it produces a patch-debug.zip file. If you're able to share that I'm sure @cyan crystal would love to take a look when he's back.

#

He's been working with other customers this week to get them above 90%. For such a tiny change I would expect it to "link" at 99% or there-abouts, not 40%

forest sand
quaint granite
#

Thank you!

#

Felix is OOO today, but I expect he'll reply to you tomorrow.

cyan crystal
#

I’ll have a look shortly (feeling better after getting a bit more sleep)

quaint granite
#

Do you pass any --dart-defines or other arguments when compiling? If so, are you passing the same arguments when compiling both the release and the patch?

cyan crystal
#

Also it looks like you're using a Flutter revision that doesn't include some recent fixes we made. Can you please try re-releasing using the latest Flutter revision and then making the same patch?

quaint granite
#

Thank you very much for your help so far!

forest sand
#

Thank you I will try to re-submit a newer version, also I am not using --dart-defines

quaint granite
#

OK, my guess was from seeing the change be dependant on kDebugMode and wondering if somehow the patch could ahve been compiled with a different set of flags than the release was. Can you confirm what set of flags you pass to shorebird release? Thanks!

forest sand
#

only shorebird release ios even not on CI/CD, it has been run locally and then open build/ios/archive/Runner.xcarchive and distribute

quaint granite
#

@cyan crystal is back now.

quaint granite
#

We're trying to reproduce a similar failure for our testing.

#

We've found one of the issues we think you're hitting, but we think there might be a second as well.

cyan crystal
#

@forest sand when you have a second, can you also share the type of status in your bloc and what toInt() is doing? It would also be helpful if you could make each of these changes separately and try patching to see which one is responsible for the big drop in linking, thanks!

cyan crystal
#

@forest sand heads up we just released a new version of Shorebird (v1.2.2) which includes some more linking improvements. Are you able to re-test?