NFSU2 (Need For Speed Underground 2)

[modest obsidian]

Umm, yeah, photosensitivity warning, I guess :D

[ember river]

Try disabling ReSTIR (the github issue)

Or do the thing with boiling filter I described there. Maybe it is something like that now

[modest obsidian]

Setting the filter didn't help, disabling ReSTIR completely did

Finally, epilepsy mod disabled :3

On another note, glad to see headlights in the game but I think they are not powerful enough, lighting up the road just in front of the car

[jade briar]

They have a weird falloff

Something we'll have to look into

[blazing bone]

ReSTIR is important tho

The game will get even laggier with more lights now

[jade briar]

It is

Not if it's broken as hell tho

[balmy chasm]

Glad it's not broken for me :3
(with old Adam's lights)

[tawny elk]

I’ve become really concerned that even with sharing rtx confs, there appears to be a difference in visuals as @ember river discovered.

[jade briar]

Ye old adam

[tawny elk]

[jade briar]

I'm gonna be honest. Your lights are super bright for basically everyone except you

[balmy chasm]

If we're protesting, than I'm not happy about Adam using AE for setting up lights

[jade briar]

I use ae

[balmy chasm]

You don't set up lights

[tawny elk]

Which was expected when using someone else’s rtx conf. But it seems that didn’t resolve it

[ember river]

Well I found an alternative setting for ReSTIR that have been working for me and the lighting is somewhat acceptable (althouth I see sparkling everywhere)

[tawny elk]

How would I use AE when setting them up? From my understanding you want to light the scene with a fixed exposure and then add AE afterwards.

[balmy chasm]

I want to set up scene with fixed exposure and make users decide for themself if they want to use AE or not. But if you prove you made AE work really smooth - we can rewrite rules for that

[tawny elk]

Yea that’s what I’m doing now. It’s up to the user if they want to use AE. I didn’t know that it would be so problematic to use when I first started

[tawny elk]

That’s how the game typically looks when I use one of your guys rtx confs.

[balmy chasm]

I just saw you saying you have AE ON right now

[tawny elk]

I do not. I believe Burrito does.

[ember river]

I'm blinded by the lights

[balmy chasm]

Overbuffed light samples somehow

[tawny elk]

That’s a lot of fireflies (?) going on.

[ember river]

Yup, it is a ReSTIR thing, cause when I disable it, I get a clean view

[tawny elk]

Reading some documentation from Pixar on this, it can be caused by a light source being too close to an object.

It's usually best to track down the source of the fireflies and eliminate it. Often these come from geometry which is very close to a light source which makes them so bright, that they'll strongly illuminate the scene through indirect contribution.

Which I do know for a fact, that many sources are very close to geometry.

[balmy chasm]

But they appear on trees. Guess they're not illuminated at all?

[tawny elk]

Oh yea, those have no lights.

[ember river]

It makes sense, if there is some floating point imprecision when computing lighitng diving by a very small distance and number blowing up 🤔

[tawny elk]

But from this article it still could be from sources being too close to geometry.

https://renderman.pixar.com/debugging-and-optimization

[tawny elk]

Which I don’t understand why I don’t get the same problem. My mind is starting to wonder if it’s hardware related

[ember river]

But on my case it is really ReSTIR stacking too much lighting by mistake. When disabled it goes away. It happens gradually over frames too (roughly 1 second), when enabling/disabling

Yeah maybe we should start asking ppl with the same problem, which hardware and driver version they're using

Maybe getting some more data can help

[tawny elk]

I’ll setup a test rig for it tonight

Place lights increasingly close to a surface and see if it triggers the problem.

Or y’all can setup one 👀

[balmy chasm]

Nah, it sure works. But such fireflies only appear around the light source

[jade briar]

https://youtu.be/4NRXx6U8ABQ

[balmy chasm]

https://youtu.be/TZoL_MFLcKg
We're in NFS topic

[tawny elk]

My hypothesis is something FP related with certain hardware/driver configurations causing ReSTIR to fall apart as you said.

[jade briar]

Naked and famous

Uh huh

[tawny elk]

New fix: only 3080s on driver version xyz are supported

[jade briar]

Uh huhhh

Time to downgrade

[safe patrol]

it'd be an upgrade for me so I'm ok with it

[tawny elk]

Could we get a test/benchmark scene put together to test what performance/bugs we get with various configurations?

[ember river]

Would be nice

[ember river]

Later on some of that could be dockerized and setup as CI for the repo 🤔

[tawny elk]

Is there a race replay mode in u2?

[ember river]

Hm I guess, let run a race real quick and see if I can save the replay

[jade briar]

Yes. Once you finish a race, you can watch replay. There's no way to save it. That's how I made my initial comparison video.

[tawny elk]

Fug

[ember river]

Nah I'm still in heaven with the old cfg

[jade briar]

Yep

Here's a crazy ideo

Idea

[jade briar]

Try turning on horizon fog from game settings

[dusty grove]

where are downloaded that? when i download from release page its old one (im noob in github soorry)

[ember river]

Nothing. Also tried many other game settings

[ember river]

That is it. A new release since 0.2.0 hasn't been rolled out yet

[dusty grove]

on that (old) release evrything is fine

[jade briar]

Also. Horizon fog fixes the minimap and nitros bar

[dusty grove]

maybe try latest adam lights? delete old one obv

[jade briar]

Nah it's a remix bug

[dusty grove]

actually i had it before, it fixed after fresh install, when i updated bridge, dxvk, and gpu drivers, maybe smth about that?

[jade briar]

@ember river I have reported all these bugs to mark. I have spent hours looking for a solution on the user end, but nothing. You shouldn't waste time on this.

[ember river]

I'm working on merging new adam lights but found some issues with game/hardware/driver/idk compatibility which are making our lives harder. Coming to a fix I think we could make a new release

[jade briar]

The engineers for the renderer are already working on it

I hope

[tawny elk]

3080s only

[ember river]

I see. It is just that it makes my texturing work harder since lights aren't accurate anymore. If I could mimic the same look as adam's pictures at least then I could move on

I'm lead to believe that its gotta be some specular+indirect bounces issue from many settings I've messed around, but most notably right now I disabled secondary bounces in the Rendering > Pathtracing > Integrator and all the overbright went away

[jade briar]

Yeah, I did discover that.

[tawny elk]

Wonder if reading some ReSTIR papers will help

[dusty grove]

can someone send traffic lights (texture on car), can see them on repo but, there is no textures for them on github, obv cuz they are not released

[jade briar]

I think they're not merged into the main mod.usda

[dusty grove]

yes but i did that subLayers = [.... problem is no texture (on github), so no lights

[jade briar]

Lights don't depend on textures

Unless you're talking about emissives

[dusty grove]

"traffic lights (texture on car)" emissives i gueeeeees

[jade briar]

Ah yes

I think @safe patrol is responsible for that

[safe patrol]

you talking about player car or traffic cars?

[dusty grove]

traffic

[safe patrol]

those are merged into main

[dusty grove]

player will be nice too

[safe patrol]

player is more complicated. I've got emissives for a lot of player headlights and tail lights merged in main but there's till a ton to do.

[tawny elk]

A quick run through some of the ReSTIR research and it the ReSTIR bug looks like if it wasn’t doing any shadow rays.

[dusty grove]

ok but when i try github version of traffic emessives, they are broken, textures become grey, and red

[safe patrol]

github is extremely WIP and stuff isn't guaranteed to work from there.

If you don't know how to adjust and edit usda files I recommend using the release build.

[dusty grove]

yep thats why i was asking for full version of emessive textures of traffic lights, cuz idk when u update things next time.

[safe patrol]

https://github.com/Ekozmaster/NFSU2-RTX-Remix/tree/main/rtx-remix/mods/gameReadyAssets/Textures/traffic

they're all right here

[dusty grove]

i know basic stuff of .usda connecting each other this:

[safe patrol]

ok make sure the traffic.usda is pointing to the right folder where you have those textures.

[tawny elk]

Might be a debug view that’ll help figure out what’s going on ReSTIR and if it’s reusing bad samples repeatedly

[dusty grove]

oh i mean this emessive texture, i cannot see traffic while driving. this happend after adding traffic usda btw pic2. That's why im asking for textures for those traffic, because clearly they aren't on github page or release page.

[safe patrol]

hmm. I'm not sure what's going on there if you have some traffic working and others not? Is anyone else experiencing that?

[tawny elk]

It can be temperamental sometimes to get it to work. Not sure why

I feel like it just doesn’t load the usda from time to time

[dusty grove]

#1103377328530276403 message

• first pic isnt mine, just take it for explanation what i mean, second is mone after trying to apply traffic.usda from github.

[safe patrol]

oh then you need to look inside the traffic.usda file and make sure it's pointing to the directory where your traffic dds files are.

I gave you the link to the repo where all those textures are. Make sure they downloaded properly and are in the directory referenced by the traffic.usda

[dusty grove]

Yep and i dont have those dds files

[safe patrol]

you didn't download the repo properly then

[dusty grove]

Im sorry, actually checked and they are there, idk why it doesn't work

[safe patrol]

ok then you need to make sure the paths in your traffic.usda match the folders that the textures are in

[dusty grove]

already checked

subLayers = [
@./adamplayer.usda@,
@./wet.usda@,
@./traffic2.usda@,
@./gu_textures.usda@,
@./eman.usda@,
@./burrito.usda@,
@./player_car_lights.usda@,
@./traffic.usda@,
@./materials.usda@,
@./ExtMod/world_sprites.usda@
]

[safe patrol]

why is it called traffic2.usda?

[dusty grove]

cuz already had one traffic from adam like lights

[safe patrol]

oh yeah that's bad. you've got duplicates then.

get rid of traffic2

[tawny elk]

Did you just copy my repo and then combine it with theirs?

[dusty grove]

only usda + texture

[tawny elk]

Yea that’ll cause some problems. They’re not plugnplay right now.

Could some one record the ReSTIR bug with the ReSTIR debug views? https://github.com/NVIDIAGameWorks/dxvk-remix/blob/6533183fa0be490ee6e0cbeb25061e174919f7b3/src/dxvk/rtx_render/rtx_debug_view.cpp#L119

Wonder if we can see which part is failing

[dusty grove]

ok rename it as it shoud be still same

[dusty grove]

yep i try before the original github without urs files, no diffrence

[ember river]

This is bad. If you know git and how to use it in a terminal, can you do:

git stash push --include-untracked
git checkout main
git fetch
git reset --hard origin/main

Then copy the rtx-remix-defaults/rtx.conf into your game folder next to speed.exe?

This all assuming you've already installed all the dependencies listed in the README.md

[safe patrol]

yeah you've got a huge mess in there, no wonder it's not working

[ember river]

This should pull all .dds files, setup all usda correctly and put you in sync with our most up to date changes in the main development branch

[tawny elk]

@dusty grove Wipe your rtx-remix folder clean and just use the release from the repo.

[tawny elk]

I’m really curious if the spatial reuse one goes crazy when it occurs since you guys said it takes a few frames before it’s fully failed.

[raw wedge]

hi

where is the download link

[dusty grove]

check the pins > https://github.com/Ekozmaster/NFSU2-RTX-Remix

[ember river]

ReSTIR's initial sample: Using EV100 view mode mapping from 0 to 6

Alright the compression algorithm will screw up everything

But there are some red bits in some alpha blended/tested things like trees, car window, etc.

[tawny elk]

Is that with the bug occurring?

[ember river]

Yup

[tawny elk]

What’s the spatial reuse look like?

[ember river]

It is quite stable so I just took a picture

Sadly I can't think of a control sample test since any methods to make the bug go away rely on disabling ReSTIR somehow (disabling itself or disabling indirect bounces)

[tawny elk]

Could you give a reference of what the scene looks like without ReSTIR on so I know what parts are expected to be bright?

[raw wedge]

how can i open the menu

[dusty grove]

After fresh re install, default cfg, normal game from release page,> works just fine, install of files from repo > looks like this, obv my previes files wasnt a problem

[raw wedge]

pls

how can i

open the

menu

[jade briar]

Alt+x

[ember river]

That is the control sample I can't get that I've mentioned. If I disable ReSTIR, the very debug view makes no sense and just renders black

[raw wedge]

didnt open

[tawny elk]

Oh I meant without the debug view.

[ember river]

Oh, wait

[jade briar]

Is the game getting raytraced?

[raw wedge]

no

[jade briar]

Then you didn't install it correctly

[safe patrol]

we told you the repo isn't guaranteed to work without some tweaking.

[raw wedge]

my mouse is big

i have problem

[jade briar]

I'll say again. You didn't install it correctly

[raw wedge]

i cant open the nvidia experience

btw

[jade briar]

That's a different thing

[raw wedge]

nope i install the everything

[ionic prawn]

not have lights

its dark

[tawny elk]

Could you try disabling enhanced materials and then see if the ReSTIR bug occurs?

[dusty grove]

Yes, that i know, thats why i was asking for thoose traffic.usda emessive beutifull lights texture, cuz there is none on discord. i know how to implement it with main mod.usda.

[jade briar]

But it still isn't working. This means you didn't. Reinstall and read the instructions carefully

[raw wedge]

i cant change my res

max 1280x1024

[ember river]

Helps, but the bright is still there, I guess. At least the trees aren't white anymore

[tawny elk]

~~ Is it okay if I make a sub thread for the ReSTIR bug? I don’t want the info to get lost in the troubleshooting. @jade briar @ember river ~~ can’t make one here sadly. My b.

[dusty grove]

install widescreenfix > rename dinput8.dll > dsound.dll

[ionic prawn]

@ember river baixei o ultimo e ainda ta sem as luzes de farol e tudo escuro

[ember river]

Sure.
Actually, disabling the materials seems to have done a great job. I'm just not sure if it is how the game is intended to look like

[raw wedge]

i did man

i did everything

[ember river]

Many out there are having touble installing the game. Think it is time for a new release guys. That simple drag and drop .zip

[jade briar]

As I said. Mark already knows everything.

So we literally just have to wait it out

[raw wedge]

maybe rtx remix dont working on the rtx 3050

[ember river]

I still think a thread would be nice to share info and progress with mark

[dusty grove]

it works on any rtx card

[tawny elk]

I’ll make a thread in the #1095455547748257862 channel if that’s okay

[tawny elk]

Mark knows everything we give him, the more we provide the easier it is for them to fix.

[dusty grove]

btw maybe u installed wrong widescreen fix or ur speed.exe incompatible with widescreenfix. try mine speed2.exe

[raw wedge]

nah

[jade briar]

I haven't really found anything that you guys are finding again, but if you do, then let either me or mark know

[raw wedge]

didnt work

again

[jade briar]

Use brain

[ember river]

Please, if you could link the repo's issue to share it in the thread, would be very helpful.
https://github.com/Ekozmaster/NFSU2-RTX-Remix/issues/63
I'll compile the info we shared so far in the issue

[raw wedge]

:(((

[dusty grove]

what is actually happening, ur game launching but no rtx effect, u can activate menu Alt+X?, or game not starting?

[raw wedge]

game starting

but i cant open the

menu

and i have no rtx effect

[dusty grove]

so obv problem is bad install of rtx remix

[raw wedge]

im gonna install again

i swear the god

install everything

but not working

WindowedMode = 4

is that true ?

[tawny elk]

Seems only mods and such can reply in that channel

[tawny elk]

Another theory: is the game adding the emissive textures itself, combining with the enhanced materials?

[raw wedge]

OK

now

[tawny elk]

I forget how to disable the automatic emissive textures.

[raw wedge]

game is

not starting

[dusty grove]

better we have proggres

[tawny elk]

Please type these in one message rather than 4.

[raw wedge]

yeah lol

[dusty grove]

ok man i will do it lazy way wait a second

[raw wedge]

i think i found the problem

[dusty grove]

works?

[raw wedge]

im gonna delete the game

thanks for everything

[safe patrol]

do you have an RTX graphics card?

[raw wedge]

yeah rtx 3050 mobile

[dusty grove]

shoud be enough for 720p dlss ultra perfomance)))

[tawny elk]

This thread is active if y’all wanna come help be detectives and find out what’s causing it

https://discord.com/channels/1028444667789967381/1126189727956082859

Rule 3

[jade briar]

Basically

Start reading from here

#general-remix message

Here's all the info I was able to get.

Add whatever you want, and make a ticket.

But there's an internal ticket already filed.

[tawny elk]

It’s so quiet now 👀

[pallid river]

Anyone got an rtx.conf for this game?

Looking to get Underground 2 set up

[tawny elk]

Check the pins

[pallid river]

Totally forgot 😆

[pallid river]

Got it all working

[pallid river]

Is this what it's supposed to look like after importing mods.usda?

[jade briar]

Probably not

[torn star]

What’s the software for editing and setting lights in usd files?

[ember river]

Check the #1095534398134300682 pinned messages

There are some tutorials and stuff to look at before beginning

[ember river]

The software specifically is Nvidia's Ominiverse Create (AKA USD Composer)

[pallid river]

Think I found out why the floor is sky blue

[ember river]

Guys, new PR fixing the ReSTIR overbright issue:
https://github.com/Ekozmaster/NFSU2-RTX-Remix/pull/65

needs approval

[ember cobalt]

coolio

[pallid river]

I didn't figure out why the ground is blue

thought it was this

Looks like it's also broken in the game too darn

Enhanced materials just turns everything into plastic

[severe solstice]

[pallid river]

All I did was drag and drop the files man 🥹

[jade briar]

Turn off road reflections from game settings

[pallid river]

Any other settings that explicitly need to be off?

And how does that affect composer since I'm getting the same issue there?
Do I do a recapture after fixing my settings?

[jade briar]

Most things should be off except for world details, and horizon fog

You shouldn't need any captures

Unless you're trying to replace textures

Then yeah

[pallid river]

Yeah this is what was happening there lol

[jade briar]

Strange

[pallid river]

Turned everything off you said and adjusted sliders all the way down, restarted game and still plastic

[jade briar]

Probably remix isn't able to find the path to textures

[pallid river]

That's what seems to be occurring in usd composer as well

I have everything from repo in my root game folder

Hm windows is saying the .dds are invalid

[jade briar]

Try opening them in Photoshop or nvtt

[pallid river]

That's how I saw they are invalid

besides preview not working

[jade briar]

What did you open them in?

[pallid river]

paint.net

which works for all other games .dds textures

lemme try nvtt as well to be sure

[jade briar]

I said it before. I'm gonna say it again

Try opening them in Photoshop or nvtt

[pallid river]

nvtt

[severe solstice]

60+ fps without dlss with my new 4070 ti

[jade briar]

E-man

[pallid river]

uh oh

[pallid river]

1080p?

[severe solstice]

2k

[pallid river]

nice

[jade briar]

I barely get 50 with a 4090

Wtf

[pallid river]

yeah I get 51 at 2k on the title screen garage

I'll redownload the repo in case I got a wacky one off

[modest obsidian]

Checked it out, worked miracles for me

[severe solstice]

wtf

[modest obsidian]

Hey, if you are downloading a zip straight from the GitHub website, textures are borked

[jade briar]

Yeep

[modest obsidian]

You have to properly git clone it for now at least

Unrelated, dust and smoke effects tank the shit out of performance for me

[pallid river]

Got it

[modest obsidian]

Generally at around 60 but when I'm driving behind someone on a dirt track it's dropping to 40s

[jade briar]

Yep. That is true

[severe solstice]

78

[pallid river]

dafuq

[severe solstice]

do you have 4070 ti too?

[pallid river]

4080

[dusk mango]

How to play

[pallid river]

ALso what's with your skybox

[pallid river]

lovely

[ember river]

Hey, yes the zip download option isn't working. I have to fix that missleading README.md. Right now, if you want the game to work properly, you have to install all the dependencies as usual like in the Hell's video, but the mod part you must git clone, maybe checkout into main and pull everything.
The problem is that .dds and usd binary files aren't stored in the repo itself. Under the hood, it uses Git LFS to store them in another Large File Storage server while in the repo it only keeps a text file pointing to the actual .dds file. It will download, checkout, and perform all versioning stuff transparently, it is just the zip download that saves space.
If you download the zip´, you probably still can do a git pull (if you're in the main branch) to dl all the actual .dds files

[pallid river]

Yeah I'm following the git setup now and saw that in the readme

[ember river]

This is a known bug when copying the link from the site and using git bash on windows. It copies some hidden characters before the https. Paste on a text editor and copy again

[pallid river]

I didn't copy and paste is why I'm confused

I saw that as the issue but if I manually typed then huh

[severe solstice]

I just tried dlss and it only worsens the image does not increase the fps

[ember river]

U didn't copy it like this?

[pallid river]

Nope I typed it.
I did it after deleting the $ filled by git bash and it worked for some reason

[severe solstice]

i had 5070 ti probably

[ember river]

How do you guys managed to get day mode? Technically speaking. Is it a directional light bound to some global mesh or something?

[severe solstice]

#1103377328530276403 message

burrito know about that

[ember river]

Hahaha nice one, the sky brightness variable

Imagine in the future being able to write, say, Lua scripts to control a day/night cycle 🤔

[pallid river]

didn't work the first fetch gonna try again

[ember cobalt]

if modifying mod.usda didn't cause huge lag spikes, you could just write a python script to update the value every second to make a fake day/night cycle

[pallid river]

I see the problem.
git isn't actually installing the repo?

mmm I had residual files and it got mad

[ember river]

Isn't there a .git folder?

[pallid river]

There was it was cause checkout main got mad that I didn't remove all old files

[ember river]

unstaged files you mean?

[pallid river]

deleted old files and now it's running

[ember river]

just throw them at the stash and blow them up

git stash push --include-untracked
git stash clear

[pallid river]

All installed now checking game

yay

I'll check composer now

composer looks good

what's the recommended cm^2 setting?

500 doesn't look far off

[ember river]

Tell me more about that. Is it something that could be easily injected in the runtime?

[ember cobalt]

sadly no, it's just a hack that'd be running in the background

for example, to launch the game, you'd run a bat file that launches the game and also starts the python script that modifies the mod.usda file

then it'd just be running in the background, constantly modifying the usda file to simulate a day/night cycle

it could also change the sky texture

[ember river]

I see, sadly the changes to file require reloeading of the mod

[ember cobalt]

yeah, and each time that file is reloaded, it takes about a second to work

it'd be insanely stuttery

[ember river]

If that worked and the user didn't had to reload the mod, the same concept could be used to watch for materials in player's cars and change roughness to smooth, since for each car customization the materials get a random hash due to how the game builds the car albedo texture during runtime

[ember cobalt]

the mod reloads automatically btw, if that wasn't clear

any time the file is modified, it'll automatically reload

it's just slow

[pallid river]

^^

[ember cobalt]

since it can't directly access what's going on in the runtime, i don't know if that'd be possible

[pallid river]

Unstable hashes suck

[ember river]

Hm... in my experiences I had to manually disable/enable enhancements, but I didn't wait long enough I guess

anyway, a form of scripting is a must for rtx-remix, I see

USD is meant for static scenes afaik

[ember cobalt]

the usda files definitely aren't intended for things like day/night cycles 😛

[ember cobalt]

i really do hope it's implemented at some point

[ember cobalt]

if someone wants to make a time lapse video using this, that'd be pretty cool

it's totally unusable for gameplay, but it'd make a nice demo

i did test remix with reloading the usda file hundreds of times over the span of an hour, it never crashed. it should be fairly stable

[slate surge]

Unironically how data caps work

[jade briar]

Very. Carefully.

[tawny elk]

So I wonder if that mesh is just cursed

[pallid river]

So I'm assuming for something like this where the texture file encompasses multiple objects, it wouldn't be possible to add proper material to them?

I'd just have to edit the individual aspects of each object like how the trashbag is I'd assume

[tawny elk]

Yes you’d have to make the material part for each section of the texture.

[pallid river]

I tried using chainner to upscale that image with an onnx model and as soon as I hit run my pc crashed

[ember cobalt]

did you have the game open at the same time?

upscaling is very VRAM intensive

[pallid river]

I figured it was because I had the game and composer open at the same time

Didn’t leave a dmp so can’t say for sure but that’s my first guess

[ember cobalt]

most likely

[pallid river]

First time upscaling an image
before I get too far, can I even upscale assets in UG2?
Like change a 256x texture to 512x or higher?

[tawny elk]

Yep

[pallid river]

Cool

Now I just need to figure out how I replace the original with that one

[tawny elk]

Material replacement is what you want to search for

[pallid river]

Okey dokey

How do I get the proper format to save my upscaled image as?

When I throw it into nvtt does it show me the format or is it just showing what it would export it as?

Ok I found that it does show me awesome

Crashed pc again when running upscale back to back

I upscaled as 512 and it spit out a 1024 wonder if it means it doubles the input res then

Nope seems to always spit out as 1024x must be the model doing a 4x and tile size is for the model to work properly

hmm the upscaling doesn't use any resources when running wondering if it's 3rd party application causing crash

been having a problem with afterburner causing restarts after crashing gpu driver so I'll try it with it closed

[ember cobalt]

@pallid river also, why are you using onnx?

it's slower than pytorch (pth files)

[pallid river]

@ember cobalt Just the first one I saw with chainner

where woukd I use pytorch?

[ember cobalt]

you'd download the pytorch version of whatever model you have from here: https://openmodeldb.info/

then set it up like this in chaiNNer:

[ember river]

@tawny elk my buoy, think I can't approve this PR for now. The lighting has gone wild. There is something weird going on, everything is sparkling bright 🤔. Found another of those bright shines near this region, and beacon hills + jackson hights lighting is waaay overbright. Not to mention that everything has just become very yellowish. Somehow the game unlocked mexico tonemapping.
I don't think it is something with your work, given by your pictures. Seems to be an issue that only happens on my end. Could someone else try this PR?
https://github.com/Ekozmaster/NFSU2-RTX-Remix/pull/62

This is using Anti Culling Lights off

[jade briar]

https://twitter.com/kapebeansies/status/1676748128253513729?t=bNkcXkwiEeB8qveSRgsJAw&s=19

bib 🐥☕️ (@kapebeansies)

https://t.co/kXtO08bi6u

Likes

2993

Retweets

591

Twitter · Jul 6, 2023, 12:21 AM

[jade briar]

Did we ever remove hellraven's lights before merging Adams?

[ember river]

Nope, but I tested earlier without the mod_lights.usda file (I suppose his lights are in this file). IIRC I recorded the video without them.

[jade briar]

Well, it's probably not the solution to your specific problem, but we should remove mod_lights because hellraven is busy these days, and just go with Adam's. Even though I'm not entirely happy with them.

I don't think having two different lights originating from a mesh is very optimal

With that said, Adam also said that he has to go back to heights area and adjust the lights there, so that's that

[ember river]

Well I just tested combinations w/wo mod_lights, w/wo adamplayer.usda, and w/wo the 01_lights directory and the only stable setup is using mod_lights.usda only 🤔

[jade briar]

That's a fat L for adam

Someone respawn hellraven

[ember river]

Haha no, its got be something else. The guy is an electrical engineer, I'm sure he knows some stuff. It is visible from his pictures that the game looks pretty on his end.
If we manage to find what is going on, at worse it might be probably just a matter of writing some automation scripts to adjust everything

[ember cobalt]

i've suggested it before, but have you guys totally swapped configs and see if the issues still remain? like using adam's rtx.conf, usda files, and whatever else?

[ember river]

I've tested with the old one that comes in the 0.2.0 rar release and the new one added by adam (which only changes the scene scale to 0.01)

[tawny elk]

Have you tested it with my repo?

Lemme zip it up and post it here and ya'll can test it

I'll delete the file in like 15 minutes so people don't start depending on it

[ember river]

Awesome. Maybe the usda structure setup is weird, since I merged with the stuff we have on the other repo.

[tawny elk]

I think that was the light intensity from the inputs: debacle where I couldn't find them

[ember river]

As of now, looking at the behaviour, it seems to me that the lights are duplicated. It is noticeble from the main menu already (the overbright)

[tawny elk]

I'll just DM you the files 👍

Let me know if that whole setup works.

[sharp sinew]

If you want this to be a proper pbr material you need to take out all baked lighting and reflections. You can make it higher Res with an upscaler but this really needs remaking by an artist.

[tawny elk]

@ember river Did it work?

[pallid river]

Thanks

[ember river]

Aaaaall right, now we're cooking with gas

[tawny elk]

[ember river]

Thing is, I'm trying to track what exactly changed so drastically to make all the difference. The rtx.conf you sent mt is veeery different from the one in rtx-remix-defaults/, but there is something else too

[tawny elk]

I diff'd it a few days ago and it seemed like mostly postprocessing differences

[ember river]

Alright, so, with your rtx.conf, all the sparkling artifacts from the video (prolly from ReSTIR) go away, but it all must run together to work properly: rtx.conf + gameReadyAssets. The dxvk.conf and bridge.conf makes no difference

[tawny elk]

It's my secrect 11 herbs and spices I tell ya

[ember river]

Now the problem is: How to merge everything again

[tawny elk]

Does it not work with just my rtx conf?

[ember cobalt]

can someone send me Adam's conf, and also the one that's supposed to work?

[tawny elk]

https://github.com/adamplayer/Underground2RTX Here's my whole setup minus textures

https://github.com/Ekozmaster/NFSU2-RTX-Remix/blob/main/rtx-remix-defaults/rtx.conf Here's the one that was being used that had all the restir problems

[ember cobalt]

if you were to just plop the textures from the release config into adam's config, would that be sufficient? what exactly is different in the release config that prevents you from just using adam's?

[ember river]

To work nicely the usdas must be the same as you've sent me, and must be using your rtx.conf.
Probably something got messed up when you restructured the work from your repo's usda with the our repo's in the Lighting branch
https://github.com/Ekozmaster/NFSU2-RTX-Remix/tree/Lighting

[ember river]

Count and EAWorld made a lot of structural changes, from naming conventions to directory hierarchies and all the documented stuff under the pinned "Guidelines" thread which would be lost

[tawny elk]

Hm wonder what's different that causes it.

[ember river]

Hmm I think it might be easier to merge than we think. The contents of the usda folder are easy to plug into our mod.usda, the remaining is work on external files like adaplayer.usda, materials.usda, etc. that requires a more careful look

[ember cobalt]

i see, but if rtx.conf is the main factor causing this, most of that shouldn't be affected? i'm guessing it's just a miscellaneous setting that got enabled in the release conf causing this issue. you could try starting a new conf following the set guidelines (then plopping in the textures) just to test

[ember river]

Well, copying just the usda director results in almos no changes:

[ember river]

adam's conf already works nicely. What is missing from assets is the work in these files at gameReadyAssets' root. Without them some regions have no lights (The images are with project's gameReadyAssets vs adams' ):

[tawny elk]

It finally happened. Someone else got the game to appear as mine

[tawny elk]

Idea: would it be better to make a PR weekly with the changes I've made in my repo rather than trying to keep them in sync?

[ember river]

Surely. It would be much easier to keep everything organized, we could manage issues, PR threads, CI/CD, and everything else in a single place

If you zipped your most up to date stuff, after merging this branch you could migrate and start working on branches and PRs from our repo. On my previous job, we used to work with short lived branches of up to 7 days. It is just awesome. Reviews are shorter, conflicts are rare and small, the commit granularity was great, all good

[tawny elk]

I won't be able to do much till Friday, many deadlines this week.

[ember river]

np. I'll do my best to merge everything

[tawny elk]

I appreciate it.

[tawny elk]

So there's just a branch with the week its from, and then it merges at the end of the week?

[ember river]

usually it is best to work by context. A branch meant to a clear purpose. Ex: Fixing ReSTIR overbright issue, adding lights to east tunnel, performance shop lighting...

with "context" being something doable in a week

it is not a hard rule, just a guide. That is because, following Kanban methodolies and metrics, a week is the point in which tasks begin to lose predictability. After that, the task might take 3 more days or a whole months, and in project management, predictability is key 😉

[tawny elk]

Yea the whole massive import of lights kinda confuses me

[ember river]

Could you describe roughly why adamplayer.usda from your repo is 35kb while the one in our repo's Lighting branch is 175kb? Just so I know how to merge them properly

[tawny elk]

Prob could use windiff to check the difference. But I assume it's that I put the elements in that file in their respective usdas rather than there.

[ember river]

actually, the merge will be smoother than I expected. The only real file that needs to be merged is adamplayer.usda

[tawny elk]

What's the conflict with the merge?

[ember river]

None, I'm just comparing the files with VSCode and checking their content. At the end as our repo is merged with contributions from everyone, the only changes we need from your repo is the rtx.conf and the adamplayer.usda file, I guess

[tawny elk]

Neat

I'd always lean towards the latest file when it comes to my work. It's rare that things get worse over time. ||Except the whole inputs: bit ||

Where's our PM? Wouldn't a github project be very suitable for our workflow here 👀

[ember river]

@jade briar

[tawny elk]

Here's your daily reading:
https://docs.github.com/en/issues/planning-and-tracking-with-projects

This would make things way easier to know what's going on. Even if it's just the basic trello board implementation

Oh and it allows for multiple repos to be used

@ember river is it good practice to use an issue to show progress of a section someone has been working on? Then once it's completely implemented, it's closed and turned into a PR.

[ember river]

Well that would be awesome. I was thinking about using trello, Jira or something like that, but was taking it slow so the team could get used to all the tools and workflows, but never occurred to me to use GitHub issues for that 🤔
Seems like a great idea

Simple and efficient

[tawny elk]

It's Need for Speed. A week is a long time here, gotta move fast ||https://www.youtube.com/watch?v=W-_9LcwKRQE||

[ember river]

Aight mate, just pushed a new commit merging everything in lighting-merge. Can you review it and check if everything is in place? The rtx.conf is in the rtx-remix-default directory, I just changed a couple of stuff like DLSS to performance mode. Should, if I didn't mess anything up, run the same as the game runs in your repo 🙏

https://github.com/Ekozmaster/NFSU2-RTX-Remix/pull/62

[tawny elk]

I get a bunch of conflicts when trying to do stuff with the branch in the github desktop so I'm just going to add comments to the "review" if that works.

might just wipe my local repo and then redownload the lighting-merge branch if you'd prefer me to make the changes

[tawny elk]

Yea my local instance is all sorts of messed up

[ember river]

So, the idea is to you boot up the game and check if the game looks the same. You'll need to wipe your repo from it and add ours, just back everything up first 😉

Also, if there is some work that got lost during the merge and overall if it looks decent

btw, what did you change in your RTX conf that made everything so dark? I'm back on main branch using your rtx.conf and, before the lighting was ok, but now it is all dark.
Before I could bump 240SX headlights from 400 to 800 and could see a lot. Now I had to bump all the way to 5000

[tawny elk]

Prob the tonemapper exposure. The earlier ones that Burrito had used were set at 10. By default it's 0.75.

[ember river]

Hmm... I've been messing with exposure and such, but it doesn't produces such a huge effect

[tawny elk]

Also I have pretty much everything that would modify the exposure disabled/set at 0.

[tawny elk]

I won't be able to do this till maybe tomorrow night/afternoon. Defiantly Friday night if I'm not completely burnt out from the week.

[ember river]

I like the view. This thing is slownly turning into an wallpaper engine

[tawny elk]

Slowly turning into ReSTIR showcase

I'm curious to see which part of the map becomes most wallpaperesque once I'm done with it. It's a tossup of the riverfront in beacon hills, Fremont Street, or maybe the one of the dense urban areas.

[ember river]

This casino one is surely my favorite. I like city center's main avenue between the tunnels. The airport sure gives some cool vibes when standing next to that huge bright window fassade

Alright, gotta go to bed

[tawny elk]

[balmy chasm]

*Good morning though 🥲 *

[elfin beacon]

Gm

[tawny elk]

what is sleep

[jade briar]

guys

help

[tawny elk]

What’s up

[jade briar]

So

Lets say I want to merge your repo

With eman's

How

[balmy chasm]

By rewriting paths

[jade briar]

how

[balmy chasm]

Well, you start by adding his .usda as a sublayer for mod.usda

Like this

[tawny elk]

Going forward I’ll be adding my changes as a PR weekly if that helps any

[jade briar]

Man. I'm falling behind.

[jade briar]

[tawny elk]

Is that a full install of my repo?

Including the rtx conf

[jade briar]

Yes. I'm using your conf

[balmy chasm]

@tawny elk Which .usda's on your repo contain lights? Seems like just mod.usda and adamplayer.usda are not all of them

[tawny elk]

The entire usda folder has light USDAs

[balmy chasm]

But it seems like you haven't referenced them?

[tawny elk]

Oh there’s a 01_lights.usda

[balmy chasm]

Do you mean 01_buildings.usda?

[tawny elk]

Yep

I think

[balmy chasm]

Also don't forget that 02_materials has exactly the same named 01_buildings folder

[tawny elk]

My usda references:

(
    metersPerUnit = 0.01
    subLayers = [
        @./usda/01_lights/01_buildings/01_buildings.usda@,
        @./usda/01_lights/02_roadways/02_roadways.usda@,
        @./usda/01_lights/05_global/0105_Global.usda@,
        @./usda/01_lights/04_unique/0104_unique.usda@
    ]
    upAxis = "Z"
)```

[balmy chasm]

Aaaahhh

Got it

[jade briar]

adam, what does this area look like for you?

I gotta send screenshots to nile today

[tawny elk]

I won’t be able to do much till later this evening EST

If you drag the unique usda above the global usda, you can get the 6500k roadway lights.

[balmy chasm]

Same area
ignore textures

[jade briar]

huh

[tawny elk]

This looks more what my game looks like.

[balmy chasm]

Even though now I'm not sure you have emissive on 1 🥲

[tawny elk]

Do y’all just want me to push a release on my repo that you guys can use?

[balmy chasm]

I wanted to see how bad things can get for me. But seems like that's not on your side

[tawny elk]

What do you mean?

[balmy chasm]

Now I question E-man, because I have stock ReSTIR settings and enabled

[tawny elk]

What card do you have?

[balmy chasm]

3070ti

[tawny elk]

Per burrito it shows up in reference mode on higher end cards.

[balmy chasm]

E-man got 3060ti, doesn't he?

[tawny elk]

I think it’s a 3060.

[tawny elk]

You can use the stock rtx config with my lights afiak, I think the AE causes it to be over exposed but that’s about it.

[balmy chasm]

Also do you know if higher sublayer rewrites entire mesh content of one specific hash, or it just adds them to the following layers (in case they overlap)

[tawny elk]

Its additive

[balmy chasm]

So you can like add 2 exactly same .usda's as sublayers and get double the brigher lights?

[tawny elk]

Yes if they have different file names

I’d suggest adjusting the exposure or AE to get the scene to be brighter tho

Lemme know if that works 👍

Thought you were trying to brighten things up

[balmy chasm]

Nah. I just didn't know about this aspect

[ember river]

Morning ppl

I see u've been busy guys
About the repos merging, this is what the lighting-mergd branch is doing, merging both repos so all Adam's content comes to ours

Did someone else try this branch?

[jade briar]

This is the screenshot I'm thinking of sending to Nyle

[balmy chasm]

Yet not sure about bloom

[jade briar]

hmmmm

[balmy chasm]

Also you mi-i-i-i-ight want to disable ACES finalize

[jade briar]

It has been sent

[ember river]

You gonna send one only?

[jade briar]

He asked for one

Adam player try not to make piss yellow lights challenge (hard)

[ember river]

Id pick some more iconic places, like the ones we were talking about yesterday. The main avenue on city center, the casinos, fort union has some great vibes. The iconic start at the airport. They really sell the work u guys have been doing

What is the purpose of those screenshots anyway?

[balmy chasm]

this

[ember river]

Well, I think this is time to show the best we can. Might result on ppl growing eyes on the project

Some wallpaper worthy ones 😉

[ember river]

Heelll yeah

How do you get those angles with the game camera without culling kicking in and eating the car wheels and whatnot?

[jade briar]

I told you before

Use zolika's mod menu

also u missed one texture

[ember river]

Wut. Your build is outdated

[jade briar]

No THis texture is some sort of rare exception, I think. I'm using the latest repo

[tawny elk]

I’ll have some time this after noon to do some tweaking if y’all need something changed.

[jade briar]

https://cdn.discordapp.com/attachments/978642457111719936/1126532627579547648/image.png

https://cdn.discordapp.com/attachments/978642457111719936/1126532628363870238/image.png

[tawny elk]

I’m tempted to try out a dusk distant light source as an alternative one day

[ember river]

Nice, the daylight mod is also a pretty cool showcase

[tawny elk]

I think I’ll save the airport start and the drive to the car dealer for later when I’ve really got the look nailed down

[safe patrol]

Are you using the daytime version for this one? Why is it so bright in the background?

[jade briar]

yes.

[safe patrol]

ah, ok. Just wanted to be sure.

[jade briar]

Nyle wanted the day version. So I said sure.

[tawny elk]

The bounced daylight filling the scene looks so good.

[jade briar]

Man

The god damn lighting

Adam

Bro please bro

[jade briar]

Look at the difference here

We're moving away from the original look with this.

[safe patrol]

I'm ok with moving away from the original look in the name of realism, personally.

as long as it looks good, that is

[jade briar]

To me, honestly doesn't look that good.

There's something up with the street lamps. They're wayyy too bright

I'm once again asking to use hellraven's lights as a reference.

[tawny elk]

I can make an override usda that changes all the color temps to like 6500k+

[jade briar]

Yeah but. That'll override every light, wont it?

[severe solstice]

bright lover

[jade briar]

[tawny elk]

No, I chose which ones get it

[jade briar]

hmm

Also. Less bright.

[tawny elk]

Europe with their stringent dark sky compliant designs 👀 (you are in Europe right?)

[jade briar]

This was honestly a high. I don't think we can top this.

[jade briar]

nope

[tawny elk]

Hm. Was it hell that’s in Europe?

[jade briar]

Yes.

He's in germany, I think

[tawny elk]

I remember us talking about this a month ago. He has a different reference on what urban lighting looks like and it shows in his lighting style

[jade briar]

Okay. Here's the thing

Hold on lemme find the thing

[ember river]

Hm...I like the yellowish tones, mimics some references from forza horizon 5's north city (forgot the name), but I must agree with the lighting being way too bright

[tawny elk]

Drag the special usda above the roadways in ov.

It has overrides for the roadway lighting that makes it more “cinematic” and cooler

[ember river]

My mod .usda looks like this in the lighting-merge branch rn

[tawny elk]

Hmmm I think my usda references all those lighting usdas already unless you changed it

[safe patrol]

oh that would explain it, since it would double them all up right?

it's cumulative?

[tawny elk]

Yea, but they might just be too bright for their tastes as well

[safe patrol]

probably both

[ember river]

The main menu is also over exposed

[safe patrol]

sigh. I broke something and now remix won't launch at all 😦

[tawny elk]

Did you make sure to rename the DLL to asi if you updated remix?

[tawny elk]

I thought it looks nice with the gloss

[safe patrol]

that was probably it, thanks

updating my graphics drivers and then I'll try again

[tawny elk]

Okay so for alternative lighting styles:

• Cinematic
• Japanese?
• Euro?
• Cyberpunk?
• Pure

[dusty grove]

Game gets over exposed cuz of light bounce settings, adam cfg uses 0 and 4, if u try smth more like 1 and 8 u will need to lower exposure

[ember river]

I see. Maybe the light is just too wide

[jade briar]

So these are hellraven's lights. With remix devs blessing us with the option to quickly enable and disable rat racing, you can easily compare how it looks.

[ember river]

Im using the same rtx.conf he provided now. Should be the same look 🤔

[tawny elk]

I also used a dark colored car when setting up that scene

[dusty grove]

Know most time in game it looks fine actually (adam cfg), maybe adam uses low monitor brithness or smth.
Anyway when i use adam lights i go for 1 8 bounce, no AE with expo at 0.250 instead of default 0.750.

[tawny elk]

I’ll make an alt and call it “Pure”’ where it’s the exact cct and color as the original game where possible.

[jade briar]

You don't have to go for EXACT

Just something that's easier on the eyes

Especially with the brightness

[ember river]

I'm not too fan of the game's original. It is very washed out. I like your concept for accurate urban lighting, it is just a matter of a tiny nudge towards less bright, IMO

[safe patrol]

Yeah I'm ok with changes to coloration in certain places where it looks better or more realistic but I like the darker look overall

[ember river]

I'll write some scripts to replace all intensities to a multiple like 0.75, for testing purposes

[safe patrol]

Thanks that fixed it. I really need to remember to do that when I update.

[tawny elk]

I think Kim already made one

It has CCT tuning as well

[jade briar]

Here's adam's

ooh I never noticed the new grass texture

[tawny elk]

You asked me to give them spaced out look earlier

[safe patrol]

Yeah I don't remember if E-Man or EAWorld did those. I've replaced a few other grass textures too - overall pretty nice improvement.

[ember river]

those medians are mine. Added couple weeks ago

[safe patrol]

There ya go. Yeah big improvement.

[tawny elk]

Would you like a different look for them now?

[safe patrol]

we need to go through and update the rtx.conf texture categories for a bunch of things. There are some sky textures that need to be flagged, and there are a bunch of textures that I've added emissives to that are flagged to add lights.

[jade briar]

It is spaced out, but a bit too much.

[ember river]

Well, I lowered the intensity to 25% for 02_roadways.usda and bumped temperature to 1.3x and I like what I see, it is a mix of them two 🤔

I just wouldn't like to use innacurate values just to adjust the look. Tonemapping and color grading posts exists for that purpose

maybe we can keep the values for colorTemperature, lower intensity, and compensate with a color grading less yellowish

[tawny elk]

The color grading isn’t as intuitive as I’d like so I didn’t mess with it. Let me know if you make any progress with it.

[tawny elk]

There are no “accurate” values sadly without setting the tonemapper to like >0.1.

Unless you mean color temperature

[ember river]

Yes, color temperature alone. Intensity and specially color grading are all dependent on so many aspects of the render engine that is impossible to come up with a standard

speaking of color grading, found some cool values that looks somewhat decent to me, but my view is getting saturated and I would need to rest my eyes for a moment before making further tweaks

[tawny elk]

Hm. Should I be using the global tonemapper now that I think about it more

[ember river]

Alright so, saturation can be set to 1.
This rtx.conf has those settings now. That, together with the lights at 25% should get the lighting the a nice good looking point. There are still some points very yellowish in the city, but adjusting the color grading for them would make everything else weird, washed out or out of balance. Those could be adjusted by hand later

Sry for the flooding. Just wanted to keep some references of how the game looks now on different points in the city center

[sharp sinew]

as someone without the game i appreciate it

[tawny elk]

These are also good markers for how the mod looked at certain time which I like

I think the diversity in color temperature is getting dialed in well. The older areas are much warmer and dim, while the modern ones are full of light.

[ember river]

I'm really enjoying it now

[tawny elk]

Speaking of which, do you guys like the in progress photos when I'm working in an area or would prefer just a before and after?

[tawny elk]

I'm really excited to see how the hotel plaza will look after completing the whole area.

[timid prairie]

Quite interested to try it out myself soon, but this will not happen this week because I am currently in Moscow for treatment due to kidney stones, for all my time there (and I have been there since June 30) I feel like hell, the very long-awaited operation to remove kidney stones is expected to happen on July 11, and honestly to me I can't wait to get out of there as soon as possible, A catheter, Bloody urine and pain in the left side of the abdomen is not what I would ever want in my life, ESPECIALLY a CATHETER, if I manage to survive it all, then I will be EXTREMELY interested in trying it all myself, even if I can't set everything up right the first time

[blazing bone]

@jade briar why didnt you apply the translucent shader to the glass yet?

[jade briar]

I have to figure out the whole github workflow

[ember river]

If you prefer, you can keep sending stuff through discord and some of us can pick it up and add through the git workflow. That way you don't need to learn it and can focus on your work 😉

[jade briar]

I wanna learn

"How bad could it be."

[safe patrol]

github desktop makes it pretty easy

[ember river]

Oh man, I just had some expectations broken

Would be magical if someone had figured it out, but sadly the mod doesn't

[jade briar]

It disables far off culling. It helps a lot with light pop in, but not camera culling.

[tawny elk]

Yea there are ints for the hq lod distance and a lq lod distance in the exe

[ember river]

Maybe the mod author could be contacted, see what he have found

[tawny elk]

I asked him if he'd do a comission to get rid of culling and he didn't answer

[ember river]

Hmmm interesting

[ember river]

Sad. I was going to propose this idea

[tawny elk]

I can toss him a bone again but no promises.

[jade briar]

I sent him a message. 3 times. No answer. I know he's alive because he chats in his own server.

[ember river]

Well that would be nice. Maybe through some other media too. Guy has a patreon, yt and discord channel

[tawny elk]

He might of only had the same amount of progress as me. See his carbon SDK: https://github.com/Zolika1351/nfsc-sdk/blob/main/include/Draw.h

Unless this is it

https://github.com/Zolika1351/nfsc-sdk/blob/main/include/GrandSceneryCullInfo.h

[ember river]

Hmmm interesting. Such things might be pretty difficult to find, maybe cheat engine could help? I've once used Ghidra which does some very decent disassembly work, and has some tools to work on runtime too, but it is a ton of work to find anything meaningdful

[tawny elk]

Good thing I spent a lot of time learning how to use all those things when I was trying to figure out culling in the first place

[ember river]

Hahah nice. Are all the logics compiled in the SPEED.exe or there are some DLLs with hints for function names regarding frustum culling and stuff?

[tawny elk]

Everything is in the exe afaik

[tawny elk]

The memory address for the DoCulling points to a string

"LOADING_REGULAR_SECTIONS"

There's this string above it:
"\\\\Eac-proj7\\RACING-BLD\\PrecullerBooBooScript.hoo"

Hmm...

[ember river]

What is this DoCulling?

[tawny elk]

It's xref'd into that object with all the pointers

I've had the realization

That the whole time I was looking for the camera to have been doing the culling

But the answer isn't an explicit culling function dependant on the camera. Rather it's done with the map loading.

undefined ** FUN_005d3de0(undefined *param_1)

{
  undefined *puVar1;
  undefined **ppuVar2;
  
  if (DAT_00883d9c == '\0') {
    DAT_00883d9c = '\x01';
    ppuVar2 = &PTR_s_JACKSON_HEIGHTS_00800c38;
    do {
      puVar1 = (undefined *)??SetSkybox(*ppuVar2);
      ppuVar2[1] = puVar1;
      ppuVar2 = ppuVar2 + 2;
    } while ((int)ppuVar2 < 0x800ca0);
  }
  ppuVar2 = &PTR_s_JACKSON_HEIGHTS_00800c38;
  do {
    if (ppuVar2[1] == param_1) {
      return ppuVar2;
    }
    ppuVar2 = ppuVar2 + 2;
  } while ((int)ppuVar2 < 0x800ca0);
  return (undefined **)0x0;
}

This likely goes through the pointer list and does all those functions

[pallid river]

oof

[ember river]

This code seems to be related only with skybox loading. No sure what you're pointing to

[tawny elk]

The **??**Skybox is a guess at what it does

@ember river are you comfortable with cheatengine?

[ember river]

Not exactly. I know how to find some basic stuff like floats in memory for money, car position, etc.

I know it has some capabilities to memorize pointer paths and stuff to generate trainers

[jade briar]

Hey @ember river

So about the road textures.

Can you make them

✨ Shinier ✨

[ember river]

Sure. You mean, more reflections?

[jade briar]

Yeah low reoughness

[ember river]

I'll see what I can work with. Have some cool ideas

[jade briar]

Would be nice asap. As always, my excuse is I have to send screenshots to nyle.

[safe patrol]

fixes for window transparancy

[jade briar]

What is htis?

[safe patrol]

transparent/translucent windows. Instead of grey.

[jade briar]

We fixed that already

[safe patrol]

oh? where?

[jade briar]

Ah

It was the first texture e-man made

lemme find it

[safe patrol]

yeah, that one was still grey for me

I edited it to make these

[jade briar]

I didn't push the update. It was a glass material used for the window.

[safe patrol]

oh, material problem, not texture problem

well...I fixed it texture side? I guess?

[ember river]

So @tawny elk, for us to move forward with merging your stuff, what are the next steps? Are you going to make those changes in intensity, want me to pass the script and merge, would you like to review first?

[tawny elk]

Uh

[ember river]

Ure talking about that translucent shader model that strelok mentioned?

[ember river]

Rn I'm trying to merge all adam stuff so he can start working on our repo, next I'll finish my stuff on tunnels branch as is and move to roads

[jade briar]

Yes. I added it. Then had to leave for 3 days. You guys moved to the whole github workflow. I removed the new changes and am now figuring out how to work with github.

[jade briar]

Ah. okay.

I guess I'll use the old textures I made for now.

[ember river]

Shouldn't take too long actually. For when do u need those?

[tawny elk]

I'd say go ahead and merge it so I can just focus on fixing anything that broke in a new branch.

[jade briar]

Any time within today's date.

[ember river]

Alright then. I'll keep them at 30% intensity, but I'll only apply to the 02_roadways.usda file. Later on if something isn't quite right, we can adjust the same way

[tawny elk]

[jade briar]

iirc, you're using one roughness map for all the different textures

[ember river]

Yes. At the time I didn't know how to work with Create so I just updated the same textures u've sent me. Now I think I'll take the time to update all the materials and roughness maps correctly

[jade briar]

Ahh

[tawny elk]

_We're all learning here _

[jade briar]

Can you like. Take 5 minutes to update the roughness map and send it my way?

[ember river]

Ok. Gimme a second

[tawny elk]

I'll look into this approach sometime soon and see if I can get it to load the whole map in.

[ember river]

It will take more than 5 mins actually, since I need to open and paint the roughness for all variations and stuff, but should send to you in a hour, maybe, ok?

[ember river]

I was thinking to myself, maybe, the game was optimized to store also the precomputed BBOX's extents for all meshes. Maybe by changing that we could like, expand them to be huge and always pass the culling test 🤔

even though the map might be loaded in chunks (say, jackson heights, beacon...) it should still work well enough for us

[jade briar]

https://cdn.discordapp.com/attachments/381329194338222081/1126593567993909299/Uppityrudescarce_856a1b_10259361.mp4

[pallid river]

Any way to easily tell which textures are modified and which are stock

when looking in composer

[tawny elk]

Hm, I'm not quite sure how to modify the BBOX of meshes. The tooling for meshes is kinda meh.

[pallid river]

that would be amazing for capures I bet

[ember river]

Well, somehow the tools know how to parse the binary data. Another thing that could be done via scripts

[tawny elk]

Hm. Maybe I missed some tools when I first went searching for them.

[ember river]

On compose I don't know any, but on runtime menu there is a debug view to see unchanged materials. Those highlight legacy stuff I guess does what you want

[tawny elk]

The reason why I think loading the whole map will be the easiest: This little bit

  do {
    if (pppuVar2[1] == param_1) {
      return pppuVar2;
    }
    pppuVar2 = pppuVar2 + 2;
  } while ((int)pppuVar2 < 0x800ca0);

Runs through every map chunk, pppuVar2, to see if it's the one that wants to be loaded, param_1.

Sorry I should add more context to that

[ember river]

Hm so that SetSkybox thing u guesses had nothing to do with skyboxes, rather, it returns which one wants to be loaded?

[tawny elk]

{
  undefined **ppuVar1;
  undefined ***toLoadMapChunk;
  
  if ((char)PTR_00883d9c == '\0') {
    PTR_00883d9c._0_1_ = '\x01';
    toLoadMapChunk = &PTR_s_JACKSON_HEIGHTS_00800c38;
    do {
      ppuVar1 = (undefined **)??LoadWorld(*toLoadMapChunk);
      toLoadMapChunk[1] = ppuVar1;
      toLoadMapChunk = toLoadMapChunk + 2;
    } while ((int)toLoadMapChunk < 0x800ca0);
  }
  toLoadMapChunk = &PTR_s_JACKSON_HEIGHTS_00800c38;
  do {
    if (toLoadMapChunk[1] == requestedMapChunk) {
      return toLoadMapChunk;
    }
    toLoadMapChunk = toLoadMapChunk + 2;
  } while ((int)toLoadMapChunk < 0x800ca0);
  return (undefined ***)0x0;
}

[ember river]

I see

[tawny elk]

When you disable it, the skybox disappeared, but it could also be that it stopped streaming in data.

[jade briar]

[ember river]

Speaking of streaming, did you check the lock streaming position in zolika's mod? It locks the position in which stuff are culled so you drive alway and your car LOD turns into a something out of a Pixar Cars Ripoff youtube channel

[tawny elk]

Yes that's set by a camera pos from what I remember. It's a bool somewhere in that whole thing.

[ember river]

:sadge:

@tawny elk since I'm the author of the PR, could you please do the clicky stuff to approve and merge this big boy? It is for a friend
https://github.com/Ekozmaster/NFSU2-RTX-Remix/pull/62

[tawny elk]

I click

[jade briar]

https://cdn.discordapp.com/attachments/667677425722851379/1126234397989929021/BZvdXxP.jpg

[pallid river]

So as far as textures and such go how far behind is the repo?

I want to work on trying replacements and such but I don't wanna do stuff that might already exist

[ember river]

@jade briar What about this?

[jade briar]

Looks pretty good

Although

I gotta ask

Looks like you selected the wrong normal map type during the conversion precess

[ember river]

Oh ok, haha, the cracks are inverted lol

[jade briar]

Direct x or ogl

[jade briar]

yep

[ember river]

sec

[jade briar]

I wonder if other normal maps are also broken

[ember river]

probably

[pallid river]

Thought it was Octahedral we use?

[ember river]

It is, is just that I chosed the wrong input type for bump map, so dark means high and light means crevices

So, here is the wetter asphalt

[safe patrol]

yeah it depends on if you're converting from opengl or directx style normals

[ember river]

I was using directx

[safe patrol]

my game still is crashing anytime I try and load into a race. That happen to anyone else?

[safe patrol]

I like it

[jade briar]

So some unique textures are still missing, which isn't a huge problem right now because I can make screenshots in other places, butalso the resolution is not enough. I'd say double.

[safe patrol]

yeah roads are one place we can afford to go a bit nuts with resolution size

[ember river]

Yeah there is also the crossings

[jade briar]

Yeah, because the roads are something you see a lot

Like a whole lot

An unhealthy amount, I'd say

[elfin beacon]

Yum

[ember river]

Well, the textures were already handpainted and photobashed in 4k. Increasing the resolution wouldn't be that easy 🤔

[jade briar]

hmmmmmmmmmmmmm

Well

Damn

Also

@tawny elk @cloud crypt @ember river @safe patrol
How should you be credited in the nvidia post. Whatever that'll be.

Am I missing someone?

https://cdn.discordapp.com/attachments/1124418750440013944/1126610127710060665/image.png

Somewhat final.

[ember river]

That second picture aren't the textures we're using rn

[jade briar]

I know

**Somewhat **final

[ember river]

I would rather use my actual name instead of discord username, since for me this project is also an artwork for portifolio stuff
Emanuel Kozerski

[ember cobalt]

(6000 member)

[jade briar]

How many followed my link?

[ember cobalt]

there hasn't been many joins from it recently

[safe patrol]

CountBuggula is fine. I don't do this professionally.

[pallid river]

Old Junk and New Junk

[tawny elk]

My username is good

[jade briar]

Alright. Pretty sure hellraven will also use the same name

I'll also go with Uncle burrito

Am I missing anyone?

[elfin beacon]

If you are short on names ,I'm here for you guys.

[ember river]

Alright, I'll be merging my tunnels branch now so you guys can grab the new textures for both tunnels and asphalt. The changes are, aside from asphalts, the East and West tunnel access to Beacon Hills, and those wavy walls IIRC:

The first pic's roof idk who did

Need someone to approve this guy:
https://github.com/Ekozmaster/NFSU2-RTX-Remix/pull/31

[jade briar]

Done

[ember river]

Alright, it is merged on main rn

[tawny elk]

Marketing pls gib 4090s

[jade briar]

I have one

[tawny elk]

Can you share?

[elfin beacon]

You can keep 90 adam.

[pallid river]

YAH

[jade briar]

how

[pallid river]

nice tunnels

Can't wait until we can do proper meshes for that nice glass that's smothered in between other stuff

Gonna try roughness map with it for now and see how it goes

[tawny elk]

Break into pieces like a chocolate bar

[jade briar]

ah

[elfin beacon]

https://gfycat.com/clumsyultimatealbacoretuna

[jade briar]

https://tenor.com/view/linus-linus-drop-linustechtips-linusdroptips-drop-gif-24524203

[pallid river]

Old glass vs new glass (no material change just texture)

[jade briar]

Pretty cool

Although

Please try not to use ai upscalers

[pallid river]

Why not?

[jade briar]

Quality

[jade briar]

I don't want to make some ai upscaled jank

I want this to be the best thing possible

[pallid river]

I get it

[jade briar]

You know cbt?

[pallid river]

Won't remix's remastering be AI upscaled anyway?

What will the difference be then

Outside of the quality of the AI upscaler of course

[tawny elk]

It does a really meh job with PBRs.

[jade briar]

Who said we have to use it?

[pallid river]

I'm doing each of the maps after I upscale the resolution of the original atm

[jade briar]

Ahahahaha. Wtf

[pallid river]

wtf is that

[jade briar]

This

[pallid river]

For something like 3d bricks, that's a material and not a texture right?

[ember cobalt]

if you do it right, it's fine. Burrito just has bad experiences with it 😛

[pallid river]

anything with actual depth?

[tawny elk]

Okay one more cause if I upscale it 3 times it becomes

[jade briar]

https://tenor.com/view/nuh-uh-beocord-no-lol-gif-24435520

[ember cobalt]

yuh huh

[tawny elk]

I wish I could be an upscale master like you

[pallid river]

I notice that if I just upscale it tends to amplify wacky artifacts already in the texture

[ember cobalt]

upscaling text is a big no-no, but you can get good texture results

what model?

[pallid river]

So then when you add to pbr it looks bleh

[ember cobalt]

you will be 🙂

[pallid river]

Trying 4x-UltraSharp atm

[jade briar]

Ok. Upscale something. Should look crisp in game, no jank, full pbr.

One of the images of all time.

[ember cobalt]

that's my own model. i wouldn't recommend it for this game

[pallid river]

Wait wut

[ember cobalt]

i don't even have the game

[jade briar]

Bruh

Then shush

[ember cobalt]

no 😛

[pallid river]

What would you recommend? I just picked the ones in the post

[ember cobalt]

realisticrescaler is most likely to work for this game

[jade briar]

Uh oh. When I accidentally press send instead backspace

[pallid river]

I'll compare them to see

[ember cobalt]

but really: if you take the time to pick the right model and fix any issues manually, it can be a good result

that's all i'm saying here

[pallid river]

So for "full pbr" that would need a material change right?

[ember cobalt]

i haven't generated PBR, i'm just talking about the diffuse texture. i think @humble niche has more experience with that

if you can get faithful textures that already have proper roughness maps and all that, then use those instead. but if you can't, then upscaling is the next best option

[pallid river]

I've been upscaling base texture then doing the maps manually using the upscaled output.

[tawny elk]

#offtopic message

[pallid river]

True

[jade briar]

The moment someone shows me an ai upscaled texture that's pbr and something as good as if not better, than a hand made I'll allow. Until then, ai upscaled things are strictly banned. There might be exceptions, but not right now.

[pallid river]

I think with this game just making roughness, metalness, and normal maps can be enough.

[tawny elk]

You'd be surprised at how low res the textures are that aren't player cars.

[pallid river]

256x

[tawny elk]

Nah

Traffic light is like 52px or something

[pallid river]

Most of em are 256x that I've come across so far.
Some are 64x128

[jade briar]

Rough, metal, normal, and color are the only maps supported by remix anyways

[pallid river]

I mean like not upscaling and adding those in.

[jade briar]

You can add anything

[tawny elk]

I hear the secret to making remix happy is to set the color maps to have 0.01 alpha for the whole texture.

[jade briar]

All I'm saying is no ai

[tawny elk]

What if I'm an AI?

[jade briar]

Huh. Why's that.

[tawny elk]

Destroys framerate. Tis a joke. It's what happened with FNV.

[tawny elk]

Oh good another bit of text

[jade briar]

Uhhhhhhhhh

[tawny elk]

Aw it didn't upscale funny

Damn

[pallid river]

So on the topic of textures faithful to the original game, wouldn't upscaling be the best possible way to do that?
You are literally taking the original texture, and increasing the quality.

If you were to try the same yourself here, what would you even do?

[tawny elk]

Remake the color by hand and then use substance designer to create the PBR bits

[pallid river]

Yeah this is where I'm in no way an artist so I can only do the latter half

But making the other maps is kinda fun since it doesn't require nearly the same level of artistic skill or design

[jade briar]

Faithful doesn't mean that I have to remake everything 1:1. There can be differences here and there as long as the original look is still there

[humble niche]

So far my results with AI upscaling haven't been anywhere near acceptable, pretty much everything on the art side of my projects is placeholder at best and the kind of thing you see on ModDB for every game now.

[jade briar]

Ah. First hand experience

[humble niche]

I think Guided Upscaling might be an acceptable solution but as it stands I've yet to get actually consistent PBR results and hand crafted or HQ sourced alternatives is probably the way to go for now.

[jade briar]

I don't know how I replied to that

[tawny elk]

Magic

[jade briar]

Truly

[humble niche]

I do think AI upscaling is great as a first step but manual cleanup is a must.

[pallid river]

And you guys are referring to an AI generating all the different maps?

[ember river]

I only use Krita and chaiNNer to do my stuff. In Krita, you can select potions of textures, create filter layers that apply, say, luminosity changes, levels filters, saturation and everything to produce roughness and bump maps. It is not that difficult really

[jade briar]

Ai anything.

[humble niche]

Also watch your licensing, most of the upscaler methods use proprietary game assets for training purposes which is... not ideal.

[pallid river]

I guess I haven't done enough with it to see the issues, I've only generated 3 things

[tawny elk]

I think something that would be fun to have lots of people do is the banners and signs on the stores.

[pallid river]

And I didn't know the licencing was a thing with datasets

[jade briar]

Ehhhhh. Just don't cite sources :)

[ember cobalt]

yes, all i've been saying

rarely can you just upscale something and not modify it after

[pallid river]

I think cleanup is a must when adding pbr mapping to the originals as well

[ember cobalt]

it's a messy conversation. it technically is and isn't. it's good to stay on the safe side with it though

[pallid river]

Like the glass looked really bad because of all the little compression artifacts and other nuances would ruin the normalmap and metalness map

I would be curious to see what you guys considered bad results from the ai though.

[humble niche]

Check out my Red Faction 2 profile. 🤣

[ember cobalt]

this has a lot of artifacts

it's not "bad", it's just far from good

https://cdn.discordapp.com/attachments/588546848105693184/1113177046714163325/image.png

in my image here, everything is upscaled. i just used a single model for it. most of it looks good, but the foliage has issues along with the trees

[pallid river]

See now I'm lost cause I don't really know what an artifact would be in these cases

[pallid river]

I'd have to see them to know what to look for.

Ah

[humble niche]

Swirly nonsense patterns that look weird.

[ember cobalt]

these blocky artifacts

and nonsense detail

[humble niche]

They just look like details that don't make sense on the object.

[ember cobalt]

right, and usually are in abnormal patterns

[pallid river]

Well now I can't unsee them

[ember cobalt]

that'd be the point 😛

so you know what to look for when upscaling

[pallid river]

I'm gonna go back and look at what I upscaled ealier

But I do see that it still generated something that's 90% good, and can be touched up.
Useful as a time saver more than a complete replacement for texture work?

[ember cobalt]

yes, exactly

that's what i meant earlier

bur Burrito has banned it from this project, so it's off limits anyway

we can move to #offtopic for more discussion regarding it

[jade briar]

Give me give me hand made textures made with love, or give me death.

[ember cobalt]

now i wonder where open-minded burrito is

[jade briar]

It's not like banned banned. As I said, if I see something usable, I'll 100% allow it in. We all like being lazy.

[ember cobalt]

i'm just messing with you anyway, lol. i respect your decision, i just don't 100% agree with why

[pallid river]

I'll try the generate and clean-up approach and see if I can win your approval.

[ember cobalt]

maintaining high quality standards is good though

[jade briar]

I don't respect u. Fuck u

||/S||

[pallid river]

Because honestly it would be impossible for me to create something from scratch.

[jade briar]

It's not that hard. And there's a bunch of ways to go about it

[pallid river]

So what quality are you guys even sticking to resolution wise here?

Idek what res most games are now

[ember cobalt]

(regarding upscales, never go above 4x)

[pallid river]

Like is 1024x too high?

[jade briar]

You got. Nodes, photobashing, photoscanning, painting, a combination of any of these, or any other method ||(except ai)||

[jade briar]

It depends on a case by case basis. The upper limit is 4096

[tawny elk]

16x it is