its not too late but my brain is Cooked
#🖥-vesktop-development
hot juniper
simple groveBOT
small lionBOT
@grizzled hemlock, <t:1739324293:R>: get @cookie to fix this
grizzled hemlock
<@521819891141967883>, <t:1739324293:R>: get @cookie to fix this
@humble mortar fix this
woeful current
its intended anti tamper to stop debugging
explode
carmine drum
thanks for the auto streamer mode :3
vernal lintel
it doesn't even work yet 😭
vernal lintel
i gave u the right hash 😭
sister we're not depending on a fork
not in production 😭
azure verge
best notification to get from this channel is "sister we're not depending on a fork" ( i didnt see what channel so i thought of the utensil, not programming )
azure verge
lame
hot juniper
i depend on forks to eat
do you eat pizza with a fork
azure verge
stay hating at my civilized composure
chicken nuggets and pizza and wraps is my diet and if you eat any of those with forks just... 
anyways i eat pizza with the discord fork of electron
hot juniper
Double unpleasant
azure verge
anyways carry on good developer people i shall go back to my organic chemistry work 😭
vernal lintel
it woudlnt stay forked 😭😭😭
I'm about to fork YOU
azure verge
oh that's what you meant
humble mortar
quick death to save me from this cold
humble mortar
do you eat pizza with a fork
thin pizza with a fork is a joy you could never comprehend
azure verge
you disturb me
humble mortar
😭😭😭😭
vernal lintel
thin pizza with a fork is a joy you could never comprehend
bro
if it's too thin to hold it properly just slightly fold it
azure verge
can we shame this user /t
vernal lintel
___ -> \_/
humble mortar
i woke up from a cold sweat in the middle of the day yesterday and there was food next to me and then I passed out right after
vernal lintel
hold it like that
humble mortar
i woke up from a cold sweat in the middle of the day yesterday and there was foo...
it felt like a dream but the plate was there when I woke up later so it wasnt
hot juniper
,..,,.,.,.,.,
humble mortar
\_\_\_ -> \\\_/
monster
cyan flame
This channel is the weirdest of all the development channels
azure verge
good
cyan flame
how y’all just so quickly start talking about pizza?
azure verge
me, its always me
simple groveBOT
sudden trout
you love missing/fucked notif daemon
velvet mica
hi, for consideration: I generated a Vesktop icon based on the original source that better scales to lower resolutions.
the original only has a 256x256 image, although Windows recommends having 16x16, 24x24, 32x32, 48x48 and 256x256 options.
think I can PR it later but it's here if anyone can try
humble mortar
the Vesktop icon stuff is kinda in weird state rn
humble mortar
the hell happened to the tray
humble mortar
the Vesktop icon stuff is kinda in weird state rn
@vernal lintel can u make a decision about this..,., its annoying that the platform inconsistentcies have existed for so long and that vesktop has no real branding
velvet mica
the hell happened to the tray
it's been like that
when you only supply a 256x256 icon, Windows downscales to the lower resolution icons it needs with nearest-neighbour or whatever and destroys quality
if you manually downscale properly and include them in the .ico it'll use them
vernal lintel
think I can PR it later but it's here if anyone can try
sure
velvet mica
diff --git a/package.json b/package.json
index d516ba0..54db29d 100644
--- a/package.json
+++ b/package.json
@@ -183,7 +183,8 @@
"arm64"
]
}
- ]
+ ],
+ "icon": "icon.ico"
},
"publish": {
"provider": "github"
diff --git a/src/shared/paths.ts b/src/shared/paths.ts
index a935d82..074938f 100644
--- a/src/shared/paths.ts
+++ b/src/shared/paths.ts
@@ -9,4 +9,4 @@ import { join } from "path";
export const STATIC_DIR = /* @__PURE__ */ join(__dirname, "..", "..", "static");
export const VIEW_DIR = /* @__PURE__ */ join(STATIC_DIR, "views");
export const BADGE_DIR = /* @__PURE__ */ join(STATIC_DIR, "badges");
-export const ICON_PATH = /* @__PURE__ */ join(STATIC_DIR, "icon.png");
+export const ICON_PATH = /* @__PURE__ */ join(STATIC_DIR, process.platform === "win32" ? "icon.ico" : "icon.png");
diff --git a/static/icon.ico b/static/icon.ico
index 1dc9894..3ee9bfb 100644
Binary files a/static/icon.ico and b/static/icon.ico differ
pretty sure other platforms can also consume ico
humble mortar
yea electron passes it as an image bytemap on linux for instance
velvet mica
mm nice
humble mortar
yea electron passes it as an image bytemap on linux for instance
so its internal logic should handle that
no idea how it'd pick the size tho
velvet mica
kk
velvet mica
just do ico and we can try
without the win32 check, right?
humble mortar
humble mortar
pretty sure we even use icns on linux and it somehow works
electron builder turns it into pixmap dir pngs
so it strips out the 256px image into pixmaps/256/vesktop.png
humble mortar
storing the desktop icon in static is a bit annoying
vernal lintel
why
humble mortar
you shouldn't even need the icon when creating the window as electron builder bundles it into the exe as you can see in my icon change pr
vernal lintel
you need to speficy icon path for the tray icon
humble mortar
yes but then doubling icon stuff is guh
wait hold on
and the static/icon.png is then useless and should be removed. build/icon.png is also useless but can be left as a reference or smth
humble mortar
yes but then doubling icon stuff is guh
just have electron builder reference static/icon.ico and remove build/icon.ico
can make it a symlink if youre feeling fun
velvet mica
i have an idea, sec
vernal lintel
yeah the build directory isn't super necessary
it's just that electron builder automatically picks up files from there
and it's the convention
humble mortar
well it is necessary if youre not dynamically accessing the icons
like the icns and background belong there
velvet mica
you can add static/icons to the extraResources
just checked
and then it'd look like this
velvet mica
ye, but then it'll copy everything in static to resources
hm, wonder if I can speecify a filename
instead of a directory
yeah that works, nice
committed
austere wolf
bruh arrpc leaks memory on windows
humble mortar
lmfao
humble mortar
bruh arrpc leaks memory on windows
likely the process scanning code
it shells out like crazy
austere wolf
it leaks processes
humble mortar
there was a convo in here a bit ago about how to process scan better
austere wolf
after a while you can see like 1000 wmic.exe and cmd.exe in rammap
austere wolf
sob
humble mortar
ducko forgor to clean them up
austere wolf
they're completely invisible in anything else
and u can't clean them up in rammap so the only solution is to restart
afaik
austere wolf
idk
maybe something's up with the exec
either way it still sucks to bomb wmic with queries like that
humble mortar
try to swap the spawning method
austere wolf
hm?
humble mortar
the what
austere wolf
austere wolf
yes lol
at first i was just concerned about cpu usage but now i found it's leaking memory sob
neither of which are immediately visible to be vesktop's or arrpc's fault
humble mortar
<https://github.com/OpenAsar/arrpc/pull/109>
the doc u linked in review is from 2016..,, silly to even mention its 'undocumented' as that makes it sound like its unstable and not good to rely on
austere wolf
yeah i mean i doubt they're gonna remove it
humble mortar
the spiteful microsoft engineer in question:
austere wolf
velvet mica
there was a convo in here a bit ago about how to process scan better
hm
how does the current scanning work
wmic process get ProcessID,ExecutablePath /format:csv
oh god wtf
humble mortar
also youll likely want to comment that that pr also fixes a memory leak
velvet mica
ok but why do you need an undocumented api to do this
austere wolf
because koffi has natives obviously
velvet mica
most people don't use them
austere wolf
it's two birds with one stone, it also can't currently detect games that run as admin
im not super well-versed so maybe there's a better documented solution, but i trust pr guy
velvet mica
oh, the existing APIs only detect Administrator apps when you run as Administrator, right?
austere wolf
ye
austere wolf
where do i put esbuild arguments
or how do i fix the dam
No loader is configured for ".node" files
i see venmic is manually copied but how does it not explode esbuild
austere wolf
man i hate learning build setups
literally so lame
yap
we could and almost make your lives a lot easier, but we don't
very cool
velvet mica
of course it is perfectly reasonable to dump the pnpm folder on the root of my disk :^)
that's really weird
ahh
austere wolf
lol you need admin to build vesktop on windows
so silly
im going to fry
it's due to my changes wahhh
vernal lintel
lol you need admin to build vesktop on windows
no?
austere wolf
it was upset about like symbolic link or something
maybe it was still my changes lmao
man i did not know native deps were gonna be this annoying
simple groveBOT
hot juniper
it was upset about like symbolic link or something
windows moment
windows doesnt let you make relative links without admin
by default
simple groveBOT
velvet mica
lol you need admin to build vesktop on windows
just the first time
simple groveBOT
humble mortar
KDEs shortcut system can't handle mouse buttons
but it can detect them just fine so likkeee 💀
(there is a mouse button rebind menu)
humble mortar
i have no control over that 😭😭😭
chromium def had a regression tho
(showing and hiding the window was delayed)
try bumping your electron version
woeful current
'Open Vencord'
'in Vencord'
hey do you develop the Vencord client for linux?
humble mortar
elon husk
hybrid fjord
Sounds like old af issue with bitrate
humble mortar
nah vesktop resolution code expects 16:9
azure verge
i dont know about camera, but streaming doesn't have an expected res, no?
unless i completely forgot the code we wrote
azure verge
Sounds like old af issue with bitrate
(though, i have been having unstable bitrate issues again 😭 )
humble mortar
sour muralBOT
https://github.com/Vencord/Vesktop/blob/a1d5e4dcdcbd4e24ad388dbca9a3e22d2117cfff...
ScreenSharePicker.tsx: Line 85
const width = Math.round(height * (16 / 9));
ohhhh
yk that's not good practice ngl
😭
(my webcam isnt even 16/9, and i stream non-widescreen stuff sometimes)
though solving that seems like a headache and a half
azure verge
yeah i haven't had issues with that, though i cant really tell because my bitrate doesn't increase much as of recently, and for the past few months every stream has been a glitchy black mess
ive been waiting until spring break when i have more time to try to debug that and open an issue lmao
i assumed it was arch but it also happens on fedora kde so 
humble mortar
ive experimented with the glitchy/non loading and it seems that sending hardware encoded video is the cause
humble mortar
like last I tried I could stream, not have it load for my friend on macos then restart with the disable encoding flag and it'd load 😃
azure verge
video standards are video standards so i'd assume hw encoded or not it'd still be the same codec
azure verge
it always loads locally with no glitiness though
THIS
YES
omg
let me test without hw accel
humble mortar
video standards are video standards so i'd assume hw encoded or not it'd still b...
discord has their own flavour of webrtc on their clients and thats what ive been assuming is the cause
azure verge
of fucking course they do
but still i mean
isnt h264, well, h264
maybe it encodes in a different container or smthn?
humble mortar
idk 😭😭
azure verge
that's really weird and honestly
kinda piques my interest
humble mortar
my theory is chromium made or pulled a change from webrtc that discord hasn't pulled in and explod
azure verge
oh my god that makes a lot of sense
welppppppp software encoded streams for me it is
i wonder if that fixes my bitrate issues
y u p
humble mortar
smile
azure verge
my client wasn't LOCKED at low bitrate
it just... didnt ever wanna jump much higher than a few hundred for a few seconds at a time
was weird as hell
i was gonna open an issue soon but huh wacky
humble mortar
i was gonna open an issue soon but huh wacky
ive been meaning to for ages but I dont wanna deal with discords support ticket system 😭😭
azure verge
oh god yeah
azure verge
well i didn't expect this to become the support channel for me just now but im glad it did LMFAO
in all honesty tho i am curious as to what caused this fuckery
azure verge
wait what liscence is webrtc
if only i knew how to read the fucking googlesource pages
humble mortar
BSD-3-Clause
azure verge
o
humble mortar
foiled
azure verge
can they say no to an icbm (intercontinental blahaj missile)
yup
can confirm
turning off hw accel
fixed it
it stayed quite stable lmao
humble mortar
dont even turn off hw accel just pass the disable accelerated video encode flag
azure verge
well i can
turn off stream hw accel without turning off uhh
client hw accel
voice & video > hw accel
that's all that option does anyways
it just changes the flag
iirc
simple groveBOT
hot juniper
if (crash) dont()
literally exists in vencord
simple groveBOT
humble mortar
uhh dont have conflicting binds??
like be fr all software is like that
I'm gonna crash out in github comments one of these days
humble mortar
@floral ledge isnt that cause theyre not launching with the scope wrapper
@scenic hollow in the comment where they listed the shortcuts you can see theres no id on the leading side of the colons
simple groveBOT
simple groveBOT
simple groveBOT
azure verge
what the FUCK discord (this isnt an issue for anyone else, right???)
simple groveBOT
scenic hollow
<@339669513912057857> in the comment where they listed the shortcuts you can see...
yeah i noticed that but also looking at the code for the hyprland portal it seemingly doesn't actually save anything
hybrid fjord
what the FUCK discord (this isnt an issue for anyone else, right???)
For me sometimes
azure verge
hybrid fjord
Discord web moment
I don't really believe we can do something about that bitrate issue as long as it's reproducible even in browsers
humble mortar
yeah i noticed that but also looking at the code for the hyprland portal it seem...
thats an impl bug on their end then I think
humble mortar
I don't really believe we can do something about that bitrate issue as long as i...
discord throttling web clients to troll 
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
grizzled hemlock
if (crash) dont()
vp crashhandler
silk elkBOT
vp crashhandler
enabled by default
vernal lintel
peak
simple groveBOT
woeful current
lc.xkcd workflow
vocal fernBOT
lc.xkcd workflow
hot juniper
i love this gif
austere wolf
it's real asf
simple groveBOT
simple groveBOT
simple groveBOT
scenic hollow
woah more implmentation bugs to find
simple groveBOT
Discord Account
No response
Operating System
Nobara 41
Linux Only ~ Desktop Environment
KDE/Wayland
Package Type
AppImage
What happens when the bug or crash occurs?
When I click on the vencord has been updated notification to restart or when I right click on the vesktop tray icon and choose restart, it will throw this error:
(sometimes 2 times, sometimes more)
and then th...
simple groveBOT
woeful current
finally
humble mortar
thats an option to enable it on the de level
its always been chromium doing the pasting
humble mortar
woah more implmentation bugs to find
theres been zero movement on the kde impl bugs
scenic hollow
i didn't say fix (also we fixed the session token thing )
humble mortar
true :3
humble mortar
i think I found an xdg-desktop-portal bug
chromium spawns itself in a systemd scope (doesntly rely on the desktop to do it)
but the portal doesnt pull that for the app_id
😃
seems to only pull .service for it
despite the spec saying .scope is valid too
simple groveBOT
simple groveBOT
humble mortar
i'd be surprised if the regression ever made its way to fedora
it was found and patched pretty quick on arch
but the freezing of the entire system fits it pretty well
azure verge
i'd be surprised if the regression ever made its way to fedora
ive been using fedora for a few weeks now at least and never noticed it
so i doubt it
azure verge
i- what
fedora is on 6.12 though???
APPARENTLY NOT AS OF TODAY 😭
nnnot doing that 😭
azure verge
oml
hmm.. ive also found out that my bitrate issues only occur when streaming above 720p60
if i stream @ 720p60 it stays around 6k kbps
but 1080p60 drops to ~30 kbps
austere wolf
guys when will canadahonk come back 
humble mortar
hmm.. ive also found out that my bitrate issues only occur when streaming above ...
you have nitro though..,
humble mortar
oh
humble mortar
guys when will canadahonk come back <:prayge:983952795034091581>
wait for short burst of activity
azure verge
oh
yeah, i wonder if they do server-side resolution checks now??
but not framerate apparently
austere wolf
or maybe i should join some electron server and ask how to bundle natives
azure verge
and SOMETIMES the 1080p60 streams are fine??
im very confused lol
ill keep documenting what i find tho
austere wolf
what if your isp is kneecapping you
azure verge
has nothing to do with my isp
austere wolf
do u do constant uploads any other time?
azure verge
yes
also i can quite easily tell the difference between my isp chokeholding me and discord fuckery
for example, i can be uploading at quite a good speed while streaming and both are good
then the stream will randomly die
so i stop uploading
nothing changes
so i upload again
same high speed
- im on uni wifi rn but this didn't start until a few weeks ago
same-ish time as discord fixed linux streaming
austere wolf
oka oka fair enough
azure verge
so i assume they changed something on their servers for stream handling
i could be very wrong tho
humble mortar
maybe theyre finally doing server side checks
azure verge
and SOMETIMES the 1080p60 streams are fine??
this
humble mortar
partial rollout on their servers?
azure verge
possibly?
austere wolf
i still have truly no idea how vesktop's build works
is it using electron-builder THROUGH esbuild?
if so like how
ohh wait i see
so pnpm build is build.mts and it's just doing a simple electron-builder . for packaging
austere wolf
i may be stupid
simple groveBOT
austere wolf
can u run vesktop without compiling to a garbled mess
or like get dev symbols or whatnot
my stack trace be like
at fileURLToPath (node:internal/url:1487:11)
at VCDMain:10:14946
at VCDMain:1:225
at VCDMain:10:16167
at VCDMain:1:225
at VCDMain:10:19212
at VCDMain:1:225
at VCDMain:14:5589
at VCDMain:1:225
at VCDMain:22:3000
just start it
there are sourcemaps
even release builds have sourcemaps iirc
just make sure that javascript sourcemaps are enabled
austere wolf
hmm
it does throw during load, idk if that makes a difference
but where would sourcemaps be enabled
vernal lintel
worked?
austere wolf
hmm no line numbers for the mapped sources, is that normal?
i can sorta find it but a lil more difficult
why is it building to this...
oh
how did this ever work
man __dirname already exists
oh it's wrong
so cool and chill
how does this work on main
it specifically uses iife which doesn't work
vernal lintel
how did this ever work
it doesn't, that's why we patch it out
austere wolf
oh my god
vernal lintel
the patch didn't apply for you which means you didn't build properly
you likely installed with npm instead of pnpm or smth
austere wolf
i used pnpm
the only thing i did differently was not use frozen lockfile because im changing out arrpc
when does it apply?
vernal lintel
because i'm changing out arrpc
there's your problem
you likely need to update the patch or are installing it wrong
austere wolf
this sure is a solution
you can use esbuild's inject instead of patching it manually
supposedly
vernal lintel
no
that readFileSync straight up cannot work because there is no such file at runtime when it's bundled
austere wolf
you mean this wouldn't work? https://github.com/evanw/esbuild/issues/1492#issuecomment-893144483
austere wolf
ok idk how to make the patch work but the arrpc PR works once you get over all the hurdles
it also may or may not bloat vesktop's size by 60mb butttttttt
(there's probably a way to only copy the windows koffi natives)
(i could also potentially create a windows C++ native as part of venmic or something, but 
)
humble mortar
ok idk how to make the patch work but the arrpc PR works once you get over all t...
what patch
austere wolf
the arrpc patch
humble mortar
which
humble mortar
are you applying it on mainline
austere wolf
whar?
humble mortar
is the patch failing
austere wolf
yeah that just has the normal file, no change
otherwise it wouldn't have crashed on me lol
austere wolf
im not touching index.js :(
uhh im on liek a few commits back i think
nvm it is up to date
humble mortar
try to manually git apply
humble mortar
apply with -3 to have it do the apply conflict thing
your shit is fucked up if youre on mainline commit and its not applying
austere wolf
oh wait it works
ohh pnpm has a utility for generating the patches
i thought the patch was manually generated sob
vernal lintel
yes 😭
you just run a command, it creates a folder, you edit the files you want in that folder, then run another command and done
humble mortar
IT DOES???
austere wolf
wild shit
vernal lintel
IT DOES???
yeah lol
humble mortar
IVE BEEN MANHALLY DIFFING
austere wolf
lmao
humble mortar
all the prs where I make changes to it ..,,
austere wolf
humble mortar
insane
austere wolf
ok generating the patch doesn't work
very awesome
oh nvm ok
it patches on install, not build
huge, i can actually iterate on arrpc then
by the way i suspect that just removing the @x.y.z from the patch works, if you're using a local arrpc repo
just for anyone unfortunate enough to stumble on this too
next sundial
hey any news regarding h.265 playback support on linux?
next sundial
yes but
the intention is to make the necessary flags the default for everyone on linux
maybe upstream could take a look at this?
austere wolf
it’s time for rust in vesktop (arrpc) https://napi.rs/
(mostly because i don’t want to make a c++ platform agnostic build system for a windows binary)
hot juniper
it’s time for rust in vesktop (arrpc) https://napi.rs/
i feel like someone tried to do this in the past
not confident about that though
cyan flame
i feel like vesktop should inject its version here
doesnt it already
iron cedar
yup
cyan flame
grizzled hemlock
are either of you on a dev build?
iron cedar
nope
grizzled hemlock
i wonder if its overwritten by a vencord dev build
grizzled hemlock
love
hot juniper
sour muralBOT
https://github.com/Vendicated/Vencord/blob/main/src/plugins/_core/settings.tsx#L...
settings.tsx: Lines 224-230
get additionalInfo() {
if (IS_DEV) return " (Dev)";
if (IS_WEB) return " (Web)";
if (IS_VESKTOP) return ` (Vesktop v${VesktopNative.app.getVersion()})`;
if (IS_STANDALONE) return " (Standalone)";
return "";
},
maybe we could make this an array that's pushed to?
or vesktop should be made a distinct thing from vencord here
does supporthelper use this?
grizzled hemlock
ill pr a fix for that sometime
she reacts while i have 14 open prs
hot juniper
she reacts while i have 14 open prs
grizzled hemlock
maybe we could make this an array that's pushed to?
You don’t make it an array because then it can’t be optimized out by the bundled
hot juniper
Husk
hot juniper
insane
humble mortar
i feel like someone tried to do this in the past
yeah I have a partial rust implementation
didnt bother finishing it
woeful current
yeah I have a partial rust implementation
is it @late ridge
humble mortar
didnt bother finishing it
mainly because we can literally just reimplement the discord RPC native module and it'd be 200x better
all their native module does is expose process scanning and websockets and IPC
we do that and hook their module loader and we won't have to deal with the bazillion transport edge cases
simple groveBOT
austere wolf
mainly because we can literally just reimplement the discord RPC native module a...
then why wasn’t that done in the first place
humble mortar
then why wasn’t that done in the first place <:blobhuskcozy:1026533139608252436>
nobody has bothered
austere wolf
hm oka
is there any like notes or documentation on it anywhere?
or would you like uhh look at disc desktop sources and try to figure it out
humble mortar
youll have to read the native modules and asar
austere wolf
i may be stupid but how do i find those things 
oblique egret
it’s time for rust in vesktop (arrpc) https://napi.rs/
this is based
NAPI is based
its hell to work with, but its mega based
no android support
ggz
austere wolf
actually nah im just gonna improve arrpc without discord's rpc module
that makes the most sense
right now at least
scenic hollow
it’s time for rust in vesktop (arrpc) https://napi.rs/
already there with venbind
austere wolf
yay
lowkey why are subpackages so unbelievably annoying
i can probably do it without one but like it's gonna pollute the main source directory so much
humble mortar
what are you trying to do
austere wolf
use some rust code and have it compile into a binary as a dependency in the arrpc project
and use that binary from the arrpc without too much headache when you update the rust code
napi-rs looks decent but it depends on fucking yarn for some reason
oh it doesn't support windows arm, well fuck them anyway
i could prolly just use node-bindgen and do all the somewhat silly stuff myself
humble mortar
what are you writing in rust for arrpc...
austere wolf
windows process detection
fixing wmic leaks and detecting admin games
possible using koffi but koffi is like 60mb
humble mortar
isnt there a pr that does that already
why are you rewriting it in rust
so pointless
..,
austere wolf
because koffi is 60mb buh
if we're fine with vesktop gaining 60mb in a single push then whatever i guess
humble mortar
there are def alternatives to koffi
austere wolf
are they not going to be the same size
humble mortar
no?
humble mortar
where did you get the 60mb number
humble mortar
you have something in mind?
https://www.npmjs.com/package/ffi-rs just found this
40kb vs 70mb unpacked
70mb is koffi ofc
oh it was literally published 9 days ago
lol
humble mortar
yeah I doubt ducko would accept an in tree native module
overhead and all
let dedicated libs do that
humble mortar
yeah I doubt ducko would accept an in tree native module
(they want to rewrite arrpc at some point to so arrpc is kinda maintenance mode)
humble mortar
i may be stupid but how do i find those things <:bombcatcozy:1287154208990167271...
/home/kylie/.config/discord/0.0.85/modules/ discord_rpc and discord_game_utils
game utils is a native module which I guess does process scanning. rpc does IPC and Websockets
client then imports these modules and does things.
yea it is. prob better to focus on doing rpc as arrpc process scanning is good enough
austere wolf
right
i’ll look for funsies
how would vesktop get this module?
i assume we can’t rehost it?
humble mortar
rewrite it or fetch from whichever endpoint the discord desktop client does
humble mortar
discord desktop fetches it at runtime in the startup check
humble mortar
thats what the entire modules dir is
rewriting and bundling into vesktop seems like the best option anyway
anyway this REALLY isnt high priority
you should prob look into the koffi->ffi-rs stuff for arrpc first
memory leak and all
vernal lintel
using discord native modules defeats the entire point of vesktop
and we likely can't do that for legal reasons
austere wolf
rewite in rust
i am curious if that’s legal tho
it probably is but i agree that it defeats part of the purpose
humble mortar
rewriting the module and patching the loader is completely fine
doing RPC as a native module/rust is entirely pointless though
as websockets and IPC are completely fine in js/ts
austere wolf
ok what's rpc
i just refer to discord detecting game running = rpc
which is the only part i'd be writing in rust
humble mortar
process detection is part of game utils
entirely on the discord side
humble mortar
RPC is websockets and IPC
apps communicate with the discord app
apps can report game presence status which sorta looks like process detection
humble mortar
which is the only part i'd be writing in rust
doing this isnt a priority as arrpc handles it
(not entirely well but..)
austere wolf
ok but you want me to write the koffi stuff in rs tho
that's what i mean
idk what else there is to it lmao
i wouldn't be touching anything else
humble mortar
i said take a look at alternative libs to koffi as I assume ducko wouldn't accept a native module in tree
then I linked the ffi-rs lib as a place to start
porting the koffi pr to it should be easy peasy
austere wolf
im still so confused because im still generating a native module with ffi-rs
ig it's not a .node? is that what you mean?
humble mortar
im still so confused because im still generating a native module with ffi-rs
well so is koffi..
austere wolf
yes
humble mortar
I'm talking about an in tree module that would be maintained as part of arrpc
humble mortar
its sorta out of scope of what arrpc is at the moment
the koffi pr is fine and works(I assume) but as you said bloats the binary size (how did you test this?) so the first step is to try other libs (ffi-rs)
austere wolf
i didn't really test it but i assume all the native modules present in koffi get copied to the build somehow
austere wolf
buh buh
humble mortar
it should only use the modules for the platform
austere wolf
that would be cool
humble mortar
it does 😭
austere wolf
lol
austere wolf
i have to like run pnpm i again and what if something explodes
or doesn't get cleaned up
austere wolf
om
it's all in tracked files i swear
it's just annoying asf because i have to reference a local arrpc
humble mortar
gorp just edit package.json
austere wolf
so basically
humble mortar
huh?¿
austere wolf
and packaging koffi was a pain
was all like
"no loader configured for .node files"
austere wolf
or will it
humble mortar
and when vesktop builds it'll bundle it
humble mortar
or will it
yes?
humble mortar
you have to be doing something so cooked
austere wolf
ok loader node copy seems to work i think
the manual copies probably aren't necessary
silly me
false alarm guys, no need for rust
humble mortar
show me what you've done
austere wolf
uhmm not much
basically just using the pr https://github.com/OpenAsar/arrpc/pull/109 + my suggested changes
and doing this
the only other thing i really had to do was remove the @3.5.0 from the arrpc .patch file
i think
if that doesn't work then just re-generate the patch
humble mortar
does that copy all .node files?
humble mortar
hm
austere wolf
awesome issue thread full of clueless people all with the same issue
i wish esbuild just did it for you
vernal lintel
but the right approach would be to copy them manually with the build script the same way we copy venmic binaries
vernal lintel
it's the quickest solution
and also an awful solution I'm never gonna merge
humble mortar
can loader take globs
austere wolf
nu
vernal lintel
how do u tell esbuild to ignore
just see how venmic is loaded
austere wolf
i tried
austere wolf
putting arrpc in optionalDeps didn't work
vernal lintel
putting arrpc in optionalDeps didn't work
because why would u do that 😭
humble mortar
we're not using that library 😭
all solutions to the arrpc windows process scanning use a native module
vernal lintel
venmic is in optional dependencies because it only supports linux
austere wolf
buh
vernal lintel
so install is skipped on windows and mac without error
austere wolf
so i have to put koffi in optional deps in arrpc
humble mortar
no
austere wolf
well no because it'll still try to load .nodes
humble mortar
arrpc pulls in koffi
austere wolf
probably won't move out of windows only
what is a desireable solution
there's ps-list on npm
can't detect admin games tho
humble mortar
anyway that thing is never getting merged
all solutions to the windows scanning go through a native module to call the windows api
vernal lintel
yes and adding an extremely bloated library that supports the entire api is stupid
if native is the desired approach, make a minimal native library that only has the necessary functionality
humble mortar
theres other alternatives
austere wolf
oka but that's like a lot of setup
humble mortar
but getting the native module loading and working is the main issue
austere wolf
lot more stuff to maintain
vernal lintel
but getting the native module loading and working is the main issue
just look how venmic is loaded
humble mortar
just look how venmic is loaded <:fr:1024751426750132284>
nop
austere wolf
bop
humble mortar
arrpc pulls in the dep that has the native module then gets bundled
so stupid that esbuild cant handle that
austere wolf
do we really want another venmic anyway
vernal lintel
so stupid that esbuild cant handle that
except that it can
you can make a simple esbuild plugin or use inject
vesktop already has an import alias plugin, that's how importing from @vencord/types/* works
austere wolf
yeah i did try the plugin thing but it's so annoying
whatever, if koffi isn't on the table then it's not really worth discussing
humble mortar
theres other libraries 😭😭😭😭😭😭😭
austere wolf
ig
humble mortar
ffi-rs is tiny and from the examples it seems like it supports all arrpc needs
austere wolf
ffi-rs seems confusing but i'll just do C to keep to their examples
using wsl to generate a windows binary
i hate C
humble mortar
guh why
humble mortar
no why are u writing c
austere wolf
ok ok ok i'll try rust but all their examples are in C
im predicting this is gonna be a massive pain to figure out
humble mortar
??
austere wolf
(i don't do ffi)
humble mortar
use its provided js bindings what are you doing 💀💀💀
austere wolf
tfym
you need a dynamic library for it
it just skips the whole package.json stuff and .node file stuff
oh you mean like
load win api as a dynlib
im a little stupid
humble mortar
just port the koffi arrpc pr to ffi-rs
humble mortar
horror
humble mortar
@azure verge
azure verge
hm
guess im reading the code for that stuff again
WAIT now im
huh
it DOESNT
it checks full app accel
vernal lintel
no i dont think that switch does anything lol
azure verge
well that should definitely be fixed at some point 😭 (i might if i finish my current project)
humble mortar
??? did discord not desktop gate that switch??
its available in pure web
insane
ok yeah just tested
does nothing
gorbb...,,
austere wolf
this library sucks so much
azure verge
its available in pure web
wait
it exists
in pure web
and does
absolutely nothing????
austere wolf
ffi-rs is so tiny tho how did they do it fr
oh
because it's a bunch of different packages
humble mortar
absolutely nothing????
biscord forgor
vernal lintel
??? did discord not desktop gate that switch??
welcome to discord lol
bro thinks they give a shit about web
did you forget that they make random context menus unavailable on web for no fucking reason?
humble mortar
visual refresh still looks like ass on web 🔥
vernal lintel
I had to make an entire plugin to patch them back in
humble mortar
gorp..
austere wolf
segfaulting the interpreter now
humble mortar
i dont even use discord much
vernal lintel
humble mortar
why am I even here
austere wolf
idk
humble mortar
hellscape
@vernal lintel my computer has been running clion for like 6 hours indexing electron project so I can Pr linux accent and drop libunity dep requirements..,,,
indexing so slow..,,
austere wolf
ffi-napi seems better
pointers and such were an afterthought in ffi-rs
it's great if you don't have to use those
butttttti do
bwomp :(
humble mortar
points at you.. @worn harness
worn harness
hiii
austere wolf
hey vro
worn harness
@humble mortar your pc will shut off and have to start indexing all over again
humble mortar
ITS ALMOST DONE
worn harness
here it comes
oblique egret
visual refresh still looks like ass on web 🔥
does it? I've been using it just fine with no issues
austere wolf
wtf
ughhh
ffi-napi is goated but it was abandoned and it doesn't work anymore
it's so unbelievably smooth compared to the alternatives
frying rn
ffi-rs be like "No need to use ref to handle pointer 🤫" when that was literally WHY i tried out ffi-napi sob
simple groveBOT
hot juniper
whatever screw 32-bit users
this is fine
hot juniper
does nothing
https://github.com/Vencord/Vesktop/commit/66f5343662e18820ef9ec3da379e9506e0842773 is this unsubmitted thing relevant
i dont use this code anymore fyi
it is probably busted by discord updates
simple groveBOT
simple groveBOT
simple groveBOT
azure verge
visual refresh still looks like ass on web 🔥
web looks different?
humble mortar
<@721853658941227088> insane
dont talk to me 🤚
austere wolf
vesktop so goated
ffi-rs shouldn't be merged in its current state
it's super confusing and inconsistent
humble mortar
windows users in shambles
austere wolf
i could rewrite the koffi pr since it's a little odd but koffi seems like a better replacement for ffi-napi
ffi-napi was super consistent and easy to understand and use but it's DEAD
mostly because they had a well-defined way to handle pointers
and a LOT of pre-defined types
ffi-rs and koffi both lack this unfortunately
koffi has wayyyy more documentation tho at least
austere wolf
everything is FUCKED everybody SUCKS
floral ledge
good news @humble mortar @scenic hollow global shortcuts are in gnome
looking like it will make it into gnome 48
its in the release candidate
they bypassed the freeze for it
simple groveBOT
humble mortar
good news <@721853658941227088> <@339669513912057857> global shortcuts are in gn...
yopppp
carmine drum
vesktop issues are horror
its all "i can't get screensharing to work" and its literally always a system issue
humble mortar
downside of linux unfortunely
two billion system configurations with over half being broken or misconfigured
hot juniper
its all "i can't get screensharing to work" and its literally always a system is...
yes
next sundial
@vernal lintel do you know which flags are needed for H.265
--enable-features=CanvasOopRasterization,VaapiVideoDecoder,UseChromeOSDirectVideoDecoder,VaapiIgnoreDriverChecks,PlatformHEVCDecoderSupport,Vulkan,DefaultANGLEVulkan,VulkanFromANGLE
I believe only two or three of them are really needed
my idea is to check which ones are needed and then enable it by default and see if users report issues with them
austere wolf
next sundial
I think that not having H.265 support out-of-the-box is bad :(
vernal lintel
spoiler: it depends on your gpu so you do need every single flag to work on most gpus
next sundial
but video is frozen
next sundial
spoiler: it depends on your gpu so you do need every single flag to work on most...
amd gpu here
it's fine for me it we only enable it for, say, amd gpus on linux
at least that's some progress
vernal lintel
with amd you need vulkan and ChromeOSDirectVideoDecoder and probably PlatformHEVCDecoderSupport
next sundial
(considering they're stable)
next sundial
with amd you need vulkan and ChromeOSDirectVideoDecoder and probably PlatformHEV...
will try
austere wolf
this package is so awesome we should depend on it for windows streaming
next sundial
with amd you need vulkan and ChromeOSDirectVideoDecoder and probably PlatformHEV...
tested here
so, from my testing, you need at least those flags to make video+audio work correctly:
--enable-features=VaapiIgnoreDriverChecks,Vulkan,DefaultANGLEVulkan,VulkanFromANGLE
other flags are not necessary
Fedora 41, KDE, Wayland, AMD GPU with RADV driver
without VaapiIgnoreDriverChecks only audio works
austere wolf
this package is so awesome we should depend on it for windows streaming
orrrrrr i could add a windows binary to venmic coded in rust depending on this crate https://crates.io/crates/wasapi
next sundial
other flags are not necessary
CanvasOopRasterization,VaapiVideoDecoder,UseChromeOSDirectVideoDecoder,PlatformHEVCDecoderSupport
I believe VaapiVideoDecoder was superseded by a new flag in Vesktop if I'm not mistaken, so we already have it
even though UseChromeOSDirectVideoDecoder and PlatformHEVCDecoderSupport are not needed, maybe adding them would cover some edge case I am not aware of, and I didn't see any downside while using them
CanvasOopRasterization - IDK why someone would need this
austere wolf
what the fuck is a canvas oop rasterization