#๐Ÿ–ฅ-vesktop-development

1 messages ยท Page 16 of 1

humble mortar
#

322 used the cli

#

cli is the easiest and doesnt drag in any dependencies

grizzled hemlock
#

is it possible to check the current vesktop version from inside vesktop? ive looked everywhere, but cant find it

grizzled hemlock
next sundial
#

go to Discord user settings and scroll down

grizzled hemlock
next sundial
#

xd

#

np

simple groveBOT
#

Discord Account

No response

Operating System

Fedora 40 KDE Plasma Spin

Linux Only ~ Desktop Environment

KDE Plasma Wayland

What happens when the bug or crash occurs?

Attempting to screenshare results in nothing happening, this seems to have happened after a recent update to Fedora around KDE 6.0.9 iirc. It also might've been caused by an update to Discord too.

What is the expected behaviour?

The screenshare works

How do you recreate this bug or crash?

  1. C...
humble mortar
#

ive implemented a horid unread badge thing but the double (1) is annoying as hell grrr

#

how the hell do i kill

viral oyster
#

try patching whatever sets the title

simple groveBOT
humble mortar
#

ok real notification badge via dbus

#

hm should the tray have it as a number badge or a baked in circle to match stock

humble mortar
simple groveBOT
humble mortar
#

1984 two spelling errors

hybrid fjord
humble mortar
hybrid fjord
#

Oh

hybrid fjord
humble mortar
#

well theres two options

#

bake the badge into the tray icon which is what #261 does

#

or linux only use an overlay badge which telegram desktop does

hybrid fjord
#

I think for Linux only we should use Linux overlay badge

simple groveBOT
humble mortar
vernal lintel
#

why

#

u can dynamically create the image with canvas

humble mortar
humble mortar
# simple grove

why would the browser pass that ๐Ÿ˜ญ๐Ÿ˜ญ (tmrw I'll implement your suggestions I just turned off my laptop)

hybrid fjord
humble mortar
vernal lintel
#

happens

#

and that's a sandbox escape

#

very bad

humble mortar
#

vesktop is rat that executes remote code on your pc

vernal lintel
#

i don't think you get the point

humble mortar
#

I do ๐Ÿ˜ญ

vernal lintel
#

the browser is sandboxed for a reason, adding an ipc method with arbitrary shell execution makes that pointless

humble mortar
#

I'm being silly I know its a bad thing

simple groveBOT
vernal lintel
#

use application
works fine
update system. do not update application
application stops working
hmmm today i will blame innocent application clueless

simple groveBOT
#

Hi, I have the exact same issue on Arch Linux using Gnome 46.2 and Mutter (Wayland). The exact reason this happens on Gnome is when you close Vesktop to the system tray in one virtual desktop and then move to another virtual desktop and try open Vesktop from it's ".desktop" file. It doesn't seem to detect Vesktop is still a running application if you open it from a different virtual desktop so it will open a duplicate (that tends to also be logged out from your accounts for some reason). This...

simple groveBOT
simple groveBOT
simple groveBOT
hybrid fjord
#

hehe

#

.ico icons not loading on linux so i coverted them to .png of 48x48 and prob remove .icos
edit: i'll remain icos and just add svgs

#

mmaaaaybe i can manually make .svgs for this numbers badges and replace color too

hybrid fjord
#

this from svg and applied custom color

#

need to change font + check if color is too bright then make text black

#

okay, main problem with .svg that user can have diff font and all breaks

#

need to use pathshusk

hybrid fjord
#

badge text is now black when background too bright

simple groveBOT
azure verge
#

hewhehwoqdireihrdihwouejhr @upper pine i went out of my way to ask what they do in the C++ class at my uni and then decided against taking it because ew c++ ๐Ÿคฎ (also its laughably simple)

upper pine
azure verge
#

this is

#

not hard

#

ever heard of a match statement

upper pine
#

Lmao

#

I mean you gotta start somewhere, not everyone has prior experience

azure verge
#

dont tell me C++ doesnt have match statements or something

#

yea ofc

upper pine
#

What semester is it offered in?

azure verge
#

its just annoying that all of the fun classes are gated behind stupid shit

#

i cant take 2d and 3d rendering pipelines and shit without taking intro to python a year prior

upper pine
#

You can also take master classes if C++'s offered there

#

That's what I did

hybrid fjord
azure verge
#

true but not only would i have to get permission to take it because its only for compsci majors

#

but id also need permission to skip the prereqs

#

which i could probably do by like

#

sending my github

#

but

#

eh

upper pine
#

I could simply register

#

No one asked

#

Got me a Job at Uni :)

azure verge
#

yeah a lot of the classes are "only comp eng majors can take this course"

#

but if i get permission they make an exception

azure verge
#

yeah

#

i can get around it but i dont wanna get around like 7 things at once with as small of a portfolio in software dev as i have

#

itd be a mess lmfao

upper pine
#

Yeah it's pretty stupid that some classes are gatekeeping

#

Oh no what's the worst that can happen

#

Someone that knows what he's doing shows up

azure verge
#

uhh probably limited seats and people joining and then taking away seats from people who need it for their major

#

hence why outside of the major you have to request permission

upper pine
#

Luckily there's really few courses that are gatekeeping at my uni (if you register early enough to get a seat)

azure verge
#

mhm

simple groveBOT
#

Hello guys!

I am also having this issue on Arch Linux.

I have installed the package through flatpak as well and it has the most recent version when I list my flatpak packages of 1.5.2

One thing I don't know how to check if the version of vencord I'm using unless it's automatically updated by Vesktop itself.

If not could someone let me know how to see the version of vencord installed and how to update it?

Discord Account

cloakingpotion3818

Operating System

Arch Linux
...

azure verge
#

i can get around most of them so im not too worried

upper pine
azure verge
upper pine
#

And even if they're over booked

#

It's like 2 people more

#

They mostly don't care

azure verge
#

fair fair

simple groveBOT
upper pine
# azure verge fair fair

But what's also a bummer is that very few universities actually offer courses with modern standards

#

I pushed my professor to use C++20 this semester for the beginners course and to teach it next semester in the advanced course

azure verge
#

niceeeeee

#

ooh my roommate is taking the C++ course

upper pine
#

Will probably also help to design the next course :D

azure verge
#

ill just ask them to forward me the assignments

azure verge
upper pine
azure verge
#

i will

#

if i remember

#

oh oh my schedule is insane
i have so much time

upper pine
# azure verge oooo woaahhhh

(also partially designed the beginners course this year, but they wanted to keep a lot of legacy stuff in which I didn't like too much)

azure verge
#

interesting

#

why

upper pine
#

And it fucks me up regardless

azure verge
#

i have so much time and its amazing

upper pine
#

Schedules are only sparse if they're gonna fuck you bad at home lol

azure verge
#

my hs was 9 classes a day, same classes every day at the same time

#

and expected you to do shit at home

azure verge
#

well

#

"bad"

#

the rest is humanities and uhh

#

an online calc course

upper pine
# azure verge why

This particular class was for eletrical engineering students (no idea if I translated that right lmao) and so the idea was that we'll have to teach C and C++ to make it useful for them... I proposed the idea of splitting C and C++ into two classes because both in one is beyond fucked, maybe they'll do it in the future tho

#

Ugh I don't want to keep writing Java

#

I'll hang myself if I ever have to touch Java Generics again

#

Fuck type erasure

#

Who in their right mind

#

Would introduce generics

#

And then type erase them

#

What the fuck is the point then

#

hey so we have added generics

#

but uhh

#

they're basically only useful for the language server

#

(ignoring type-safety checks)

azure verge
#

programming:

simple groveBOT
hybrid fjord
azure verge
#

lmfao

humble mortar
#

ok so apparenrly windows 11 has task bar/dock badges

#

I might add that to my pr

#

alsoi found a Mac program called "doll" which adds tray badges

marsh hinge
humble mortar
#

yehah

marsh hinge
#

thay exists in w10 and even w7 iirc

#

and maybe even before that

#

theyre hidden if ur taskbar is set to small

#

or explicitly disabled

humble mortar
#

from my googling it says its win11 only?

marsh hinge
#

what the fuck ๐Ÿ˜ญ

humble mortar
#

I might need to virtual mahlchine

hybrid fjord
#

Bc I added badges to tray icon

humble mortar
#

no no

marsh hinge
#

heres a w10

#

ss

#

show badges on taskbar buttons

humble mortar
humble mortar
marsh hinge
#

nah its been in w10

humble mortar
#

I swear it wasnt a thing b4

marsh hinge
#

its even been in w7 im pretty sure

hybrid fjord
marsh hinge
#

i used to use discord back around win 7

hybrid fjord
#

Bc I'm confused in these names

humble mortar
humble mortar
#

tray is the little icons

#

tray is what youre enhancing in your pr

marsh hinge
#

thats what u mean

simple groveBOT
#
marsh hinge
#

then ye maybe a w11 feature

hybrid fjord
#

Nothing will break then

marsh hinge
#

but discord has had individual notification icons in their folder

#

not full but just the red circle

#

always

humble mortar
#

yep

#

so that option you have on win10 must be back ported

marsh hinge
#

nop ive used w10 for most of my life

#

and when doing stuff with discord

#

it was the same before w11

humble mortar
#

why the hell does discord bake it into their icon then??

#

why does electron not support this???

marsh hinge
#

๐Ÿ˜ญ

humble mortar
#

average electron slowness

#

ok so all 3 platforms have taskbar number badges

#

so why have a badge in the tray?

#

actually

#

is the tray badge for unreads or pings

marsh hinge
#

i never pay attention to it

#

but pretty sure its just unreads

humble mortar
#

so it shouldn't have a number in the tray

marsh hinge
#

nop

humble mortar
#

@hybrid fjord time to explode your code ๐Ÿ˜ญ

marsh hinge
#

also i dont think the number would be very readable

humble mortar
#

hm true

marsh hinge
#

if it was in the tray

hybrid fjord
humble mortar
#

Your hard work reduced to ashes

hybrid fjord
simple groveBOT
humble mortar
#

@marsh hinge can u confirm vesktop bakes the badge into the icon on windows

marsh hinge
#

just cause theres some plugins i use that dont work on web version

humble mortar
#

explod

simple groveBOT
hybrid fjord
#

I don't have electricity rn ๐Ÿ˜ฆ

marsh hinge
humble mortar
# simple grove

@vernal lintel spotify manages to set it so it must be there

hybrid fjord
marsh hinge
#

ah makes sense

vernal lintel
humble mortar
#

GWUH

#

CEF?

marsh hinge
#

they dont?

hybrid fjord
#

What they use xd

marsh hinge
#

i mean obs told me they use electron even

#

๐Ÿ˜ญ

vernal lintel
marsh hinge
#

ah

humble mortar
vernal lintel
#

and yes spotify is using cef

#

obs also seems to be using CEF, not electron

humble mortar
#

heroic games launcher is also missing the tray name

marsh hinge
#

i added spotify as game capture on obs to capture spotify audio and it told me its electron iirc

humble mortar
#

electron hill issue ig

hybrid fjord
# marsh hinge what happens to ur electricity every day

And for me I have blackouts only for around 2-3 hours 2-3 times per day so it's good for me
At least I have FTTH and UPS for router so I have internet while blackout
I wish I had laptop for work but spending much money for just 2-3 hours not feels right xd

marsh hinge
#

sucks ig

#

thats 4-9 hours a day without electricity

#

is this during the day or 24h

vernal lintel
#

bro i alr go crazy without internet for an hour

#

how do u go fully without elecricity

#

every day

marsh hinge
#

i have mobile data so i always have internet within city

#

and a bit outside city

hybrid fjord
# marsh hinge sucks ig

It's okay for me
Today I had blackout at 1-3 am, 8-10am, and 7-9pm (enabled few minutes ago)
At night I was sleeping, at morning I was at university xd

hybrid fjord
marsh hinge
#

ah

hybrid fjord
#

Our IPSs providing internet to houses while blackout

#

So we as customers need just to power in router and PON terminal

vernal lintel
#

oh

hybrid fjord
#

windows tray icon sucks

humble mortar
#

ya should just be a circle

hybrid fjord
#

everywhere?

humble mortar
#

wdym everywhere

hybrid fjord
#

linux/macos

humble mortar
#

yeah i think so

hybrid fjord
#

Rebooting finally xd

marsh hinge
#

on an unread

humble mortar
#

and is the taskbar badge only for pings/dms

marsh hinge
vernal lintel
#

need to improve

marsh hinge
hybrid fjord
humble mortar
#

do we want to follow that behaviour on mac/win10+

#

does mac support numbers

#

rn it just puts a dot

marsh hinge
#

a dot is better than nothing ๐Ÿ™

vernal lintel
sour muralBOT
# vernal lintel it alr has special handling https://github.com/Vencord/Vesktop/blob/main/src/mai...

appBadge.ts: Lines 24-48

export function setBadgeCount(count: number) {
    switch (process.platform) {
        case "linux":
            if (count === -1) count = 0;
            app.setBadgeCount(count);
            break;
        case "darwin":
            if (count === 0) {
                app.dock.setBadge("");
                break;
            }
            app.dock.setBadge(count === -1 ? "โ€ข" : count.toString());
            break;
        case "win32":
            const [index, description] = getBadgeIndexAndDescription(count);
            if (lastIndex === index) break;

            lastIndex = index;

            // circular import shenanigans
            const { mainWin } = require("./mainWindow") as typeof import("./mainWindow");
            mainWin.setOverlayIcon(index === null ? null : loadBadge(index), description);
            break;
    }
}
humble mortar
#

yeah im looking at it rn

#

im asking how it behaves

#

ok oko ok

#

so theres two settings

#

Mention badge

#

and

#

Unread badge

#

Mention badges are the numbers

#

Unread is the dot

#

so currently mac support is only the dot but its controlled via the mention toggle

#

which is wrong

vernal lintel
#

no

#

vesktop handles it correctly

sour muralBOT
# vernal lintel https://github.com/Vencord/Vesktop/blob/main/src/renderer/appBadge.ts#L19-L27

appBadge.ts: Lines 19-27

const mentionCount = GuildReadStateStore.getTotalMentionCount();
const pendingRequests = RelationshipStore.getPendingCount();
const hasUnread = GuildReadStateStore.hasAnyUnread();
const disableUnreadBadge = NotificationSettingsStore.getDisableUnreadBadge();

let totalCount = mentionCount + pendingRequests;
if (!totalCount && hasUnread && !disableUnreadBadge) totalCount = -1;

VesktopNative.app.setBadgeCount(totalCount);
hybrid fjord
#

cookie you can pull, now it shows only circle

#

and we can change color ^^

humble mortar
#

behaviour is wrong

#

it should be unreads

#

not mentions

humble mortar
#

someone buy me a mac

#

(real)

hybrid fjord
humble mortar
#

check for -1

#

it sets it to -1 in appbadge when theres unreads

hybrid fjord
#

OOOH WHAT

humble mortar
#

youll need to comment out the linux badge setting code

#

itll be replaced anyway

#
    lastBadgeCount = count;
    switch (process.platform) {
        case "linux":
        //    if (count === -1) count = 0;
        //    app.setBadgeCount(count);
            break;
        case "darwin":
            if (count === 0) {
                app.dock.setBadge("");
                break;
            }
            app.dock.setBadge(count === -1 ? "โ€ข" : count.toString());
            break;
        case "win32":
            const [index, description] = getBadgeIndexAndDescription(count);
            if (lastBadgeIndex === index) break;

            lastBadgeIndex = index;

            // circular import shenanigans
            const { mainWin } = require("./mainWindow") as typeof import("./mainWindow");
            mainWin.setOverlayIcon(index === null ? null : loadBadge(index), description);
            break;
    }
    if (count === -1)
        mainWin.webContents.send(IpcEvents.SET_CURRENT_VOICE_TRAY_ICON);
}```
hybrid fjord
#

Okay

#

At least hardest part is implemented

humble mortar
#

i find it so strange that linux doesnt have a dot option

#

i could make it show as a zero for unreads trol

#

does typeof count === "number" have any special cases where its not actually a number but still returns true

hybrid fjord
hybrid fjord
#

oki

humble mortar
#

should add a note in the commit that the commented out lines are temp to be replaced by #686

#

or rebaced onto if 686 is merged first

hybrid fjord
#

Comment*

#

Can I do it later a bit or you need it rn?

humble mortar
#

nah doesnt matter

#

take ur time

#

@vernal lintel your second comment on 686 - how is it not robust? dbus commands shouldnt* change often and even if they did an array would need to be updated as well

simple groveBOT
humble mortar
#

passing a negative number results in a dash

hybrid fjord
#

flatlined

simple groveBOT
humble mortar
#

best we are getting for unread badges on linux is that dash i think

hybrid fjord
#

You wanted just empty circle?

humble mortar
#

or a dot

hybrid fjord
#

What about numbers?

#

Looks like there's a lot of space for numbers

humble mortar
#

unread not mentions

hybrid fjord
#

Ohh

humble mortar
#

mentions have numbers

#

best i can do for unreads is a 0 or a dash

#

0 just looks odd

hybrid fjord
#

Can we set custom text to it? "_" is you specified?

humble mortar
#

no, no custom text

#

the dash comes from setting a negative number

hybrid fjord
#

only valid reaction to this situation

humble mortar
#

real

#

i think thge best option would be to add a toggle between the title text based unread/mention indicator or the badge

#

actually

#

does it really matter

#

the tray will have an unread indicator

hybrid fjord
#

How does it all work on stock discord on windows?

humble mortar
#

its baked into the icon

#

but windows has proper badge support

#

so discord devs are just ba

hybrid fjord
hybrid fjord
# humble mortar

Isn't this circle controlled by theme? Maybe with other theme this 0 will not be looking odd?

humble mortar
#

its font based

#

what the

#

trying to stream from the pnpm start client crashes

#

its using its own electron

#

prob why

#

werid

#

message requests dont count towards the mention count

#

is that intentional

hybrid fjord
#

okay so
pushing this?
but after this for some time badge at tray icon will be broken. Thats good?

humble mortar
#

tray will work fine

hybrid fjord
#

yes it is

#

works great

humble mortar
hybrid fjord
#

xdd

humble mortar
#

it can display any text it just doesnt want to

#

grr

hybrid fjord
#

here some questions/marks:

  1. It does support custom icons now
  2. Do i actually need to set system accent color as default?
humble mortar
#

thats what you do for windows and mac right?

#

also is there any way to reset it back to the system accent

hybrid fjord
#

no, it defaults to discord standart color (~)

humble mortar
hybrid fjord
#

tested on windows but setting accent color for tray looks like shit

humble mortar
#

windows moment

hybrid fjord
#

bc taskbar is tray color too and it just merges

#

wonder whats going on on macos

#

@brave tendon can you take a look?

#

is there even something like accent color on MacOS lol

brave tendon
#

Yeah accent color does exist on Mac

#

I'll check it out in a bit

simple groveBOT
hybrid fjord
#

maybe bake to icon too....

humble mortar
hybrid fjord
#

xdddd

humble mortar
#

windows and mac both dont need to do that

hybrid fjord
#

lol for plasma we can get accent color from here

#

it's returning decimal value which converts to hex of FF7357AB in mine case
and its indeed my accent color

#

is there is something for gnome and other DEs?

humble mortar
#

JUST USE THE DBUS

#

dont do a de specific access method

hybrid fjord
#

i don't have this new entry T_T

humble mortar
#
gdbus call --session --dest org.freedesktop.portal.Desktop --object-path /org/freedesktop/portal/desktop --method org.freedesktop.portal.Settings.Read 'org.freedesktop.appearance' 'accent-color'
hybrid fjord
#

oh shit it's accent color

#

my bad

humble mortar
hybrid fjord
#

its some online site

humble mortar
#

no the dbus thing

hybrid fjord
#

D-Feet

hybrid fjord
humble mortar
#

its not very much repeated code

#
                execFile ("gdbus", [
                    "emit",
                    "--session",
                    "--object-path",
                    "/",
                    "--signal",
                    "com.canonical.Unity.LauncherEntry.Update",
                    "application://vesktop.desktop",
                    `{\'count\': <int64 ${count}>, \'count-visible\': <${visible}>}`
                ]);
            }```
hybrid fjord
#

but may be in future i think

humble mortar
#

you need to pass the options anyway

vernal lintel
#

don't overengineer

#

can always reactor if needed later

hybrid fjord
#

oki

brave tendon
# hybrid fjord <@302266697488924672> can you take a look?

All custom icons/default icons work correctly for MacOS 14.5, and do not look out of place in the macOS tray. Accent color works correctly and correctly defaults to system accent color.

A few things:

  • Tray setting did not apply until toggled off/on again
  • Accent color setting did not apply until a different color was selected, and then I could set it back
hybrid fjord
#

wha

brave tendon
#

When I booted up vesktop, there was no tray even though the switch was enabled, i had to toggle it

hybrid fjord
#

ooh you mean that

#

you just updated or first first launch?

humble mortar
#

yyeah the first launcher after update is scuffed

brave tendon
#

just updated

hybrid fjord
#

i don't really know how to fix that
i can't just write if(settings.tray == false) settings.tray = true on startup for showing all settings

humble mortar
#

if true set to false then true

#

trol

brave tendon
#

you could check if its undefined

#

and just set it as a boolean if it is undefined, which would only occur on first launch

hybrid fjord
#

okay, but how to reproduce it xddd

brave tendon
#
rm -r ./Vesktop
git clone -b tray-icon https://github.com/PolisanTheEasyNick/Vesktop
#

scuffed

#

actually

#

that wouldnt work because config stays

hybrid fjord
#

rm -rf ~/.config/Vesktop
start default vesktop, close
start branch

brave tendon
#

this is honestly such a minor issue that i dont know if its worth the code that may be required

#

but the undefined check should work

hybrid fjord
#

yeah and do not think that i must add something bc it will run on every every start just for like one moment

brave tendon
#

electron app micro-optimization husk

hybrid fjord
#

yohooo

#

tf with icons๐Ÿ˜ญ

#

should i remove white circle from badge?

hybrid fjord
#

now accent color is using by default on first first launch

humble mortar
#

me when i reply with an emoji thats available as a reaction

humble mortar
hybrid fjord
#

there is

#

thats not mine idea i dunno tf is that

humble mortar
#

thats for the windows badges

hybrid fjord
#

yeap but why 9+ why not just for 10 use circle

humble mortar
hybrid fjord
#

.svg i'm using for including to tray
and since user can pick custom colors then it may look like this:

hybrid fjord
humble mortar
#

maybe allow the user to provide a custom unread icon

hybrid fjord
#

explod

#

me

#

maybe user can just
"naaaaaah its too dark, lemme pick more brighter"
and then pick something like that

#

and live happy life

humble mortar
hybrid fjord
#

i need some rest xd

#

but actually from my side i want to add .svg icons loading

#

and then major relook at all sctructure and optimize as best as can

#

how do you plan to merge all this prs in one?

#

with closing PRs

#

or you will just close issue when all be merged xd

humble mortar
#

close everything ig

#

idk

hybrid fjord
#

maybe we should create at original Vesktop repo another branch like tray icons

#

and merge all PRs to that branch

#

and fix all things there

#

and then merge that to main

#

ooor as long as my PR looks like not be conflicting with other PRs then we maybe can just push it to main when it's ready???

humble mortar
#

your pr supersedes like all theother prs except the splash one

hybrid fjord
#

i have feeling that splash pr will not conflict with mine

humble mortar
#

i dont think it would

brave tendon
#

yeah just use your PR

humble mortar
#

guh i cant get vesktop to start in my vm

next sundial
humble mortar
#

no

brave tendon
#

holy shit

#

KDE update and the disable middle click paste finally works in vesktop

simple groveBOT
vernal lintel
#

why is kde so broken

#

so many issues

brave tendon
#

better than gnome in my experience :/

vernal lintel
#

broken icon
broken screenshare after update
etc

#

0 of these happen for me on gnome

brave tendon
#

i havent experienced the broken icon/screenshare but i know that kde is typically regarded as the buggier DE

#

need to try gnome again tbh

humble mortar
#

screen share has been working fine for me on KDE

#

I have no idea why its so broken for these peopel

#

Oh something ive been wondering

#

why is the flatpak and default vesktop icon different

brave tendon
#

is it?

humble mortar
#

wait

vernal lintel
#

it's not

humble mortar
#

huh

#

aur packager thing

#

wheres the application icon

#

build/icon.icns

#

that isnt a format that can be used

vernal lintel
#

it is tho

#

thats what the flatpak and appimage and such use

humble mortar
#

ive never seen that format used in a .desktop entry

#

yeah its 100% not supported

#

in the deb its extracted into its individual files

#

hm that fails on all but 3 of the sizes

compact frigate
humble mortar
#

might be best to provide the icons in a zip for other packagers

vernal lintel
humble mortar
#

yeah the native build process deals with the icons correctly somehow but other packagers are just out of luck guh

#

wait huh

#

the nix pkg uses libicns

#

let me ask my nix using friend something

#

nix ships an unstable version of libicns

#

which is understandable considering theres been no tag in years

humble mortar
#

even the latest commit (2022) which the nixpkg uses it still fails to extract the 16x16 and 48x48

#

provide the pngs in a zip pretty please

marsh hinge
#

I know this might be pointless to have, but is it possible for Vesktop to support animated Webp/Apngs. Im not sure why but animated Webp's and APNG's are supported in the chrome browser, but whenever i upload it to Discord it doesn't want to load. It's not like the webp's are sanitized to no longer be animated after it's uploaded because you can download them afterwards.. I truly think Discord is dumb for not allowing animated Webp's.. They're far superior to gifs

vernal lintel
#

vesktop supports it just fine

#

it's just that discord doesn't

marsh hinge
#

Ohh, damn i thought there'd be a way to change how stuff is interpreted.. im not smart with this kinda stuff tbh ๐Ÿ˜ญ

vernal lintel
#

its impossible to support apng, but possible to embed awebp

#

it's just kinda pointless cause it won't embed for anyone else

marsh hinge
#

Good point ๐Ÿ˜”

grizzled hemlock
#

not sure if this is a bug, but with the vesktop quick css editor on linux, lines are terminated with crlf instead of just lf

#

also idk where to report this

grizzled hemlock
#

annoying when pasting

vernal lintel
#

idgi

#

youre right lol

#

why tf is it CRLF

grizzled hemlock
#

also this didnt used to happen

vernal lintel
#

before when?

#

today?

#

i updated monaco to latest version.

grizzled hemlock
#

i updated my dev build today

#

i will check with old monaco

vernal lintel
vernal lintel
#

why is it annoying?

grizzled hemlock
grizzled hemlock
#

fixed this for myself, leaving it here if anyone else comes looking for this

// in src/main/monacoWin.html
// after var editor = monaco.editor.create(/*stuff*/);
if(window.navigator.userAgent.includes("Linux")){
    const model = editor.getModel();
    model.pushEOL(monaco.editor.EndOfLineSequence.LF);
}
vernal lintel
#

we could do this

#

in vencord

grizzled hemlock
#

idk if mac also uses CRLF

grizzled hemlock
simple groveBOT
simple groveBOT
#

Discord Account

mflyx

Operating System

Windows 11

Linux Only ~ Desktop Environment

No response

What happens when the bug or crash occurs?

This bug basically occurs all the time. It shows wrong activity in my profile, sometimes it shows an activity that is kinda right, but it should'nt show it, for example - FPS Monitor. It says that I am playing FPS Monitor. Sometimes it shows that I play "Last man standing" (I dont even know this game)
![k7n2wyoz](https://github.com...

hybrid fjord
#

.svg picking cooked

simple groveBOT
hybrid fjord
#

517 exploded, now need many many many reviews for this shitty code xd

simple groveBOT
simple groveBOT
humble mortar
hybrid fjord
#

hm

#

actually they can but i dunno how it will work in tray

humble mortar
#

see if it explodes lmao

hybrid fjord
#

it will be just first frame

#

bc it converts to png

#

bc electron not supports svg

golden cypress
humble mortar
hybrid fjord
#

nativeImage supports only png and jpeg

#

And ico on windows

simple groveBOT
#

i'm having the same issue - using the vscode RPC extension, i get this error.

2024-06-22 17:56:06.405 [error] TypeError: Cannot read properties of null (reading 'write')
	at IPCTransport.send (/home/nex/.vscode/extensions/icrawl.discord-vscode-5.8.0/dist/extension.js:2:24881)
	at /home/nex/.vscode/extensions/icrawl.discord-vscode-5.8.0/dist/extension.js:2:24968
	at new Promise (<anonymous>)
	at IPCTransport.close (/home/nex/.vscode/extensions/icrawl.discord-vscode-5.8.0/dist/extensi...
grizzled hemlock
#

Is there a reason why volume booster doesn't work on vesktop

hybrid fjord
#

webrtc

simple groveBOT
next sundial
compact frigate
#

is it possible to install two seperate vesktop instances on windows?

#

nvm i can do portable

#

aw it just focuses the main window

#

discord canary it is :c

grizzled hemlock
#

Is vesktop available as a portable exe

next sundial
grizzled hemlock
#

Nice

next sundial
#

but I haven't used it

hybrid fjord
azure verge
#

i havent found anything

#

tbh

#

been kinda busy

#

i am fear

upper pine
#

Why does the print quality look so ass lmao

simple groveBOT
marsh hinge
#

These two exit buttons quit the entirety of Vesktop, which is perfectly fine. But I ask is this something that was intentional and is here to stay in the future? If I'm using dropdowns on a foreground window, I usually expect the first dropdown on the foreground window to close itself. It's not really a bug or glitch, more-so a design choice

#

I think it's perfectly fine that the VESKTOP dropdown closes VESKTOP. I just think it should be further right, and Window should be first

upper pine
#

I have never seen that window

marsh hinge
#

i think its a new thing/experimental

upper pine
#

How do you open that?

marsh hinge
upper pine
#

Ah interesting

marsh hinge
#

oh shit one sec im dumb

#

thats in the Vesktop settings

#

at the very bottom

torpid ocean
# marsh hinge

it also does that for connections > add account if you have it off

simple groveBOT
simple groveBOT
#

@ToxicMushroom The unread count isnt actually "0" in this case. Theres two distinct badge modes; unreads and mentions. Mentions are what have the number count and only shows up for pings and DMs, etc.

Unreads are when there is a message in a channel that you do not have muted. Users can disable the unread badge but still have the mention badge.

The reason why the unread badge shows a "0" is due to a limitation with the Launcher API it can only show 0-9 with no option for blank badge o...

#

Content

The .icns format on Linux is not well support and extracting the pngs from said format is impossible to do fully.

libicns (the library which provides icns2png) has not had a stable release in 12 years and only manages to extract two large icons from the icon.icns. Latest git is a bit better and only fails for ic04 and ic05 but again, doesnt work fully.

I'm making this as vesktop/-git on the aur uses build/icon.png which is notably not the Vesktop icon but ...

simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
#

Discord Desktop logic (cleaned up & simplified, search for "IdleStore to find this in code):

function isSystemIdle() {
  return suspended || locked || (isAndroid() && idkIrrelevantWhoCares);
}

function checkIdleNative() {
	let checkIdleTime = t => {
	    idleSince = Math.max(Date.now() - t, idleSince),
	    checkIdleAFK(),
	    setTimeout(checkIdleNative, 10 * d.Z.Millis.SECOND)
	}
    DiscordNative.remotePowerMonitor.getSystemIdleTimeMs()
		.then(checkIdleTime);
}

c...
scarlet furnace
#

@hot juniper Keep getting the message "Failed to connect to arRPC" ๐Ÿ™ƒ

#

I assume this is a Linux thing?

hot juniper
#

this is dev chat not support blobcatcozy

scarlet furnace
#

Whoops ๐Ÿฅฒ

vernal lintel
#

wtf is a VeskTop

marsh hinge
#

RobTop

simple groveBOT
vernal lintel
#

is it even possible for apps to change their own icon

hot juniper
#

yes

simple groveBOT
hot juniper
#

windowsism real

hybrid fjord
humble mortar
# simple grove

no other program provides this ๐Ÿ˜ญ๐Ÿ˜ญ๐Ÿ˜ญ

#

its literally up to the DE

hot juniper
vernal lintel
#

honestly im still unsure if we should even provide option to change the icons

#

name one program that provides this option

#

why should we

hot juniper
#

(on desktop)

#

mobile apps including discord do it though

#

mostly as a premium subscriber perk

vernal lintel
#

we should just improve the current icons to not be as scuffed

humble mortar
#

idk I like the idea of changing tray icons without having to use an icon theme

vernal lintel
#

well some DEs provide options to change it

#

eg kde

#

it currently doesn't work because of chromium moment but sorrykirino

humble mortar
humble mortar
#

bros just lazy

simple groveBOT
#

Discord Account

mora_unie_youer

Operating System

NixOS 24.11.20240531.57610d2 (Vicuรฑa)

Linux Only ~ Desktop Environment

Niri (Wayland)

What happens when the bug or crash occurs?

Audio Sources in Screenshare window do not show anything but Pulseaudio sources.

image

As an example I can provide MPV, but for example osu!lazer and something else is not being shown too.

(MPV i...

hybrid fjord
humble mortar
simple groveBOT
grizzled hemlock
#

where could i get the ARRPC logs for vesktop

#

cant find them in the console

vernal lintel
sudden trout
#

mean Pout

simple groveBOT
#

Anyway, when I start mpv, it is detected by venmic, but nothing is shown in screensharing window
<details>
<summary>Part of console log with venmic debug enabled</summary>

[2024-06-23 20:48:15.525] [venmic] [trace] [patchbay] (add_global) new global: 267 (type: "PipeWire:Interface:Client")
[2024-06-23 20:48:15.526] [venmic] [trace] [patchbay] (add_global) new global: 212 (type: "PipeWire:Interface:Node")
[2024-06-23 20:48:15.526] [venmic] [trace] [patchbay] (handle) new node: 212 ...
next sundial
#

what's still pending for a new Vesktop release?

simple groveBOT
#

I'mma go ahead and bump this'n. I'm using Debian Trixie at the moment, and after a recent update, I'm getting a similar issue to OP- Along with a few other quirks that I'm unsure may or may not be related.

image

I think this confirms that it's not a Nix-Specific issue, at the very least.

I get this error when running the AppImage, and from source. Screenshare works correctly (sometimes) on fla...

simple groveBOT
#

i believe that it's for platform consistency, mac / linux icons usually have a background colour, while windows usually has icons with a transparent background

Hmm mind sharing some examples of applications that have intentionally transparent background? Most apps I use are cross platform and share the same logo across platforms

vs code, native explorer, native paint, native calculator, (also most native apps) git, firefox, and inno installer ar...

simple groveBOT
vernal lintel
vernal lintel
#

block speedrun

simple groveBOT
#

Discord Account

mora_unie_youer

Operating System

NixOS 24.11.20240531.57610d2 (Vicuรฑa)

Linux Only ~ Desktop Environment

Niri (Wayland)

What happens when the bug or crash occurs?

Audio Sources in Screenshare window do not show anything but Pulseaudio sources.

image

As an example I can provide MPV, but for example osu!lazer and something else is not being shown too.

(MPV i...

vernal lintel
#

i have already tested with mpv and it looks flawlessly

simple groveBOT
simple groveBOT
brave tendon
simple groveBOT
simple groveBOT
simple groveBOT
#

I was running into this problem earlier today where screensharing was running at around 11 FPS according to the debug window people were using above.

After seeing this comment: https://github.com/Vencord/Vesktop/issues/629#issuecomment-2136191619 I decided to "rebuild" my vesktop installation with the latest Electron 31 (31.0.2). I'm using NixOS, so it kind of worked like below. I had to use a local fork of nixpkgs as Electron 31 hasn't landed there yet:

{pkgs, inputs, ...}: l...
simple groveBOT
simple groveBOT
simple groveBOT
#

Discord Account

No response

Motivation

I see some commits for Vencord to disable renderer backgrounding.
Some of them have been implemented on Vesktop, but not all of them.

Vencord file: https://github.com/Vendicated/Vencord/blob/main/src/main/patcher.ts
Vesktop file: https://github.com/Vencord/Vesktop/blob/main/src/main/index.ts

Relevant commits on Vencord's site:
https://github.com/Vendicated/Vencord/commit/a0778f6a2e786889d11f2b627f2ac03f7696c2e5
https://github.com/V...

simple groveBOT
simple groveBOT
#

Discord Account

Soham52#0241

Motivation

It's Hard to tell whether you're connected to a vc, and everytime you need to open the client to confirm it.

Solution

Make the venktop tray icon change into the voice indicator similar to how the discord icon behaves in the tray.

Alternatives

None

Additional context

Here's how the Discord Tray Icon behaves -

https://github.com/Vencord/Vesktop/assets/73898737/ba453199-29c2-47a5-aa6c-9a86bd6c6fb4

Request Agreement...

gentle hatch
#

Venktop

upper pine
upper pine
#

No the one in the issue

#

I don't see how it would not work ootb

vernal lintel
#

most stable nixos setup

upper pine
hybrid fjord
humble mortar
simple groveBOT
simple groveBOT
simple groveBOT
hybrid fjord
#

why bro can't just change gif in project folder and write new .desktop for starting pnpm start in needed folder๐Ÿ˜ญhusk

gentle hatch
#

too much work

simple groveBOT
#

Discord Account

No response

Operating System

linux

Linux Only ~ Desktop Environment

i3

What happens when the bug or crash occurs?

if i play a game, others see my game activity, but to me it doesnt change anything, i cant see what game i am playing

What is the expected behaviour?

i would expect it that i can see the game activity too, especially so i can check if its actually detecting my game properly

How do you recreate this bug or crash?

open a game with...

humble mortar
gentle hatch
#

:3

simple groveBOT
simple groveBOT
#

--enable-wayland-ime doesn't appear to work for me, neither does forcing GTK4? I seem to have a very specific issue with this and the logs for Vesktop don't seem to tell me much about what's happening:

Passing the following arguments to Electron: --ozone-platform-hint=auto
[arRPC > ipc] listening at /run/user/1000/discord-ipc-0
[arRPC > websocket] listening on 6463
[arRPC > process] started

Is there any other logs I can provide to support this issue? I've been at it for abo...

simple groveBOT
grizzled hemlock
#

is builtin arrpc on vesktop known to be buggy

humble mortar
hybrid fjord
hot juniper
gentle hatch
#

what did you do

wary merlin
hot juniper
simple groveBOT
vernal lintel
next sundial
#

vee's sanity is going down day after day

rare beacon
#

what is vesktop?

#

an discord fork

#

?

next sundial
#

๐Ÿ’€

simple groveBOT
simple groveBOT
#

Discord Account

No response

Operating System

Arch Linux

Linux Only ~ Desktop Environment

Hyprland - Wayland

What happens when the bug or crash occurs?

If you highlight a piece of text and you try to right-click nothing happens.

What is the expected behaviour?

Should give you a bunch of options, one is to search with Google or in my case I have the ReplaceGoogleSearch (It is not the issue because I already tried removing it)

How do you recreate this bug or c...

hybrid fjord
#

V is tired for writing reason xd

gentle hatch
#

are you really that surprised โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹

gentle hatch
#

true! โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹โ€‹

simple groveBOT
#

Discord Account

kekkodance

Operating System

Windows 11

Linux Only ~ Desktop Environment

No response

What happens when the bug or crash occurs?

I use EarTrumpet, i periodically find Vesktop's volume lowered to around 50 to 66 percent for no reason, despite turning it back to 100

What is the expected behaviour?

Volume staying at the specified level

How do you recreate this bug or crash?

  1. Start Vesktop and EarTrumpet
  2. Get in a VC or do something with noi...
hybrid fjord
#

10000000% vesktop issue

simple groveBOT
#

Discord Account

retrodeg

Operating System

Kubuntu 24.04

Linux Only ~ Desktop Environment

KDE X11

What happens when the bug or crash occurs?

Not getting notification pop ups on desktop or in app. it plays the discord sound, but doesn't pop up.

What is the expected behaviour?

notification pops up

How do you recreate this bug or crash?

  1. get a notification
  2. observe

Debug Logs

Replace this text with your crash-log. Do not remove the backticks
```...
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
#

Discord Account

No response

Operating System

Windows 11

Linux Only ~ Desktop Environment

No response

What happens when the bug or crash occurs?

Happens every time. Tried restarting several times and went thru settings a few times to make sure i wasn't missing a toggle or anything.

What is the expected behaviour?

There should be a working pin icon.

How do you recreate this bug or crash?

  1. Hop on a call
  2. Pop out the call using the button next to the "f...
simple groveBOT
hot juniper
simple groveBOT
hybrid fjord
#

tf

hybrid fjord
#

Maybe we should update year in copyright?)
Everything will explode

next sundial
vernal lintel
#

^

#

the year serves as an indicator for when that file was created

#

it has 0 legal relevance

#

updating the year is pointless

next sundial
#

Copyleft ๐Ÿ„ฏ โ€” All rights reversed

next sundial
#

but Vesktop being free software it may as well be considered public domain :v

next sundial
#

it's rare for GPL violations to arise publicly and notably

vernal lintel
#

copyright expires a set number of years after your death

next sundial
#

yes

vernal lintel
#

it doesn't matter if you keep the year in the header updated

next sundial
#

the text itself is irrelevant, of course

vernal lintel
#

you hold copyright your entire life

#

even if it says copyright 2011 and it's 2050, it's still copyrighted by you

next sundial
#

copyright is, at minimum, entire life + 50 years after death

#

countries can have a higher limit if they desire

#

IIRC USA is 70 after death

#

that's why recently the first Mickey Mouse animation has entered the public domain

vernal lintel
next sundial
# vernal lintel so this makes no sense

The Berne Convention introduced the concept that protection exists the moment a work is "fixed", that is, written or recorded on some physical medium, and its author is automatically entitled to all copyrights in the work and to any derivative works, unless and until the author explicitly disclaims them or until the copyright expires. A creator need not register or "apply for" a copyright in countries adhering to the convention.

#

as soon as the thing exists, copyright is automatic

#

the year is relevant for that

vernal lintel
#

no

#

it's not

#

and if anything, changing the year is misleading

you're pretending like it was written in 2024, when in reality it was written in 2022

next sundial
#

I get what you mean

#

I don't know for sure, but I believe some things have fixed years instead of entire life plus afterlife years

#

such as patents, which expire after 20 years

#

I think there's something similar for copyright too under some circumstances

next sundial
#

but yeah it doesn't make much sense and it is irrelevant

#

even more if the program is copyleft or under a permissive license such as MIT

simple groveBOT
#

enable desktop notifications in notification settings

if it still doesn't work, system issue

i do have desktop notifications enabled, i refuse to believe it is a system issue. Every other program sends notifications just fine. INCLUDING regular discord, but i stopped using regular discord because i got tired of it never getting timely updates and/or having to manually update a deb every time i wanted to use discord

humble mortar
#

I'm on 6.1 and get notifications fine

#

only issue is clicking them doesnt do anything

#

actually has that been reported

azure verge
#

oh my god i didnt even notice

#

plasma 6.1 fixed the double screenshare picker issue when picking a single window

hybrid fjord
azure verge
#

yeah that's

#

way better

#

also sowwy i havent been here much cuz i uhh got addicted to gtnh

humble mortar
#

geuwh

#

u mean the

#

window picker portal > vesktop picker (settings) > window picker portal

#

right

brave tendon
#

Fixed for me in plasma 6.1

humble mortar
#

???? its working now

#

what the

#

and now its not after a reboot

#

huhh

#

xwayland scuff issue??

humble mortar
#

yeah it doesnt happen at all via native wayland

azure verge
azure verge
humble mortar
#

@hybrid fjord your conversion isnt exactly accurate

hybrid fjord
#

T_T

#

I'll take a look

humble mortar
#

oh

#

also

#

the dot is for unreads on stock discord

#

here its acting as a mention indicator

humble mortar
simple groveBOT
#

I am also having this issue on my Fedora system running KDE in Wayland mode.
Desktop notifications are enabled.
libnotify-0.8.3-3.fc40.x86_64 is installed.
Notifications are working on Discord Stable, Canary and PTB.

Specs/Info:

Vesktop 1.5.2
Vencord E37a0cf
Electron 29.1.1
Chromium 122.0.6261.111
Using Canary release channel

Fedora Linux 40 (KDE Plasma) x86_84
Kernal Rev. Linux 6.9.4-200.fc40.x86_64
humble mortar
#

cant i remove this as emitDBusBadge only takes a number anyway

vernal lintel
#

if it's user controlled no

humble mortar
#

wdym by user controlled

#

count is calculated from unreads and mentions which shouldn't ever be a non number

vernal lintel
#

if it's passed via ipc you need to validate it

#

simple as

humble mortar
#

i dont see the point of erroring before it reaches the function if the function would just error itself

compact frigate
#

better to give a error yourself then reach potentially untested stuff

topaz dove
#

although that log should probably be a real message

humble mortar
#

just ctrl f the code for the log duh

simple groveBOT
simple groveBOT
hybrid fjord
simple groveBOT
humble mortar
hybrid fjord
#

yeah but it literraly shows only when == -1 ๐Ÿ˜ข

humble mortar
#

is that how it works for you?

hybrid fjord
#

i tried marking all my servers as read and badge dissapears

#

and shows back when somewhere in chats someone wrote something

humble mortar
#

guh???

#

that is NOT what's happening for me

#

I'll show later

humble mortar
#

gwuh i was out of date oops

#

its not showing at all now

#

oh

#

its following this setting

#

disabling it removes the -1 setter

#

it shouldnt follow that setting

#

hm

humble mortar
#

you should just ignore main/appBadge.ts and get GuildReadStateStore.hasAnyUnread(); directly from renderer/appBadge.ts as it only sets to -1 if that toggle is on

#

@hybrid fjord

#

prob add another toggle to vesktop settings for the tray unread badge

#

iirc stock discord u cant even turn off the tray unread badge

hybrid fjord
hybrid fjord
simple groveBOT
#

Having the same issue, Vesktop seems to ignore the --enable-wayland-ime command. I'm using the Flatpak package on Arch Linux with Plasma 6.1.1 & fcitx5 configured for Japanese input.
Other Electron applications have no issues with using the IME, including the standard Discord package from the Arch repo.

next sundial
#

I think Vesktop is being tortured

hybrid fjord
humble mortar
hybrid fjord
#

Change description? xd

humble mortar
#

you can't remove the unread badge on the tray on stock discord

hot juniper
hybrid fjord
#

But I dunno, I have feeling that following app badge would be better

#

In UX terms

humble mortar
#

what if the user wants unreads in the tray and mentions on the app icon

hybrid fjord
humble mortar
#

unreads badge would show on the app icon too

#

unreads != mentions

hybrid fjord
humble mortar
#

if you have it enabled in Vesktop settings yes

hybrid fjord
#

shorter, I'll just add another one toggle for showing unread message badge
If this is enabled, then i check for -1
If disabled, then check whether it's != 0?

#

It's so fucking complicated with this all unreads and mentions
Who tf wants to see unread badge if most users have millions of muted servers where many people chatting

humble mortar
hybrid fjord
humble mortar
hybrid fjord
#

Perfectly

#

Even have function for it

humble mortar
#

yep just export from renderer/appBadge.ts

hybrid fjord
#

I will do asap, hopefully today at evening

humble mortar
#

take your time

hybrid fjord
#

Yeah but if not today then in Monday xd

#

So better today

humble mortar
#

I mean its not like the world is gonna explode if u take an extra day or two

hybrid fjord
#

Yeah but I just do not want to detain if someone or you, for example, need it for further development

humble mortar
#

well I can just make an ugly patch to get the behaviour I want in the meantime

hybrid fjord
#

xd

#

Okay and if someone DM me and chat is not muted then it's mention or unread xd

humble mortar
#

its a mention

#

which will show on the app icon

hybrid fjord
#

Good

#

Good thing that I even don't need to think about it and just use hasAnyUnread() xd

#

Bc brain explodes with all of these types

next sundial
humble mortar
#

message requests should be too but theyre not included in the count that vencord grabs #๐Ÿ‘พ-core-development message
I assume it was just forgotten when they added that feature

hybrid fjord
#

Looks like easy fixable in your PR but it needs further approve from V

humble mortar
hybrid fjord
vernal lintel
sour muralBOT
# vernal lintel are you talking about this? https://github.com/Vencord/Vesktop/blob/main/src/ren...

appBadge.ts: Lines 19-25

const mentionCount = GuildReadStateStore.getTotalMentionCount();
const pendingRequests = RelationshipStore.getPendingCount();
const hasUnread = GuildReadStateStore.hasAnyUnread();
const disableUnreadBadge = NotificationSettingsStore.getDisableUnreadBadge();

let totalCount = mentionCount + pendingRequests;
if (!totalCount && hasUnread && !disableUnreadBadge) totalCount = -1;
humble mortar
#

no

vernal lintel
#

then what

humble mortar
#

wait which part of the convo

vernal lintel
#

"message requests should be too but theyre not included in the count that vencord grabs"

#

i have no clue what you're referring to

humble mortar
#

Vencord.Webpack.Common.RelationshipStore.getPendingCount(); returns the number of mentions

#

friend requests DMS pings etc

vernal lintel
#

yes

#

so?

humble mortar
#

message requests should be included in the count

#

theyre not