#๐ฅ-vesktop-development
1 messages ยท Page 16 of 1
is it possible to check the current vesktop version from inside vesktop? ive looked everywhere, but cant find it
yes
where would i find that information
go to Discord user settings and scroll down
oh, i checked there, but i am just blind and somehow missed it
thanks for the sanity check
Discord Account
No response
Operating System
Fedora 40 KDE Plasma Spin
Linux Only ~ Desktop Environment
KDE Plasma Wayland
What happens when the bug or crash occurs?
Attempting to screenshare results in nothing happening, this seems to have happened after a recent update to Fedora around KDE 6.0.9 iirc. It also might've been caused by an update to Discord too.
What is the expected behaviour?
The screenshare works
How do you recreate this bug or crash?
- C...
ive implemented a horid unread badge thing but the double (1) is annoying as hell grrr
how the hell do i kill
try patching whatever sets the title
ok real notification badge via dbus
hm should the tray have it as a number badge or a baked in circle to match stock
@hybrid fjord handle that in your pr
Closes #298, #424, #189
remove (#) title prefix when Notification Badge option is toggled
explode scuffed option libunity dependency (kabloomed)
1984 two spelling errors
Do I need to do something if this exists?
this is for the dock/app launcher not the tray
Oh
And how to do this?
well theres two options
bake the badge into the tray icon which is what #261 does
or linux only use an overlay badge which telegram desktop does
I think for Linux only we should use Linux overlay badge
since count comes from renderer via ipc, it is an untrusted value. embedding it into an exec command is a veeery bad idea. what if the browser passes something like "$(rm -rf /*)"?
you absolutely need to validate the value to avoid sandbox escapes, e.g. via typeof count === "number"
also raw exec with string is not very robust, prefer calls that take an arg array, e.g. execFile("gdbus", ["emit", ...]). that's also more performant since it won't spawn an extra shell
I just realized if we go this route users won't have the option to change what the tray icon looks like while they have a notification
and thered need to be custom icon logic anyway for windows and Mac to keep with the rest of the pr
why would the browser pass that ๐ญ๐ญ (tmrw I'll implement your suggestions I just turned off my laptop)
Isn't Linux native badges just renders number on top of any tray icon?
yes but thered be no state to switch the icon with
due to xss / malicious code
happens
and that's a sandbox escape
very bad
vesktop is rat that executes remote code on your pc
i don't think you get the point
I do ๐ญ
the browser is sandboxed for a reason, adding an ipc method with arbitrary shell execution makes that pointless
.
I'm being silly I know its a bad thing
Not sure why this has been closed without comment? Applications like OBS, Firefox, and even the deprecated discord-screenaudio work just fine, it's currently a Vesktop only issue.
use application
works fine
update system. do not update application
application stops working
hmmm today i will blame innocent application
Hi, I have the exact same issue on Arch Linux using Gnome 46.2 and Mutter (Wayland). The exact reason this happens on Gnome is when you close Vesktop to the system tray in one virtual desktop and then move to another virtual desktop and try open Vesktop from it's ".desktop" file. It doesn't seem to detect Vesktop is still a running application if you open it from a different virtual desktop so it will open a duplicate (that tends to also be logged out from your accounts for some reason). This...
Noticed and fixed those:
Patch by Vesktop had no effect (Module id is 292959): /\.isPlatformEmbedded(?=\?[A-Za-z_$][\w$]*\.DesktopNotificationTypes\.ALL)/g
Patch by Vesktop had no effect (Module id is 897607): /([A-Za-z_$][\w$]*)\.default\.getState\(\).neverShowModal/
after the latest discord breakage & subsequent fixing, i started experiencing this issue.
๐ Grammarly has found 1 issue!
- you have to fix your systen
+ you have to fix your system
hehe
.ico icons not loading on linux so i coverted them to .png of 48x48 and prob remove .icos
edit: i'll remain icos and just add svgs
mmaaaaybe i can manually make .svgs for this numbers badges and replace color too
this from svg and applied custom color
need to change font + check if color is too bright then make text black
okay, main problem with .svg that user can have diff font and all breaks
need to use paths
badge text is now black when background too bright
hewhehwoqdireihrdihwouejhr @upper pine i went out of my way to ask what they do in the C++ class at my uni and then decided against taking it because ew c++ ๐คฎ (also its laughably simple)
What semester is it offered in?
its just annoying that all of the fun classes are gated behind stupid shit
i cant take 2d and 3d rendering pipelines and shit without taking intro to python a year prior
Bruh
That's dumb
In my university we started learning C/C++ and only on third year we learn Python xd
Started from C actually
true but not only would i have to get permission to take it because its only for compsci majors
but id also need permission to skip the prereqs
which i could probably do by like
sending my github
but
eh
You don't need permission if the course is not guarded somehow
I could simply register
No one asked
Got me a Job at Uni :)
yeah a lot of the classes are "only comp eng majors can take this course"
but if i get permission they make an exception
ah too bad
yeah
i can get around it but i dont wanna get around like 7 things at once with as small of a portfolio in software dev as i have
itd be a mess lmfao
Yeah it's pretty stupid that some classes are gatekeeping
Oh no what's the worst that can happen
Someone that knows what he's doing shows up
uhh probably limited seats and people joining and then taking away seats from people who need it for their major
hence why outside of the major you have to request permission
Luckily there's really few courses that are gatekeeping at my uni (if you register early enough to get a seat)
mhm
Hello guys!
I am also having this issue on Arch Linux.
I have installed the package through flatpak as well and it has the most recent version when I list my flatpak packages of 1.5.2
One thing I don't know how to check if the version of vencord I'm using unless it's automatically updated by Vesktop itself.
If not could someone let me know how to see the version of vencord installed and how to update it?
Discord Account
cloakingpotion3818
Operating System
Arch Linux
...
i can get around most of them so im not too worried
I've literally never seen a master class that has all seats booked

fair fair
Hello, i also have the same issue on the steam deck since this week.
Hello, i also have the same issue on the steam deck since this week.
It never happened before.
But what's also a bummer is that very few universities actually offer courses with modern standards
I pushed my professor to use C++20 this semester for the beginners course and to teach it next semester in the advanced course
Will probably also help to design the next course :D
ill just ask them to forward me the assignments
oooo woaahhhh
Let me know what standard they use lmao
(also partially designed the beginners course this year, but they wanted to keep a lot of legacy stuff in which I didn't like too much)
i have so much time and its amazing
Schedules are only sparse if they're gonna fuck you bad at home lol
my hs was 9 classes a day, same classes every day at the same time
and expected you to do shit at home
chem will be bad
well
"bad"
the rest is humanities and uhh
an online calc course
This particular class was for eletrical engineering students (no idea if I translated that right lmao) and so the idea was that we'll have to teach C and C++ to make it useful for them... I proposed the idea of splitting C and C++ into two classes because both in one is beyond fucked, maybe they'll do it in the future tho
Ugh I don't want to keep writing Java
I'll hang myself if I ever have to touch Java Generics again
Fuck type erasure
Who in their right mind
Would introduce generics
And then type erase them
What the fuck is the point then
hey so we have added generics
but uhh
they're basically only useful for the language server
(ignoring type-safety checks)
programming:
Content
as seen in the screenshot below, vesktop has no name assigned in kde plasma system tray settings. this causes it to interfere with other programs that also don't have a name set. (for example unity)
programming:
Issue without template created
lmfao
ok so apparenrly windows 11 has task bar/dock badges
I might add that to my pr
alsoi found a Mac program called "doll" which adds tray badges
u mean like the notification badges?
yehah
thay exists in w10 and even w7 iirc
and maybe even before that
theyre hidden if ur taskbar is set to small
or explicitly disabled
from my googling it says its win11 only?
what the fuck ๐ญ
I might need to virtual mahlchine
Wait, on task bar there is tray icon?
Bc I added badges to tray icon
no no
badges aren't on trays
must be back ported
nah its been in w10
I swear it wasnt a thing b4
its even been in w7 im pretty sure
Can you show it?
i used to use discord back around win 7
Bc I'm confused in these names
discord has always baked it into the taskbar icon no?
taskbar/dock and tray
tray is the little icons
tray is what youre enhancing in your pr
ah
thats what u mean
Content
as seen in the screenshot below, vesktop has no name assigned in kde plasma system tray settings. this causes it to interfere with other programs that also don't have a name set. (for example unity) 
It's okay for me
Today I had blackout at 1-3 am, 8-10am, and 7-9pm (enabled few minutes ago)
At night I was sleeping, at morning I was at university xd
Yeah but I have internet
ah
Our IPSs providing internet to houses while blackout
So we as customers need just to power in router and PON terminal
oh
windows tray icon sucks
ya should just be a circle
everywhere?
wdym everywhere
linux/macos
yeah i think so
on an unread
and is the taskbar badge only for pings/dms
its for unread and pings
i'm downscaling in canvas
linux only supports number badges so thats ok
do we want to follow that behaviour on mac/win10+
does mac support numbers
rn it just puts a dot
a dot is better than nothing ๐
it alr has special handling https://github.com/Vencord/Vesktop/blob/main/src/main/appBadge.ts#L24-L48
appBadge.ts: Lines 24-48
export function setBadgeCount(count: number) {
switch (process.platform) {
case "linux":
if (count === -1) count = 0;
app.setBadgeCount(count);
break;
case "darwin":
if (count === 0) {
app.dock.setBadge("");
break;
}
app.dock.setBadge(count === -1 ? "โข" : count.toString());
break;
case "win32":
const [index, description] = getBadgeIndexAndDescription(count);
if (lastIndex === index) break;
lastIndex = index;
// circular import shenanigans
const { mainWin } = require("./mainWindow") as typeof import("./mainWindow");
mainWin.setOverlayIcon(index === null ? null : loadBadge(index), description);
break;
}
}
yeah im looking at it rn
im asking how it behaves
ok oko ok
so theres two settings
Mention badge
and
Unread badge
Mention badges are the numbers
Unread is the dot
so currently mac support is only the dot but its controlled via the mention toggle
which is wrong
appBadge.ts: Lines 19-27
const mentionCount = GuildReadStateStore.getTotalMentionCount();
const pendingRequests = RelationshipStore.getPendingCount();
const hasUnread = GuildReadStateStore.hasAnyUnread();
const disableUnreadBadge = NotificationSettingsStore.getDisableUnreadBadge();
let totalCount = mentionCount + pendingRequests;
if (!totalCount && hasUnread && !disableUnreadBadge) totalCount = -1;
VesktopNative.app.setBadgeCount(totalCount);
guh im so bad at visualizing i need to see this in practice
someone buy me a mac
(real)
I'm getting from appBadge :((
OOOH WHAT
youll need to comment out the linux badge setting code
itll be replaced anyway
lastBadgeCount = count;
switch (process.platform) {
case "linux":
// if (count === -1) count = 0;
// app.setBadgeCount(count);
break;
case "darwin":
if (count === 0) {
app.dock.setBadge("");
break;
}
app.dock.setBadge(count === -1 ? "โข" : count.toString());
break;
case "win32":
const [index, description] = getBadgeIndexAndDescription(count);
if (lastBadgeIndex === index) break;
lastBadgeIndex = index;
// circular import shenanigans
const { mainWin } = require("./mainWindow") as typeof import("./mainWindow");
mainWin.setOverlayIcon(index === null ? null : loadBadge(index), description);
break;
}
if (count === -1)
mainWin.webContents.send(IpcEvents.SET_CURRENT_VOICE_TRAY_ICON);
}```
i find it so strange that linux doesnt have a dot option
i could make it show as a zero for unreads trol
does typeof count === "number" have any special cases where its not actually a number but still returns true
So now I:
- comment these two lines
- show badge only when count === -1
That's all?
yeah
oki
should add a note in the commit that the commented out lines are temp to be replaced by #686
or rebaced onto if 686 is merged first
I will add commit
Comment*
Can I do it later a bit or you need it rn?
nah doesnt matter
take ur time
@vernal lintel your second comment on 686 - how is it not robust? dbus commands shouldnt* change often and even if they did an array would need to be updated as well
Maybe that belongs in a new issue, but I would like the tray icon to indicate when there is a notification. Seems like a useful feature for many.
passing a negative number results in a dash
flatlined
Maybe that belongs in a new issue, but I would like the tray icon to indicate when there is a notification. Seems like a useful feature for many. Putting it hear because discords icon actually does that.
Will be in #517
best we are getting for unread badges on linux is that dash i think
You wanted just empty circle?
or a dot
unread not mentions
Ohh
mentions have numbers
best i can do for unreads is a 0 or a dash
0 just looks odd
Can we set custom text to it? "_" is you specified?
real
i think thge best option would be to add a toggle between the title text based unread/mention indicator or the badge
actually
does it really matter
the tray will have an unread indicator
How does it all work on stock discord on windows?
its baked into the icon
but windows has proper badge support
so discord devs are just ba
Devs cooked xd
Isn't this circle controlled by theme? Maybe with other theme this 0 will not be looking odd?
its font based
what the
trying to stream from the pnpm start client crashes
its using its own electron
prob why
werid
message requests dont count towards the mention count
is that intentional
okay so
pushing this?
but after this for some time badge at tray icon will be broken. Thats good?
the badge in the task bar/dock will be broken
tray will work fine
bwoa
xdd
here some questions/marks:
- It does support custom icons now
- Do i actually need to set system accent color as default?
thats what you do for windows and mac right?
also is there any way to reset it back to the system accent
no, it defaults to discord standart color (~)
then how do you suggest the accent?
just go to color picker and first color in presets will be accent color if supported
tested on windows but setting accent color for tray looks like shit
windows moment
bc taskbar is tray color too and it just merges
wonder whats going on on macos
@brave tendon can you take a look?
is there even something like accent color on MacOS lol
I need some design input regarding the unread badge option.
Do I provide an unread badge at all and if I do do i make it display a "-" or "0" (also should I strip out the โข like with the (#)
This is simply a limitation of the Launcher API unfortunately.
maybe bake to icon too....
explode kill kill
xdddd
windows and mac both dont need to do that
lol for plasma we can get accent color from here
it's returning decimal value which converts to hex of FF7357AB in mine case
and its indeed my accent color
is there is something for gnome and other DEs?
i don't have this new entry T_T
gdbus call --session --dest org.freedesktop.portal.Desktop --object-path /org/freedesktop/portal/desktop --method org.freedesktop.portal.Settings.Read 'org.freedesktop.appearance' 'accent-color'
what even is this ui
its some online site
no the dbus thing
D-Feet
i think someone of us should create some function for DBus calls
its not very much repeated code
execFile ("gdbus", [
"emit",
"--session",
"--object-path",
"/",
"--signal",
"com.canonical.Unity.LauncherEntry.Update",
"application://vesktop.desktop",
`{\'count\': <int64 ${count}>, \'count-visible\': <${visible}>}`
]);
}```
but may be in future i think
you need to pass the options anyway
oki
All custom icons/default icons work correctly for MacOS 14.5, and do not look out of place in the macOS tray. Accent color works correctly and correctly defaults to system accent color.
A few things:
- Tray setting did not apply until toggled off/on again
- Accent color setting did not apply until a different color was selected, and then I could set it back
wha
When I booted up vesktop, there was no tray even though the switch was enabled, i had to toggle it
yyeah the first launcher after update is scuffed
just updated
i don't really know how to fix that
i can't just write if(settings.tray == false) settings.tray = true on startup for showing all settings
you could check if its undefined
and just set it as a boolean if it is undefined, which would only occur on first launch
okay, but how to reproduce it xddd
rm -r ./Vesktop
git clone -b tray-icon https://github.com/PolisanTheEasyNick/Vesktop
scuffed
actually
that wouldnt work because config stays
rm -rf ~/.config/Vesktop
start default vesktop, close
start branch
this is honestly such a minor issue that i dont know if its worth the code that may be required
but the undefined check should work
yeah and do not think that i must add something bc it will run on every every start just for like one moment
electron app micro-optimization 
now accent color is using by default on first first launch
me when i reply with an emoji thats available as a reaction
isnt there the 11.ico badge
thats for the windows badges
yeap but why 9+ why not just for 10 use circle
im gonna see if i can explode those and implement https://learn.microsoft.com/en-us/windows/apps/design/shell/tiles-and-notifications/badges
.svg i'm using for including to tray
and since user can pick custom colors then it may look like this:
i'm exploding just while being on microsoft page
maybe allow the user to provide a custom unread icon
explod
me
maybe user can just
"naaaaaah its too dark, lemme pick more brighter"
and then pick something like that
and live happy life
i need some rest xd
but actually from my side i want to add .svg icons loading
and then major relook at all sctructure and optimize as best as can
how do you plan to merge all this prs in one?
with closing PRs
or you will just close issue when all be merged xd
maybe we should create at original Vesktop repo another branch like tray icons
and merge all PRs to that branch
and fix all things there
and then merge that to main
ooor as long as my PR looks like not be conflicting with other PRs then we maybe can just push it to main when it's ready???
your pr supersedes like all theother prs except the splash one
i have feeling that splash pr will not conflict with mine
i dont think it would
yeah just use your PR
missing Visual C++ redist?
no
Ah okay I apologize, Thank you! I don't quite know where to run the command but I've moved to the AUR on Arch Linux which is working fine.
Thanks for letting me know though!
better than gnome in my experience :/
i havent experienced the broken icon/screenshare but i know that kde is typically regarded as the buggier DE
need to try gnome again tbh
screen share has been working fine for me on KDE
I have no idea why its so broken for these peopel
Oh something ive been wondering
why is the flatpak and default vesktop icon different
is it?
wait
it's not
huh
aur packager thing
they pull from https://github.com/Vencord/Vesktop/blob/main/static/icon.png
wheres the application icon
build/icon.icns
that isnt a format that can be used
ive never seen that format used in a .desktop entry
yeah its 100% not supported
in the deb its extracted into its individual files
hm that fails on all but 3 of the sizes
thats the macos one :p
oh libicns hasnt had an update in 8 years
might be best to provide the icons in a zip for other packagers
yes and also used on appimage and flatpak and maybe more
yeah the native build process deals with the icons correctly somehow but other packagers are just out of luck guh
wait huh
the nix pkg uses libicns
let me ask my nix using friend something
nix ships an unstable version of libicns
which is understandable considering theres been no tag in years
even the latest commit (2022) which the nixpkg uses it still fails to extract the 16x16 and 48x48
provide the pngs in a zip pretty please
I know this might be pointless to have, but is it possible for Vesktop to support animated Webp/Apngs. Im not sure why but animated Webp's and APNG's are supported in the chrome browser, but whenever i upload it to Discord it doesn't want to load. It's not like the webp's are sanitized to no longer be animated after it's uploaded because you can download them afterwards.. I truly think Discord is dumb for not allowing animated Webp's.. They're far superior to gifs
Ohh, damn i thought there'd be a way to change how stuff is interpreted.. im not smart with this kinda stuff tbh ๐ญ
its impossible to support apng, but possible to embed awebp
it's just kinda pointless cause it won't embed for anyone else
Good point ๐
not sure if this is a bug, but with the vesktop quick css editor on linux, lines are terminated with crlf instead of just lf
also idk where to report this
?
why does it matter
annoying when pasting
also this didnt used to happen
this shows up, and then eslint complains
fixed this for myself, leaving it here if anyone else comes looking for this
// in src/main/monacoWin.html
// after var editor = monaco.editor.create(/*stuff*/);
if(window.navigator.userAgent.includes("Linux")){
const model = editor.getModel();
model.pushEOL(monaco.editor.EndOfLineSequence.LF);
}
idk if mac also uses CRLF
should i pr it?
I'm also experiencing this problem in Bazzite Fedora KDE. Updating Vesktop to the latest did not fix for me. Viewers of my streams say the picture looks much better when audio is disabled.
Discord Account
mflyx
Operating System
Windows 11
Linux Only ~ Desktop Environment
No response
What happens when the bug or crash occurs?
This bug basically occurs all the time. It shows wrong activity in my profile, sometimes it shows an activity that is kinda right, but it should'nt show it, for example - FPS Monitor. It says that I am playing FPS Monitor. Sometimes it shows that I play "Last man standing" (I dont even know this game)

but is there a way to not display certain activities in vesktop, like we have in discord?
should already be fixed in latest master. try building from source
svgs can be animated right
see if it explodes lmao
dewit
if theres multiple frames convert to gif or apng ๐ฃ๏ธ
Nou
nativeImage supports only png and jpeg
And ico on windows
i'm having the same issue - using the vscode RPC extension, i get this error.
2024-06-22 17:56:06.405 [error] TypeError: Cannot read properties of null (reading 'write')
at IPCTransport.send (/home/nex/.vscode/extensions/icrawl.discord-vscode-5.8.0/dist/extension.js:2:24881)
at /home/nex/.vscode/extensions/icrawl.discord-vscode-5.8.0/dist/extension.js:2:24968
at new Promise (<anonymous>)
at IPCTransport.close (/home/nex/.vscode/extensions/icrawl.discord-vscode-5.8.0/dist/extensi...
Is there a reason why volume booster doesn't work on vesktop
webrtc
You can use the NotificationVolume plugin from Vencord.
AFAIK Discord has its own proprietary implementation
(see https://github.com/Vencord/Vesktop/issues/331 for ongoing progress)
is it possible to install two seperate vesktop instances on windows?
nvm i can do portable
aw it just focuses the main window
discord canary it is :c
Ty
Is vesktop available as a portable exe
yes, there's a portable edition
Nice
Also problem is that in voice connection in MediaStore AudioTranceiver have only one audio track with all voices baked into one output so we need to somehow found out how to get audios of every user to change output or just found out how discord manages changing sound from 0 to 100 and patch this function
@azure verge worked on this too and maybe have some updates
Why does the print quality look so ass lmao
I also had to spend hours figuring out this is a Vesktop/Electron issue, and found this issue.
This should really be enabled by default, because it doesn't negatively affect anyone still using X11.
There's also --use-gl=desktop which opens the window immediately, instead of after around a minute.
These two exit buttons quit the entirety of Vesktop, which is perfectly fine. But I ask is this something that was intentional and is here to stay in the future? If I'm using dropdowns on a foreground window, I usually expect the first dropdown on the foreground window to close itself. It's not really a bug or glitch, more-so a design choice
I think it's perfectly fine that the VESKTOP dropdown closes VESKTOP. I just think it should be further right, and Window should be first
I have never seen that window
i think its a new thing/experimental
How do you open that?
Ah interesting
it also does that for connections > add account if you have it off
Do I provide an unread badge at all and if I do do i make it display a "-" or "0" (also should I strip out the
โขlike with the(#)
I think it makes most sense to not display an unread pings badge if the count is 0.
So it makes it more noticeable when you do have one.
Idm either way for the โข
@ToxicMushroom The unread count isnt actually "0" in this case. Theres two distinct badge modes; unreads and mentions. Mentions are what have the number count and only shows up for pings and DMs, etc.
Unreads are when there is a message in a channel that you do not have muted. Users can disable the unread badge but still have the mention badge.
The reason why the unread badge shows a "0" is due to a limitation with the Launcher API it can only show 0-9 with no option for blank badge o...
Content
The .icns format on Linux is not well support and extracting the pngs from said format is impossible to do fully.
libicns (the library which provides icns2png) has not had a stable release in 12 years and only manages to extract two large icons from the icon.icns. Latest git is a bit better and only fails for ic04 and ic05 but again, doesnt work fully.
I'm making this as vesktop/-git on the aur uses build/icon.png which is notably not the Vesktop icon but ...
This should really be enabled by default, because it doesn't negatively affect anyone still using X11
false. there's a reason this is still not enabled by default in chromium. Just because it is stable for you doesn't mean it is stable for everyone.
in any case, we already enable this by default inside the flatpak
i'm using vencord from flatpak
flatpak versions of discord require a hack to support RPCs. dont forget to change the package name to your own
Could it be this issue ? https://bugs.kde.org/show_bug.cgi?id=482142. This was fixed already and going to be released in plasma 6.1
I got plasma 6.1 but the issue still persists. I will go talk to plasma kwin devs and see what's going on. Does Vencord handle any special cases for drag and drop that the devs will need to know about to fix this ?
I'm also experiencing this problem in Bazzite Fedora KDE, using Vesktop. Updating Vesktop to the latest did not fix for me. Viewers of my streams say the picture looks much better when audio is disabled.
Same issue in my setup, looks like Discord upstream broke screensharing again.
a lot has changed about the code since and now it has global state that it applies inside a getUserMedia patch. that'll likely solve your issues of only applying once! could you please rebase based on that?
excludes; in window assets, controllable via css and the app icon(read https://github.com/Vencord/Vesktop/issues/505, DEs provide methods of achieving this).
From #667
Does not solve this issue as for OSes without DEs (aka windows).
how Discord does it:
- subscribe to ChannelRTCStore and SelectedChannelStore
- whenever
SelectedChannelStore.getVoiceChannelId()is not null andChannelRTCStore.getMode() === "video", it blocks display sleep:DiscordNative.powerSaveBlocker.blockDisplaySleep()
Discord Desktop logic (cleaned up & simplified, search for "IdleStore to find this in code):
function isSystemIdle() {
return suspended || locked || (isAndroid() && idkIrrelevantWhoCares);
}
function checkIdleNative() {
let checkIdleTime = t => {
idleSince = Math.max(Date.now() - t, idleSince),
checkIdleAFK(),
setTimeout(checkIdleNative, 10 * d.Z.Millis.SECOND)
}
DiscordNative.remotePowerMonitor.getSystemIdleTimeMs()
.then(checkIdleTime);
}
c...
you can just disable Rich presence for the time being. you will have to fully close & restart vesktop once to apply this setting
if you can confirm that this is indeed caused by RPC, you should report this upstream in the arRPC repo.
focuses a bit too much on linux... there should also be one image that just shows normal discord
Yes, the issue came back, but it does not to seem as problematic as before.
I can stream normally with audio to some people, but not to others.
Depends on the "viewer"'s client.
@hot juniper Keep getting the message "Failed to connect to arRPC" ๐
I assume this is a Linux thing?
this is dev chat not support 
Whoops ๐ฅฒ
wtf is a VeskTop
RobTop
Windows has a DE called "Windows Shell" you can easily change icons. Google it
Windows has a DE called "Windows Shell" you can easily change icons. Google it
I know that, I mean an actual useful and customisable DE, sure you may be able to change shortcut icons, but changing actual executable icons is more of a hastle and in this case doesn't actually change the icon in the task bar.
you can change the app icon in the taskbar on windows.
you can change the app icon in the taskbar on windows.
Yes, but that only changes it if it's pinned. It does not change the app icon entirely.
is it even possible for apps to change their own icon
yes
Can we stop creating work arounds for the issue and actually develop a fix...
cAn yOu mAkE a fOrK aNd cReAtE fix by yOuRsElF
no other program provides this ๐ญ๐ญ๐ญ
its literally up to the DE
wayland real
honestly im still unsure if we should even provide option to change the icons
name one program that provides this option
why should we
none
(on desktop)
mobile apps including discord do it though
mostly as a premium subscriber perk
idk I like the idea of changing tray icons without having to use an icon theme
well some DEs provide options to change it
eg kde
it currently doesn't work because of chromium moment but 
I doubt that'd work for apps that change the tray icon to display a state
I'm like 90% sure u can change that too
bros just lazy
Discord Account
mora_unie_youer
Operating System
NixOS 24.11.20240531.57610d2 (Vicuรฑa)
Linux Only ~ Desktop Environment
Niri (Wayland)
What happens when the bug or crash occurs?
Audio Sources in Screenshare window do not show anything but Pulseaudio sources.
As an example I can provide MPV, but for example osu!lazer and something else is not being shown too.
(MPV i...
I'm using 3fe2094814480c78ae74f4466804c51059c563aa, so I think this is kinda latest git of Vesktop. I don't know how to use latest venmic, as I'm using Nix package for Vesktop build
What is nix
latest Linux horror
I'm forcing pnpm-lock.yaml to be updated, so I think I'm already using latest venmic
HorrorOS
mean 
cannot reproduce. probably a system issue. try again on non-nix
all-hail the penguin! ๐ง
I agree, we should have more screenshots: normal Discord, user settings and maybe vencord settings too, then screenshare
Well, I can't test properly on non-nix build, as it's not latest (the only thing I can normally start is flatpak, which is outdated)... Later at free time I will send venmic debug logs
The only thing I can say is that on older Vesktop (before screensharing window update), pipewire applications were shown, but now, on the latest build - they are not
Anyway, when I start mpv, it is detected by venmic, but nothing is shown in screensharing window
<details>
<summary>Part of console log with venmic debug enabled</summary>
[2024-06-23 20:48:15.525] [venmic] [trace] [patchbay] (add_global) new global: 267 (type: "PipeWire:Interface:Client")
[2024-06-23 20:48:15.526] [venmic] [trace] [patchbay] (add_global) new global: 212 (type: "PipeWire:Interface:Node")
[2024-06-23 20:48:15.526] [venmic] [trace] [patchbay] (handle) new node: 212 ...
next-generation package manager (https://nixos.org/)
Nix is a tool that takes a unique approach to package management and system configuration. Learn how to make reproducible, declarative and reliable systems.
what's still pending for a new Vesktop release?
https://github.com/Vencord/Vesktop/issues/172#event-13256427970
@Vendicated, is this https://github.com/Vencord/Vesktop/issues?q=reason%3A"not+planned" because as https://github.com/Vencord/Vesktop/issues/172#event-13256427970 requires, this isn't notarised? I expect you don't want to pay for a certificate?
I'mma go ahead and bump this'n. I'm using Debian Trixie at the moment, and after a recent update, I'm getting a similar issue to OP- Along with a few other quirks that I'm unsure may or may not be related.
I think this confirms that it's not a Nix-Specific issue, at the very least.
I get this error when running the AppImage, and from source. Screenshare works correctly (sometimes) on fla...
i believe that it's for platform consistency, mac / linux icons usually have a background colour, while windows usually has icons with a transparent background
Hmm mind sharing some examples of applications that have intentionally transparent background? Most apps I use are cross platform and share the same logo across platforms
vs code, native explorer, native paint, native calculator, (also most native apps) git, firefox, and inno installer ar...
i know this comment is going to be marked as spam but PLEASE ADD THIS. Is there anything blocking this from being merged? it seems to be fully working. (also this serves as kind of a bump)
ppl want more features in the pr for some reason :/
it seems great to me
bump
doesn't share debug info

Discord Account
mora_unie_youer
Operating System
NixOS 24.11.20240531.57610d2 (Vicuรฑa)
Linux Only ~ Desktop Environment
Niri (Wayland)
What happens when the bug or crash occurs?
Audio Sources in Screenshare window do not show anything but Pulseaudio sources.
As an example I can provide MPV, but for example osu!lazer and something else is not being shown too.
(MPV i...
Please provide a pw-dump. The pipewire only client is likely missing important node properties
i have already tested with mpv and it looks flawlessly
(haven't looked into the dump yet) But make sure to send the dump when mpv is running in pipewire mode
Yeah, of course I made dump with MPV in pipewire mode
Yeah, of course I made dump with MPV in pipewire mode
Awesome, will take a look soon!
using electron 31, the bug with flickering on mouse move is gone, however now the stream's fps drops to 1-2 when NOT moving the mouse inside the streamed window
arch, kde 6.1, nvidia beta 555
https://github.com/Vencord/Vesktop/assets/19815169/46b467f4-9194-4500-94eb-d28b8e31174b
stream's fps drops to 1-2 when NOT moving the mouse inside the streamed window
What's your hardware? CPU and GPU?
Looks like encoder struggling bc bitrate looks good.
What's your hardware? CPU and GPU?
amd r9 5900x, rtx3080
i dont think hardware is the problem, also streams are silky smooth under x11
Hi, what is the current status of this issue?
Screen sharing is not working for me on NixOS (Wayland Session) with the version 1.5.2
Hi, this issue should apparently not be closed, as my comment in #560 was marked as off-topic
Screen sharing is not working for me on NixOS (Wayland Session) with the version 1.5.2
please stop hijacking random unrelated issues. this and the other issue are specifically about being unable to start a stream while already watching someone else's stream, not general inability to stream at all. we do not support nixos.

please stop hijacking random unrelated issues. this and the other issue are specifically about being unable to start a stream while already watching someone else's stream, not general inability to stream at all. we do not support nixos.
thanks for clarifying. NixOS doesn't have to be specifically supported, the program is built from source.
sorry for my useless comment, but this will make screen-sharing games on X11 finally bearable using my small tool.
if the dev of this pr cannot currently / doesn't have the time to rebase it, would it be possible for me to do it?
I was running into this problem earlier today where screensharing was running at around 11 FPS according to the debug window people were using above.
After seeing this comment: https://github.com/Vencord/Vesktop/issues/629#issuecomment-2136191619 I decided to "rebuild" my vesktop installation with the latest Electron 31 (31.0.2). I'm using NixOS, so it kind of worked like below. I had to use a local fork of nixpkgs as Electron 31 hasn't landed there yet:
{pkgs, inputs, ...}: l...
I don't seem to have a problem on systems with iGPUs (e.g. my laptop). Unfortunately, my desktop doesn't have an iGPU and it seems to run into the GPU bug...both are AMD.
this might happen if you enable vencord's transparency setting. delete (or manually edit) ~/.config/Vesktop/settings/settings.json and it will reset that setting
unfortunately no dice (I had never touched that file - this is under the flatpak config directory). Tried deleting that file, but issue still persists
Discord Account
No response
Motivation
I see some commits for Vencord to disable renderer backgrounding.
Some of them have been implemented on Vesktop, but not all of them.
Vencord file: https://github.com/Vendicated/Vencord/blob/main/src/main/patcher.ts
Vesktop file: https://github.com/Vencord/Vesktop/blob/main/src/main/index.ts
Relevant commits on Vencord's site:
https://github.com/Vendicated/Vencord/commit/a0778f6a2e786889d11f2b627f2ac03f7696c2e5
https://github.com/V...
The issue where capture is low framerate when there isn't mouse movement has been reported to KDE. I actually wasn't having this issue for a while but it popped up for me today, and posted some additional details in the tracker. As I noted there, the issue doesn't seem to happen on Firefox, only on Chromium.
I tried using vesktop with electron31 as dmizelle did but am still getting low framer...
Discord Account
Soham52#0241
Motivation
It's Hard to tell whether you're connected to a vc, and everytime you need to open the client to confirm it.
Solution
Make the venktop tray icon change into the voice indicator similar to how the discord icon behaves in the tray.
Alternatives
None
Additional context
Here's how the Discord Tray Icon behaves -
https://github.com/Vencord/Vesktop/assets/73898737/ba453199-29c2-47a5-aa6c-9a86bd6c6fb4
Request Agreement...
Venktop
Curious to look at the pw-dump, probably some really cursed shit again lmao
do you mean mine?
most stable nixos setup
Lmaoo
xddd
muh portable immuntible os!!!
Discord Account
idontskid_ipaste
Operating System
Fedora Linux 40
Linux Only ~ Desktop Environment
Gnome
What happens when the bug or crash occurs?
When im trying to attach files:
- its not showing preview
- when im trying to send it says "Upload Failed, Something went wrong, try again later"

shiggy is the worst creation in the history of mankind
Any idea of when this will be added? More customization is always a bonus and this has a good amount of demand for it (relative to the size of the project at least).
mods drop a nuclear bomb on this user
i stand by my statement
nah seriously tho this should be customizable like most things are with themes
why bro can't just change gif in project folder and write new .desktop for starting pnpm start in needed folder๐ญ
too much work
Discord Account
No response
Operating System
linux
Linux Only ~ Desktop Environment
i3
What happens when the bug or crash occurs?
if i play a game, others see my game activity, but to me it doesnt change anything, i cant see what game i am playing
What is the expected behaviour?
i would expect it that i can see the game activity too, especially so i can check if its actually detecting my game properly
How do you recreate this bug or crash?
open a game with...
idk why but this is so fucking funny
:3
well i will take your word for it, but can you please elaborate? what do i need to do to fix this?
i don't know. you have provided 0 relevant info. use our support channel for support https://vencord.dev/support
--enable-wayland-ime doesn't appear to work for me, neither does forcing GTK4? I seem to have a very specific issue with this and the logs for Vesktop don't seem to tell me much about what's happening:
Passing the following arguments to Electron: --ozone-platform-hint=auto
[arRPC > ipc] listening at /run/user/1000/discord-ipc-0
[arRPC > websocket] listening on 6463
[arRPC > process] started
Is there any other logs I can provide to support this issue? I've been at it for abo...
I'm experiencing this also when just clicking on Vesktop's taskbar icon, and it happens even when the window is not maximised, for instance if it is snapped to one half of the screen. Using 1.5.2 on Win10 22H2.
That's because of Chromium bug with DMA-Buffers. Today fix was merged to Chromium), so we just need for Chromium to release new Tag version, then wait for Electron to use this Chromium version and then use this Electron version in Vesktop for getting rid of slutters while streaming.
Is this supposed to be fixed now? I still get these stutters when dragging windows, latest Vesktop.
that patch has not reached chromium stable yet so we are still waiting.
is builtin arrpc on vesktop known to be buggy
isnt this the armcord guy
Looks like he is
idk i probably made arrpc worse overall by accident
what did you do
it always works for me.. so..
PRed some major changes to game detection
xddd
another interesting idea then would be if you could reduce the code size of app.asar to beat openASAR. but when i took a look at openASAR's github, i realised that dude is a madlad they don't even have a package.json and their toolchain is shell scripts. hard to beat that kind of minimalism

๐
read the readme on https://github.com/Vencord/Vesktop @rare beacon
Hey @tuxinal , can I help w something?
I'm very interested in the keybinds, and I also would like to add some things that the discord official client doesn't have (such as toggle noise supression)
Discord Account
No response
Operating System
Arch Linux
Linux Only ~ Desktop Environment
Hyprland - Wayland
What happens when the bug or crash occurs?
If you highlight a piece of text and you try to right-click nothing happens.
What is the expected behaviour?
Should give you a bunch of options, one is to search with Google or in my case I have the ReplaceGoogleSearch (It is not the issue because I already tried removing it)
How do you recreate this bug or c...
V is tired for writing reason xd
are you really that surprised โโโโโโโโโโโโโโโโโโโโโโโโโโ
I'm surprised that he didn't stopped answering before
true! โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโ
Discord Account
kekkodance
Operating System
Windows 11
Linux Only ~ Desktop Environment
No response
What happens when the bug or crash occurs?
I use EarTrumpet, i periodically find Vesktop's volume lowered to around 50 to 66 percent for no reason, despite turning it back to 100
What is the expected behaviour?
Volume staying at the specified level
How do you recreate this bug or crash?
- Start Vesktop and EarTrumpet
- Get in a VC or do something with noi...
10000000% vesktop issue
Vesktop doesn't control its own audio output. Something on your system is changing it.
Discord Account
retrodeg
Operating System
Kubuntu 24.04
Linux Only ~ Desktop Environment
KDE X11
What happens when the bug or crash occurs?
Not getting notification pop ups on desktop or in app. it plays the discord sound, but doesn't pop up.
What is the expected behaviour?
notification pops up
How do you recreate this bug or crash?
- get a notification
- observe
Debug Logs
Replace this text with your crash-log. Do not remove the backticks
```...
do you have the option in vesktop enabled? do you have libnotify installed? do you have notifications from other electron apps?
Still facing this issue with --disable-renderer-backgrounding
Discord Account
No response
Operating System
Windows 11
Linux Only ~ Desktop Environment
No response
What happens when the bug or crash occurs?
Happens every time. Tried restarting several times and went thru settings a few times to make sure i wasn't missing a toggle or anything.
What is the expected behaviour?
There should be a working pin icon.
How do you recreate this bug or crash?
- Hop on a call
- Pop out the call using the button next to the "f...
enable desktop notifications in notification settings
if it still doesn't work, system issue
what is this button supposed to do
@Vendicated
this is what it looks like (thumbtack). it keeps the window on top. the screenshot is from regular discord.
vesktop btw
you can use PowerToys Always on Top for the time being https://learn.microsoft.com/en-us/windows/powertoys/
OH i didn't realize this was something that had to be implemented manually. Sick, I'll check out power toys. Thanks.
I'll keep this issue open.
my sanity is also going down day after day from vencord plugin dev 
tf
Maybe we should update year in copyright?)
Everything will explode
no
irrelevant
IMO only the copyright year of the year the program was created is relevant
^
the year serves as an indicator for when that file was created
it has 0 legal relevance
updating the year is pointless
Copyleft ๐ฏ โ All rights reversed
actually, the year is legally relevant under the Berne Convention
but Vesktop being free software it may as well be considered public domain :v
it's rare for GPL violations to arise publicly and notably
copyright expires a set number of years after your death
yes
it doesn't matter if you keep the year in the header updated
the text itself is irrelevant, of course
you hold copyright your entire life
even if it says copyright 2011 and it's 2050, it's still copyrighted by you
copyright is, at minimum, entire life + 50 years after death
countries can have a higher limit if they desire
IIRC USA is 70 after death
that's why recently the first Mickey Mouse animation has entered the public domain
so this makes no sense
The Berne Convention introduced the concept that protection exists the moment a work is "fixed", that is, written or recorded on some physical medium, and its author is automatically entitled to all copyrights in the work and to any derivative works, unless and until the author explicitly disclaims them or until the copyright expires. A creator need not register or "apply for" a copyright in countries adhering to the convention.
as soon as the thing exists, copyright is automatic
the year is relevant for that
no
it's not
and if anything, changing the year is misleading
you're pretending like it was written in 2024, when in reality it was written in 2022
I get what you mean
I don't know for sure, but I believe some things have fixed years instead of entire life plus afterlife years
such as patents, which expire after 20 years
I think there's something similar for copyright too under some circumstances
the idea of changing the year is just to say that the developer is active and they still hold copyright for it
but yeah it doesn't make much sense and it is irrelevant
even more if the program is copyleft or under a permissive license such as MIT
enable desktop notifications in notification settings
if it still doesn't work, system issue
i do have desktop notifications enabled, i refuse to believe it is a system issue. Every other program sends notifications just fine. INCLUDING regular discord, but i stopped using regular discord because i got tired of it never getting timely updates and/or having to manually update a deb every time i wanted to use discord
plasma 5 issue maybe
I'm on 6.1 and get notifications fine
only issue is clicking them doesnt do anything
actually has that been reported
oh my god i didnt even notice
plasma 6.1 fixed the double screenshare picker issue when picking a single window
Yeah, I talked about it
Also there is no now checkboxes in portal picker, just single click on screen and that's it
yeah that's
way better
also sowwy i havent been here much cuz i uhh got addicted to gtnh
it still does it for me
geuwh
u mean the
window picker portal > vesktop picker (settings) > window picker portal
right
Fixed for me in plasma 6.1
???? its working now
what the
and now its not after a reboot
huhh
xwayland scuff issue??
it worked like once huh
yeah it doesnt happen at all via native wayland
https://issues.chromium.org/issues/331796411?pli=1 i love chromium log spamming because i dare to encode/decode video on wayland
yeah
that's what im using iirc
@hybrid fjord your conversion isnt exactly accurate
oh
also
the dot is for unreads on stock discord
here its acting as a mention indicator
explod u forgor
I am also having this issue on my Fedora system running KDE in Wayland mode.
Desktop notifications are enabled.
libnotify-0.8.3-3.fc40.x86_64 is installed.
Notifications are working on Discord Stable, Canary and PTB.
Specs/Info:
Vesktop 1.5.2
Vencord E37a0cf
Electron 29.1.1
Chromium 122.0.6261.111
Using Canary release channel
Fedora Linux 40 (KDE Plasma) x86_84
Kernal Rev. Linux 6.9.4-200.fc40.x86_64
cant i remove this as emitDBusBadge only takes a number anyway
if it's user controlled no
wdym by user controlled
count is calculated from unreads and mentions which shouldn't ever be a non number
i dont see the point of erroring before it reaches the function if the function would just error itself
better to give a error yourself then reach potentially untested stuff
although that log should probably be a real message
HATER
just ctrl f the code for the log duh
don't run arrpc yourself. vesktop already comes with it out of the box
the one out of the box does not work on linux, it only works if i run it myself
It's nicer. :)
Also it's consistent with other places (such as "Restart Client" in Vencord's settings).
It's checking for -1
false. if you are using flatpak, you need to grant sandbox permissions.
use our support channel if you need help
thats not how its behaving xdd
yeah but it literraly shows only when == -1 ๐ข
is that how it works for you?
i tried marking all my servers as read and badge dissapears
and shows back when somewhere in chats someone wrote something
gwuh i was out of date oops
its not showing at all now
oh
its following this setting
disabling it removes the -1 setter
it shouldnt follow that setting
hm
you should just ignore main/appBadge.ts and get GuildReadStateStore.hasAnyUnread(); directly from renderer/appBadge.ts as it only sets to -1 if that toggle is on
@hybrid fjord
prob add another toggle to vesktop settings for the tray unread badge
iirc stock discord u cant even turn off the tray unread badge
Didn't we already have toggle for it?
Ohh nvm
Will do
Having the same issue, Vesktop seems to ignore the --enable-wayland-ime command. I'm using the Flatpak package on Arch Linux with Plasma 6.1.1 & fcitx5 configured for Japanese input.
Other Electron applications have no issues with using the IME, including the standard Discord package from the Arch repo.
I think Vesktop is being tortured
Maybe we should just fix logic for already existing toggle? Because I don't feel right for creating another one toggle if "Enable Unread Message Badge" must do same work
the description of the toggle explicitly says on the app icon
Change description? xd
you can't remove the unread badge on the tray on stock discord
how
Another switch for tray icon is the way then ๐ฆ
But I dunno, I have feeling that following app badge would be better
In UX terms
what if the user wants unreads in the tray and mentions on the app icon
Didn't user get this behavior with this enabled?
So if this is disabled and someone mention me then i will get notification badge anyway?
if you have it enabled in Vesktop settings yes
shorter, I'll just add another one toggle for showing unread message badge
If this is enabled, then i check for -1
If disabled, then check whether it's != 0?
It's so fucking complicated with this all unreads and mentions
Who tf wants to see unread badge if most users have millions of muted servers where many people chatting
if disabled hide the tray badge
ikr
And if enabled then just show badge in tray icon when it's not 0?
disabled: hide tray badge
enabled: show only if hasAnyUnread() is true
yep just export from renderer/appBadge.ts
I will do asap, hopefully today at evening
I mean its not like the world is gonna explode if u take an extra day or two
Yeah but I just do not want to detain if someone or you, for example, need it for further development
well I can just make an ugly patch to get the behaviour I want in the meantime
Good
Good thing that I even don't need to think about it and just use hasAnyUnread() xd
Bc brain explodes with all of these types
because WAAAAAAAAAAAAAAAAAAAAAAA
message requests should be too but theyre not included in the count that vencord grabs #๐พ-core-development message
I assume it was just forgotten when they added that feature
Looks like easy fixable in your PR but it needs further approve from V
nah it'd be fixed in vencord itself
...AAA-kaboom
are you talking about this? https://github.com/Vencord/Vesktop/blob/main/src/renderer/appBadge.ts#L19-L25
appBadge.ts: Lines 19-25
const mentionCount = GuildReadStateStore.getTotalMentionCount();
const pendingRequests = RelationshipStore.getPendingCount();
const hasUnread = GuildReadStateStore.hasAnyUnread();
const disableUnreadBadge = NotificationSettingsStore.getDisableUnreadBadge();
let totalCount = mentionCount + pendingRequests;
if (!totalCount && hasUnread && !disableUnreadBadge) totalCount = -1;
no
then what
wait which part of the convo
"message requests should be too but theyre not included in the count that vencord grabs"
i have no clue what you're referring to
