#๐Ÿ–ฅ-vesktop-development

1 messages ยท Page 11 of 1

azure verge
#

oh

#

my god

sly cairn
#

i had to open their software in dotpeek to find where it puts them

#

its so dumb

azure verge
#

holy hell ๐Ÿ˜ญ

sly cairn
#

but yeah i very quickly

simple groveBOT
sly cairn
#

removed their system service and startup app

#

once i worked it out

#

xd

#

anyway yeah this is vesktop discussion xd

#

no more fonts

vernal lintel
#

well i also just like being very direct

azure verge
#

same, i just add a flare of being helpful to it

vernal lintel
#

i say what's on my mind without much talking around the point

azure verge
#

to make people like me

azure verge
#

if you add flare and talking around

#

it just wastes time

#

and energy

#

its annoying when people do that imo

vernal lintel
#

yeah lol

#

hence why i avoid it

#

sometimes i just need to word what I say nicer I think

sly cairn
#

i tend to think i'm passively direct

azure verge
sly cairn
#

like i will say what i want

#

but with a bit of

#

smile

simple groveBOT
sly cairn
#

then again i am just british that's how we talk

vernal lintel
#

like "it's really not that hard" sounds really passive aggressive and patronising

I didn't mean to make it sound that way, I only noticed after i had commented that

simple groveBOT
vernal lintel
#

so i edited it to "it's pretty simple"

#

so much better

azure verge
#

i feel i was direct

#

but i didnt want to leave them with nothing

vernal lintel
#

is it just me or does adding an exclamation mark make things sound a lot nicer

#

sure

vs

sure!

azure verge
#

it does imo lmao

azure verge
vernal lintel
#

"sure" is like "welll if you insist ๐Ÿ™„"

"sure!" is like "yuss do it bestie slayyy!!"

azure verge
#

REAL

upper current
#

dont even use sure with a period unless you hate their guts

vernal lintel
#

sure.

azure verge
#

they make me really scared that people dont like me

#

if they use periods lmao

vernal lintel
#

i use periods only when im annoyed or if im being very serious

azure verge
#

it sounds too serious ๐Ÿ˜ญ

azure verge
upper current
#

yeah i basically only use them for formal text or when you have like. really long pauses while talking

vernal lintel
#

also when someone asks dumb questions

#

no.

#

only three letters yet so powerful

azure verge
#

true

upper current
#

is a period a letter

azure verge
#

its a character

simple groveBOT
#
Tiagoquix
[Vencord/Vesktop] Issue opened: #571 Add a new option to change the tray icon used by Vesktop

Hi there. I would like to have a command-line flag or GUI option to change the icon used by Vesktop on the system tray. For the GUI, it could be something together with the "Tray Icon" option in "Vesktop Setttings".

My reasoning for this request is because I personally prefer to use original Discord icons.

For the app itself, I can do it using the .desktop file on my DE (KDE Plasma), but I can't modify the VC icon due to it being hardcoded in Vesktop itself. (I could, but I would have...

vernal lintel
#

i should start using good first issue more

azure verge
#

oooh

#

true

vernal lintel
# simple grove

for simple feature requests / bugs

add pointers like how i did here and add that label

#

could help new people get into the project

#

god i really need to tidy up all the repos

#

so many prs to go through

so many issues that could use better info

etc

azure verge
#

if you want I can skim the open issues tomorrow and see if there's anything that can be easily answered

simple groveBOT
vernal lintel
#

i looked into that a while ago

#

fixing it is as simple as flipping a boolean in discord code

#

but like I suspected they did it this way cause of permissions

#

so if u do that it just breaks vc

azure verge
#

ahhh

simple groveBOT
#
AstralPhnx
[Vencord/Vesktop] New comment on issue #298: Unread Notification Badge not working on KDE

I think it's a good idea to give a explanation what is needed to make this work:

1. Electron [currently checks the Desktop](https://github.com/electron/electron/blob/5ad8b4b7d16ff8026243251bac98bbcf343c77e3/shell/browser/linux/unity_service.cc#L63) before using the API. I had [removed this check](https://github.com/electron/electron/pull/41211), so this should be gone with the next Electron version, but for now you may have to set some environment variables, if your desktop is no...
simple groveBOT
#
JakobDev
[Vencord/Vesktop] New comment on issue #298: Unread Notification Badge not working on KDE

being a real ballache with the flatpak and appimages which both use their own funny haha .desktop filenames

If you take a look at my PR, I use the patch-desktop-filename script, so Vesktop will use the correct dev.vencord.Vesktop.desktop filename. For AppImage there is no way to make this work.

Is this .desktop file thing an absolute requirement at this point?

Yes. This is even a bigger problem on Wayland. On Wayland Apps can't set a Icon. The Icon from the desktop file is u...

simple groveBOT
azure verge
#

I know I bumped an old issue
welp
I'm gonna bump a million if we can fix them :3

hybrid fjord
#

It's really easy to fix

#

I can even include it into mine tray icons PR, because I have this subscription and isSelfMute function

#

But I'm not sure about UX side of it

hybrid fjord
azure verge
#

id assume but also vesktop auto-mutes on launch

#

and at least

#

for me

#

it auto unmutes when i join a call

hybrid fjord
azure verge
#

shrug maybe its already fixed???

hybrid fjord
#

xd

#

Funny if using same approach as I wrote

azure verge
vernal lintel
#

idk

#

i don't vc much

azure verge
#

sobs

#

yeah but id assume you knew if that code was somewhere lol

#

unless its something discord did themselves

vocal adder
azure verge
#

yeah but it

#

unmutes as soon as you need it

#

eg. joining vc, mic test, voice messages

vocal adder
#

oh true

azure verge
#

yea so idk if its still an issue

vocal adder
#

if it auto unmutes on basically anything that requires you to use the mic then who really cares imo

simple groveBOT
vernal lintel
#

i swear it didnt do that back then

vocal adder
#

i honestly can't remember bleh

#

and then i get things mixed because on desktop you get auto unmuted in calls but not in voice chats

simple groveBOT
azure verge
#

I remember using browser discord with goosemod

#

for audio streaming

#

and it didn't auto unmute

simple groveBOT
simple groveBOT
azure verge
#

as soon as i finish the homework im doing rn

#

im going to get to work and start clearing up some old issues

vernal lintel
#

hopefully will increase the quality of reports and avoid some duplicates / invalid issues

#

inb4 noone reads sadaamia

simple groveBOT
azure verge
hybrid fjord
# vernal lintel

Maybe we can add checkbox like "I checked closed issues and my issue is not duplicate"? Something like that

#

Bc they will probably skip first sentence))

simple groveBOT
vernal lintel
simple groveBOT
vernal lintel
#

so whats with the release? did it fail or smth @sly cairn

#

sorry for constantly pinging u but youre the only one with access sadaamia

#

can you give me access somehow

sly cairn
#

its just their ci failing

#

theres not a lot i can so

#

do

#

also yeah file an issue on flathub/flathub asking for contrib access

#

as an upstream maintainer

#

ill vouch it

vernal lintel
#

how can i do that

#

https://discourse.flathub.org/t/how-would-i-go-around-with-requesting-a-new-user-as-a-maintainer-for-a-repo/5446

Flathub Discourse
How would I go around with requesting a new user as a maintainer fo...

Hey there! Essentially after a few months of communication the owner of the application for which Iโ€™ve made a flatpak for agreed to add him as a maintainer for the flatpak/manifest, alongside other things like verifying the app on flathub. How would I got around with adding them? I donโ€™t have permissions to add users myself, would I create an ...

#

oh god no template

simple groveBOT
vernal lintel
#

just comment on this to confirm

#

@sly cairn just pinging to make sure u dont miss it pookie venniecozycat

simple groveBOT
vernal lintel
#

thanks <3

simple groveBOT
simple groveBOT
simple groveBOT
#
kaitlynkittyy
[Vencord/Vesktop] New comment on issue #528: Screenshare with audio enabled breaks video quality

Okay, here are some updates. Yesterday (30.04) Discord updated web version from 287337 to 289103. Kaitlyn noticed that streaming from Vesktop to Browser (and some clients) was fixed (if we can say so). At that time I was able to stream from Vesktop to another account on Chromium without bitrate loses, however while streaming from Vesktop to Firefox I could see drops to 29.17 kbit/s. Today(? 01.05) Discord updated web version to 289379 and rn I'm able to stream from Vesktop to friend on Wind...

azure verge
#

@vernal lintel does this sound okay?

upper pine
azure verge
#

id think so

simple groveBOT
azure verge
#

:3 YAYYY

simple groveBOT
upper pine
#

I think I just took the first nap ever after which I don't want to fucking die

vernal lintel
#

this looks so funny out of context

Screenshot_2024-05-03-16-42-52-46_572064f74bd5f9fa804b05334aa4f912.jpg
upper pine
#

I want another nap now :(

upper pine
#

Big Vesktop & Linux win right there

#

Let's how Nvidia releases some fucking working drivers now

#

Then I'd have a pretty stable daily driver xD

simple groveBOT
azure verge
#

to make sure i dont

#

misinform

upper pine
#

venmic is also vesktop only

#

Basically

#

If you run Linux

#

Run Vesktop

azure verge
#

true

upper pine
#

Is someone here familiar with docker compose networks

#

I want a container to only be able to reach local ips but not be able to reach the internet

simple groveBOT
#
kaitlynkittyy
[Vencord/Vesktop] New comment on issue #488: Clarity on how/where Vesktop differs from Vencord

I read over this a few times before making my post. Nothing really answers the question of "why Vesktop?"

The first point is that vencord is pre-installed. To me, that says "you can skip the step of manually having to patch Discord with Vencord".

The second point states it's more lightweight and faster than Discord, but doesn't mention if it's also more lightweight and faster than if I were to just download Discord and then patch it with Vencord myself.

The third point ...

simple groveBOT
simple groveBOT
#
sylvi-3
[Vencord/Vesktop] Issue opened: #573 [Bug] <The Vencord settings are missing!>

Discord Account

sy1vi3_

Operating System

NixOS 24.05

Linux Only ~ Desktop Environment

Hyprland (Wayland)

What happens when the bug or crash occurs?

I can't find the plugin settings. This might just be me being silly, but I can't for the life of me figure out where to change my plugins! It used to be that there would be options in settings for Vencord and Plugins, but they don't seem to be there anymore.

What is the expected behaviour?

Vencord settings/plugin s...

hybrid fjord
#

๐Ÿ˜ญ

simple groveBOT
azure verge
#

oooh

simple groveBOT
simple groveBOT
simple groveBOT
azure verge
#

i keep checking these channels hoping there's something fun to do oml i have a problem

simple groveBOT
#
the-arkhive
[Vencord/Vesktop] Issue opened: #574 [Bug] OBS virtual camera not listed in settings

Discord Account

No response

Operating System

Arch

Linux Only ~ Desktop Environment

Wayland

What happens when the bug or crash occurs?

OBS virtual camera does not appear in video options. There is an external USB webcam that does get listed as expected

What is the expected behaviour?

Video device should appear in the drop down menu.

How do you recreate this bug or crash?

1: Install latest version of Vesktop
2: Start OBS virtual camera
3: Go to "Voice & Vi...

simple groveBOT
simple groveBOT
simple groveBOT
ionic gust
simple groveBOT
vernal lintel
ionic gust
#

right, my mistake

simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
#
AstralPhnx
[Vencord/Vesktop] New comment on issue #298: Unread Notification Badge not working on KDE

being a real ballache with the flatpak and appimages which both use their own funny haha .desktop filenames

If you take a look at my PR, I use the patch-desktop-filename script, so Vesktop will use the correct dev.vencord.Vesktop.desktop filename. For AppImage there is no way to make this work.

Is this .desktop file thing an absolute requirement at this point?

Yes. This is even a bigger problem on Wayland. On Wayland Apps can't set a Icon. The Icon from the desk...

ionic gust
#

wayland apps can't set an icon, its from the desktop file

#

and this is supposed to be the xorg killer

#

god forbid i wanted two windows to have two different icons

simple groveBOT
#
Xionical1
[Vencord/Vesktop] New comment on issue #522: Unable to Update to Latest Vencord with Vesktop Appimage (Vesktop shows blank screen)

I have had this multiple times. Still unclear on what to do. I understand that you have to go through updates, and may have problems. But what do I do? Wait for an aur update? can I update through the app itself? Do I have to download anything and manually install it? Why should I if the aur exists? For now I am not gonna use vesktop cause its broken and I cannot find a way to fix it. Just don't be salty about people trying to clear things up. I still have no idea what to do. This is the top ...

simple groveBOT
simple groveBOT
simple groveBOT
#
tuxinal
[Vencord/Vesktop] New comment on issue #18: Custom Keybinds

#326 used to use the electron globalshortcuts api which doesn't work on wayland (by default without hacky solutions), can't do PTT, and consumes inputs.

i've since changed it to have a cli which you can hook up any DE's keybind system to. currently it doesn't support PTT either but that should be fairly easy to add.

though my intention with the cli is for it to be used more as a fallback than the main solution. and there isn't anything else besides the cli in #326 so i don't think it'...

simple groveBOT
simple groveBOT
#
Vendicated
[Vencord/Vesktop] New comment on issue #522: Unable to Update to Latest Vencord with Vesktop Appimage (Vesktop shows blank screen)

Please stop being lazy and just answer the damn question please :) This might end up in someones (me) results page when they do 'do research'. Thanks.

i answered the question, in the first issue that was reporting this issue. if you properly checked for duplicates (it's literally one of the two mentioned duplicates you quoted) you would have found the solution. you're the lazy one. stop being entitled

vernal lintel
#

why do people

#

so much mimimi instead of just checking the duplicate issues i linked for the solution i posted there

azure verge
#

omfg

#

god I hate people like that

simple groveBOT
#
Vendicated
[Vencord/Vesktop] New comment on issue #522: Unable to Update to Latest Vencord with Vesktop Appimage (Vesktop shows blank screen)

That is exactly what happened... I wrongly assumed any issue might still be open as I just experienced it on the day I submitted the bug report. I'll make sure to search closed issues as well next time.

@cbmiller2610 yeah i have since realised that github's issue search is a bit confusing in that sense since it only searches open issues. so it's not your fault, sorry for calling you lazy! i was just fed up with the many duplicates. i have since added a much improved issue template that s...

simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
humble mortar
ionic gust
#

it shouldve been there from the start ๐Ÿ—ฃ๏ธ

#

controversial
wayland maintainers sure are on something, and i want some

simple groveBOT
#
ottergauze
[Vencord/Vesktop] Issue opened: #575 [Bug] Vesktop AppIcon icon not present on GNOME panels.

Discord Account

ottergauze

Operating System

Bazzite (Fedora Linux 40.20240427.0)

Linux Only ~ Desktop Environment

GNOME 46

What happens when the bug or crash occurs?

Using the AppImage results in the default application icon being used in GNOME's panels, whether it be stock, or augmented using Dash to Panel / Dash to Dock.

The application's icons show properly in the application launcher, applications for installing AppImages like Gear Lever, and in the process tray....

simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
#
dclipca
[Vencord/Vesktop] New comment on issue #500: Venmic fails to retrieve audio sources despite me running pipewire (Flatpak)

I had to actually install pipewire-pulse.

To enable Pipewire with PulseAudio support on Linux Mint, you need to install Pipewire and configure it to handle audio instead of the default PulseAudio. Hereโ€™s a step-by-step guide on how to do it:

Update Your System: Before starting, ensure your system is up-to-date.

sudo apt update
sudo apt upgrade
Install Pipewire: You need to install Pipewire and the PulseAudio compatibility layer.

sudo apt install pipewire pipewire-pu...
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
#
BenMatteson
[Vencord/Vesktop] Issue opened: #577 [Bug] Flatpack does not prevent idle

Discord Account

No response

Operating System

Manjaro

Linux Only ~ Desktop Environment

KDE X11

What happens when the bug or crash occurs?

System idles while watching stream (screen dim/off, screensaver, etc.) when using flatpack version.

What is the expected behaviour?

While watching a stream, system idle is prevented
Confirmed appimage works as expected.

How do you recreate this bug or crash?

  1. Ensure a system idle behavior is enabled (screen off, slee...
simple groveBOT
#
AstralPhnx
[Vencord/Vesktop] New comment on issue #575: [Bug] Vesktop AppIcon icon not present on GNOME panels.

Yeah this is partially related to appimages being crapimages. There is a way to fix it though if you modify the .desktop entry using a program like mainmenu and change the "StartupWMClass" variable accordingly it should pick up the proper icon. Far from ideal but workable. Ideally though you'd want to use the flatpak if you're not running using something compiled for your native package manager

hybrid fjord
#

There will be so much merge conflicts with these all 3 tray PRs๐Ÿ˜…

simple groveBOT
simple groveBOT
simple groveBOT
#
Unichy
[Vencord/Vesktop] New comment on issue #406: [macOS] Universal Binary

I know I posted this ages ago, but I have some concerns.

Last time I checked, there was no way for a website to get the architecture of a machine unless weโ€™re talking about the user agent string. In that case, Apple Silicon Macs will pretend to be Intel Macs for privacy.

Thereโ€™s also the issue of users moving between systems. If a user were to transfer their data from an Intel Mac to an Apple Silicon Mac, they would be none the wiser that there is an ARM version for this app. Also, in t...

simple groveBOT
hybrid fjord
#

Also, I have a question
Do we assume that on Wayland if we start AppImage then we will always receive some standard icon instead application icon?

simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
#
Vendicated
[Vencord/Vesktop] New comment on issue #406: [macOS] Universal Binary

Last time I checked, there was no way for a website to get the architecture of a machine

await navigator.userAgentData.getHighEntropyValues([ "architecture", "bitness" ]);

const canvas = document.createElement('canvas');
try {
  gl = canvas.getContext('webgl') || canvas.getContext('experimental-webgl');
  debugInfo = gl.getExtension('WEBGL_debug_renderer_info');
  console.log("vendor", gl.getParameter(debugInfo.UNMASKED_VENDOR_WEBGL))
  console.log("renderer", ...
simple groveBOT
simple groveBOT
#
coinkillerl
[Vencord/Vesktop] Issue opened: #578 [Bug] Drag and drop breaks mouse control in vesktop

Discord Account

CoinKillerL

Operating System

CachyOS Linux

Linux Only ~ Desktop Environment

KDE Wayland

What happens when the bug or crash occurs?

Dragging a dropping a file (for example, an image) completely breaks mouse input for vesktop, making the app only usable with keyboard navigation in wayland native mode. This does not happen on XWayland.

What is the expected behaviour?

Mouse input works fine after dragging and dropping a file

How do you recreate th...

hot juniper
azure verge
#

is there an open issue with electron about the random crashing on electron 30, or is it just us that has the problem

vernal lintel
azure verge
#

tyty

hybrid fjord
#

guys do we have issue when appimage does not have any icon on Wayland?
bc i recently downloaded osu!lazer appimage and it does have icon on wayland for me..
so probably there should be way to add icon?

azure verge
#

lemme check

azure verge
#

the flatpak doesn't

#

lmao

simple groveBOT
hybrid fjord
#

Nvm icon not present in gnome

#

I can't test

#

#575

azure verge
#

it had an icon for me on kde plasma

#

im going to assume its wayland being wayland

simple groveBOT
simple groveBOT
hybrid fjord
hybrid fjord
#

Any ideas what else I can do in Tray voice detection PR?
If no ideas then it is ready to merge

simple groveBOT
simple groveBOT
simple groveBOT
hybrid fjord
simple groveBOT
#
MrGarlic1
[Vencord/Vesktop] New comment on pull request #576: feat: Allow tray icon customization

I had some issues with displaying an image from the local filesystem on the Vesktop settings page. I moved the tray icon setting to a tray icon context menu item, where I think it makes more sense to be. (old method kept on a branch in case this ends up being worse)

image

When selected, it brings up this window which has the same functionality as the setting did before while also showing the curr...

simple groveBOT
azure verge
#

okay

#

we have to do something

#

with content hint motion

#

it doesnt scale aggressively enough

#

mine keeps dropping to like 240p when it gets slightly past the bitrate cap at 1080p

#

and then refuses to scale back up

hybrid fjord
#

Most probably discord at discord_voice implemented own algorithms for downscaling and upscaling depending on available bitrate

azure verge
#

true

#

hmm

simple groveBOT
azure verge
simple groveBOT
azure verge
#

we DONT

#

omfg

simple groveBOT
simple groveBOT
ionic gust
azure verge
#

what is

#

/g/

ionic gust
#

the technology board of 4chan

azure verge
#

ah....

simple groveBOT
#
Tiagoquix
[Vencord/Vesktop] New comment on issue #571: Add a new option to change the tray icon used by Vesktop

#505 and #506 are worth mentioning too, for a third party client which is all about customization it's ironic that the devs shut down any discussion about changing the assets.

On Windows, you can right-click and change the icon, and I believe that applies to the task bar as well.

On Linux, depending on your desktop environment, you can edit /usr/share/applications/vesktop.desktop (at least on KDE Plasma) and change the Icon line to point to an icon name from your icon pack, or to ...

simple groveBOT
simple groveBOT
simple groveBOT
#
Tiagoquix
[Vencord/Vesktop] Issue opened: #580 Question about app.asar

Content

Hi there.

First of all, I'm using this blank issue template because this is a question, and not a bug report nor a feature request.

So, my question is: I found that Vesktop uses (or seems to use) an app.asar file, found in /opt/Vesktop/resources/app.asar.

Considering the file size (16 megabytes), is this the official Discord client app.asar? If so, would it be possible to replace it with OpenAsar or somehow integrate it with Vesktop?

I have seen #112, but I am mak...

hot juniper
#

i have read this thing that explains why it is not possible but i will ask why

simple groveBOT
simple groveBOT
#
MythicalNewt
[Vencord/Vesktop] Issue opened: #581 [Bug] Vesktop flatpak spawns an invisible window that cannot be interacted with.

Discord Account

@mythicalnewt

Operating System

OpenSUSE Tumbleweed

Linux Only ~ Desktop Environment

KDE Plasma 6 on wayland

What happens when the bug or crash occurs?

When vesktop is launched using krunner the loading vesktop window spawns, followed by an invisible fullscreen window that cannot be interacted with.

Closing this window and clicking on the vesktop tray icon works around this issue.

I have included a video to illustrate the issue better:

https://...

#
MythicalNewt
[Vencord/Vesktop] New comment on issue #581: [Bug] Vesktop flatpak spawns an invisible window that cannot be interacted with.

This bug has been happening since 1.5.1 current version showcased in video is 1.5.2


Vesktop - Snappier Discord app with Vencord

          ID: dev.vencord.Vesktop
         Ref: app/dev.vencord.Vesktop/x86_64/stable
        Arch: x86_64
      Branch: stable
     Version: 1.5.2
     License: GPL-3.0
      Origin: flathub
  Collection: org.flathub.Stable
Installation: system
   Installed: 281.6ย MB
     Runtime: org.freedesktop.Platfo...
simple groveBOT
simple groveBOT
simple groveBOT
cursive bear
#

@vernal lintel can you check if you can tap this text to get it to open a popup on vesktop

Screenshot_2024-05-05_at_10.32.26_PM.png
simple groveBOT
simple groveBOT
simple groveBOT
#
TheDrifter363
[Vencord/Vesktop] New comment on issue #377: Vesktop flatpak does not show the screen sharing dialog on Debian

I'm going to add on to this. On Debian 12, Bookworm, and using the latest flatpak, screensharing doesn't work. Get that same "unable to open display". I'm using KDE with wayland. Using the 1.5.0 deb version of flatpak, screensharing works fine. I can't use the later versions of vesktop, since Debian's libstdc++ is too old. Just wanted to post my issues too, hope it helps.

#
MrGarlic1
[Vencord/Vesktop] New comment on pull request #576: feat: Allow tray icon customization

Many thanks for your PR!

To be honest, I don't think an option as "important" as this should be so easily accessible with via right-click. Vendicated's idea ends up fitting better (of displaying the icon on the settings page next to the "Tray Icon" option, instead of your idea of adding new buttons).

That's my end goal too, I just shied away due to literally never having used css or html. After much learning (read: pain), the recent commits moved it back to being in the Vesktop se...

simple groveBOT
simple groveBOT
#
myryk31415
[Vencord/Vesktop] Issue opened: #583 [Bug] Vesktop opens share-picker multiple times

Discord Account

No response

Operating System

OpenSUSE Tumbleweed

Linux Only ~ Desktop Environment

Hyprland

What happens when the bug or crash occurs?

When pressing screen-sharing multiple popus open in this order (next one opens when selecting something):

  1. hyprland-share-picker
  2. Discord/Vesktop screenshare popup for quality etc
  3. hyprland-share-picker
  4. hyprland-share-picker

If I select the same screen 3 times in hyprland-share-picker it streams as expect...

simple groveBOT
simple groveBOT
simple groveBOT
#
Sollace
[Vencord/Vesktop] Issue opened: #584 [Bug] Rich Presence does not work with Proton

Discord Account

No response

Operating System

Manjaro

Linux Only ~ Desktop Environment

KDE

What happens when the bug or crash occurs?

When running a steam game that uses Proton, Vesktop does not pick that up for rich presence. Native steam games work fine, and normal steam is able to detect all steam games with or without Proton.

What is the expected behaviour?

Self-explanatory

How do you recreate this bug or crash?

  1. Install Vesktop
  2. Install Steam
  3. ...
simple groveBOT
hybrid fjord
simple groveBOT
simple groveBOT
simple groveBOT
#
Vendicated
[Vencord/Vesktop] New comment on issue #584: [Bug] Rich Presence does not work with Proton

works on my machine with overwatch, also running in proton. make sure you're on vesktop 1.5.2 and try to check the game's command line to make sure it's not weird.

if the game has native rich presence support (a custom one with stuff like match info, join, etc), then it's not possible for arrpc to handle that, you need to run a bridge in the same wineprefix

![image](https://github.com/Vencord/Vesktop/assets/45497981/f357509e-39db-4...

simple groveBOT
upper pine
simple groveBOT
hybrid fjord
#

V plz review 517))
It's ready to merge

#

Or I can add something if there is any ideas

simple groveBOT
simple groveBOT
simple groveBOT
#
zazFe
[Vencord/Vesktop] Issue opened: #586 Vesktop not passing through audio

Discord Account

@zompireface

Operating System

Debain 12 (Bookworm)

Linux Only ~ Desktop Environment

KDE (Wayland)

What happens when the bug or crash occurs?

i try to start a screenshare which is able to show my screen but no audio passes through at all. I have also tried on launching it with commands specifically with this command which showed me a few errors when screensharing. Side note the screenshare portal also opens up twice before screensharing.

Command: "vesk...

simple groveBOT
simple groveBOT
#
padgriffin
[Vencord/Vesktop] New comment on issue #571: Add a new option to change the tray icon used by Vesktop

On Linux, depending on your desktop environment, you can edit /usr/share/applications/vesktop.desktop (at least on KDE Plasma) and change the Icon line to point to an icon name from your icon pack, or to point to a PNG or ICO file directly.

If you're using the Flatpak version, you can find it at /.local/share/applications/dev.vencord.Vesktop.desktop.

I hate that I have to do this but I am LGBTQ myself, I just prefer the original Discord logo over the VC in my dock. If someone co...

simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
#
literon36
[Vencord/Vesktop] Issue opened: #587 [Bug] Vesktop doesn't start after first run

Discord Account

No response

Operating System

Debian 12

Linux Only ~ Desktop Environment

Gnome on Wayland

What happens when the bug or crash occurs?

On the first run I was able to login and pull my config from the cloud without issues.
Restarting Vesktop results in the shiggy loading screen and the tray icon showing up, but after the loading screen closes, the actual Discord window doesnt show up.

What is the expected behaviour?

I expect the Discord window to sh...

simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
#
Sollace
[Vencord/Vesktop] New comment on issue #584: [Bug] Rich Presence does not work with Proton

By default Vesktop uses arrpc for game detection. Seems like arrpc supports Crab Champions, but in some reason does not detects it in Linux. Can you send how game executable named while started using proton?

@Vendicated
Game's command-line arguments are the default. Using Proton Experimental and a fresh reinstall of Vesktop from yesterday.

image

(screenshot in windowed mode so I can capture...

vernal lintel
#

@turbid depot alt

turbid depot
simple groveBOT
simple groveBOT
hybrid fjord
#

@azure verge in flathub there is released test chromium build where FPS drops and flickering fixed

simple groveBOT
azure verge
hybrid fjord
#

but it crashes for me after some time))0

#

but at least main bug fixed so very very soon it will be in chromium

#

i have feeling that electron will be main problem for us

simple groveBOT
#
SmilerRyan
[Vencord/Vesktop] New comment on issue #23: Portable Settings

For me, i start vesktop.exe with command line paramater like --user-data-dir=C:\MyCustomDataFolder, however it would be nice if the executable automatically set it to a data folder the current directory if a file exists or something like that. A custom startup_args.txt would work too, if one exists it can use them as relative paths (eg. --user-data-dir=Data) do seem to work, and that would also allow having it manage its own startup work without adding my own shortcut to the startup...

azure verge
simple groveBOT
#
SmilerRyan
[Vencord/Vesktop] Issue opened: #588 Custom launch arguments

Discord Account

SmilerRyan

Motivation

Related to issue #23, I'd like to be able to set custom launch arguments for Vesktop without having to make a custom shortcut of Vesktop with my arguments, such as changing the data directory, auto start options, and others. It would also allow the Portable version to be able to be even more portable, by not relying on an extra file on the system (outside the installation directory) for portable builds.

Solution

Create a launch_arguments....

simple groveBOT
simple groveBOT
#
MrGarlic1
[Vencord/Vesktop] New comment on issue #23: Portable Settings

Even with a lack of environment variables, it could theoretically be determined if the install is portable by checking if the platform is windows, and then checking if the parent vesktop directory includes Uninstall Vesktop.exe, as that is only present on windows non-portable installs. It's a bit of a patchwork/imperfect solution, but it could be used to implement this.

I have also noticed that on a portable install, the updater will update by installing a non-portable version.

worn harness
#

@vernal lintel guhhhhh

#

how long until pnpm fix will be on main

#

aur package unupdateable

#

eventually users will complain

#

whyyy push non code change to dev branch aywayss

simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
worn harness
#

@vernal lintel pleaseee

#

just push to main

simple groveBOT
vernal lintel
#

wait do u mean vesktop or vencord

#

@worn harness

simple groveBOT
simple groveBOT
worn harness
simple groveBOT
simple groveBOT
simple groveBOT
cursive bear
simple groveBOT
worn harness
#

@vernal lintel told you

Screenshot_20240507_212945_Proton_Mail.png
#

guh

#

what am I supposed to say

vernal lintel
#

nothing

#

or say its upstream

#

or just submit a pr instead of constantly complaining

worn harness
#

say youll merge and ill do it right now

#

or

#

give me push access

cyan flame
worn harness
#

vee has no bones

simple groveBOT
worn harness
#

merge

simple groveBOT
vernal lintel
simple groveBOT
worn harness
#

ill do

#

i forgot where my fork is

#

ive been using discord custom title bar and the issue doesnt seem to happen

#

wh

#

i cant reproduce the original bug now?

simple groveBOT
ionic gust
#

there i read through all the changes ignoring all the copyright date changes tr

vernal lintel
#

why would they do that lmao

ionic gust
#

stupid

vernal lintel
#

btw even vencord uses a everywhere

#

is Clickable good

ionic gust
ionic gust
#

though i guess it does make sense to use a if you want it to look like a link

#

but also Button has Button.Looks.LINK

#

idk how well it inlines though

vernal lintel
ionic gust
#

yeah true

#

theres also just the Anchor component as well

ionic gust
#

using a raw just kinda brings up the question of if they even fit they styling because i think almost every link in discord uses Anchor, which has classes attached to it by default

simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
cedar nacelle
simple groveBOT
simple groveBOT
hybrid fjord
simple groveBOT
simple groveBOT
simple groveBOT
upper viper
#

idk if its on stabel tho

hybrid fjord
#

@azure verge

upper viper
#

oh wait ignore all i said

hybrid fjord
#

xd

upper viper
#

@vernal lintel you will merge

azure verge
#

mhm

#

that PR is ready to merge

azure verge
#

it's because the exact same patch is in vencord and vesktop rn

azure verge
upper viper
#

hence why i said i thought the thing was merged alr

#

i thought the patch actually broke

#

before i realised

simple groveBOT
hybrid fjord
#

ooooh content hint, right

azure verge
simple groveBOT
simple groveBOT
#
MrGarlic1
[Vencord/Vesktop] Pull request opened: #592 [Windows] Add portable settings/patch updater for portable installs

Resolves #23 and #588

Since the portable build of Vesktop is now a .zip, the previous portable environment variable does not work anymore. Instead, this checks if the platform is windows, and then checks for the presence of "Uninstall Vesktop.exe" in the Vesktop install (somewhat sketchy but it works). If the installation is portable, DATA_DIR is set to be within the portable install so that settings are persistent.

Also patched the updater which would previously download the non-p...

simple groveBOT
#
kerriganx
[Vencord/Vesktop] New comment on issue #545: Hovering over window makes X11 screensharing drop frames

There is a bug in WebRTC capture:
https://issues.chromium.org/issues/333945842
https://issues.webrtc.org/issues/338232699

I can confirm that provided patch (https://webrtc-review.googlesource.com/c/src/+/350042) fixes issue for me.
I have sucess applying the patch for Chromium, I did test web version of Vencord, and it is working without original issue. But having problems to make it work with Electron (to fix issue in Vesktop). Firstly, I have to install fresh archlinux in virtual mach...

#
kerriganx
[Vencord/Vesktop] New comment on issue #545: Hovering over window makes X11 screensharing drop frames

Yes, I think so too. Until the problem is resolved upstream, for those who don't want to wait, they can use one of the following workarounds:

  1. Downgrade kwin to 6.0.2
    or
  2. If you have multiple displays, you can set up capture in OBS, then right click on the preview window and choose "Full-screen Projector". Move projector window to display you NOT streaming. Open Vesktop, start stream and capture that projector window. So that way you basically don't have cursor on streaming display (bu...
simple groveBOT
simple groveBOT
simple groveBOT
#
Lyvelion
[Vencord/Vesktop] Issue opened: #593 [Bug] Rich presence doesn't work at all on OpenSuse Tumbleweed

Discord Account

lyvelion

Operating System

OpenSuse Tumbleweed

Linux Only ~ Desktop Environment

KDE

What happens when the bug or crash occurs?

I previously used Vencord itself, which does not display the game status correctly. I read on reddit that Vesktop allows you to use Rich Presence. I installed the flatpak version [also tried appimage]. When you start the game, nothing happens - no status appears. I tried with games using Proton and with native ones.

I haven't ...

simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
ionic gust
#

bruh

#

oh

simple groveBOT
#
ading2210
[Vencord/Vesktop] New review comment on pull request #355: Add option for custom startup animations

I disagree, since the Electron protocol handler API expects a promise for a fetch response as the return value.

Using a synchronous API for this isn't ideal because it will block the rest of the main process which will increase the startup time as it waits for the file to load.

The Electron docs also say to use net.fetch for reading local files: https://www.electronjs.org/docs/latest/breaking-changes#...

ionic gust
#

sorry i fucking assumed every fucking electron api works the fucking same ๐Ÿ™ƒ

worn harness
#

uh huh

simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
azure verge
#

bleh

#

I wanna work on this more

#

I'm sick :(

#

again :(

vernal lintel
#

aww

simple groveBOT
azure verge
# vernal lintel aww

this is why you shouldn't do what i do and never leave my room unless i get food or have to go to school

azure verge
simple groveBOT
simple groveBOT
marsh hinge
simple groveBOT
worn harness
#

@vernal lintel can i have push access

vernal lintel
#

what for

simple groveBOT
#
IBtheanimator
[Vencord/Vesktop] Issue opened: #596 [MacOS] Vesktop extensions and settings not part of regular discord not appearing on Home Screen

Discord Account

ib_studios

Operating System

MacOS Ventura

Linux Only ~ Desktop Environment

No response

What happens when the bug or crash occurs?

When trying to change added encored plugins I wasn't able to find a encored specific section. I tried restarting and changing versions but it didn't appear. However, it was present a few days ago.

I thought it was because I needed to update vencord however when clicking the popup to do so I received a blank screen

##...

worn harness
simple groveBOT
worn harness
#

rewrite vencord in Rust ๐Ÿš€

azure verge
#

LMAO

simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
hot juniper
# simple grove

shouldn't this be ```js
return a.name.endsWith(PORTABLE ? "win.zip" : ".exe");

simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
#
D3SOX
[Vencord/Vesktop] New comment on issue #18: Custom Keybinds

@Rush Screen sharing is already upstreamed for a while now so as long as that branch is up-to-date you're fine.
For global shortcuts you need to be on X11 or KDE on Wayland and enable Legacy X11 App Support in settings.
As for packaging, just refer to the README and feel free to use whatever you like that Electron Builder supports (I think RPM and AppImage is supported)

simple groveBOT
simple groveBOT
fringe pollen
simple groveBOT
simple groveBOT
simple groveBOT
#
LunarcatOwO
[Vencord/Vesktop] Issue opened: #597 [Bug] window goes offscreen

Discord Account

LunarcatOwO

Operating System

Windows 11

Linux Only ~ Desktop Environment

No response

What happens when the bug or crash occurs?

if i close vesktop (end it ccompleatly) while its on a second screen then disconnect that screen the next time I start vesktop it will just go off screen and is unable to be retrived

What is the expected behaviour?

Expect vesktop to snap back on to main screen.

How do you recreate this bug or crash?

close vesktop (...

vernal lintel
#

why disconnect ur screen ๐Ÿ˜ญ

simple groveBOT
hybrid fjord
vernal lintel
#

nah lol

#

it's our issue

#

we remember and restore window dimensions & coordinates

so if you put it on some monitor then disconnect that monitor, it will try to put it to those coordinates again which puts it off screen

#

just need to see if there's some electron apis for querying monitors then see if the stored coordinates still exist

#

if no reset them to 0

#

i mean realistically this is windows fault cause it shouldn't let apps put themselves out of bounds

hybrid fjord
simple groveBOT
vernal lintel
#

first see if the issue even reproduces xd

#

maybe that guy is just high

hybrid fjord
#

im dead

image.png
azure verge
simple groveBOT
vernal lintel
#

v+ contributor @brave tendon

simple groveBOT
brave tendon
#

oh hello everyone

simple groveBOT
hybrid fjord
simple groveBOT
#
Vendicated
[Vencord/Vesktop] New review comment on pull request #592: [Windows] Add portable settings/patch updater for portable installs

i think this call would make more sense directly under where DATA_DIR is defined

also if (!exists(file)) create(file) is an antipattern since it could potentially lead to a race condition if the file is deleted/created by a different process between these two checks. it's better to just yolo the action and handle errors. or in the case of mkdir, you can just use the recursive option instead:

    mkdirSync(DATA_DIR, { recursive: true });
simple groveBOT
#
Glitchitee
[Vencord/Vesktop] Issue opened: #599 [Bug] Vesktop crash upon startup

Discord Account

Glitchite

Operating System

Debian

Linux Only ~ Desktop Environment

Wayland and X11 were tried.

What happens when the bug or crash occurs?

A few seconds upon booting it crashes. No matter if I uninstall or delete all the prior data.

What is the expected behaviour?

I expect it to open and not close automatically

How do you recreate this bug or crash?

Install vesktop. I assume on Debian with Plasma X11 or Wayland.

Debug Logs

Passing ...
simple groveBOT
vernal lintel
#

how ๐Ÿ˜ญ

hybrid fjord
#

ahahahahahhaha what

simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
scenic hollow
#

yall i wanted some opinions for something
i'm working on an external library for handling global shortcuts
when we receive a shortcut from vesktop it's formatted something like "shift+ctrl+m"
in the external library, the way listening for keybinds works is it gets a key and all the modifiers (shift, ctrl, alt etc) and then it has to match it to a previously defined keybind and if it does find a match then it'd report back to vesktop and tell it to trigger a keybind
currently i'm working on the matching step. should i just parse the key data i get in the library into the string format discord uses and use it as a hashmap key? (i did literally get this idea while writing this. i was gonna say should i have the shortcut be encoded as a tree (like shift > ctrl > a) but i thought perhaps this isn't that bad)

marsh solstice
#

what library are you using?

scenic hollow
#

libuiohook

#

i don't think it provides a way to filter specific key inputs if that's what you are looking for

simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
#
MattheDev53
[Vencord/venmic] Issue opened: #20 Crash when streaming on Vesktop using Linux Mint

โœ๏ธ Bug Description

When trying to stream an application or monitor, the client soft locks after selecting the application or monitor, hanging at "Loading audio Sources...". voice chatting is still possible and the client still animates everything properly, but no longer responds to user input. the desktop environment eventually reports that Vesktop is no longer responding.

๐Ÿ” Steps to reproduce

  1. Join voice Channel
  2. Click Share your Screen Button
  3. Click on a window/screen
    4....
hybrid fjord
#

@upper pine do you have plans in future to add plain pulseaudio support to venmic?

upper pine
#

Yes

#

I already have some basic code

#

But it needs some polish first

hybrid fjord
#

i would like to help as much as i can bc i worked with pulseaudio api

vernal lintel
#

doiesnt chromium have pulseaudio api

#

or is it just pipe

upper pine
#

its pulse but shit

#

pulse in itself is garbage for audio sharing but it def. can be done better than chrome

simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
#
ading2210
[Vencord/Vesktop] Issue opened: #600 [Bug] No application icon present in LXDE

Discord Account

vk6

Operating System

Debian 12

Linux Only ~ Desktop Environment

LXDE (uses Xorg)

What happens when the bug or crash occurs?

When running Vesktop inside the LXDE desktop environment, there is no app icon.

image
This may be related to #575 but it seems like that one is related to the AppImage builds only.

What is the expected behaviour?

I expect the app i...

arctic barn
simple groveBOT
#
Curve
[Vencord/venmic] New tag created: v3.4.3
#
Curve
[Vencord/venmic] tag deleted: v3.4.3
#
Curve
[Vencord/venmic] New tag created: v3.4.3
upper pine
#

Remind me to port the arm workflow to macos

simple groveBOT
#
Curve
[Vencord/venmic] New tag created: v3.4.4
#
Curve
[Vencord/venmic] tag deleted: v3.4.4
#
Curve
[Vencord/venmic] New tag created: v3.4.4
simple groveBOT
upper pine
#

Due to a limitation of Apple's Virtualization Framework, which our hypervisor uses, nested-virtualization is not supported by arm64 runners.

Fuck

#

Are you serious

simple groveBOT
upper pine
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
azure verge
upper pine
#

macos-14 builder would replace the qemu linux builder

#

and thus have no emulation => faster build times

simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
#
thankarezos
[Vencord/Vesktop] Issue opened: #601 [Bug] screenshare doesnt work anymore

Discord Account

thankarezos

Operating System

EndeavourOS Linux x86_64 Kernel 6.6.30-2-lts

Linux Only ~ Desktop Environment

Kde Plasma 6.0.4 wayland

What happens when the bug or crash occurs?

Screenshare doesnt work anymore it just loads like the official discord app. also if I run it from terminal i get this: 'loop->recurse > 0' failed at ../pipewire/src/pipewire/thread-loop.c:426 pw_thread_loop_wait() not sure if pipewire is the problem here tho
![image](https://...

simple groveBOT
#
thankarezos
[Vencord/Vesktop] New comment on issue #601: [Bug] screenshare doesnt work anymore

@Vendicated Its not portal problem, I noticed that sharing does work if noone shares when I press the share. if someone else shares this happens. If I share first even if the other persons shares it still works and I can change windows and screens without problem. Yes the workaround is to tell the other person to close the share for a bit, the only reason I did catch it now was because I was the one only sharing all this time. I think you closed the issue too fast because that's no way it's ...

simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
azure verge
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
vernal lintel
#

someone dmed me this regarding the background unloading

https://www.reddit.com/r/discordapp/comments/fqm69d/fix_process_flag_to_keep_the_cpu_priority_of/

https://github.com/electron/electron/issues/2822#issuecomment-141462244

Reddit
From the discordapp community on Reddit: FIX - Process flag to keep...

Explore this post and more from the discordapp community

GitHub
Process priority when application is minimized on dock or not focus...

I'm developing a CPU intensive application with electron and i'm experiencing some issue with process priority. We have a native module written in C doing signal processing (low level) and ...

#

definitely worth a shot

simple groveBOT
simple groveBOT
simple groveBOT
#
Rush
[Vencord/Vesktop] New comment on issue #18: Custom Keybinds

For global shortcuts be warned that push to talk does not work and you need to be on X11 or KDE on Wayland and enable Legacy X11 App Support in settings. Then just use Discord's keybind settings.

Cool. I was able to have Mute work - but I am seeing an issue when Discord is out of focus. When in focus it's instant, when out of focus it sometimes takes half a second for mute to take effects. Did you see that?

azure verge
#

I haven't been able to produce the background issue but I hope that works

simple groveBOT
simple groveBOT
#
Rush
[Vencord/Vesktop] New comment on issue #18: Custom Keybinds

@Rush No it works for me when it's not focused. Which Discord client and desktop environment are you using?

It works, it's just delayed & laggy when Vesktop is not focused. Using your Vesktop fork. KDE. I opted for the "Legacy X11 App Support" way and its keystrokes redirection.

simple groveBOT
simple groveBOT
#
MalakaiJA
[Vencord/Vesktop] Issue opened: #603 Vesktop crash & restart my PC as soon as logging in

Discord Account

J.m.a.f.a.a.b.a

Operating System

Nobara

Linux Only ~ Desktop Environment

Wayland

What happens when the bug or crash occurs?

Vesktop was disconnecting giving me issue of Java script issue for themes and csnt join voice. Later on I did reset vesktop/vencord & typed my credentials for logging in & suddenly my PC restarts by itself. Did same thing and same sudden restart. Now I don't understand what us up. My PC is modern & current gen.

What is the e...

azure verge
#

okay maybe a dumb question but all i need to make RPC work is to enable the wine discord ipc bridge right
or is arrpc still broken

simple groveBOT
#
Vendicated
[Vencord/Vesktop] New comment on issue #603: Vesktop crash & restart my PC as soon as logging in

your pc's age does not matter. it might be a hardware failure (for example because something isn't properly connected) or just a software failure. you use a linux distro i've never heard of before... it might be a driver, etc

but it's not vesktop. you'll have to figure it out yourself, we can't help more than that! inspect the relevant logs (dmesg, journalctl, etc) or worst case scenario try reinstalling your OS

in any case, that's very out of scope for vesktop. good luck though

simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
azure verge
# simple grove

@vernal lintel nobara is basically fedora but more optimized for gaming afaik
fairly popular from what ive heard

marsh solstice
#

Idk honestly happened after putting another 64 GB of Rams & booted my PC
doesn't even matter, its broken ram not distro issue

simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
#
LunarcatOwO
[Vencord/Vesktop] Issue opened: #604 [Bug] vesktop starting offscreen

Discord Account

LunarcatOwO

Operating System

Windows 11

Linux Only ~ Desktop Environment

No response

What happens when the bug or crash occurs?

#597 samething is still happening

What is the expected behaviour?

not to go offscreen

How do you recreate this bug or crash?

same as #597

Debug Logs

N/A

Request Agreement

  • [X] I have searched the existing issues and found no similar issue
  • [X] I am using the latest Vesktop and Vencord versions
  • [X] ...
simple groveBOT
simple groveBOT
simple groveBOT
#
Lythium4848
[Vencord/Vesktop] Issue opened: #605 [Bug] High Memory Usage

Discord Account

lythium4848

Operating System

Fedora 40

Linux Only ~ Desktop Environment

KDE 6 on Wayland

What happens when the bug or crash occurs?

Vesktop uses extremely high amounts of memory
image

What is the expected behaviour?

Vesktop to not be using large amounts of memory

How do you recreate this bug or crash?

Unknown - Was screensharing in a vc at the time ...

hybrid fjord
#

how๐Ÿ˜ญ

simple groveBOT
simple groveBOT
simple groveBOT
worn harness
#

guh what do i even do

#

pnpm updated again now vencord-desktop-git wont build

#

ERR_PNPM_BAD_PM_VERSIONโ€‰ This project is configured to use v9.1.0 of
pnpm. Your current pnpm is v9.1.1

#

aaaa

#

help me

gentle hatch
# 
diff --git a/package.json b/package.json.911
index 0e58459..9d8284d 100644
--- a/package.json
+++ b/package.json.911
@@ -71,7 +71,7 @@
         "zip-local": "^0.3.5",
         "zustand": "^3.7.2"
     },
-    "packageManager": "pnpm@9.1.0",
+    "packageManager": "pnpm@9.1.1",
     "pnpm": {
         "patchedDependencies": {
             "eslint-plugin-path-alias@1.0.0": "patches/eslint-plugin-path-alias@1.0.0.patch",
#

ยฏ_(ใƒ„)_/ยฏ

vernal lintel
#

you could use corepacker

worn harness
#

whats that

worn harness
#

i dont wanna do that

gentle hatch
#

oh no changing 1 line in package.json

worn harness
#

thats not the point

#

i want to keep it fully self sufficient

gentle hatch
#

can always just

sudo npm uninstall -g pnpm && sudo npm i -g pnpm@9.1.0
worn harness
#

im looking at

#

idk

#

corepacker is set to provide pnpm on aur

#

vencord-desktop-git requires pnpm or corepacker installed currently

#

trying to see if other electron aur packages have a solution

worn harness
#

I see that a lot of packages use npm

simple groveBOT
hot juniper
azure verge
simple groveBOT
worn harness
#

Could "packageManager": "pnpm@9.1.0", be changed to only require a specific major version?
like: ^pnpm@9.1.0 would be everything including and after 9.1.0

vernal lintel
#

no

worn harness
#

only minor changes so its unlikely to break vesktop packaging

#

why

vernal lintel
#

not valid, is it?

worn harness
#

it is

#

actually wait

#

it might be ^ before the ver

vernal lintel
#

no

#

you cannot

#

it's not valid

worn harness
#

why even specify a specific version in packageManager

#

its experimental
plus engines already does that

#

hmm

#

@vernal lintel so either

  • I modify vencord-desktop-git to instead depend on nodejs>=18 in makedeps and have that use the bundled corepack to call pnpm
    or
  • remove packageManager key in vesktop
#

idk if first one would work though i need to test

#

g

#

cant use package:dir script cause it hardcodes using pnpm from PATH

#

cant use corepack enable cause that requires elevated permission

#

well this is the only solution i see ```
build() {
pnpm() {
corepack pnpm "$@"
}

cd "$pkgname"

pnpm i && pnpm build && corepack pnpx electron-builder --dir
}

#

i await further instruction from Vee

vernal lintel
#

wha

#

how does it hardcode using from path

worn harness
#

wha

#

i wil show you

#

sh: line 1: pnpm: command not found

#

it tries to invoke pnpm without the corepack prefix

#

pnpm isnt in path

vernal lintel
#

how

#

what corepack prefix

worn harness
#

corepack has to be manually installed using sudo corepack enable

worn harness
#

corepack pnpm

#

package:dir calls pnpm

#

not in path though so it fails

vernal lintel
#

unlucky

worn harness
#

telll

vernal lintel
#

idk how to fix

worn harness
#

remove packageManager field blobcatcozy

vernal lintel
#

nop

#

can't

worn harness
#

yop

#

engines does the same thing

#

wont use

#

i think just removing explict packageManager is simpler and less error prone

vernal lintel
#

tbh it's kinda shitty that it can't specify a version range

but i guess it's because it's supposed to be where corepack automatically downloads the specified version

worn harness
#

i think engines is pnpm specific

vernal lintel
#

nuh uh

#

try to add engines without removing package manager field

#

and see if works

worn harness
#

whar

#

wdym

vernal lintel
#

both

worn harness
#

it works if i remove packageManager field

vernal lintel
#

nop

#

both

worn harness
#

why

#

corepack doesnt use engines

#

im so confused

vernal lintel
#

i said try both at once and see if it fixes

worn harness
#

thats how it is already?

#

it doesnt

vernal lintel
#

just remove the field or cope

worn harness
#

imm sso confused

#

im all for removing the field

vernal lintel
# 
jq 'del(.packageManager)' package.json
worn harness
#

jq

vernal lintel
#

run this before build

#

add jq to makedep

worn harness
#

HONP