#๐Ÿ–ฅ-vesktop-development

1 messages ยท Page 7 of 1

hybrid fjord
#

mac moment (its all stupid)

feral fulcrum
#

I enjoy macOS, i still use it on my laptop from time to time

azure verge
#

see this is why i roped you into this

hot juniper
#

i would get a mac but i would probably install linux on it after like a week

azure verge
#

id buy a mac JUST to test asahi

vernal lintel
azure verge
#

i think itd be fun

vernal lintel
#

need to use this

hot juniper
vernal lintel
#

btw why doesn't electron use this

azure verge
#

plus i need a new ARM device

hot juniper
feral fulcrum
azure verge
#

a javascript program

hot juniper
#

nuh uh

feral fulcrum
#

Its also 16k by default

#

:3

hot juniper
#

i have one sitting on my desk

#

i do NOTHING with it

#

give me something to do with it

feral fulcrum
#

I have one in the living room, its running android tv

vernal lintel
feral fulcrum
vernal lintel
hybrid fjord
hot juniper
vernal lintel
#

so its coming, just ETA 2038

hybrid fjord
#

or Moonlight for playing games on TV

hybrid fjord
feral fulcrum
hot juniper
sly cairn
#

youll have to clone the flatpak manifest and alter it to point to the local appimage

feral fulcrum
#

I say this but i run 3 pihole instances in my home pain

hot juniper
#

we should start yapping in another channel

feral fulcrum
#

and because my second proxmox host is a different architecture i had to create a new one anyways

#

So i just made a third one

#

Instead of deleting and recreating the 2nd one

azure verge
#

ty

vernal lintel
#

to add more paths such as ~/.icons

azure verge
#

real

#

also i am so new to flatpak dev oml
i tried running it and WOW it broke instantly

#

but it seems to be because its not allowed the right permissions even though i gave it the manifest????/

#

confusing

#

wait

#

no

#

im just a dumbass

#

vesktop is already running

#

nvm

#

it is in fact broken

#

the fact that it cant find an x server is weird to me

#

i have xorg-xwayland

#

nope it was just hating being run like that

#

it works after installing it

#

flatpak seems to work well

simple groveBOT
#

Can you build this PR as a Flatpak (https://github.com/flathub/dev.vencord.Vesktop) and validate it works? We have a decent amount of users using it via Flatpak now so it needs to be tested

I also use it as a flatpak, and I just confirmed that I am able to build and run it as a flatpak, with the streaming modifications. I didn't do any sort of rigorous testing, but I did confirm that it works.

simple groveBOT
#

After updating Arch to the latest packages, Vesktop stopped working, and just segfaults

To Reproduce

  1. Open Vesktop
  2. Wait for it to load
  3. Watch it crash with a segfault

Expected behavior
Vesktop working
ะธะทะพะฑั€ะฐะถะตะฝะธะต

Desktop (please complete the following information):

  • OS/Distro: Arch Linux
  • Desktop Environment (linux only): Plasma 6
  • Version: Rolling rele...
hybrid fjord
#

why --disable-gpu flag?

hot juniper
simple groveBOT
azure verge
#

........

simple groveBOT
azure verge
hybrid fjord
#

change versions in config files
cry and open issues that it segfaults because of 30 electron

azure verge
#

REAL

simple groveBOT
#

it was closed because this has nothing to do with our code. it's an issue with either your system or the electron version you're using (which is not supported by us). find official supported artifacts in releases. if you install differently, you're on your own.

do not deliberately open duplicate issues or you will be blocked from opening further issues

azure verge
strange turtle
#

Hello everyone, I have previously opened an enhancement issue regarding to screenshare audio support for MacOS. https://github.com/Vencord/Vesktop/issues/472
I am uncertain who takes the reign of MacOS development here, however I have implemented a naive solution to support Loopback as a Mic-In input for soundshare audio. I lack the knowledge (and time) to dabble further into making it a customizable audio source selector, but I hope this small demo helps with getting the ball rolling for MacOS soundshare support.
https://github.com/Vencord/Vesktop/compare/4abae9c7082081dcae667916d9608e23adf688a9...EndenDragon:Vesktop:c260e5526729587fdd7c8778377b0d2e9021f65d

Alternatives to Venmic already exists for MacOS such as in the form of Loopback or Blackhole, so I think simply supporting the option to select a Mic-In input would be minimally sufficient.

I am happy as well to help with testing any changes directed for MacOS if you need some additional hands.

simple groveBOT
upper pine
#

Yeah BlackHole should do it, I'll see if I can add an option to use it as a source in the stream dialog

hybrid fjord
#

I have some news (??) about FPS issue
At least they will do something

azure verge
#

OOOH

#

YOO

upper pine
#

We can also investigate using the system API later on

strange turtle
#

Note that the System API is only supported on later version of MacOS. I believe that is MacOS 13+, however I cannot confirm since I am running on 10.15.

azure verge
#

i think it would be good to support both maybe

strange turtle
#

It would be good- as long as there is a conditional that is in place to enable it for OS that supports it. I didn't like it when Discord straight up removed support for older MacOS versions.

azure verge
#

big tech companies:

strange turtle
#

truth

azure verge
#

oh my god

hybrid fjord
#

discord support is not helpful at all :c

#

like spotify xd

azure verge
#

real

#

took them like 2 weeks to recover my account when it was bungled

hybrid fjord
#

then only can say some template phrases and something like "reboot pc"

simple groveBOT
azure verge
#

@vernal lintel

new language to write vesktop in just dropped

runic inlet
#

yappachino

topaz dove
#

kotlin range syntax blobcatcozy

hybrid fjord
#

will we use rule "it works == do not touch it"?

simple groveBOT
hybrid fjord
#

where i can see example of using logger?

vernal lintel
#
const logger = new Logger("VesktopScreenShare");

// same methods as console
logger.error(...);
hybrid fjord
#

thanks)

vernal lintel
simple groveBOT
vernal lintel
#

see where they do it and hook into that

hybrid fjord
#

okay without timeout it really broken
I have an idea to find out which function discord uses for setting default fps and overload it with user picked settings

azure verge
#

I believe it's just once electron processes the replacetrack function

#

not sure tho

hybrid fjord
hybrid fjord
# azure verge I believe it's just once electron processes the replacetrack function

looks like it works but:

  1. debug menu brakes
  2. in my current approach it will reoverload function on every stream changing (or maybe even stream strarting), this is bad. Need to move code somewhere else
    const originalReplaceTrack = conn.videoTransceiver.sender.replaceTrack; conn.videoTransceiver.sender.replaceTrack = async function () { logger.log("Called overloaded replaceTrack!"); originalReplaceTrack.call(track); };
humble mortar
#

built vesktop with electron 30 launched to test hardware encoding (it worked) now getting segfaults $ electron30 /usr/share/vesktop/app.asar [arRPC > ipc] listening at /run/user/1000/discord-ipc-0 [arRPC > websocket] listening on 6463 [arRPC > process] started [13536:0416/173856.744586:ERROR:gl_surface_presentation_helper.cc(260)] GetVSyncParametersIfAvailable() failed for 1 times! [13536:0416/173856.753443:ERROR:gl_surface_presentation_helper.cc(260)] GetVSyncParametersIfAvailable() failed for 2 times! [13536:0100/000000.281612:ERROR:broker_posix.cc(41)] Recvmsg error: Connection reset by peer (104) Segmentation fault (core dumped)

upper pine
hybrid fjord
upper pine
hybrid fjord
#

setTimeout was temporary too xD

upper pine
#

True xd

hybrid fjord
#

at least stable working

hybrid fjord
#

@azure verge we probably should use user picked width and height for max values too?

real glade
#

no

#

oh for max

azure verge
#

true

#

yeah

#

not for min

#

but for max yeah

simple groveBOT
hybrid fjord
#

lol plasmashell crashed when changed stream xd

hybrid fjord
#

wtf this errors

#

i receive them when not-stable stream resolution changing works

#

Kait can you test whether changing stream description and fps works ALWAYS for you?
I noticed it changes with ~80% chance

#

or maybe i just broke smth with major refactoring ๐Ÿ™‚

hybrid fjord
#

Okay i really believe i didn't broke anythin
At least all in same functionality as before for me
and at least we can revert commit if everything will be bad xd

simple groveBOT
#

Describe the bug

When vesktop loses window focus the app crashes.

To Reproduce

  1. Open Vesktop
  2. Change window focus

Expected behavior
Vesktop properly loses focus, but does not crash.

Desktop (please complete the following information):

  • OS/Distro: EndeavorOS
  • Desktop Environment (linux only): KDE6

Command line output

$ vesktop
[arRPC > ipc] listening at /run/user/1000/discord-ipc-0
[arRPC > websocket] listening on 6463
...
#

Apologies, I only just realized this is now a duplicate of issues opened 6 hours ago (I didn't expect something so new to be closed already). Based on the comments in those threads you have claimed the issue does not lie with Vesktop, but instead an upstream dependency (so Electron?) How can we be certain the issue lies there and not in the implementation? I'm not seeing any issues for other apps having a similar problem. Which means it must be unique to Vesktop's implementation somehow.

simple groveBOT
azure verge
#

always

azure verge
#

uhhh

#

sorry im rly busy today but i can try

simple groveBOT
simple groveBOT
#

VM827 react_devtools_backend.js:4026 Vencord Webpack Error: webpack.findByCode found no module
at Jn (webpack.ts:96:17)
at i1 (webpack.ts:324:9)
at webpack.ts:334:28
at [vencord.lazy.get] (lazy.ts:98:38)
at Wa. [as apply] (lazy.ts:56:65)
at index.tsx:78:47
at aS (44076.b5f9426088ebaff2b53a.js:12:899964)
at u (44076.b5f9426088ebaff2b53a.js:12:955175)
at sB (44076.b5f9426088ebaff2b53a.js:12:938190)
at 44076.b5f9426088ebaff2b53a.js:12:938056 ...

hybrid fjord
azure verge
#

fuc sorry I've been rly busy

#

I'll get back to focusing on this a lot more

#

in the next few days

#

but

#

lemme read that commit rq

azure verge
#

so

#

I like that a lot

#

it makes sense

#

why do it twice

#

so tbh

#

I really like it

#

what broke tho

#

also I love the logger transition

hybrid fjord
#

Maybe it was on previous commits but we didn't noticed

azure verge
#

oh odd

#

I'll try on an older commit

#

and on latest

#

just remind me in like

#

8-9 hours

hybrid fjord
#

xD

azure verge
#

it's 23:37

#

I need to sleep

hybrid fjord
#

I'll probably retest later, but in 5 hours
For me it's 06:37 xd

azure verge
#

oml

#

yeah

#

lmk and I will gladly test and debug

#

I've been doing a lot today

#

most notably I'm working on my NAS :3

hybrid fjord
#

Wooow

#

Nintendo Switch is sooo cute ^-^

noble pagoda
#

I almost thought that was a switch lite husk

azure verge
azure verge
#

it's just a fully reshelled year 1 switch

#

entirely blocked from Nintendo servers and I refuse to pay for anything

noble pagoda
#

more w's

azure verge
noble pagoda
#

yes

#

cute

#

good

azure verge
#

:3

simple groveBOT
simple groveBOT
hybrid fjord
hybrid fjord
#

okay, it does looks like regression.
i will try to get connection in screenShareFixes.ts

simple groveBOT
hybrid fjord
#

fixed it. I believe now is the most stable and clean way to do things with screen sharing

simple groveBOT
hybrid fjord
#

yeap

upper pine
#

Ah, it was not about the setTimeout thing though right

#

Can that also be avoided?

hybrid fjord
#

i tryed many things but it we avoid setTimeout then changing resolution would break

#

ds will just apply screen res x 30 fps

#

even if in logs there are NOTHING about 30 fps

upper pine
#

Can we not hook into the method that applies the changes?

#

And just prevent the update

hybrid fjord
#

you mean override something like setTrack to do nothing?

upper pine
#

Yes

#

Depending on the caller

hybrid fjord
#

most propably it will break discord negotiations on low bitrate
and it breaks debug menu

upper pine
#

Just make it depend on where it was called from (inspect the caller) and check the params that were set

hybrid fjord
#

i will try, but later

#

in few hours

hybrid fjord
#

caller deprecated??

#

and iirc replaceTrack() is async function :c

upper pine
#

ah then see if you can find out anything from the params

simple groveBOT
vernal lintel
#

but there's most likely a better way

azure verge
#

ghuhg

azure verge
#

anything that can be done or are we just

hybrid fjord
# azure verge anything that can be done or are we just

Looks like we can do anything
It because Firefox automatically disables DmaBuffers by default on problematic drivers (lwe have many errors because of them)
I asked whether we can somehow disable them in chromium and if so then we may try to put another CLI argument or something like that

azure verge
#

good idea

#

what about the weird jittering

#

or is that what you mean

simple groveBOT
hybrid fjord
hybrid fjord
#

why people keep creating issues when problems with AUR packages T_T

azure verge
#

its called the arch USER repository

#

cry about it

#

its not always perfect

simple groveBOT
#

Windows 8.1 and below (and even some early windows 10 versions) has already long reached their EOL. For your own safety, do not use softwares after their EOL, especially OSes, as your security may be compromised. Security issues are not solved anymore after them. If windows 10 or above can't run well on your hardware, you may consider some linux distribution, as they are a lot more lightweight.

hot juniper
#

i can indeed recommend linux

hybrid fjord
#

xd

simple groveBOT
azure verge
#

really looking good to

#

not use windows

hybrid fjord
#

linux gaming ricing, what else do we need xd

azure verge
#

i wonder why its called ricing

hybrid fjord
#

maybe my mistake in words

#

i mean growing, something like that

azure verge
#

nono

#

wait

#

maybe

#

true

#

idk

#

brain not working

#

ricing is like
customizing linux

#

im confused why that's called ricing

#

but sure

hybrid fjord
#

i meant rising

#

xd

#

remembered how it is written

#

is there any way to get discord's connection in console?

ionic gust
azure verge
#

as i hear it

#

LMAO

ionic gust
#
ionic gust
simple groveBOT
#

Describe the bug
Crashes immediately after fox-girl gif start-up screen, no further graphic output is reached

To Reproduce
Start Vesktop by any means

Expected behavior
Vesktop starting

Screenshots

Desktop (please complete the following information):

  • OS/Distro: Arch Linux
  • Desktop Environment (linux only): sway
  • Version: Vesktop 1.5.1-1, Arch Linux latest

Command line output

[56658:0417/193243.581460:ERROR:obje...
hybrid fjord
#

oh......

azure verge
vernal lintel
#

please stop

#

what are people thinking opening these issues

#

you're using an unsupported version then complaining that it doesn't work ๐Ÿ˜ญ

ionic gust
#

electron dont release broken versions challenge

#

but also this is why i hate arch

vernal lintel
#

what did electron even cook

#

this isn't even beta, it's a stable release

ionic gust
#

asar fuse on windows

#

oh fucking boy

hybrid fjord
ionic gust
#

yes but the people complaining arent using it, they're just using electron-bin and a portable copy more than likely

hybrid fjord
#

yeap

simple groveBOT
vernal lintel
ionic gust
ionic gust
vernal lintel
#

embeddedAsarIntegrityValidation sounds awful

ionic gust
vernal lintel
#

oh only macos

#

why only macos lol

ionic gust
#

cause its checked in the plist

#

but with electron 30 they figured out a way to do it on windows so

vernal lintel
#

uh oh

#

but you can probably patch it out somehow

#

or maybe replace smth like discord desktop core instead

ionic gust
#

We recommend all Electron application executable to be signed after resource modification. A tampered Electron executable will break the existing executable certificate and change the executable checksum, which will trigger Microsoft Defender SmartScreen

azure verge
#

damnit

hybrid fjord
#

"improvements"

simple groveBOT
hybrid fjord
#

ahahaha electron ^30

simple groveBOT
humble mortar
ionic gust
#

doesnt affect me any cause i use windows

#

and if i were to use linux id probably be on void so

#

but also it makes no sense to install apps you're going to mod through the package manager anyways

humble mortar
#

vesktop is a package

#

vesktop is an app

azure verge
#

dingus

humble mortar
#

whos the aur pkgbuild maintainer

#

also

#

venmic isnt needed on electron30 now

simple groveBOT
ionic gust
#

thats for entire system, not individual windows

#

venmic is still needed

#

normal webrtc screenshare on browsers does not support individual windows

simple groveBOT
#

I do not believe this will be fixed by #489.
Screensharing uses system's xdg-desktop-portal call for capturing the stream. If you can't see your applications in system (portal) picker that means that problems with portal, not with Vesktop.
Maybe you migrated from different DE and not installed right xdg-desktop-portal? For example, for KDE check whether xdg-desktop-portal-kde installed and so on.

vernal lintel
#

so venmic is likely still needed

humble mortar
#

guh

#

also

#

what every caused this to be magically fixed

#

its broken again it seems

#

tested in a clean env

simple groveBOT
#

I do not believe this will be fixed by #489. Screensharing uses system's xdg-desktop-portal call for capturing the stream. If you can't see your applications in system (portal) picker that means that problems with portal, not with Vesktop. Maybe you migrated from different DE and not installed right xdg-desktop-portal? For example, for KDE check whether xdg-desktop-portal-kde installed and so on. Please provide more info about your current DE and system.

Im running vesktop on windo...

humble mortar
#

plasma issue most likely

#

does anyone know any other apps which use the unread indicator

hybrid fjord
#

some messengers? telegram-desktop?

simple groveBOT
#

@Vendicated The bug report template sucks. But this is one way to ignore not working features I guess, since these features seems to be broken for other users aswell LOL?

@PolisanTheEasyNick It must be Vesktops bug, since it works with stock discord, vencord, betterdiscord without problems. Even with discord portable.
But im not here to argue or smth, its just strange that nobody is fixing this stuff, since its obviously broken lol?

ionic gust
humble mortar
#

6

#

nope its working for telegram desktop

#

i wonder if its an xwayland issue

ionic gust
#

probably

#

i wouldnt be surprised

hybrid fjord
#

V you can restart test for 489

#

i have bugs with this unread icons too on KDE 6

#

its so random, i just restart plasmashell

ionic gust
#

in general or also xwayland

hybrid fjord
#

in general

ionic gust
#

all apps or just vesktop

hybrid fjord
#

noticed on telegram-desktop, maybe somewhere too

#

telegram-desklop on wayland or xwayland?
edit: wayland

ionic gust
#

then yeah thats just a plasma 6 moment, not surprised

#

shitshow of a release imo

humble mortar
#

not working in vesktop under wayland

humble mortar
#

nothing show stopping

ionic gust
#

if you're just a basic individual that uses flat themes, sure

#

but they changed so much that its so annoying to even begin to port shit like aerothemeplasma

humble mortar
#

thats not a shitshow of a release

ionic gust
#

their docs are pretty shit

#

plus theres still some stock widgets that arent ported yet like that one dock one

#

i think theres some distros that upgraded it without testing anything and a lot of things broke as well idr

humble mortar
#

if that did happen thats user error

ionic gust
#

or packager error

humble mortar
#

same thing

#

plasma6 as a whole has been fine

upper pine
humble mortar
#

Actually

#

telegram doesnt use libunity

ionic gust
#

i just think they simply dont care because it has a limited usecase outside of electron apps as it is

#

we're the minority of use cases here

upper pine
humble mortar
vernal lintel
#

we talked about this before

ionic gust
humble mortar
#

ill spin up a vm

#

whats a recentish distro still on plasma5

upper pine
#

Some older fedora version maybe?

#

(i think there are KDE flavors of fedora right?)

humble mortar
#

nvm just remembered i nuked my system a few days ago

#

im not bothering with vm stuff rn

upper pine
#

I can spin up a VM tomorrow

humble mortar
#

ill leave a comment with what ive narrowed it down to on the issue

humble mortar
upper pine
#

You wanted to test if the notification badges are only broken on plasma6 right?

humble mortar
#

yea

upper pine
#

Alr

humble mortar
#

specifically libunity notification badges

upper pine
#

Are there any reference apps using that?

humble mortar
ionic gust
upper pine
#

I had the most fucked plasma problem the other day

#

Not sure if it was because of plasma6 or Wayland

upper pine
#

I plugged my laptop in at Uni to show something and it just turned my laptop screen black and only showed video on the Beamer, when I plugged the HDMI out I still had no video on my laptop

#

Couldn't fix it from the tty even when deleting kscreen configs

humble mortar
#

what gtk version is discord

#

3?

upper pine
#

Should be

#

99% sure it isn't 4

humble mortar
#

a post on the discord flathub repo says libindicator is needed

upper pine
#

Should be ayatana then

humble mortar
#

extra/libindicator-gtk3 is its own repo

#

nope that wasnt it

#

actually

#

what about the electron version

#

i dont remember it ever working on electron29

ionic gust
#

discord is still on 28

#

28.2.10 to be exact

humble mortar
#

27 doesnt work

#

alr its very likely an issue with libunity and plasma 6

#

2021-04-13 was the last modification to the repo as far as i can tell

#

unless im horribly confusing how discord determines when to show an unread badge

simple groveBOT
hybrid fjord
#

xd

#

welcome to nvidia wayland kde

humble mortar
#

this is screensharing

#

on my amd igpu

#

this is what the screenshare looks like on their end

#

0 encoder usage

hybrid fjord
#

looks like explicit sync glitches

humble mortar
#

weird

#

the thing thats the most weird is the encoder usage being 0

#

it was fine yesterday

simple groveBOT
#

You actually can do it yourself (at least for the taskbar part), if in windows you can create a link, go to properties, change the link icon and fix the link in the taskbar, if in linux you can go to properties and just change the icon.

Main point of vesktop is to improve linux experience, because of that it should bee implemented in source.
Also, i really like the idea of changing this gay logo to something less political.

hybrid fjord
#

ahahahhahahhaha

cyan flame
simple groveBOT
#

Sorry for bumping an old issue, but I did some investigation about how we can get this functionality to work.
Firstly, we need to get connection object from MediaEngineStore:
const conn = [...MediaEngineStore.getMediaEngine().connections][0];
If we can successfully get [0] element from connections array, it means that we are at some VC.
Then we can get property whether we are muted using this:
const isMuted = conn.input.audio._mute;
And we can get whether we are speaking rn like t...

#

Sorry for bumping an old issue, but I did some investigation about how we can get this functionality to work. Firstly, we need to get connection object from MediaEngineStore: const conn = [...MediaEngineStore.getMediaEngine().connections][0]; If we can successfully get [0] element from connections array, it means that we are at some VC. Then we can get property whether we are muted using this: const isMuted = conn.input.audio._mute; And we can get whether we are speaking rn like this:...

#

Describe the bug
Clicking the "A Vencord update available!" notification makes the whole window blank. Another issue I found while I tried to investigate is that the "Vencord" settings on the left is gone.

To Reproduce
Steps to reproduce the behavior:

  1. Open Vesktop
  2. Wait a few seconds before the notification appears
  3. Click on the notification
  4. See error

Expected behavior
It should show me the changelog and the option to update.

Screenshots
![...

#

You actually can do it yourself (at least for the taskbar part), if in windows you can create a link, go to properties, change the link icon and fix the link in the taskbar, if in linux you can go to properties and just change the icon.

Main point of vesktop is to improve linux experience, because of that it should bee implemented in source. Also, i really like the idea of changing this gay logo to something less political.

But I just said it can also be done in linux just as ea...

hybrid fjord
#

That's how I live)

humble mortar
#

its only the screen share though ๐Ÿ’€๐Ÿ’€๐Ÿ’€

#

also AMD not nvidia

hybrid fjord
humble mortar
#

I'll try stock discord in a bit

simple groveBOT
hybrid fjord
#

Here we areee

simple groveBOT
simple groveBOT
azure verge
#

omg

vernal lintel
#

not released for now cause i believe curve also wants his pr in

#

and maybe some more

#

but in the next few days

azure verge
#

mhm

#

awesome

#

if you need me to test anything lmk
I've just been so busy and I'm still struggling with my NAS lmao

vernal lintel
#

nono focus on u

#

your efforts already helped a lot

#

thanks for the work

azure verge
#

aaayggd

#

no I

#

I really wanna help here more

#

I feel bad for last time

#

I kinda disappeared after audio screensharing

simple groveBOT
simple groveBOT
#

if you check out #326 the most recent commit kinda does that. it exposes a cli that can execute different keybinds by code. though i was thinking this would be used as fallback. plans are being made for better ways to do this but i am really busy with school as of right now and can't really contribute much.

This looks like a great first step! Does this only work for oneshot keybinds or would this work with push to talk too potentially in the future?

humble mortar
humble mortar
#

I'm going to sleep

simple groveBOT
vernal lintel
azure verge
azure verge
#

its been a known problem

#

if you mean the jittering

simple groveBOT
simple groveBOT
simple groveBOT
#

the older(and now removed) electron api based global shortcut handler didn't at all support push to talk
the current cli doesn't handle pressed and unpressed states tho it should be super easy to add
we are planning better ways to do this. i was thinking the cli could be used as fallback for wayland users. currently the only way to handle keybinds for wayland users is through xdg-desktop-portals which last time i checked didn't really have a mature implentation of this. though it probably has...

simple groveBOT
simple groveBOT
simple groveBOT
humble mortar
#

im not running nvidia though

#

its also not using hardware encoding at all (viewing via nvtop)

#

chromium itself can use encoding fine

simple groveBOT
humble mortar
#

guess it was scuffed

#

jittering doesnt happen under x11

#

ยฏ_(ใƒ„)_/ยฏ

hybrid fjord
#

What's the difference between findByPropsLazy and findByProps not lazy?

humble mortar
#

at least switching sessions take like 2 seconds

simple groveBOT
simple groveBOT
upper pine
#

I'd say pulse support is something for the release after the next one, I'll have to make sure that's battle-tested before we add it :D

simple groveBOT
hybrid fjord
#

can i add myself to devs in future PR?

#

ohh nvm, devs are not in Vesktop project

azure verge
#

pretty sure it's chromium being chromium

simple groveBOT
humble mortar
#

no jitter with pure X11 session

azure verge
#

ofc

vernal lintel
#

i just run vesktop in xwayland

#

works way better for me

humble mortar
#

I do too

#

the jitter exists there as well

#

I do wonder if its a kwin wayland issue though

#

I'll try another wayland compositor next I have a chance

simple groveBOT
hybrid fjord
#

can we include #517 in next release too? if pr is good

simple groveBOT
azure verge
#

it genuinely might be kwin

vernal lintel
hybrid fjord
#

oki, i will try my best to fix everything based on reviews

vernal lintel
vernal lintel
#

you can just import stuff

vernal lintel
#

type the name, like Logger and vscode should auto suggest the import

hybrid fjord
vernal lintel
#

nuh uh

#

don't manually import

humble mortar
#

#355 needs to be merged so I can make it an even more gay startup animation trolley

humble mortar
# azure verge

guys it's embarrassing now all my factory default friends will know I'm different :((((

vernal lintel
#

WHAT IS THAT SPEECHBUBBLE LMAO

#

did u handdraw that

azure verge
#

yes

#

I have been tempted to send it to

humble mortar
#

work of art imo

azure verge
#

every stupid issue

hybrid fjord
vernal lintel
#

wha

#

don't import that

upper pine
hybrid fjord
#

hm, let my try it
i already called IPC events but in VesktopNative.ts
i want to try jsut use invoke directly in tray.ts

upper pine
#

bro fuck python

#

does anyone know how I can add options to a pyproject.toml

hybrid fjord
azure verge
#

wha

#

im using the flatpak rn to type this message

upper pine
hybrid fjord
#

all i have is this:

fallow quail
#

it only happens sometimes. so maybe it's not exactly the same

hybrid fjord
#

typedIpc imports and uses electron

upper pine
hybrid fjord
#

looks like it only handles

#

no

#

it does same approach as i did

#

VesktopNative.capturer.getLargeThumbnail(source.id))

upper pine
hybrid fjord
#

i am in PR

upper pine
#

Hm

#

I can check it out in an hour or so

hybrid fjord
#

but V didn't like it bc it is calling from global

vernal lintel
#

no thats right

#

i meant new Vencord.Util.Logger

#

thats bad

#
import { Logger } from "..."

new Logger
hybrid fjord
#

i believe i created it only for temp usage and not removed it

#

i'll recheck

#

there was logger but i already removed it some time ago

#

all ok

simple groveBOT
hybrid fjord
#

just add another icon with red circle
and use Ipc call for changing tray icon if there is new message or smth. I can just use badge logic

#

discord native uses just another icon

hybrid fjord
#

fixed lol

simple groveBOT
hybrid fjord
#

omg i just noticed it was PR not issue T_T

humble mortar
#

the task icon isnt the same as the tray icon

hybrid fjord
#

wait i'm confused

simple groveBOT
hybrid fjord
#

we have #261

humble mortar
hybrid fjord
#

do we need it if #261 will be merged?

#

because looks like #261 fixes this too

humble mortar
#

261 seems like the better linux native solution as it seems to use the system unread indicator which follows accents

hybrid fjord
#

yes, i think about it too

#

i just revert commits then

humble mortar
#

theres also windows and mac users to think about

hybrid fjord
#

i thought that this is only linux problem about tray icon

#

this is what i did. I think that will work for mac and windows too

#

okay so tell anyone
should i revert this changes or keep?

humble mortar
#

yours implements it into the icon while 261 uses the system indicator

hybrid fjord
#

261's system indicator will work on windows and mac?

#

if no then i believe i must keep it for winows and mac users and do not change icon for linux users so system's notification badge will appear

humble mortar
#

macos might have their own standard

simple groveBOT
#

Describe the bug

The vesktop-git AUR package will not build the latest version, because ElectronJS 30.0.1 (the latest version) is not in the list of compatible Electron versions.

To Reproduce

  • Run yay -S vesktop-git, or, since I was doing my system updates, just yay.
  • build() will fail with this error:
    ERR_PNPM_NO_MATCHING_VERSIONโ€‰ No matching version found for electron@30.0.1

Expected behavior

30.0.1 should be a supported ElectronJS version and t...

hybrid fjord
#

informative

upper pine
#

@humble mortar You wanted to test app-indicator with plasma5 right?

humble mortar
#

yeah

#

is libunity the only option for electron apps

#

following the link a KDE contributor said yes

Chromium-based applications need libunity for showing badges though I believe which could explain the distro difference.

upper pine
vernal lintel
#

just use gnome blobcatcozy

#

(doesnt have notif badges)

upper pine
upper pine
hybrid fjord
#

i believe we may close #463 and #191

azure verge
#

ughhhh my laptop's vesktop install isn't hooking vencord properly
I can't test it tho cuz my flatpaks won't updateeeee

simple groveBOT
humble mortar
#

theres no way this isnt a kwin wayland issuie

#

cant test another compositor rn tho

simple groveBOT
azure verge
hybrid fjord
#

plasma wayland moment

simple groveBOT
simple groveBOT
simple groveBOT
#

The frequency or something is real off with just vesktop.. regular discord / chrome picks up the mic just fine. It's not the internal mic im using but the issue is there with that one too. When I test it, its like the bitrate was just really low. sounded like a mcdonalds happy meal toy. everything else works though! Real happy with being able to stream audio... just cant seem to make my microphone sound like it should on the steamdeck. tried everything i could from my end using settings, not ...

upper pine
simple groveBOT
hybrid fjord
vernal lintel
#

lmaoo

#

@grand swift fix soon

grand swift
#

steameros you should use Filter-Chain Source by default

#

there's actual mic, echo cancel source, and filter chain source

#

mic goes into echo cancel and echo cancel goes into filter chain

#

you love valve insanity

grand swift
simple groveBOT
humble mortar
hybrid fjord
#

i tested with this fork: https://github.com/miathetrain/arrpc
and it did recognized game runned from Steam Proton. However, it is not fork which merget to arrpc main.
I believe that same functionality must be in current upstream too

humble mortar
#

wait wait aarpc needs to be a system sevice?? I thought vesktop bundled that

hybrid fjord
#

if i understand correctly arrpc is like server which detects games and sends info about it to clients
Vesktop plugin is serving like client for arrpc server and receives info about games and prints them into "currently playing" and so on
i may be wrong about all this structure. I do not understand why we need arrpc plugin if vesktop have some settings about rpc receiving (iirc)

simple groveBOT
azure verge
#

rpc works for me with most games and i dont have anything system level

#

so

#

id assume it doesnt require system stuff

#

idk tho

humble mortar
#

I think thats the RPC which apps themselves integrate

#

discord also scans open apps to support non native RPC apps

simple groveBOT
simple groveBOT
upper pine
upper pine
upper pine
# simple grove

When will people actually provide actually useful information in their bug reports catfrown

simple groveBOT
simple groveBOT
vernal lintel
#

but haven't made release yet (?)

#

yep

vernal lintel
hybrid fjord
#

we do not need arrpc plugin then?

vernal lintel
#

yes

hybrid fjord
#

that's what confused me all time xd

upper pine
upper pine
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
#

I'm wondering if it's more widespread than that. I just started using vesktop and people were telling me that my microphone quality was bad. I rejoined the voice channel in a couple of other clients and they all said those sounded fine. After self testing in the sound settings, the difference is night and day. I'd rather use Vesktop, but the audio quality for input is very noticeably worse.

#

Thank you for feedback! I'm not using any black colors, I believe that it was just small border width. Also, I increased whole icon size. Can you please pull and retest?
What state is on your last screenshot? If it is muted or deafened that means that icons too small, and we need to redraw them completely, because I just took discord's original icons and changed colors to Vesktop ones. They are 24x24 pixels, so maybe they have not resized to proper size in Gnome system.

simple groveBOT
#

Thank you for feedback! I'm not using any black colors, I believe that it was just small border width. Also, I increased whole icon size. Can you please pull and retest? What state is on your last screenshot? If it is muted or deafened that means that icons too small, and we need to redraw them completely, because I just took discord's original icons and changed colors to Vesktop ones. They are 24x24 pixels, so maybe they have not resized to proper size in Gnome system.

I can confirm tha...

simple groveBOT
simple groveBOT
hybrid fjord
simple groveBOT
humble mortar
#

sometimes it works sometimes it segfaults

hybrid fjord
#

When I tried I received seg faults always after gif splash, so I thought electron 30 not working at all

simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
#

Describe the bug

After clicking on the update notification for Vencord, Vesktop shows a blank screen (Appimage)

To Reproduce

Steps to reproduce the behavior:

  1. Start Vesktop appimage
  2. Click on "Vencord Update Available" notification
  3. See a blank grey screen

Expected behavior
Vencord update occurs, after a brief refresh/restart Discord is shown again.

Screenshots
![Screenshot from 2024-04-19 18-53-20](https://github.com/Vencord/Vesktop/assets/7013753/23...

simple groveBOT
simple groveBOT
#

Hi,
I'm new to using linux kde wayland and seem to be having some trouble getting vesktop screen share working. When I press the button to screen share this menu pops up.
Screenshot_20240419_170746
Once selecting what I wanna share nothing happens. I cant bring it up again(unless i close and reopen vesktop) and it wont start screen sharing. I'm told I might be missing something but we cant seem t...

simple groveBOT
simple groveBOT
simple groveBOT
#

I've narrowed it down to an issue with what I think is libunity and Plasma 6 (5?) specifically - unable to test 5 at the moment. This affects both the stock Discord and the Flatpak version. Libunity is old and hasn't been touched in ages, so I guess its about time it breaks...

Alright, I've tested on Kubuntu 23.10(plasma 5) in a virtual machine- the Snap, Flatpak (snap and flatpak both bundle libunity) and Deb+libunity9 all display the task indicator.

This is most definitely an upstr...

simple groveBOT
#

My tray Icon is disabled and it looks like the integration with Discord is broken as I can't access Vencord settings to turn on the tray Icon. Agreed, using the Vencord installer manually is a workaround, I'll try that. But, that is still not the expected behavior, so I believe this can still be considered a bug. I've also tried signing out and downloading a completely new Vesktop Appimage, which gives the same behavior.

simple groveBOT
simple groveBOT
vernal lintel
#

what if we made a better announcement channel that doesn't rely on being in this server

#

like on the website + rss feed + fetch in client and display as banner (with option to disable)

#

do people still use rss feeds

simple groveBOT
#

using the Vencord installer manually is a workaround, I'll try that. But, that is still not the expected behavior, so I believe this can still be considered a bug

since Vencord patches and deeply integrates with Discord, sadly we are at their mercy. if they make changes that break our patches, stuff breaks and you sometimes have to manually update. not much we can do. that's why options like repairing in the installer (only for Discord Desktop) or updating via the vesktop tray icon exist

vernal lintel
#

maybe we could make it so that the installer can also repair vesktop

simple groveBOT
#

Can confirm I and my partner see this issue regularly. Usually right after Vencord starts up screen sharing will work, but if it's been more than a few minutes, I often get this infinite loading loop. A working stream will also eventually stop working spontaneously. I didn't know about using "Change Windows" as a workaround, but can confirm this does work. I've also never seen this behavior with the stock client or the browser client, but obviously those don't share sound.

My suspicion is ...

humble mortar
runic inlet
simple groveBOT
#

Describe the bug

Vesktop opens, displays the discord loading screen briefly, then closes.

To Reproduce

Run Vesktop

Expected behavior

Vesktop functions

Screenshots

Desktop (please complete the following information):

  • OS/Distro: Garuda Linux
  • Desktop Environment: KDE Plasma 6.0.4 (Wayland)
  • Version: N/A (Just updated today)

Command line output

MESA-INTEL: warning: cannot initialize blitter engine
[...
humble mortar
# simple grove

You'd think an arch user would be able to figure this out themselves ๐Ÿ’€๐Ÿ’€

simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
azure verge
simple groveBOT
azure verge
#

someone has one of the weirdest issues ive seen, so i told them to open an issue about it

#

we should see that one soon

#

it is wacky

simple groveBOT
#

Describe the bug

Trying to stream anything results in having a framerate of about one, maybe less. Switching to a browser, regular discord, or discord with Vencord, the framerate and streams work as expected. Framerate does not fluctuate, it is constantly that.

To Reproduce

  1. Try streaming anything, in any resolution/fps combo
    2) My stream is washed ๐Ÿ’”

Expected behavior

Stream framerate to be what i choose it to be

**Desktop (please complete the following in...

upper pine
vernal lintel
#

speaking and idle are quite large for whats essentially a few circles

svg would be way better

simple groveBOT
#

Describe the bug

I am trying to get VAAPI Video Decoding to work on amdgpu, which needs a bunch of flags and some amount of prayers.
Since Vesktop tries to append it's own enable-features flags this caused it to override the previous (user added) flags. I have no proof of this happening, but in my testing removing this line made it work:

https://github.com/Vencord/Vesktop/blob/8eaa5206b98ce7029b6879cc2ce361c2ae5f6239/src/main/index.ts#L33

Those flags has good intentions, but i...

hybrid fjord
#

svg nice idea, I will remake them

simple groveBOT
hybrid fjord
#

Thank you for reviews

vernal lintel
#

400kb png is bad

#

unless im missing something its just one circle and one path

hybrid fjord
#

Yep, I will remake them
Any ideas what we can do for mic and headphones icons? Maybe there are some open source free repos with icons where we can just take icons and edit them?

hybrid fjord
#

CaseOH ahh icons

vernal lintel
#

is there actually a gradient

#

doesnt seem that way

hybrid fjord
simple groveBOT
#

In my testing, all the flags I placed there is necessary, but it will have to know if the driver is amdgpu (because the whole ANGLE Vulkan dance is only needed (probably for now) for AMD only). Besides, this is using mesa-git and not generally available which is why I'm not comfortable with adding it to Vesktop yet.

I'm suggesting a way to passthrough enable-feature flags to Vesktop. I believe that Vesktop is doing great with the flags, but if the user tries to pass something to Electron...

vernal lintel
#

making svgs by hand is hard xd

hybrid fjord
simple groveBOT
vernal lintel
hybrid fjord
#

As long as it's MIT

simple groveBOT
vernal lintel
#

check material icons

hybrid fjord
#

Are they free for another projects?

vernal lintel
hybrid fjord
#

Apache License

simple groveBOT
#

This PR implements the solution in #526.

I am also looking to adding the flags to Vesktop, unfortunately it is impossible to set the argument in time as app.getGPUInfo() is async and I don't know if Electron has already initialized the GUI backend by then. It might be worth looking into as a toggle in the settings (probably something like "Experimental Video Decode Acceleration on AMD" but this is so specific it's hard to come out with a suitable name).

runic inlet
hot juniper
#

just like macos, adobe programs, literally every office editor you can imagine...

runic inlet
#

It's just a design program

#

man really said every designer is pretending to be productive

#

๐Ÿ˜ญ

simple groveBOT
hot juniper
simple groveBOT
#

That is exactly what happened... I wrongly assumed any issue might still be open as I just experienced it on the day I submitted the bug report. I'll make sure to search closed issues as well next time.

"since Vencord patches and deeply integrates with Discord, sadly we are at their mercy. if they make changes that break our patches, stuff breaks and you sometimes have to manually update. not much we can do. that's why options like repairing in the installer (only for Discord Desktop) or u...

humble mortar
upper pine
humble mortar
#

should the title be changed to specify plasma 6

#

also maybe a plasma issue should be opened

#

idk what their stance on libunity is

simple groveBOT
#

Describe the bug

I can stream fine with or w/o Hardware Acceleration enabled until I turn on the audio source for any application, choosing entire audio or specific applications does not matter

To Reproduce

  1. Start a screenshare
  2. Add an audio source before or after starting the screenshare
  3. Video quality breaks completely

Expected behavior

Video quality remains the same when an audio source is selected.

Screenshots

  • Streaming output

Those...

humble mortar
#

i dont even think theres a cross desktop standard for notification badges

#

well Gnome doesnt have them at all so thats a thing

vernal lintel
#

wow what an essay

hybrid fjord
#

Wait tf with bitrate

#

Target to 30 kbit

simple groveBOT
real glade
#

interesting

simple groveBOT
azure verge
simple groveBOT
hybrid fjord
#

30 kbit is something really new

azure verge
#

true

simple groveBOT
azure verge
#

oh my god

#

i have it too

#

i just didnt realize

hybrid fjord
#

Means we can recreate it and do development on local PCs

azure verge
#

mhm

hybrid fjord
#

I have an idea how to fix it, I will try it at home

#

2-3 hours

azure verge
#

awesome

simple groveBOT
#

Hi, I also have this issue and I'd like to add one thing. When streaming and NO ONE is watching my stream, the bitrate target is 8000 kpbs and the actual bitrate hovers around 7k and 8k (1080p 60fps prefer clarity and with an audio souce)

As soon as someone joins the stream, the bitrate goes to 28kpbs.

This issue is not present when streaming without an audio source.

@PolisanTheEasyNick Maybe that's caused by the same discord call that messes with the video source shortly a...

vernal lintel
azure verge
#

ooh

vernal lintel
#

essay is good when informative

azure verge
#

mhm!

vernal lintel
#

inb4 Audio stream is like 3 million bitrate and gets preferred over video track

azure verge
#

hAHHAHA

upper pine
#

8k audio stream

azure verge
#

omg

#

imagine it switches

#

so

#

the audio is 8000kbps

hybrid fjord
#

Ahahahahahaha

azure verge
#

the video is 30kbps

upper pine
#

Haha

#

Might not be that improbable

#

Could actually be the case lmao

hybrid fjord
#

We can just stream visualized audio waves

azure verge
#

that's my guess

ionic gust
# simple grove

interesting, this completely throws out my hypothesis of "webrtc is just shit"

#

weird

azure verge
#

wdym

ionic gust
#

i was always under the assumption that webrtc screenshare was not hardware accelerated at all or was only cpu encode

azure verge
#

oh yeah no like half of the pr was enabling hardware accel

simple groveBOT
simple groveBOT
#

This PR breaks stream audio for me on Linux. I compared the latest Vesktop commit to the latest Vesktop commit with this PR reverted.

I also checked that it was not caused by the Venmic version bump from 3.4.1 to 3.4.2. It's only broken with the actual code changes from the PR, and the logs look about the same (just to show, I'll put them both below).

Log before PR:

[arRPC > websocket] listening on 6463
[arRPC > process] star...
#

This PR breaks stream audio for me on Linux. I compared the latest Vesktop commit to the latest Vesktop commit with this PR reverted.

I also checked that it was not caused by the Venmic version bump from 3.4.1 to 3.4.2. It's only broken with the actual code changes from the PR, and the logs look about the same (just to show, I'll put them both below).

Log before PR:

[arRPC > websocket] listening on 6463
[arRPC > proc...
upper pine
simple groveBOT
upper pine
simple groveBOT
hybrid fjord
#

okay i'm really confused now
audio streaming broken for me at all
but around 15 minutes ago it was working and i didn't do anything

hybrid fjord
#

tf with firefox. Site is allowing copying, i can copy using Ctrl+C

upper pine
hybrid fjord
#

oki

#

i'm wrking on svg icons for now xd

upper pine
#

๐Ÿ‘

hybrid fjord
#

and if bitrate bug will remain then i will take a look for it too

upper pine
#

I'll let you know once I've figured out what's wrong

hybrid fjord
#

but propably after few hours i will be asleep already)

hybrid fjord
#

because all logs looks good for me

upper pine
#

I think I did it on accident

#

Although it worked for me locally before I PRd

#

So it's going to be interesting what's wrong xd

hybrid fjord
#

just wondering
is it good that vencord-screen-share just accepting inputs and electron receiving only from some kwin_wayland-1?

simple groveBOT
#

Describe the bug
the program segmentation faults after relaunch
the only way to make vesktop work is to delete the folder in ~/.config

To Reproduce
setup Vesktop
Relaunch Vesktop

Expected behavior

Screenshots

Desktop (please complete the following information):

  • OS/Distro: Arch Linux
  • Desktop Environment (linux only): KDE Plasma 6
  • Version: [e.g. 22] Rolling Release

Command line output

Gtk-Message: 18:15:47.356: Failed ...

hybrid fjord
#

ohhh

simple groveBOT
hybrid fjord
#

i: *manually did svg icons"
electron:

simple groveBOT
#

this is meh. if the user wants to override one switch, it will disable everything else

why not merge our switches into the user switches? could do the same for disable-features

const features = app.commandLine.getSwitchValue("enable-features").split(",");
features.push("Feature1", "Feature2");

app.commandLine.appendSwitch("enable-features", [...new Set(features)].filter(Boolean).join(","));

That would be an option. I'm just mainly concerned with co...

#

As for your proposal to add that long list of flags to Vesktop, on my machine, it prints that the settings for angle/vulkan are not an allowed combination. AMD Arch KDE Wayland electron29. Just my 2c of unsolicited feedback.

  1. You need mesa-git, specifically 24.1-devel
  2. Wayland is currently out of the question, you need to at least run it in XWayland, sorry
  3. You need to use system Electron.
  4. Make sure you have a Vulkan driver installed.

Now you get the idea why these flags m...

vernal lintel
hybrid fjord
#

it's okay, i converted them to png 128x128

#

they look cute

#

added few commits according to reviews for tray PR

hybrid fjord