#๐ฅ-vesktop-development
1 messages ยท Page 6 of 1
AHAHAH
hey uhh
here's an issue
i just realized this
this app is made in electron
instead of iced-rs
im gonna be honest
i was going to react with the rust logo c++ but I don't have nitro :/
who doesn't
occasionally*
everyone hates web
ikr
it's way better
REALLLLL
Last week (2021-05-09) I cut Notcurses 2.3.0, containing most of the work necessary for Notcurses 3.0.0. In particular, Notcurses now supports portable (Sixel + Kitty) terminal bitmaps, wholly integrated into the multiplanar character semigraphics model. The known universe's most powerful TUI library just became a lot more powerful. Hack on!
h...
this video is so insane lmao
does it do cool stuff or is it just the 3 millionth electron killer
it's not meant to replace electron, it's just a modern c++ webview lib
cat aquiring tool acquiring tool
its a downloader
for cat aquiring tool
look at the website/docs
recursion ๐คฏ
we about to crash the matrix with this one
a script that downloads itself 100 times before downloading the cat-cli app
Ban%
So
Share
Audio
Of Doom Eternal only
Will break it right?
Do I have to be ingame?
Ok I can't reprod on latest vesktop
will try with your PR
Also tried with the PR, I started a Doom Eternal Window only stream on 1080p60. selected Doom Eternal as the audio source, and everything's fine
Also tried with Entire System audio
Both worked fine ^^ Audio was fine on my and the receiving end
grrrrrrrrrrrrrrrrrrrrrrr merge this so i can finish my pr grr
wacky
im gonna go out on a limb and blame myself
variables should be camelCase
yes this is the same casing as the object would take but it still looks very out of place
I was on patch 66.6
What version are you on?
the demon patch
of w h a t
Doom Eternal
oh idk whatever latest on steam is
Resolved
now let us sacrifice another 10 sheeps to review changes ๐
๐ช ๐๐ฉธ
๐ช ๐๐ฉธ
๐ช ๐๐ฉธ
๐ช ๐๐ฉธ
๐ช ๐๐ฉธ
๐ช ๐๐ฉธ
๐ช ๐๐ฉธ
๐ช ๐๐ฉธ
๐ช ๐๐ฉธ
๐ช ๐๐ฉธ
Ven edging the merge button rn
im cleaning kitchen rn bestie
if you depend on the pr why not just rebase ur pr onto noahs pr
that's too much of a good idea
ill wait 
maybe you should just clean faster
Give this man a raise
ban% speedrun gets more realistic xD
Hahahahahahaba
Btw, if possible I'd like to get another PR in before the Vesktop update
Still working on that one though
you mean before merge or before tag release?
Before tag release
I might also add pulse support to venmic although pipewire is obviously still to be preferred in case I add it
That will be a fun loopback spam x)
You can check this for some example of working with pulse library: https://github.com/PolisanTheEasyNick/Crescendo/blob/main/player.cpp#L2186
But it's C style because of plain C pulse library
**player.cpp: **Line 2186
#ifdef HAVE_PULSEAUDIO
Soundux already has a working impl :D (I am the Soundux backend maintainer)
why i didn't found soundux while creating crescendo T_T
Soundux even has a, albeit really scuffed, pipewire implementation, however that was before I made rohrkabel xd
anyway i don't really want to refactor whole code for changing lib xd
plain C cool too
Yeah Ill use the c API for pulse as well
Pulse audios API is simple enough that you don't need a wrapper
Pipewire on the other hand is absolutely fucked lmao
totally agree xD
tbh i dont understand the default speaker switch
When sharing entire desktop audio, restrict to applications that play to the default speakers.
wha?
@upper pine
Imagine you have some app playing to your speakers
And one app that's playing to a Bluetooth box or similar
With the old Venmic version, only the apps that played to the speaker would be shared
Now you can control the behavior to also include apps that don't play audio to the systems default speakers
Or a null sink
Any suggestions? I had a hard time coming up with a good description as well xd
When sharing entire desktop audio, only share apps that play to the default speakers, ignore apps that play to other speakers (eg a bluetooth box).
What about
When sharing entire desktop audio, only share apps that play to the default speakers and ignore apps that play to other speakers or devices.
yea
Alr will change it real quick
okay
i dont have the energy to figure it out rn but
here
someone fix this
its existed since the dawn of time
its not a big deal just if you cancel a stream instead of pressing go live
it does that
if its even fixable lol
might just be electron
being elexcyton
electron
god i am so sick lmao
annoyed lol
also
opinion?
i think it fits in quite nicely
would be better if they were the same width maybe
idk
im so fucking out of it rn
lmao
do it then
make the box stretch
wdym stretch
ohh i know what you mean i thinjk
i dont know whaqt you mean
whatever
toio tiired
afaik the pr is ready
id let @hybrid fjord or @broken solstice check it though
im not exactly trustworthy rn
I will do try to fix it today
hm nvtop isnt reporting any encoder usage when streaming on the latest commit
its not even attempting to use decode either
That screenshare twice popup is 100% some chromium regression
Is it tracked somewhere?
my bad
WAIT
no
sorry
not my bad
disable and re-enable hardware accel in vesktop settings
I tried that ๐ญ
h u h
my drivers are def working

let me check and see if i broke something while rebasing
no
hmm
wtf
okay i got it
let me try something
okay try with new latest commit
@humble mortar
:D
basically
it was set so
if hardware accel = false it disabled hardware accel rasterization
and if true it enabled vaapi
but now
if false it does the same
otherwise enable vaapi
so an if else instead of a second if statement
seemed to fix it
I think for some reason that gets set to undefined sometimes
Have a title barless and frameless electron window that would check for user set games/apps, and if it detects one, start acting like the game overlay! otherwise, show nothing but a transparent png.
Game overlay on Linux will probably greatly reduce fps in-game
And lol transparent window will just steal focus from system
Okay, so, little comment on the UI.
First of all, MUCH better ๐
The only thing i'd say is that the left side settings might be a tiny bit cramped so, maybe, I would still make the popover slightly larger.
Other than that the only tiny nit is to extend the audio settings down to align with the stream's ๐
any idea why i cant maximize latest vesktop even though transparency is off
looks like rejections from executeJavaScript are not catched by .catch function
If i just close Discord's screen picked (not portal's) then promise must be rejected by:
onCloseRequest() { closeModal(key); reject("Aborted"); }
or
close={() => { props.onClose(); if (!didSubmit) reject("Aborted"); }}
but actually not, i can't see "Aborted" logs
Or i just simply miss something
Also for latest commit starting stream while watching another stream is broken for me. But i believe we can't do anything about it, discord just not creating stream object in new connection
and about UI. What do you think about expanding audio settings section to align with stream settings?
Like this:
Edit: oh you already wrote this xd
also before merging we must remove debug console.logs propably?
Yep AHAHAH
to clear this up for anyone reading/not sure if it will work on their nvidia gpu, it will not. Since NVIDIA only want to support their own APIs.
Browsers use VA-API. There's two currently maintained backends for VA-API that relate to Nvidia, VAAPI > VDPAU and VAAPI > NVDEC (which is the repo linked above), both of which are decode support only, with the latter mostly being aimed at Firefox.
The only hope for Nvidia users is hopefully either open source kernel drivers nouveau o...
to clear this up for anyone reading/not sure if it will work on their nvidia gpu, it will not. Since NVIDIA only want to support their own APIs.
Browsers use VA-API. There's two currently maintained backends for VA-API that relate to Nvidia, VAAPI > VDPAU and VAAPI > NVDEC (which is the repo linked above), both of which are decode support only, with the latter mostly being aimed at Firefox.
The only hope for Nvidia users is hopefully either open source kernel drivers nouveau or ...
Just a question, isn't this outdated since vulkan video dropped?
Any thoughts on this comment? @hybrid fjord @azure verge
.
I do not really know much about all this encoders
Well, looks like somebody commented rn. Timing AHAHAH
Before merge I believe we must finalize UI for picker (align sound section with stream settings section if idea is good) and remove all debug console.logs.
Oki, anyway discord overlay is quite useless
there are more important things to fix
like the notorious "if client is in background, it will disconnect from discord"
also
i recently discovered
that if you leave vesktop unfocused
it will stop accepting mic input
????????
Has anyone tested sharing a 2160p display using this rework?
For me it just says "RPC disconnected" after some time in background
I believe this may be some electron issue
Has anyone tested sharing a 2160p display using this rework?
There will not be enough bitrate for stable 4k sharing even on 30 FPS.
Has anyone tested sharing a 2160p display using this rework?
There will not be enough bitrate for stable 4k sharing even on 30 FPS.
Nono, as in screensharing at 1080/1440 on a 2160p display, before it seemed I was getting worse performance than people using 1080/1440p displays. Was wondering if anyone has tried this using the rework.
Nono, as in screensharing at 1080/1440 on a 2160p display, before it seemed I was getting worse performance than people using 1080/1440p displays. Was wondering if anyone has tried this using the rework.
You can try add 2160 here and try it by yourself if you have 4K screen
Has anyone tested sharing a 2160p display using this rework?
There will not be enough bitrate for stable 4k sharing even on 30 FPS.
Nono, as in screensharing at 1080/1440 on a 2160p display, before it seemed I was getting worse performance than people using 1080/1440p displays. Was wondering if anyone has tried this using the rework.
Hello, before this PR resolution setting wasn't actually working which means that, irrespective of user choice, the resolution w...
For example, at least on GNOME/KDE Wayland, the screen sharing is worse performing than the window sharing (~60->~45-50)
Found out that it's a Chromium upstream issue and already created issue in their bugtracker
Not sure whether this is really related, but the current screen sharing implementation of the native Discord desktop client is pretty bad. Every time I stream anything on my screen, the frame rate of any currently playing game takes a noticeable hit. Is this different with this implementation?
no idea
I don't know much about vulkan video
I just know vaapi is already supported by chrome so we're using it
if something better comes along we can change that
did you already commit that?
Not sure whether this is really related, but the current screen sharing implementation of the native Discord desktop client is pretty bad. Every time I stream anything on my screen, the frame rate of any currently playing game takes a noticeable hit. Is this different with this implementation?
Yes it will be, as you're probably noticing the impact of sotware transcoding done on your CPU instead of the dedicated hardware provided by most GPUs.
that'd be great imo
I'm gonna clean up the code as soon as I get the energy to get out of bed
I can hardly swallow with my throat lmao
No, I didn't commit anything
It just drawing in paint xd
I can try to align them later
oh lmao
Get well bestie
tyty
okay i found a way to align them but i do not like it
omfg
margin-bottom creates space under cards
Not sure whether this is really related, but the current screen sharing implementation of the native Discord desktop client is pretty bad. Every time I stream anything on my screen, the frame rate of any currently playing game takes a noticeable hit. Is this different with this implementation?
Yes it will be, as you're probably noticing the impact of sotware transcoding done on your CPU instead of the dedicated hardware provided by most GPUs.
So this implementation will use the ...
So this implementation will use the proper GPU encoding with H.264 or HEVC with the NVIDIA hardware transcoding module? (Also on Linux)
..... If you read up, Nvidia does not implement VA-API encoding (there is https://github.com/elFarto/nvidia-vaapi-driver which translates decoding but it doesn't do encoding), meaning there is no infrastructure to do hardware accelerated encoding for Chromium / Electron on Nvidia Linux.
that's probably the best thing we can do
personally i dont like using px
me too
we can do some calculations in % but they are bad too
xd
fuck it im using this
can you send screenshot?
actually no
the px is probably better
well
hmm
it stays lined up
no matter what size the app is
which is good
even when stupidly tiny
yes
I just do not know why on 3.1 i got this
oh
odd
lemme test it on a 1080p monitor
still perfectly even for me
let me just
look up online if there's a better way to do this
what if whole settings put in div, make card fit-content and add margins?
ooh
dont do this lol
Test your JavaScript, CSS, HTML or CoffeeScript online with JSFiddle code editor.
fit- whole space actually
i found a demo of something that seemed interesting
@vernal lintel this is worse :)
i dont like it also
please learn css lmao ๐ญ
HAHAHHA
listen
im an avid oldnet enjoyer
so
beauty to me is no css
or very very little
so

you should basically never hardcode specific dimensions
instead, use auto responsive layouts
you could use height: 100%;
or a flexbox
or a grid
or 3 million other methods
yeah
that i know
shhhh i forgot that css existed and uhhh shhhhh

definitely not height 100%
LMAO
and also apply it to the left side..
because you're combining height 100% with something like a padding or margin which makes it more than 100% so overflow
you can fix it via box-sizing: border-box;
NO
please never touch css again
|| /lh ||
GIRL WHAT IS THAT
at least make them equal width ๐ญ
anyway just ummm... leave the css to me ig
LMAO
no thAT WOULD LOOK BAD
THIS IS PRETTY
i want it too look like something you'd see in 1985
okay then make them the same height so we can merge
is the rest done
afaik yes
i removed the excess console.logs
@hybrid fjord @broken solstice do you know of anything else that needs done?
i believe no, only bug that discord should fix and we can't do anything about it
oki
And other upstream issues, yeah.
Also, it's such an improvement that the faster it gets to people the better ๐
that settles it
the answer is yes
or use the calc function
So this implementation will use the proper GPU encoding with H.264 or HEVC with the NVIDIA hardware transcoding module? (Also on Linux)
..... If you read up, Nvidia does not implement VA-API encoding (there is https://github.com/elFarto/nvidia-vaapi-driver which translates decoding but it doesn't do encoding), meaning there is no infrastructure to do hardware accelerated encoding for Chromium / Electron on Nvidia Linux.
OBS studio can use hardware encoding, so I don't really see...
So this implementation will use the proper GPU encoding with H.264 or HEVC with the NVIDIA hardware transcoding module? (Also on Linux)
..... If you read up, Nvidia does not implement VA-API encoding (there is https://github.com/elFarto/nvidia-vaapi-driver which translates decoding but it doesn't do encoding), meaning there is no infrastructure to do hardware accelerated encoding for Chromium / Electron on Nvidia Linux.
OBS studio can use hardware encoding, so I ...
So this implementation will use the proper GPU encoding with H.264 or HEVC with the NVIDIA hardware transcoding module? (Also on Linux)
..... If you read up, Nvidia does not implement VA-API encoding (there is https://github.com/elFarto/nvidia-vaapi-driver which translates decoding but it doesn't do encoding), meaning there is no infrastructure to do hardware accelerated encoding for Chromium / Electron on Nvidia Linux.
OBS studio can use hardware encoding...
So this implementation will use the proper GPU encoding with H.264 or HEVC with the NVIDIA hardware transcoding module? (Also on Linux)
..... If you read up, Nvidia does not implement VA-API encoding (there is https://github.com/elFarto/nvidia-vaapi-driver which translates decoding but it doesn't do encoding), meaning there is no infrastructure to do hardware accelerated encoding for Chromium / Electron on Nvidia Linux.
OBS studio can use hardware encoding...
So this implementation will use the proper GPU encoding with H.264 or HEVC with the NVIDIA hardware transcoding module? (Also on Linux)
..... If you read up, Nvidia does not implement VA-API encoding (there is https://github.com/elFarto/nvidia-vaapi-driver which translates decoding but it doesn't do encoding), meaning there is no infrastructure to do hardware accelerated encoding for Chromium / Electron on Nvidia Linux.
OBS studio can use hardware encoding...
Somehow the post was displayed twice for me. Deleted it, but both versions were gone. Reposted it. Sorry.
So this implementation will use the proper GPU encoding with H.264 or HEVC with the NVIDIA hardware transcoding module? (Also on Linux)
..... If you read up, Nvidia does not implement VA-API encoding (there is https://github.com/elFarto/nvidia-vaapi-driver which translates decoding but it doesn't do encoding), meaning there is no infrastructure to do hardware accelerated encoding for Chromium / Electron on Nvidia Linux.
OBS studio ...
So this implementation will use the proper GPU encoding with H.264 or HEVC with the NVIDIA hardware transcoding module? (Also on Linux)
..... If you read up, Nvidia does not implement VA-API encoding (there is https://github.com/elFarto/nvidia-vaapi-driver which translates decoding but it doesn't do encoding), meaning there is no infrastructure to do hardware accelerated encoding for Chromium / Electron on Nvidia Linux.
OBS...
i added a new commit
everything seems to be fine
if something breaks ill just revert it
Looks good
Probably it will fix starting stream from 240p
So now we need to sacrifice 15 sheeps for UI commit from V xD
(actually plz don't spam)
lmao true
and yeah
that's what i thought
wait
hmm
nah
i wonder if we set min to the selected res
if it would
start at selected
but still be able to drop
lemme test that
Also while trying I found out that connection creates only after 1.5-2 secs, so I even increased timeout time
No
No, it didn't helped
ahh
it seems to have scaled up a bit more aggressively but i still need to test more
We use timeout only for already created conn
And waiting 200 msecs only for letting discord reapply stream settings to default res and 30 fps so we can change it to our settings
Also this comment is not true now
https://github.com/kaitlynkittyy/Vesktop/blob/hardware-accel/src%2Frenderer%2Fcomponents%2FScreenSharePicker.tsx#L452
**src%2Frenderer%2Fcomponents%2FScreenSharePicker.tsx: **Line 452
// If there are 2 connections, the second one is the existing stream.
^-^
Get well soon
tyty
@azure verge i haven't really been following, did you figure out the weird bitrate cap issues?
not the 4696 one
that's not too important for this pr tho imo
fair
It looks like backend cap for non-nitro accs
Hm
I believe I have full nitro
On main acc I can't reproduce 4696 bitrate
I will retest at home
Just to be sure
I would love for this to be in Vesktop as well. I don't want to use Flatpak Discord but this is a necessary feature for me.
i really really doubt this exists
It may, because on non nitro accs there are restrictions in 720p30 and 4-5k bitrate will be enough
But for real we need to test it somehow :c
Btw, I got pulseaudio support in venmic working but I'll have to do some more testing later on.
It's not nearly as pretty* as it is with pipewire but it works
- it requires to move around some outputs which could introduce some unwanted behavior in case anything goes wrong (already accidentally triggered a feedback loop by unloading a module) and is not as robust as the pw backend. It could also add some latency, but that's to be expected with audio share on pulse
ooh
Yes, Im about to write my tests result
Linux, Vesktop, no nitro acc, sticked to 4686 ~~~
Linux, Vesktop, full nitro
Windows, Discord native, no nitro
all with someone watched and streamed ufo-test on full screen to emulate motion
do not watch at res, i just not give time to make negotiations
maybe we should add some sort of warnings about bitrate for non-nitro? Maybe at readme at least
Or someone who knows about patches can find something related to "4000" and try to patch it to more bitrate, maybe it will unlock bitrate for non-nitro accs (just like fixed 2500 kbit problem)
Well, looks like my theory was true ๐
that begs the question as to why they don't validate resolution too
I wonder if this is some limit the client sets when it doesn't have nitro that we haven't found yet
try patching premiumType locally
Describe the bug
not getting pipewire audio source but when streaming its getting audio source
To Reproduce
- open vesktop
- join a channel
Expected behavior
getting audio source from pipewire just how the streaming window get or add a option in voice setting to pick audio source
Desktop (please complete the following information):
- OS/Distro: Arch linux
- Desktop Environment: Sway
- Version: 2024.04.01
2 variants
I'm not sure what you mean, can you please elaborate further?
or i don't know english well or the text doesn't make any sense
just looks like T9 created xd
what the hell did i just read
while im just listing in a channel my input is not detected but when im streaming my screen its get audio source, also that screen share selection window have a option to select audio source, but settings > voice & video > input selecting is disabled or in my case
ohh microphone not working
What the fuck
ohh yeah
ahahahahha that 1000 clicks per second sound is so funny
The audio selected when starting the screenshare is audio that will be shared alongside the stream and is not intended to be used as a microphone.
I have to hide venmic from the audio inputs
scrcpy??????
why the hell are they using scrcpy for a mic
check the video
I did, please re-read my message
The audio selected when starting the screenshare is audio that will be shared alongside the stream and is not intended to be used as a microphone.
yep thats correct but its not getting my mic input
oml
The audio selected when starting the screenshare is audio that will be shared alongside the stream and is not intended to be used as a microphone.
yep thats correct but its not getting my mic input
You don't have a microphone. Scrcpy is an application you're sharing audio from - not an actual microphone
it's srccpy problem then, bc it does not share microphone as input device properly
but shares as output device
scrcpy is not intended for that at all
yeap
okay im confused
do have a mic
What is the output of pw-cli ls Device?
pw-cli ls Device
id 46, type PipeWire:Interface:Device/3
object.serial = "46"
factory.id = "14"
client.id = "45"
device.api = "alsa"
device.description = "Raven/Raven2/Fenghuang HDMI/DP Audio Controller (PRIME B450M-A Motherboard)"
device.name = "alsa_card.pci-0000_07_00.1"
device.nick = "HD-Audio Generic"
media.class = "Audio/Device"
id 47, type PipeWire:Interface:Device/3
object.serial = "47"
factory.id = "14"
client.id = "45"
device.api =...
And what is the output of pw-cli ls Node?
id 28, type PipeWire:Interface:Node/3
object.serial = "28"
factory.id = "10"
priority.driver = "20000"
node.name = "Dummy-Driver"
id 29, type PipeWire:Interface:Node/3
object.serial = "29"
factory.id = "10"
priority.driver = "19000"
node.name = "Freewheel-Driver"
id 32, type PipeWire:Interface:Node/3
object.serial = "54"
factory.id = "13"
client.id = "45"
node.description = "BLE MIDI 1"
node.name = "bluez_midi.server"
media.class = ...
does id 51 looks like microphone?
Interesting, this should be detected as a microphone: Family 17h/19h HD Audio Controller (PRIME B450M-A Motherboard) Analog Stereo, it not showing up seems to be either a Discord or Electron issue though
yeah
Interesting, this should be detected as a microphone:
Family 17h/19h HD Audio Controller (PRIME B450M-A Motherboard) Analog Stereo, it not showing up seems to be either a Discord or Electron issue though
so its a bug or something a issue right??
maybe qpwgraph scheme can help us?
Could help, but should show roughly the same as the pw-cli output
maybe this node is somehow muted or disabled in pulseaudio control panel or system settinsg?
Node shouldn't exist if the mic is turned off / disabled
Just checked
And muted devices should still show up
Maybe some sort of electron permission stuff? That would be unusual though
can we start vesktop from sudo?
please dont lmao
maybe root user can't connect to another user's pipewire server, or something like that
What's the output of pw-cli info 51?
unfortunately i can confirm this
id: 51
permissions: rwxm-
type: PipeWire:Interface:Node/3
- input ports: 0/0
- output ports: 2/65
- state: "running"
- properties:
-
alsa.card = "1" -
alsa.card_name = "HD-Audio Generic" -
alsa.class = "generic" -
alsa.device = "0" -
alsa.driver_name = "snd_hda_intel" -
alsa.id = "ALC887-VD Analog" -
alsa.long_card_name = "HD-Audio Generic at 0xfcc80000 irq 63" -
alsa.name = "ALC887-VD Analog" -
alsa.resolution_bits = "16" -
alsa.subclass = "generic-mix" -
alsa.s...
discord is really weird
sounds about right
what the hell
wtf with formatting
i can also confirm it affects desktop too
Why does this look so ass
so this isn't webrtc specific
and this is def recent because i've noticed bitrates of ~10k before on desktop
what can I do about it ๐ญ
make it not have the scrollbar
how
smaller size or bigger modal
It's just a normal Modal component with text
or reword it
maybe we can try set target to 10k?
to remove a line
weird
idk what determines it
i'll try looking into it
we need just to know which bitrate is on windows
who cares
Other modals don't suffer from the issue either
if it works it works
Vee will instant decline lmao
shhhh
Aber zurecht
I have no idea what other modals do differently
du sprichst deutsch?
WAS
ICH HABE GEDACHT DASS DU WARST IM AMERICA GEMACHT
(yes i know its amerika)
(no i dont care)
Ich distanziere mich von Kriegcorp Inc.
was ist kriegcoorp
Amerika
Ich glaub es mรผsste ein o sein lmao
Why
was sollte ein o sein?
you could talk about overflow: hidden in german so V wouldn't noticed
Corporation
political stuff
v is german iirc
I guess Austria isn't any better than either?
keine ahnung
yes xd
its nice being able to speak german tho
True
i had a good language teacher
she doesnt care if we fuck around as long as its in german
so we end up teaching each other a shit ton just from being idiots
irgendwas bestimmtes oder generell?
im trans
kenn mich mit der politischen Lage nicht so aus xd Aber gibt leider viele Leute die brutal intolerant sind :(
Voice Message Modal has scroll bars as well???
ja, ich werde nicht hier darueber sprechen, aber es ist nicht schlect aber nicht gut
i added a css thing because discord broke their scrollbars and made them default chromium scrollbars
so maybe it fixed that
???
lemme check
did you commit that?
this is at the bottom of my custom css
* {
scrollbar-width: unset !important;
scrollbar-color: unset !important;
}
wasn't it
not in vesktop source
will try
its in my quickcss
i do not have scroll bars on hardware-accel branch
sprechen, nicht sagen xd
yep its discord's fault
i think
check css snippets for scrollbars
HOLY FUCK hahaha
huh
I just opened an app (I guess it was under xwayland) and my cursor was like at least 5cm large
grandma mode
HAHAHA
i have NO idea what those even are ima be honest
i kinda understand it
but not well
arghhh
I want discord to show the modal for new microphone devices again
but I can only get it to show once
bro picking resolution and fps where stream settings are broken ahjhahahahaha
I'm going to try and recreate it, but my main priority is screensharing
@kaitlynkittyy take all the time you need you have been absolutely grinding out that screen sharing work
sheeesh
haha
weird
it doesn't get them through enumerateDevices it seems
what else could they even use
what output if you just call await navigator.mediaDevices.enumerateDevices()?
then it returns my mocked result
for me looks like that discord uses enumerateDevices() function and takes only kind: "audioinput"
but I overwrote the func
ohhh
wait
maybe they cache it once
and then re-use their version of it
as in cache the function
so that they don't call my patched one
where in the vesktop source would I hook a func
before discord loads
you want overload it?
if yes then take a look at src/renderer/patches and file for screenSharing. There is overloaded function
No
its called on every enter to voice and video section
try at discord console:
const enumerateStock = navigator.mediaDevices.enumerateDevices
navigator.mediaDevices.enumerateDevices = async function() { console.log("I was called!"); return await enumerateStock.call(this); }
and on every entering to voice and video you will get "I was called!"
seems to work when I patch in the screenshare file
now does anyone have an idea
how I can trigger discords "new device detected" screen?
Creating a dozen null sinks doesn't seem to trigger it
it seems really random
reconnect real devices?
maybe it have some cooldown
fuck discords inconsistent shit xd
I restarted multiple times in between
also tried new names
FUCK
I triggered it
and accidentally clicked away
maybe you can use this?
https://discord.com/developers/docs/topics/rpc#getvoicesettings
or this just for bots
there's also something like this. But i believe for >100 volume plugin we must edit WebRTC streams directly somehow
I'm going to try and recreate it, but my main priority is screensharing
@kaitlynkittyy take all the time you need you have been absolutely grinding out that screen sharing work
I've had help lol, but thanks
Found this fucker
is there any section where I can apply vencord like patches specific to vesktop?
found it
does \i in a patch represent a valid variable name?
Okay got it working :D
@vernal lintel What would be the best way to write to global settings from the Screen-Share Modal?
Nvm I don't think I'll even need that
Edit ScreenSharePicker.tsx file (add what you need in settings) and just import the streamSettings variable from it?
In 489 we exported it
@azure verge Do you think this is too much text (especially since the spacing changes where you wanted to make sure that both have the same height)?
holy shit spectacle screen recordings have like 2 fps lmao
i think its fine because its literally an error
It's a warning
close enoug
๐
- [x] Allow to bypass
pipewire-pulsewarning
- [x] Prevent
New Audio Device DetectedModal with venmic
- [x] Hide venmic from
Input Devicesin Audio Settings
maybe, but I'd say yours goes first
The chrome sound sharing code is ass lmao
yeah
tbh i like our implementation more
stars many
Sorry if it has gotten buried in here somewhere, but is there a solution for the stream lagging/skipping based on mouse movement over/in the streamed window? I believe I may have seen a comment about it being specific to certain DEs? I'm using kde plasma in wayland.
Yeah it's always better to not fuck around with loopback modules too much, the pw approach we have is def less intrusive
The pulse approach has to move the output of certain applications to a loopback and then remap that as a mic
Which is prone to all sorts of problems due to the amount of fucked pulse audio modules that are loaded by default
Which will then fuck up the whole thing when You're not absolutely paranoid-like careful
But I think I have a pretty good idea on how we could avoid all those problems with our pulse backend for Venmic in the future
This looks like either an audio server problem (some sort of issue with pipewire-pulse?) or an electron problem to me
Do we have a official fix for this yet, or are we still using the workaround?
Do we have a official fix for this yet, or are we still using the workaround?
You can downgrade to 1.5.0
oh?
I have this too
I have genuinely no idea what is wrong
but it's definitely Chromium's problem I think
yeap
in firefox there is no this issue
i have idea to try alpha 30 electron, but i do not have time rn for experiments xd
yes, on chromium i can see issue and in firefox there is plain 60 fps
stuff glitches back and forth a lot
okay
good
yayy it's not our problem!!!
lmao
being done with the major issues is
a huge relief
yayy I can focus on getting my freebsd+zfs custom NAS running
i really believe we did everything we could
other than bugfixes ofc
yeah
it's in a good state rn
I packaged it a few days ago and I've been using it ever since
it's stable as rocks
it's propably even better that windows native because of content-motion setting
on windows with text setting stream is limited to 15 fps
and no way to choose res/fps
like this
It says "better visibility of the text" and "the image will be better with a low frame rate (15 frames per second)"
btw if any mac user could look into this and figure out the entitlements and stuff and confirm it works
that would be super appreciated
but ig it's hard to test cause you'd need to sign with your own developer certificate
https://git.kaydax.xyz/w/algos are we getting native voice modules soon 
Alright, I can confirm it indeed works via downgrading to 1.5.0, I've been in a VC for 15 minutes and it's just fine.
I can ask someone I know who has one
they're also a dev so they aren't dumb as rocks
lmao thats by far my favorite way to address end users
THEY ARE THO
full context:
we recently started signing vesktop. but this breaks microphone permissions and such because we also need specific entitlements in the plist (at least i think this is what's causing it)
not that I'm much better
(not disagreeing)
kaitlyn as rocks
someone buy that domain and redirect it to vencord.dev
im slightly too sane to spend 10 bucks on a joke
it says 25 for me T_T
REAL
I might need the money for college
but a joke is a joke
@vernal lintel it was only $5.64 for the first year
last thing is changes for height in css by you
Sorry if it has gotten buried in here somewhere, but is there a solution for the stream lagging/skipping based on mouse movement over/in the streamed window? I believe I may have seen a comment about it being specific to certain DEs? I'm using kde plasma in wayland.
We believe this is a Chromium upstream issue, because this behavior is not reproducing in Firefox browser.
For temp solution, you can try to stream application window instead o...
^-^/
yep
no need to thankie
I fix when thing no work
that was our problem too)
and problem for many many people who rn waiting for merge ^^
mhmm
my friend has a proxmox osx instance already running wth lmao
hopefully they can help
Very nice, was anything gleaned about the mouse movement issue?
issue not reproducible in firefox browser so that means that this is chromium issue -> electron issue
Chromium tries not to regress challenge (impossible)
@vale sierra Can we get #504 in before the update as well?
Thankyou for all the work kait and everyone else!
Will be getting my friends on ven
@vernal lintel give @feral fulcrum programming role
v+ programming @feral fulcrum
yeah
xd
Sorry if it has gotten buried in here somewhere, but is there a solution for the stream lagging/skipping based on mouse movement over/in the streamed window? I believe I may have seen a comment about it being specific to certain DEs? I'm using kde plasma in wayland.
We believe this is a Chromium upstream issue, because this behavior is not reproducing in Firefox browser. For temp solution, you can try to stream application window inst...
HAHAHAH
this issue can be re-produced on firefox using vdo.ninja, I'm also running KDE wayland and have the same problem.
Thank you for useful info. Anyway, that means that mouse issue is some upstream issue and we in Vesktop code can't do anything about it :c
No way 
||(@azure verge why am i here)||
macos stuff
you're the one with the proxmox instance
yep
Btw, which codec is used for Discord screen sharing? VP9?
yep
Btw, which codec is used for Discord screen sharing? VP9?
H264, as of right now.
I may look into H265 at some point, but that's not likely to happen.
I don't mean to be rude but I'm subscribed to this PR because I'd like to track the development of it, I would prefer if exploratory questions like that could be moved to IM.
There's a lot of noise here from lots of people waiting for this PR which drowns out useful information (which is why iirc we talked 3 times about Nvidia encode despite it not happening).
I don't mean to be rude but I'm subscribed to this PR because I'd like to track the development of it, I would prefer if exploratory questions like that could be moved to IM.
There's a lot of noise here from lots of people waiting for this PR which drowns out useful information (which is why iirc we talked 3 times about Nvidia encode despite it not happening).
That's a fair point. Further questions can be directed at my discord: kaitlynyaa (although this PR is due for a merge real...
wtf is IM
me when the development thread is used to discuss development 
REAL
i just dont care to argue
not in the mood after my school was really pissy today so im in what's basically a heated email argument with the administration
oh god
because they got mad at me for using german in my senior quote and said it could cause issues on social media or some shit
so im basically tearing them apart
i QUOTED FUCKING SIGNALIS
CALM THE HELL DOWN
LMAO
lol???
they wanted u to use english instead??
why are they mad ๐ญ acting like u quoted hitler or some shit
they were like "it has to be positive or it will cause issues"
lmaooooo
bitch i said "achtung. achtung. 39204 27950 45840" (different numbers but i dont care to remember them rn)
ITS NOT FUCKING CAUSING ISSUES LMAO
i am so done with this school
nice one
new role
Is your feature request related to a problem? Please describe.
No. Basically I just want to be able to change the Vesktop logo that appears in the taskbar and tray
Describe the solution you'd like
Anyways the point is I wish I could change the vesktop logo to something else wether it be the discord logo or some silly little meme
Describe alternatives you've considered
Not too sure? I don't see and alternative way of doing this unless vesktop changes the default icon which...
tHATS PART OF LITERALLY ANY DESKTOP ENVIRONMENT OMFG
log in to the thing i sent you
true i am on my laptop rn
@vernal lintel so uhh yeah i have this now
not that i know much about macos
but i can test things!!!
the hEll
L badly configured webserver
@azure verge any idea how we can get input connection objects?
wdym
if i in call with someone i want to get input connection from other person, like receiver or smth
i believe [...MediaEngineStore.getMediaEngine().connections] only returns our voice and video send connections
or i wrong?
Uh I should probably add here that streaming genshin impact displays the cursor with a blue tint instead of its normal yellow 0.o (will test if obs or wtv captures it properly later)
it means that the server and client couldnt find a compatible cipher to use to complete the ssl request (the web server did something bad)
no this is exactly the point of ssl
our certificate only applies to vencord.dev
i need to add the domain as a name for the site and then it'll work
welll xd you need to change your nameservers to cloudflare for it to be usable via cf pages
oh wait transferring NS is only necessary if using apex domain
so if we used like www.vencord.rocks it wouldn't need to be
but www sucks lmao
fuck www all my homies hate www
REALL
#440 (comment) seems related
yep the same
I want to redirect everything on vencord.rocks to the vencord.dev
except for like
idk
git.vencord.rocks could be the GitHub
same for vesktop.vencord.rocks
or I could make my own version of the vencord website and just ship malware /j
make a rock themed fork of the vencord site
And use hardcoded height weight values in pixels everywhere where you can
it's just a picture of a rock
click on it and it downloads vencord
imagine hosted gitlab instance though :3
Is your feature request related to a problem? Please describe.
The problem I have is a see a weird fox wearing a suit kind of thing when starting vesktop
Describe the solution you'd like
Please add an option to turn it off.
Describe alternatives you've considered
Not using vesktop.
Additional context
i love shiggy why would anyone want to remove shiggy
or being able to chose between shiggy and vinnie, idk i just like vinnie better
Any support for soundsharing on MacOS?
It would be nice to be able to pick from the list of Mic-in inputs to share.
not in this pr, no. I can look into it now that I have a macos device to test on, but I cannot confirm anything, as I have absolutely no idea how that would be done.
you got a problem with that? 
no iโm very much on board with it, just bold of you to say
As far as I know you can have multiple implementations of the same portal exposed via dbus. So, maybe this could be fixed by having an xdg-desktop-portal implementation for gamescope, thus this being an issue for upstream gamescope?
Unfortunately gamescope has no plans to implement/support the xdg-desktop-portal, if you can convince them otherwise more power to you.
Unfortunately gamescope has no plans to implement/support the xdg-desktop-portal, if you can convince them otherwise more power to you.
Then it's not going to be done because screensharing in Electron relies on desktop portals. It would be easier for them to implement it than for anyone to attempt to hack support into Electron.
Unfortunately gamescope has no plans to implement/support the xdg-desktop-portal, if you can convince them otherwise more power to you.
Then it's not going to be done because screensharing in Electron relies on desktop portals. It would be easier for them to implement it than for anyone to attempt to hack support into Electron.
Uh... electron already has support for pipewire sources as camera feeds, the problem is that it specifically filters out any source not marked as a "came...
Any support for soundsharing on MacOS?
It would be nice to be able to pick from the list of Mic-in inputs to share.
This would probably require additional routing through BlackHole
not in this pr, no. I can look into it now that I have a macos device to test on, but I cannot confirm anything, as I have absolutely no idea how that would be done.
Thank you!
This would probably require additional routing through BlackHole, or is there a system API for this? I vaguely remember something
I use loopback, but that's the plan!
Describe the bug
See "Additional context" for system specifications.
Upon launching the app, it hangs on the initial loading popup seemingly indefinitely. After manually quitting this window, the main Vesktop window appears, but the content is just blank white.
To Reproduce
Expected behavior
Vesktop launches normally.
Screenshots
 and validate it works? We have a decent amount of users using it via Flatpak now so it needs to be tested
Oh shit could I lend one of those xD?
electron 30 released, can we use it in next release tag?
lmao I could just give you my login but uhhh @feral fulcrum said to turn it off when done and it's up to him if I give that out anyways
I shall
There is no purpose if it doesn't actually increase the framerate, as indicated by some people in this post
ok, I'm closing the issue now
gpu issue as indicated by the log, classic nvidia on linux experience
try to run with --disable-gpu-sandbox or --disable-gpu
if that works you may want to try disabling hardware acceleration inside vesktop settings, then running without the flag
get newer nvidia driver 535 has issues with vesktop in my experience
better idea would probably be a gamescope overlay but i think it's better that another app handle this and vesktop just enables the OVERLAY rpc event
@sly cairn uhhh im kinda new to flatpak builder
i feel like im doing this really wrong
how would i build it from a local appimage
@azure verge kernel module
@upper pine is the audio nerd
and i
i hate that idea
Or sorry i forgot
Its called a kext
kext moment
i have absolutely no idea what is happening in here but there is absolutely no reason you should be anywhere near that depth of the system for something like this (unless macOS has extremely stupid levels of "security")
You have obviously never used macos..
i do not use macos this is true
it's no longer needed
me installing a kext to browse the internet:
there's a proper system api
C++* :P I'm not particulary well versed in audio, I just somehow slid into that topic because I needed some stuff for Soundux xd
There's no way
Kernel module used to be the way lol
too bad you're now the audio nerd
There's a system API now right
What the fuck
xD
I have a macbook and yeah discord really used to like ask you to install a kernel extension to stream audio
It sounded sketchy as fuck
wait looks like what they do is similar to how venmic works lmao
it creates a virtual audio device

venmic for macos??
drm moment (its stupid)
Imagine drm


