#๐Ÿ–ฅ-vesktop-development

1 messages ยท Page 6 of 1

upper pine
#

c++

broken solstice
#

AHAHAH

azure verge
#

hey uhh

#

here's an issue

#

i just realized this

#

this app is made in electron

#

instead of iced-rs

upper pine
azure verge
#

im gonna be honest

broken solstice
azure verge
#

im a web developer and

#

i hate webdev

upper pine
azure verge
upper pine
#

everyone hates web

azure verge
#

ikr

upper pine
#

fuck web

#

let's go back to the fucking terminal

azure verge
#

like why do they keep making new ways of doing the same shit

#

REAL

upper pine
#

it's way better

azure verge
#

REALLLLL

upper pine
#

watch this hype fucking video

#

about a console lib

azure verge
upper pine
azure verge
#

i need to make uhhh

#

Cat-cli

upper pine
rancid tartan
upper pine
azure verge
#

its a downloader

#

for cat aquiring tool

upper pine
upper pine
azure verge
#

infinite

#

recursion

upper pine
#

we about to crash the matrix with this one

azure verge
#

a script that downloads itself 100 times before downloading the cat-cli app

hybrid fjord
#

Ban%

azure verge
#

waaaah @vernal lintel merge pr #499 already waaah

#

i wanna rebaseeeeee

upper pine
#

Share

#

Audio

#

Of Doom Eternal only

#

Will break it right?

#

Do I have to be ingame?

#

Ok I can't reprod on latest vesktop

#

will try with your PR

#

Also tried with the PR, I started a Doom Eternal Window only stream on 1080p60. selected Doom Eternal as the audio source, and everything's fine

#

Also tried with Entire System audio

#

Both worked fine ^^ Audio was fine on my and the receiving end

simple groveBOT
azure verge
#

im gonna go out on a limb and blame myself

simple groveBOT
upper pine
#

What version are you on?

vernal lintel
#

the demon patch

azure verge
upper pine
#

Doom Eternal

azure verge
#

oh idk whatever latest on steam is

upper pine
hybrid fjord
#

now let us sacrifice another 10 sheeps to review changes ๐Ÿ˜„

upper pine
#

๐Ÿ”ช ๐Ÿ‘๐Ÿฉธ

#

๐Ÿ”ช ๐Ÿ‘๐Ÿฉธ

#

๐Ÿ”ช ๐Ÿ‘๐Ÿฉธ

#

๐Ÿ”ช ๐Ÿ‘๐Ÿฉธ

#

๐Ÿ”ช ๐Ÿ‘๐Ÿฉธ

#

๐Ÿ”ช ๐Ÿ‘๐Ÿฉธ

#

๐Ÿ”ช ๐Ÿ‘๐Ÿฉธ

#

๐Ÿ”ช ๐Ÿ‘๐Ÿฉธ

#

๐Ÿ”ช ๐Ÿ‘๐Ÿฉธ

#

๐Ÿ”ช ๐Ÿ‘๐Ÿฉธ

upper pine
#

Ven edging the merge button rn

vernal lintel
#

im cleaning kitchen rn bestie

#

if you depend on the pr why not just rebase ur pr onto noahs pr

azure verge
#

ill wait PI_hmph

#

maybe you should just clean faster

upper pine
hybrid fjord
upper pine
upper pine
#

Still working on that one though

hybrid fjord
#

you mean before merge or before tag release?

upper pine
#

Before tag release

simple groveBOT
upper pine
#

I might also add pulse support to venmic although pipewire is obviously still to be preferred in case I add it

#

That will be a fun loopback spam x)

simple groveBOT
hybrid fjord
sour muralBOT
upper pine
hybrid fjord
#

why i didn't found soundux while creating crescendo T_T

upper pine
#

Soundux even has a, albeit really scuffed, pipewire implementation, however that was before I made rohrkabel xd

hybrid fjord
#

anyway i don't really want to refactor whole code for changing lib xd

#

plain C cool too

upper pine
#

Yeah Ill use the c API for pulse as well

#

Pulse audios API is simple enough that you don't need a wrapper

#

Pipewire on the other hand is absolutely fucked lmao

hybrid fjord
#

totally agree xD

simple groveBOT
vernal lintel
#

tbh i dont understand the default speaker switch

#

When sharing entire desktop audio, restrict to applications that play to the default speakers.

#

wha?

#

@upper pine

upper pine
#

Imagine you have some app playing to your speakers

#

And one app that's playing to a Bluetooth box or similar

#

With the old Venmic version, only the apps that played to the speaker would be shared

#

Now you can control the behavior to also include apps that don't play audio to the systems default speakers

upper pine
vernal lintel
#

i see

#

i think the description is a bit meh

upper pine
#

Any suggestions? I had a hard time coming up with a good description as well xd

vernal lintel
#

When sharing entire desktop audio, only share apps that play to the default speakers, ignore apps that play to other speakers (eg a bluetooth box).

upper pine
#

What about

#

When sharing entire desktop audio, only share apps that play to the default speakers and ignore apps that play to other speakers or devices.

vernal lintel
#

yea

upper pine
#

Alr will change it real quick

simple groveBOT
upper pine
#

Look like this now

#

Will push

azure verge
#

woa

#

damnit i want to finish this but i have a sore throat and brain hurty

azure verge
#

okay

#

i dont have the energy to figure it out rn but

#

here

#

someone fix this

#

its existed since the dawn of time

#

its not a big deal just if you cancel a stream instead of pressing go live

#

it does that

#

if its even fixable lol

#

might just be electron

#

being elexcyton

#

electron

#

god i am so sick lmao

vernal lintel
#

is this actually an issue?

#

or are you just annoyed with the error being printed

azure verge
#

annoyed lol

#

also

#

opinion?

#

i think it fits in quite nicely

#

would be better if they were the same width maybe

#

idk

#

im so fucking out of it rn

#

lmao

vernal lintel
#

make the box stretch

azure verge
#

wdym stretch

#

ohh i know what you mean i thinjk

#

i dont know whaqt you mean

#

whatever

#

toio tiired

#

afaik the pr is ready

#

id let @hybrid fjord or @broken solstice check it though

#

im not exactly trustworthy rn

hybrid fjord
#

I will do try to fix it today

humble mortar
#

hm nvtop isnt reporting any encoder usage when streaming on the latest commit

humble mortar
#

its not even attempting to use decode either

hallow trail
#

That screenshare twice popup is 100% some chromium regression

#

Is it tracked somewhere?

azure verge
#

WAIT

#

no

#

sorry

#

not my bad

#

disable and re-enable hardware accel in vesktop settings

humble mortar
azure verge
#

h u h

humble mortar
#

my drivers are def working

azure verge
#

oh what the hell you're right

#

it isnt working

humble mortar
azure verge
#

let me check and see if i broke something while rebasing

#

no

#

hmm

#

wtf

#

okay i got it

#

let me try something

#

okay try with new latest commit

#

@humble mortar

humble mortar
#

yep

#

fixed

azure verge
#

:D

#

basically

#

it was set so

#

if hardware accel = false it disabled hardware accel rasterization

#

and if true it enabled vaapi

#

but now

#

if false it does the same

#

otherwise enable vaapi

#

so an if else instead of a second if statement

#

seemed to fix it

#

I think for some reason that gets set to undefined sometimes

simple groveBOT
hot juniper
#

discord overlay sucks

#

unironically

#

do not try to reimplement the official one

hybrid fjord
#

Game overlay on Linux will probably greatly reduce fps in-game

#

And lol transparent window will just steal focus from system

broken solstice
rancid tartan
#

any idea why i cant maximize latest vesktop even though transparency is off

hybrid fjord
# azure verge i dont have the energy to figure it out rn but

looks like rejections from executeJavaScript are not catched by .catch function
If i just close Discord's screen picked (not portal's) then promise must be rejected by:
onCloseRequest() { closeModal(key); reject("Aborted"); }
or
close={() => { props.onClose(); if (!didSubmit) reject("Aborted"); }}
but actually not, i can't see "Aborted" logs

#

Or i just simply miss something

#

Also for latest commit starting stream while watching another stream is broken for me. But i believe we can't do anything about it, discord just not creating stream object in new connection

hybrid fjord
#

also before merging we must remove debug console.logs propably?

simple groveBOT
#

to clear this up for anyone reading/not sure if it will work on their nvidia gpu, it will not. Since NVIDIA only want to support their own APIs.

Browsers use VA-API. There's two currently maintained backends for VA-API that relate to Nvidia, VAAPI > VDPAU and VAAPI > NVDEC (which is the repo linked above), both of which are decode support only, with the latter mostly being aimed at Firefox.

The only hope for Nvidia users is hopefully either open source kernel drivers nouveau o...

#

to clear this up for anyone reading/not sure if it will work on their nvidia gpu, it will not. Since NVIDIA only want to support their own APIs.
Browsers use VA-API. There's two currently maintained backends for VA-API that relate to Nvidia, VAAPI > VDPAU and VAAPI > NVDEC (which is the repo linked above), both of which are decode support only, with the latter mostly being aimed at Firefox.
The only hope for Nvidia users is hopefully either open source kernel drivers nouveau or ...

broken solstice
#

Just a question, isn't this outdated since vulkan video dropped?

#

Any thoughts on this comment? @hybrid fjord @azure verge

broken solstice
hybrid fjord
#

I do not really know much about all this encoders

broken solstice
#

Well, looks like somebody commented rn. Timing AHAHAH

simple groveBOT
hybrid fjord
#

Oki, anyway discord overlay is quite useless

hot juniper
#

there are more important things to fix

#

like the notorious "if client is in background, it will disconnect from discord"

#

also

#

i recently discovered

#

that if you leave vesktop unfocused

#

it will stop accepting mic input

#

????????

simple groveBOT
hybrid fjord
simple groveBOT
simple groveBOT
#

Has anyone tested sharing a 2160p display using this rework?

There will not be enough bitrate for stable 4k sharing even on 30 FPS.

Nono, as in screensharing at 1080/1440 on a 2160p display, before it seemed I was getting worse performance than people using 1080/1440p displays. Was wondering if anyone has tried this using the rework.

Hello, before this PR resolution setting wasn't actually working which means that, irrespective of user choice, the resolution w...

azure verge
#

I don't know much about vulkan video

#

I just know vaapi is already supported by chrome so we're using it

#

if something better comes along we can change that

simple groveBOT
#

Not sure whether this is really related, but the current screen sharing implementation of the native Discord desktop client is pretty bad. Every time I stream anything on my screen, the frame rate of any currently playing game takes a noticeable hit. Is this different with this implementation?

Yes it will be, as you're probably noticing the impact of sotware transcoding done on your CPU instead of the dedicated hardware provided by most GPUs.

azure verge
#

that'd be great imo

#

I'm gonna clean up the code as soon as I get the energy to get out of bed

#

I can hardly swallow with my throat lmao

hybrid fjord
#

I can try to align them later

azure verge
#

oh lmao

hybrid fjord
azure verge
#

tyty

hybrid fjord
#

okay i found a way to align them but i do not like it

azure verge
#

im gonna try something simple

#

and just margin-bottom

hybrid fjord
azure verge
#

omfg

hybrid fjord
#

xd

#

i can use specified margin-bottom instead of height

simple groveBOT
hybrid fjord
#

margin-bottom creates space under cards

azure verge
#

my bad

#

padding-bottom

simple groveBOT
#

Not sure whether this is really related, but the current screen sharing implementation of the native Discord desktop client is pretty bad. Every time I stream anything on my screen, the frame rate of any currently playing game takes a noticeable hit. Is this different with this implementation?

Yes it will be, as you're probably noticing the impact of sotware transcoding done on your CPU instead of the dedicated hardware provided by most GPUs.

So this implementation will use the ...

azure verge
#

i am so annoyed

#

its ALMOST

#

perfect

#

its slightly higher

#

omfg

hybrid fjord
#

3 pixels diff

#

padding-bottom: 49px;

#

xd

simple groveBOT
#

So this implementation will use the proper GPU encoding with H.264 or HEVC with the NVIDIA hardware transcoding module? (Also on Linux)

..... If you read up, Nvidia does not implement VA-API encoding (there is https://github.com/elFarto/nvidia-vaapi-driver which translates decoding but it doesn't do encoding), meaning there is no infrastructure to do hardware accelerated encoding for Chromium / Electron on Nvidia Linux.

azure verge
#

personally i dont like using px

hybrid fjord
#

me too

azure verge
#

but idk what else to do lmao

#

lemme try and recreate it with like

#

em

hybrid fjord
#

we can do some calculations in % but they are bad too

azure verge
#

this is

#

i hate this

hybrid fjord
#

xd

azure verge
#

fuck it im using this

hybrid fjord
#

can you send screenshot?

azure verge
#

actually no

#

the px is probably better

#

well

#

hmm

#

it stays lined up

#

no matter what size the app is

#

which is good

#

even when stupidly tiny

hybrid fjord
#

yes
I just do not know why on 3.1 i got this

azure verge
#

oh

#

odd

#

lemme test it on a 1080p monitor

#

still perfectly even for me

#

let me just

#

look up online if there's a better way to do this

hybrid fjord
#

what if whole settings put in div, make card fit-content and add margins?

azure verge
#

ooh

vernal lintel
azure verge
hybrid fjord
#

fit- whole space actually

azure verge
#

i found a demo of something that seemed interesting

azure verge
hybrid fjord
vernal lintel
#

please learn css lmao ๐Ÿ˜ญ

azure verge
#

HAHAHHA

#

listen

#

im an avid oldnet enjoyer

#

so

#

beauty to me is no css

#

or very very little

#

so

vernal lintel
#

you should basically never hardcode specific dimensions

#

instead, use auto responsive layouts

#

you could use height: 100%;
or a flexbox
or a grid
or 3 million other methods

azure verge
#

that i know

azure verge
#

definitely not height 100%

#

LMAO

vernal lintel
#

and also apply it to the left side..

azure verge
#

but it adds a SCROLLBAR

#

i could just do like

#

height 95% or something

#

idfk

vernal lintel
#

because you're combining height 100% with something like a padding or margin which makes it more than 100% so overflow

#

you can fix it via box-sizing: border-box;

vernal lintel
azure verge
#

HAHAH

#

WHY NOT

vernal lintel
#

please never touch css again Ui_Pray || /lh ||

azure verge
#

LMAO

#

my website

vernal lintel
#

GIRL WHAT IS THAT

#

at least make them equal width ๐Ÿ˜ญ

#

anyway just ummm... leave the css to me ig

azure verge
#

LMAO

azure verge
#

THIS IS PRETTY

#

i want it too look like something you'd see in 1985

azure verge
vernal lintel
#

is the rest done

azure verge
#

afaik yes

#

i removed the excess console.logs

#

@hybrid fjord @broken solstice do you know of anything else that needs done?

hybrid fjord
#

i believe no, only bug that discord should fix and we can't do anything about it

azure verge
#

oki

broken solstice
#

And other upstream issues, yeah.
Also, it's such an improvement that the faster it gets to people the better ๐Ÿ™‚

azure verge
simple groveBOT
runic inlet
simple groveBOT
#

So this implementation will use the proper GPU encoding with H.264 or HEVC with the NVIDIA hardware transcoding module? (Also on Linux)

..... If you read up, Nvidia does not implement VA-API encoding (there is https://github.com/elFarto/nvidia-vaapi-driver which translates decoding but it doesn't do encoding), meaning there is no infrastructure to do hardware accelerated encoding for Chromium / Electron on Nvidia Linux.

OBS studio can use hardware encoding, so I don't really see...

#

So this implementation will use the proper GPU encoding with H.264 or HEVC with the NVIDIA hardware transcoding module? (Also on Linux)

..... If you read up, Nvidia does not implement VA-API encoding (there is https://github.com/elFarto/nvidia-vaapi-driver which translates decoding but it doesn't do encoding), meaning there is no infrastructure to do hardware accelerated encoding for Chromium / Electron on Nvidia Linux.

OBS studio can use hardware encoding, so I ...

simple groveBOT
#

So this implementation will use the proper GPU encoding with H.264 or HEVC with the NVIDIA hardware transcoding module? (Also on Linux)

..... If you read up, Nvidia does not implement VA-API encoding (there is https://github.com/elFarto/nvidia-vaapi-driver which translates decoding but it doesn't do encoding), meaning there is no infrastructure to do hardware accelerated encoding for Chromium / Electron on Nvidia Linux.

OBS studio can use hardware encoding...

#

So this implementation will use the proper GPU encoding with H.264 or HEVC with the NVIDIA hardware transcoding module? (Also on Linux)

..... If you read up, Nvidia does not implement VA-API encoding (there is https://github.com/elFarto/nvidia-vaapi-driver which translates decoding but it doesn't do encoding), meaning there is no infrastructure to do hardware accelerated encoding for Chromium / Electron on Nvidia Linux.

OBS studio can use hardware encoding...

#

So this implementation will use the proper GPU encoding with H.264 or HEVC with the NVIDIA hardware transcoding module? (Also on Linux)

..... If you read up, Nvidia does not implement VA-API encoding (there is https://github.com/elFarto/nvidia-vaapi-driver which translates decoding but it doesn't do encoding), meaning there is no infrastructure to do hardware accelerated encoding for Chromium / Electron on Nvidia Linux.

OBS studio can use hardware encoding...

#

So this implementation will use the proper GPU encoding with H.264 or HEVC with the NVIDIA hardware transcoding module? (Also on Linux)

..... If you read up, Nvidia does not implement VA-API encoding (there is https://github.com/elFarto/nvidia-vaapi-driver which translates decoding but it doesn't do encoding), meaning there is no infrastructure to do hardware accelerated encoding for Chromium / Electron on Nvidia Linux.

OBS studio ...

vernal lintel
#

guys please you don't have to quote the entire issue thread every time

azure verge
#

heheheh

#

its funny

simple groveBOT
#

So this implementation will use the proper GPU encoding with H.264 or HEVC with the NVIDIA hardware transcoding module? (Also on Linux)

..... If you read up, Nvidia does not implement VA-API encoding (there is https://github.com/elFarto/nvidia-vaapi-driver which translates decoding but it doesn't do encoding), meaning there is no infrastructure to do hardware accelerated encoding for Chromium / Electron on Nvidia Linux.

OBS...

azure verge
#

i added a new commit

#

everything seems to be fine

#

if something breaks ill just revert it

hybrid fjord
#

Looks good

#

Probably it will fix starting stream from 240p

#

So now we need to sacrifice 15 sheeps for UI commit from V xD
(actually plz don't spam)

azure verge
#

lmao true

#

and yeah

#

that's what i thought

#

wait

#

hmm

#

nah

#

i wonder if we set min to the selected res

#

if it would

#

start at selected

#

but still be able to drop

#

lemme test that

hybrid fjord
#

I tried setting selected res right after creating conn

#

But without success

hybrid fjord
azure verge
#

oki

#

is it increased in the repo?

hybrid fjord
#

No

azure verge
#

should i

#

do that

hybrid fjord
#

No, it didn't helped

azure verge
#

ahh

#

it seems to have scaled up a bit more aggressively but i still need to test more

hybrid fjord
#

We use timeout only for already created conn
And waiting 200 msecs only for letting discord reapply stream settings to default res and 30 fps so we can change it to our settings

sour muralBOT
azure verge
#

true one moment

#

fixed

hybrid fjord
#

^-^

upper pine
azure verge
#

tyty

simple groveBOT
real glade
#

@azure verge i haven't really been following, did you figure out the weird bitrate cap issues?

azure verge
#

that's not too important for this pr tho imo

real glade
#

fair

hybrid fjord
azure verge
#

i have nitro

#

unless its

hybrid fjord
#

Hm

azure verge
#

full nitro

#

i have basic

#

we need a full nitro acc to check

hybrid fjord
#

I believe I have full nitro

#

On main acc I can't reproduce 4696 bitrate

#

I will retest at home

#

Just to be sure

simple groveBOT
real glade
hybrid fjord
#

It may, because on non nitro accs there are restrictions in 720p30 and 4-5k bitrate will be enough
But for real we need to test it somehow :c

upper pine
#

Btw, I got pulseaudio support in venmic working but I'll have to do some more testing later on.

It's not nearly as pretty* as it is with pipewire but it works

  • it requires to move around some outputs which could introduce some unwanted behavior in case anything goes wrong (already accidentally triggered a feedback loop by unloading a module) and is not as robust as the pw backend. It could also add some latency, but that's to be expected with audio share on pulse
azure verge
#

ooh

azure verge
#

@hybrid fjord

#

it's nitro

hybrid fjord
#

Yes, Im about to write my tests result

#

Linux, Vesktop, no nitro acc, sticked to 4686 ~~~

#

Linux, Vesktop, full nitro

#

Windows, Discord native, no nitro

#

all with someone watched and streamed ufo-test on full screen to emulate motion
do not watch at res, i just not give time to make negotiations

#

maybe we should add some sort of warnings about bitrate for non-nitro? Maybe at readme at least
Or someone who knows about patches can find something related to "4000" and try to patch it to more bitrate, maybe it will unlock bitrate for non-nitro accs (just like fixed 2500 kbit problem)

broken solstice
real glade
#

that's very very interesting

#

they've never had a nitro limit before this

simple groveBOT
real glade
#

that begs the question as to why they don't validate resolution too

#

I wonder if this is some limit the client sets when it doesn't have nitro that we haven't found yet

#

try patching premiumType locally

simple groveBOT
#

Describe the bug

not getting pipewire audio source but when streaming its getting audio source

To Reproduce

  1. open vesktop
  2. join a channel

Expected behavior

getting audio source from pipewire just how the streaming window get or add a option in voice setting to pick audio source

Desktop (please complete the following information):

  • OS/Distro: Arch linux
  • Desktop Environment: Sway
  • Version: 2024.04.01
upper pine
#

bro

#

what

hybrid fjord
#

2 variants

simple groveBOT
hybrid fjord
#

or i don't know english well or the text doesn't make any sense
just looks like T9 created xd

upper pine
#

this

#

doesn't make any sense

azure verge
#

what the hell did i just read

simple groveBOT
hybrid fjord
#

ohh microphone not working

upper pine
#

What the fuck

hybrid fjord
#

but streams can capture audio

#

99% it's not vesktop problem

azure verge
#

ohh yeah

hybrid fjord
#

ahahahahha that 1000 clicks per second sound is so funny

simple groveBOT
upper pine
#

I have to hide venmic from the audio inputs

azure verge
#

scrcpy??????

simple groveBOT
azure verge
#

why the hell are they using scrcpy for a mic

simple groveBOT
hybrid fjord
#

omg he's propably using android as microphone input

#

at least trying to

simple groveBOT
azure verge
#

oml

simple groveBOT
hybrid fjord
#

it's srccpy problem then, bc it does not share microphone as input device properly
but shares as output device

upper pine
#

scrcpy is not intended for that at all

hybrid fjord
#

yeap

simple groveBOT
hybrid fjord
#

okay im confused

simple groveBOT
#

pw-cli ls Device
id 46, type PipeWire:Interface:Device/3
object.serial = "46"
factory.id = "14"
client.id = "45"
device.api = "alsa"
device.description = "Raven/Raven2/Fenghuang HDMI/DP Audio Controller (PRIME B450M-A Motherboard)"
device.name = "alsa_card.pci-0000_07_00.1"
device.nick = "HD-Audio Generic"
media.class = "Audio/Device"
id 47, type PipeWire:Interface:Device/3
object.serial = "47"
factory.id = "14"
client.id = "45"
device.api =...

#

id 28, type PipeWire:Interface:Node/3
object.serial = "28"
factory.id = "10"
priority.driver = "20000"
node.name = "Dummy-Driver"
id 29, type PipeWire:Interface:Node/3
object.serial = "29"
factory.id = "10"
priority.driver = "19000"
node.name = "Freewheel-Driver"
id 32, type PipeWire:Interface:Node/3
object.serial = "54"
factory.id = "13"
client.id = "45"
node.description = "BLE MIDI 1"
node.name = "bluez_midi.server"
media.class = ...

hybrid fjord
#

does id 51 looks like microphone?

simple groveBOT
upper pine
simple groveBOT
hybrid fjord
#

maybe qpwgraph scheme can help us?

upper pine
#

Could help, but should show roughly the same as the pw-cli output

hybrid fjord
#

maybe this node is somehow muted or disabled in pulseaudio control panel or system settinsg?

upper pine
#

Yeah

#

Let me check if pw-cli shows that

simple groveBOT
upper pine
#

Node shouldn't exist if the mic is turned off / disabled

#

Just checked

#

And muted devices should still show up

#

Maybe some sort of electron permission stuff? That would be unusual though

hybrid fjord
#

can we start vesktop from sudo?

upper pine
#

please dont lmao

hybrid fjord
#

maybe root user can't connect to another user's pipewire server, or something like that

upper pine
#

huh

#

but I would expect vesktop to be running under the same user he ran pw-cli in

simple groveBOT
real glade
simple groveBOT
#

id: 51
permissions: rwxm-
type: PipeWire:Interface:Node/3

  • input ports: 0/0
  • output ports: 2/65
  • state: "running"
  • properties:
  •   alsa.card = "1"
    
  •   alsa.card_name = "HD-Audio Generic"
    
  •   alsa.class = "generic"
    
  •   alsa.device = "0"
    
  •   alsa.driver_name = "snd_hda_intel"
    
  •   alsa.id = "ALC887-VD Analog"
    
  •   alsa.long_card_name = "HD-Audio Generic at 0xfcc80000 irq 63"
    
  •   alsa.name = "ALC887-VD Analog"
    
  •   alsa.resolution_bits = "16"
    
  •   alsa.subclass = "generic-mix"
    
  •   alsa.s...
    
real glade
#

discord is really weird

azure verge
#

sounds about right

azure verge
hybrid fjord
#

wtf with formatting

azure verge
#

is that

#

formatting

#

omfg

upper pine
real glade
#

i can also confirm it affects desktop too

upper pine
#

Why does this look so ass

real glade
#

so this isn't webrtc specific

#

and this is def recent because i've noticed bitrates of ~10k before on desktop

azure verge
#

put a border around it

upper pine
#

what can I do about it ๐Ÿ˜ญ

azure verge
#

make it not have the scrollbar

upper pine
#

how

azure verge
#

smaller size or bigger modal

upper pine
#

It's just a normal Modal component with text

azure verge
#

or reword it

hybrid fjord
azure verge
#

to remove a line

real glade
#

i'll try looking into it

hybrid fjord
#

we need just to know which bitrate is on windows

upper pine
#

it's still fucked with one line

#

wha

azure verge
#

WTF

#

uh

upper pine
#

At least it looks ok with padding

azure verge
upper pine
#

bruh

#

There has to be a better way

azure verge
#

who cares

upper pine
#

Other modals don't suffer from the issue either

azure verge
#

if it works it works

upper pine
azure verge
#

shhhh

upper pine
#

I have no idea what other modals do differently

azure verge
upper pine
#

Ja

#

Ich bin made in Germany

azure verge
#

WAS

#

ICH HABE GEDACHT DASS DU WARST IM AMERICA GEMACHT

#

(yes i know its amerika)

#

(no i dont care)

upper pine
#

Ich distanziere mich von Kriegcorp Inc.

azure verge
#

was ist kriegcoorp

upper pine
#

Amerika

azure verge
#

oh LMAO

#

i hate it here

upper pine
#

Ich glaub es mรผsste ein o sein lmao

upper pine
azure verge
hybrid fjord
#

you could talk about overflow: hidden in german so V wouldn't noticed

upper pine
azure verge
hybrid fjord
#

ahahahahha

#

bad plan

upper pine
azure verge
#

keine ahnung

upper pine
azure verge
#

its nice being able to speak german tho

upper pine
#

True

azure verge
#

i had a good language teacher

#

she doesnt care if we fuck around as long as its in german

#

so we end up teaching each other a shit ton just from being idiots

upper pine
azure verge
upper pine
#

kenn mich mit der politischen Lage nicht so aus xd Aber gibt leider viele Leute die brutal intolerant sind :(

#

Voice Message Modal has scroll bars as well???

azure verge
azure verge
#

wait

upper pine
#

what

#

w o t

azure verge
#

i added a css thing because discord broke their scrollbars and made them default chromium scrollbars

#

so maybe it fixed that

#

???

#

lemme check

upper pine
#

maybe??

#

I'm on latest Vesktop

#

with latest vencord update

upper pine
#

wait

#

maybe it's css stuff I have on

azure verge
#

this is at the bottom of my custom css

#
* {
    scrollbar-width: unset !important;
    scrollbar-color: unset !important;
}
upper pine
azure verge
upper pine
#

will try

azure verge
#

its in my quickcss

upper pine
#

that fixed it

#

l m a o

hybrid fjord
#

i do not have scroll bars on hardware-accel branch

azure verge
#

i think

#

check css snippets for scrollbars

upper pine
#

HOLY FUCK hahaha

azure verge
#

huh

upper pine
#

I just opened an app (I guess it was under xwayland) and my cursor was like at least 5cm large

hybrid fjord
#

grandma mode

upper pine
#

xddd

#

How can I log discord flux events again?

#

or view

azure verge
#

i have NO idea what those even are ima be honest

#

i kinda understand it

#

but not well

upper pine
#

arghhh

#

I want discord to show the modal for new microphone devices again

#

but I can only get it to show once

hybrid fjord
# simple grove

bro picking resolution and fps where stream settings are broken ahjhahahahaha

simple groveBOT
upper pine
#

uhm

#

how the fuck does discord get the microphones

hybrid fjord
#

sheeesh

upper pine
#

haha

azure verge
#

console.log e v e r y t h i n g

#

and you'll eventually find it

upper pine
#

it doesn't get them through enumerateDevices it seems

#

what else could they even use

hybrid fjord
#

what output if you just call await navigator.mediaDevices.enumerateDevices()?

upper pine
#

then it returns my mocked result

simple groveBOT
hybrid fjord
#

for me looks like that discord uses enumerateDevices() function and takes only kind: "audioinput"

upper pine
#

but I overwrote the func

#

ohhh

#

wait

#

maybe they cache it once

#

and then re-use their version of it

#

as in cache the function

#

so that they don't call my patched one

#

where in the vesktop source would I hook a func

#

before discord loads

hybrid fjord
#

you want overload it?

#

if yes then take a look at src/renderer/patches and file for screenSharing. There is overloaded function

hybrid fjord
#

its called on every enter to voice and video section

#

try at discord console:
const enumerateStock = navigator.mediaDevices.enumerateDevices

navigator.mediaDevices.enumerateDevices = async function() { console.log("I was called!"); return await enumerateStock.call(this); }
and on every entering to voice and video you will get "I was called!"

upper pine
#

seems to work when I patch in the screenshare file

#

now does anyone have an idea

#

how I can trigger discords "new device detected" screen?

#

Creating a dozen null sinks doesn't seem to trigger it

#

it seems really random

hybrid fjord
#

reconnect real devices?

upper pine
#

just tried

#

didn't work as well

hybrid fjord
#

maybe it have some cooldown

upper pine
#

fuck discords inconsistent shit xd

#

I restarted multiple times in between

#

also tried new names

#

FUCK

#

I triggered it

#

and accidentally clicked away

hybrid fjord
#

or this just for bots

#

there's also something like this. But i believe for >100 volume plugin we must edit WebRTC streams directly somehow

simple groveBOT
upper pine
#

Found this fucker

#

is there any section where I can apply vencord like patches specific to vesktop?

#

found it

#

does \i in a patch represent a valid variable name?

simple groveBOT
upper pine
#

Okay got it working :D

#

@vernal lintel What would be the best way to write to global settings from the Screen-Share Modal?

#

Nvm I don't think I'll even need that

hybrid fjord
#

Edit ScreenSharePicker.tsx file (add what you need in settings) and just import the streamSettings variable from it?
In 489 we exported it

upper pine
#

@azure verge Do you think this is too much text (especially since the spacing changes where you wanted to make sure that both have the same height)?

#

holy shit spectacle screen recordings have like 2 fps lmao

azure verge
upper pine
#

It's a warning

azure verge
#

close enoug

upper pine
#

๐Ÿ‘

simple groveBOT
hybrid fjord
#

We need another rebase probably?

#

For 489

upper pine
#

maybe, but I'd say yours goes first

upper pine
#

The chrome sound sharing code is ass lmao

simple groveBOT
azure verge
#

tbh i like our implementation more

simple groveBOT
simple groveBOT
slender gale
#

stars many

simple groveBOT
upper pine
#

The pulse approach has to move the output of certain applications to a loopback and then remap that as a mic

#

Which is prone to all sorts of problems due to the amount of fucked pulse audio modules that are loaded by default

#

Which will then fuck up the whole thing when You're not absolutely paranoid-like careful

#

But I think I have a pretty good idea on how we could avoid all those problems with our pulse backend for Venmic in the future

simple groveBOT
simple groveBOT
azure verge
#

I have genuinely no idea what is wrong

#

but it's definitely Chromium's problem I think

hybrid fjord
#

yeap

#

in firefox there is no this issue

#

i have idea to try alpha 30 electron, but i do not have time rn for experiments xd

azure verge
#

lmao

#

wait

#

so you see it in chromium though, right?

#

the weird stuttering

hybrid fjord
#

yes, on chromium i can see issue and in firefox there is plain 60 fps

azure verge
#

stuff glitches back and forth a lot

#

okay

#

good

#

yayy it's not our problem!!!

#

lmao

#

being done with the major issues is

#

a huge relief

#

yayy I can focus on getting my freebsd+zfs custom NAS running

hybrid fjord
#

i really believe we did everything we could

azure verge
#

other than bugfixes ofc

hybrid fjord
#

about screensharing i mean)

#

that pr

azure verge
#

yeah

#

it's in a good state rn

#

I packaged it a few days ago and I've been using it ever since

#

it's stable as rocks

hybrid fjord
#

it's propably even better that windows native because of content-motion setting

#

on windows with text setting stream is limited to 15 fps

#

and no way to choose res/fps

azure verge
#

yeah we use motion and detail instead of motion and text

#

text is the limiting one

hybrid fjord
simple groveBOT
vernal lintel
# simple grove

btw if any mac user could look into this and figure out the entitlements and stuff and confirm it works

#

that would be super appreciated

#

but ig it's hard to test cause you'd need to sign with your own developer certificate

fringe pollen
simple groveBOT
azure verge
#

they're also a dev so they aren't dumb as rocks

fringe pollen
#

lmao thats by far my favorite way to address end users

azure verge
#

THEY ARE THO

vernal lintel
azure verge
#

not that I'm much better

fringe pollen
#

(not disagreeing)

azure verge
#

I use rocks for everything

#

stable as rocks

#

dumb as rocks

#

etc.

vernal lintel
#

kaitlyn as rocks

#

someone buy that domain and redirect it to vencord.dev

#

im slightly too sane to spend 10 bucks on a joke

hybrid fjord
#

it says 25 for me T_T

azure verge
azure verge
#

but a joke is a joke

#

@vernal lintel it was only $5.64 for the first year

vernal lintel
#

NO

#

LMAOOO

#

omg did u actually ๐Ÿ˜ญ

azure verge
#

yes

#

I'll redirect it later

#

also

#

I can hackintosh an old laptop

#

if you need

vernal lintel
#

btw is ur pr all done now

#

should i review and stuff

simple groveBOT
hybrid fjord
vernal lintel
#

alright

#

thank you guys for working on this so much btw vennieflower

simple groveBOT
#

Sorry if it has gotten buried in here somewhere, but is there a solution for the stream lagging/skipping based on mouse movement over/in the streamed window? I believe I may have seen a comment about it being specific to certain DEs? I'm using kde plasma in wayland.

We believe this is a Chromium upstream issue, because this behavior is not reproducing in Firefox browser.
For temp solution, you can try to stream application window instead o...

azure verge
azure verge
#

I fix when thing no work

hybrid fjord
#

that was our problem too)

#

and problem for many many people who rn waiting for merge ^^

azure verge
#

mhmm

azure verge
#

hopefully they can help

hallow trail
#

Very nice, was anything gleaned about the mouse movement issue?

hybrid fjord
#

issue not reproducible in firefox browser so that means that this is chromium issue -> electron issue

hallow trail
#

Chromium tries not to regress challenge (impossible)

upper pine
#

@vale sierra Can we get #504 in before the update as well?

hallow trail
#

Thankyou for all the work kait and everyone else!

#

Will be getting my friends on ven

azure verge
#

@vernal lintel give @feral fulcrum programming role

vernal lintel
#

v+ programming @feral fulcrum

hybrid fjord
#

xd

simple groveBOT
#

Sorry if it has gotten buried in here somewhere, but is there a solution for the stream lagging/skipping based on mouse movement over/in the streamed window? I believe I may have seen a comment about it being specific to certain DEs? I'm using kde plasma in wayland.

We believe this is a Chromium upstream issue, because this behavior is not reproducing in Firefox browser. For temp solution, you can try to stream application window inst...

upper pine
simple groveBOT
feral fulcrum
#

||(@azure verge why am i here)||

azure verge
#

macos stuff
you're the one with the proxmox instance

simple groveBOT
#

I don't mean to be rude but I'm subscribed to this PR because I'd like to track the development of it, I would prefer if exploratory questions like that could be moved to IM.

There's a lot of noise here from lots of people waiting for this PR which drowns out useful information (which is why iirc we talked 3 times about Nvidia encode despite it not happening).

#

I don't mean to be rude but I'm subscribed to this PR because I'd like to track the development of it, I would prefer if exploratory questions like that could be moved to IM.

There's a lot of noise here from lots of people waiting for this PR which drowns out useful information (which is why iirc we talked 3 times about Nvidia encode despite it not happening).

That's a fair point. Further questions can be directed at my discord: kaitlynyaa (although this PR is due for a merge real...

vernal lintel
#

wtf is IM

azure verge
#

instant message

#

so any sort of like

#

dms

vernal lintel
# simple grove

me when the development thread is used to discuss development WHAT

azure verge
#

REAL

#

i just dont care to argue

#

not in the mood after my school was really pissy today so im in what's basically a heated email argument with the administration

vernal lintel
#

oh god

azure verge
#

because they got mad at me for using german in my senior quote and said it could cause issues on social media or some shit

#

so im basically tearing them apart

#

i QUOTED FUCKING SIGNALIS

#

CALM THE HELL DOWN

#

LMAO

vernal lintel
#

lol???

#

they wanted u to use english instead??

#

why are they mad ๐Ÿ˜ญ acting like u quoted hitler or some shit

azure verge
#

they were like "it has to be positive or it will cause issues"

vernal lintel
#

lmaooooo

azure verge
#

bitch i said "achtung. achtung. 39204 27950 45840" (different numbers but i dont care to remember them rn)

#

ITS NOT FUCKING CAUSING ISSUES LMAO

#

i am so done with this school

#

nice one

#

new role

simple groveBOT
#

Is your feature request related to a problem? Please describe.
No. Basically I just want to be able to change the Vesktop logo that appears in the taskbar and tray

Describe the solution you'd like
Anyways the point is I wish I could change the vesktop logo to something else wether it be the discord logo or some silly little meme

Describe alternatives you've considered
Not too sure? I don't see and alternative way of doing this unless vesktop changes the default icon which...

azure verge
#

tHATS PART OF LITERALLY ANY DESKTOP ENVIRONMENT OMFG

simple groveBOT
feral fulcrum
azure verge
#

true i am on my laptop rn

#

@vernal lintel so uhh yeah i have this now

#

not that i know much about macos

#

but i can test things!!!

#

the hEll

feral fulcrum
#

L badly configured webserver

azure verge
#

@vernal lintel waaaah what do i need to changeeeee

#

or is your ssl just bad

hybrid fjord
#

@azure verge any idea how we can get input connection objects?

azure verge
#

wdym

hybrid fjord
#

if i in call with someone i want to get input connection from other person, like receiver or smth
i believe [...MediaEngineStore.getMediaEngine().connections] only returns our voice and video send connections

#

or i wrong?

humble mortar
#

Uh I should probably add here that streaming genshin impact displays the cursor with a blue tint instead of its normal yellow 0.o (will test if obs or wtv captures it properly later)

feral fulcrum
vernal lintel
#

our certificate only applies to vencord.dev

#

i need to add the domain as a name for the site and then it'll work

#

welll xd you need to change your nameservers to cloudflare for it to be usable via cf pages

azure verge
#

lmao

#

okay gimme a bit

#

I will

#

I use cf for the rest of my domains anyways

vernal lintel
#

oh wait transferring NS is only necessary if using apex domain

#

so if we used like www.vencord.rocks it wouldn't need to be

#

but www sucks lmao

#

fuck www all my homies hate www

azure verge
#

REALL

simple groveBOT
simple groveBOT
simple groveBOT
azure verge
#

except for like

#

idk

#

git.vencord.rocks could be the GitHub

#

same for vesktop.vencord.rocks

#

or I could make my own version of the vencord website and just ship malware /j

vernal lintel
#

make a rock themed fork of the vencord site

hybrid fjord
#

And use hardcoded height weight values in pixels everywhere where you can

azure verge
#

click on it and it downloads vencord

feral fulcrum
azure verge
#

omfg

#

@vernal lintel i could make @vencord.rocks email addresses

simple groveBOT
hot juniper
cyan flame
azure verge
#

I want both

#

gay

#

GAY WOMEN KISSING โ€ผ๏ธ

#

lmao

simple groveBOT
simple groveBOT
cyan flame
azure verge
#

LMAO

#

what can I say

#

Im quite blunt

simple groveBOT
#

As far as I know you can have multiple implementations of the same portal exposed via dbus. So, maybe this could be fixed by having an xdg-desktop-portal implementation for gamescope, thus this being an issue for upstream gamescope?

Unfortunately gamescope has no plans to implement/support the xdg-desktop-portal, if you can convince them otherwise more power to you.

simple groveBOT
#

Unfortunately gamescope has no plans to implement/support the xdg-desktop-portal, if you can convince them otherwise more power to you.

Then it's not going to be done because screensharing in Electron relies on desktop portals. It would be easier for them to implement it than for anyone to attempt to hack support into Electron.

Uh... electron already has support for pipewire sources as camera feeds, the problem is that it specifically filters out any source not marked as a "came...

simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
upper pine
hybrid fjord
#

electron 30 released, can we use it in next release tag?

simple groveBOT
azure verge
azure verge
azure verge
#

ignore this

#

oh come on nvm ugh waaah

#

it wont let me upload the file

simple groveBOT
azure verge
#

@sly cairn uhhh im kinda new to flatpak builder
i feel like im doing this really wrong
how would i build it from a local appimage

feral fulcrum
azure verge
#

and i

#

i hate that idea

feral fulcrum
#

Its called a kext

azure verge
#

kext moment

hot juniper
#

i have absolutely no idea what is happening in here but there is absolutely no reason you should be anywhere near that depth of the system for something like this (unless macOS has extremely stupid levels of "security")

azure verge
#

i agree, although it does

#

lmao

feral fulcrum
#

You have obviously never used macos..

hot juniper
vernal lintel
azure verge
#

me installing a kext to browse the internet:

vernal lintel
#

there's a proper system api

upper pine
feral fulcrum
vernal lintel
azure verge
upper pine
hot juniper
upper pine
vernal lintel
feral fulcrum
#

It sounded sketchy as fuck

vernal lintel
#

it creates a virtual audio device

hot juniper
feral fulcrum
#

Imagine drm