the tooltip is a bitch to get to work how i want it to
#🖥-vesktop-development
azure verge
oh wait and the go live button is shifted oddly
Go Back works properly tho
lemme commit what i have before my laptop dies
hybrid fjord
What about this idea?
Maybe better to not use it for now for not creating another one portal's picker
Or we can just replace whole streaming starting logic, but, maybe no sense of doing it
azure verge
?
pressing go back just calls getDisplayMedia
because
well
it calls close
then getDisplayMedia
because getDisplayMedia is what's called to open a portal and then the screensharepicker
oohhh i have an idea as to why its called twice on window opens
ill look into it
hybrid fjord
Okay I do not quite understand how it works now but at least I helped to create idea 😄
azure verge
here
this file should be the one
that line
line 60 seems like it may be the culprit of the second call to getDisplayMedia
maybe
vernal lintel
i think this is bad UX
azure verge
oh?
vernal lintel
having two cancel buttons is confusing
azure verge
true
vernal lintel
leave it next to the preview
azure verge
good point
vernal lintel
stick to discords design
azure verge
im gonna change that rq
vernal lintel
modals / popups should always have one positive and one negative option
two negative options is confusing
azure verge
fair
azure verge
how set key on modal so closeModal works,,,?
better question
how the hell do i use closemodal to close the screenshare modal from outside of it
close(); just closes the entire vesktop window
vernal lintel
@azure verge is gonna kill u
azure verge
omfg
upper pine
Yeah kinda unfortunate, I'll put up the PR and wait for theirs to get merged first
azure verge
lmao
upper pine
then rebase
upper pine
Make it wide
azure verge
I tried
azure verge
@vernal lintel doesn't like it 
upper pine
Show how it looks
upper pine
<@306158896630988801> is gonna kill u
Is the wording ok?
upper pine
what about default layout
azure verge
wdym
azure verge
I think
idk how to do that in css without a bunch more work
I'm gonna leave it as is for now
we can rethink it later
upper pine
I think you can do that with the existing components without css
azure verge
plus idk how much longer the mic workaround will be needed(if I understand it properly)
upper pine
plus idk how much longer the mic workaround will be needed(if I understand it pr...
I don't think it's gonna get removed any time soon
Afaik there's no known cause for the issue, some distros / pipewire configs just fuck it up
simple groveBOT
azure verge
cuz like I can't see why selecting something like Firefox for example
selects the user microphone
upper pine
what is the EXACT issue
On Linux Mint for example, when Discords Screenshare tries to use the venmic microphone, the server instead redirects it to the default microphone
upper pine
Yes, but it's not an issue we've caused, it's an issue in Firefox, Chrome as well so probs with the pipewire version? config?
azure verge
yeah
that's my guess too
wait
does having the workaround on cause any problems
if you don't need it
upper pine
no, we could theoretically always enable it but I'd prefer not to
azure verge
may I ask what it does and why not permanently enable
upper pine
or rather, it's not used by many so we don't know if it might cause problems
upper pine
may I ask what it does and why not permanently enable
it forces the next created node that matches some given properties to be connected to venmic
azure verge
I can use it on my system to see if I'm good with default config
azure verge
it forces the next created node that matches some given properties to be connect...
oh interesting
upper pine
I can use it on my system to see if I'm good with default config
I'd be cautious though as there are some systems with really weird audio configurations, which we currently support pretty well
hybrid fjord
Can we move microphone workaround and require default speakers to some sort of expandable section?
Like button (or smth) "More options" and when clicked it will expand and show these two options
upper pine
Can we move microphone workaround and require default speakers to some sort of e...
Good idea
hybrid fjord
Maybe we can think on moving audio source choosing to this section too
hybrid fjord
@azure verge check this edited message about hardware encoding when hardware accel is disabled
Maybe we should try to remove/comment flags for disable accel?
simple groveBOT
azure verge
<@306158896630988801> check this edited message about hardware encoding when har...
wdym
upper pine
@vernal lintel @azure verge does that look ok?
azure verge
I put the encoder flags in the hardware accel if statement cuz it made sense to me
idk if they should be something the user can't opt out of
azure verge
personally I like it
hybrid fjord
I put the encoder flags in the hardware accel if statement cuz it made sense to ...
But if I understand rightly, he said that removing flags enables hardware encoding..
azure verge
what they said was that disabling and re-enabling the setting made it work
it was the setting not storing it's value for some reason afaik
upper pine
xd what if in code we just add-remove-add flags
I don't think that would be necessary, if I understood correctly that was just a config saving quirk
hybrid fjord
Yeah it would be great ^^
Didn't knew you are a maintainer of Rohrkabel
It helped me a lot so thank you)
upper pine
Didn't knew you are a maintainer of Rohrkabel
I'm the only maintainer :P
upper pine
It helped me a lot so thank you)
Glad to hear :D
simple groveBOT
upper pine
v5 released today btw ^^
hybrid fjord
v5 released today btw ^^
It's great)
simple groveBOT
upper pine
Does someone here run pulse only (no pipewire)?
azure verge
honestly
if this became the new menu
id ask you to merge it before i merge this pr
upper pine
sure ^^
upper pine
Ven needs to approve tho
hybrid fjord
Can we move microphone workaround and require default speakers to some sort of e...
Also don't forget about expandable section variant
upper pine
btw, @vernal lintel, I've had someone complain about the pulse check, as they run some hybrid setup, I think I'll remove the error condition when pipewire was not detected as the main audio server, and instead only log a warning
You can still call has_pipewire from node and we should probably open a modal informing the user that pipewire was not detected as the main audio server, if he knows what he's doing and wants to continue anyway, or if he properly wants to setup pipewire-pulse
Sorry for all the pings 😅
azure verge
@hybrid fjord what's the status on displaysurface
do we know if its the cause behind the weird framerate cursor tie
hybrid fjord
We are not sure whether this is a cause or not
For checking we need to somehow pass displaySurface as display and correct display id to stream object instead window as electron returns
But it seems logical to me that this is a cause
azure verge
are we able to test if the framerate is better with displaysurface set correctly?
although tbf
if it is a cause
it seems to be the kind of thing we should wait on electron for
and just merge anyways
hybrid fjord
I think with display surface we need to pass id as screen : x:0 correctly instead of window, but I do not know how to get screen's id
However I can test whether just applying displaySurface to screen helps
azure verge
if you test that i think we should wait on electron
and merge anyways
and if they dont fix it
we can make another pr with a fix
hybrid fjord
if you test that i think we should wait on electron
Yeap, because we can't know what picked user (window or screen) for applying displaySurface correctly
We receive "window" in all cases
azure verge
yeah
hybrid fjord
But it seems logical to me that this is a cause
It's always logical because it seems that if we on kde choose window then we get frames only when window updates
But for display on kde we have slightly 50-60 (bc looks that kde updates almost always) and updates only when screen updates on systems like gnome (looks like their update system updates only on updates)
azure verge
on kde when i choose window i get 60 afaik
display makes it only update when updates
but it checks the display plane
not cursor plane
hybrid fjord
Okay we need more tests I believe
Bc recently I successfully got same behavior as on gnome for windows streaming
azure verge
w h at
simple groveBOT
upper pine
btw, <@343383572805058560>, I've had someone complain about the pulse check, as ...
Also remind me to add some sort of automatic audio suggestion when starting the screen share and not explicitly selecting something
Could probably use some sort of Levenstein?
simple groveBOT
hybrid fjord
Also remind me to add some sort of automatic audio suggestion when starting the ...
easiest way will be for default enable whole system audio sharing
I think even on windows native version this is default for now (it actually have checkbox like "Enable screen audio sharing" which remembers user's choice, but i think we can't use this in this way)
simple groveBOT
upper pine
easiest way will be for default enable whole system audio sharing
I think even o...
I think it only shares the audio of the selected application on Windows by default
hybrid fjord
I think it only shares the audio of the selected application on Windows by defau...
when you picking application window then it shares only app sounds
But if you pick screen then it have this checkbox which streams all sounds in system except discord voices
upper pine
when you picking application window then it shares only app sounds
But if you pi...
yes
I want to replicate that behavior
as far as possible
We can already get some app names, and I can cross ref that with the avaialble pipewire nodes through some sort of closest match sorting
hybrid fjord
w h at
i can reproduce it on latest commit.
When i start streaming Kate as window then i get updates only when mouse moves:
azure verge
i can reproduce it on latest commit.
When i start streaming Kate as window then ...
with further testing
same
just
i had originally tested with
doom eternal
and that forced 60fps
hybrid fjord
bc of game updates more than 60fps?
azure verge
most likely
humble mortar
I'm currently reinstalling arch (my system is having issues and I'm trying to figure it out(may be hardware))
hybrid fjord
About bug that calls portal's screen picker twice. I can reproduce it even in chromium using getDisplayMedia plain function, so it is a not our bug
It calls only when picking window, for picking screen it calls only once
azure verge
odd
broken solstice
It calls only when picking window, for picking screen it calls only once
I recently started to get double pick on monitor
azure verge
interesting
hybrid fjord
okay, i tested few times in discord and in webrtc demo and for screen choosing i have 1 picker and for window 2 pickers
hybrid fjord
i tried many ways to specify displaySurface to monitor but without success.
displaySurface field is located in MediaTrackSettings dict so it propably using some different logic from constraints
also it can be linked with deviceId property and refuses to change displaySurface to monitor while we have deviceId: window:x:0
simple groveBOT
hybrid fjord
Okay, i have some really useful information
In webrtc demo which uses sender and receiver and even does WebRTC negotiations i wrote FPS for sender FPS and receiver FPS.
And even when i pick screen using plain WebRTC's getDisplayMedia() function i do have FPS drops when i move mouse. Thats means that setting displaySurface to 'monitor' will not fix this bug.
When picking window i do have the same behavior with updating fps only when window updates.
if someone want to play with discord-like streaming - you can with this demo
hybrid fjord
Maybe it is some upstream's bug? Or even it's a feature in some scenarios..
azure verge
or xdg-portal
hybrid fjord
chromium bug maybe?
let me retest in firefox, if it will not break
FPS not droping in firefox
means its chromium bug
hybrid fjord
firstly i must really good search in their bugtracker. Maybe it is already reported
azure verge
true
hybrid fjord
Also in firefox i have two picker calls whether i pick screen or window
azure verge
wacky
hybrid fjord
tf is that
hybrid fjord
I believe i have fps drops on mouse-moving even when streaming browser window with 60fps video
created bug report, but looks like i accidentally picked Blink section :c. I hope devs will change to right section it.
https://issues.chromium.org/issues/333945842
okay time to sleep i think, 2am already
so with this new info i believe we can't fix this independently
azure verge
created bug report, but looks like i accidentally picked Blink section :c. I hop...
i did the same thing when i made an issue
i think its automatic
azure verge
so with this new info i believe we can't fix this independently
yeah im gonna remove that
well that's a graphics update
i wish we could lock it to 60/30fps
if it stayed locked
itd be a lot better
azure verge
okay
so
i have an idea
the bitrate lowers when someone starts watching, right?
maybe instead of looking for the amount it locks to
we need to look at what functions are called when someone starts watching
maybe then we can find which one patches the bitrate
i think we just needed to look at it from a different perspective
uh
should we care that encode is 720p30?
vernal lintel
set height and width
azure verge
i will i just wondered if it is something we should care about
eh to hell with it
ill add it to the patch
i should anyways
yayyy
okay
when someone starts watching i THINK it reapplies videostreamparameters
idk why that would cause issues though
S(this, "handleVideo", e=>{
var t;
return this.emit(d.BaseConnectionEvent.Video, this.userId, e, this.audioSSRC, this.videoStreamParameters[0].ssrc,
null !== (t = this.videoStreamParameters[0].rtxSsrc) && void 0 !== t ? t : 0, this.videoStreamParameters)
}
hybrid fjord
Wonder if there is any way to decrease latency? Bc in theory WebRTC streams can work with almost 0 latency like for camera, but in discord streams on preview we currently can see latency about 100-200 ms. Also in demo there is latency too. I will try to play with parameters on demo, maybe I can find something
hybrid fjord
about this. Why we can't just stream gamescope as window?
upper pine
@vernal lintel I thought about removing the pulseaudio depdencency and instead checking it from pipewire, however there seems to be no fully portable way to do so, although there's a way that should work 99% of the time unless the user has some really fucked configuration - Should we then remove the current pw-pulse check (that requires pulseadudio to be linked) and instead only show a warning modal in the frontend when no pw-pulse was detected
azure verge
Wonder if there is any way to decrease latency? Bc in theory WebRTC streams can ...
interesting
if you look into that ill look into bitrate
im waiting for v's opinion on the new modal before i start styling ours
cuz im gonna rebase from the newest version
hybrid fjord
if you look into that ill look into bitrate
I tried but without success
hybrid fjord
Dunno, we need to check more settings/constraints and search something about latency
azure verge
oki
hybrid fjord
Also in senders/receivers too
azure verge
```js
S(this, "handleVideo", e=>{
var t;
return this.emit(d.BaseConnectionEv...
i dont think this would be an issue
we already patched that
time to patch this
azure verge
Also in senders/receivers too
im not able to talk but are you able to hop in vc rq so i can test something?
i need someone to start watching the stream
nvm i got it
vernal lintel
<@343383572805058560> I thought about removing the pulseaudio depdencency and in...
why are you trying to remove the dependency?
azure verge
i cant even test this 😭
my laptop cant encode fast enough
and idk if my hotspot is fast enough for 1440p60
to test the bitrate limit
azure verge
hey uh v
opinion?
upper pine
why are you trying to remove the dependency?
Why not
But until there's a good way to see it from pipewire I should probably keep it
vernal lintel
that looks decent
upper pine
Should I PR?
azure verge
can one of you @broken solstice @hybrid fjord test with my newest commit and lmk if the 4696 limit is still there when someone watches?
hybrid fjord
I'm not in home rn :c
azure verge
oki ur good
worst case scenario i test at home
oh
odd
my laptop isnt hw accelerated
oh
fixed it
my laptop IS powerful enough
lmao
hmm
i cant break 4000 anymore
what the hell
okay that's not happening anymore but the framerate is locked at 30
wHAT the HELL
im just gonna revert whatever i did
hybrid fjord
xD
upper pine
Should I PR?
I'll do some design testing and then PR the Venmic update
If that's ok with you @azure verge
The changes are probably going to be fairly minimal
azure verge
ofc
I turned my pr into a draft because I forgot to
it's not getting merged until the menu is done
azure verge
yeah
as soon as your PR is done
ill rebase and finish the screensharing modal
ill test a bunch of stuff
and then ready my pr for merge
upper pine
Next update is gonna be huge
upper pine
"we fixed everything"
Hotifx 2 seconds later
broken solstice
can one of you <@414554932679802886> <@242305263313485825> test with my newest c...
Hmmm, I will test when I'm back home
azure verge
Hotifx 2 seconds later
yep
azure verge
Hmmm, I will test when I'm back home
dont worry about it
broken solstice
Wait, you think to have lifted the limit?
azure verge
yeah
broken solstice
it just broke everything
Hmmm, perhaps you might have been onto something tho
Perhaps
azure verge
I'm gonna focus on the modal tho first
azure verge
Perhaps
bitrate in conn.videoQualityManager was limited to 4000
with target at 6000
so it could explain 4696
maybe
idk if I fixed it I'll let y'all know
no big deal
for now tho
im gonna test
add new modal
and merge
we can PR with any other fixes later
broken solstice
Sure, let's keep that in mind
Later, when I'm home, we can experiment with it a bit
broken solstice
add new modal
Before you set it as ready you can send me a screenshot if you want some feedback 🙂
azure verge
ofc
simple groveBOT
azure verge
👀
upper pine
@vernal lintel How should I handle the width here? Neither of the predefined classes look good
Should I add my own?
If so, should I use vw?
upper pine
<@343383572805058560> How should I handle the width here? Neither of the predefi...
@mossy torrent You probably know this as well?
simple groveBOT
upper pine
Yeah it was a stupid question
Wasn't sure if I should pin the modal width with px or vw
vernal lintel
why do it at all
upper pine
The normal width is way too narrow
upper pine
Ik, but the Medium one is also too narrow and Large is FUllscreen
vernal lintel
then you need to rethink the ui :p
azure verge
i accidentally clicked on the image absent mindedly and i thought that someone said something here and i got excited 😭
azure verge
honestly
no
i like that
because
there needs to be room under res and fps
for the content hint
that gives that room
azure verge
id use up the space under res and framerate with the "smoothness vs clarity" button
yeah
upper pine
Then I'll PR it like that
azure verge
yeah large is massive
i tested with large
there's also a size called dynamic
idk what it looks like
upper pine
That's straight up fullscreen lmao
azure verge
HAHAHAHHAA
azure verge
o;HgghjhhHGAHJAHHAHAHAHASHKAS:DAJSD:AKJSDH:AHA:HA
i hit my keep so hard it opened 6 help windows and added strikethrough
azure verge
LMAO
upper pine
Discord is borderline unusable on Nvidia with both xwayland and normal wayland
holy fuck this is killing me
I can't type like this
oops
was about to push with dynamic size hahaha
azure verge
HAHHAHA
azure verge
I can't type like this
y e p
did you test the new modal on xorg to make sure it all works properly
azure verge
yep
which is why i suggest testing
there's a variable called isWayland in the main process
you could probably pass its value to renderer if you need to
upper pine
Bruh fuck wayland we don't get any useful information on the selected window here
so much for auto suggestion the audio source
upper pine
do they even get any useful information from the portal??
azure verge
they also shouldn't be returning window:xx:x for everything
azure verge
they also shouldn't be returning window:xx:x for everything
this causes issues
its supposed to be window:xx:x and screen:xx:x i believe
@hybrid fjord knows more
azure verge
do they even get any useful information from the portal??
im quite curious
azure verge
<@242305263313485825> knows more
if you select a window through portals on your demo app @hybrid fjord, what info does it give about the app?
does it give app name and everything?
hybrid fjord
does it give app name and everything?
I believe no, I didn't see anything like that
But I have an idea
Maybe when we have id like "window 31 0" we can just make some call to something which will return more info? Maybe DBus has any functions for it?
azure verge
possibly
upper pine
I believe no, I didn't see anything like that
But I have an idea
Maybe when we h...
I checked if pipewire has any mapping for that but doesn't seem like it
azure verge
hm
im gonna look into what the portal itself returns
if there's documentation on that anywhere
upper pine
wait
how does the pipewire screensharing even work
does anyone have any docs on that by any chance?
upper pine
oh bruh this is all dbus
hybrid fjord
What we must do on dbus-less systems..
upper pine
can't I access the information through the pw-api as well?
azure verge
i have no idea
hybrid fjord
Okay whenever I think we can use some DBus calls and get more info
I will try all of it when I got home
upper pine
I'd like to avoid dbus if possible
okay
obs uses pipewire to screen capture
surely they dont use dbus for that
hybrid fjord
https://developer.mozilla.org/en-US/docs/Web/API/MediaDevices/enumerateDevices
Maybe this function will return something useful?
upper pine
https://developer.mozilla.org/en-US/docs/Web/API/MediaDevices/enumerateDevices
M...
I want info on windows tho
not hardware devices
hybrid fjord
Maybe it returns something for windows too?
upper pine
like not windows the os
hybrid fjord
I can't check rn(
hybrid fjord
But the screen share windows
I mean this too
upper pine
ah sorry 😅
hybrid fjord
xd
broken solstice
@azure verge anything to test?
broken solstice
Ah, okay, what about the bitrate thinghy?
azure verge
im waiting for this stuff to get merged
upper pine
am in physics class
uff pyhsics
azure verge
conn.videoQualityManager
look at that property
it has bitrate stuff on it
it may be part of the issue
gl tho
broken solstice
I'm testing out your reverted commit
azure verge
go ahead
lol
it stopped working for me
and i dont have time to troubleshoot rn
so i undid it
azure verge
it locked my fps to 30 whar
broken solstice
Still very low fps unless moving the cursor, same limit
vernal lintel
funny
upper pine
btw v
can we put this up here?
ah
no
I see why
how can I access a static member then
vernal lintel
have to refactor the code a bit
upper pine
alr
I'll PR it in it's current form then
I removed the error for when the user is not running pipewire-pulse
and made it a warning instead
vernal lintel
kinda ugly xd
upper pine
We'll have to make sure to check PatchBay.hasPipeWire() to show a warning when pipewire-pulse is not installed
upper pine
kinda ugly xd
lmao
vernal lintel
tbh i still dont understand why even bother to drop pulse dep
isnt pulse required to use electron
upper pine
Dunno
I didn't drop it though
I just made running pipewire-pulse optional
But true
You probably need pipewire pulse anyway
upper pine
isnt pulse required to use electron
Saw this: https://github.com/tildearrow/venmic
upper pine
Saw this: https://github.com/tildearrow/venmic
I just asked him about his setup, will have to wait for a response
upper pine
We'll have to make sure to check `PatchBay.hasPipeWire()` to show a warning when...
But regardless, this should better be handled with an explicit check in Node rather than a C++ Runtime Error
upper pine
kinda ugly xd
.constructor doesnt seem to exist in TS xd
simple groveBOT
Changes
- [x] Adds new setting for
Only Default Speakers - [x] Re-Design the ScreenShare Picker (#489)
Screenshots
upper pine
yeah I did that before opening the PR xd
broken solstice
yeah but id add a period
I wouldn't 🙂
azure verge
are you only capturing those or are you redirecting them
azure verge
I wouldn't 🙂
why lol
broken solstice
why lol
Hmm, generally, unless it's multiple sentences, I would avoid periods
let me find a reference for it
upper pine
other settings use trailing periods as well
broken solstice
other settings use trailing periods as well
If it's consistent then sure
That's more important
upper pine
But regardless, this should better be handled with an explicit check in Node rat...
@vernal lintel We should probably also make the Glibc error hint a modal
as well as the pipewire-pulse warning
azure verge
wowie a new message (its just a new star notif)
upper pine
I'm hyped really hyped for #489
broken solstice
Sooo
for some reason
Having vkcube onscreen totally fixes the screen stream's update issue
Like, instantly goes from 5-10 to 45-50
I wonder what's causing that
upper pine
gpu usage?
broken solstice
I thought about clock but I already have a script that pushes that (if you're wondering why, it's because in the past xwayland discord flickered when changing GPU Clock)
upper pine
hmm
broken solstice
~13%
sometimes 20-30
IT'S FRAMERATE RELATED
okay, so, here's what I did
I opened Rainworld, which uses DXVK, if I unset the max fps the stream is at 49
My monitor's at 144Hz
If I lock the game with the ingame toggle to 120 the stream drops to ~36fps
at 69fps it's at 20fps
at 40 it's at 4-5fps
Which is mostly the behaviour we see from not moving the cursor
Later i'll test if having a different refresh rate alters this is any way
THe GPU clock are hard set, they're not a factor at play here
Can anyone with this issue test something similar
hybrid fjord
Why we then can't reproduce this issue in Firefox?)
hybrid fjord
When I choose window -> I have only updates fps
When I choose display -> 60 fps when mouse not moving and 45-50 when moving mouse
Take a look
https://issues.chromium.org/issues/333945842
hybrid fjord
Take a look
https://issues.chromium.org/issues/333945842
Actually I believe that demo, provided here, works like discord streaming
I even saw how to get properties that we see in debug menu
azure verge
interesting
azure verge
Like, instantly goes from 5-10 to 45-50
when I played doom eternal
it was locked at 59-60
upper pine
Can we test something?
do you need someone to test with?
upper pine
Sure
hybrid fjord
Do we want to add "Try to fix 4696 bitrate cap" to tasklist before merging?
azure verge
I'm not sure
also
should we mention the open issues in the pr so people can forward that they're also experiencing them to maybe push development a bit
simple groveBOT
Describe the bug
Venmic fails to start despite me running pipewire
To Reproduce
Go to a voice channel
Open the screenshare menu
Expected behavior
Screenaudio working as normal
Screenshots
Desktop (please complete the following information):
- OS/Distro: Void Linux
- Desktop Environment: Sway
Command line output
...
hybrid fjord
😦
hybrid fjord
[error] could not create core or registry
Maybe it's a pipewire's issue?
upper pine
Sounds like it
azure verge
they gave no information in that issue I am so confused as to what they want
are they running vesktop in gamescope???????
simple groveBOT
hybrid fjord
are they running vesktop in gamescope???????
I don't really know.
I think it may be for some like SteamDeck systems where maybe whole compositor is gamescope or something like that. Probably on that systems there are no portal picker (??)
hybrid fjord
I don't really know.
I think it may be for some like SteamDeck systems where may...
Okay in any case I think that for fixing this issue we must create another PR for not making 95% of users wait for some GameScope specific bug fixing.
upper pine
Okay in any case I think that for fixing this issue we must create another PR fo...
Yeah I'd do them separately
azure verge
Okay in any case I think that for fixing this issue we must create another PR fo...
ofc
I'm not including it in 488
489*
I'm just trying to get info
azure verge
Yeah I'd do them separately
has v merged yours
hybrid fjord
Yeap, I would like to try some things for fixing it
I need just understand what he wants 😅
hybrid fjord
has v merged yours
Not yet 😦
azure verge
gimme like 20m to fix lmao
broken solstice
@azure verge @hybrid fjord I tested some stuff with @upper pine and it seems that the further apart the framerate of the fastest updating client is from the monitor's refresh rate the worse the stream runs.
So, opening vkcube and having a tiny section of it on screen prompts the framerate to be stable and close to target. This also explains what we were seeing with the secondary monitor as, because it has a lower refresh rate, it needs a lower framerate to not be horrible.
This is one heck of a bug
I could also reproduce that moving the cursor WORSENS framerate in some cases
Which is what I've seen on KDE
also @upper pine's stream flickers just like yours even on Nvidia Wayland so it's probably a synchronization issue that's not driver dependent
azure verge
<@306158896630988801> <@242305263313485825> I tested some stuff with <@349609234...
add this to the open chromium issue made by @hybrid fjord
hybrid fjord
I believe that's all is a upstream issues
broken solstice
I agree with you
broken solstice
Yeah
broken solstice
There's a chance it's lower level than chromium but eh
broken solstice
I'm trying to get gstreamer1.24 on 40
azure verge
to report and fix
azure verge
I'm trying to get gstreamer1.24 on 40
how know what version on
broken solstice
you're on Arch, mostly likely 1.24.2 which is the latest
azure verge
id assume
broken solstice
I'm on 22.9 which is basically 23
broken solstice
@upper pine is
azure verge
broken solstice
I'm installing 1.24.0
It's taking quite a bit, partially overridden, partially installed
Silverblue moment
AHAH
azure verge
gl
broken solstice
gstreamer1 1.22.9-1.fc40 -> 1.24.0-1.fc41
gstreamer1-plugin-libav 1.22.9-1.fc40 -> 1.24.0-1.fc41
gstreamer1-plugins-bad-free 1.22.9-3.fc40 -> 1.24.0-2.fc41
gstreamer1-plugins-bad-free-extras 1.22.9-3.fc40 -> 1.24.0-2.fc41
gstreamer1-plugins-bad-free-libs 1.22.9-3.fc40 -> 1.24.0-2.fc41
gstreamer1-plugins-base 1.22.9-1.fc40 -> 1.24.0-1.fc41
gstreamer1-plugins-good 1.22.9-3.fc40 -> 1.24.0-2.fc41
gstreamer1-plugins-good-qt 1.22.9-3.fc40 -> 1.24.0-2.fc41
gstreamer1-plugins-ugly 1:1.22.9-2.fc40 -> 1:1.24.0-1.fc41
gstreamer1-plugins-ugly-free 1.22.9-1.fc40 -> 1.24.0-1.fc41
gstreamer1-vaapi 1.22.9-1.fc40 -> 1.24.0-1.fc41
Removed:
faad2-libs-1:2.11.1-2.fc40.x86_64
gstreamer1-plugins-bad-freeworld-1:1.22.9-3.fc40.x86_64
libde265-1.0.15-2.fc40.x86_64
libkate-0.4.1-29.fc40.x86_64
librtmp-2.4-24.20210219.gitf1b83c1.fc40.x86_64
mjpegtools-libs-2.2.1-5.fc40.x86_64
svt-hevc-libs-1.5.1-6.fc40.x86_64
Just in case 🙂
I couldn't find freeworld
hybrid fjord
About this issue
Is there ang way in electron to check user inputs even on unfocused window?
But it's looks like critical security issue 😄
hybrid fjord
But it's looks like critical security issue 😄
I mean if app can log any keys unfocused it's kinda dangerously
azure verge
About this issue
Is there ang way in electron to check user inputs even on unfoc...
not on wayland
afaik
hybrid fjord
Ohh
hybrid fjord
Okay, but at least for x11 we can potentially realize this feature
Just checking all inputs and comparing to binds table
simple groveBOT
Venmic works on the appimage, maybe it's an issue with the flatpak?
Interesting, maybe some sort of permission issue? Have you allowed access to the host audio system to the Flatpak? (Should happen automatically unless tampered with through flat-seal or similar)
vernal lintel
I mean if app can log any keys unfocused it's kinda dangerously
welcome to windows, mac & x11
you can't on wayland
on wayland u need to use the portal
hybrid fjord
GlobalShortcut portal looks kinda attractive
azure verge
welcome to windows, mac & x11
the world of insecurity
keyloggers my beloved
took us like 30 years of computing to say "we shouldn't give apps keyread permission by default"
vernal lintel
i mean the general assumption is that apps you run on your system are trusted
azure verge
i mean yeah but the system should still protect you
it should protect you but allow you to disable those protections
upper pine
Who maintains the Flatpak?
azure verge
im gonna go out on a limb and say @sly cairn
upper pine
@sly cairn do have some idea what could be the cause here?
@mossy torrent didn't we have similar issues with the soundux flatpak
simple groveBOT
sly cairn
<@96269247411400704> do have some idea what could be the cause here?
would not have a clue
it seems to work for everyone else
hybrid fjord
In discord native windows client there for non nitro accounts in p2p call I have bitrate target of 4000 for streaming
And I can't get more than 4100 actual bitrate
So I believe that non nitro accounts are restricted to 4k on backend
hybrid fjord
found out that latency on video depends on quality (how surprisingly, right?) so i believe w/o changing encoder we can't decrease latency
i will try to search whether there are ways to decrease latency for voice
hybrid fjord
okay any ideas how we can reproduce it in default systems?
anyway how we must send pipewire output instead of portal one's if electron want portal output..
azure verge
i have no idea
hybrid fjord
maybe we can create stream object from pipewire output sobehow?
azure verge
hence why im leaving it out of this pr
hybrid fjord
hardest thing will be to test it
azure verge
i could probably install gamescope on my switch or some shit
hybrid fjord
and vesktop?
azure verge
yeah
the main thing i wanna fix rn
is the 4696 cap
i have nitro
and im still locked
i cant hold 1080p60
azure verge
unless nitro basic has a lower cap
azure verge
how exactly you reproduce it?
start streaming
the moment someone starts watching
the target drops to 4696
@upper pine uhm
sometimes when i screenshare some apps
all audio quality in call turns robotic
is that normal pipewire shit
upper pine
all audio quality in call turns robotic
Wot
I've never experienced anything remotely similar xd
azure verge
maybe my pipewire config is brokey?
azure verge
it depends on the game
upper pine
But then it's also a pipewire issue
upper pine
it depends on the game
Wait can you actually reprod somewhat decently
upper pine
doom eternal is a big culprit
I have that
azure verge
Wait can you actually reprod somewhat decently
every time
upper pine
I'll see if I can reprod to tomorrow
azure verge
oki
upper pine
Or for yourself?
hybrid fjord
it looks like small latency issue
upper pine
Ah
azure verge
everything else is fine
upper pine
Alr
azure verge
gl
upper pine
is this right
Dunno but looks right
azure verge
oki
upper pine
*all vesktop audio
But that's also really interesting because I don't touch the vesktop audio at all
hybrid fjord
it looks like small latency issue
we can receive robotic sound when applying very small latency on pulseaudio and when applications actually needs more latency
dunno how to properly say it
azure verge
But that's also really interesting because I don't touch the vesktop audio at al...
only happens when screensharing the app
not the screen
what the fuck
azure verge
we can receive robotic sound when applying very small latency on pulseaudio and ...
do you know how to fix
upper pine
In case I can reprod I wouldn't know what could fix it tho xd
azure verge
lmao
upper pine
But we'll see
upper pine
Maybe I get some crazy idea
upper pine
Ok
hybrid fjord
do you know how to fix
just to set higher latency
upper pine
So
Exact steps to reprod
Are
- Open Doom Eternal
- start windowed stream
Whole desktop audio or only doom?
azure verge
start stream with doom eternal window and with game audio on
content hint set to motion
and im using 1080p60
upper pine
Whole desktop audio or only doom?
^
azure verge
game only
upper pine
Ok, noted :D Thanks
upper pine
we literally cant stream 1080p60
Is 1080p normally nitro only?
azure verge
mhm
upper pine
<@242305263313485825> 720p60 uses 9800kbps
Does that also happen in a minimal reprod example or only in discord?
azure verge
not sure
azure verge
try
odd
im streaming 1440p 30 rn
and barely hitting 1000kbps
even at full 30fps
azure verge
that's a thing we worked on and implemented a while ago lol
upper pine
Alright, sorry I'm not too up-to-date 😅
hybrid fjord
It's actually like new feature for us ^^
upper pine
https://www.w3.org/TR/mst-content-hint/#behavior-of-an-rtcpeerconnection
But this is not about the content hint
hybrid fjord
added bitrate showing, but it's kinda strange
azure verge
osadjlfkshjldakf
upper pine
hybrid fjord
hm
azure verge
But this is not about the content hint
degredationpreference is deprecated
azure verge
look at the mdn page
upper pine
Oh xd
azure verge
lol
upper pine
Have you tried using it anyway?
Is it deprecated long enough that it's actually deprecated in the current chrome build of electron?
upper pine
Yeah absolutely
azure verge
it would be a pain if it came back later and caused more issues
upper pine
Just for testing
hybrid fjord
at least our current configuration of contentHint are working so maybe it be better to not touch it
hybrid fjord
can anyone retest starting stream when watching another stream? T_T
upper pine
We did that a few hours back and it would load indefinitely
upper pine
motion is basically maintain-framerate
Just making sure, does maintain-framerate also exist in electrons chrome version yet?
hybrid fjord
why we fixing bugs and they are just coming back
upper pine
why we fixing bugs and they are just coming back
They are getting stronger 😨
hybrid fjord
like us
broken solstice
We did that a few hours back and it would load indefinitely
can confirm
We're just hard to kill bugs AHAH
Well, nonetheless, on GStreamer 1.24 I can't see any significant difference compared to 23
hybrid fjord
wait stop
did we even fixed starting stream when watching another stream? Or we just decided that discord must fix it
bc i remember that i can reproduce this bug in default discord
newly created conn.input.stream is undefined when watching another stream, so we can't do anything here
broken solstice
I have to yet add my custom pipewire
hybrid fjord
Oh, and about gamescope
I have this issue😂
https://github.com/ValveSoftware/gamescope/issues/1200
hybrid fjord
I have idea about UX here
Can we change text to something like "Choosing "Prefer Smoothness" will result a higher framerate in exchange for a image quality" when user picker prefer smoothness and change text to clarity when user picks clarity?
Like this about section will tell to user what exactly he picked
azure verge
@vernal lintel the sooner you merge venmic 3.3.4, the sooner ill be able to finish #489 lmao
simple groveBOT
simple groveBOT
runic inlet
hey don't ageshame
ageshame images 💀
simple groveBOT
azure verge
<:caturtle:1227001386969858088>
simple groveBOT
upper pine
@azure verge I just noticed I dont have Doom Eternal but only Doom 2016
Do you reckon that will still reprod?
azure verge
I'm not sure
upper pine
the crack has 13 parts holy fuck
I'll see if one of my friends has it
ok got it
downloading rn
azure verge
btw do we have a timeline on when #499 will be merged?
azure verge
downloading rn
gl
upper pine
btw do we have a timeline on when #499 will be merged?
you have to sacrifice 10 sheep and we will look at it instantly
azure verge
LMAO
broken solstice
I guess that works 🙂
azure verge
<@306158896630988801> now sacrifice 20 sheep and tag vee each time
is this a dare
upper pine
<@306158896630988801> now sacrifice 20 sheep and tag vee each time
speedrun get banned any%
upper pine
is this a dare
if you want it to :P
broken solstice
Btw @azure verge I discovered that the screenshare issue only happens with dual monitors.
(Also that VRR only works with one and glitches like hell even then :)) )))) ) )
azure verge
Btw <@306158896630988801> I discovered that the screenshare issue only happens w...
odd
azure verge
if you want it to :P
nah i wont lmao
upper pine
hahah
azure verge
th e r e
upper pine
same
runic inlet
why is this channel literally only screenshare issues/bugfixes??? 💀
upper pine
why is this channel literally only screenshare issues/bugfixes??? 💀
because that's the hot shit right now
azure verge
no other development is really being talked about lmao
upper pine
we can also talk about
broken solstice
we can also talk about
stream?