it works great
#🖥-vesktop-development
azure verge
interesting
ill retest later
hmm
I streamed for a few hours the other day
it was fine
the only annoying part was my stream couldn't fold 60fps because of 4696 bitrate cap
hybrid fjord
okay, lmk
bc at night when i was trying to fix starting stream i did some changes in conn finding, maybe this fixed some problems
hybrid fjord
something like that
just ignore setTimout things at the end, it is tries to fix stream
hybrid fjord
yeah, i believe there must be better way xd
azure verge
const conn = connections.find(conn => conn.streamUserId === UserStore.getCurrentUser().id)
hybrid fjord
``const conn = connections.find(conn => conn.streamUserId === UserStore.getCurre...
okay, this works for me as well
i still can't reproduce that bug
hybrid fjord
i started stream 1080p60 -> got it
Changed to 480p15 -> got it
changed back to 1080->60 got it
azure verge
interesting
hybrid fjord
``const conn = connections.find(conn => conn.streamUserId === UserStore.getCurre...
and i think we must let this conn finding code, because just getting [1] looks unstable
azure verge
yeah definitely
getting [1] doesn't work if another stream is running
if I can fix input.stream to stop being undefined
it'll be great
hybrid fjord
now nothing work because of discord bug 😄
azure verge
lmao
hybrid fjord
if I can fix input.stream to stop being undefined
if we can get somehow stream object from electron picker then we can just assign it
azure verge
true
hybrid fjord
or we need more investigation, maybe discord do have somewhere stream
azure verge
I'll test more when i get home
while I'm at school I'm gonna work on the modal css and another vencord project
simple groveBOT
hybrid fjord
I have an idea of temporarily workaround about this dc bug. We can after 1 second find new connection, call again getDisplayMedia function for getting stream object and assign it to connection. I tried it but without success. Looks like we need to change something else too and/or call some functions
But this approach will again call system display picker :c
real glade
yeah it is
azure verge
omfg
azure verge
fakenitor
hybrid fjord
xd
azure verge
I really wanna get in vc, say I found the plugin, and stream at 30fps
and see the reaction
hybrid fjord
xD
azure verge
LMAO
azure verge
it's still locked at 59 LMAO
hybrid fjord
yeap
azure verge
wtf is the bitrate though
I'm going to bump the bitrate limit up later to test like
1440p144
simple groveBOT
I applied 120 fps at Track settings, and we still are hardcapped to 60 fps, even when sometimes we reach for moment >60 fps
Also, we have strange bitrate behavior.
hybrid fjord
we need 4k display for it 😦
hybrid fjord
we can emulate it i think
azure verge
I have a 4k tv but it's not near my pc
hybrid fjord
creat virtual 4k display somehow, in x11 we 100% can do it
i believe in wayland there must be a way to do it too
runic inlet
I really wanna get in vc, say I found the plugin, and stream at 30fps
my pc will prob die, but it was def more than 60 FPS
iron cedar
it would be
azure verge
interesting
hybrid fjord
1 year old
I believe discord changed many things by this time and fixed this
runic inlet
do desktop plugins work in vesktop too?
hallow trail
Gave the setup a go last night
Mouse movement in the discord window or the captured window would bring the stream framerate to it's knees
On KDE plasma 6
But so long as the mouse did not move it was quite heavenly
Which was surprisingly not so much of a problem streaming VRChat on monado in HMD
simple groveBOT
azure verge
But so long as the mouse did not move it was quite heavenly
interesting
broken solstice
Well I'm back
broken solstice
But so long as the mouse did not move it was quite heavenly
I have the exact opposite issue
azure verge
i forgot to commit stuff i did last night
broken solstice
on Gnome 46 Nvidia
azure verge
i forgot to commit stuff i did last night
i cant work on it on my laptop 😭
welp guess ill just do my vencord plugin instead
hybrid fjord
wow
hybrid fjord
https://raw.githubusercontent.com/refact0r/midnight-discord/master/flavors/midnight-vencord.theme.css
For raw including in themes
azure verge
mhm
anywayssss
hm
welp guess its time to figure out how to do volume stuff
vencord patches yayyy
hallow trail
Godspeed, I am immeasurably happy I can stream vr to everyone in chat even if its a little funny right now 🥰
hallow trail
I have the exact opposite issue
Tried windowed mode instead of fullscreen?
broken solstice
Tried windowed mode instead of fullscreen?
Streaming the monitor will result in updates only when the cursor plane updates for some reason
oddly enough, the secondary monitor seems unaffected
Even more oddly, rn the stream is simply broken
AAND
I'm back on 40 and can reset my custom Pipewire because there are conflicts that had to pop up rn
AHAHAH
azure verge
Godspeed, I am immeasurably happy I can stream vr to everyone in chat even if it...
:D
azure verge
I'm back on 40 and can reset my custom Pipewire because there are conflicts that...
whar
hallow trail
iirc there's a book to include the mouse cursor in the pipewire api
Might be worth testing with/ without it
azure verge
do lmk if you find anything
i cant test rn and yall cant test on the latest update because i forgot to push my commits
😭
i fixed a lot of issues
hallow trail
Ooh, wen push?
azure verge
the 2 biggest problems imo are the weird 4696 bitrate cap and the uh
conn.input.stream being undefined
hallow trail
All good I'm outta work in 5h
Learned me well, always have the pub key ssh box on the home net, always
broken solstice
OKAY... looks like I can rebase from testing to stable just fine
So i'll do that 🙂
hybrid fjord
welp guess its time to figure out how to do volume stuff
i saw something related to volume on conn object
outputVolume: 100
let me test it xd
vernal lintel
hybrid fjord
hm
broken solstice
Huh
broken even with stock stuff
Well, funnily enough it looks like Rawhide is the only stable ground I have
broken solstice
doesn't work even in Rawhide now?
Okay
i was using Canary
Okay
So, Stream's broken on Canary, not stable. Good
and bad
huh, the bug is gone
Interesting, prepare for when the current canary merges into stable, I guess
azure verge
what about it doesnt work on canary
broken solstice
what about it doesnt work on canary
The screen stream bug is only present in Canary
Not in stable, as of my testing
broken solstice
Huh, interestingly enough, I did some more testing.
So, stream is totally broken for me on anything but Rawhide it seems... probably GStreamer 1.24 related.
Okayyy... now it's broken in Rawhide too?
Well, let's just say it's EXTREMELY inconsistent
azure verge
oh my
broken solstice
oh my
Are you back?
To push the stuff you didn?
at Function.assign (<anonymous>)
at Object.patchStreamQuality (VCDRenderer:1:5071)
at new o (WebpackModule701597:2:908)
at u.getDesktopQuality (WebpackModule701597:2:3583)
at u.getQuality (WebpackModule701597:2:1683)
at f.initializeStreamParameters (65573.bdec86a….js:1:7139992)
at new h (65573.bdec86a….js:1:7261261)
at new f (65573.bdec86a….js:1:7302145)
at h (65573.bdec86a….js:1:7265458)
at C.connect (65573.bdec86a….js:1:7315059)```Looks like some of the parameters for patchStreamQuality are undefined in some cases
I'd like to print them to test, but I can't build as Rawhide has broken containers
Time to reboot
broken solstice
getting food rn
Nice
broken solstice
There is a chance this issue trickled down from canary btw
heady merlin
only merge when dev gets merged to main
perhaps I should make the change on vencord non breaking, you will me vee
hybrid fjord
you know what xD
latest commit broke stream starting for me
even when no one else streaming
azure verge
even when no one else streaming
damn
same thing here
ughhhh
okay that's gonna take more work
hybrid fjord
i believe these if statements we can write simply as "if (conn)"
bc conn object will be only when ids same
azure verge
true
yeah
it can
i wrote this while i was basically falling asleep
im not gonna be super active development tonight
im fixing a chromebook
hybrid fjord
i'll try to fix this problem and will commit if i find solution
or i do not have write access..
anyway i will let you know
hybrid fjord
i cant start watching stream too
looks like it tries to patch stream quality for not our stream
broken solstice
latest commit broke stream starting for me
Not just the latest, probably a discord change trickled down from Canary
It broke on Canary, worked on stable, now not even there, at least for me
hybrid fjord
i pushed fix xD, pull it
azure verge
ill be spending tonight fixing a chromebook and then experimenting with linux on it if i get it working
oki LMAO
i think itll be way better with all of us able to push and pull
hybrid fjord
fps and res setting not even broke after it
azure verge
nice
hybrid fjord
but changing window broke..
azure verge
but changing window broke..
changing windows works for me
idk about changing windows + res
hybrid fjord
for me it setups back to fullhd 30 fps
hybrid fjord
hm
hybrid fjord
wtf is that when i change window
azure verge
why did you comment it
hybrid fjord
bc it drops error while starting stream or watching
because encode is undefined now in some reason
ionic gust
no null checking
hybrid fjord
but changing window broke..
fixed it
by this
we submit only when there are no connection for stream already
okay it looks for me good now
hybrid fjord
here we have ressurection of github api
ionic gust
cant mark your own reviews as resolved
shithub at its finest
theres so many features that just arent there that really should be
hybrid fjord
i just commented it(
broken solstice
Funny thing btw
ionic gust
and i doubt you can as well cause you're not the pr author
broken solstice
It works now, but the cursor bug is back
ionic gust
It works now, but the cursor bug is back
then its probably a deeper webrtc issue we have no control over?
broken solstice
I'll test Rawhide ONE LAST TIME
hybrid fjord
about commenting i agree, your approach is better for future discord changes
broken solstice
then its probably a deeper webrtc issue we have no control over?
I think it has to do with Pipewire or GStreamer
ionic gust
gstreamer then
broken solstice
When using Rawhide it was perfect. the major difference was GStreamer 1.24
ionic gust
pipewire is purely audio and is not relevant
hybrid fjord
Pipewire have Gstreamer plugin
i believe in future video support will be more extended
ionic gust
When using Rawhide it was perfect. the major difference was GStreamer 1.24
what version has the cursor issue then
if its older then oh well, welcome to stable release distros
if its newer then its a regression
broken solstice
what version has the cursor issue then
I think GStreamer 1.23
ionic gust
so its already fixed, no use caring
broken solstice
Yeah but now it's back
azure verge
and i doubt you can as well cause you're not the pr author
can i give access
ionic gust
can i give access
probably not, its just a missing feature within github
broken solstice
I can't find a consistent reproducer for the working scenario
The only conclusive thing is that the secondary monitor doesn't present this issue
azure verge
gsync?
azure verge
i have major issues with freesync
i had to turn it off
it makes my monitor flicker
(implicit sync kinda vibes)
hybrid fjord
can we add #191 and #463 here? screenshot from our PR
humble mortar
it works great
ah its the decoding thats broken it seems
broken solstice
it makes my monitor flicker
Doesn't happen for me
humble mortar
encode works
broken solstice
Btw, streaming the window is still much more performant than monitor, even mouse issues aside...
I wonder if you can reproduce this
hybrid fjord
can we add #191 and #463 here? screenshot from our PR
also this is fixed now, i believe
broken solstice
It's probably just the window vs monitor issue that @hybrid fjord opened yesterday
Any news on that btw?
hybrid fjord
only added labels xD
looks like they added this to project, so i have hope that they will fix it
broken solstice
Welp
No one can reproduce this issue yet, right?
We only have the inverse, on KDE
hybrid fjord
can you again write what exactly issue is?
broken solstice
So, sharing a window works very well, sharing a monitor works but with a much lower framerate; Sharing the primary monitor, on GNOME 46 (Nvidia Wayland) leads to an avg fps or 4-5 with drops to 1 UNLESS the cursor is moving.
We theorised that it was due to Window/Monitor not being set properly by chromium, for which we opened a bug
hybrid fjord
oh, these one
broken solstice
Yep
broken solstice
I wonder if you have the framerate drop compared to window streaming in your setup as well
Like, from 60 locked to 40-45hish
That's what I've been seeying
hybrid fjord
I wonder if you have the framerate drop compared to window streaming in your set...
i believe no
it is display streaming
broken solstice
Let me try something
hybrid fjord
in final commits we need to do not forget to remove all these console.logs
broken solstice
Huh
Looks like even the window screen sharing is very bad now... the hell
rarely crashes on starting a new stream with ```terminate called after throwing an instance of 'std::future_error'
what(): std::future_error: Promise already satisfied
c++
broken solstice
Yeah, strange stuff
Well, I'm going back to 40
and cleaning up Rawhide
it's broken on both, mostly in a similar manner by the looks of it
I will try to test the differnece between app and screen streaming even while moving the cursor soon
hybrid fjord
can you try to install kde?
hybrid fjord
lol
hybrid fjord
Screen While Moving the Cursor
i can reproduce this
broken solstice
i can reproduce this
Slight drop?
hybrid fjord
yeap
broken solstice
Okay
hybrid fjord
it might be encoder issue or smth like that
broken solstice
Which is why I'm somewhat tempted to build GStreamer 1.24.2 before Fedora
that + custom pipewire with explicit modifiers
broken solstice
Wait are you guys talking about this issue
Yes, but specifically with the currently open MR
Basically window streaming is much better than screen
And I have a bug where not moving the cursor while streaming the screen tanks the framerate significatnly
seems to be multimonitor related
I'll now test my secondary monitor
hybrid fjord
but we are not using anything that can do this frame drops
broken solstice
Also there is some work to make use of explicit sync for Pipewire screen sharing
Interesting stuff
Let me test the secondary monitor
hybrid fjord
For window streaming i have the same fps drops when mouse moving
broken solstice
I don't have drops when the mouse moves
hybrid fjord
and you do have updates only when mouse moves
broken solstice
Window is mostly perfect for me
Yep
Looks like on KDE it's the literal inverse
hybrid fjord
i have same behavior like screen sharing
i do not think that we in vesktop code can and must do anything to fix this
broken solstice
Yeah, I agree
We definitely improved what we could but this all looks like upstream issues
The problem is that I would have to prove they are upstream
Test this
I think i can reproduce it
Btw, when the stream framerate increases due to mouse movement the underlaying primary plane doesn't update
I.e. it still gets dropped
Window is perfect
hybrid fjord
For window streaming i have the same fps drops when mouse moving
nvm, looks like i accidentally picked screen instead of window. In window streaming when i move mouse i do not have drops
like this
broken solstice
AHAHAH
OBS seems fine but direct scanout in fullscreen seems to cause it to drop some frames
hybrid fjord
Screen to window changing seems broken
azure verge
Screen to window changing seems broken
i didnt check res or fps but it works for me
broken solstice
jokes aside, other than reporting, the only real thing I can do rn is to find a way to record Wine Wayland windows AHAHAH
To sidestep the real issue just a bit
hybrid fjord
Start Stream display -> change stream to window -> not changing with any permutations
start stream window -> change stream to display without changing res and fps -> not changing
start stream window -> change stream to display with another settings -> changing
this is for me
can anyone recheck?
azure verge
it did 1440p30
i chose 720p60
i didnt check fps and res on the first 2
just the last one
still trying to solder
hybrid fjord
i just checked whether stream is changing image
azure verge
it did all 3 times for me
res and fps didnt work well though
btw nobody was watching me
azure verge
wtf lmao
hybrid fjord
propably smth on my end
hybrid fjord
Start Stream display -> change stream to window -> not changing with any permuta...
last one changes stream from window to display and it is 60 fps, so not dropped to default screen res and 30 fps
azure verge
hmm
oh
odd
im not on the latest commit
its a regression
this should always submit
hybrid fjord
okay
azure verge
the code after handles reapplying so that it doesnt matter if the track is changed
i really should comment what i do
itd be better to put the entire block in this try in if conn
instead of just the latter
hybrid fjord
how then it changed if i change settings
hybrid fjord
oh
when we submit then it applies default res and 30 fps
but submitting only when there is no connection (starting stream) i fixed problem when reverting to 30 fps
but this changing window problem added
what if we after submitting just wait in code for like 100 msecs and then apply new constraints?
bc it looks like we apply but then discord applies default ones back
i will try
humble mortar
Im getting infinite loading on the latest commit of #489
Xwayland
the screen capture portal seems to remane open even after i end the stream
and if i exit the portal the stream remains open
theyre not hooking correctly or smth?
hybrid fjord
i had strange behavior that screen capture portal opens again even if we already chose desktop
But for now i just ignore it as we trying to fix streaming
humble mortar
hm well streaming isnt even starting for me
hybrid fjord
i will reclone repo and retest it
hybrid fjord
what if we after submitting just wait in code for like 100 msecs and then apply ...
@azure verge it worked for me but i do believe there must be better way to do this. What do you think about this approach?
humble mortar
@hybrid fjord is your stream working on your end?
humble mortar
i think theres something scuffed on my system
I'm getting near constant system freezes
mouse still works and apps still work but anything that requires loading just freezes
what tf is happening
screenshots are just blank
hybrid fjord
@broken solstice when i start stream display -> change to window then i do have the same behavior with fps as you.
hybrid fjord
what if we after submitting just wait in code for like 100 msecs and then apply ...
@azure verge with this approach i get working stream->window and vise-versa changings with setted settings fixed, including 60 fps. Do you think there is better way to do this? Or i can commit it?
azure verge
its not perfect but the main thing rn imo is making something work
hybrid fjord
okay i'll do some more tests and will commit it
pushed, so if can anyone pull and test it, it will be great
and i believe we can check it finally:
"Fix bug where changing windows allows you to lower the fps but not raise it"
as for now we also have issue when we can't start stream while viewing someone else's stream. But it is also reproducing in discord web, so i believe discord's devs will fix it soon
ionic gust
are you sure submit isnt async?
ionic gust
actually it should be
hybrid fjord
submit maybe, but it seems that discord still doing something with track. I do not really sure whether it is while submit works or after
ionic gust
yes but its async
hybrid fjord
i will try make this better, but for now it just works for me
hybrid fjord
yeap yeap
okay, i tried to use then but discord makes stream 30 fps
so its most propably doing it after then()
ionic gust
how the actual fuck does this even work if submit is just a call to venmic and not to actually start screensharing what
azure verge
submit calls VENMIC?????
ionic gust
sour muralBOT
https://github.com/Vencord/Vesktop/blob/main/src/renderer/components/ScreenShare...
**ScreenSharePicker.tsx: **Lines 107-117
submit={async v => {
didSubmit = true;
if (v.audioSource && v.audioSource !== "None") {
if (v.audioSource === "Entire System") {
await VesktopNative.virtmic.startSystem(v.workaround);
} else {
await VesktopNative.virtmic.start([v.audioSource], v.workaround);
}
}
resolve(v);
}}
I THOUGHT IT WAS A CALLBACK TO THE SCREENSHAREHANDLER FUNCTION
ionic gust
so did i
azure verge
i wrote half this file lmao
ionic gust
time to see if theres a flux event then
azure verge
gl
ionic gust
time to see if theres a flux event then
STREAM_START
azure verge
STREAM_START
whats a flux event
hybrid fjord
So in theory we can just apply constraints after flux event done? I do not know how to work with them
upper pine
@humble mortar In case it is the issue I was suspecting, it should be fixed with v3.3.4, if not, I'd like to debug this further (would probably require input from you as I can't reprod)
humble mortar
<@721853658941227088> In case it is the issue I was suspecting, it should be fix...
yeah im up for it
humble mortar
Im getting infinite loading on the latest commit of #489
journal
Apr 10 19:40:07 bakery rtkit-daemon[982]: Supervising 7 threads of 5 processes of 1 users.
Apr 10 19:40:07 bakery rtkit-daemon[982]: Supervising 7 threads of 5 processes of 1 users.
Apr 10 19:40:11 bakery rtkit-daemon[982]: Supervising 7 threads of 5 processes of 1 users.
Apr 10 19:40:11 bakery rtkit-daemon[982]: Supervising 7 threads of 5 processes of 1 users.
Apr 10 19:40:28 bakery kded6[1308]: Registering ":1.89/StatusNotifierItem" to system tray
Apr 10 19:40:28 bakery xdg-desktop-portal-kde[1424]: qt.qml.typeresolution.cycle: Cyclic dependency detected between "qrc:/qt/qml/org/kde/desktop/private/TextFieldContextMenu.qml" and "qrc:/qt/qml/org/kde/desktop/MenuItem.qml"
Apr 10 19:40:36 bakery kded6[1308]: Service ":1.89" unregistered
Apr 10 19:40:43 bakery kded6[1308]: Registering ":1.91/StatusNotifierItem" to system tray
Apr 10 19:40:43 bakery kded6[1308]: Service ":1.91" unregistered
Apr 10 19:40:43 bakery kded6[1308]: Registering ":1.93/StatusNotifierItem" to system tray
Apr 10 19:40:59 bakery kded6[1308]: Service ":1.93" unregistered
Apr 10 19:40:59 bakery wireplumber[1177]: <WpAsyncEventHook:0x5999f423d780> failed: <WpSiStandardLink:0x5999f45c7770> link failed: 1 of 1 PipeWire links failed to activate```something is broken
let me try the latest stable of vesktop
latest stable works
ill try latest git build without the patches from #489
humble mortar
latest git works
let me try #489 one more time
and now it works
my system is haunted
azure verge
oop
azure verge
this doesnt
update
hmm
im streaming at 480p15 rn but i started the stream at 1080p60
omg so close to merge checklist completion
azure verge
btw
if anything breaks on xorg only
we could pull this into the renderer process
and use it to define 2 sets of behavior
azure verge
@vernal lintel not styled yet but i think this is an improvement
and then ill make content type a dropdown
azure verge
getting better
hot juniper
**ScreenSharePicker.tsx: **Lines 107-117
```tsx
submit={async v => {
didSubm...
this looks like type gore
azure verge
well anyways i made a little animation and im proud of it
azure verge
<:SKULL_SKELETON:1133504974777757726> <:SKULL_SKELETON:1133504974777757726> <:SK...
i dont do frontend
hot juniper
well anyways i made a little animation and im proud of it
that looks sick
azure verge
that looks sick
hot juniper
i dont do frontend
look in src/webpack/common/components.ts
azure verge
noted
azure verge
look in src/webpack/common/components.ts
classic vesktop L
azure verge
im not gonna go digging around in vencord source code rn
hot juniper
for vencord
azure verge
yeah i mean itll still work here too lol
hot juniper
yeah ofc
azure verge
i just dont wanna dig for it
hot juniper
sour muralBOT
https://github.com/Vendicated/Vencord/blob/main/src/webpack/common/components.ts...
**components.ts: **Lines 25-50
export let Forms = {} as {
FormTitle: t.FormTitle,
FormSection: t.FormSection,
FormDivider: t.FormDivider,
FormText: t.FormText,
};
export let Card: t.Card;
export let Button: t.Button;
export let Switch: t.Switch;
export let Tooltip: t.Tooltip;
export let TextInput: t.TextInput;
export let TextArea: t.TextArea;
export let Text: t.Text;
export let Select: t.Select;
export let SearchableSelect: t.SearchableSelect;
export let Slider: t.Slider;
export let ButtonLooks: t.ButtonLooks;
export let Popout: t.Popout;
export let Dialog: t.Dialog;
export let TabBar: any;
export let Paginator: t.Paginator;
export let ScrollerThin: t.ScrollerThin;
export let Clickable: t.Clickable;
export let Avatar: t.Avatar;
export let FocusLock: t.FocusLock;
vernal lintel
well anyways i made a little animation and im proud of it
sorry but why not just use a tooltip
seems way better imo
when you hover it shows the preview in tooltip
upper pine
yeah im up for it
Can you still reproduce the issue with Venmic 3.3.5? (You'll have to manually bump)
azure verge
when you hover it shows the preview in tooltip
okay that's fair
broken solstice
Huh, it's randomly working perfectly rn
Even the stream
Like, without the mouse issue
hybrid fjord
insteresting thing that i had mouse issue only when i changed stream to window
But if i start with window that it's okay
broken solstice
Interesting yeah
I'm trying to find reproduction steps btw
It works fine for now, somehow
broken solstice
I updated to the latest versoin and it regressed
huh
Or maybe I just got lucky again
But did I get lucky twice?
Because I tested the previous version multiple times
now it jumps between 50 and 5
huh
upper pine
Framerate edging lmao
azure verge
LMAO
azure verge
now it jumps between 50 and 5
odddddddd
hybrid fjord
Framerate edging lmao
that's graph how our development goes
azure verge
true
upper pine
hahahahahaha
upper pine
You're trying to fix the screenshare right?
upper pine
Is the screenshare issue a chromium one or is it actually discords code that's bad some where?
azure verge
discord mostly
originally it was because it was limited to 2.5mbps bitrate + contenthint = text
so resolution settings weren't applying
and it was 5fps
and it could barely hold that because of how low the bitrate was
that's all fixed mostly
broken solstice
OKAY
It works at commit 83d4164eacd79718ff97a7257ff0fead4cdf92e2
I'm going to move forward by one commit
Until it breaks
azure verge
okay
simple groveBOT
Describe the bug
when i uninstall vesktop the screenshare portal stays active on normal discord
To Reproduce
uninstall and screenshare still installed
Expected behavior
normal discord sharing window
Screenshots
Desktop (please complete the following information):
- OS/Distro: Linux
- Desktop Environment (linux only): kde
broken solstice
broken with commit 006f4e96dea21fee018e446e84a19a92ddabbd1e
Let me rollback and double check
azure verge
what changed
simple groveBOT
broken solstice
Yep, I've retested https://github.com/Vencord/Vesktop/commit/83d4164eacd79718ff97a7257ff0fead4cdf92e2 and it works
broken solstice
Although it does, when FULLSCREENED, rarely drop to 1 fps for a second
See the three central dips? those
broken solstice
Some logs from the working commit
65573.71e278ef7f5773eb2c7b.js:1 [UnifiedConnection(stream)] updateVideoQuality: {
"remoteSinkWantsPixelCount": 0,
"encodingVideoMinBitRate": 500000,
"encodingVideoMaxBitRate": 8000000,
"encodingVideoBitRate": 600000,
"streamParameters": [
{
"type": "video",
"active": true,
"rid": "100",
"ssrc": 3432307713,
"rtxSsrc": 3493598720,
"quality": 100,
"maxBitrate": 8000000,
"maxFrameRate": 60,
"maxResolution": {
"type": "fixed",
"width": 1920,
"height": 1080
}
}
]
}
65573.71e278ef7f5773eb2c7b.js:1 [UnifiedConnection(stream)] BaseWebRTCConnection.updateVideoQuality: resolutionScaleFactor: undefined, encodingVideoWidth: undefined, remoteSinkWantsMaxFramerate: undefined, encodingVideoMaxBitRate: 8000000, localWant: 100```I'll now check the broke one
azure verge
what code changed lol
broken solstice
I'm on my phone I cant dig through commits
So, it's Fixed setting stream settings while changing window
upper pine
@scarlet kestrel https://github.com/Vencord/venmic/issues/17 could you test this yet? Would like to see if the issue is resolved already and if not some debug logs would be greatly appreciated
broken solstice
broken solstice
I can see if the logs are any different on the broken commits to nail it further
I could test the individual code changes if you want
azure verge
I'll test with it in an hour or two too
azure verge
oki
hybrid fjord
did i broke something? 😄
azure verge
I didn't fully reread it all
but one thing I will note
make sure you have prettier and eslint active lol
the project has pretty strict styling rules
hybrid fjord
okay, sorry for this
broken solstice
Okay, testing out the Object.assign change
Okay, a couple of dips at the start, good otherwise
Even in fullscreen
Now i'll add the second change
broken solstice
Even screen is good for you?
hybrid fjord
strange thing that i have this with latest commit
it is screen streaming
window even better bc no mouse issue
broken solstice
huh
Now it's working just fine?
It's so inconsistent... maybe it's some race condition with some timeout? I have no idea
hybrid fjord
window, streaming browser which playing yt video
broken solstice
Let me retest latest
broken solstice
window, streaming browser which playing yt video
Yeah, window is still better but that's not related to us
hybrid fjord
yeap
broken solstice
last commit is working except for some drops at the start
hybrid fjord
and changing windows works and it applies settings
broken solstice
Well, I guess it might really be some sort of race
hybrid fjord
might help
azure verge
give it 1 second
see what happens
instead of 100ms
@broken solstice test that rq
hybrid fjord
1 sec just for test, in future i think we need to setup something like 200-500. We need to find proper number
broken solstice
One error that's quite consistent that sometimes seems correlated is a spotify integration error btw
simple groveBOT
broken solstice
Okay, testing without spotify integration real quic
Couple of drops but it stabilises
Okay, time to increase the timeout
upper pine
I hate clangd 😭
broken solstice
looks similar, at this point it might just be internet related tbh
Well, still, the only contentious points for me are probably just upstream
BUT, the UX is still not there imho
SHOW PREVIEW shouldn't be all caps and it doesn't have enough contrast between text and container. the container itself also doesn't use the correct color. What's the change button for?
Show Preview would be better
I'm trying to think about which color specifically as, abstrantion wise, it is meant to be a button
Hmmm
At this point wouldn't it be better to have something similar to the Microphone Workaround thing
Because it's still a toggle, not a button
That would also fix the contrast issue and be consistent
At the same time, i'm still unsure about having it at all but, I guess, if we have to have it might as well make it similar to the Microphone Workaround
simple groveBOT
Bumps tar from 6.2.0 to 6.2.1.
Commits
bef7b1e 6.2.1
fe8cd57 prevent extraction in excessively deep subfolders
fe7ebfd remove security.md
See full diff in compare view
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-secur...
azure verge
SHOW PREVIEW shouldn't be all caps and it doesn't have enough contrast between t...
its not done at all yet
lol
i havent had time to sit down and finish the css
im just making something functional
and the change button will cancel and reopen the portal so you can pick a new window
incase you misclicked and dont want to close it and reclick screenshare
hybrid fjord
fixed changing of discord quality description
but i will install eslint and prettier before committing
also i think then setTimeout() we need to set inside another if (conn) checkiing. Because otherwise it will try to set conn variables even if there are no conn
like this
okay i believe that i didn't broke anything
If someone could retest quality description changing when changing settings for already created stream it would be great
And also if someone have any recommendations to code it also be great
vast bane
Hi! I have an idea, I don't know where to post it. The idea is to maybe have a variable for OS is using a dark or a light theme OR even better, an option to apply a chosen light color when the OS changes to a light mode and a chosen dark color scheme when the os changes to a dark color. And make it optional.
hybrid fjord
I believe this can be realized as some type of plugin
upper pine
Hi! I have an idea, I don't know where to post it. The idea is to maybe have a v...
You could probably hook into the discord system theme logic and override the applied theme
azure verge
yeah I think that's plugin territory
vast bane
Ah thanks
upper pine
yeah I think that's plugin territory
yeah
hot juniper
Hi! I have an idea, I don't know where to post it. The idea is to maybe have a v...
ok
if you NEED the nitro colour scheme below
vernal lintel
this only allows default light
if you want to switch between a dark and a light nitro theme that's not a thing
hot juniper
if you want to switch between a dark and a light nitro theme that's not a thing
ah
i am aware
i was just about to say
vernal lintel
or switch between two custom vencord themes
but it should be really easy to add
i sent a code sample recently to detect changes to the theme
azure verge
hot juniper
`@media (prefers-color-scheme: dark) {}`
if u need it as js: ```js
matchMedia("(prefers-color-scheme:dark)").matches
bros name is elFarto
vernal lintel
my bad bro
upper current
bro posted a comic 
azure verge
bro posted a comic <:SKULL_SKELETON:1133504974777757726>
bro used skull emoji in a message
upper current
yeah but its the skyrim one so its ok
azure verge
lmao
azure verge
If someone could retest quality description changing when changing settings for ...
it works for me i believe
azure verge
fixed changing of discord quality description
this alone
makes it feel like 10x higher quality
azure verge
STREAM_START
how could we go about using this
it may remove the need for the timeout
simple groveBOT
hybrid fjord
Also for now I have bug when you change stream to window then system portal picker shows twice
Can anyone reproduce?
azure verge
it should happen anytime you stream a window in general
ive been meaning to look into it
@vernal lintel 2 things
- what the hell is your sleep schedule
- i cannot for the life of me find anything on tooltips in order to learn how to use them
azure verge
i know
it forces me to add children and text to it and i dont know how they work
i tried looking it up
there is N O T H I N G
vernal lintel
wdym looking it up
like googling? 😭
ofc u won't find anything, it's discords component
azure verge
e x a c t l y
vernal lintel
search for tooltip in vencord source code
azure verge
what the hell is the children field
vernal lintel
many examples
azure verge
there is no children field
what
it automatically adds these
wait WAIT
im really dumb
do i just fucking
put the image
in children
azure verge
omfg
vernal lintel
but not like that
azure verge
i just let vscode create the missing fields
vernal lintel
well no actually
azure verge
and then was gonna go off of it
vernal lintel
text is the tooltip value
azure verge
yeah
vernal lintel
children is what's gonna have the tooltip
vernal lintel
so you put the show tooltip in children and the preview img in text
azure verge
like i said look vencord code for examples
i was looking just now 😭
vernal lintel
huh
changes to what
vesktop?
or do u mean you worked on venmic code from multiple computers and didn't pull
upper pine
or do u mean you worked on venmic code from multiple computers and didn't pull
this
Problem was that I moved a lot of files
And I was afraid it's gonna be really fucked
broken solstice
its not done at all yet
Sure sure, I was just putting out my ideas 🙂
upper pine
i vote leave it like this /j
Make it move like the DVD thingy
but only 5% of the time
Also, what's your theme? Looks nice :D
Another idea: Can you move the Change button left to Go Live?
vernal lintel
midnight with "vencord" color scheme i think
upper pine
thanks :D
azure verge
Another idea: Can you move the `Change` button left to `Go Live`?
i may put it to the left of go live and cancel on the FAR left of that bar
maybe
upper pine
yeah that sounds good
azure verge
i am struggling way too much to style this fuckin tooltip
upper pine
Most of the time I click outside of the modal to cancel anyways
azure verge
really?
azure verge
interesting
upper pine
And that's really noticable
azure verge
i dont have any noticeable change with vesktop with this theme
upper pine
because stock isn't too smooth either xd
azure verge
TRUE
azure verge
then again im on my laptop rn so
its not exactly the most perfect experience anyways
you'd think itd be smoother
upper pine
yep
vernal lintel
why does Vesktop / Discord always feel so sluggish with themes
themes add a lot of lag
i just use https://vencord.dev/plugins/ClientTheme
no lag
azure verge
i have that plugin on iirc
upper pine
i just use https://vencord.dev/plugins/ClientTheme
Can I prvent the text-color change?
Just bgs
azure verge
how the hell do I style a tooltip
boreal warren
What I don't understand is why themes lag
Like, they're (usually) not a thousandth of the css discord already has
Is it all the [class*=] selectors piling up after all?
simple groveBOT
Context menu on desktop:
Context menu on vesktop:
(literally unusable i want paste on the bottom)
vernal lintel
What I don't understand is *why* themes lag
Like, they're (usually) not a thousa...
no
it doesn't matter if it uses attr selectors or not
boreal warren
I honestly don't see how that can be true, checking substrings has to be more expensive than classes
It is a more complex operation, and also less common and therefore probably less optimized
azure verge
im losing it
i cannot style this fucker
@vernal lintel waaaaah im stupid and cant figure it out waaah solve all my problems for me (pls dont i just cannot get any styles to apply to the tooltip component itself and i dont want to be annoying by complaining or pinging you but im confuseddd)
vernal lintel
I honestly don't see how that can be true, checking substrings *has* to be more ...
yes but both have an incredible throughput making the difference irrelevant
vernal lintel
<@343383572805058560> waaaaah im stupid and cant figure it out waaah solve all m...
why do u need to style it
xy problem
upper pine
yes but both have an incredible throughput making the difference irrelevant
I'd actually love to see a benchmark on like a couple million classes
surely someone has done that before
vernal lintel
what actually matters are poorly written compound selectors
one single line of poorly written css can cause 100% cpu usage
vernal lintel
a poorly written compound selector (wildcards, :has, etc) can cause exponential complexity
like walking the entire body for every node in the body
upper pine
yeah ik
vernal lintel
something like
body:has(.foo) *
azure verge
xy problem
fair
although i thought it was obvious
you shouldnt have text that you hover over
that is just black and default font size
vernal lintel
and stop using vanilla html elements
azure verge
oh my fucking god
vernal lintel
use discord components
azure verge
im an idiot
THE SHOW PREVIEW TEXT IS LITERALLY IN A DIV IM AN IDIOT
I CANNOT BRAIN
azure verge
use discord components
i shall try
im just
used to html
so first habit is
"there's an element for this!!!"
upper pine
Is someone here using pipewire < 0.3.68?
azure verge
Is someone here using pipewire < 0.3.68?
yeah
upper pine
thats > 0.3.68
upper pine
xd
azure verge
im in a mood rn lmao
upper pine
haha
azure verge
gimme like 20 minutes and ill be normal
god said i should make an operating system
LMAO
upper pine
I'm about to finish a fairly big update and it'll have a lot of logic changes, just want to make sure everything still works properly before bumping in vesktop
azure verge
nice
upper pine
god said i should make an operating system
are you terry
azure verge
possibly
upper pine
watch out for glowies
azure verge
for whaT
upper pine
feds
azure verge
ignoring the show preview button
the change button looks so nice now !!!
why didnt i use discord's own components earlier lmao
upper pine
gib preview
upper pine
Sexy
azure verge
im just gonna make change
call close
and then call openscreensharepicker
so it closes and restarts
upper pine
👌
upper pine
openscreensharepicker takes data from the other file
can't you access that from within the screenshare picker?
azure verge
can't you access that from within the screenshare picker?
openscreensharepicker is ususally called from the main process
upper pine
ah
holy fuck my second monitors color profile is so fucked
The reply isn't even yellow there
azure verge
can i just call navigator.mediaDevices.getDisplayMedia
yes
yes i can
it hooks the main process's openscreensharepicker call
change works!!!!
upper pine
nice :D
azure verge
augh tooltip positioning is weird