maybe contentHint would do something
#🖥-vesktop-development
azure verge
simple groveBOT
vernal lintel
is this is? @azure verge
azure verge
is this is? <@306158896630988801>
that is
that is amazing
i will get to testing that
well
it works for framerate
resolution is still
not applying
OH
NVM
IT APPLIES ON WINDOW CHANGE
oh but you lose the higher framerate....
odd
hmm
i dont like that though
ill have to keep testing
azure verge
well
progress has been made
resolution is mostly selectable
if you choose 1080p for some reason it picks your monitor resolution
and i cant get it to use higher than 30fps yet
but this is progress
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
For me, I do not have bitrate capping to 4696kpbs even when someone is watching a stream
vernal lintel
how did ur pr get so many upvotes and hearts
like i know it's a long awaited change but how did so many people find it
simple groveBOT
For me, I do not have bitrate capping to 4696kpbs even when someone is watching a stream
When streaming something with amount of motion (ufo test on all screen), then bitrate increases up to 8mbps~, but framerate drops to 15~
Streamed in 1920x1080
That is quite intriguing, I'll have to ...
sudden trout
like i know it's a long awaited change but how did so many people find it
someone posted about it on one of the linux subreddits
vernal lintel
oh
sudden trout
vernal lintel
oh wow
the description is a bit misleading because it implies that the discord app also suffers from these fps issues
while it does suffer from many issues but not this one
azure verge
does chrome support av1 encoding
I'm not sure but they could figure that out themselves
lkao
lmao*
plus idk
discord has support for it so
if they wanted they could write a shit ton of stuff to support it
vernal lintel
it's not that easy 😭
azure verge
while it does suffer from many issues but not this one
yeah
vernal lintel
u likely need to fork electron for that
azure verge
it's not that easy 😭
oh ofc
azure verge
u likely need to fork electron for that
:)
simple groveBOT
Is your feature request related to a problem? Please describe.
Depends on what someone sees as a problem. For me it resides on this problem, that I use discord on my second screen half of the window and my input bar looks like this:
I personally only need the Timestamp and Translation. I never click on the Smiley/Gif/Sticker buttons and use their shortcuts.
**Describe the solution you'd ...
azure verge
it's not that easy 😭
maybe not av1 but I'm definitely going to look into enabling vp9 for non-nvidia systems
webrtc supports it
and it's far better size-wise than h264
so less bitrate throttling
simple groveBOT
simple groveBOT
azure verge
@vernal lintel so we've found out that now you can stream lowish res with 60fps(it automatically lowers the resolution to handle smooth 60fps) without nitro because all that nitro does is limit bandwidth and disable the button
should i add some sort of nitro check to keep us from
essentially modding in new functionality
vernal lintel
<@343383572805058560> so we've found out that now you can stream lowish res with...
you're saying non nitro users have lower max bitrate which makes it hard to do 60fps at 1080p?
azure verge
yeah as far as we can see the bitrate is lower so its harder but you can still reach 60fps at resolutions like 480p or 720p
vernal lintel
interesting
vernal lintel
usually non nitro is stuck at 720p 30fps right
azure verge
yeah
vernal lintel
id say no don't limit it but set defaults to 720p30 if you don't have nitro and add a warning card that it might not be good quality if non nitro selects higher
i wonder if this also affects FakeNitro discord desktop
azure verge
i dont know
vernal lintel
is it only in the 10$ nitro
azure verge
interesting
although im not 100% sure if the bitrate limitation is set on the server or in the client
azure verge
so why are you limited at 4kbps?
im only limited to 4696 in dm calls and non-boosted servers
in boosted servers it unlocks to 8000kbps
vernal lintel
oh interesting
azure verge
i havent been able to debug that fully
vernal lintel
discord probably has a function to get max bitrate
could check that and if it's only 4k show a warning if you select 1080p60
azure verge
should i add that into the todo as something to do/attempt to do before merging
real glade
<@343383572805058560> so we've found out that now you can stream lowish res with...
nitro itself has absolutely no checks within voice
premium tier (boosts) might
i can try to look into that
ok so boosts affect the highest bitrate you can set on a channel but that's supposed to be for voice only
higher boost levels do unlock higher quality but so does nitro, so there can't be a check there
hmmm
i wonder if video_quality_mode has any effect on this
real glade
i wonder if this also affects FakeNitro discord desktop
on desktop i can hit 10kbps without nitro so no
i'm really doubting this has anything to do with nitro
interestingly the desktop client likes to target ~4800 too
azure verge
interestingly the desktop client likes to target ~4800 too
if you find anything
lmk
it locks to like
exactly 4695ish
azure verge
this happens on web too?
on web its limited to 4000kbps afaik
real glade
ah right
azure verge
i can also help with that
do you have any idea of how to do this
because its really all that's major before merging this
the rest is small stuff that i dont know how easy it will be to fix and i dont want to make streaming take months to implement because of small bugs
azure verge
@vernal lintel i have a theory that some of the arbitrary bitrate limits on nitro users may come from the app being registered as a web client
is there a known way to spoof that
vernal lintel
yes but it makes discord think you're capable of their native vc stuff and thus breaks vc entirely
vernal lintel
discord web uses WebRTC for vc
discord desktop uses a custom udp stack implemented via discord_voice
i don't know any details about it, it's proprietary and i don't really care about it
but web can't use that
vernal lintel
if you spoof yourself as desktop, it expects you to be able to use their custom stuff and it entirely breaks vc
you can try it yourself
find where vesktop spoofs its user agent, it's somewhere in mainWindow.ts, and comment that line out
it will make it use the default electron user agent and make it think you're desktop
hot juniper
if you spoof yourself as desktop, it expects you to be able to use their custom ...
interesting
does it do that for mobile too?
real glade
yes but it makes discord think you're capable of their native vc stuff and thus ...
couldn't you present as desktop and instead patch the specific NativeFeatures checks that vesktop doesn't support
azure verge
couldn't you present as desktop and instead patch the specific NativeFeatures ch...
oooh
i need to make a todo list of things i want to change in vesktop
simple groveBOT
azure verge
i doubt this changes anything for this webrtc stuff lol
true
vernal lintel
most informative github issue comment
simple groveBOT
discord's web krisp code is broken. there is nothing we can do except wait and pray they fix it soon
vernal lintel
@heady merlin discord moment lmao
hot juniper
horror
vernal lintel
maybe we can do insane thing and patch their bundle to fix the issue
heady merlin
💀
hot juniper
maybe we can do insane thing and patch their bundle to fix the issue
we love fixing discord bugs for discord
azure verge
most informative github issue comment
BABHHAHAHAHHA
azure verge
~~we love fixing discord bugs for discord~~
y e p
also
APPARENTLY HAVING A GAME OPEN LOCKS MY STREAMS TO MAX FRAMERATE???
im barely using any bitrate and streaming perfect 1080p60
heady merlin
maybe we can do insane thing and patch their bundle to fix the issue
you mean the insane thing I did with webpack?
forcing an error and running modified
azure verge
okay who's good at css
im trying to rotate this menu so everything fits better
how do i make it wider
hot juniper
what menu
azure verge
i tried width
hot juniper
display:flex and flex-direction
azure verge
already done
hence the
everything being sideways
its still stuck to the same width though
azure verge
yeah
i added a class to the div
and tried to edit it
i just wondered if there's something more than just
width
vernal lintel
how do i make it wider
do you mean make the modal wider?
ModalRoot takes a modal size
azure verge
yeah
vernal lintel
you'll want to change it to chonky
azure verge
o
azure verge
you'll want to change it to chonky
i cannot for the life of me find it
its also late and im half asleep
i gOT it
azure verge
WIP new screenshare modal
i can move it to another branch if people dont like the idea
i just feel like it makes sense that if im already adding a few options there i might as well make it a bit cleaner
azure verge
alrighty
I'll do that tmrw
I pushed the changes just so I can mess with it on my laptop lmao
azure verge
i'd just make the preview smaller
personally id only show the name of the source
so there's as much room as possible for how much there is to select
but
sources aren't getting a name for some reason
they never were
vernal lintel
names aren't reliable
apps can set title themselves
it can be anything, doesn't even need to contain the app name
hot juniper
WIP new screenshare modal
too squished
simple groveBOT
azure verge
too squished
wdym
azure verge
@vernal lintel I've honestly not been able to be sure if any server side bitrate limitations exist other than the 4696 on dm calls(if it's even server side)
I have no idea what we should do
for non-nitro vs nitro
other than maybe lock the settings for streaming
azure verge
i'd just make the preview smaller
how would i make it smaller and still fit all of this
id prefer to remove scrolling on that modal
vernal lintel
i meant to make the preview smaller
azure verge
yeah
if i did
itd have to be basically nonexistent to fit the rest of the stuff
(mostly because of mic workaround but im not complaining if it fixes stuff lmao)
without a preview at all it fits well
hmm
i just liked the idea of the preview on the side
i could keep this part the same and just
slap it on the side
idk
its not super important
just dont want this to be too cluttered
runic inlet
how would i make it smaller and still fit all of this
maybe make the screen resolution and frame rate a dropdown
azure verge
nah
that seems like the kind of thing you want to advertise
preview is the least important thing on this menu
so therefore it should be of least priority to show
imo
runic inlet
or shorten the workaround text a bit
hallow trail
Question, on kait's developing branch, does resizing the underlying window still break/ freeze the stream?
Other clients appear to suffer this want to know if the good old issue remains
Hmm, That and other streams starting boot out your own stream
ionic gust
Hmm, That and other streams starting boot out your own stream
if you mean trying to stream while watching other streams, i talked about it a few days ago, its a vanilla bug that is a pain to try and fix
.
and no its not a simple "reverse an array", its three calls to a function that end up sending in the wrong order if you're watching a stream
but it could be and im just blind
azure verge
if you mean trying to stream while watching other streams, i talked about it a f...
i fixed that
afaik
ionic gust
wild
azure verge
it was just uhhh
i had to check if the current stream had the current user ID in it
if not
start one
azure verge
Question, on kait's developing branch, does resizing the underlying window still...
i am not sure
have not tested
will test as soon as i get home
actually ill do it rn
what the hell
that is a WACKY issue
it mostly works
but it cuts off parts of the stream
like a bad crop
ill look into fixing that later but it may be another electron thing
we've found quite a few issues in electron
when the app's resolution updates
vernal lintel
i doubt it's fixable lol
azure verge
its not properly grabbed by the desktopcapturer
yeah
its not fixable by us afaik
electron may be able to do something
vernal lintel
it's a flaw in the capturer
azure verge
yeah
vernal lintel
that's the thing that sucks about using electron you have very little control about that stuff
azure verge
electron *may* be able to do something
assuming they care enough
azure verge
that's the thing that sucks about using electron you have very little control ab...
yeah
vernal lintel
like whenever someone opens any graphical glitch issues it's an instant wontfix + closed as not planned
azure verge
we've been debating dropping the capturer altogether for the raw webrtc apis for screensharing
but i shut that down as
way too much work
id rather bother electron
azure verge
like whenever someone opens any graphical glitch issues it's an instant wontfix ...
electron also returns the wrong ID for windows and monitors
and on top of that
it doesnt return app names at all
hence the app name not working
their capturer is
a mess
we have some open issues rn
to see if they ever fix that lmao
btw
is there a way to store something and have it remain the same across app launches (like a user preference)
a simple boolean really
vernal lintel
settings api
azure verge
noted
azure verge
sorry i didnt mean to bother
that's just how i type usually
i use CRLFs as a form of punctuation
vernal lintel
i use CRLFs as a form of punctuation
yes, hence why one sentence per message you're doing like 2 words per message
azure verge
yeah but then i cant use CRLF as punctuation
unless i do it like this and
do that
vernal lintel
wdym
vernal lintel
i just realised. that's, a catturtle
azure verge
i just realised. that's, a catturtle
i mean yeah but waah that doesnt sound like me at all
boreal warren
You can
Like
Put multiple lines
In one message
azure verge
you can just say you have this channel set to all messages or something and i wont do it but if its just preference i mean idk why i cant type however i want
upper current
you can use periods to add more spacing without line breaks. e.g.
I just realized. that's. a catturtle
or more crytyping style with commas
I just realized,, that's ,,, a catturtle??
vernal lintel
you can talk how u want, i was just giving u 'feedback' cause it makes it kinda hard to read your messages
splitting multiple sentences across messages is good, but you split like one sentence into 3 messages and it makes it hard to follow :p
like the example i gave that everyone is somehow misinterpreting "i just realised that's a catturtle", it's one sentence without any punctuation so splitting it into 3 messages is weird
upper current
that star guy from deltarune
I just realized that's a catturtle
azure verge
you can talk how u want, i was just giving u 'feedback' cause it makes it kinda ...
ohhhhhhhhhhhhhhhhhhhhhhhhhh
that's fair
i can try and be a bit more readable here
azure verge
i doubt it's fixable lol
fixed it
vernal lintel
O.O
simple groveBOT
Did you tested it with latest commit?
Never had a commit already being put out to fix an issue as I was typing the issue lol. But yes, it's fixed now ^^
simple groveBOT
To Reproduce
Expected behavior
Error shows with 1/5 chance of popping up
Screenshots
Desktop (please complete the following information):
- OS/Distro: Windows 11
- Version: 23H2
broken solstice
Hello, I have a little UX discussion around https://github.com/Vencord/Vesktop/pull/489 I would like some feedback on.
This is the new picker. I'm not too sure that keeping a Show Preview button here makes sense, if I understand correctly, it has been added to remove the preview to save up space to avoid having to scroll through the picker. I think that a new layout for this dialog would make more sense as the button already wastes some extra space for the default behaviour. A simpler, temporary, solution would be to increase the dialog's size by itself.
What does Vendicated think about this?
hybrid fjord
Hello, I have a little UX discussion around https://github.com/Vencord/Vesktop/p...
What if we create spoiler element with screen preview (like <details> html tag) instead of toggle button?
For default we can hide this spoiler and set text like "click to see preview" or smth
simple groveBOT
azure verge
WIP new screenshare modal
that's why i like the idea of doing it like this
it gives more room to expand on our options
while still showing the user what they chose
vernal lintel
i think it looks really awful in a horizontal layout
azure verge
interesting
vernal lintel
looks asymetric and pushes the main content to the side
azure verge
ahhh
vernal lintel
main content should be close to the centre imo
azure verge
that's a fair point
vernal lintel
like the controls are the main centre of attention
azure verge
mhm
vernal lintel
so it should be central imo
azure verge
which is why it bothers me that the audio controls are pushed off the modal and you have to scroll to them
vernal lintel
imo either a collapsed thing or something you hover would be cool
azure verge
oooh
hm
collapsed thing that has the preview in it?
or options
i think not options personally
vernal lintel
yes the preview
azure verge
alr
vernal lintel
well actually lets just check how it looks in stock discord
azure verge
it uses app name i believe
vernal lintel
azure verge
honestly that dropdown for quality is cool
the uhh
vernal lintel
instead of that radio
azure verge
oooooooooh
i feel like another win would be to minimize the microphone workaround somehow
vernal lintel
im thinking for the preview we could do something like this and when you hover it shows the preview as tooltip
azure verge
that box usually shows the app name if you're not streaming your screen
what if i
add the change button
that would automatically make the box bigger
azure verge
true
as of rn i just found another bug??????
it now always chooses 30fps
lemme try to force 60
nope
still 30
what the hell
hybrid fjord
lol, for me too
azure verge
wha
this is weird
it was working just fine
did discord change something??????
am i
i think its limited to 720p30
hybrid fjord
But 15 fps limit setting up successfully. Means that our configuration works
azure verge
mine wont go above 720p
hybrid fjord
mine too, only fps setting
azure verge
did discord change something......
fucking hell
i swear if we have to stop faking browser useragent
@vernal lintel do you know anything
vernal lintel
i know nothing sorry
azure verge
you're fine
azure verge
SZAME
hybrid fjord
while negotiationgs looks like we receive from servers something like:
[UnifiedConnection(stream)] updateVideoQuality: {
"remoteSinkWantsMaxFramerate": 30,
"encodingVideoFrameRate": 30
}
Maybe we can change it using the same way like we patched bitrate?
hybrid fjord
also after it we can see in logs this:
...
"maxBitrate": 8000000,
"maxFrameRate": 30,
...
hybrid fjord
so looks like it does setups this settings
heh or we can just try to call this updateVideoQuality function somehow and setup our values xD
azure verge
hybrid fjord
we may set this maxFrameRate in our overrided getDisplayMedia function?
azure verge
maybe????????
hybrid fjord
i will try, but i do not really know how to properly set it
hybrid fjord
looks like a war
hybrid fjord
1920/1.5 is just 1280
azure verge
yep
hybrid fjord
xD maybe we can override functions of UnifiedConnection to do nothing?
hybrid fjord
but then it may not change resolutions where there are lack of bitrate. (maybe it is even a plus? On full hd we will always receive fullhd)
azure verge
hmm
hybrid fjord
any ideas how to get UnifiedConnection object in code?
azure verge
i may try and patch the encodingVideoFrameRate
azure verge
couldn't you present as desktop and instead patch the specific NativeFeatures ch...
we may have to do this
hybrid fjord
Can someone test streaming start when someone else have already enabled stream? Looks like it is broken for me in local p2p call
hybrid fjord
yeap, same for me
simple groveBOT
hybrid fjord
it actually looks like some webrtc broken things.. or portal or smth
hybrid fjord
tf is videoBudget at all
looks like discord proprietary things
but we can try change all here
if you know how to get it in code
azure verge
god
i am at such a loss
something is hardcoded to lock this
it definitely needs to be patched
i just dont know what to do
hybrid fjord
okay, so what we have:
- broken starting stream when someone streaming. When checking if there is another stream we use connection from MediaEngineStore
- broken track settupping of framerate and resolution. Track is getting from same connection
so maybe problem with connection object or smt?
it just hard to believe that two +- different issues are appeared at same time
hybrid fjord
IT IS
conn is undefined
which returned from MediaConnectionStore
try:
const conn = [...MediaEngineStore.getMediaEngine().connections][1];
console.log("Connection: ", conn);
And it will print:
Connection: undefined
why here [1]..
vernal lintel
discord watching the pr and trolling us
azure verge
conn is undefined
wHAT
azure verge
discord watching the pr and trolling us
I FUCKING SWEAR
hybrid fjord
xd
azure verge
IF THATS THE CASE IM MARCHING MYSELF OVER THERE AND SLAPPING WHOEVER BROKE IT
@vernal lintel can i get the vencord contributor badge 
hybrid fjord
something on my end this
then*
i'm in local call, maybe it is a reason?
i dunno
i have only like this
azure verge
odd
and it still
well its still normal
its just locked to low framerate
and low resolution
azure verge
yeah
vernal lintel
<@343383572805058560> can i get the vencord contributor badge <:pleadingtaco:843...
yes but i cant just give it to u
it works via the Devs object in src/utils/constants.ts in vencord codebase
need to add u there lol
azure verge
its hardcoded into vencord isnt it- omg
that's fair lol
ill just add it after i work on volume booster
im focused on this rn lmao
hybrid fjord
funny that bitrate target is around 8k for nitro
azure verge
@broken solstice opinions on all of this?
hybrid fjord
Look
i store input object as global variable, got MediaStream and here is 30 fps it track
and even no resolution variables
maybe somewhere in code we can get again this videotrack and patch it again
azure verge
maybe
broken solstice
that's why i like the idea of doing it like this
I mean, it's WIP but it could work if properly designed
hybrid fjord
maybe somewhere in code we can get again this videotrack and patch it again
maybe we can try to create some type of callback function when UnifiedConnection smth logs into console and patch connection's track again?
broken solstice
One sec, catching up the messages 🙂
broken solstice
instead of that radio
It's a binary option, the dropdown would have worse clarity imho
simple groveBOT
azure verge
One sec, catching up the messages 🙂
get ready to be annoyed
hybrid fjord
transceiver's sender does not have our patches too
azure verge
did we ever patch the sender?
hybrid fjord
i think no, but it may be got when we patch while creating stream
broken solstice
<@414554932679802886> opinions on all of this?
The fact that something suddently changed for no apparent reason? No idea tbh
hybrid fjord
i mean created track may be putted in transceiver's sender object
azure verge
The fact that something suddently changed for no apparent reason? No idea tbh
i assume discord fucking
updated something
and it all died
broken solstice
Yep, my stream is at 720p30 again
Confirmed, it was working fine a few hours ago
azure verge
i mean its still better than 1440p5
broken solstice
But target bitrate is somehow 6951 in private call?
azure verge
interesting????
hybrid fjord
can we try to change it using patches like "find"->"replace"?
broken solstice
hybrid fjord
But target bitrate is somehow 6951 in private call?
i thought i had this because i have nitro
azure verge
can we try to change it using patches like "find"->"replace"?
im trying to find where it's initially set
broken solstice
Sorry, Anoushka wasn't watching
It's locked just like before...
Thought they were
azure verge
oh lmao
hybrid fjord
but i'm not sure it will help in all problems(
resolution still broken
hybrid fjord
its inside applyQualityConstraints
this new function
azure verge
its inside applyQualityConstraints
yeah but is that where its initially defined or is it being used as a variable there
vernal lintel
read the code
hybrid fjord
i think we may also try to set constraints in track object, looks like discord taking res and fps info from this object
at least was taking
vernal lintel
constraints.encodingVideoFrameRate = quality.encode.framerate;
interesting
vernal lintel
getQuality(e) {
var t, n, i;
let r = this.isStreamContext ? this.getDesktopQuality() : this.getVideoQuality(this.connection.getLocalWant(e));
return new o({
encode: l.extend(r.encode, this.qualityOverwrite.encode),
capture: l.extend(r.capture, this.qualityOverwrite.capture),
bitrateMin: null !== (t = this.qualityOverwrite.bitrateMin) && void 0 !== t ? t : r.bitrateMin,
bitrateMax: null !== (n = this.qualityOverwrite.bitrateMax) && void 0 !== n ? n : r.bitrateMax,
bitrateTarget: null !== (i = this.qualityOverwrite.bitrateTarget) && void 0 !== i ? i : r.bitrateTarget,
localWant: r.localWant
})
}
setQuality(e) {
this.qualityOverwrite.capture = e.capture,
this.qualityOverwrite.encode = e.encode,
this.qualityOverwrite.bitrateMin = e.bitrateMin,
this.qualityOverwrite.bitrateMax = e.bitrateMax,
this.qualityOverwrite.bitrateTarget = e.bitrateTarget
}
thank god i can read it now
vernal lintel
sour muralBOT
thats https://github.com/Vencord/Vesktop/blob/main/src/renderer/components/Scree...
**ScreenSharePicker.tsx: **Lines 55-83
patches: [
{
find: "this.localWant=",
replacement: {
match: /this.localWant=/,
replace: "$self.patchStreamQuality(this);$&"
}
}
],
patchStreamQuality(opts: any) {
if (!currentSettings) return;
const framerate = Number(currentSettings.fps);
const height = Number(currentSettings.resolution);
const width = Math.round(height * (16 / 9));
Object.assign(opts, {
bitrateMin: 500000,
bitrateMax: 8000000,
bitrateTarget: 600000
});
Object.assign(opts.capture, {
framerate,
width,
height,
pixelCount: height * width
});
}
});
i would never have guessed
vernal lintel
this
Object.assign(opts.capture, {
framerate,
width,
height,
pixelCount: height * width
});
needs to be adapted to the new api
broken solstice
Btw, jokes aside, we need to be very careful around the resolution/bitrate thing. It's, unfortunately, discord's right to cap that for non-nitro users.
If anything gets down to users, it needs to be "safe" around the TOS as much as reasonably possible...
azure verge
im still learning how patches work
azure verge
Btw, jokes aside, we need to be very careful around the resolution/bitrate thing...
i agree
broken solstice
Sure, there will be plugins to override that safety for those who so choose but it shouldn't be automatic
vernal lintel
Object.assign(opts.encode, {
framerate,
pixelCount: height * width
});
Object.assign(opts.capture, {
framerate,
width,
height
});
try this
vernal lintel
wow so mean :(
azure verge
HAHDJHKLASGJDKHG AHJS
hybrid fjord
xD
azure verge
:(
vernal lintel
azure verge
see i would like
not say it in multiple messages
but i had no words
it works now
at least for me
let me push this
and see if it still works for others
broken solstice
Checking rn
azure verge
also im in dm call and i have max bitrate?
8000kbps
i think it was just a broken api
broken solstice
I'll test as soon as you commit
hybrid fjord
in some reason im stick with 30 fps, so test it plz too
vernal lintel
**ScreenSharePicker.tsx: **Lines 55-83
```tsx
patches: [
{
...
btw the fact that it hardcodes 16/9 resolution
idk if thats a good idea
azure verge
I'll test as soon as you commit
just pushed it
azure verge
shit
you right
hmm
well
the reason it does that is cuz height is the label (480, 720, 1080, 1440)
hybrid fjord
yeah, i thougth about it
We must create currentSettings.width parameter and rename resolution to height
azure verge
but
hmm
but how do we let the user choose
choosing low resolutions on windows still works
hybrid fjord
i think for window we may just let discord to change resolutions itself
azure verge
even if the window is super square
hybrid fjord
we need to test it
hybrid fjord
xd
vernal lintel
welll i assume we can get dimensions of the thing shared
hybrid fjord
so i can use a 4:3 screen
or just change resolution in system settings?
vernal lintel
we can just use the aspect ratio of that instead
broken solstice
Bitrate still capped
broken solstice
are you sure someone was watching that?
hybrid fjord
at least fps and res working
broken solstice
As I've told you, I know the ways, I see them patterns 🙂
azure verge
maybe
eh
not a big deal
we dont go near it
once stream stabilises
1080p 51fps is only 964kbps
hybrid fjord
not a big deal
yet now, but in future we need to see how fix it :c
azure verge
mhm
broken solstice
Also, is the starting a stream while watching another fixed as of rn?
hybrid fjord
i can't test rn
azure verge
let me check
hybrid fjord
conn is "undefined" issue?.. if you can reproduce this
broken solstice
I'm not sure I can do anything more complex than a little testing after 8 hours of conservatory and 2 of programming
and now studying guitar cause I have lesson tomorrow
broken solstice
The most crucial one we never fixed tho eheh
azure verge
// If there are 2 connections, the second one is the existing stream.
// In that case, we patch its quality
try {
var conn = [...MediaEngineStore.getMediaEngine().connections].find(
connection => connection.streamUserId === UserStore.getCurrentUser().id
);
} catch {
console.log("No current stream.");
}
console.log([...MediaEngineStore.getMediaEngine().connections]);
try {
if (conn.streamUserId === UserStore.getCurrentUser().id) {
const track = conn.input.stream.getVideoTracks()[0];
const frameRate = Number(settings.fps);
const height = Number(settings.resolution);
const width = Math.round(height * (16 / 9));
var constraints = track.getConstraints();
const newConstraints = {
...constraints,
frameRate,
advanced: [{ width: width, height: height }],
resizeMode: "none"
};
track.applyConstraints(newConstraints).then(() => {
console.log("Applied constraints from ScreenSharePicker successfully.");
console.log("New constraints:", track.getConstraints());
});
}
} catch {
console.log("No current stream.");
}
try {
if (!conn || conn.streamUserId !== UserStore.getCurrentUser().id) {
submit({
id: selected!,
...settings
});
}
} catch {
console.log("Unable to start stream.");
}
that's the stream code
ima test if it works
vernal lintel
lmao why manually include the filename and line
vernal lintel
if u enable sourcemaps, devtools automatically shows u
azure verge
omfg
vernal lintel
and u can even jump to it
azure verge
i knew that
i
im still broken from thinking my past few days of nonstop work on streams was gone
okay
so
what the hell
there's a stream with my uid
as the streamuserid
if (conn.streamUserId === UserStore.getCurrentUser().id) {
const track = conn.input.stream.getVideoTracks()[0];
const frameRate = Number(settings.fps);
const height = Number(settings.resolution);
const width = Math.round(height * (16 / 9));
var constraints = track.getConstraints();
const newConstraints = {
...constraints,
frameRate,
advanced: [{ width: width, height: height }],
resizeMode: "none"
};
track.applyConstraints(newConstraints).then(() => {
console.log("Applied constraints from ScreenSharePicker successfully.");
console.log("New constraints:", track.getConstraints());
});
}
something here didnt work
hmm
hybrid fjord
what if we check whether userId and streamUserId is same? Like for WebRTC-2
Or i do miss smth
i think we need try to log what UserStore.getCurrentUser().id returns
broken solstice
Couple of logs from latest MR version:
(node:319439) UnhandledPromiseRejectionWarning: TypeError: Video was requested, but no video stream was provided
at AsyncFunction.<anonymous> (VCDMain:40:2411)
(Use `vesktop.bin --trace-warnings ...` to show where the warning was created)
(node:319439) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 8)
TypeError is new one
I had this error when my xdg-desktop-portal needs restart and i have this error when i cancel picking screen for streaming
broken solstice
huh
interesting
I will report if I find further stuff
I'm considering how to prep for tomorrow's lesson
Cause I'm hella tired
hybrid fjord
also i think that this mini roadmap https://github.com/Vencord/Vesktop/pull/489#issuecomment-2043166651 we can move to PR's first message for convenience
azure verge
i think we need try to log what UserStore.getCurrentUser().id returns
the userid of the logged in user
broken solstice
Don't forget the cursor thing making fullscreen streaming unusable
azure verge
what if we check whether userId and streamUserId is same? Like for WebRTC-2
Or i...
we do
azure verge
Couple of logs from latest MR version:
```[319439:0409/233228.875413:ERROR:share...
ik
hybrid fjord
most informative github issue comment
i overplayed him:
hybrid fjord
the userid of the logged in user
and this if statement is still broken? Or problem now isn't with checks?
broken solstice
huh, I wonder about something
I mean, I don't think GNOME's xdg desktop portal can do that actually
I wonder if that would have the same issue as full monitor streaming
azure verge
lemme console.log inside of it
its fine and conn is set to the right stream
hybrid fjord
ohh it is strange issue
azure verge
ahh
this fails
conn.input.stream is undefined
lemme see why
i think its an edge case
lemme try stuff
hybrid fjord
you can enter overwatch vc for testing starting when someone streaming if you want
hybrid fjord
okay
azure verge
we cannot switch windows as of rn
azure verge
because we bypass submit if the stream exists
hybrid fjord
and res
azure verge
but not streamed window
hybrid fjord
hm
azure verge
because we bypass submit if the stream exists
i need to see if something else is the same
hybrid fjord
yes, windows not changing
simple groveBOT
azure verge
i need to see if something else is the same
if window/stream id was a property of conn
i could check if that's equal to a new stream or something
and if not
replacetrack
if it is equal
dont replacetrack
hybrid fjord
found out that if we start stream window then fps for it will vary only when window updates. It confirms my theory about displaySurface type. Looks like Gnome or Gnome's portal did some optimizations of redrawing display or smth
azure verge
interesting
hybrid fjord
dont replacetrack
looks good
azure verge
i cant find window id on conn
btw
if it was supported by VA-API
id love to use one of these
hybrid fjord
dont replacetrack
also when we start streaming window than i have more than one portal's window/screen picker
it is a bug actually that we might fix in .tsx?
hybrid fjord
how
azure verge
it was WAY easier than i thought
i just update the track after replacetrack is called 
hybrid fjord
xd
azure verge
omfg
hybrid fjord
hehe what if we in conn object just change videoCodec property?
what do you think? xD
azure verge
hehe what if we in conn object just change videoCodec property?
the VA-API linux driver literally does not support VP9
hybrid fjord
😦
azure verge
it would fall back to H264 no matter what
H265 is like our only chance and its
not exactly supported
hybrid fjord
okay, looks like we returned to previous state
azure verge
yeah
okay
biggest issue
cannot start stream when watching another stream
this is all that's left that isnt
bitrate related
hybrid fjord
cannot start stream when watching another stream
maybe here we need to do more checks?
azure verge
no
hm
or i think no
also
apparently changing windows cannot bring the resolution up from 30 to 60
just down from 60 to 30
hybrid fjord
i have theory
look
we getting connections array and getting [1] from it
But when we start watching stream, then it is already connection
ill investigate more
simple groveBOT
simple groveBOT
broken solstice
found out that if we start stream window then fps for it will vary only when win...
Interesting...
I mean, we're INCORRECTLY setting Window to Display which might be the root cause. What's being tracked? the cursor, for sure, it's the only thing that would cause a re-update no matter what in theory.
Also yeah, when streaming the console the framerate is lowered to only screen updates unless I move the cursor, even on a different surface (or monitor)
It looks like, by streaming the screen as a window, we're failing to track screen changes and only tracking cursor updates
broken solstice
yeah, the question now, is it GNOME or the custom software stack I'm running?
I'm going to test it hopefully soon
azure verge
want me to install gnome and find out
broken solstice
If you want but you also have an AMD GPU so it might also play a role
azure verge
we shall see
broken solstice
I actually realised that I have had broken screen capture in GNOME itself since I built my custom pipewire and rolled back from Rawhide...
Basically, they changed the API for GStreamer 1.24 and a future Pipewire version
I have backported the Pipewire stuff
But I'm no longer on Rawhide so there's probably an API break with GStreamer 1.23
GNOME also added support to the new explicit API some time ago
I'll just rebase to Rawhide and test
then rollback and also test with stock pipewire
At worst I could reset to a stock image temporarily
The things I do instead of sleeping or studying Guitar eh
But hey, I fixed the state transitions in FlatSync, for now
hybrid fjord
okay for now i have infinite loading when created stream but instant loaded stream if i change window for resolution
azure verge
yeah but is the new stream able to be 60fps
hybrid fjord
xd no
azure verge
yeah that's what im trying to figure out
hybrid fjord
but any ideas how to fix start of streaming?
azure verge
not sure rn
hybrid fjord
okay so look what i got
when we change window then in some reason constraints are not applied.
But i tried to apply them right into console like this:
temp1.stream.getVideoTracks()[0].applyConstraints({ ...temp1.stream.getVideoTracks()[0].getConstraints(), frameRate: 60 })
And i got 60 fps. Interesting thing that resolution upped to 1920, but i didn't specified it
azure verge
interesting
so it just needs reapplied
okay main issue is the dead stream on stream start while watching a stream
hybrid fjord
so it just needs reapplied
yes, but i really do not how if we really do it alrady
azure verge
okay main issue is the dead stream on stream start while watching a stream
ill try and debug that after we fix this
azure verge
huh
hybrid fjord
IT IS BROKEN IN DISCORD WEB
azure verge
omg
hybrid fjord
it is even not our problem
hybrid fjord
when you create stream then connection creates but there are no stream object in conn.input
hybrid fjord
if we use stock webrtc functions instead of electron then we can create stream ourselves and just pass it into conn.input...
But i think we really should just wait for discord to fix it
hybrid fjord
i think we may work on reapplying constraints on change window button
omg why discord is so shitty ahaha
community must find and fix bugs in discord web
broken solstice
Okay
the cursor bug still happens in rawhide
I'll test stable without patches tomorrow
Good luck with the rest 🙂
azure verge
I'll test stable without patches tomorrow
ill test in a moment
hybrid fjord
i think we may just ask some another users on gnome with gnome portal to test it
azure verge
ill test in a moment
in 20m
hybrid fjord
gnome download time xD
azure verge
i think we may just ask some another users on gnome with gnome portal to test it
i installed gnome in a container
broken solstice
Yeah, if anyone could test this, especially on Nvidia, it would be great
Keep in mind there's a good chance it's an issue with my custom stuff if no one else can reproduce it
real glade
we may have to do this
why lol
azure verge
nvm that
real glade
Btw, jokes aside, we need to be very careful around the resolution/bitrate thing...
don't use client mods if you care that much lol
or don't use the plugin
azure verge
don't use client mods if you care that much lol
yeah but we dont want discord to actively go after us or anything
real glade
yeah but we dont want discord to actively go after us or anything
they're not changing their stance cuz of this lol
azure verge
in that case
lets figure out how to remove the weird 4696 bitrate limit its getting annoying
humble mortar
Yeah, if anyone could test this, especially on Nvidia, it would be great
I'd test it but chromium has a bug which explodes multi gpu system support despair (i cant switch to just dgpu cause my laptop doesnt support it)
oh and apparently chromium vaapi with amd gpus is also broken so i cant even use hardware enc/decode on it
broken solstice
don't use client mods if you care that much lol
Yep, that's what I said. It should be safe by default
Although, to be honest they should be limiting this stuff server side anyways
broken solstice
I'd test it but chromium has a bug which explodes multi gpu system support [desp...
Thanks nonetheless
broken solstice
lets figure out how to remove the weird 4696 bitrate limit its getting annoying
Yeah, this wouldn't be necessary if they took proper care of their clients on Linux
I wonder if this limitation is present on Firefox btw
ionic gust
Btw, jokes aside, we need to be very careful around the resolution/bitrate thing...
they do not give a single fuck
source: annie/dark
annie/dark had spotify autopause and nitro screenshare settings patched out
if they actually cared they would have strong enforcement on resolutions and bitrate, but thats unrealistic
cause its how source quality functions as is
hot juniper
annie/dark had spotify autopause and nitro screenshare settings patched out
lmfao
brilliant job discord
vernal lintel
all that and they making it free now
free forever? seems like it's just like a trial thing
vernal lintel
annie/dark had spotify autopause and nitro screenshare settings patched out
lmao why
i mean i doubt anyone at discord gives a fuck about the spotify autopause, it's probably just cause spotify demanded it as part of the partnership
ionic gust
idk ask annie (prob laid off remote worker so 
)
vernal lintel
annie fired for her crimes
are u sure annie is the name of the staff and not just a codename
hot juniper
i mean i doubt anyone at discord gives a fuck about the spotify autopause, it's ...
this is real
broken solstice
they do not give a single fuck
source: annie/dark
I noticed
simple groveBOT
hybrid fjord
"Fix bug where changing windows allows you to lower the fps but not raise it" - i can't reproduce it. Can someone retest?
Also found floating bug that running stream can just die. Propably discord negotiations breaking something? Or just problem with my system
azure verge
oh and apparently chromium vaapi with amd gpus is also broken so i cant even use...
huh
I have an RX 6800xt