oh this is new
#🖥-vesktop-development
azure verge
idk what caused it to start logging
but uh
this now repeats semi-regularly while i stream with hardware accel stuff enabled
marsh hinge
humble mortar
were you ever able to do this
upper pine
Is that what you expected? Or did you expect it to be mapped different?
We currently map the ports by their name (i.e. FL -> FL)
Or did you expect this mapping?
If so, I'll have to adjust the mappings a bit
upper pine
Yes to what xd
hot juniper
idk what I was expecting
hot juniper
This looks right to me though
simple groveBOT
humble mortar
this is the mapping that I got 💀
vernal lintel
i feel like it would make more sense to make a discord thread for this
azure verge
that sounds like a good idea tbh
simple groveBOT
upper pine
this is the mapping that I got 💀
Can you still reproduce this with the latest vesktop version?
simple groveBOT
simple groveBOT
azure verge
@vernal lintel you're going to want to read this
vernal lintel
i already did :p
azure verge
okay good
i have no words
if that's the issue that is wack as hell
(obv its not the only issue i think because its recreatable in other screen recording apps on electron/chromium)
vernal lintel
tbh i just took the bitrate values from discord desktop lol
azure verge
that's probably a good idea
to avoid discord from rate limiting
but uhhh
we may want to look into raising that bitrate limit from 2.5kbps
cuz rn chromium is still limited even tho you used 80kbps according to that issue
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
azure verge
so uh
progress has been made
im going to try and rewrite parts of the screensharing logic in the RTCRtpSender API
doing that should hopefully fix the framerate issues
Ive been talking with IlChitarrista
this seems to be the API that discord desktop uses
which would explain a lot
simple groveBOT
azure verge
im going to try and rewrite parts of the screensharing logic in the RTCRtpSender...
*not really rewrite, more of just i think i see what's weird
elder epoch
does vesktop have a custom navigator? (browser thingy thing i forgot the name of)
agent*
vernal lintel
it uses the default chrome user agent
vernal lintel
why
elder epoch
i was going to attempt to make a fork that adds vesktop to platformindicators because currently it shows all vesktop users are on web which is technically true, (also 99% of the time i see a web icon its either a scammer or someone doing dev work (or vesktop)) 
idk if that's impossible to perform due to privacy reasons or etc
vernal lintel
i was going to attempt to make a fork that adds vesktop to platformindicators be...
not possible
elder epoch
not possible
aww
azure verge
@vernal lintel the issue with screensharing is believed to be because
this is applied to the first connection through portals
which is then broken
and then a new connection is made to start the stream
i believe if we were to either re-apply or just only apply those here before the callback, it may work
if not we may have to look into creating an instance of RTCRtpSender
and apply the settings to that
azure verge
yeah
vernal lintel
it doesn't support any of that stuff
azure verge
we've looked around a bit more
we have a few options that make sense
we either make a new instance of RTCRtpSender
and use that
or we monkeypatch the one electron uses by default somehow
azure verge
we either make a new instance of RTCRtpSender
this is the elegant solution
not sure how to make electron use it for a WebRTC stream though
azure verge
not sure how to make electron use it for a WebRTC stream though
@vernal lintel this right here is the only thing stopping the streams from being on par with windows as far as we can tell
the fps holds high until the bitrate cap of like 2500kbps gets hit
and then it throttles
hot juniper
2500kbps bitrate limit 
azure verge
yeah its a hardcoded limit in chromium
hot juniper
what the FUCK
azure verge
once its correctly applied
itll work
hopefully
alright
does anyone know where RTC connections are made
in this code
azure verge
@vernal lintel im really sorry to bother you again i just cannot for the life of me understand what api this connection is from/ what it even is and how it can be modified
vernal lintel
discord
azure verge
yea but like
is it an rtc connection?
or is it some sort of proprietary thing that makes no sense to anyone
simple groveBOT
simple groveBOT
simple groveBOT
vernal lintel
that's just not true??
hot juniper
since when
when was this changed
this was added in some update i never read about afaik
simple groveBOT
hot juniper
@vernal lintel am I getting it mixed up with the web arrpc
vernal lintel
arrpc has supported process scanning forever
hot juniper
huh i didnt know
so in that case
how does it detect what processes are registered?
there's no settings in vesktop for it
figured it out
i will now document my findings
@vernal lintel you will so hard when you read what i discovered
hot juniper
your horror has been delivered
vernal lintel
why post that here and not arrpc repo
hot juniper
i will file there too now
or i could attempt to fix it
should I try to fix it myself?
hot juniper
just remembered wmic is depreciated
simple groveBOT
hot juniper
love shit not working for no reason.
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
I actually quite like the current logo for Vesktop on FlatHub
Unfortunately, it's the normal one on the Windows version for example....
Question: @Vendicated Why aren't all the Vesktop versions using the one on FlatHub? Perhaps at least give the option for the background?
azure verge
damn
always sad seeing new messages here and its just "star added"
i always think someone has some new crazy stuff LMAO
boreal warren
That's what I've been saying for ages
tulip hare
#starboard channel but instead of #⭐-starboard it's just all the GitHub stars
azure verge
That's what I've been saying for ages
IKR
azure verge
#starboard channel but instead of <#1026276347070390382> it's just all the GitHu...
YES
hallow trail
Anyone got a lead on that 2.5kbps value chromium sets?
I can just patch and rebuild it for a quick test of the encoder
But I did not get much on my own searches of the codebase, it's a pretty thick tome
vernal lintel
@azure verge
azure verge
Anyone got a lead on that 2.5kbps value chromium sets?
wassup
hallow trail
Heyo
I can spare the compile on my gentoo slab
And probably whip up a PKGBUILD for arch use
azure verge
ive been trying to test it but GOD trying to worm through how id remake the api on vesktop is a pa i n
so
azure verge
But I did not get much on my own searches of the codebase, it's a pretty thick t...
codebase of vesktop? or chromium?
azure verge
oh
lmao
uhhh
im not sure where it's set in chromium
but yeah basically
if you test a stream, in the debug menu itll show a fuck ton of stats
the framerate is stable 30 with hw accel
but the framerate drops like a rock as soon as the bitrate goes above 2500kbps(idk if its 2.5 or 2500 the number is different in different places) until the bitrate goes down and then the framerate goes back up
hallow trail
Cloning repo to search on my own disk
azure verge
alright !
azure verge
Cloning repo to search on my own disk
so are you going to build chromium and then just test with discord web or somethin?
that'd be what I do
hallow trail
media/video/vpx_video_encoder.cc
Worth looking at
media/base/video_encoder.cc
uint32_t GetDefaultVideoEncodeBitrate(gfx::Size frame_size,
uint32_t framerate) {
// Let's default to 2M bps for HD at 30 fps.
const uint32_t kDefaultBitrateForHD30fps = 2'000'000u;
const uint32_t kHDArea = 1280u * 720u;
const int kMaxArea = 8000 * 8000;
const uint64_t kMinBitrate = 10000;
const uint64_t kMaxBitrate = std::numeric_limits<uint32_t>::max();
// Scale default bitrate to the given frame size and fps
base::ClampedNumeric<uint64_t> result = kDefaultBitrateForHD30fps;
result *= std::clamp(framerate, 1u, 300u);
result *= std::clamp(frame_size.GetArea(), 1, kMaxArea);
result /= kHDArea * 30u; // HD resolution, 30 fps
return std::clamp(result.RawValue(), kMinBitrate, kMaxBitrate);
}```interesting
im pretty sure i just need to edit the bitrate through the RTCRtpSender
but its wack
you could try and build with that file edited
hallow trail
Why doesnt the call just normally work, we enter all the correct parameters
Are we not entering them into RTCRtpSender and instead something else?
Give me a primer, all this is new
What function in that class initiates the stream?
azure verge
which class?
most of the screensharing logic is in src/main/screenShare.ts
but
the bitrate is applied in src/renderer/components/ScreenSharePicker.tsx
the issue (i believe) is that a portal is used to get access to the screen
that connection is then modified
and then closed
and another connection starts
and that one no longer has the modified settings
i could be wrong
that's just a hypothesis
azure verge
this is helpful and may have more useful information on this topic
this is really interesting
there are like a billion RTC handshakes
the bitrate gets set to 8000000
and then
undefined
also the discord website forces it to 30fps due to it not being registered as desktop and yk
being registered as web discord
at least
i assume that's why it does it
@vernal lintel
https://issues.chromium.org/issues/40155218
this is something of note btw
azure verge
<@343383572805058560>
https://issues.chromium.org/issues/40155218
and now i stop pinging you so much i am so sorry lmao
azure verge
uhm
and then instantly
wtf
and yep
bitrate undefined again
oh my god
the first call to start stream
gives
720p30
at 2.5mbps
that's the fucking problem i think
wait no what the hell is that stream
is it my friend's camera?????
i am so confused lmao
okay so resolution is instantly removed
odd
for a basic solution
if may be worth making a button or something
to see if we can force reapply
the bitrate
ionic gust
...you're contributing to a client mod for discord
azure verge
...you're contributing to a client mod for discord
omfg
i mean like
i get it
if you're not super familiar with discord but you know electron and you know how to fix the issue but
ionic gust
i still dont fully think WebRTCMediaEngine issues lie at an electron issue, but they very much could which is why discord just opted to make discord_voice
azure verge
true
wait
so how much does discord_voice implement
isnt it just voice stuff
or is it literally like
a shit ton of webrtc
ionic gust
yes
azure verge
oh god
ionic gust
the first issue is its a partial black box because no one has cared to reverse engineer it, which i dont blame them
azure verge
oh g o d
i hope we dont have to update venmic to patch webrtc to force bitrates and shit
lmao
heh
welp gonna keep working on it eventually
ionic gust
discord_voice has arbitrary limits that would need to be patched out if anything if anyone cared enough but no one does
because the big one is stereo voice which has been more of a nuisance than used for constructive purposes
azure verge
may i ask what you mean by it being a nuisance
ionic gust
theres a "scene" of mostly annoying kids that use stereo voice to be as loud as possible, known as "packing"
ionic gust
lightcord used to be used for it after they patched stereo voice in discord_voice because of lightcord version pinning native modules
but anyways
azure verge
interesting
ionic gust
discord_voice also handles special encoders as well like av1
and hardware accelerated encode via cuda, nvenc and amf
which all have kamoji strings for the respective encoders
azure verge
oh uhh i just kind of wondered if you had any idea if you knew about this at all because you seem to kind of understand webrtc
it seems to reset the streams to default settings about 1-2 seconds after they start
azure verge
and hardware accelerated encode via cuda, nvenc and amf
interesting
ionic gust
oh uhh i just kind of wondered if you had any idea if you knew about this at all...
i know fuck all about webrtc, i only know the pitfalls of WebRTCMediaEngine from my own debugging
azure verge
oh uhh i just kind of wondered if you had any idea if you knew about this at all...
which i think may play into the fuckin 2.5mbps bitrate limit
azure verge
i know fuck all about webrtc, i only know the pitfalls of WebRTCMediaEngine from...
ohhhh oki
ionic gust
like the fact that if you're already watching a stream and you try and screenshare for whatever reason the order of your packets get flipped
and thus your screenshare doesnt start properly
azure verge
what the fuck
what the actual fuck
how the hell do you program a bug like that into existence
ionic gust
vanilla bug btw
azure verge
that seems like it had to have been
like
put there
like
i mean obv it wasnt
but
how the hell
ionic gust
ive tried to fix it and have no idea where the fuck to even start
azure verge
yeah that's
reasonable
god i am
honestly like
so fucking confused as to how to start even trying to fix this issue
because i dont know why it's un-applying
for all i know it could be discord's servers overwriting something but that wouldn't explain setting resolution to undefined
ionic gust
ive also tried to fix resolution being wrong and have gotten nowhere with that
changing the values just changed them in the print and the actual data sent had no effect
not even the "720p 30 FPS" label changed
ionic gust
or i mightve gotten that to change at one point idr
azure verge
but the actual streamed res is
ionic gust
this was like, a year or two ago so
azure verge
but the actual streamed res is
your screen resolution
i have a 1440p monitor
discord streams at 1440p no matter what
and 30fps
its really weird
also low as shit bitrate
with the setting set to maintain-quality
so it
drops to like 3fps
instead of looking bad
this debug menu is super helpful
it gets throttled if it goes above 2500kbps
and instantly gets the framerate lowered to hell and back
ionic gust
ill see what happens on native
azure verge
btw
h264 is used if hw accel is found
if not disc uses vp8
afaik
idk when av1 is used
ionic gust
im on windows so
azure verge
oh gl
ionic gust
ah cool its broken
azure verge
whar
ionic gust
ionic gust
azure verge
interesting
ionic gust
actually
i think i know why its "broken"
i purposely disabled voice hooking to stop stacktrace polution but i might need to disable that patch
ionic gust
nvm its just broken 😔
azure verge
ohhhhhh
interesting
it updates on vesktop
maybe that has some wack random shit to do with it
ionic gust
ionic gust
nope its fluxuating a lot but staying around 7.5k
azure verge
discord on windows is so weird
azure verge
nope its fluxuating a lot but staying around 7.5k
h265 is a lot more efficient
ionic gust
also h265????????
yeah thats one of the special encoders within discord_voice
azure verge
ahhhh
ionic gust
yeah
azure verge
like holy hell
ionic gust
the problem is most browsers dont and wont officially support h265/hevc playback though because of licensing
azure verge
which is annoying
ionic gust
which is why google is trying to push av1 but its still too early for support as it requires hardware decode
azure verge
"ooh look at us we made a good thing but made it a hell of a lot harder for anyone to use it"
azure verge
which is why google is trying to push av1 but its still too early for support as...
ahh
i mean
vaapi on linux and whatever shit windows has
mesa almost has full av1 support
azure verge
almost
its still early
i mean it works but idk how well
probably could be somewhat backported
ionic gust
gonna try enabling the av1 experiment even though i think its only meant for nvidia cards
ionic gust
wcgw
azure verge
instantly after starting a stream
ionic gust
nothing, its still just h265
simple groveBOT
azure verge
nothing, its still just h265
damn
ionic gust
thats the logger class itself
azure verge
its the squiggle line that the console pointed to
yeah
thought so
i have NO idea how to read minified code
ionic gust
findByCode("UnifiedConnection")
ionic gust
actually that prob wont work as well cause i dont think that gives module id nvm
azure verge
oh lol
eh findbycode isnt defined in console anyways
i probably should have done it somewhere else but debugging this shit is wack to me
azure verge
whar
ooh
i wonder what i can do with this
hehhehehe
i didnt realize i could use findbycodelazy to grab the BaseWebRTCConnection
simple groveBOT
Ensure your adblock isn't interfering. With uBlock Origin, you'll have to disable "Block Outside Intrusion to LAN" list.
it's not blocking anything, nor i have any filter that's "Block Outside Intrusion to LAN"
simple groveBOT
azure verge
oml lmao
the stream itself is UnifiedConnection(stream) on every device
that may be useful
simple groveBOT
simple groveBOT
ionic gust
the stream itself is UnifiedConnection(stream) on every device
only on web
that stream class is not used on desktop when discord_voice is available
azure verge
that stream class is not used on desktop when discord_voice is available
yea but for the sake of vesktop streaming
that's sustainably the same
and i feel it could reliably be used
as if we got discord_voice
well
we would rewrite streaming anyways
humble mortar
@upper pine did some testing and it appears to only scuff out when switching the audio output of the specific program (via plasma settings in my case) so this is very much an edge case
upper pine
<@349609234985517057> did some testing and it appears to only scuff out when swi...
Good to know though, will test what causes it there
humble mortar
also changing the audio output twice on the streamed application breaks venmic entirely and does not connect to any application until vesktop is restarted
upper pine
also changing the audio output twice on the streamed application breaks venmic e...
Interesting
simple groveBOT
simple groveBOT
simple groveBOT
upper pine
also changing the audio output twice on the streamed application breaks venmic e...
Cannot reproduce for breaking with single switch (I replied to the wrong message here xd)
Can also not reproduce breaking with changing twice
Ohhh
Wait
I think I might know what's causing it though
Are you changing the systems default speakers @humble mortar?
Because that might cause problems
upper pine
Because that might cause problems
But only when sharing whole desktop audio
But yeah with whole system audio I can reproduce venmic not sharing an application that is not playing to the default speakers
vernal lintel
gg
azure verge
it may be worth it to not crash on failed update check
simple groveBOT
simple groveBOT
real glade
@vernal lintel they have actually banned for this before
this is something they used to kinda care about
don't seem to anymore though
vernal lintel
<@343383572805058560> they have actually banned for this before
source?
i have found nothing and like it's been in vencord for ages lol
vernal lintel
i take any "fake nitro gets banned" with a massive grain of salt
misinfo spread by various people who want to justify their own rules with it
vernal lintel
misinfo spread by various people who want to justify their own rules with it
"message logger gets you banned"
"show hidden channels gets you banned"
"fake nitro gets you banned"
so i don't believe anything without proof :p
but yeah we've had no issues whatsoever even tho we've had it for more than a year
what i don't really understand is why they even let u do it lol
why not just add server side check and 403/400 😭
real glade
how do you 403 over a udp connection silly
it's very hard to do with their architecture
real glade
"message logger gets you banned"
"show hidden channels gets you banned"
"fake ni...
true
and i don't blame you lol
i just remember a few incidents so there's a chance i'm wrong
simple groveBOT
simple groveBOT
simple groveBOT
humble mortar
Are you changing the systems default speakers <@721853658941227088>?
no I'm changing the specifically shared application's output device
I'd record a video but ive been experiencing constant random freezes with plasmashell and im too busy IRL to figure it out :p
simple groveBOT
azure verge
okay i may or may not have found something interesting
either that or the connection is just unloggable
nope
alright
major progress
the stream connection doesnt exist at all
until after the stream has started
so it cannot be updated
this whole function is useless lmao
vernal lintel
please read the comments
azure verge
i did
vernal lintel
it's not useless
azure verge
it is where its currently at
the connections array only has one element when its called
vernal lintel
if you're creating a stream connection for the first time, there will only be 1 connection
that connection is patched on creation, via https://github.com/Vencord/Vesktop/blob/main/src/renderer/components/ScreenSharePicker.tsx#L54-L83
if you are changing your stream, it will reuse the old connection. that's what the code you showed is for
sour muralBOT
if you're creating a stream connection for the first time, there will only be 1 ...
**ScreenSharePicker.tsx: **Lines 54-83
addPatch({
patches: [
{
find: "this.localWant=",
replacement: {
match: /this.localWant=/,
replace: "$self.patchStreamQuality(this);$&"
}
}
],
patchStreamQuality(opts: any) {
if (!currentSettings) return;
const framerate = Number(currentSettings.fps);
const height = Number(currentSettings.resolution);
const width = Math.round(height * (16 / 9));
Object.assign(opts, {
bitrateMin: 500000,
bitrateMax: 8000000,
bitrateTarget: 600000
});
Object.assign(opts.capture, {
framerate,
width,
height,
pixelCount: height * width
});
}
});
upper pine
no I'm changing the specifically shared application's output device
Alr I think I know what it is, will fix it after I've updated Rohrkabel to make this easier
azure verge
if you're creating a stream connection for the first time, there will only be 1 ...
in that case, commenting this out shouldn't do what it actually does i feel
for some reason if i do this, the later function that sets it for when you change windows also doesn't apply
wHAT
without that patch
the resolution may not be
higher than 720p
but its actually not just
forced to screen res
azure verge
to recap
azure verge
ahm
why is this set
oh
okay
uhhh
for testing i want to try something but i have no idea how to do it
vernal lintel
why is this set
interesting, is discord setting that?
azure verge
yeah
i think its set for web clients
one of my friends has the same streaming issues when they stream from chrome on windows
azure verge
call me dumb but uhhh how 
azure verge
god i hate minified code
its a fucking nested mess
so its equal to e
holy shit literally everything in this file takes e
omfg
literally 99% of the functions in the file
including the very first line of the file
they all take e
vernal lintel
azure verge
would that mean its in another file....?
okay welp
this didnt help
interesting
its definitely correct
same ID
just didnt apply
(yes i relaunched)
this is why i need to learn how the patches work LMAO
vernal lintel
did u do a patch or edit the file
with your cursor there it looks like you edited it with devtools lol
that doesn't work
azure verge
i made an override to the file and relaunched but yeah i assumed it didnt work
im gonna make a patch rq
although idk where the patch should be called from
same place as bitrate i assume
vernal lintel
just throw it anywhere for testing, doesn't matter
i can give u a patch in a bit (not at my pc rn)
azure verge
im gonna test but idk if i can do it properly lmao
patch helper is way more useful than i realized tho
vernal lintel
but it's really easy like
find: "x-google-max-bitrate",
replacement: {
match: /"x-google-max-bitrate".concat\(\i\)/,
replace: '"x-google-max-bitrate".concat(8_000_000)'
}
you can use underscores as separators in numbers, yes they're ignored
vernal lintel
it's the same function as commas in english
but comma already has a different function in js so they used _
azure verge
it edits stuff there too
azure verge
yeah
vernal lintel
so does this patch improve stuff
azure verge
so does this patch improve stuff
im getting stable 30fps with a shit ton of motion so id say
yes
yes it does
the only issue now is fuckin
res selector
vernal lintel
im getting stable 30fps with a shit ton of motion so id say
wow that's huge
how did u even figure this stuff out
azure verge
i dont fucking know
i was reading stuff in the webrtc debugger
and noticed it was set to 2500 for max bitrate
so i set it a fuck ton higher
ill find a better setting in a bit
but i just set it to like
8gbps
azure verge
wow that's huge
im gonna look into fixing the resolution selector but making this stable is my first priority
vernal lintel
btw is this using hardware encoding or software?
azure verge
hardware
vernal lintel
like did u add the vaapi flags too?
azure verge
yeah
vernal lintel
try without vaapi
azure verge
vernal lintel
im curious
azure verge
oki
azure verge
im curious
i got like 15-20fps
its not great
not as bad as before this whole ordeal tho
vernal lintel
im getting stable 30fps with a shit ton of motion so id say
why 30fps? have u tried 60fps
azure verge
resolution selection isnt applying
vernal lintel
🤔
azure verge
its the other issue
vernal lintel
honestly now i wonder why discord sets max bitrate to 2.5k
is this on purpose so you use their desktop app
azure verge
is this on purpose so you use their desktop app
possibly
we definitely should forward this to other clients
do you want me to pr with this once i get some better settings?
azure verge
:D
i take like 50% credit
@broken solstice helped me a good bit
alright
because the value is in kbps
ill set the max to 80,000
which would be 80mbps
that's what it was set to in your previous code at least
well
hmm
it seems to not use much more than 5mbps so maybe we set it to like 15
just to keep it low
azure verge
it seems to not use much more than 5mbps so maybe we set it to like 15
this is at 1440p30
also uhhh
@vernal lintel do you think it would maybe be worth it to add this patch to vencord instead of vesktop?
it would still apply
but it would also help browser users
azure verge
i meant like
not in vesktop
just in vencord
it'd still be applied to vesktop
just
also would apply to browser users
vernal lintel
i know
azure verge
oh
azure verge
it's a bit meh to have code for the same feature in both codebase
i see what you mean
oh
wait
what if i just make it a plugin
and we make it a core plugin on web clients or something
*required
not core
couldn't remember the word
vernal lintel
that would work but it's still meh to have the code fragmented across different codebases
azure verge
yeah
i know what you mean
do you think there's a good way to implement this for browser users?
vernal lintel
that would work but it's still meh to have the code fragmented across different ...
every day we get closer to big vencord monorepo
azure verge
i just imagine like
vencord logo on a skyscraper
"big vencord"
be careful or big vencord will get you
simple groveBOT
real glade
is this on purpose so you use their desktop app
maybe they don't want to strain their webrtc infra?
cuz 2.5k is probably enough for the free stream qualities
and the web client doesn't allow you to change quality
azure verge
cuz 2.5k is probably enough for the free stream qualities
its not
its almost enough
but not perfect
real glade
interesting
i should really spend some time trying to figure out voice
nobody knows how it works fully
azure verge
@vernal lintel question about patches
actually wait
nvm
ill just split this into 2 patches
real glade
lemme take a look at this webrtc code
oh wow
there's a lot of options
don't think i've ever looked at this before
dear god this is terrifying
simple groveBOT
real glade
looks like this is where the bitrates are hardcoded
wonder if audio could use a bump too
simple groveBOT
real glade
@azure verge you can use \i
real glade
custom vencor functionality
azure verge
@vernal lintel i cannot for the life of me figure out what you mean by this
vernal lintel
that line is there twice now
vernal lintel
yes
azure verge
wtf
its not for me
lemme
rm -rf and get a fresh pull
omfg
its duplicated now
welp
fixed
azure verge
well
@broken solstice figured out the issue with resolution selection not working
at least
they found out how to fix it
not in code just
basically you can do a thing and itll stream at the right resolution
(start stream button twice, select application/window, stream, and then close the second portal that opens)
framerate is always 30 though
and bitrate is still locked to 4696
simple groveBOT
vernal lintel
huh
vernal lintel
so removing those not needed flags fixed the bitrate?
azure verge
so removing those not needed flags fixed the bitrate?
it did a great deal to bump it up yeah
its still
iffy here and there
vernal lintel
no it isnt
but why do you need that flag
it just makes electron run in Wayland instead of XWayland
Wayland electron still has many issues so making it the default isn't that good
azure verge
that's fair
vernal lintel
i for one still use it in XWayland cause Wayland electron has positioning issues for me
vernal lintel
you dont need to run in wayland for pipewire capturer to work
vernal lintel
interesting
azure verge
its such an odd issue
real glade
have you searched for that number in the code
real glade
curious if there's another target/cap anywhere
azure verge
nothing
vernal lintel
might be on backend
real glade
maybe it's 5000
real glade
might be on backend
true
vernal lintel
it seems plausible to limit bitrate
otherwise people might send crazy bitrate and maybe crash electron
real glade
their rtc workers were not made to handle any more than the 720p web discord streams
azure verge
backend limit is 8mbps for 1080p60 afaik
real glade
so this could be an rtc worker limit only
azure verge
backend limit is 8mbps for 1080p60 afaik
unless you mean electron backend
not discord backend
simple groveBOT
azure verge
their rtc workers were not made to handle any more than the 720p web discord str...
wh
a
then how do they support 1080p60
vernal lintel
maybe it's 5000
fun
vernal lintel
??????
girl?
are you not paying attention in math / physics class 😭
maybe you're more used to seeing it with capital E
5E3
vernal lintel
😭
vernal lintel
js supports it and 5e3 is one byte less than 5000 so the minifier uses it
azure verge
interesting
mine has a x10^y
okay so
it seems the reason 8mbps isnt enough for streaming
is because its lowering the framerate instead of the quality when it cannot keep up
i need to figure that out
real glade
isn't that desktop behavior too
azure verge
it usually lowers quality
and looks really blurry and blocky
which id honestly prefer
to framerate going to 7fps
real glade
that's probably an option somewhere
search for isEmbedded() or whatever
might be isPlatformEmbedded()
real glade
it's the check for native
simple groveBOT
