#🧩-plugin-development | libVencore | Page 11

austere gulch Jan 24, 2023, 3:40 PM

#

same folder as the plugin guide

sonic badger Jan 25, 2023, 1:46 AM

#

is Could not find the language '', did you forget to load/include a language module? from react_devtools_backend.js:4026 normal?

#

I don't think I caused it but just wanna double check

stiff kiln Jan 25, 2023, 3:42 AM

#

have you guys thought about making an AUR package

dull magnet Jan 25, 2023, 3:44 AM

#

what for

covert nimbus Jan 25, 2023, 7:40 AM

#

stiff kiln have you guys thought about making an AUR package

arch users putting everything on the AUR be like

#

like idk why

installing is super simple

sonic badger Jan 25, 2023, 9:52 AM

#

I did it! @dull magnet

#

MessageEvents.ts Lines: 44-66

export type SendListener = (channelId: string, messageObj: MessageObject, extra: MessageExtra) => void | { cancel: boolean; };
export type EditListener = (channelId: string, messageId: string, messageObj: MessageObject) => void;

const sendListeners = new Set<SendListener>();
const editListeners = new Set<EditListener>();

export function _handlePreSend(channelId: string, messageObj: MessageObject, extra: MessageExtra) {
    for (const listener of sendListeners) {
        try {
            const result = listener(channelId, messageObj, extra);
            if (result && result.cancel === true) {
                return true;
            }
        } catch (e) {
            MessageEventsLogger.error("MessageSendHandler: Listener encountered an unknown error\n", e);
        }
    }
    return false;
}

export function _handlePreEdit(channelId: string, messageId: string, messageObj: MessageObject) {
    for (const listener of editListeners) {
        try {

https://github.com/Vendicated/Vencord/blob/main/src/api/MessageEvents.ts#L44-L66

proud parrotBOT Jan 25, 2023, 9:52 AM

#

sonic badger **MessageEvents.ts** Lines: 44-66 ```ts export type SendListener = (channelId: s...

**MessageEvents.ts: **Lines 44-63

export type SendListener = (channelId: string, messageObj: MessageObject, extra: MessageExtra) => void | { cancel: boolean; };
export type EditListener = (channelId: string, messageId: string, messageObj: MessageObject) => void;

const sendListeners = new Set<SendListener>();
const editListeners = new Set<EditListener>();

export function _handlePreSend(channelId: string, messageObj: MessageObject, extra: MessageExtra) {
    for (const listener of sendListeners) {
        try {
            const result = listener(channelId, messageObj, extra);
            if (result && result.cancel === true) {
                return true;
            }
        } catch (e) {
            MessageEventsLogger.error("MessageSendHandler: Listener encountered an unknown error\n", e);
        }
    }
    return false;
}

sonic badger Jan 25, 2023, 9:55 AM

#

Everything seems to be working with async now

sonic badger Jan 25, 2023, 2:43 PM

#

Should I make a PR?

green vessel Jan 26, 2023, 3:56 PM

#

something like this? ```js
Vencord.Webpack.Common.RelationshipStore.getFriendIDs().map(id => Vencord.Webpack.Common.UserStore.getUser(id).username)

#

outputs all friend's usernames

#

@green vessel pong

oblique prairie Jan 26, 2023, 3:59 PM

#

ping

green vessel Jan 26, 2023, 4:04 PM

#

oh yeah try ```js
Vencord.Webpack.Common.RelationshipStore.getFriendIDs().map(id => (u => u.username + "#" + u.discriminator)(Vencord.Webpack.Common.UserStore.getUser(id)))

sonic badger Jan 26, 2023, 9:38 PM

#

by chance, has anybody taken a look at my pr?

#

I'm not very familiar with js/ts, so any advice would be appreciated

#

tho i didn't really add anything new in the pr, i just did it so my plugin could work

tribal stream Jan 26, 2023, 10:09 PM

#

hey i have a question how i can remove embed from message locally
im trying to just do

<IMessageCreate>.message.embeds = [];

but that kinda don't work and i don't have idea

#

~~doing plugin to hide embeds from certain websites because my friend irritates me with one lol~~

dull magnet Jan 26, 2023, 10:38 PM

#

dispatch a MESSAGE_UPDATE event with flux dispatcher

#

that has empty embeds array

tribal stream Jan 26, 2023, 10:39 PM

#

you mean that?

FluxDispatcher.subscribe("MESSAGE_CREATE", this.onMessage);

dull magnet Jan 26, 2023, 10:47 PM

#

thats subscribing

#

you can also dispatch your own events

#

you can just dispatch a message update event

#

FluxDispatcher.dispatch("MESSAGE_UPDATE", {
  id: ...,
  channel_id: ...,
  embeds: []
});

tribal stream Jan 26, 2023, 11:17 PM

#

i know im really stupid and don't know what im really doing but
when i do this like that ide shows me an error TS2554: Expected 1 arguments, but got 2.

#

lol

#

and when i just ignore that it prints many errors in console

dull magnet Jan 26, 2023, 11:26 PM

#

cause its dispatch({
type: ...
})

tribal stream Jan 26, 2023, 11:42 PM

#

oh

#

uhh, and it doesn't change anything really

dull magnet Jan 26, 2023, 11:57 PM

#

figure it out

tribal stream Jan 27, 2023, 12:02 AM

#

im trying to

foggy mason Jan 27, 2023, 3:02 AM

#

dull magnet figure it out

jeez

foggy mason Jan 27, 2023, 3:02 AM

#

tribal stream uhh, and it doesn't change anything really

show code

cedar olive Jan 27, 2023, 8:52 AM

#

@dull magnet guh do you still have the config and the flag to open discord with to debug with vscode, I literally cannot find

dull magnet Jan 27, 2023, 1:32 PM

#

cedar olive <@343383572805058560> guh do you still have the config and the flag to open disc...

it's literally in the repo xd

cedar olive Jan 27, 2023, 1:34 PM

#

lmao where??

#

I swear I can't find it

covert nimbus Jan 27, 2023, 1:37 PM

#

cedar olive I swear I can't find it

https://github.com/Vendicated/Vencord/blob/main/.vscode/launch.json

GitHub

Vencord/launch.json at main · Vendicated/Vencord

The cutest Discord client mod. Contribute to Vendicated/Vencord development by creating an account on GitHub.

proud parrotBOT Jan 27, 2023, 1:37 PM

#

covert nimbus https://github.com/Vendicated/Vencord/blob/main/.vscode/launch.json

**launch.json: **

{
    // this allows you to debug Vencord from VSCode.
    // How to use:
    // You need to run Discord via the command line to pass some flags to it.
    // If you want to debug the main (node.js) process (preload.ts, ipcMain/*, patcher.ts),
    //     add the --inspect flag
    // To debug the renderer (99% of Vencord), add the --remote-debugging-port=9223 flag
    //
    // Now launch the desired configuration in VSCode and start Discord with the flags.
    // For example, to debug both process, run Electron: All then launch Discord with
    // discord --remote-debugging-port=9223 --inspect

    "version": "0.2.0",
    "configurations": [
        {
            "name": "Electron: Main",
            "type": "node",
            "request": "attach",
            "port": 9229,
            "timeout": 30000
        },
        {
            "name": "Electron: Renderer",
            "type": "chrome",
            "request": "attach",
            "port": 9223,
            "timeout": 30000,
            "webRoot": "${workspaceFolder}/src"
        }
    ],
    "compounds": [
        {
            "name": "Electron: All",
            "configurations": ["Electron: Main", "Electron: Renderer"]
        }
    ]
}

dull magnet Jan 27, 2023, 1:39 PM

#

this makes discord take like 5 years to start btw

covert nimbus Jan 27, 2023, 1:39 PM

#

Noted

solar maple Jan 27, 2023, 2:14 PM

#

can we make a plugin to update UI?

#

like replacing some elements

#

(cannot be done with css)

dull magnet Jan 27, 2023, 3:37 PM

#

yes

cedar olive Jan 27, 2023, 4:49 PM

#

covert nimbus https://github.com/Vendicated/Vencord/blob/main/.vscode/launch.json

I am blind thank you.

solar maple Jan 27, 2023, 5:22 PM

#

dull magnet yes

How to setup a dev environment? 😅
Like if I clone the vencord repo then make my plugin I am sure it won't work, so is there any specific path where I clone it so that the installer reads it?

austere gulch Jan 27, 2023, 5:25 PM

#

@solar maple read the docs https://github.com/Vendicated/Vencord/tree/main/docs

GitHub

Vencord/docs at main · Vendicated/Vencord

The cutest Discord client mod. Contribute to Vendicated/Vencord development by creating an account on GitHub.

solar maple Jan 28, 2023, 1:48 AM

#

👍

solar maple Jan 28, 2023, 4:00 AM

#

austere gulch Jan 28, 2023, 4:01 AM

#

not a vencord issue
you've modified it yourself so you'll need to figure it out

#

take a closer look at examples and existing plugins

solar maple Jan 28, 2023, 4:01 AM

#

austere gulch take a closer look at examples and existing plugins

just copied the code from your guide

#

megu's plugin guide

austere gulch Jan 28, 2023, 4:02 AM

#

screenshot code?

solar maple Jan 28, 2023, 4:02 AM

#

#

(code is referenced from fxTwitter plugin)

austere gulch Jan 28, 2023, 4:03 AM

#

firstly, remove spaces from "name"
having spaces will break stuff

solar maple Jan 28, 2023, 4:03 AM

#

ok

#

nothing changed 🤡

austere gulch Jan 28, 2023, 4:05 AM

#

oh

#

whys the folder called .ts

#

remove that

solar maple Jan 28, 2023, 4:05 AM

#

folder called ts?

austere gulch Jan 28, 2023, 4:05 AM

#

#

remove the .ts

#

and try again

solar maple Jan 28, 2023, 4:05 AM

#

ah shit

#

thanks

austere gulch Jan 28, 2023, 4:07 AM

#

does it work now?

solar maple Jan 28, 2023, 4:08 AM

#

it builds successfully

#

but no console logs

#

userplugins must be turned on by default

#

i was banging my head for no reason

austere gulch Jan 28, 2023, 4:11 AM

#

solar maple Jan 28, 2023, 4:12 AM

#

good to know that preSendListener does not trigger for messages with attachments

#

RIP

solar maple Jan 28, 2023, 2:56 PM

#

solar maple Jan 28, 2023, 5:21 PM

#

I can't access the plugin tab because it's crashed

austere gulch Jan 28, 2023, 6:08 PM

#

vsupport more info

shrewd tundraBOT Jan 28, 2023, 6:08 PM

#

austere gulch vsupport more info

"doesn't work" or similar are not very helpful.
You can make our lives easier by providing the following information:

What platform are you on? Windows, Mac, Linux?

What client are you using? Discord Desktop, Discord Web, Armcord...?

What branch are you on? Stable, Canary, PTB...? If not on stable, does it work on stable?

Are you fully up to date? You can check by going to the Updater settings tab. If you cannot access that page, use the installer. If no, update and try again

Are there any errors? Open the console (Ctrl+Shift+I) and check the console tab. If there are any errors (red text), please provide them.

Does this issue persistently happen, or only sometimes?

Please provide steps to reproduce this issue. Screenshots or videos are also helpful.

tall perch Jan 28, 2023, 11:28 PM

#

hi guys flushed_shy
I wants to edit content from incoming messages. How to subscribe event on my plugin?

austere gulch Jan 28, 2023, 11:30 PM

#

look at existing plugins

dull magnet Jan 28, 2023, 11:31 PM

#

incoming messages

#

dont think any existing plugin does that

austere gulch Jan 28, 2023, 11:31 PM

#

#

moyai does

#

well, subscribe yes

#

idk about modifying

#

they just asked how to subscribe though

tall perch Jan 28, 2023, 11:33 PM

#

okeyy

#

thx

austere gulch Jan 28, 2023, 11:41 PM

#

np

dull magnet Jan 28, 2023, 11:42 PM

#

but asking for how to subscribe is x/y problem

#

so no point to help with that

#

you need to patch some part of the message event lifecycle to edit message content

sonic badger Jan 28, 2023, 11:54 PM

#

@dull magnet what is Promiseable?

austere gulch Jan 28, 2023, 11:55 PM

#

sonic badger Jan 28, 2023, 11:56 PM

#

Oh okay I have to import it then

austere gulch Jan 28, 2023, 11:56 PM

#

you can use this if you're not sure if something is a promise or not https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/resolve

Promise.resolve() - JavaScript | MDN

The Promise.resolve() static method "resolves" a given value to a Promise. If the value is a promise, that promise is returned; if the value is a thenable, Promise.resolve() will call the then() method with two callbacks it prepared; otherwise the returned promise will be fulfilled with the value.

edgy berry Jan 29, 2023, 1:33 AM

#

i cant import flux events

#

and eslint does not like this

green vessel Jan 29, 2023, 2:17 AM

#

try import type instead of import

#

actually mm

#

yeah tsconfig needs ```json
"@webpack/common/types/": ["./webpack/common/types/"],

#

or something like it

#

@dull magnet fix

dull magnet Jan 29, 2023, 2:42 PM

#

just don't import them

edgy berry Jan 29, 2023, 6:11 PM

#

dull magnet just don't import them

how do i use the type then

#

if i dont import it

dull magnet Jan 29, 2023, 6:11 PM

#

you don't need to

#

why do you need it

dull magnet Jan 29, 2023, 6:12 PM

#

green vessel yeah tsconfig needs ```json "@webpack/common/types/*": ["./webpack/common/types/...

in any case you can just add this

edgy berry Jan 29, 2023, 6:12 PM

#

edgy berry Jan 29, 2023, 6:12 PM

#

dull magnet in any case you can just add this

alr

dull magnet Jan 29, 2023, 6:13 PM

#

edgy berry

just add as const to ur object

edgy berry Jan 29, 2023, 6:20 PM

#

dull magnet just add `as const` to ur object

where would i add that

#

like this?

dull magnet Jan 29, 2023, 6:23 PM

#

to your object

#

at the end

edgy berry Jan 29, 2023, 6:36 PM

#

oh thanks

green vessel Jan 29, 2023, 6:38 PM

#

const foo = /* ... */ as const; we love

edgy berry Jan 29, 2023, 6:39 PM

#

it works but i still dont understand what that does lmao

dull magnet Jan 29, 2023, 6:51 PM

#

by default ts considers objects as possibly partial and mutable

#

so it types

const blah = [{ type: "hi"}]
``` as `Array<{type: string}>`

#

the as const tells ts that this object is immutable or constant and now correctly infers every variant of type as literal

#

so in this case it would be typed as Array<{ type: "hi" }>

edgy berry Jan 29, 2023, 6:53 PM

#

ohh i see

#

so its basically making the entire object and all properties/elements constant

#

thats actually really useful

trail ginkgo Jan 30, 2023, 1:45 AM

#

dull magnet you need to patch some part of the message event lifecycle to edit message conte...

i do that

#

in spotimbed

#

sike

#

i dont do it far up enough in the lifecycle to be generalizable

#

only affects embeds

near aurora Jan 30, 2023, 9:31 AM

#

is there a wasm lib/any other reimplementation of base64 => ascii decoding than atob?

#

atob is slow

#

like rly slow

#

a 1-2k line json encoded in b64 takes like good 5-6 seconds to decode

dull magnet Jan 30, 2023, 4:11 PM

#

🤨

#

are u sure

green vessel Jan 30, 2023, 4:13 PM

#

atob is native code

#

wasm can't be faster

south ledge Jan 30, 2023, 8:36 PM

#

is pmneo.tsimporter useful

#

or does vscode alr implement what it does (& that's what it got removed)

#

also in the most part auto rename tag's functionality is part of vscode ("editor.linkedEditing": true,)

dull magnet Jan 30, 2023, 8:46 PM

#

linkedEditing bad

#

doesnt work in most file types

#

and tsimporter mostly obsolete

#

i think tsimported is only good for importing default exports

#

but u should just avoid default exports theyre bad

grim hare Jan 30, 2023, 10:10 PM

#

atob/btoa converted 25MB of json to base64 and back to json in less than a second for me (i do not feel like getting an exact time right now but it is fast)

#

saying it is slow is insane

near aurora Feb 1, 2023, 10:04 AM

#

hello webdev folk pliz halp

#

https://stackoverflow.com/questions/75307453/fabric-js-canvas-repeating-background-with-dynamic-svg

Stack Overflow

fabric.js canvas repeating background with dynamic SVG

I am creating a pannable, zoomable, infinite grid editor with fabric.js, typescript and vite.
Since i implemented snapping to grid, it would be good to have a visual aid of where the grid actually ...

magic sorrel Feb 1, 2023, 1:17 PM

#

is emote cloner working?

#

i think image context menu patch is broken
well not broken but passing the target isnt working
https://i.imgur.com/h6djTnV.png

Imgur

dull magnet Feb 1, 2023, 1:28 PM

#

ye brokey

#

but ReverseImageSearch works idk

magic sorrel Feb 1, 2023, 1:29 PM

#

prolly because it doesnt need the target eh

#

i think

#

¯_(ツ)_/¯

dull magnet Feb 1, 2023, 1:30 PM

#

i think it only uses target to not show reverse image search for videos and other junk

magic sorrel Feb 1, 2023, 1:30 PM

#

interesting

bitter sonnet Feb 2, 2023, 8:41 PM

#

hey, i'm using codef53's stylesheet (https://codef53.github.io/CSS-Snippets/discord/RevertUserPopouts.css )
and some more css:

[class*="avatarPositionPremiumBanner"] {
  top: 72px;
  left: 18px;
}
[class*="avatarPositionPremiumBanner"] circle {
  opacity: 0 !important;
}
[class*="userProfileInner"] {
  background: var(--nord-dark1);
}
[class*="userPopoutOuter"], [class*="userProfileOuter"] {
  padding: 0 !important;
  background: var(--nord-dark1);
  --profile-body-background-color: var(--nord-dark1) !important;
}

to disable custom profile themes, but those that are light themed have a theme-light class on them so it makes them unreadable
and i have no idea how to fix that pure css w/o like 50 css selectors to undo the whole light theme 😵‍💫
(screenshots of a theme-dark profile and a theme-light one)
(idk if this is the right channel but i don't see a theme-dev/css specific one so 🥴)

dull magnet Feb 2, 2023, 8:43 PM

#

accessibility settings

#

bitter sonnet Feb 2, 2023, 8:43 PM

#

😭

#

how did i not notice that

#

thank you

dull magnet Feb 2, 2023, 8:44 PM

#

well tbf its in the worst section it could be in

#

it should be in appearance settings

bitter sonnet Feb 2, 2023, 8:46 PM

#

yeah, along with the option to yeet profile themes altogether 😵‍💫

potent fox Feb 3, 2023, 2:18 AM

#

@dull magnet DELETE

austere gulch Feb 3, 2023, 2:27 AM

#

done

feral bronze Feb 3, 2023, 12:22 PM

#

How can the CustomRPC plugin set a custom presence type and name

#

why can't other rich presence applications do the same

dull magnet Feb 3, 2023, 12:24 PM

#

wha

opal fern Feb 3, 2023, 12:31 PM

#

It's internal

feral bronze Feb 3, 2023, 12:34 PM

#

So not possible from an external application?

hardy pawn Feb 3, 2023, 2:23 PM

#

covert nimbus Feb 3, 2023, 8:24 PM

#

feral bronze How can the CustomRPC plugin set a custom presence type and name

because i added it as a setting

#

im unsure why others don't though

feral bronze Feb 4, 2023, 3:09 AM

#

bruh

cedar olive Feb 4, 2023, 11:34 PM

#

for gods sake if any soul can help me get stage channels to work

https://github.com/Vendicated/Vencord/pull/469

literally just use my pr, click a hidden stage channel and you will see the issue (it doesn't transition correctly sobb )

GitHub

ShowHiddenChannels: fix guhhh formatter (grr ven) by Nuckyz · Pull ...

cedar olive Feb 5, 2023, 12:39 PM

#

@dull magnet can I include this on my pr

dull magnet Feb 5, 2023, 4:04 PM

#

94ms blbctscrd

#

sure

proud parrotBOT Feb 5, 2023, 4:10 PM

#

**index.js: **

// Generated by MS2Porter
const version = '1.1.0';

let src;

const downloadURL = async (url) => {
  let el = document.createElement('a');

  el.href = url;
  el.download = url.includes('http') ? url.split('/').pop() : '';

  el.style.display = 'none';

  document.body.appendChild(el);

  el.click();

  document.body.removeChild(el);
};

const keypressHandler = (e) => {
  if (src && e.code === 'KeyD' && e.ctrlKey) {
    downloadURL(src);

    e.preventDefault();
    return false;
  }
};

const hoverHandler = (e) => {
  if (e.target && e.target.src) {
    src = e.target.src.split('?')[0];
  } else {
    src = undefined;
  }
};

export default {
goosemodHandlers: {
  onImport: async function () {
    document.addEventListener('keypress', keypressHandler);
    document.addEventListener('mousemove', hoverHandler);
  },

  onRemove: async function () {
    document.removeEventListener('keypress', keypressHandler);
    document.removeEventListener('mousemove', hoverHandler);
  },



}
};

cedar olive Feb 5, 2023, 4:11 PM

#

I GOT IT

#

THIS FREAKING THING WAS REPLACING MY ROUTE FROM STAGE CHANNELS

#

THIS TOOK ONLY LIKE 7 HOURS TO FIND

#

no kidding

cedar olive Feb 5, 2023, 4:13 PM

#

dull magnet 94ms <:blbctscrd:1065724903652855938>

I will improve

#

#

blobcatfearful

dull magnet Feb 5, 2023, 4:27 PM

#

why did it take so long

#

are you trolling

cedar olive Feb 5, 2023, 4:28 PM

#

seems to be constant

#

will fix

dull magnet Feb 5, 2023, 4:29 PM

#

curious

#

is it because of the non fixed width lookbehind

cedar olive Feb 5, 2023, 4:29 PM

#

probably

#

troll

dull magnet Feb 5, 2023, 4:49 PM

#

chatgpt can't write plugins

#

yes but it can't

opal fern Feb 5, 2023, 5:00 PM

#

learn how to code

#

then come back

green vessel Feb 5, 2023, 5:12 PM

#

did a mf seriously ask AI to code a vencord plugin bruh

#

that's awesome

deft horizon Feb 5, 2023, 5:27 PM

#

On discord web wit my browser when I got to share my screen, It shares my desktop audio even without a window selected. Would it be possible to develop somthin like that for Ventcord?

dull magnet Feb 5, 2023, 5:29 PM

#

wha

cedar olive Feb 5, 2023, 5:40 PM

#

@dull magnet aight it's done https://github.com/Vendicated/Vencord/pull/469/files

GitHub

ShowHiddenChannels: More improvements (Stage and voice channels sup...

trail ginkgo Feb 5, 2023, 6:22 PM

#

keep in mind chatgpt's training data cuts off at 2019

#

so it would never know about vencord

#

other than what you could infer from the name

green vessel Feb 5, 2023, 6:23 PM

#

https://cdn.discordapp.com/emojis/1017401072274395279.gif?size=48&quality=lossless

#

no you thought AI could port that plugin 💀

#

https://mastodon.social/@pid_eins/109755065302743024

mastodon.social

Lennart Poettering

Lennart Poettering (@pid_eins@mastodon.social)

So, we are now living in a world where people generate feature requests based on random ideas AI might have? → https://github.com/systemd/systemd/issues/26212

And I thought AI was supposed to reduce the workload on humans, not add more on top!

#

trolley

#

https://cdn.discordapp.com/emojis/1015604204657717349.gif?size=48&quality=lossless

cedar olive Feb 5, 2023, 6:54 PM

#

/*
 * Vencord, a modification for Discord's desktop app
 * Copyright (c) 2022 Vendicated and contributors
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
*/

import { Devs } from "@utils/constants";
import definePlugin from "@utils/types";

let src;

function downloadURL(url: any) {
    const el = document.createElement("a");

    el.href = url;
    el.target = "_blank";
    el.style.display = "none";

    document.body.appendChild(el);

    el.click();

    document.body.removeChild(el);
}

function keypressHandler(e: any) {
    if (src && e.code === "KeyD" && e.ctrlKey) {
        downloadURL(src);

        e.preventDefault();
        return false;
    }
    return true;
}

function hoverHandler(e: any) {
    if (e.target && (e.target.src || e.target.href)) {
        src = (e.target.src || e.target.href).split("?")[0];
    } else {
        src = undefined;
    }
}

export default definePlugin({
    name: "DownloadImagesShortcut",
    description: "guh",
    authors: [Devs.Nuckyz],

    start() {
        document.addEventListener("keypress", keypressHandler);
        document.addEventListener("mousemove", hoverHandler);
    },

    stop() {
        document.removeEventListener("keypress", keypressHandler);
        document.removeEventListener("mousemove", hoverHandler);
    }
});

#

@green vessel ^

#

bit modified from the original cuz it didn't work thonk

#

instead of opening the download popoup it opens the link in your browser for you to download

dull magnet Feb 5, 2023, 7:09 PM

#

@cedar olive i dont understand these

#

why even bother webpack searching

#

just hardcode the values

cedar olive Feb 5, 2023, 7:09 PM

#

eh just in case discord ever change them somehow

dull magnet Feb 5, 2023, 7:09 PM

#

they wont

cedar olive Feb 5, 2023, 7:10 PM

#

I guess it would be more perfomant hardcoding

dull magnet Feb 5, 2023, 7:10 PM

#

it's more likely those webpack searches fail than that the values are changed

cedar olive Feb 5, 2023, 7:10 PM

#

aight I will change it

#

I will keep channel flags

#

since those are bitfields

#

nvm actually

dull magnet Feb 5, 2023, 7:14 PM

#

most if not all of those are part of the public api

#

aka they will not change them ever unless it's a major api update

cedar olive Feb 5, 2023, 7:19 PM

#

there

#

changed it

dull magnet Feb 5, 2023, 7:23 PM

#

this fixed performance? @cedar olive

cedar olive Feb 5, 2023, 7:23 PM

#

yeah

dull magnet Feb 5, 2023, 7:23 PM

#

so strange

cedar olive Feb 5, 2023, 7:24 PM

#

I added the comma at the start too cuz there was another function that ended with NOTICE_DISMISS

dull magnet Feb 5, 2023, 7:29 PM

#

why did u add so many patches O_o

cedar olive Feb 5, 2023, 7:32 PM

#

It's needed

#

😔

#

It turned super complex

cursive plank Feb 5, 2023, 11:18 PM

#

~~does anyone already know how to modify the user modal?~~

#

~~just asking in case I can avoid searching for all eternity~~

cursive plank Feb 5, 2023, 11:34 PM

#

nvm found it

cursive plank Feb 5, 2023, 11:55 PM

#

nice

austere gulch Feb 6, 2023, 12:00 AM

#

hi

cursive plank Feb 6, 2023, 12:13 AM

#

now, how would I make the timestamp show correctly?

#

do I use the markdown parser?

#

<t:1675638180:f>

#

actually nvm

#

i got a better solution

cursive plank Feb 6, 2023, 1:08 AM

#

working on a timezones plugin

#

(that is my own timezone btw)

#

i havent reached the part where you can change the timezone

cedar marsh Feb 6, 2023, 2:35 AM

#

How do I fix the react components debugger again?
I remember Ven or some other dev saying you have to delete a folder to make it actually work a while back, but I can't find it

cursive plank Feb 6, 2023, 2:46 AM

#

I just open my browser to use the react dev tools

#

Kinda inconvenient but it works all the time

#

Although, it might be just Firefox, but the react dev tools are showing errors every second

#

So they are a pain

cedar marsh Feb 6, 2023, 3:08 AM

#

My firefox says discord isn't using react

#

found the thing

#

but that seems to have just entirely removed react devtools from my client, even following a restart

#

disabling, restarting, enabling, restarting fixed it

celest hound Feb 6, 2023, 7:46 PM

#

Hello, i'm currently trying to develop a plugin for the Vencord platform that permits our application Cider to use the "Listening" activity type and forces the application id to also use the Spotify progress bar UI as its more suitable for music purposes.

However, i'm somewhat caught up amidst the the webpack mess that is Discord client code, is there any efficient way to intercept a RPC websocket request to apply a custom activity type on receive?

Any help would be greatly appreciated!

#

dull magnet Feb 6, 2023, 7:51 PM

#

you can just dispatch custom events

#

as in don't use native rich presence

#

do it urself then manually dispatch appropriate SET_ACTIVITY events

#

see the lastfm plugin for how to dispatch those events

#

you could run ur own websocket server via cider then connect to it with the plugin and set the activity

celest hound Feb 6, 2023, 7:54 PM

#

Noted, so there's no efficient way to intercept then?

dull magnet Feb 6, 2023, 7:54 PM

#

or patch the handler for SET_ACTIVITY

#

both work

celest hound Feb 6, 2023, 7:54 PM

#

Ah

dull magnet Feb 6, 2023, 7:54 PM

#

search for SET_ACTIVITY:function and you'll likely find it

celest hound Feb 6, 2023, 7:54 PM

#

Awesome will do thanks!

dull magnet Feb 6, 2023, 7:54 PM

#

if it doesn't do it omit the function

#

you can search all of their sources by opening devtools then hitting ctrl shift f

celest hound Feb 6, 2023, 7:55 PM

#

Gotcha.

dull magnet Feb 6, 2023, 7:55 PM

#

ska_capoonod if u get stuck and need more pointers just let me know

celest hound Feb 6, 2023, 7:55 PM

#

Thanks! I will.

cedar olive Feb 6, 2023, 8:10 PM

#

dull magnet search for `SET_ACTIVITY:function` and you'll likely find it

@celest hound if you want to do this, search for this nonzero pid required instead and scroll up till you see handler:function, that's your handler for when a RPC websocket emits a SET_ACTIVITY

green vessel Feb 6, 2023, 8:10 PM

#

I have similar code, I'll get it in a bit

celest hound Feb 6, 2023, 8:10 PM

#

cedar olive <@191621342473224192> if you want to do this, search for this `nonzero pid requi...

Huh, interesting.

cedar olive Feb 6, 2023, 8:10 PM

#

cedar olive <@191621342473224192> if you want to do this, search for this `nonzero pid requi...

from there you can patch and do any manipulation you want to do with it

green vessel Feb 6, 2023, 8:10 PM

#

I change the application name, u can just adapt it to change type instead

celest hound Feb 6, 2023, 8:10 PM

#

That'd be awesome!!

cedar olive Feb 6, 2023, 8:10 PM

#

celest hound Feb 6, 2023, 8:10 PM

#

Thanks for all the help.

cedar olive Feb 6, 2023, 8:11 PM

#

no prob!

green vessel Feb 6, 2023, 8:15 PM

#

if you have this patch ```ts
{
find: '.displayName="LocalActivityStore"',
replacement: {
match: /LOCAL_ACTIVITY_UPDATE:function((\i)){/,
replace: "$&$self.patchActivity($1.activity);",
}
}

you can then have this function ```ts
patchActivity(activity: any) {
    if (activity.application_id == "<whatever id you want>")
        activity.type = 2; /* LISTENING type */
}

celest hound Feb 6, 2023, 8:15 PM

#

Oh sweet!

#

That makes things really easy.

green vessel Feb 6, 2023, 8:16 PM

#

do note that the application id is a string, not a number

#

although yeah actually js wouldnt care lol

dull magnet Feb 6, 2023, 8:17 PM

#

their api might

green vessel Feb 6, 2023, 8:17 PM

#

you only need to compare

celest hound Feb 6, 2023, 8:17 PM

#

guess we'll find out.

dull magnet Feb 6, 2023, 8:19 PM

#

oh wait application id

#

i thought u meant type

#

yeah application ids are strings because ids are too large to fit in 32 bit integers

#

and js loses precision after 32 bits

celest hound Feb 6, 2023, 8:19 PM

#

Sounds about right.

cedar olive Feb 6, 2023, 8:44 PM

#

#

spotify seems different

delicate totem Feb 6, 2023, 8:46 PM

#

cedar olive

WHO IS THIS

#

WHO IS DOING THIS PLUGIN

#

WHO

cedar olive Feb 6, 2023, 8:46 PM

#

why lol

delicate totem Feb 6, 2023, 8:46 PM

#

BECAUSE

#

I’VE WANTED A PLUGIN TO DO THIS FOR SO LONG

#

PAIN

cedar olive Feb 6, 2023, 8:47 PM

#

this is what you need to fake it

#

delicate totem Feb 6, 2023, 8:47 PM

#

HELL

cedar olive Feb 6, 2023, 8:47 PM

#

type has to be LISTENING
name has to be Spotify
gotta have start and end timestamps
party id must include spotify:

delicate totem Feb 6, 2023, 8:47 PM

#

I know how to do it

#

I just can’t code

dull magnet Feb 6, 2023, 8:48 PM

#

cedar olive

LOL

#

F so it has to be spotify

cedar olive Feb 6, 2023, 8:48 PM

#

yeah

#

😔

#

if only the name check didn't exist

celest hound Feb 6, 2023, 9:02 PM

#

green vessel if you have this patch ```ts { find: '.displayName="LocalActivityStore"', ...

Doesn't seem to be functioning as it should I don't believe.

#

Not seeing any effect.

#

Tested it without the if, still appears to send the "Playing" activity type instead.

#

Discord DevTools shows 0.

#

just sanity checking

#

dont think im doing anything wrong but if I am do lmk

dull magnet Feb 6, 2023, 9:19 PM

#

did u enable it?

green vessel Feb 6, 2023, 9:19 PM

#

you should do appIds.includes(activity.application_id)

celest hound Feb 6, 2023, 9:19 PM

#

in plugins yeah

green vessel Feb 6, 2023, 9:19 PM

#

not the opposite

dull magnet Feb 6, 2023, 9:19 PM

#

yeah youre checking whether a string includes an array

#

blbctscrd

celest hound Feb 6, 2023, 9:19 PM

#

godwhy

#

knew it

celest hound Feb 6, 2023, 9:24 PM

#

green vessel you should do appIds.includes(activity.application_id)

alright can confirm that wasn't it

#

(thank god)

#

dull magnet Feb 6, 2023, 9:26 PM

#

activity.activities[0].application_id

green vessel Feb 6, 2023, 9:26 PM

#

thats activity store

dull magnet Feb 6, 2023, 9:26 PM

#

oh fair

#

but check that activity is actually a flat activity

green vessel Feb 6, 2023, 9:27 PM

#

idk my status is working

#

and it patches name like this

#

u love

celest hound Feb 6, 2023, 9:28 PM

#

not sure

dull magnet Feb 6, 2023, 9:28 PM

#

any errors in console?

celest hound Feb 6, 2023, 9:28 PM

#

Not seeing any no.

#

green vessel Feb 6, 2023, 9:29 PM

#

I mean did u rebuild and restart after u updated plugin

celest hound Feb 6, 2023, 9:29 PM

#

yeah

#

im using watch and the restart client button in the vencord tab

#

yeah it doesn't even update the name

#

#

pretty sure im f*ing something up.

#

not sure where

green vessel Feb 6, 2023, 9:37 PM

#

if u want

celest hound Feb 6, 2023, 9:38 PM

#

ill double check my stuff

celest hound Feb 6, 2023, 9:45 PM

#

green vessel if u want

#

got something

green vessel Feb 6, 2023, 9:45 PM

#

oh

#

your plugin name shouldn't have spaces

celest hound Feb 6, 2023, 9:46 PM

#

godwhy

#

of course

#

i swear if everything starts working

green vessel Feb 6, 2023, 9:46 PM

#

epicly trolled

celest hound Feb 6, 2023, 9:46 PM

#

imma cry from laughter

green vessel Feb 6, 2023, 9:46 PM

#

how did u not have that error before though

celest hound Feb 6, 2023, 9:46 PM

#

i have not a clue.

#

now it started whining though.

cedar olive Feb 6, 2023, 9:47 PM

#

hmmm

dull magnet Feb 6, 2023, 9:47 PM

#

u can still have spaces but then u cant use $self

cedar olive Feb 6, 2023, 9:47 PM

#

should I make custom rpc support this

dull magnet Feb 6, 2023, 9:47 PM

#

mayb

green vessel Feb 6, 2023, 9:47 PM

#

I will pr plugin name sanity check

cedar olive Feb 6, 2023, 9:47 PM

#

it's just custom activity type 1

celest hound Feb 6, 2023, 9:48 PM

#

nope not it

#

godwhy

#

no error this time though

green vessel Feb 6, 2023, 9:49 PM

#

plugin names must match ([A-Z][a-z]*)+ (fuck numbers)

celest hound Feb 6, 2023, 9:49 PM

#

noted

#

#

worked

#

lets goo

green vessel Feb 6, 2023, 9:50 PM

#

(no dont take that seriously)

celest hound Feb 6, 2023, 9:50 PM

#

wait is that playback bar capable of being patched to specific app id's?

#

this btw

cedar olive Feb 6, 2023, 9:50 PM

#

only users with vencord will be able to see the playback bar

celest hound Feb 6, 2023, 9:51 PM

#

yeah i know that part

#

but can I only do it for a certain app id?

cedar olive Feb 6, 2023, 9:51 PM

#

yeah

#

give me a sec

celest hound Feb 6, 2023, 9:51 PM

#

awesome thanks

cedar olive Feb 6, 2023, 9:59 PM

#

@celest hound btw dont do spaces on your plugin name

celest hound Feb 6, 2023, 9:59 PM

#

yeah figured that out

#

the hard and grueling way

cedar olive Feb 6, 2023, 10:00 PM

#

grrr it's gonna break the other plugin

#

adding a patch there

celest hound Feb 6, 2023, 10:01 PM

#

godwhy

cedar olive Feb 6, 2023, 10:01 PM

#

well

#

you could tell your users to enable the TimeBarAllActivities plugin

green vessel Feb 6, 2023, 10:01 PM

#

which plugin

cedar olive Feb 6, 2023, 10:01 PM

#

TimeBarAllActivities

green vessel Feb 6, 2023, 10:01 PM

#

oh

cedar olive Feb 6, 2023, 10:01 PM

#

#

adding a patch there makes it not match

#

cuz more than 50 chars

green vessel Feb 6, 2023, 10:02 PM

#

patch the patch

cedar olive Feb 6, 2023, 10:02 PM

#

cedar olive you could tell your users to enable the TimeBarAllActivities plugin

enabling it you make your bar work

green vessel Feb 6, 2023, 10:02 PM

#

trolley

dull magnet Feb 6, 2023, 11:15 PM

#

btw u can also add a custom component to ur plugins about page @celest hound

#

settingsAboutComponent

celest hound Feb 6, 2023, 11:15 PM

#

oh

dull magnet Feb 6, 2023, 11:15 PM

#

if u wanna have link and stuff

celest hound Feb 6, 2023, 11:15 PM

#

didnt know that

#

yeah ill add that

#

sounds good

celest hound Feb 6, 2023, 11:28 PM

#

dull magnet if u wanna have link and stuff

#

Better?

#

(yes i caught the typo lool)

delicate totem Feb 7, 2023, 1:18 AM

#

cedar olive should I make custom rpc support this

make custom RPC support spotify trolley

cedar olive Feb 7, 2023, 1:19 AM

#

wdym

delicate totem Feb 7, 2023, 1:19 AM

#

wdym what do I mean

cedar olive Feb 7, 2023, 1:19 AM

#

like support a fake playbar?

delicate totem Feb 7, 2023, 1:19 AM

#

yeah

#

trolley

cedar olive Feb 7, 2023, 1:19 AM

#

maybe

#

just have to add spotify party id

delicate totem Feb 7, 2023, 1:22 AM

#

celest hound

this would genuinely be a useful plugin if you make it more general (aka allowing any ID and making it possible to use other presence types other than "listening")

cedar olive Feb 7, 2023, 1:22 AM

#

there's already a plugin that does that

delicate totem Feb 7, 2023, 1:22 AM

#

what

cedar olive Feb 7, 2023, 1:22 AM

#

TimeBarAllActivities

delicate totem Feb 7, 2023, 1:23 AM

#

no what

#

that just adds a timebar

#

I'm saying changing the presence type of presences

cedar olive Feb 7, 2023, 1:23 AM

#

oh

#

me dumb

celest hound Feb 7, 2023, 1:23 AM

#

delicate totem this would genuinely be a useful plugin if you make it more general (aka allowin...

maybe something I could make

delicate totem Feb 7, 2023, 1:24 AM

#

it probably wouldn't be that hard in all honesty

green vessel Feb 7, 2023, 1:24 AM

#

I mean I could merge my activityRenamer with this

celest hound Feb 7, 2023, 1:24 AM

#

yeah

delicate totem Feb 7, 2023, 1:24 AM

#

green vessel I mean I could merge my activityRenamer with this

YES

celest hound Feb 7, 2023, 1:24 AM

#

few settings options

#

and what not

delicate totem Feb 7, 2023, 1:24 AM

#

I would love to use that

delicate totem Feb 7, 2023, 3:54 AM

#

@celest hound do you mind if I give an attempt at editing your code to make it be able to be used more generally?

celest hound Feb 7, 2023, 3:54 AM

#

delicate totem <@191621342473224192> do you mind if I give an attempt at editing your code to m...

that's fine

delicate totem Feb 7, 2023, 3:54 AM

#

alrighty

covert nimbus Feb 7, 2023, 6:16 AM

#

cedar olive should I make custom rpc support this

i was hesitant to add that because discord is incredibly consistent when it comes to RPC, but if it's requested i can give it a shot

cedar olive Feb 7, 2023, 10:50 AM

#

I already made a pr lol

cedar olive Feb 7, 2023, 12:02 PM

#

covert nimbus i was hesitant to add that because discord is incredibly consistent when it come...

though wdym incredible consistent?

covert nimbus Feb 7, 2023, 12:05 PM

#

cedar olive though wdym incredible consistent?

your rpc shows for yourself and only yourself if it's invalid, for example

cedar olive Feb 7, 2023, 12:05 PM

#

ah

#

I think I will add a desc explaining what's needed to get a streaming rpc working

#

the minimum discord requires for it

cedar olive Feb 7, 2023, 12:06 PM

#

cedar olive

same for this

foggy sierra Feb 7, 2023, 9:27 PM

#

uhh...?

cedar olive Feb 7, 2023, 11:13 PM

#

@dull magnet we will add displayName filter

green vessel Feb 7, 2023, 11:17 PM

#

real

cedar olive Feb 7, 2023, 11:17 PM

#

it's better than using byProps

green vessel Feb 7, 2023, 11:18 PM

#

can't wait for discord to get rid of displayNames completely trolley

cedar olive Feb 7, 2023, 11:18 PM

#

that would break our patches anyways

#

lots of finds depend on display names

#

also

#

they wont

#

#

cuz of this

maiden ruin Feb 8, 2023, 3:56 AM

#

Hi I was wondering how to use genPluginList?

#

I ran it through node but it said Vencord isn't defined

dull magnet Feb 8, 2023, 4:02 AM

#

dont run it through node?

#

what are u trying to run it for

maiden ruin Feb 8, 2023, 4:03 AM

#

I'm just trying to get all the plugins installed

dull magnet Feb 8, 2023, 4:03 AM

#

u paste it in discord devtools

maiden ruin Feb 8, 2023, 4:03 AM

#

ah

#

tysm

delicate totem Feb 8, 2023, 4:04 AM

#

cedar olive this is what you need to fake it

would it be possible to add the partyid to an already existing presence?

delicate totem Feb 8, 2023, 4:21 AM

#

oop

#

nevermind

#

was able to set the partyid

#

WAIT FUCK

delicate totem Feb 8, 2023, 5:04 AM

#

how would you fetch user id through a vencord plugin?

trail ginkgo Feb 8, 2023, 5:04 AM

#

like the id of the current logged in user

delicate totem Feb 8, 2023, 5:04 AM

#

yeah

trail ginkgo Feb 8, 2023, 5:05 AM

#

UserStore.getCurrentUser().id

delicate totem Feb 8, 2023, 5:05 AM

#

thank you

trail ginkgo Feb 8, 2023, 5:05 AM

#

npnp

green vessel Feb 8, 2023, 5:07 AM

#

pnpm

trail ginkgo Feb 8, 2023, 5:07 AM

#

TRU

green vessel Feb 8, 2023, 5:07 AM

#

upnp

trail ginkgo Feb 8, 2023, 5:07 AM

#

fals.e

#

failse.

green vessel Feb 8, 2023, 5:07 AM

#

yarrn

trail ginkgo Feb 8, 2023, 5:07 AM

#

unless u mean networking

#

then so true

green vessel Feb 8, 2023, 5:08 AM

#

networking yes

trail ginkgo Feb 8, 2023, 5:08 AM

#

upnp is so real

green vessel Feb 8, 2023, 5:08 AM

#

what is other upnp

trail ginkgo Feb 8, 2023, 5:08 AM

#

i ignored the universal part

#

and thought of yarn pnp

green vessel Feb 8, 2023, 5:08 AM

#

oh

#

yarn pnp kinda promising but I feel impl is possibly terrible

trail ginkgo Feb 8, 2023, 5:10 AM

#

its kinda silly to commit your packages imo

#

typescript doesnt support it i dont think

#

and a lot of packages break because it forces them to be read-only

green vessel Feb 8, 2023, 5:13 AM

#

wait wdym commit

trail ginkgo Feb 8, 2023, 5:16 AM

#

basically pnp monkeypatches node's module resolution system

#

to instead of looking at like node_modules

#

it just checks .yarn/cache in the pwd

#

which has zips of each package+version installed

#

and the idea is that u commit those zips and the pnp script

green vessel Feb 8, 2023, 5:17 AM

#

that's just node_modules all over

#

what

trail ginkgo Feb 8, 2023, 5:17 AM

#

yea its a little silly

green vessel Feb 8, 2023, 5:18 AM

#

I thought it was like

trail ginkgo Feb 8, 2023, 5:18 AM

#

we do a little polluting git history

green vessel Feb 8, 2023, 5:18 AM

#

global

trail ginkgo Feb 8, 2023, 5:18 AM

#

you can make it global if u want

#

but then its only zero install if u already have them installed

#

and then you do have to install packages

delicate totem Feb 9, 2023, 3:46 AM

#

Is there an event for a presence update?

green vessel Feb 9, 2023, 3:52 AM

#

delicate totem Is there an event for a presence update?

LOCAL_ACTIVITY_UPDATE guh

delicate totem Feb 9, 2023, 3:53 AM

#

oh yeah

#

I'm stupid

#

thanks <3

#

wait how do I fetch presence data?

green vessel Feb 9, 2023, 4:06 AM

#

qhar

#

what data

delicate totem Feb 9, 2023, 1:34 PM

#

green vessel what data

details, state, and large image text

#

of I guess assets might be the better word, since large image text is under that

delicate totem Feb 9, 2023, 4:09 PM

#

nvm, got it

trail ginkgo Feb 10, 2023, 1:22 PM

#

i cant get the data from this form with FormData

#

https://codepen.io/vap0r1ze/pen/oNMrKXO

#

does anyone have a clue why

#

if you click show data its just an empty object

trail ginkgo Feb 10, 2023, 2:52 PM

#

oh im silly

#

{ ...formData } => Object.fromEntries(formData.entries())

maiden ruin Feb 10, 2023, 11:19 PM

#

Is there a way to dismiss the notification before the timer runs out via the console?

dull magnet Feb 10, 2023, 11:32 PM

#

no

#

u can rightclick the notificiation to close it

maiden ruin Feb 11, 2023, 12:38 AM

#

dull magnet u can rightclick the notificiation to close it

ah cool ty

rocky compass Feb 11, 2023, 2:06 AM

#

not sure if this is the right channel, but does anyone know of any extensions or projects that have the same ability to patch javascript before it's loaded (/ in real time)? I know about userscripts, but what I want would only work being able to patch the js before it's loaded

#

a tiny bit of searching in the discord finds a few old conversations about some related stuff, but no actual projects

#

(if need be i can try to just extract the important parts from vencord and make my own, but i'd rather not if I don't have to)

dull magnet Feb 11, 2023, 2:15 AM

#

whats ur use case

#

@rocky compass

rocky compass Feb 11, 2023, 2:23 AM

#

I'm trying to make some changes (like you might usually make with a user script) to a site I use, but it uses webpack and everything is minified and really hard to hook into. Specifically, I'm trying to mess with some requests it sends, and theoretically I could overwrite the fetch function or something like that to be able to modify it, but that kind of edit is a lot more difficult to make than it would be to do something like Vencord does

#

I could use a proxy of some kind, but I don't want to have to start it with the browser and deal with everything else that comes with that

#

@dull magnet

dull magnet Feb 11, 2023, 2:28 AM

#

rocky compass I'm trying to make some changes (like you might usually make with a user script)...

how so?

#

just monkey patch

rocky compass Feb 11, 2023, 2:28 AM

#

what do you mean

rocky compass Feb 11, 2023, 2:29 AM

#

dull magnet just monkey patch

or in what way / using what

dull magnet Feb 11, 2023, 2:30 AM

#

find what code sends request

rocky compass Feb 11, 2023, 2:30 AM

#

oh, do you just mean overwriting functions with a modified version and stuff?

#

theoretically I could do that, but because of scope stuff, that becomes a lot more annoying

dull magnet Feb 11, 2023, 2:33 AM

#

okay

#

i might write a blogpost about how to patch webpack

rocky compass Feb 11, 2023, 2:33 AM

#

if you do, please let me know

#

even if I could just monkeypatch it, this way also seems a lot more interesting and fun

#

btw, do you know how the userscript does it? does it just monkeypatch somehow? (how is it compiled / where is the src?)

dull magnet Feb 11, 2023, 3:11 AM

#

its just the same code

rocky compass Feb 11, 2023, 3:18 AM

#

dull magnet its just the same code

then this kind of relates to vencord for web as a whole, not just the userscript version, but how does it actually modify the code? I assumed the extension modifies the response from the server somehow (or blocks it and loads its own patched ver), but that doesn't seem possible with a userscript

dull magnet Feb 11, 2023, 3:22 AM

#

monkeypatching

rocky compass Feb 11, 2023, 3:24 AM

#

dull magnet monkeypatching

I thought monkeypatching is just replacing the functions with a modified version / a 'proxy', but vencord modifies the actual text code, so how does it 'inject' that?

#

sorry for all the questions, i'm just trying to get my head around how vencord works

dull magnet Feb 11, 2023, 3:30 AM

#

webpack uses chunking

#

the way it works is that there's a global variable webpackChunkdiscord_app

#

you can monkey patch webpackChunkdiscord_app.push to intercept chunks being pushed

#

and modify those chunks before their code is ran

#

https://github.com/Vendicated/Vencord/blob/main/src/webpack/patchWebpack.ts

GitHub

Vencord/patchWebpack.ts at main · Vendicated/Vencord

The cutest Discord client mod. Contribute to Vendicated/Vencord development by creating an account on GitHub.

rocky compass Feb 11, 2023, 3:32 AM

#

oh, that's pretty cool

#

thanks, I'll look into that

rocky compass Feb 11, 2023, 4:19 AM

#

it turns out you can call toString() on a function. I'm going to go re-evaluate my life choices

dull magnet Feb 11, 2023, 4:24 AM

#

lol

foggy mason Feb 11, 2023, 5:10 AM

#

you'll most likely have problems with inline-eval (or something similar) not being in the csp if you go down the inline patch route, so you'll either need to modify it or do inline patching a dif way (intercepting web requests)

rocky compass Feb 11, 2023, 2:15 PM

#

foggy mason you'll most likely have problems with inline-eval (or something similar) not bei...

actually, for whatever reason, the site I'm using doesn't seem to have it blocked, so hopefully I won't have to deal with that

woven lion Feb 11, 2023, 4:30 PM

#

my react devtools are broken

#

NOOOOOOOWHYYY

dull magnet Feb 11, 2023, 4:31 PM

#

woven lion my react devtools are broken

are they stuck on loading?

woven lion Feb 11, 2023, 4:32 PM

#

yeah

#

stable and canary

dull magnet Feb 11, 2023, 4:32 PM

#

#🧩-plugin-development message

woven lion Feb 11, 2023, 4:33 PM

#

hm it houghtt i did that alreayd

#

weird

dull magnet Feb 11, 2023, 4:36 PM

#

https://github.com/facebook/react/issues/25843#issuecomment-1406766561

GitHub

[DevTools Bug]: Electron support broken in 4.27 · Issue #25843 · fa...

Website or app Electron.js Repro steps React devtools 4.27 no longer works in Electron[1] because chrome.scripting isn't implemented, which it started using due to the manifest v3 upgrade: ...

empty jacinth Feb 11, 2023, 6:50 PM

#

ayo not sure if this is the right channel for this, but is it okay for me to PR some improvements to LastFMRichPresence?

#

@green vessel is the credited author of it

green vessel Feb 11, 2023, 6:51 PM

#

hello

#

well u can pr anything

#

what do you plan on changing?

empty jacinth Feb 11, 2023, 6:55 PM

#

namely formatting stuff

empty jacinth Feb 11, 2023, 7:40 PM

#

green vessel what do you plan on changing?

https://i.imgur.com/X7QTDqS.png

Imgur

#

I just found out Discord shows the large image text if the activity type is listening. 😛

covert nimbus Feb 11, 2023, 7:40 PM

#

wait wtf why is it purple

empty jacinth Feb 11, 2023, 7:40 PM

#

isn't it normally purple?

covert nimbus Feb 11, 2023, 7:41 PM

#

empty jacinth I just found out Discord shows the large image text if the activity type is list...

yeah i ran into that when testing CustomRPC and it is annoying af

covert nimbus Feb 11, 2023, 7:41 PM

#

empty jacinth isn't it normally purple?

don't think so

#

i may be wrong

#

hold on

empty jacinth Feb 11, 2023, 7:41 PM

#

maybe based on user profile colors?

#

on that note, the option to show it as playing doesn't work, and i have no idea why. thonk

covert nimbus Feb 11, 2023, 7:42 PM

#

covert nimbus Feb 11, 2023, 7:42 PM

#

empty jacinth maybe based on user profile colors?

perchance

covert nimbus Feb 11, 2023, 7:42 PM

#

empty jacinth on that note, the option to show it as playing doesn't work, and i have no idea ...

:thonk:

empty jacinth Feb 11, 2023, 7:43 PM

#

btw, the hideAlbumName = !trackData.album is redundant, because last.fm API always provides placeholder album art if there's no album art.

covert nimbus Feb 11, 2023, 7:43 PM

#

nice

#

and i just realised this is #🧩-plugin-development not #🧊-off-topic-iceman-only

green vessel Feb 11, 2023, 7:43 PM

#

.album is the album name

steady whaleBOT Feb 11, 2023, 7:43 PM

#

Info about Various Artists - My Name Is Earl – The Album for StackMachine

Supporters can see the date they first listened to an album. View all supporter perks here.

Statistics

312 listeners
1148 global plays
0 plays by you
0 by you last week

Server stats

No listeners in this server.

Tracks

East Bound and Down — 2:46
The Weight — 4:58
One Time One Night
Bust a Move — 4:24
Livin' Thing — 3:39
It Takes Two
Smoke! Smoke! Smoke! (That Cigarette) — 3:02
Gimme Three Steps — 4:30
Joy
Amos Moses — 2:19
Instant Karma — 3:35
What Goes Around - My Name Is Earl Theme - Vocal version — 3:09
99 Red Balloons — 3:37

covert nimbus Feb 11, 2023, 7:43 PM

#

oh well

covert nimbus Feb 11, 2023, 7:43 PM

#

steady whale

trolley

green vessel Feb 11, 2023, 7:44 PM

#

I do that to hide the album name if the track name is the same

#

cuz that's very common for singles

empty jacinth Feb 11, 2023, 7:44 PM

#

wait i quoted the wrong code lmao

green vessel Feb 11, 2023, 7:44 PM

#

j

empty jacinth Feb 11, 2023, 7:44 PM

#

imageUrl: (trackData.image || [])

green vessel Feb 11, 2023, 7:46 PM

#

oh it doesnt sometimes

#

lastfm api is very silly

empty jacinth Feb 11, 2023, 7:48 PM

#

https://i.imgur.com/7eHpZ9k.png

Imgur

#

do you know any songs in particular that don't gave placeholder album art?

empty jacinth Feb 11, 2023, 7:51 PM

#

covert nimbus and i just realised this is <#1032770730703716362> not <#1015060231060983891>

☝️ 😄

green vessel Feb 11, 2023, 7:51 PM

#

um

covert nimbus Feb 11, 2023, 7:51 PM

#

amazing

empty jacinth Feb 11, 2023, 7:52 PM

#

did you provide your username and API key in settings?

green vessel Feb 11, 2023, 7:52 PM

#

yeah guh

austere gulch Feb 11, 2023, 7:55 PM

#

h

green vessel Feb 11, 2023, 8:05 PM

#

idk a track that has missing fallback image rn but I've seen the plugin show it's own fallback multiple times so I know it happens

empty jacinth Feb 11, 2023, 8:06 PM

#

might make sense to provide your own fallback then, so the album art shows up correctly.

green vessel Feb 11, 2023, 8:07 PM

#

yeah it does that already

empty jacinth Feb 11, 2023, 8:09 PM

#

well it replaces it with the last.fm logo

#

btw we should probably move to the thread

#

https://discord.com/channels/1015060230222131221/1074054324998635540

green vessel Feb 11, 2023, 8:10 PM

#

threads will explod

empty jacinth Feb 11, 2023, 8:10 PM

#

???

#

i was thinking upload this as an app asset tho: https://lastfm.freetls.fastly.net/i/u/174s/2a96cbd8b46e442fc41c2b86b821562f.png

empty jacinth Feb 11, 2023, 8:25 PM

#

empty jacinth on that note, the option to show it as playing doesn't work, and i have no idea ...

okay suddenly it works? thonk

empty jacinth Feb 11, 2023, 8:46 PM

#

https://github.com/Vendicated/Vencord/pull/483

GitHub

Update LastFM plugin by RuiNtD · Pull Request #483 · Vendicated/Ven...

Reformat the results
Simplify some code
Add some sanity checks

foggy mason Feb 11, 2023, 9:57 PM

#

personally i would make buttons a constant because it's never redefined and i would add brackets around the if statement so its consistent with the rest of the code but im just being picky lol

dull magnet Feb 11, 2023, 9:59 PM

#

i hate you github

empty jacinth Feb 11, 2023, 10:00 PM

#

foggy mason personally i would make buttons a constant because it's never redefined and i wo...

I always forget that arrays aren't redefined when you push to them 😂

dull magnet Feb 11, 2023, 10:00 PM

#

https://github.com/community/community/discussions/4586

GitHub

Allow to request a pull request review from non-organization member...

At the moment it is only possible to request reviews from organization members or external collaborators that have been added to the repository. However, numerous times, while working on pull reque...

#

FUCK YOU GITHUB

foggy mason Feb 11, 2023, 10:02 PM

#

empty jacinth I always forget that arrays aren't redefined when you push to them 😂

const just means a variable can't be redefined, but you can still mutate it all you want lol

empty jacinth Feb 11, 2023, 10:02 PM

#

yeah i know. i just forgor. 😂

foggy mason Feb 11, 2023, 10:02 PM

#

wrong emoji

#

💀

empty jacinth Feb 11, 2023, 10:05 PM

#

foggy mason personally i would make buttons a constant because it's never redefined and i wo...

tbh tho if you want to enforce code styling, you should probably add smth like prettier.

foggy mason Feb 11, 2023, 10:05 PM

#

vencord has way looser code style enforcement than i would have

#

i dont think it has any

#

also prettier sucks vscode default formatter is leagues better

dull magnet Feb 11, 2023, 10:06 PM

#

prettier is horrid

#

i don't enforce style much because it doesn't matter + people contributing their own plugins should be able to be fairly free to choose imo, i'm not a fan of forcing very opiniated rules for such stuff

#

i only added a baseset of sanity checks

green vessel Feb 11, 2023, 10:10 PM

#

ven will hop on dprint

green vessel Feb 11, 2023, 10:12 PM

#

dull magnet https://github.com/community/community/discussions/4586

simple fix just give me push access

empty jacinth Feb 11, 2023, 10:26 PM

#

Hmm. I need to do some more testing with LastFM PR. I don't think the try catch I added is even working?

dull magnet Feb 11, 2023, 10:27 PM

#

when do you intend it to throw?

#

fetch() does not throw on failed requests

empty jacinth Feb 11, 2023, 10:29 PM

#

meowneutral

#

bruh i hate javascript lmao

dull magnet Feb 11, 2023, 10:29 PM

#

if you want it to throw on failed requests, you need something like

const res = await fetch(...)
if (!res.ok) throw new Error(`${res.status}: ${res.statusMessage}\n${await res.text().catch(() => null) || "Unknown Error"}`);
const json = await res.json();

#

it's that way in most http implementations and most languages so idk why you'd blame javascript

#

even when it responds with smth like 400 it might still give u more info in the body so having access to the response object is useful

empty jacinth Feb 11, 2023, 10:33 PM

#

statusText btw, not statusMessage

empty jacinth Feb 11, 2023, 10:57 PM

#

Also turns out the API returns an error message, so I'm now throwing that instead of checking res.ok

#

@dull magnet requesting re-review 🙂

dull magnet Feb 11, 2023, 11:12 PM

#

you should still use res.ok

empty jacinth Feb 11, 2023, 11:24 PM

#

eh, I doubt it will fail unless the user lacks internet

#

even then, it'll still catch if there's a non-API error.

potent fox Feb 12, 2023, 12:02 AM

#

@dull magnet finish

green vessel Feb 12, 2023, 4:13 AM

#

dzshn:dots/ (main*) % curl -sSL 'https://ws.audioscrobbler.com/2.0/?method=user.getrecenttracks&api_key=<snip>&user=dzshn&limit=1&format=json' | jq '.recenttracks.track[0] | [.name, .album["#text"], .artist["#text"], .image]'
[
  "ROBBING CHASE BANK WITH A MOP",
  "",
  "Wells Fargo",
  [
    {
      "size": "small",
      "#text": ""
    },
    {
      "size": "medium",
      "#text": ""
    },
    {
      "size": "large",
      "#text": ""
    },
    {
      "size": "extralarge",
      "#text": ""
    }
  ]
]

yop @empty jacinth

#

the urls r blank for that track

#

anyways I'll check ur pr soon

empty jacinth Feb 12, 2023, 5:04 AM

#

green vessel ``` dzshn:dots/ (main*) % curl -sSL 'https://ws.audioscrobbler.com/2.0/?method=u...

Okay. Any chance you can replace the large image placeholder with this for consistency? https://lastfm.freetls.fastly.net/i/u/174s/2a96cbd8b46e442fc41c2b86b821562f.png

green vessel Feb 12, 2023, 5:06 AM

#

does it rlly matter

#

last.fm logo makes more sense for me instead of their own placeholder on their website

empty jacinth Feb 12, 2023, 7:00 AM

#

green vessel last.fm logo makes more sense for me instead of their own placeholder on their w...

except that for the way I changed the code, it would show two lastfm logos.

#

https://lastfm.freetls.fastly.net/i/u/174s/c6f59c1e5e7240a4c0d427abd71f3dbb.jpg 🙂

#

for some reason the API returns the star for album art placeholder.

#

delicate totem Feb 12, 2023, 8:07 AM

#

not using fake spotify RPC smh

viral roost Feb 12, 2023, 12:40 PM

#

in the src folder

#

https://cdn.discordapp.com/emojis/762461727626756136.png?size=48

empty jacinth Feb 12, 2023, 4:55 PM

#

How did you install Vencord?

opal fern Feb 12, 2023, 4:59 PM

#

if you didnt install manually (which is omega unsupported) not much you can do relating to userplugins

empty jacinth Feb 13, 2023, 2:07 AM

#

Question. If I make a user plugin, is it possible to install node modules in the user plugin folder?

viral roost Feb 13, 2023, 5:27 AM

#

empty jacinth Question. If I make a user plugin, is it possible to install node modules in the...

no

#

plugins run within chromium, no node

empty jacinth Feb 13, 2023, 5:44 AM

#

But doesn't the build script bake in node modules?

#

Emphasis on modules, not on node

#

Node modules don't always require Node. A lot of them are designed to work on the web as well.

viral roost Feb 13, 2023, 6:24 AM

#

then no idea

#

plugins that depend on external libs install it asynchronously from a link

#

see plugins like InvisibleChat or ShikiCodeblocks

empty jacinth Feb 13, 2023, 6:25 AM

#

I'm going to assume that's ESM modules. I'll check in a second.

#

I have no idea what you mean by InvisibleChat doing that (all I see them downloading is a PNG asset), but for ShikiCodeblocks, it looks like the dependency is just included in Vencord itself.

viral roost Feb 13, 2023, 6:33 AM

#

looks like https://github.com/Vendicated/Vencord/blob/main/src/utils/dependencies.ts does what you are trying to achieve, if not then wait for someone that knows what they are doing

empty jacinth Feb 13, 2023, 6:36 AM

#

my understanding from this is that the only way i can do this in a user plugin is by adding a <script> into the webpage.

green vessel Feb 13, 2023, 12:40 PM

#

how can i find an app id for a rich presence

dull magnet Feb 13, 2023, 1:49 PM

#

empty jacinth my understanding from this is that the only way i can do this in a user plugin i...

no

#

look at what they just linked

#

but you can also just add node modules

empty jacinth Feb 13, 2023, 5:40 PM

#

Somehow I didn’t see the line at the bottom. lol

#

And how would I “just add node modules”? I’m making a user plugin, not one to be included in Vencord.

#

Would users need to pnpm i in the plug-in directory as well?

cedar olive Feb 13, 2023, 5:50 PM

#

user plugins are super unsupported

dull magnet Feb 13, 2023, 5:57 PM

#

ye

empty jacinth Feb 13, 2023, 6:51 PM

#

oof.

#

guess i'll just make a replugged plugin then

woven lion Feb 13, 2023, 7:13 PM

#

good luck

scarlet wedge Feb 15, 2023, 2:38 AM

#

🗿

magic sorrel Feb 15, 2023, 12:23 PM

#

@dull magnet i think gif collections is ready. review it when you're free

thanks

minor jolt Feb 15, 2023, 7:38 PM

#

how would i go about joining a voice channel in code ?

#

navigationrouter does "visit" the channel but does not actually join it

covert nimbus Feb 15, 2023, 8:21 PM

#

@minor jolt just did some testing

const whatever = findByProps("handleVoiceConnect");
whatever.handleVoiceConnect(
    {
        // ChannelStore is in webpack.Common
        channel: ChannelStore.getChannel("channel id as a string")
    }
);```
 should work

minor jolt Feb 15, 2023, 8:22 PM

#

damn man that works like a charm

#

tysm

covert nimbus Feb 15, 2023, 8:23 PM

#

np

#

i had to read discord source to find this

give me a bit of eye bleach

minor jolt Feb 15, 2023, 8:24 PM

#

i was trying different combinations of connect and voice in the search

#

but that one didn't hit my eye

covert nimbus Feb 15, 2023, 8:24 PM

#

this is where i found it

minor jolt Feb 15, 2023, 8:25 PM

#

my observation skills are near zero

#

any idea how to make it screenshare ?

covert nimbus Feb 15, 2023, 8:25 PM

#

uhh I do not

minor jolt Feb 15, 2023, 8:25 PM

#

back to the search it is

#

ty for the help

covert nimbus Feb 15, 2023, 8:25 PM

#

np

minor jolt Feb 15, 2023, 8:47 PM

#

apparently there is a handleGoLive function but findByProps doesn't pick it up

cedar marsh Feb 16, 2023, 3:01 AM

#

how difficult would it be to add the class .custom-theme-background to the root html?

#

or parse the existing CSS and remove the .custom-theme-background selector from all of it, replacing it with *

#

I am pretty close to replicating custom themes entirely with css, but some things require .custom-theme-background for their stuff

with my own css:

#

with the actual thing:
(note the scrollbars and folders)

#

adding theme-custom custom-theme-background theme-dark to the classlist of the root <html> perfectly matches the second screenshot

cedar olive Feb 16, 2023, 3:13 AM

#

if js is gonna be needed anyways you can just trick discord to let you use the real

cedar marsh Feb 16, 2023, 3:13 AM

#

part of what I want to do is choose custom gradients and theme params

cedar olive Feb 16, 2023, 3:14 AM

#

you should be able to just select the element using a query selector and add the class

#

unless discord remakes it, which would make the class disappear

cedar marsh Feb 16, 2023, 3:15 AM

#

discord redoes the html classlist every time you change a channel

#

I would've already written some openasar injected stuff otherwise

cedar olive Feb 16, 2023, 3:15 AM

#

but do they redo the root

cedar marsh Feb 16, 2023, 3:16 AM

#

no clue, honestly not sure where :root is in the dom

cedar olive Feb 16, 2023, 3:16 AM

#

no I mean the root html element

#

which you want to add the class to

cedar marsh Feb 16, 2023, 3:17 AM

#

the one at the very top of the dom, the one that says <html>

#

yeah thats the one I tried in the first place

cedar olive Feb 16, 2023, 3:17 AM

#

and they redo it?

cedar marsh Feb 16, 2023, 3:17 AM

#

yeah

cedar olive Feb 16, 2023, 3:18 AM

#

you can patch where discord puts their classes and add your own

cedar marsh Feb 16, 2023, 3:19 AM

#

I don't understand plugin dev that well. I am spoiled by mc modding where finding what I need to change is stupid easy because mojang provides the mappings to deobsfucate their code

cedar olive Feb 16, 2023, 3:20 AM

#

let me help you

cedar marsh Feb 16, 2023, 3:20 AM

#

alright

#

how do I start searching through the source code

cedar olive Feb 16, 2023, 3:21 AM

#

oh I'm gonna make the plugin for you

cedar marsh Feb 16, 2023, 3:21 AM

#

ah

cedar olive Feb 16, 2023, 3:21 AM

#

sorry I would help you understand if I had more time

cedar marsh Feb 16, 2023, 3:21 AM

#

no problem

cedar olive Feb 16, 2023, 3:23 AM

#

okay this is likely it

cedar marsh Feb 16, 2023, 3:23 AM

#

which component is that in?

#

Rr?

#

It has to be one of the rootish ones in the tree

cedar olive Feb 16, 2023, 3:23 AM

#

search for this (565e3) and scroll down

#

I will write you a patch real quick

#

what classes do you need?

cedar marsh Feb 16, 2023, 3:24 AM

#

cedar olive search for this (565e3) and scroll down

I feel so dumb

cedar olive Feb 16, 2023, 3:24 AM

#

include the parenthesis

cedar marsh Feb 16, 2023, 3:24 AM

#

cedar olive what classes do you need?

theme-custom custom-theme-background

cedar marsh Feb 16, 2023, 3:25 AM

#

cedar olive include the parenthesis

oh

#

yes I found it

#

alright, I think I can eventually figure this out

dull magnet Feb 16, 2023, 3:28 AM

#

cedar marsh how difficult would it be to add the class `.custom-theme-background` to the roo...

document.querySelector("html").classList.add("balls")

#

slap that in start of ur plugin

cedar olive Feb 16, 2023, 3:28 AM

#

/*
 * Vencord, a modification for Discord's desktop app
 * Copyright (c) 2022 Vendicated and contributors
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
*/

import { Devs } from "@utils/constants";
import definePlugin from "@utils/types";

export default definePlugin({
    name: "RootClassAdder",
    description: "Add classes to the root element of Discord.",
    authors: [Devs.Nuckyz],
    patches: [
        {
            find: '"theme-dark theme-amoled"',
            replacement: {
                match: /(?<=className:.+?{)/,
                replace: '"theme-custom custom-theme-background":true,',
            }
        }
    ]
});

#

here you go

cedar marsh Feb 16, 2023, 3:28 AM

#

dull magnet document.querySelector("html").classList.add("balls")

yes but they redo root classlist a lot

cedar marsh Feb 16, 2023, 3:29 AM

#

cedar olive ```ts /* * Vencord, a modification for Discord's desktop app * Copyright (c) 2...

thanks

dull magnet Feb 16, 2023, 3:29 AM

#

cedar marsh yes but they redo root classlist a lot

~~interval~~ MutationObserver is ur friend

but nookies already helped u so that's even better :P

cedar marsh Feb 16, 2023, 3:30 AM

#

dull magnet ~~interval~~ MutationObserver is ur friend but nookies already helped u so that...

mutationobserver makes me want to vomit

#

the new client themes experiment is objectively worse than the old one because it doesn't touch the values of --background-primary and the like

#

so now things that use those values directly are ugly

#

like my custom typing indicator

#

#

the old one directly changed those

cedar olive Feb 16, 2023, 3:32 AM

#

bruh

#

that's so bad

#

we use discord color vars for a lot of stuff

cedar marsh Feb 16, 2023, 3:33 AM

#

and the new one relies entirely on OVERLAYS implemented into the css that uses the vars

cedar olive Feb 16, 2023, 3:34 AM

#

incredibly horrible

cedar marsh Feb 16, 2023, 3:34 AM

#

I hate powershell with every inch of my soul

cedar olive Feb 16, 2023, 3:37 AM

#

lol

cedar marsh Feb 16, 2023, 3:39 AM

#

why is vencord based on tab depth 4?

#

aaa

#

can someone with real nitro figure out what css the new themes thing adds to settings?

#

turns out the css I found only covers the primary client

#

or someone just needs to develop a plugin equivalent to the old client themes plugin

cedar olive Feb 16, 2023, 3:48 AM

#

hmm

#

can you tell me a class that discord adds for their custom theme

#

I may be able to find the other ones

cedar marsh Feb 16, 2023, 3:52 AM

#

wait what?

#

oh

#

uh

cedar olive Feb 16, 2023, 3:55 AM

#

actually

#

idk it seems like it's just those 2 classes

#

#

theme-custom

cedar marsh Feb 16, 2023, 3:55 AM

#

I will dig through the css file then

cedar olive Feb 16, 2023, 3:55 AM

#

and they also added a css rule there

#

with the gradient colors

#

cedar marsh Feb 16, 2023, 3:56 AM

#

yeah

#

I got all that

#

its actually a lot

cedar olive Feb 16, 2023, 3:56 AM

#

.custom-theme-background {
  --custom-theme-background: something;
}

cedar marsh Feb 16, 2023, 3:56 AM

#

you need more than what fits in a discord message, and it doesn't cover the settings

📎 message.css

cedar olive Feb 16, 2023, 3:57 AM

#

skull

#

wait you can preview

cedar marsh Feb 16, 2023, 3:57 AM

#

yeah thats what I have been using

#

to figure all this out

#

I only have the middle teir nitro, the one they got rid of

cedar olive Feb 16, 2023, 3:58 AM

#

I will make you not able to leave the preview

#

so you can figure the rest of the css

dull magnet Feb 16, 2023, 3:58 AM

#

cedar marsh I hate powershell with every inch of my soul

u will install gnu coreutils

#

that's what I did

#

FubukiDance2

dull magnet Feb 16, 2023, 3:58 AM

#

cedar marsh why is vencord based on tab depth 4?

?

cedar marsh Feb 16, 2023, 3:58 AM

#

4 SPACES PER TAB

#

#

2 spaces is way better

dull magnet Feb 16, 2023, 3:59 AM

#

no lol

cedar marsh Feb 16, 2023, 4:00 AM

#

I'm still disgusted

cedar olive Feb 16, 2023, 4:18 AM

#

@cedar marsh lmao

#

preview a theme and restart your discord

#

the theme persists

#

discord so good

cedar marsh Feb 16, 2023, 4:19 AM

#

I can't get that to work

cedar olive Feb 16, 2023, 4:19 AM

#

are you previewing a gradient?

cedar marsh Feb 16, 2023, 4:19 AM

#

yeah

cedar olive Feb 16, 2023, 4:19 AM

#

dont do anything after clicking it

#

just restart with ctrl r

#

no?

cedar marsh Feb 16, 2023, 4:20 AM

#

no

cedar olive Feb 16, 2023, 4:20 AM

#

ok 1 sec then

cedar marsh Feb 16, 2023, 4:21 AM

#

cedar olive Feb 16, 2023, 4:21 AM

#

/*
 * Vencord, a modification for Discord's desktop app
 * Copyright (c) 2022 Vendicated and contributors
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
*/

import { Devs } from "@utils/constants";
import definePlugin from "@utils/types";

export default definePlugin({
    name: "Aaaaa",
    description: "",
    authors: [Devs.Nuckyz],
    patches: [
        {
            find: ".Messages.USER_SETTINGS_APPEARANCE_GRADIENT_THEME_TITLE",
            replacement: [
                {
                    match: /(?<=\.getGradientPreset\(\).{0,100},\i=)\i\[0\](?=.{0,50}useState)/g,
                    replace: "false",
                },
                {
                    match: /(?:\i\.)?\i\.isPreview/g,
                    replace: "false"
                }
            ]
        }
    ]
});

#

use this

#

one of those made the thing persist lol

#

did it work?

cedar marsh Feb 16, 2023, 4:25 AM

#

no

#

clicking anywhere in discord yeets the active theme

cedar olive Feb 16, 2023, 4:26 AM

#

ik

#

restart your discord with it applied

#

and dont open the preview menu

cedar marsh Feb 16, 2023, 4:27 AM

#

lmao wtf

#

ok that works

cedar olive Feb 16, 2023, 4:28 AM

#

kekw

cedar marsh Feb 16, 2023, 4:28 AM

#

so the new client themes just don't touch settings at all?

cedar olive Feb 16, 2023, 4:28 AM

#

eh idk completely

#

but I changed some isPreviews to false

#

and that made the theme kinda persist

cedar marsh Feb 16, 2023, 4:29 AM

#

ah

#

this new client theme experiment sucks so much ass though
it doesn't touch vars

#

I need a version of discord with the old one so I can recreate it

cedar olive Feb 16, 2023, 4:30 AM

#

have fun experimenting with it lol

#

I will add the funcionality to fully bypass nitro for client themes on fake nitro tomorrow or something

cedar marsh Feb 16, 2023, 4:30 AM

#

alright

green vessel Feb 16, 2023, 5:00 AM

#

4 spaces indentation is objectively the only real indentation

minor jolt Feb 16, 2023, 1:49 PM

#

minor jolt apparently there is a handleGoLive function but findByProps doesn't pick it up

anyone have any ideas ?

cedar olive Feb 16, 2023, 2:31 PM

#

cuz it's a function inside a component

#

which means it's not exported

silk sorrel Feb 16, 2023, 2:33 PM

#

Wouldn't it be easier to overwrite the canUseClientThemes to always return true?
The gradient state is kept even after a restart iirc, unless they changed something

cedar olive Feb 16, 2023, 2:34 PM

#

I will work on it

covert nimbus Feb 16, 2023, 2:35 PM

#

silk sorrel Wouldn't it be easier to overwrite the canUseClientThemes to always return true?...

Vencord.Webpack.findByProps("canUseClientThemes").canUseClientThemes = () => true

cedar olive Feb 16, 2023, 2:35 PM

#

ew monkey patch

covert nimbus Feb 16, 2023, 2:35 PM

#

i am working on a plaintext patch rn too

cedar olive Feb 16, 2023, 2:35 PM

#

minor jolt anyone have any ideas ?

findByCode(".CHANNEL_CALL_POPOUT:null;")

#

It's the method handleGoLive calls inside it, but that one is exported

covert nimbus Feb 16, 2023, 2:41 PM

#

would this be a viable plaintext patch for the canUseClientThemes function or is it just arsejs { find: "canUseClientThemes:function", replacement: { match: /canUseClientThemes:function$\w${return \w*$\w*,\w*$}/, replace: "canUseClientThemes:function(){return true;}" } }

minor jolt Feb 16, 2023, 2:41 PM

#

cedar olive findByCode(".CHANNEL_CALL_POPOUT:null;")

that's helpful thanks a lot

#

brazilia numero uno

dull magnet Feb 16, 2023, 2:54 PM

#

covert nimbus would this be a viable plaintext patch for the canUseClientThemes function or is...

unnecessary

#

you can just

{
    find: "canUseClientThemes:function",
    replacement: {
        match: /canUseClientThemes:function\(.*?\)\{/,
        replace: "$&return true;"
    }
}```

covert nimbus Feb 16, 2023, 2:57 PM

#

fr?

#

nice

minor jolt Feb 16, 2023, 5:08 PM

#

this got lost in general so i'll ask here if it's not a problem

#

btw is there some way to force the overlay open via the console ?
(when running it in a browser)
since the keybind doesn't work

cedar olive Feb 16, 2023, 5:09 PM

#

opening the overlay in a browser?

#

I don't think that's even possible

eternal lion Feb 16, 2023, 5:10 PM

#

minor jolt btw is there some way to force the overlay open via the console ? (when running ...

What overlay

minor jolt Feb 16, 2023, 5:10 PM

#

the overlay that supposedly opens in games, you can run it in the browser

#

you can get the url from Vencord.Webpack.findStore("OverlayBridgeStore").__getLocalVars()._overlayURL

eternal lion Feb 16, 2023, 5:12 PM

#

minor jolt the overlay that supposedly opens in games, you can run it in the browser

Oh like the vc one?

minor jolt Feb 16, 2023, 5:12 PM

#

yea probably that one lol

#

i mean it does more than vc

eternal lion Feb 16, 2023, 5:12 PM

#

Maybe I'm confused

minor jolt Feb 16, 2023, 5:12 PM

#

it can open like a mini-discord that communicates with the normal discord

eternal lion Feb 16, 2023, 5:12 PM

#

Oh

#

Weird, idk

viral roost Feb 16, 2023, 5:12 PM

#

no way that works in a browser

eternal lion Feb 16, 2023, 5:12 PM

#

Never heard of it

cedar olive Feb 16, 2023, 5:13 PM

#

viral roost no way that works in a browser

yeah

covert nimbus Feb 16, 2023, 5:13 PM

#

pressing this used to work but it doesn't anymore

minor jolt Feb 16, 2023, 5:13 PM

#

covert nimbus Feb 16, 2023, 5:13 PM

#

uhh you might wanna censor the url there i dont trust it

minor jolt Feb 16, 2023, 5:14 PM

#

it's only a local token

covert nimbus Feb 16, 2023, 5:14 PM

#

oh okay

minor jolt Feb 16, 2023, 5:14 PM

#

not an account one

#

basically when it loads it gives you the little prompt with the keybind

#

but the keybind doesn't work (presumably the overlay webview doesn't handle it)

#

so clicking on the prompt before it disappears is the only way to open mini-discord

#

but i want to open it from the console

#

or just force it to always open tbh

cedar olive Feb 16, 2023, 6:01 PM

#

https://github.com/Vendicated/Vencord/pull/504 @covert nimbus I did it for you

GitHub

feat(FakeNitro): Bypass client themes by Nuckyz · Pull Request #504...

#

dull magnet Feb 16, 2023, 6:15 PM

#

minor jolt btw is there some way to force the overlay open via the console ? (when running ...

I don't think that's possible

#

the overlay is opened by electron

minor jolt Feb 16, 2023, 6:17 PM

#

yea but it has to do some js event fuckery to open it. the mini-discord div has a "visibility: hidden" attribute, if i remove it manually it shows up but i cannot type in channels and it's not complete

#

dull magnet Feb 16, 2023, 6:18 PM

#

it opens an entirely different window

minor jolt Feb 16, 2023, 6:19 PM

#

yea probably opens a different browser view and loads the above URL

#

but how does it handle the keybind

cedar olive Feb 16, 2023, 6:19 PM

#

I don't think you are quite understanding

#

the overlay is only officially used by discord on the client version

#

because it requires functionalities that the browser does not support

#

keybinds are one

#

and you simply can't take that browser window you are opening with the overlay url and apply it as the normal overlay

#

impossible

#

there is absolutely no reason to use the overlay on a browser

#

It can't do its main functionality, being an overlay

minor jolt Feb 16, 2023, 6:29 PM

#

hmm, my idea with this was to use it with the CEF BrowserView Api on the Steam Deck, to open the little discord window in gamescope

dull magnet Feb 16, 2023, 6:29 PM

#

the overlay likely requires DiscordNative

minor jolt Feb 16, 2023, 6:31 PM

#

as in the native client ?

#

i can accomodate that

dull magnet Feb 16, 2023, 6:32 PM

#

why

#

just use the desktop app

minor jolt Feb 16, 2023, 6:33 PM

#

don't like having a non-steam game always open on the deck

covert nimbus Feb 16, 2023, 6:37 PM

#

cedar olive https://github.com/Vendicated/Vencord/pull/504 <@347366054806159360> I did it fo...

lmfao why am i there i did like nothing

cedar olive Feb 16, 2023, 6:42 PM

#

covert nimbus would this be a viable plaintext patch for the canUseClientThemes function or is...

you did

covert nimbus Feb 16, 2023, 6:45 PM

#

cedar olive you did

accurate depiction of what i did

cedar olive Feb 16, 2023, 6:47 PM

#

no problem lol

dull magnet Feb 16, 2023, 6:51 PM

#

covert nimbus accurate depiction of what i did

what's up with the dramatic music

#

are you starring in Halloween 2023

#

https://tenor.com/view/halloween-michael-myers-hammock-chilling-gif-15437464

Tenor

covert nimbus Feb 16, 2023, 6:53 PM

#

dull magnet what's up with the dramatic music

It's Gaster's Theme from undertale husk

#

y'know, the scientist that existed, and then didn't?

#

mr funny haha wingdings

#

that gaster

dull magnet Feb 16, 2023, 6:53 PM

#

idk

covert nimbus Feb 16, 2023, 6:55 PM

#

this fuck

#

(probably)

minor jolt Feb 16, 2023, 7:05 PM

#

2017 was 6 years ago

#

husk

covert nimbus Feb 16, 2023, 7:05 PM

#

shut up shut up shut up shut up shut up shut up shut up shut up shut up shut up shut up shut up shut up shut up shut up shut up shut up i feel old now despite not being that old

#

but holy shit really

lapis swallow Feb 17, 2023, 7:50 PM

#

Oof

cedar olive Feb 17, 2023, 9:44 PM

#

@dull magnet I require assist

#

I built rlottie already

dull magnet Feb 17, 2023, 9:48 PM

#

the install script adds rlottie to system libraries

#

you just need to manually add it to the include path when compiling

cedar olive Feb 17, 2023, 9:50 PM

#

ah

#

do I add this this directory to path

dull magnet Feb 17, 2023, 10:08 PM

#

inc i think

cedar olive Feb 17, 2023, 10:17 PM

#

didnt work

#

oh

cedar olive Feb 17, 2023, 10:44 PM

#

ooh my god I will cry

#

for gods sake what's the issue now

#

@dull magnet please assist

#

full thing

strange igloo Feb 17, 2023, 11:02 PM

#

aka long long unsigned int

cedar olive Feb 17, 2023, 11:02 PM

#

that's not the issue lol

dull magnet Feb 17, 2023, 11:03 PM

#

it installs it

#

to ur system includes

#

idk use linux

#

windows bad

cedar olive Feb 17, 2023, 11:03 PM

#

https://media.discordapp.net/stickers/1075075140666282036.png?size=160

#

I fucking did it

covert nimbus Feb 17, 2023, 11:14 PM

#

liar

cedar olive Feb 17, 2023, 11:39 PM

#

and now I have more issues

#

okay I will cry

#

so bad

#