doesnt hurt :P
#👾-core-development
austere talon
limber skiff
then why not re-export all?
austere talon
just add to the import bans if u care
limber skiff
nah I don't care that much I just want to make sure it's consistent
since code refactor
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/main/scripts/build/common.mjs#L361-L3...
common.mjs: Lines 361-368
export const commonRendererPlugins = [
banImportPlugin(builtinModuleRegex, "Cannot import node inbuilt modules in browser code. You need to use a native.ts file"),
banImportPlugin(/^react$/, "Cannot import from react. React and hooks should be imported from @webpack/common"),
banImportPlugin(/^electron(\/.*)?$/, "Cannot import electron in browser code. You need to use a native.ts file"),
banImportPlugin(/^ts-pattern$/, "Cannot import from ts-pattern. match and P should be imported from @webpack/common"),
// @ts-expect-error this is never undefined
...commonOpts.plugins
];
you can add to this
limber skiff
okay I just realized the whole components index file with re-exports is useless
we don't have a path for just the components index
so it was never going to be used
neither vesktop seems to use it
so I just nuked
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/refactor-settings-ui/src/Vencord.ts#L...
Vencord.ts: Line 23
export * as Components from "./components";
😭
limber skiff
okay good catch
austere talon
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/ad810df9789bf51bd81226b4bd63efac77e84...
index.tsx: Line 8
import { ErrorBoundary, Flex } from "@components/index";
lol
this imports it
YOUR PLUGIN
nvm sadan#s fault
YOUR FAULT
we should just ban imports of /index$
nvm we cant
limber skiff
https://tenor.com/view/makin-smth-with-this-trust-w-gif-gif-5790956484979011289
LOL
I DO NOT REMEMBER THAT!
must have been my intellisense
austere talon
yeah it happens with autoimport
sometimes i auto import from the craziest place imaginable and have to manually fix it
limber skiff
@austere talon u didnt cause any regressions in patch helper right?
austere talon
i tested and it seems to work fine
limber skiff
it had so many little fixes that could either cause crashes or not work
austere talon
i made the json box auto resize
limber skiff
I'll just trust u didnt cause regressions, if anything we can fix later
limber skiff
patchhelper isnt that important
yeah
elder plinth
i made the json box auto resize
thank god
austere talon
i made the json box auto resize
crazy that there's still not a <textarea autoresize> and u have to instead do it with js
austere talon
btw it might be easier to review the changes by going through the commits
the first bunch of commits purely moves code around
only later did I start making actual changes
limber skiff
btw it might be easier to review the changes by going through the commits
theres so much logic to review 😭
austere talon
previously the returned value wasn't actually a valid plugin object
it was a PluginDef, not a Plugin
austere talon
it was a PluginDef, not a Plugin
so something like isPluginEnabled(SpecificPlugin); would type error and if you wanted to type a generic Plugin type to a specific Plugin you had to cast to any first
the change fixes it
austere talon
**index.tsx:** Line 8
```tsx
import { ErrorBoundary, Flex } from "@components/in...
actually try to fix this
maybe it's that
but don't worry too much about it for this pr
It would be better to try to tackle the circular stuff in a future pr instead
austere talon
so this is the issue
the best solution is to avoid top level code like this
limber skiff
didnt work
austere talon
and instead make init functions and call them in order
austere talon
that doesn't matter much
limber skiff
import just ~plugins works
but also plugins doesnt?
the first import should happen before
austere talon
it's not that simple
limber skiff
I am not seeing something then
austere talon
all parts of vencord import each other recursively
top level code competes for who gets to run first. if top level code depends on each other recursively you get into this trouble
the way it currently is it imports in just the right order to make it work
if you move around or add new imports it changes the order
limber skiff
~plugins is everything inside plugins excluding index right
austere talon
it's very ugly but the only solution is looking into what is exactly causing it and doing a deeper refactor
austere talon
~plugins is everything inside plugins excluding index right
yes
just don't worry about it for this PR let's tackle it separately 🙏🏻
limber skiff
just don't worry about it for this PR let's tackle it separately 🙏🏻
alright
austere talon
the naming was mostly intended
if its named after a component, PascalCase
otherwise camelCase (like commons)
but this is fine too it doesn't really matter
nimble pendantBOT
vtest refactor-settings-ui
Now testing! 
limber skiff
yeah just did that
fossil inlet
did I not change the name
git on windows hates case changes for files
doesn't respect them
austere talon
Windows user spotted
fossil inlet
i remember this being a pain in the ass on a personal project a while back
austere talon
try git mv commons Commons
limber skiff
guhhh
limber skiff
why isn't vscode smarter on that
fossil inlet
why isn't vscode smarter on that
it's git not vscode
limber skiff
it's both cuz vscode could call git mv
fossil inlet
it's both cuz vscode could call git mv
well not really, i'd argue that calling git mv is incorrect
(assuming you're talking about renaming a file)
limber skiff
yes
fossil inlet
few reasons
- not everyone uses git (no vcs or other vcs)
- when you rename a file you dont expect git to be invoked
this is just an issue with git on windows
not with vscode
limber skiff
I mean yes, I get why it's a git issue
austere talon
this is just an issue with windows :P
limber skiff
@austere talon do we plan or merging it soon
if not need to backport the find fix and push it as soon as possible
since it breaks plugin settings
odd heath
<@343383572805058560> do we plan or merging it soon
you should merge https://github.com/Vendicated/Vencord/pull/3382 too 
fossil inlet
you should merge <https://github.com/Vendicated/Vencord/pull/3382> too <:blobcat...
that pr probably gets mangled by the settings refactor
odd heath
that pr probably gets mangled by the settings refactor
nothing nookies couldnt fix
fossil inlet
limber skiff
nothing nookies couldnt fix <:blobcatcozy:1026533070955872337>
😭 😭 😭 😭
odd heath
but it needs to be reviewed anyway 
cuz the code wouldnt change much id just shuffle files around
austere talon
if not need to backport the find fix and push it as soon as possible
wait wdym?
oh
add it separately for now
and bump extension
limber skiff
alright
austere talon
the refactor should sit in dev for a while so enough people test it
limber skiff
vtest dev2
nimble pendantBOT
vtest dev2
Now testing!
nimble pendantBOT
vtest dev2
Seems like everything is working fine (for now) 
nimble pendantBOT
vtest dev2
Seems like everything is working fine (for now)
limber skiff
I'll wait a lil bit and then push tag
odd heath
you should still merge refactor to dev methinks
fossil inlet
wouldn't this just be RCE via settings sync
gaunt bluff
“QuickJS”
Wait where do u write the #📜-js-snippets then
gaunt bluff
Ohhh
limber skiff
so why are we husking extension bump now
gaunt lava
idk
glass jasper
so why are we husking extension bump now
Because it took like an hour and half
limber skiff
i was waiting for possible bugs
glass jasper
Still tho thats why husk
gaunt lava
i was waiting for possible bugs
if you have time, you can check https://github.com/Vendicated/Vencord/pull/3540
fossil inlet
Because it took like an hour and half
You're insane
glass jasper
You're insane
jolly egret
not for feature requests guhh
scenic brook
It's not even a feature request because they've created it already, this could just be a PR lol
elder plinth
the contributing guide does say to open an issue but thats on the now defunct plugin-requests repo and the link leads to a 404 so maybe they got confused
scenic brook
Fair
austere talon
so why are we husking extension bump now
because it's krystal they always add random reactions
austere talon
should we merge the settings refactor into dev now?
jolly egret
screams "never used a dev build before outside of this PR"
theres measures in place that (as long as dependency changes don't happen) the updater can just git pull and rebuild for you lol
anyway voiding security of people all for this is dumb
charred monolithBOT
austere talon
just make it faster, duh 😛
austere talon
evil nuckyz
charred monolithBOT
prime dew
You could call this
Vee...to
glass jasper
because it's krystal they always add random reactions
limber skiff
vext
limber skiff
@austere talon they are cooking so hardly
has anyone experienced discord freezing in chats
it's like the fourth time my client completely freezes out of no where
fossil inlet
On Windows I've always experienced random crashes, but that's with the stock client, so I figured that was just the issue.
jolly egret
i haven't restarted yet
actually did i?
can't remember but i haven't seen anything odd
limber skiff
I have a feeling it's related to typing tweaks
it was changed recently no?
but it's so hard to debug because the whole client just freezes
limber skiff
client theme
austere talon
do u have any custom css
limber skiff
it's 100% a function looping infinitely
austere talon
wait does it freeze forever?
limber skiff
yeah
austere talon
ohhh
limber skiff
completely
austere talon
yeah no i never had that
well try to replicate it with devtools open
then you can pause scripts
and see where it got paused
fossil inlet
@opaque silo when will electron fix the 30s hang when theres no notification daemon
austere talon
@opaque silo
limber skiff
vtest dev2
nimble pendantBOT
vtest dev2
Now testing!
nimble pendantBOT
vtest dev2
Seems like everything is working fine (for now)
nimble pendantBOT
vtest dev2
limber skiff
vtest dev2
nimble pendantBOT
vtest dev2
Now testing!
nimble pendantBOT
vtest dev2
nimble pendantBOT
vtest dev2
glass jasper
fixed it <:blobcatcozy:1026533070955872337>
Nuh uh
limber skiff
but it should be decreased
limber skiff
better?
odd heath
yes
limber skiff
or should I make margin 12
elder plinth
this is why you should make every plugin with 100% components for custom margins 
limber skiff
ClientTheme color #101010
odd heath
yeah no looks weird already
yea just stick with 8 imo
and maybe review my pr if you have time pretty please :3
gaunt lava
limber skiff
gaunt lava
avatar is not rendering
odd heath
errors look so bad...
just add margins into the style 
limber skiff
discord form components are so bad
we need to stop using them
like why does a switch have 20 pixels of bottom margin??
odd heath
we need to stop using them
nopp
odd heath
like why does a switch have 20 pixels of bottom margin??
probably to bully vc devs
gaunt lava
looks good?
yes
limber skiff
see that's another reason to stop using form components
they have so much random margin
odd heath
wasnt it completely fine before 
limber skiff
@austere talon werent form components deprecated so long ago
this for example does not look like the switch we use
odd heath
this for example does not look like the switch we use
whats the difference?
limber skiff
the gap between the title and description
odd heath
ohhh
scenic brook
Settings modals without a save button feels wrong lol
glass jasper
Yk when that hits main should prolly post something about incase people ask about it
elder plinth
how does this change actually work. for custom components will it just call the setValue instantly instead of waiting for save to be pressed?
limber skiff
it will be breaking for third party plugins I think
custom components would already instantly save in most cases
elder plinth
oof if you validate a field and prune it you'll need to defer that now cause it'll be impossible to update the field otherwise
limber skiff
huh?
elder plinth
how would you even know when to validate a field now though. onclose?
elder plinth
huh?
like enforcing a syntax in a field and not saving otherwise. and clearing it if the syntax is wrong
guess I'll just have to try it and to see how it works
elder plinth
it just calls the passed setValue for custom components right
elder plinth
yeah you pass it as a prop
limber skiff
so basically everytime your component calls setValue it will attempt to save
but it will save debounced so if you call it a lot it wont spam saving
you can have your custom component do parsing with a useState
and only call setValue when the parsing is successful
to then save the value
elder plinth
ok so does onChange still exist? if so then nothing really changes actually
limber skiff
yeh
elder plinth
you just have to be more careful about when you call setValue or it will call onChange and overwrite a field mid typing in it cause it's technically bad syntax
not that bad
limber skiff
not really
the way you implement a custom component it should never reflect the changes of the setting you are changing
the state which controls the field should never be overwriten by parsing
so what I'm trying to say is, even if you do call setValue all the time, it wont overwrite the field because the state should be different
elder plinth
looks like I actually only have one setting where this will be an issue
limber skiff
how does your validator works?
elder plinth
that will remove invalid options so if you're mid typing and it insta calls onchange due to attempting to save it then it'll yeet what you're typing wont it or am I missing something
limber skiff
where does it show the error
limber skiff
that will remove invalid options so if you're mid typing and it insta calls onch...
then what I said earlier applies
elder plinth
no error it just checks your list vs the current quests so it never gets too long and has outdated quests
limber skiff
you are using the wrong state
dont use for example
const { quests } = settings.use(["quests"]);
inside your component
use const [quests, setQuests] = useState(settings.store.quests)
on field changes always call setQuests and setValue
onChange will validate your quests and remove the invalid ones
elder plinth
limber skiff
setQuests will make sure your field remains intact so when the user finishes adding a proper quest, it will pass your validator and save it so settings
limber skiff
dont call it like that lol
ignoredQuests and setIgnoredQuests
what is ignored quests? a list of ids?
limber skiff
what about your validator
elder plinth
nvm multi line list of quest names
elder plinth
validator checks if the quest still exists or if you've completed it or not
limber skiff
alright then it's similar
do your validation and set the parsed setting with settings.store
and it should work just fine
elder plinth
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/1a81912ba0dd4bad3c99ee6cbf689579e3d45...
settings.tsx: Line 132
export function validateIgnoredQuests(ignoredQuests?: string, questsData?: Quest[]): string {
questify is a good name
Honestly one is the best I’ve heard lately
At least it’s not a cliché Better_____
odd heath
At least it’s not a cliché `Better_____`
on that note can we merge BetterBlockedContext
elder plinth
originally named QuickQuests when it was just a shortcut to the quests page but then I had to rename it when I added a ton more and really wanted to avoid the Better_ syntax lol
elder plinth
do your validation and set the parsed setting with settings.store
I'll just have to try it out when I get back to my pc I can't really mentally envision how validating this without overwriting midtype would work
odd heath
@gaunt lava why ghost ping me 😭
spark cove
@limber skiff are you alive
limber skiff
why?
spark cove
why?
i want help investigating this issue i have
everytime i pnpm i on the vencord repo
my lockfile changes
my patchfile hashes differ from those in the upstream lockfile
fossil inlet
have you tried pnpm i --frozen-lockfile
spark cove
oo okay
spark cove
have you tried `pnpm i --frozen-lockfile`
this doesnt work for this
ERR_PNPM_LOCKFILE_CONFIG_MISMATCH Cannot proceed with the frozen installation. The current "patchedDependencies" configuration doesn't match the value found in the lockfile
do u not have this issue @fossil inlet ?
fossil inlet
no
fossil inlet
i'd just compare the patches/lockfile to what's upstream as a starting point
also pnpm version
spark cove
well the actual patches
are the same
its just that when pnpm patches the modules i think the hash is hashing the post-patch code
fossil inlet
@spark cove pnpm version
fossil inlet
old versions refuse to do anything in some packages that have use newer versions
(including things like pnpm --version
spark cove
that sounds like a corepack thing
fossil inlet
that sounds like a corepack thing
i am 100% sure it's a pnpm issue
(the error comes from fields added to the pnpm-workspace.yaml file that the olderversion doesnt know about)
something corepack should not be reading
fossil inlet
the field is automatically added by newer versions for anything that has a "built" dependency
(most native things)
spark cove
i didnt even think to look at the old value
fossil inlet
love pnpm
but hate their constant breaking changes
spark cove
cus i just assumed same format diff hash
spark cove
i just realized they introduced a breaking change in the lockfile format without upping the lockfile version
fossil inlet
i just realized they introduced a breaking change in the lockfile format without...
i'm not sure if it's 100% a breaking change
spark cove
yea fair
fossil inlet
yea fair
it depends if the new version updates hashes to the new format even if the content didn't change
if it does then it's a breaking change
if not then it's not
(i think)
because afaik pnpm doesn't promise forwards compat
austere talon
<@343383572805058560> werent form components deprecated so long ago
idk but they're also laggy lol
plugin page used to use formswitch and it was really slow (would freeze for a second)
that's why i rewrote switch from scratch and switched to that
some of their settings indeed use a new component but not all
scenic brook
Plugin categories real
charred monolithBOT
scenic brook
I still run the categories thing I fucked around with a while back but I removed all the categories from the plugins because I couldn't be bothered dealing with merge conflicts everywhere forever lol, so it only really serves to filter user plugins now
scenic brook
Just fucking around
I kinda just stopped dead at one point so it is what it is, I don't go in there much
Six felt better back here
prime dew
4
prime dew
True
gaunt lava
https://github.com/Vendicated/Vencord/pull/2707
Oh, I completely forgot about that
limber skiff
I found this to be what looks the best
Ideally there shouldn't be that huge margin between the title and the subtitle, but we need to move away from form components to fix that
once again their random ass margins
@austere talon looks good?
austere talon
i never noticed the switches are not aligned
limber skiff
they aren't?
limber skiff
glass jasper
I found this to be what looks the best
-# Personally there isn’t a big enough gap between each option, needs to have a top margin or something
limber skiff
-# Personally there isn’t a big enough gap between each option, needs to have a ...
more gap?
austere talon
that's vertically
limber skiff
that's vertically
I dont get what you mean then 😛
austere talon
limber skiff
ohhh
limber skiff
Doesn’t seem like there’s any gap
limber skiff
wait until you realize that's how it looks in all discord settings
limber skiff
I feel like it's wasting a bit of space
austere talon
wait until you realize that's how it looks in all discord settings
it looks worse in ur screenshot
probably cause so little margin
limber skiff
that makes sense
limber skiff
what about this
that's the same margin we currently have
well, a bit less
added more margin in just the switches
austere talon
just stop using the formswitch
limber skiff
yeah
austere talon
nice
limber skiff
super easy lol
austere talon
i think that's good
limber skiff
what about stop using FormTitle and FormText
austere talon
why
limber skiff
austere talon
what else
limber skiff
the gap between the title and description is too big
limber skiff
I would if I knew how lmao
do you remember what's the text variant for the grey text
fossil inlet
just remove the patch, who cares about the plugin 
fossil inlet
do you remember what's the text variant for the grey text
muted i think
test
-# thing
limber skiff
too bad there's no muted
I also can't find a variant that matches the current title...
so that's how they do it
😭
md medium with hardcoded style
glass jasper
<@929208515883569182> do you still think it's too little gap?
No, that’s actually perfect
limber skiff
glass jasper
First screenshot was better
limber skiff
the select components look so weird imo
limber skiff
First screenshot was better
it's the same lol
glass jasper
it's the same lol
Im just trying to gaslight you now
glass jasper
Agreed
limber skiff
@odd heath does your array settings have a name and description?
odd heath
<@708275751816003615> does your array settings have a name and description?
Wdym
It's just a normal setting so I'd assume so?
limber skiff
alr
limber skiff
just wanted to know if setting section name and description should stay required
I kept them required and added an inline option to the component
for settings like booleans
limber skiff
last one I promise
limber skiff
they looked bad after the rewrite
glass jasper
??
limber skiff
we pushed a refactor earlier and it messed up settings a bit
this fixes the issues but also improves the layout as we were just discussing
nothing else
austere talon
we pushed a refactor earlier and it messed up settings a bit
wha
they were always like this, no?
austere talon
why to dev directly 😭 next time pr
limber skiff
why to dev directly 😭 next time pr
it's so minor 😭
limber skiff
they were always like this, no?
yeah mostly, but after the refactor error didnt have margin
austere talon
what do you think about https://github.com/Vendicated/Vencord/pull/3553
charred monolithBOT
limber skiff
it's nice but I also think we should potentially separate plugins in categories in the list
austere talon
how?
limber skiff
just categories which can be expanded and collapsed
we can put all the Better* plugins in Improvements or something for example
glass jasper
what do you think about https://github.com/Vendicated/Vencord/pull/3553
Gotta think of a name and tags for my random plugins?
austere talon
we can put all the Better* plugins in Improvements or something for example
well yeah I was always gonna do this for some plugins
bright island
adding the keyword "depressing" when a plugins code just looks sad
austere talon
mainly the tweak plugins that just alter some stock behaviour
idk if putting better* in one category is a good idea
we should just give them appropriate tags and make the tag filter accessible (as in not hide them in some menu but instead display them always)
bright island
are the keywords to help people find the plugins they want?
then i don't think making the Better* stuff have its own tag would be helpful, might just end up being annoying
austere talon
we should just give them appropriate tags and make the tag filter accessible (as...
I'm thinking a grid of pills below the search bar that you can click to select a tag
median rapids
is the waveform gen in the vm plugin the same as what the mobile client does?
brazen bone
what do you think about https://github.com/Vendicated/Vencord/pull/3553
Is this different from the existing tags field? Think that one's only used for searching though
limber skiff
it was a bit too small but now it changes accordingly
umbral hedge
vencord launcher now supports arm64 discord installs by popular request (one singular person asked for it) 
https://github.com/MeguminSama/Vencord-Launcher
dusk blaze
vencord launcher now supports arm64 discord installs by popular request (one sin...
this should really be an official install method at some point
umbral hedge
I wouldn't say no to it
only downside is apple is too restrictive, so any mac support would still have to do file patching
fossil inlet
vencord launcher now supports arm64 discord installs by popular request (one sin...
windows on arm my beloved
hollow musk
windows on arm my beloved
wasnt there a case where Minecraft didn't work on arm processors?
arm on desktop just feels like it is in a weird state
glass jasper
scenic brook
charred monolithBOT
charred monolithBOT
woeful sleet
what do you think about https://github.com/Vendicated/Vencord/pull/3553
A bit pedantic but would it be better for developers to be development? Doesn't really change the meaning, but seems more appropriate to me weirdly.
servers, friends, emotes, and activities also seem like odd ones out. Are they the areas of the app that are affected by the plugin? That seems odd to me, can't really put my finger on why
elder plinth
A bit pedantic but would it be better for `developers` to be `development`? Does...
Accessibility Plugins ✅
Activity Plugins ✅
Appearance Plugins ✅
Commands Plugins 
Customisation Plugins ✅
Developers Plugins ❌ -> Development Plugins ✅
Emotes Plugins
Friends Plugins
Fun Plugins ✅
Media Plugins ✅
Notifications Plugins
Organisation Plugins ✅
Privacy Plugins ✅
Roles Plugins
Servers Plugins
Shortcuts Plugins
Utility Plugins ✅
Hm I agree with Developers being better as Development. The others you mentioned and a few others feel a bit weird ( ) but I think that's mainly because they're plural forms. Also as you said they slightly semantically describe something different than the rest of the tags. 🤔 But overall I don't think they're bad.
||Also Customiszation & Organiszation 
||
limber skiff
vtest dev2
nimble pendantBOT
vtest dev2
Now testing!
nimble pendantBOT
vtest dev2
nimble pendantBOT
vtest dev2
Seems like everything is working fine (for now)
elder plinth
Existing patch technically works it just has no effect cause Discord added a terniary operator. At least I'm assuming that's what the change was.
fossil inlet
Existing patch technically works it just has no effect cause Discord added a ter...
Did they re-add the ternary lol
elder plinth
well it has one now so I guess so lol
charred monolithBOT
charred monolithBOT
charred monolithBOT
scenic brook
As if anyone's gonna read through smali
jolly egret
LMAO
charred monolithBOT
elder plinth
you can speed up videos like 10x but ntts just made a video on orbs and showcased the quest exploit script so inb4 discord finally patches it? 
analog knoll
vesktop-bin-patched seems to be malware https://aur.archlinux.org/packages/vesktop-bin-patched
(from what I've heard), someone should keep an eye on the news here
dusk blaze
has "electron patches" whatever that means
odd heath
vesktop-bin-patched seems to be malware https://aur.archlinux.org/packages/veskt...
It's gone
limber skiff
you can speed up videos like 10x but ntts just made a video on orbs and showcase...
unless they actively fight it they cant patch lol
you can always simply replicate what the client is doing
and javascript makes it so easy
elder plinth
surely they can patch the thing that allows you to send video progress reports 10x the speed that should be possible
guess it wouldnt matter much if you were still able to fake watching it at all
just would take longer to finish
odd heath
Great, did you have anything to do with it? (with it being gone)
nah i just went to open the link and its a 404
elder plinth
multiple people have mentioned adding the quest speedups to the plugin and I've always took it as a joke cause I don't want to ruffle Discord's feathers but now I'm wondering is it a joke? Should I genuinely add it? I suppose it isn't that much worse than fake nitro at the end of the day. Except instead of Discord losing out it's their advertisers 🤔
elder plinth
was just curious if it was too much for an official plugin
elder plinth
aight. in other news I just learnt you can complete mobile quests on desktop. praise be
uh idk
limber skiff
that could be very interesting lol
elder plinth
get your account flagged in 1 easy step, complete all 7 open quests at the same time
fossil inlet
is it possible to complete more than one quest at once?
i wouldn't do that myself, and amia's script doesnt either
i also wouldn't feel comfortable putting that in a plugin
elder plinth
the speedups or specifically the multi at once
cause yeah I also wouldnt want the multi at once personally
limber skiff
i also wouldn't feel comfortable putting that in a plugin
why?
fossil inlet
why?
idk, just doesn't sit right with me
not worried about discord flagging it because you could have more than one client open at the same time
?remind 2 weeks make keybind api
shut vineBOT
Alright @fossil inlet, in 2 weeks: make keybind api
fringe basalt
<@142007603549962240> they made the snippet anyways
hi
fringe basalt
istg i hate this misinfo
elder plinth
Did you do exact testing to land on the 10 second max and 7 second values in your script? or were they just ballparks
fringe basalt
Did you do exact testing to land on the 10 second max and 7 second values in you...
exact testing for the 10s one (i spammed the api to death on multiple accounts and watched which thresholds it allows)
the 7s is just how often the client sends it
elder plinth
can I use some logic from your script and add you as an author so I dont have to do a bunch of my own testing
limber skiff
rare aliucord plugins pr
fringe basalt
can I use some logic from your script and add you as an author so I dont have to...
as long as you credit me then sure, but tbh idk if making it a vencord plugin is a good idea
fossil inlet
why is the first character times new roman 😭
fringe basalt
it would have to be updated too often
fringe basalt
why is the first character times new roman 😭
i set it to a cyrillic a to dehoist myself
fossil inlet
i set it to a cyrillic a to dehoist myself
😭
elder plinth
how much of it changes often? does the video speed part change a lot?
fossil inlet
i need to make some plugin that normalizes names
fringe basalt
how much of it changes often? does the video speed part change a lot?
well the video speed part changed once so far, but other parts change often
for example all quests used the taskConfig field until like 1-2 weeks? ago where newer ones started using taskConfigV2 instead
fossil inlet
it would have to be updated too often
tbh vencord also has to be updated often, but breakages in this might be less noticable
elder plinth
hmmm
fringe basalt
tbh vencord also has to be updated often, but breakages in this might be less no...
fixes take forever to get merged and pushed to main though
im still being ghosted on this one https://github.com/Vendicated/Vencord/pull/3540
fossil inlet
yeah
elder plinth
showmeyourname fix sitting there in shambles
fringe basalt
for example all quests used the `taskConfig` field until like 1-2 weeks? ago whe...
they also introduced the WATCH_VIDEO_ON_MOBILE quest type like a month ago i think?
fossil inlet
showmeyourname fix sitting there in shambles
is it broken rn?
elder plinth
yeah I just added an option to make that work on desktop
elder plinth
is it broken rn?
isnt it? they added a terniary
glass jasper
-# Tbh this whole time this Quest plugin as seemed more of a userplugin to me anyhow
elder plinth
limber skiff
the feature to disable fetching quests is kinda useless tbh
fossil inlet
the feature to disable fetching quests is kinda useless tbh
based on the name, couldn't that prevent quest ads in the client
elder plinth
if you want to completely dequest then not really
there's another option to disable the popup above your profile area so it is sorta kinda redundant
elder plinth
all it does it makes no quests appear, right?
limber skiff
in your pr desc you said it broke
elder plinth
huh
fringe basalt
if you want to get rid of the quest popups while keeping quests functional then just do something like thisjs FluxDispatcher.addInterceptor(function(event) { if(event.type === "QUESTS_FETCH_CURRENT_QUESTS_SUCCESS") { event.quests.forEach(x => x.config.features = x.config.features.filter(y => ![1,3,8].includes(y))) } })
elder plinth
I just patch the popup to not show
plus the same popup is used for progress tracking
jagged reef
holy moly
elder plinth
so you need to check for that
elder plinth
in your pr desc you said it broke
Fetching Quests — Will prevent fetching Quests resulting in a blank Quests page.
just said it shows no results
fossil inlet
elder plinth
it's an option you wouldnt turn on unless you were already turning everything else on. not really necessary I guess but also not detrimental 
limber skiff
ahh I must remember wrong then
elder plinth
<:fear:1126220232176975942>
god forbid I want to make a pretty settings page
fossil inlet
it still needs work to be pretty i'd say
elder plinth
huh? looks great imo
fossil inlet
ran into some issues with it
elder plinth
explain
fossil inlet
test
elder plinth
very helpful thanks
fossil inlet
sorry
@elder plinth why is everything !important
this will make thing a pain for themes to style
elder plinth
some of them needed it and I lost track of which ones did at some point and started putting it on everything
fossil inlet
some of them needed it and I lost track of which ones did at some point and star...
don't do that
elder plinth
ill go through at some point and see which ones actually need it then 😭
glass jasper
Bro just had to make that comment
fossil inlet
btw how did we go from you telling me the settings didnt look nice to this
shouldn't have said they didn't look nice, they do
just found some weird styling things
elder plinth
elder plinth
oof that was definitely copilot autofilling for me.
elder plinth
oh the settings page supports light mode. agony
fossil inlet
oh the settings page supports light mode. agony
all of discord supports light mode
elder plinth
huh
fossil inlet
<@521819891141967883> can you explain this one
you are wrapping it in something that does nothing
lc.wiki noop
rancid idolBOT
lc.wiki noop
Wikipedia • labsCore • Page 1/51
fossil inlet
@astral birch fix html encoding not being decoded
elder plinth
it does do something though?
it adds a feedback prop
I patch it in. but the default component doesnt have it
and so the type hinting gets mad at me without this
fossil inlet
I patch it in. but the default component doesnt have it
you patch in functionality to the discord SearchableSelect component?
elder plinth
fossil inlet
insane
elder plinth
why
austere talon
aliucord jumpscare
jolly egret
When are you pushing the fixes for irccolors and showmeyourname?
they have been broken on stable for days now with suitable fixes waiting for deployment
limber skiff
it's waiting a bit because settings refactor go along with it
austere talon
we can probably release it
maybe tomorrow (EU) morning
I'm gonna sleep very soon
so in like 10 hours or so
elder plinth
I have a PR open for it
elder plinth
have these always been a thing? cause ive only started noticing them recently
limber skiff
click the filter
elder plinth
surely it'll make it to main eventually
limber skiff
why does that matter tho
elder plinth
wdym
why does what matter
making it into main?
cause I base my stuff off main
cba to switch to dev
fossil inlet
cba to switch to dev
Trust me, base off dev
Sometimes fixes take a while to get into main
fossil inlet
@austere talon you should review https://github.com/Vendicated/Vencord/pull/3547
charred monolithBOT
kindred tree
this would also be cool
toxic forge
austere talon
what joke vulnerability is this lol https://github.com/advisories/GHSA-xffm-g5w8-qvg7
high vulnerability
look inside
build tool config is "vulnerable" to denial of service
if you're running untrusted code as build config you have deeper problems
why are the headings so small @limber skiff
Authors and Settings
i will make them bigger
charred monolithBOT
austere talon
also I agree with using Text over Forms @limber skiff
I used it in this commit
it's nice that you can easily choose which variant you need
so good
vtest dev
elder plinth
what's _oldChildren for in the smyn patch? 🤔
austere talon
what's _oldChildren for in the smyn patch? 🤔
to noop the old code without having to match it
elder plinth
is there a reason you can't just remove the entire terniary and return only the function result
just curious what I might have accidentally broken with my patch by doing that. seems fine so far but idk
🤔
austere talon
without having to match it
elder plinth
I didnt lol
match: /(onContextMenu:\i,children:)[^}]+}[^}]+/,
mm I see my method removes the data-text though
elder plinth
this is why you don't try to match it
yeah but this solution feels ugly lol
austere talon
lol it puts it in the html that's funny
scenic brook
You need to patch data-text as well anyway for the hover glow to match the added/reordered names on gradient roles
elder plinth
gradient works fine for me without
match: /(onContextMenu:\i,children:)[^"]+/,
replace: "$1$self.renderUsername(arguments[0]),"
🤔
austere talon
```js
match: /(onContextMenu:\i,children:)[^"]+/,
replace: "$1$self.renderUserna...
terrible
elder plinth
works
scenic brook
It won't if you put the other name first
austere talon
that is terribly unsafe and will eat up an arbitrary amount of code if they ever change the code
elder plinth
:)
austere talon
if they remove "data-text" you will eat half the module
elder plinth
It won't if you put the other name first
?
I suppose I should redo a lot of my patches that rely on [^}]+ then huh
scenic brook
Here the glow is emitting based on the display name from the start but that's not the correct text
elder plinth
it's just so convenient
elder plinth
Here the glow is emitting based on the display name from the start but that's no...
what's wrong about that?
scenic brook
It's the wrong text, the glow doesn't match the chars and extends past the username
It's more noticeable when the display name has an emoji
elder plinth
what should I be noticing in the second one
scenic brook
The glow is for the text "Kerla 🌈" but is displayed behind "foreverkara"
I don't really know how else I can describe it
elder plinth
oh you want the glow on kerla?
it just makes sense to me the first listed name would always get the gradient
scenic brook
It's just weird to have an arbitrary glowing shape behind the text that doesn't match the characters
scenic brook
it just makes sense to me the first listed name would always get the gradient
Sure but then it should be patched so that data-text is the first name listed and not the display name as default
elder plinth
oh I thiink I accidentally killed the glow in my smyn pr which is why I havent been understanding
scenic brook
If you were patching out data-text then yeah you will have done lol
elder plinth
mm yeah lol
scenic brook
Anyway it's not a huge deal, was just meant to be a passing comment lol
elder plinth
oh yeah I changed the order and the glow is fucked
so data text needs to be patched too
ugh
scenic brook
That's why my PR extracts getting the different names into its own function, so I could use it in both the actual name component and the data-text
The patch in that PR won't work anymore but eh
elder plinth
so does the glow only extend for however far the data text is
so if I want the glow to extend for multiple names stacked I gotta return the whole string formatted hmm
scenic brook
Yeah it's just used by this :after
elder plinth
hmm weird ive somehow broken it so the glow stops before the last name
wtf it's cause of @ in the data-text
even encoding it @ isnt working
elder plinth
guess I'm just .replaceing @ to a lol
charred monolithBOT
jolly egret
let's go finally
dusk blaze
austere talon
<a:kys:1334683360219369576>
love?
scenic brook
How can you live without fart plugin
dusk blaze
love?
make PR to fix i can't live without fart https://git.nin0.dev/duke/fart
and splattie will not be online for years
jolly egret
VEN HOW DO I GET FREE NITRO
limber skiff
also I agree with using Text over Forms <@235834946571337729>
yeah it's much better
I guess we could even recreate the text component with more variants
or easier color management maybe
charred monolithBOT
limber skiff
yeah it's much better
@austere talon thoughts
imo it's good to stop relying on webpack finds for settings
austere talon
oh from scratch?
I mean i guess but that's a lot of work
have fun reimplementing the interactive components especially
switch etc
limber skiff
I mean we got the switch already lol
jolly egret
crazy how we still haven't fixed this yet
though isn't this a show me your name thing
fossil inlet
i have twemoji installed globally so i would never notice
can you send the font file for it
i've never managed to get a working twemoji install
olive aurora
fossil inlet
you can just use a css snippet it's way easier
i mean install it as my emoji font system wide
fossil inlet
should be compatable with stable
limber skiff
just remove the limit from the look behind
gritty iris
@granite sky why did you do ChannelStore.getChannel(this.getChannelId()) when you could just use getCurrentChannel()? they both do ChannelStore.getChannel(SelectedChannelStore.getChannelId())
granite sky
<@279266228151779329> why did you do `ChannelStore.getChannel(this.getChannelId(...
I was trying to do it and lsp told me to fuck off
Lmao
granite sky
Couldn't find this method
gritty iris
granite sky
Will look again in a few minutes
gritty iris
its from discord
import { getCurrentChannel, getIntlMessage } from "@utils/discord";
granite sky
Thanks
gritty iris
mhm
austere talon
that file is from vencord 😭
it's called discord cause it's utils for getting discord data
austere talon
canary 👁️👃👁️
jolly egret
again? great!
austere talon
evil
austere talon
they converted it to a function component
fossil inlet
yeah figured
it looked like the old module id was just a empty wrapper
this works but it sucks
findComponentByCode('"aria-labelledby":null!=(')
findComponentByCode(".error]:", ".inputWrapper", '"input"')
yeah