#👾-core-development
charred monolithBOT
elder plinth
tryna make a dm with discord just gives me internal server error and with community updates gives me invalid recipients 😭
fossil inlet
@odd heath js wreq(493683).Z.openPrivateChannel({ recipientIds: "643945264868098049"})
odd heath
works for me
fossil inlet
anyway, cant repro the crash
elder plinth
did you do something sus in the past to get a dm with discord cause it looks to me like they have to be the one to make the dm lol
odd heath
or from discord rather
odd heath
did you do something sus in the past to get a dm with discord cause it looks to ...
yes :3
they yelled at me for tos violation
elder plinth
await Vencord.Webpack.Common.RestAPI.post({
url: "/users/@me/channels",
body: {
recipients: ["250322741406859265"]
}
});
this works for any user id from the sidebar just not discord or community update's for me
fossil inlet
do you havbe any dms with discord
yeah, this is the only embed-looking thing tho
and no crash
odd heath
i got this dm today and the crash when i tried to open the dm so i feel like they probably relate
elder plinth
damn why yall out here getting on discord's naughty list
y u getting that dm
I have 2 servers with boosts
one at 86 rn
elder plinth
usually they send that kinda notice in the community updates channel you set for your server hm
I havent actually gotten one of those in asges in my server. weird
how can these simultaneously be true
top is test find, bottom is view module
odd heath
@fossil inlet the discord dm embed vs an emoji embed
it doesnt have the url field in teh embed itself
thats why it crashes
fossil inlet
i just wrapped in try-catch 
GUHHH WHO DID TYPE ASSERTIONS
@odd heath can you checkout 3509 and try to repro
elder plinth
shitty code
what about this then 😭
odd heath
<@708275751816003615> can you checkout 3509 and try to repro
works fine
fossil inlet
what about this then 😭
probably also shitty code 
elder plinth
maybe ur plugin is just buggin
odd heath
well tbf probably its true for every non system dm or discord changed it recently
otherwise the crash would be more frequent
fossil inlet
well tbf probably its true for every non system dm or discord changed it recentl...
yeah, see my fix
odd heath
i did see
elder plinth
this work?
fossil inlet
this work?
Make a suggestion with it
It’s probably better, but I’ll leave it up to whoever reviews it
elder plinth
hm the comma makes a big difference lol
elder plinth
Make a suggestion with it
how do you make a suggestion? is it just leaving a comment? 🤔
fossil inlet
how do you make a suggestion? is it just leaving a comment? 🤔
Select range of lines
Press +
There’s a button in the top row
scenic brook
making more specific is so hard without adding like 20 different finds lol
It's dev companion that's wrong, not you
elder plinth
It's dev companion that's wrong, not you
https://tenor.com/view/crazy-samuel-l-jackson-samuel-l-jackson-samuel-jackson-sam-glass-gif-23684172
fossil inlet
It's dev companion that's wrong, not you
Are all the modules the same 
From lazy loading
scenic brook
I can't remember the issue, I did mention it here before
I'll find it again at my PC but the unique modules count is wrong in some cases
^
elder plinth
I'll find it again at my PC but the unique modules count is wrong in some cases
how would it be returning none when the find works though lol
scenic brook
Can't speak to that one off the top of my head
fossil inlet
You should find out why and fix it
elder plinth
findComponentByCodeLazy("STATUS_DANGER,disableColor:")
find works but view module says none
scenic brook
But the "found 18, 24, etc. modules" is the thing I mentioned
elder plinth
sadan's or basic?
scenic brook
Sadan's but I may have modified it, I don't remember 
I kinda merged the new dev tools into my personal build
elder plinth
oh now it works
it was attaching to my PTB install which I hadnt restarted yet since discord's fuckery earlier
saw "connected to websocket" on stable and assumed it was using that smh
nvm wrong find. clicked the wrong one, still no worky. smh x2
jolly egret
having a lot of annoying gaps in viewraw with roles
can't do it in mod view, can't do it in members tab, can't do it in the permissions viewer modal
maybe even more places but its kinda frustrating especially when i was trying to steal/check gradients
fossil inlet
having a lot of annoying gaps in viewraw with roles
can't do it in mod view, ca...
Can you send an ss
jolly egret
i misremembered mod view button but yea
glass jasper
fossil inlet
Fixed in 3509, but I might pull it out because it will work on stable
glass jasper
Ight
glass jasper
<@133203646983831552> lmk if more people run into this
Iirc the message is only available to like 1% of users #1107706955960688650 message
So prolly more people will have the problem but it will either be a small number or it’ll grow the ones that message is rolled out
fossil inlet
Can’t get to computer easily rn so cba to split the pr
odd heath
Fixed in 3509, but I might pull it out because it will work on stable
again arent canary and stable equally broken rn
though @limber skiff you should merge at least that quickly one cuz client crashing bug
fossil inlet
again arent canary and stable equally broken rn
odd heath
i swear to god i looked at this 5 times earlier on and it showed the same for cdanary and stabke
😭
elder plinth
bot should post a link to the most recent post for each version at the bottom
elder plinth
wait they reverted the color picker change?
oh was gonna say im on stable and my "fix" is still working but realized the find im using probably works regardless. makes sense
fossil inlet
if someone wants to merge the fake nitro crash earlier
odd heath
austere talon
oh, was that why it wasn't in common
well it can be in commons
but it would be good to add a note
jsdoc comment
fossil inlet
will do
elder plinth
im now getting color picker like this
export const ColorPicker = findComponentByCodeLazy("showEyeDropper", "BACKGROUND_BASE_LOW");
works in stable
austere talon
try making it compatible with stable
elder plinth
oh
nvm
i hadnt opened my plugin settings
it worked earlier before they reverted smh
ok this works
export const ColorPicker = findComponentByCodeLazy("showEyeDropper", "BACKGROUND_ACCENT");
loading fine on stable ptb and canary
the difference seems to be between BACKGROUND_PRIMARY and BACKGROUND_BASE_LOW 
fossil inlet
I went for ```ts
export const ColorPicker = waitForComponent<t.ColorPicker>("ColorPicker", filters.componentByCode("#{intl::USER_SETTINGS_PROFILE_COLOR_SELECT_COLOR}", "showEyeDropper"));
yeah
elder plinth
convenient I randomly downloaded the modules earlier before it reverted
fossil inlet
convenient I randomly downloaded the modules earlier before it reverted
i always have a old version
fossil inlet
hover over it with vencord compnaion
elder plinth
idk what you mean
fossil inlet
austere talon
insane
elder plinth
yeah im good with my find :^)
fossil inlet
looks like not all plugins required color picker in the past
should they be updated to require it
(looking at clientTheem)
austere talon
(looking at clientTheem)
is there even any way to get to those settings without loading them
fossil inlet
is there even any way to get to those settings without loading them
bit confused, what loads the color picker for client theme settings
austere talon
bit confused, what loads the color picker for client theme settings
opening settings loads it
elder plinth
I went for ```ts
export const ColorPicker = waitForComponent<t.ColorPicker>("Col...
do I need to be worried about using findComponentByCodeLazy vs waitForComponent(...filters.componentByCode)?
austere talon
the latter is an internal method you shouldn't use
just use the former
but ultimately it doesnt matter
fossil inlet
opening settings loads it
... but if it isn't required, then why did it error with fakeprofilethemes
austere talon
... but if it isn't required, then why did it error with fakeprofilethemes
wdym
try it urself
ctrl r
immediately go to clienttheme settings
fossil inlet
with
wait
is that just unrelated and i'm stupid
yeah...
<@&1073655264923881602> @limber skiff
austere talon
the thing that's erroring is UserProfileStore.getUserProfile().bio
fossil inlet
is there even any way to get to those settings without loading them
how is it loaded when just going through the badge without settings
austere talon
badge?
fossil inlet
it doesnt error, i just have no idea how the color picker is loaded
or maybe it isn't lazy anymore
austere talon
it just works
fossil inlet
guhhh i need to see if it's lazy or not now
fossil inlet
love
fossil inlet
i'd defer to nookies on that one
austere talon
why not just remove this?
austere talon
i'd defer to nookies on that one
well yeah not this PR
fossil inlet
why not just remove this?
doesnt hurt anything, keeping incase children become anything that starts with an identifier
feel free to remove if you want
opaque silo
what should we do about ClientTheme now
just make it a wrapper on that experiment
fossil inlet
@austere talon do you know if this has any other purpose other than loading the color picker
grave mangoBOT
<@343383572805058560> do you know if this has any other purpose other than loadi...
CreateCategoryModal.tsx: Line 27
export const requireSettingsMenu = extractAndLoadChunksLazy(['name:"UserSettings"'], /createPromise:.{0,20}(\i\.\i\("?.+?"?\).*?).then\(\i\.bind\(\i,"?(.+?)"?\)\).{0,50}"UserSettings"/);
would turn openmodallazy to openmodal if that matters
austere talon
it doesnt matter
fossil inlet
seems to still work, I can only assume it was there for color pciker
leaving it there because no reason to remove
it's also exported from the plugins default object, but doesn't seem to be used anywhere
weird.
austere talon
nice
fossil inlet
looks like it's compatable with stable and canary
haven't tested, just looking at the reporter
austere talon
crazy thatBetterFolders didnt break for once
austere talon
thanks for the fixes 
fossil inlet
thanks for the fixes <:mona_love:1261429885939744788>
np
the fakeprofilethemes things looks like it leads to a whole other can of worms and logic errors
charred monolithBOT
austere talon
np
the fakeprofilethemes things looks like it leads to a whole other can of wor...
wdym?
vtest dev
grave mangoBOT
index.tsx: Lines 136-138
UserProfileStore.getUserProfile(UserStore.getCurrentUser().id).bio
) ?? [0, 0];
const [color1, setColor1] = useState(existingColors[0]);
index.tsx: Lines 135-137
const existingColors = decode(
UserProfileStore.getUserProfile(UserStore.getCurrentUser().id).bio
) ?? [0, 0];
it gets the colors with getUserProfile
fossil inlet
but it also patches that function
austere talon
in what scenario would ur own profile not be loaded?
fossil inlet
so it's trying to decode colors that will never be present
austere talon
we love
fossil inlet
it also doesn't properly work with nitro colors
if the user has set nitro colors to prefer what should the ui default to
charred monolithBOT
fossil inlet
the colors in the profile or the nitro colors
with the bug rn, it's ambigious
@glass jasper fake nitro crash fixed
fossil inlet
in what scenario would ur own profile not be loaded?
seems like your own profile isnt actually loaded by default
charred monolithBOT
Content
await Util.fetchUserProfile("521819891141967883");
Request Agreement
- [x] I have read the requirements for opening an issue above
fossil inlet
cba to fix rn
fossil inlet
took 30 minutes of finding out that useAwaiter swallows errors
fossil inlet
took 30 minutes of finding out that useAwaiter swallows errors
yes, ik there's a error thing, but it should really log it as well
(if in dev mode)
dusk blaze
vencord salad
charred monolithBOT
fossil inlet
@fallow scarab @glass jasper
glass jasper
<@1107503706229985291> <@929208515883569182>
fossil inlet
https://tenor.com/view/alpha-wolf-you-dare-ping-me-ping-me-you-dare-ping-me-the-...
blame vee for having an <@&1073655264923881602> role lol
scenic brook
You didn't even tag the role lol
prime dew
blame vee for having an <@&1073655264923881602> role lol
You tagged a user, not even the role
prime dew
Real
austere talon
blame vee for having an <@&1073655264923881602> role lol
literally a user
ur so dumb
fossil inlet
literally a user
discord should fix their code
typing @slient should by make the message silent before pinging a user
elder plinth
@silent<enter> tags first user named silent
@silent<space> uses the silent feature
<@&1073655264923881602> @fossil inlet
unless I just tagged someone named silent
or is that a role?
this is the role's fault
would have worked otherwise smh
fossil inlet
<@&1073655264923881602> <@521819891141967883>
blame @austere talon for adding a role called silent
austere talon
blame discord for being stupid and making this such an half assed feature*
fossil inlet
also that
fossil inlet
GUHHH WRONG PR TITLE
fakeProfileThemes: fix error when user's profile is not loaded
still maple
discord should ban the name silent
no, they should not have used @ for silent
they should have used # or smth like that
that way no confusion is possible
fossil inlet
or just made it a proper button / switch
you don't understand, the chatbar has to be filled with nitro upsells
fossil inlet
wait what's the point in creating state if it will never be used
or is this just something that discords linting didn't catch
austere talon
where
limber skiff
😭
odd heath
How even 😭 the bundler must've taken it out cuz I don't think anyone would actually do that
Insane
fossil inlet
How even 😭 the bundler must've taken it out cuz I don't think anyone would actu...
I don't see how the bundler could have minified passing a ref
It probably just got overlooked in a refactor.
odd heath
Possibly
fossil inlet
Because the value is abstracted by the useref call, static analysis can't mark it as unused.
charred monolithBOT
austere talon
lmao
probably unused variables
but the bundler can't remove them because they could be getters with side effects or could be undefined/null (so throw an error when accessed)
fossil inlet
you would figure they would have some kind of linting for that
austere talon
but the bundler can't remove them because they could be getters with side effect...
this is the funny part of minifying js
you often can't safely remove code
fossil inlet
getters with side effects are evil
austere talon
yop
fossil inlet
proxies are evil
olive aurora
vee loves proxies
austere talon
proxies so good
dusk blaze
yop
pine topaz
https://tenor.com/view/alpha-wolf-you-dare-ping-me-ping-me-you-dare-ping-me-the-...
down, boy.
fossil inlet
charred monolithBOT
toxic forge
not
granite wharf
I don't have a problem with it but vee might dismiss it in favor if hiding it in a useful commit lol
toxic forge
yeah I thought as much looking through the commits
fossil inlet
I don't have a problem with it but vee might dismiss it in favor if hiding it in...
afaik badges aren't for one line documentation changes
granite wharf
Oh definitely not, I didn't look at that part
I wouldn't accept it either for just readme changes x)
fossil inlet
@toxic forge you should fix the failing patches instead
toxic forge
I should sleep bro
charred monolithBOT
woeful sleet
Doesn't look like it from their other PRS
jolly egret
making an alt right now and removing bunny and putting revenge instead just to get the badge
scenic brook
You don't need to make another alt right smh, the one we have is bad enough
charred monolithBOT
austere talon
that is true
limber skiff
true
austere talon
connectStores has been deprecated since like at least 2022 tho idk why they mentioned it
isnt this hellbound
yeah it is
pine topaz
tbh i did possibly even less to get my badge so
charred monolithBOT
spice python
tbh i did possibly even less to get my badge so
https://github.com/Vendicated/Vencord/commit/6573c4757cc1b2e3847c037d254cbdd11653b579
honestly this seems like more work than changing a word and a link in the readme
pine topaz
oh that's what they did
fossil inlet
@austere talon if you want to merge these before it hits stable
glass jasper
<@343383572805058560> if you want to merge these before it hits stable
-# already have
glass jasper
glass jasper
Discord might have also changed a variable
I think that’s only on Canary right now though
Average sadan moment
fossil inlet
@glass jasper i think discord fucked all their css variables
i lied
role color everywhere also broke
we need to fix this before it hits stable
glass jasper
<@929208515883569182> i think discord fucked all their css variables
Nah text-normal just changed too text-default
fossil inlet
yeah
cba to change all instances of --text-normal so just going to alias it once at :root
will change all later
glass jasper
cba to change all instances of --text-normal so just going to alias it once at :...
Find and replace my beloved
austere talon
Online themes also has fucked colours
austere talon
cba to change all instances of --text-normal so just going to alias it once at :...
INSANE
honestly might not be that stupid to add that and keep it for a while
to unfuck themes as well
fossil inlet
INSANE
couldn't get it to work
not that hard to do all manually
so that's what i'm doing
seems like --text-normal was all that was changed
opaque silo
vencord theme compatibility layer
fossil inlet
make
opaque silo
HORRROR
opaque silo
genuinely terrible
opaque silo
so push the new one
fossil inlet
breaks on stable
fossil inlet
no
opaque silo
canary can cope
fossil inlet
so wait for it to hit stable
then there is a period where stable users have bad text
fossil inlet
yeah
opaque silo
instead of all those fallbacks just have a single root --text-normal: var(--text-default, var(--text-normal, white)); with a TODO to update then all?
less changes
fossil inlet
in most cases we could also just use an alias at root, something like --vc-text-primary but that could get messed up if discord overrides their variables later in the tree
fossil inlet
instead of all those fallbacks just have a single root --text-normal: var(--text...
couldn't get that to work
i'm fine doing this and i'm fine doing the work to clean it up after a certain peroid of time has passed
fossil inlet
in most cases we could also just use an alias at root, something like `--vc-text...
also see this
opaque silo
ah okay if theres var prio shenanigans simpler is better
jolly egret
github insane
obviously messed up his own branch
opaque silo
just have a TODO so its not forgotten I think
austere talon
this change sucks just put it on root
jolly egret
I DID NOT CLOSE IT
you did close it because you no longer had anything on that branch left to merge
you pushed out all your changes
fossil inlet
opaque silo
this change sucks just put it on root
sadan says it has prio issues
fossil inlet
sadan says it has prio issues
could*
austere talon
who would override it??
opaque silo
😭
fossil inlet
who would override it??
discord could, but it would be stupid
not counting out discord doing stupid shit
fossil inlet
they do that a lot
stupid stuff or override their own vars
opaque silo
especially in places that follow user theme
opaque silo
stupid stuff or override their own vars
both
fossil inlet
love
fossil inlet
who would override it??
also other themes could set --text-default at some random point to fix some issue
this keeps the original behavior
opaque silo
--theme-default?
opaque silo
no brain
fossil inlet
yop
opaque silo
also other themes could set --text-default at some random point to fix some issu...
YOP
contrast issues and the like
fossil inlet
also other themes could set --text-default at some random point to fix some issu...
i feel like this is a lot more likely
opaque silo
🥰
fossil inlet
@austere talon thoughts
opaque silo
if only you could have vars evaluated at their use instead of their definition
that'd be baller
fossil inlet
if only you could have vars evaluated at their use instead of their definition
you could prob do that with some preprocessor that inlined it
but too much work
@opaque silo you husk yet you just linked scss that you were the last contributor to
opaque silo
scss is unironically so ass at nested slop
but its what ctp discord uses
so I cope
fossil inlet
opaque silo
nop
quick isle
<@508863359777505290> you might want to know about this
js shoot me already
fossil inlet
javascript?
opaque silo
scss is unironically so ass at nested slop
ESPECIALLY MODERN SCSS like seriously its so bad so much boiler plate thats going on
fossil inlet
fossil inlet
this is the best plugin i've ever made
quick isle
cba to change all instances of --text-normal so just going to alias it once at :...
is that all i gotta do
a single replace?
fossil inlet
is that all i gotta do
a single replace?
i'd advise against it
opaque silo
ESPECIALLY MODERN SCSS like seriously its so bad so much boiler plate thats goin...
fuck you explicit loading and @use
fossil inlet
but you can
opaque silo
is that all i gotta do
a single replace?
tell canary users to cope and yeah
fossil inlet
@glass jasper 
opaque silo
tell canary users to cope and yeah
wait for it to hit main and push
odd heath
tell canary users to cope and yeah
The way I cope is to explode anyone telling me to cope
You have 38.523 seconds before explosion
fossil inlet
@austere talon looks like the text changes are on stable
opaque silo
<@343383572805058560> looks like the text changes are on stable
looks like --bg-mod-* vars are also gone
--background-mod-* now
opaque silo
husk
never
oh husk....
it wont immediately break but it wont update anymore on stock themes and themes that drop the var
since its already on main will the fallbacks be dropped
limber skiff
<@343383572805058560> looks like the text changes are on stable
ill fix tomorrow if V doesnt do
I'm tired right now
already going to sleep
fossil inlet
ill fix tomorrow if V doesnt do
i have an open pr
limber skiff
alright
fossil inlet
haven't tested everything
limber skiff
austere talon
discord could, but it would be stupid
just put it on :root as new variable
themes override vencord vars
charred monolithBOT
kindred tree
any chance of this getting merged
dusk blaze
any chance of this getting merged <:blobcatcozy:1026533070955872337>
wait for vee's ADHD fueled PR reviewing session 
tbf it looks mergable
kindred tree
vee did already review it once
limber skiff
@austere talon thoughts about creating vencord aliases for vars in the feature
so we can have for example vc-text-normal which aliases to text normal
which is easier to change globally when something is changed
modest widget
<@343383572805058560> thoughts about creating vencord aliases for vars in the fe...
I feel like that could cause deviations when not all the plugins that rely on those aliases update at once.
limber skiff
huh?
limber skiff
vtest dev
limber skiff
stop being slow 
austere talon
its always that patch thats slow lmfao
it really is slow
that module isnt even big wtf
limber skiff
I dont get it lol
austere talon
its medium size
modest widget
huh?
Say that Discord changes one of their variable names, if the plugins aren't all updated at the same time there's still a chance that they will use different aliases making them inconsistent
limber skiff
@austere talon you remember it better, was the preview bg darker or lighter
they nuked background-secondary
hmm
too dark
austere talon
this looks right
limber skiff
i dont know whats the new secondary var
austere talon
you will find some guy who sent screenshot in support
austere talon
i dont know whats the new secondary var
they nuked some vars
doesnt have to match exactly
just look okay
prime dew
i dont know whats the new secondary var
If it can help
#🎨-theme-development message
limber skiff
thanks
austere talon
they moved GuildStore.getRoles
GuildRoleStore
new store
on canary
need to update everything https://github.com/search?q=repo%3AVendicated%2FVencord+GuildStore.getRole&type=code
fossil inlet
How will this impact Lebron's legacy?
fossil inlet
need to update everything <https://github.com/search?q=repo%3AVendicated%2FVenco...
?remind 2 hours do
shut vineBOT
Alright @fossil inlet, in 2 hours: do
austere talon
i would just do this temporarily:
export const GuildRoleStore = findByPropsLazy("getRole", "getRoles");
so it's compatible with stable + canary
charred monolithBOT
fossil inlet
i would just do this temporarily:
```js
export const GuildRoleStore = findByProp...
Are the functions equivalent or are there different signatures?
fossil inlet
Dev-1
austere talon
identical
fossil inlet
Alright <@521819891141967883>, in 2 hours: do
I lied, I'm doing it now.
charred monolithBOT
austere talon
no you aren't
fossil inlet
no you aren't
i just did, wdym
austere talon
are u fixing the css colour stuff?
austere talon
<@343383572805058560> thoughts about creating vencord aliases for vars in the fe...
sounds good
also allows themes to more easily theme vencord specific stuff if they want to for whatever reason
fossil inlet
are u fixing the css colour stuff?
yeah, just got home
odd heath
fossil inlet
is there no index.css file or something like that
odd heath
is there no index.css file or something like that
I eated it
fossil inlet
next to where we init margins?
doesnt make that much sense
margins are computed, this is static
limber skiff
i know
fossil inlet
id just touch src/index.css and import that from vencord.ts
austere talon
where should I place the css for the aliases
src/global.css ?
limber skiff
ig
austere talon
.vcshc-auar-cter-pd-btn
fossil inlet
vencord will use css modules with no mangling for easy imports
austere talon
how tf do you css modules without mangling
fossil inlet
how tf do you css modules without mangling
actually, you could prob mangle by the plugin name
but too
austere talon
actually, you could prob mangle by the plugin name
write a custom esbuild + postcss plugin for it
fossil inlet
@austere talon fix
austere talon
<@343383572805058560> fix
i did 
fossil inlet
write a custom esbuild + postcss plugin for it
not that hard
already did something like that for my userscripts on other websites
austere talon
then do it
fossil inlet
soon
modest widget
insane class name
Nothing like
.javascriptMaterialdesignGm3WizTextFieldFilled-text-field-- invalid:not(.javascriptMaterialdesignGm3WizTextFieldFilled-text-field-- disabled).javascriptMaterialdesignGm3WizTextFieldFilled-text-field-- focused+.javascriptMaterialdesignGm3WizTextFieldFilled-text-field- helper-line
fossil inlet
i did <:bruh:1057461680575098890>
-> dev
austere talon
it's in dev3 buckaroo
fossil inlet
im based off dev
austere talon
youre cringed off dev
olive aurora
normal
limber skiff
https://github.com/Vendicated/Vencord/pull/3518/files @austere talon look
salad
so many changes due to formatting 😭
fossil inlet
@limber skiff isn't the whole point to use vencord vars instead of just --text-normal
limber skiff
I FORGOT
fossil inlet
also is there any reason to import as file instead of just import ./globalStyles.css
limber skiff
cuz that doesnt work lol
css imports are done by bundler magic
we only have bundler magic for plugins
fossil inlet
cuz that doesnt work lol
fossil inlet
we only have bundler magic for plugins
then how do all the other things (vencord settings, notifications, etc...) do css
or do those all get globbed by the plugins build
@limber skiff did discord remove --bg-overlay-3 or is there another reason to use -5
limber skiff
overlay 3 is the same as the background lol
fossil inlet
😭
limber skiff
so it does nothing
limber skiff
I cant find where the css is being inserted 😭
austere talon
vencord-css-core
limber skiff
austere talon
gets put into this
austere talon
these are managed css
any directly imported css gets bundled into the vencord css bundle and applied always
fossil inlet
@limber skiff did you just find and replace all --text-default 😭
there are some that can't be replaced
limber skiff
how
limber skiff
that doesnt explain how
fossil inlet
i might be going crazy
limber skiff
vc can conflict with voice chat
fossil inlet
vc can conflict with voice chat
does discord actually use --vc for voice chat
fossil inlet
😭
austere talon
vc can conflict with voice chat
we use vc prefix everywhere
limber skiff
I think for a var it might be safer to use vencord
limber skiff
we use vc prefix everywhere
yeah but classes
discord compiles classes differently
I could change it to vc but vencord seems a bit more safe
fossil inlet
we should use vc to stay consistent
charred monolithBOT
austere talon
there
fossil inlet
make change
push
changes
pull
nookies has already done it
limber skiff
WHO PUSHED AGAIN
austere talon
which sadanifier did
limber skiff
😭
fossil inlet
it's based on dev but has dev changes
somehow didnt merge into dev properly
limber skiff
fossil inlet
what does the ! do
austere talon
what does the ! do
shell
fossil inlet
ah
fossil inlet
without it it gets interpreted by git
how does git interpret it
is there some git scripting lang?
WHY ARE THERE 2
limber skiff
@fossil inlet those format changes were automatic or did u do it
fossil inlet
<@521819891141967883> those format changes were automatic or did u do it
i have some vscode extension that fucked up formatting on save
didnt notice until lint failed
austere talon
ofc its prettier <:husk:1026532993923293184>
we literally set the formatter
did you open the individual file instead of opening the vencord folder as project
fossil inlet
we literally set the formatter
thats typescript dummy
limber skiff
we literally set the formatter
not for css lol
austere talon
ohhh css files
we should configure for css
yea
add in the pr
to settings.json
fossil inlet
so easy
limber skiff
😭
austere talon
explode
modest widget
"[css]": {...
limber skiff
thats horrible lol
limber skiff
V is getting angry
fossil inlet
V is getting angry
this was all a ploy to annoy vee
fossil inlet
yop
fossil inlet
true
modest widget
why is prettier so dogshit
It's intentionally opinionated a certain way apparently
... Seemingly not the most "pretty" way.
fossil inlet
GUH
fossil inlet
GUH
@clever sierra how do i fix this
@austere talon do you want default formatter or stylelint
stylelint is what is in the extension recomendations
austere talon
which one looks less dogshit
fossil inlet
which one looks less dogshit
given you prefer this, idfk
austere talon
no i dont??
limber skiff
that's so bad
austere talon
the upper one is better
fossil inlet
oh
limber skiff
choose the one that doesnt do it
fossil inlet
im stupid
austere talon
the bottom one is ugly
limber skiff
😛
fossil inlet
i thought it was a suggestion
austere talon
😭
wait does vscode embed it directly or does it proxy via github
what if i put grabify image into the pr comment
fossil inlet
wait does vscode embed it directly or does it proxy via github
ghpr ext
austere talon
would it expose ur ip
fossil inlet
wait does vscode embed it directly or does it proxy via github
looks like gh proxies it
and it prob just embeds content directly
quick isle
<@508863359777505290> you might want to update your themes for the new --vc- var...
whart
austere talon
ignore sadanizer he has lost it
quick isle
whats the point of all this again?
fossil inlet
whats the point of all this again?
eaiser if discord ever renames their things
modest widget
whats the point of all this again?
So that if Discord changes their variables things don't break as badly
quick isle
eaiser if discord ever renames their things
ok but what about bd users?
fossil inlet
ok but what about bd users?
what's bd only really used for parts in vencord plugins, not discord itself
austere talon
the vc- vars are just aliases for discord vars used in vencord
themes don't have to care about them
just keep changing discord variables like before
sadan just insane
fossil inlet
guh
austere talon
guhh now I have to update catppuccin theme
no u dont
sorry i deleted ur message on accident sadanizer
fossil inlet
sorry i deleted ur message on accident sadanizer
vee trying to prevent me from sleeping
insane
austere talon
quick isle
~~what's bd~~ only really used for parts in vencord plugins, not discord itself
then whyd u ping me 
austere talon
because he's insane 😭
fossil inlet
see the message vee deleted
austere talon
it's just so that if discord changes their variables again like now, we just have to update our variable and not every single plugin using it
opaque silo
no u dont
yes because if you modify the text var further down it doesnt apply to the vc vars
austere talon
true
why does css work like that
so weird
so yes we can't do this @limber skiff
limber skiff
what happened
austere talon
yes because if you modify the text var further down it doesnt apply to the vc va...
^
:root {
--cool-variable: var(--text-default);
}
div {
color: var(--cool-variable) !important;
}
body div {
--text-default: red; /* --cool-variable won't be red */
/* have to add this for it to be red: */
--cool-variable: red;
}
so we can't do an alias
css so dumb
good catch cookie 👩🍳
fossil inlet
i was saying this last night
but i also forgot about this so
limber skiff
but thats fine isnt it?
limber skiff
bruh
austere talon
and this wont work either
limber skiff
for that i still used text-default
austere talon
we cant do the alias variables
opaque silo
horror
olive aurora
husk
opaque silo
and this wont work either
this'll work cause of specificity I think (just make that text-default)
austere talon
would it be possible to do something with @property
nop
dusk blaze
saladizer
shut vineBOT
@fossil inlet, <t:1751052640:R>: do
woeful sleet
Y'all is crazy for even trying. Just assimilate
jolly egret
Any plans to add gradient role support to RCE?
right now stuff like user pings just show the primary colour
i'll look into it myself at some point if nobody else does but it shouldn't be that bad
ShowMeYourName is broken on stable now im pretty sure
you could push the changes
fossil inlet
ShowMeYourName is broken on stable now im pretty sure
Iirc fix is in dev
jolly egret
i know it is
austere talon
this extension is so funny
okay but this formatter is ugly
prettier looks better
just get rid of the formatter config
whats trhis for? @fossil inlet
did you remove the other one intentionally?
austere talon
🤫
charred monolithBOT
fossil inlet
whats trhis for? <@521819891141967883>
I don't think that was me
austere talon
found 3 more vars
austere talon
i pushed ur pr manually via this @fossil inlet
easier to just redo the changes myself than to undo all the formatting horror
austere talon
Advaith back at discord and already refactoring code like mad
should i bump chrome ext again 😭
kinda annoying we just released one
i dont get this pr Vendicated/Vencord#2446
the premise is cool but why did they throw 3 million unrelated changes into it
writing their own reporter, updating dependencies, build script, editing lint config, etc
fossil inlet
Advaith back at discord and already refactoring code like mad
Did he get hired or is he there for another summer internship?
austere talon
idk man
fossil inlet
i dont get this pr [Vendicated/Vencord#2446](https://github.com/Vendicated/Venco...
Would you be open to another separate one without unrelated changes
Been wanting to do it for a while, but never did because that one existed.
austere talon
Would you be open to another separate one without unrelated changes
yeah
- Create
packages/discord-types - Move everything relevant from the discord-types package we currently use over and update them
- Move everything from webpack/commons/types over
- Set up npm publishing config as <@&1172711119585034311>vencord/discord-types
austere talon
did discord fuck up or why is there just the `@` highlighted
zwsp role name lmfao
austere talon
nah?
fossil inlet
yes
austere talon
yeah
1. Create `packages/discord-types`
2. Move everything relevant from the di...
should I set it up?
the package and structure
austere talon
let's make it some permissive license tho
fossil inlet
ofc
austere talon
LGPL3.0 best probably
austere talon
LGPL is better so people are forced to contribute back imo
fossil inlet
what's the orig discord-types one
austere talon
MIT means someone can just steal and use in their proprietary client mod
fossil inlet
because if we're starting from there we might need to keep the same one
austere talon
well they're so outdated and partially wrong
we might as well just not base on it at all
also types might not even be copyrightable anyway
austere talon
LGPL is better so people are forced to contribute back imo
LGPL: If you are modifying it, it's like GPL where you have to publish source. But if you only use it as library, you can use it under MIT terms
fossil inlet
yeah, i know what lgpl is
just dont want to violate license of orig discord-types
@agile laurel are you the one who did discord-types
(same username)
austere talon
it is yeah
but really it will probably be faster to just remake from scratch
since a lot of it is outdated anyway
fossil inlet
do you mind if we base the vencord version off yours and use lpgl
if not we will just remake from scratch
austere talon
just use this 👽
agile laurel
<@474322346937810955> are you the one who did discord-types
hi
r u wanting to change the license
i dont do client mod shit anymore
austere talon
we are making @vencord/discord-types a reality
just a revived, updated and much more complete discord-types
(gonna publish to npm)
agile laurel
r u gonna use the gpl license
fossil inlet
lgpl
agile laurel
lgbt
fossil inlet
LGPL: If you are modifying it, it's like GPL where you have to publish source. B...
lgpl tldr
agile laurel
yeah id prefer if u use the lgpl license cuz im a libtard but like theyre not even my property anyways so if u wanted me to change it i wouldnt care
fossil inlet
yeah id prefer if u use the lgpl license cuz im a libtard but like theyre not ev...
alr, thanks!
husk
austere talon
@fossil inlet
fossil inlet
love how you can get patch urls from github
charred monolithBOT
austere talon
i created project and moved all the webpack commons types over
fossil inlet
how do i do my pr now
austere talon
just pr to that branch
fossil inlet
alr
austere talon
i havent moved any of the discord-types stuff over
fossil inlet
thats fine
austere talon
it's recommending the wrong thing guh
fossil inlet
love
fossil inlet
should we just export everything from index
ill worry about that later
but i think so
austere talon
it does recommend the longer path tho
i had to delete @webpack/types for it to suggest the right path
omg why is it stupid
nvm it works
okay reorganised
will push
fossil inlet
50 merge conflicts my beloved
charred monolithBOT
austere talon
okay I just made it so you can only import from index
i think thats better
just make sure no name conflicts
aka give stuff good names
fossil inlet
yop
austere talon
i'll remove @webpack/types from tsconfig
outdated userplugins should still compile but will type error
fossil inlet
yeah, esbuild is nice like that
austere talon
or does it error
fossil inlet
does esbuild have to keep it because it could be a runtime import with side effects
austere talon
😭
fossil inlet
idk man 😭
austere talon
if you use it yes
if you only use it as types it wont include it
some renderer parts import types from main and vice versa
fossil inlet
well yeah, but when it exists, esbuild can see it and know
austere talon
anyway i'm not sure about file structure
for most things, one file per object is too crazy
austere talon
but then some other things like Message object take up 200 lines
fossil inlet
but dont just copy from discord-types
im doing that as a base, then updating
charred monolithBOT
austere talon
okay go wild
charred monolithBOT