make a separate proxyArray function again
#๐พ-core-development
austere talon
function proxyArray(array) {
let shouldProxyGets = true;
return new Proxy(..., {
get(target, key) {
if (!shouldProxyGets) return Reflect.get();
if (["splice", ...].includes(key))
return (...args) => {
shouldProxyGets = false;
const result = array[key](...args);
shouldProxyGets = true;
return result;
}
}
})
}
easier than you think
fill that array with all methods that modify array
it should fix it
limber skiff
I will continue tomorrow
austere talon
yeah that's okay
limber skiff
I'm kinda tired right now
austere talon
```js
function proxyArray(array) {
let shouldProxyGets = true;
return new...
but this should work perfectly
i can also do that if you want
push that change
(tomorrow)
austere talon
lmao yeah
fossil inlet
@austere talon i responded to all of your feedback, can you review when you have a chance
fossil inlet
ohh nice u figured out how to open profile and scroll
i give credit for that to my companion extension
so easy to jump from module to module
austere talon
use const enums tho and they should probably be moved to the types file
fossil inlet
use const enums tho and they should probably be moved to the types file
didnt know those were a thing
i tried them in the types file, but esbuild threw an error
esbuild*
austere talon
const enum should work probably
fossil inlet
const enum should work probably
still throw an error with const enum
fossil inlet
i love adding types then finding unsafe usage
austere talon
well maybe fuck the enum
yeah
section?: "USER_INFO" | "BOT_INFO" ...;
do this instead
no enum
austere talon
no
string union is cleaner
no imports and still good auto complete
use interface instead of type
fossil inlet
guhhhhhhhhhhhhhhh
austere talon
and u need to fix the type errors 
fossil inlet
theres a makeRange function lmao
i tried that but it gave the horror of 99999 markers
austere talon
cause u need to use the step argument
fossil inlet
somehow missed the third arg 
austere talon
icon looks meh tbh (and seems off centre)
maybe do this instead
+11
or try some other icons
but other than that its good now
austere talon
actually
you pass custom component to text (why?) so aria-label doesnt work either way
fossil inlet
@austere talon this doesnt feel right
median rapids
that looks horror
fossil inlet
i liked the ellipsis more
fossil inlet
@austere talon i think this looks a bit better
fossil inlet
i eep now
austere talon
it does work
fossil inlet
it does work
Nop
If you ser icon size to 24, 13/20,... is no longer the ideal number
austere talon
set stickToMarkers to false O_O
fossil inlet
set stickToMarkers to false O_O
Then it allows floating point numbers
austere talon
you will figure it out
fossil inlet
Husk
charred monolithBOT
You're right about that (I'm an idiot)
Excuse me!!
I have uploaded a version that I have tested quickly from Russian to English and English to Russian, it should not give any problems now, I have used xxhash64 as I have seen it already used in the project.
Sorry for the inconvenience and I hope that now it works for all cases (probably I have forgotten something).
robust halo
<@343383572805058560> i think this looks a bit better
god dammit
odd heath
god dammit
Why do you even have so many
robust halo
Why do you even have so many
mentally ill
odd heath
mentally ill
Relatable
robust halo
limber skiff
alright got the list @austere talon
"copyWithin", "reverse", "shift", "sort", "splice", "unshift"
that's everything
austere talon
one thing we probably can't ever make work is [...array]
it will spread proxy I think
limber skiff
yeah but that's fine I guess
austere talon
alright got the list <@343383572805058560>
`"copyWithin", "reverse", "shift", "...
how about .concat, does it create proxy array or normal array
and slice()
would be nice if slice and concat worked
austere talon
I mean the elements within
limber skiff
austere talon
does it create Proxy<T>[] or T[]
limber skiff
there are these ones too
limber skiff
what about map?
and reduce
I'm thinking someone may wanna do some operation in those soo
austere talon
yeah
limber skiff
I guess keep proxied
austere talon
probably keep those proxied yeah
limber skiff
"concat", "copyWithin", "every", "filter", "flat", "join", "reverse", "shift", "slice", "some", "sort", "splice", "toReversed", "toSorted", "toSpliced", "unshift"
every and some?
austere talon
`"concat", "copyWithin", "every", "filter", "flat", "join", "reverse", "shift", ...
tbh even some of these are a tough call lol
you might want filter proxied for example
limber skiff
uhmm true
actually no, I don't think so
filter shouldn't return proxied elements, but a proxied array
austere talon
yeah
limber skiff
nono
I was finding the methods first
I guess it's easy, if it returns array then we proxy that too
no need for a list
austere talon
yeah but also avoiding storing proxies in the actual array in splice and such haha
limber skiff
yep
limber skiff
oh well it's all broken now
limber skiff
I'm not sure why
long stream
limber skiff
right
long stream
wait why are we proxying array settings
limber skiff
since it's not a proxy splice is not trigerring deleteProperty
limber skiff
wait why are we proxying array settings
adding support for OptionType.CUSTOM
long stream
ah
limber skiff
which allows anything including arrays, which should save when they are modified
but then we have to be extra careful to not have the methods that modify in place insert proxies into the array
those can't be cloned to settings after
ehmm still not working
oh I see
austere talon
since it's not a proxy splice is not trigerring deleteProperty
huh why
limber skiff
array/target is not a proxy
austere talon
use the proxy not the target xD
austere talon
i forgot what else we talked about it's so long ago
austere talon
xD
charred monolithBOT
limber skiff
i forgot what else we talked about it's so long ago
gotta convert the function calls to jsx
woeful bisonBOT
This tag doesn't exist!
austere talon
right
limber skiff
oops
holaa
okay it works
why do tags even have a enabled prop
it does nothing...
austere talon
idk lol
austere talon
tbh we should just remove the temporary settings probably
limber skiff
so it's not dependent on the ui
austere talon
make changes apply immediately
limber skiff
tbh we should just remove the temporary settings probably
other time other time
austere talon
this looks so cursed
limber skiff
hmm how can I do this
what if I just
plugins.TextReplace.stringRules.0.find
replace this to the nearest plugins.xx.yy
and then we can add support to settings.use(["stringRules.*"])
long stream
austere talon
oh this broke contributorBadge ๐ฅ
rugged spire
austere talon
okay i might be stupid
rugged spire
HMMMMMMMMMMMM I was thinking I should do that with my PR
rugged spire
okay i might be stupid
i am a bit stupid where is the issue
charred monolithBOT
austere talon
that is the issue
rugged spire
i see
rugged spire
and i can disable this horror plugin again
what horror
austere talon
283 Online
rugged spire
serverlistindicators hater....
austere talon
this code goes crazy
okay someone "review" this by testing that all the plugins that were modified still work https://github.com/Vendicated/Vencord/pull/3028
rugged spire
WHY DOES GITHUB MIX FILES AND FOLDERS IN THE SIDEBAR
that just blends in
i'm gonna be so real and admit that i'm just looking at this so I can implement this functionality into unified styles
you will enjoy at least 1 merge conflict
austere talon
okay someone "review" this by testing that all the plugins that were modified st...
one caveat with this is that if you have a setting that toggles stuff on / off, it won't update until you restart even though it could
it would be kinda annoying to implement live updates for that
rugged spire
shrimply just use the settings hook and return null in your component
rugged spire
(don't do this)
limber skiff
its pretty hacky but yeah
austere talon
shrimply just use the settings hook and return null in your component
that works
honestly the smoothest way anyway
austere talon
one caveat with this is that if you have a setting that toggles stuff on / off, ...
this is fine imo
the settings hook approach can be used
austere talon
wont this mean it calls it twice
once for when you update via ui, once when the actual value is changed
you didn't remove the onChange call settings ui does
limber skiff
LMAOO
limber skiff
alright
scenic brook
this code goes crazy
I like having all these properties in the plugin def for discovery too, this is cool
Like new users not knowing that something like addMessageAccessory exists
austere talon
you should add a short comment explaining what this does exactly
anyway i look later
time to eat now
limber skiff
oh no
oh okay
makes sense
that's annoying
@austere talon im gonna make Array.at return un-proxied
we need a way to get unproxied
austere talon
Settings.plain
limber skiff
but it's soo nested below
austere talon
we need a way to get unproxied
we could also reverse it
inside set trap, check if the value is a proxy and unproxy it
maybe easier than thinking of 3 million methods xD
austere talon
you can
austere talon
export const UnwrapProxy = Symbol("vencord.settingsproxy.unwrap");
get(target, key) {
if (key === UnwrapProxy) return target;
},
set(target, key, value) {
value &&= value[UnwrapProxy] ?? value;
}
austere talon
```js
export const UnwrapProxy = Symbol("vencord.settingsproxy.unwrap");
get(ta...
this should be all that's needed
and then you can remove all the wrappers for stuff like .splice
it should work fine then
it will try to store proxies but the set trap will unwrap them to the plain value
this way you can straight up dump the proxies inside the array without worrying about it
and stuff like arr[0] = arr[1] will magically work
limber skiff
of course something didnt work...
austere talon
did you forget to implement the IS_PROXY one
austere talon
show full code
limber skiff
oh
my array got fucked up somehow
I can remove makeArrayProxy again...
that was smart vee
way more simple now haha
however setting pindm category color still doesn't work
rugged spire
what horrors have i found just by being bored and clicking buttons
why does discord devtools have a potions tab
yeah makes sense
long stream
yeah makes sense
woah a staging endpoint
austere talon
destructuring objects doesnt work either
yeah
bit annoying but there isn't a good way to fix it
austere talon
for arrays it's clear, use slice() or concat() to make a clone
limber skiff
it's a state, and just changing the property wont work
austere talon
but for object there isn't anything like that 
austere talon
it's a state, and just changing the property wont work
it should work but you need to sub to settings store
somber thorn
but for object there isn't anything like that <:think:1283081430175449099>
structuredClone? โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโ
somber thorn
oh okay fair โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโ
limber skiff
should I make the dms category no collapsable @austere talon
austere talon
should I make the dms category no collapsable <@343383572805058560>
yessss
either that or make it super clear that it's collapsed
or make it an opt-in setting
austere talon
i was like wtf u deleted so much settings proxy code then I realised it's code you added (i thoughjt you removed old existing code LOL)
austere talon
it's all done I will just add this one thing now
look at that PR it should be good now probably unless i forgot something 
oh yeah also someone test all plugins
i already tested a bunch and all work
limber skiff
ya wait
austere talon
did u fix the category colour changing
limber skiff
yeah
austere talon
this hurts me so much
austere talon
this is so bad ahahaha should we just make some form of static logger
we keep creating new loggers inline everywhere ๐ญ
we could do either of these to make it a bit nicer
Logger.TextReplace.error("balls");
Logger.error("TextReplace", "balls");
alright that's it
austere talon
this could potentially be extracted into a notifyListeners function to reduce duplication
limber skiff
nit: this can never be undefined at that point so === is more accurate :P
I prefer doing !=
it's good to check for both in the same place
austere talon
yeah but it can never be undefined at that point like i said
you're checking for exactly null
limber skiff
ehh
austere talon
typeof undefined is not object
limber skiff
alright fair enough
austere talon
the other one hurts me
it's pretty cursed to create a pointless wrapper function on top of it instead of using the function directly
anyway besides that few feedback i left it looks very good now
but we should thoroughly test all plugins affected to make sure there are no weird edge cases we didn't notice
same goes for my PR that changes the APIs
limber skiff
should be fine to just return here
if a connection open happens after it will init and have the userId
austere talon
anyway besides that few feedback i left it looks very good now
but we should t...
much better and more powerful than the initial draft too
see this is why API changes should be discussed properly instead of rush merged
I mean I kinda get it cause I haven't been very active for the past weeks but still
austere talon
if a connection open happens after it will init and have the userId
yeah thats good
rugged spire
I find the other sooo ugly
what is the other way of doing this
limber skiff
if (...)
something()
rugged spire
thats ugly
limber skiff
yes I find it too
austere talon
what is the other way of doing this
if (index === rulesArray.length - 1)
rulesArray.push(makeEmptyRule());
this is god awful I hate this as well โฌ๏ธ
if (index === rulesArray.length - 1) rulesArray.push(makeEmptyRule());
but the one with newline is chefs kiss to me
rugged spire
-----------------------------------------------
this is god awful I hate this a...
WHAT IS WRONG WITH THAT
long line?
austere talon
these are my nitpicks lol
it doesn't really matter much but it's weird to change it retroactively and it should be consistent per file at least
it doesn't have to be consistent in the entire project but it shouldn't be mixed in the same file
rugged spire
```js
if (index === rulesArray.length - 1)
rulesArray.push(makeEmptyRule());...
this with just return or a very short statement is ugly imo
rugged spire
vee will explode my PR for this
austere talon
discord already does the same everywhere they use div for a button
you can just wrap it in Clickable
it's much cleaner
rugged spire
clickable also allows keyboard clicks
austere talon
<Clickable onClick={} onContextMenu={}>
<h2>hi</h2>
</Clickable>
How
limber skiff
and the other component which discord has is a h2 too
austere talon
the h2 doesn't support keyboard
limber skiff
tabindex does it, no?
austere talon
and the other component which discord has is a h2 too
yeah because it's not a button ๐ญ
austere talon
tabindex does it, no?
no
you can focus it but not click it
you can press buttons with spacebar / enter
for this it uses Clickable too
just wrap in Clickable it's so quick
limber skiff
austere talon
it doesnt have any styles so it should look the same
rugged spire
for this it uses Clickable too
this button, i don't like this button in particular
limber skiff
just wrap in Clickable it's so quick <:uranium:1329736375548772352>
but it's not reallyy needed
what if I just change it to a div
rugged spire
because of how the create group popout keybind activates that popout
austere talon
yes but now look above that
it manually triggers click when you use keyboard
this is important for people who navigate discord with a keyboard
rugged spire
i feel like a decent amount of vencord plugins likely can't be used with a keyboard simply because of how horror discord's focusring system is
limber skiff
this is super ugly lol
limber skiff
now it's consistent
rugged spire
i feel like a decent amount of vencord plugins likely can't be used with a keybo...
oh discord's f6 to switch section completely breaks if you hide the sidebar lol
rugged spire
do the types just suck
rugged spire
austere talon
you can move the onContextMenu back to the clickable @limber skiff xD
limber skiff
yeah but got fix the typings
austere talon
it's hard to type this correctly because you can override tag
by default it's div so you can specify all div options
but you could specify like button tag and then you can specify other properties
we could just hardcode div and if u want non div tag, cope?
(or do it properly with a generic parameter (just hardcode div who cares))
rugged spire
(or do it properly with a generic parameter (just hardcode div who cares))
this
rugged spire
you love me editing to say the opposite after you this'd
is that because typing it would be hell
austere talon
it wouldnt even be that hard with a generic
export type Clickable<Tag extends HTMLTagsIdkWhatThisUnionTypeIsCalledButItExistsSomewhere = "div"> = ComponentType<PropsWithChildren<ComponentPropsWithRef<Tag>>>;
perfecttt
limber skiff
why
austere talon
export type Clickable<Tag extends ElementType & string = "div">
change it to this
idk if it will fix but this will filter out the non strings (like ComponentType)
austere talon
why
oh because React components are very limited with generics hmm
<Clickable<"span">>LOL</Clickable>
you would have to do this i think
oh
this kills the generic
limber skiff
how so
austere talon
austere talon
i think that does not really do anything
granite wharf
@austere talon can I get a new branch for the rust rw code ive made for the installer
austere talon
nvm i fixed it
charred monolithBOT
charred monolithBOT
austere talon
how can that fix it?
idk what the hell ComponentPropsWithRef is but it sucks
limber skiff
it's the proper way of doing it
austere talon
IntrinsicElements works, ComponentPropsWithRef is borked
limber skiff
this works
austere talon
anyway it sucked before with the entire list
it worked as soon as I changed it to IntrinsicElements
but that was laggy LOL
cause so many fucking tags
like autocomplete took 2 seconds to load
limber skiff
I'm pretty sure ComponentPropsWithRef uses IntrinsicElements internally
austere talon
and there is no use case for using insane tags, this is enough
limber skiff
true
austere talon
Clickable basically just recreates button without button
because button styles are insane
austere talon
and then it's ready
yeah but don't merge yet xD
limber skiff
what are we waiting for?
austere talon
i suggest:
- merge dev into main and release extension
- merge your PR and my PR into dev and test extensively all plugins that got changed
- eventually merge into main again
i wouldn't release those big refactors to browser immediately
limber skiff
sure that seems good
austere talon
just so if we end up finding a regression / breakage it will be easy to fix without having browser broken for a while
limber skiff
have they pushed to stable yet
austere talon
btw we should also test the plugins with fully blank settings
austere talon
have they pushed to stable yet
oh right
frail skyBOT
limber skiff
ugh you gotta be kidding me
frail skyBOT
limber skiff
omg
austere talon
if yes i can add a venbot command
austere talon
can you trigger workflow run with githubapi <:think:1283081430175449099>
niceee
i will add rn
limber skiff
I might just add a way to run patches after a x build number
and then we push with both patches
what do you think?
austere talon
scary
limber skiff
ya
limber skiff
if buildNumber > x run pach
nimble pendantBOT
vh report
Reporter (report, vencord-reporter, test-patches)
Run the Vencord reporter workflow
Usage
vreporter [ref = dev]
@limber skiff no more manual triggering
in other news github finally added no expiry option to fine grained tokens so i CAN STOP ABUSING LEGACY TOKENS
rugged spire
whats the point then
fossil inlet
husk
jolly egret
whats the point then
you can just like ping any of us and we'll run it
austere talon
do you really think i will give perms to everyone ๐ญ
fossil inlet
let contributors run it
rugged spire
change it to contributor and give it a global cooldown
austere talon
acting like being a contributor means much
you can contribute anything claim the role and boom
austere talon
you can just like ping any of us and we'll run it
^
austere talon
acting like being a contributor means much
(not meaning to put down contributors it's just there are some HUSK people with contributor role because anyone who contributed at least 1 commit can get it)
jolly egret
contribute a readme change and spam the fuck out of workflows 
austere talon
(not meaning to put down contributors it's just there are some HUSK people with ...
like these guys... very evil
manti would get bored and spam 200 workflow runs
fossil inlet
(not meaning to put down contributors it's just there are some HUSK people with ...
adds command so anyone with any commits can get contrib role
People with one commit can get contributed role
Mfw
austere talon
duh..?
jolly egret
i mean thats what the role is there for
austere talon
we already have "contributor but more gatekept so only sane people (mostly) have it" it's called regular
jolly egret
lmao
rugged spire
we already have "contributor but more gatekept so only sane people (mostly) have...
nop
there are totally insane regulars
rugged spire
fossil inlet
Everyone in this server is insane
rugged spire
>adds command so anyone with any commits can get contrib role
>People with one c...
tbh it seems like overall there needs to be a better distinction between contributors and developers which isn't "regular" role or git log
but also it would be such a hassle
jolly egret
eh i don't think it would be that... hard but its kinda redundant
like you could use the internal vencord contrib list as that is either plugin stuff (people that actually work on the patches) or other notable changes
but like what would you even call that contributor and better contributor lmao
rugged spire
"contributor" and "developer" respectively
jolly egret
fwiw if the only reason is running reporter theres no point in going that far
rugged spire
true
the thing is if you add a "contributor" field to plugins you will get 1-2 line patches for the sake of being a contributor rather than to actually fix things
shy veldt
like these guys... very evil
<3
scenic brook
the thing is if you add a "contributor" field to plugins you will get 1-2 line p...
I mean similar to people adding themselves to Devs for too small things, they'd just get told not to before it gets merged
But also I know I've only been here a few months but it kinda just works fine as is
rugged spire
But also I know I've only been here a few months but it kinda just works fine as...
yop it's a "Not a real issue" but a "Would be neat if there is something for things like that"
scenic brook
Fair
fossil inlet
limber skiff
if buildNumber > x run pach
not possible
patches run too early the way it is currently
before wreq is available
however like this it can work I think
jolly egret
its because you suck !!
limber skiff
https://github.com/Vendicated/Vencord/blob/immediate-finds/src/webpack/patchWebp...
@austere talon what if I port just this file to current vencord?
austere talon
i will have to look tomorrow im gonna sleep soon
limber skiff
if anything I can say file was extensively tested
it's also pretty complex lol
I'll port it to a different pr then
median rapids
(not meaning to put down contributors it's just there are some HUSK people with ...
make it more selective then xd
what if.. 2 commits
charred monolithBOT
jolly egret
FIRE
fossil inlet
rust
austere talon
granite wharf
libvencord is also fully documented in its functionality, examples can be found here on how to use libvencord for patching https://github.com/khcrysalis/Installer-patch/blob/rust-rewrite/crates/libvencord/README.md
granite wharf
ill have u know I wrote that manually
jolly egret
why did that guy ai react lmao
not everyone is bright ๐ญ
fossil inlet
@austere talon how tf do i make a slider in settings that only sticks to integers without having 100 markers
austere talon
check the props
glass jasper
<@343383572805058560> how tf do i make a slider in settings that only sticks to ...
Ahh yes i like having .72 of a connection
scenic brook
<@343383572805058560> how tf do i make a slider in settings that only sticks to ...
It's not a perfect solution but I did this when I was fucking around with sliders a while ago
test: {
type: OptionType.COMPONENT,
description: "",
component: props => {
const [sliderValue, setSliderValue] = useState(settings.store.test || 13);
return (
<Forms.FormSection>
<Forms.FormTitle>Whatever title</Forms.FormTitle>
<Forms.FormText className={Margins.bottom20} type="description">Whatever description</Forms.FormText>
<Slider
initialValue={sliderValue}
stickToMarkers={false}
keyboardStep={1}
minValue={-1}
maxValue={48}
markers={[-1, 0, ...makeRange(6, 48, 7), sliderValue]}
onValueChange={value => {
const rounded = Math.round(value);
setSliderValue(rounded);
props.setValue(rounded);
}}
onValueRender={value => {
const rounded = Math.round(value);
if (rounded === -1) return "โ";
return String(rounded);
}}
onMarkerRender={value => {
if (value === -1) return "โ";
return String(value);
}}
/>
</Forms.FormSection>
);
}
}```the componentProps option 
scenic brook
Obviously ignore -1 bit, I changed the markers to do the multiple of 7-1 thing but the rest is just what I had there already
scenic brook
the componentProps option <:wires:1262562427422244874>
I think the problem was setting the value on change
I don't remember
I did custom component to have the value state
limber skiff
๐
frail skyBOT
limber skiff
all working 
frail skyBOT
nimble pendantBOT
vreport immediate-finds
Now testing! 
fossil inlet
scenic brook
Need to set the first and last marker to be same as min and max value
rugged spire
<:wires:1262562427422244874>
fossil inlet
@scenic brook thanks for that, discords code is horror
odd heath
@limber skiff why no stack?.match but stack.match?
limber skiff
already returns in the first stack?.includes if its undefined
limber skiff
this is being so weird...
odd heath
charred monolithBOT
fossil inlet
HORROR
limber skiff
HOW
fossil inlet
/hj
limber skiff
this was harder than I thought
fossil inlet
i see how it will be nice for massive/crashing changes so you can push out to main before discord pushes to stable
limber skiff
I had to manually require because this is called when the first module is required
austere talon
๐ญ
fossil inlet
i love re-implementing all of vencordnative in c++
austere talon
do we even need this
it seems cool on surface but I don't wanna have 3 million legacy patches in the project and it's really not thaaaat important to fix canary all the time
austere talon
i love re-implementing all of vencordnative in c++ <:blobcatcozy:102653307095587...
WHY
austere talon
why tf are u using cef
limber skiff
do we even need this
it seems cool on surface but I don't wanna have 3 million ...
just have to clean up after
no big deal
austere talon
are u modding spotify or steam or something
fossil inlet
are u modding spotify or steam or something
yop
i plan to re-write everything, but for now, using vecnord as a base for testing
austere talon
yop to what
fossil inlet
yop to what
modding spotify
austere talon
is spicetify that bad
austere talon
fossil inlet
is spicetify that bad
you have to run like 5 cli commands every time you want to change plugins/themes at all
limber skiff
vreport patcher-rewrite
nimble pendantBOT
vreport patcher-rewrite
Now testing!
frail skyBOT
austere talon
imagine if venbot ran tests locally and posted results (we love RCE)
limber skiff
however I cant make this work in reporter
frail skyBOT
limber skiff
it uses the eagerPatches approach which means I cant get the buildNumber before it starts patching
either way it's good to see which ones are failing
austere talon
I thought u insta merged for a second
scary
I will check tomorrow
I'm in bed
(ignore the fact that I was coding/discussion in bed for hours yesterday lol)
limber skiff
(ignore the fact that I was coding/discussion in bed for hours yesterday lol)
lmaooo I noticed
rugged spire
imagine if venbot ran tests locally and posted results (we love RCE)
I love role color everywhere too
austere talon
(ignore the fact that I was coding/discussion in bed for hours yesterday lol)
using laptop feels so awful when you're used to a much faster PC
everything feels laggy
limber skiff
actually why is that so slow
I remember now, the regex for loading chunks includes a bit more
so it loads more stuff
rugged spire
using laptop feels so awful when you're used to a much faster PC
YOP
fossil inlet
:megahusk:
limber skiff
vreport patcher-rewrite
nimble pendantBOT
vreport patcher-rewrite
Now testing!
fossil inlet
arent module numbers derived from the some hash of the file or am i crazy
limber skiff
vreport immediate-finds
nimble pendantBOT
vreport immediate-finds
Now testing!
nimble pendantBOT
vreport patcher-rewrite
Now testing!
limber skiff
ngl this really shouldn't be taking 30 seconds
rugged spire
rugged spire
<:blobcatcozy:1026533070955872337>
this is what happens due to the accountpanelserverprofile patch being broken
limber skiff
this is what happens due to the accountpanelserverprofile patch being broken
how so?
rugged spire
if you open the regular popout
also nothing is clickable
it's infinitely rerendering 
scenic brook
<:blobcatcozy:1026533070955872337>
Blessing in disguise
fossil inlet
might be stupid, but i cant find where methods in VencordNative are defined
nevermind, im very stupid
limber skiff
how is your Spotify mod going @fossil inlet
fossil inlet
good
ive got webpack patching working rn
im creating all of vencord-native in c++
with the v8 api in c
limber skiff
they use webpack too?
fossil inlet
yea
limber skiff
so you can just patch the files then, not sure what's better tho
I know spicetify does that and... yeah
fossil inlet
so you can just patch the files then, not sure what's better tho
i feel like runtime is better because i plan to allow user patches with this
limber skiff
we know how that is
fossil inlet
I know spicetify does that and... yeah
spiceitfy is all dom manip and monkey patching
(i think)
fossil inlet
if ((IS_WEB ? stack?.includes("__webpack_require__") : stack && !stack.includes("xpui.js")) || Array.isArray(v)) {
logger.debug("Ignoring Webpack module factory", stack);
return;
}
btw I wonder if my other implementation of webpack patching would work for Spotify too
the one in the branch I just made
it's way more generic than the current vencord one
limber skiff
well I know it won't work perfectly cuz Spotify webpack likely does not have wreq.e
because no chunks
but that can be changed easily
rugged spire
im creating all of vencord-native in c++
what are you even trying to do
nvm
just your spotify mod
median rapids
pls make something better than spicetify i beg
fossil inlet
pls make something better than spicetify i beg
thats what im doing
you will help me write the native part (i hate c++)
fossil inlet
unless u want me to write it in python
horror
i hate python for anything more than scripting
median rapids
python is ridiculously powerful
fossil inlet
tbh i prob just havent used it enough
compared to js/ts
but also i really dont like not having braces
median rapids
mf is addicted to braces
if you're writing js code well you should have no reason to care abt the braces because the indentation should be already good
fossil inlet
mf is addicted to braces
yop
fossil inlet
nop
median rapids
ven will add donor tier with priority reviews
jagged reef
ven will add donor tier with priority reviews
priority review will still take down to 7 months
fossil inlet
your plugin will be merged in 3-5 Business days
glass jasper
your plugin will be merged in 3-5 Business days
*years
glass jasper
Im not clicking that gng
austere talon
ven will add donor tier with priority reviews
scary
limber gale
will either of these ever get merged ๐
limber gale
or is there anything else i should do on the pr to get it ready? idk no reviews no attention
i guess noone sees the use? its useful since i don't want to scramble the names of files that people may actually want to download/that have no preview, ex. if i send someone my lecture pdfs they should keep their organized names
but ex. image files often have interesting info in their name (datetime of capture, device type, all the stuff in sharex image names) that isn't shown in the UI anyway nor will people be downloading it, so that should be stripped
scenic brook
@fossil inlet I realised that you could just do this and have 100 markers but don't render them all
sliderSetting: {
type: OptionType.SLIDER,
description: "A slider setting",
default: 13,
markers: makeRange(1, 100),
componentProps: {
onMarkerRender: value => {
if (value === 1 || value === 100 || (value+1) % 7 === 0) return String(value);
else return null;
}
}
}```But then that got shot down because discord doesn't render the tooltip if stickToMarkers is true
fossil inlet
<@521819891141967883> I realised that you could just do this and have 100 marker...
I tried that yesterday and it doesn't wirk
scenic brook
It works to not render the markers but not having the tooltip makes it pointless because they can't tell what they're picking
scenic brook
I feel like it looks good but the word opposite is misspelled in the setting desc
odd heath
Atp Just cherry pick my commits for the UI into that branch and make it one whole pr of us two lmao
limber skiff
bros are still in a break
limber skiff
maps are cheaper than closures
this way we avoid creating a handler and a closure for each proxy
austere talon
oh like that
instead of recursively creating new proxies one single proxy that handles all
limber skiff
ya
austere talon
idk it shouldn't really matter tbh
doubt it's enough to be relevant
but sure ig
wait no it still creates a lot of proxy
limber skiff
wait no it still creates a lot of proxy
but only one handler
it still avoids creating the functions and the handler for every new proxy, along with the closure
omg
delet
austere talon
it still avoids creating the functions and the handler for every new proxy, alon...
I would assume js does closures not much different than how you did with the map now
limber skiff
well a closure has access to everything in scope
a map, just what you store
either way just leave it like that, the implementation is pretty much the same, and technically should create less things
remember we proxy recursively soo
junior olive
bros are still in a break
bro this is pissing me off bc surely winter break is over
where is 263.0 stable on mobile
Or a new alpha
limber skiff
why is it pissing you off too lol
jolly egret
bros are still in a break
why didn't we use this for a tag push
limber skiff
because there are conflicting patches between stable and canary
jolly egret
but that affects desktop too?
nimble pendantBOT
vreport main
Now testing!
limber skiff
vreport dev
nimble pendantBOT
vreport dev
Now testing!
glass jasper
bros are still in a break
which I wouldnโt even be surprised if they donโt push todayโฆ cause you had the weekend, then MJK day/ Trumps inauguration yesterday so they prolly actually are still on vacation
limber skiff
they arent working today
glass jasper
Most likey yeah
austere talon
which I wouldnโt even be surprised if they donโt push todayโฆ cause you had the w...
discord staff attended Trump Inauguration real
heady gyro
discord staff attended Trump Inauguration real
Trump 2025
jolly egret
yes
so you're not gonna push any fixes.. at all even during at ime where you could've fixed web?
ยฏ_(ใ)_/ยฏ
like if it affects desktop too might as well just sync web in the downtime between discord updates?
limber skiff
I dont wanna push a fix that's gonna break instantly after
this pr is literally to fix that
austere talon
so you're not gonna push any fixes.. at all even during at ime where you could'v...
it's working fine on stable
the fix is for canary
push fix now = we break stable until discord releases it just to fix canary
jolly egret
meant more for the popover buttons fix
rugged spire
I am busy writing the worst Vencord find ever
odd heath
I am busy writing the worst Vencord find ever
why is it bad
jolly egret
probably some terrible regex
rugged spire
It's worse
I'm reimplementing half of extractAndLoadChunks
in a way to extract a module ID from a list of imported modules
based on where it is used in the code
Alternatively: help me find 789639
there are 2 other similar modules
that look almost the same
THE GAME
limber skiff
Alternatively: help me find `789639`
haven't looked but can you not combine a string + regex filter
use string to find the two that match, then the regex to differ
by using string first the performance will be pretty much the same
rugged spire
This is the module
limber skiff
and the other?
fossil inlet
in a way to extract a module ID from a list of imported modules
if you're looking to do that, i have code that already does that, but it requires typescript
rugged spire
here are some VERY similar modules (one of them does not fit in)
If anyone is wondering what I'm wanting to find, it's the lottie settings icon
rugged spire
do you really need to find it
technically no but i'd rather not implement it again
rugged spire
one has duration:66 and the other duration:90
there are 2 other duration:66 modules.
austere talon
do you want to use the cog
rugged spire
yop
austere talon
- don't
- copy paste the lotti3 json and use it manually
limber skiff
there are 2 other duration:66 modules.
๐ญ
rugged spire
1. don't <:sorrykirino:908467495147544597>
2. copy paste the lotti3 json and use...
INSANE (this is probably the most sane way of doing this albeit it would produce huge code)
granite wharf
@austere talon have u looked at my rust rw yet
I may add another thing on my todo regarding how I check vencord version
glass jasper
they arent working today
Actually speak of devil they turned back on their Auto Publish bot... still haven't to stable tho
limber skiff
vreport dev
nimble pendantBOT
vreport dev
Now testing!
nimble pendantBOT
vreport dev
Now testing!
limber skiff
you gotta be kidding
austere talon
we should merge dev into main and release then
austere talon
<@343383572805058560> are you still planning to review my other pr today?
im gonna sleep now but tmrw i will
i was gonna today but i slept way too late so i slept the whole day ๐ญ
sorry
limber skiff
we should merge dev into main and release then
but now there is another
and it's even worse cuz it's an API
austere talon
could either make patch compatible with both or just add two patches one for stable one for canary then release
charred monolithBOT
SortForumsByUnread
SortForumByUnread
Allows sorting forum posts so that unread posts are at the top
limber skiff
@scenic brook btw you should settings.use inside your context menu to provide re-activity to pressing the checkbox, instead of having to close the popout
@austere talon LMAOOO
LOOK AT THE TYPO IN THE RETURN
it has been like this for soo much time probably ๐ญ
fossil inlet
did they fix a typo in their codebase or is that a vencord bug
limber skiff
Vencord bug
fossil inlet
๐ญ