we are proxying our target
#👾-core-development
limber skiff
austere talon
i know but
const { foo } = findLazy(...);
if foo is a string
how do you make this work while still being lazy
limber skiff
foo will become a proxy
austere talon
then it doesnt work
limber skiff
well the type will be wrong I guess but
austere talon
you're passing a proxy as string that makes no sense
limber skiff
you should rarely use this anyways
before it would throw errors, now it doesnt at least
it's not perfect but it's the closest we can get
austere talon
it seems really bad because you end up with not strings
how does passing that to className even work
limber skiff
in the old state it would error, now it doesnt error, but may cause an issue in the future depending on how you use
austere talon
are you sure its not turning into [object Object]
radiant reef
Maybe the IDE is bugged
limber skiff
what do you mean the IDE is bugged
radiant reef
Uhm
limber skiff
I'm literally running on discord with it
limber skiff
it seems really bad because you end up with not strings
that's right, the string turns into a function because that's what the proxy is
but will it cause issues besides with typeof, I don't know
limber skiff
I guess it calls toString internally always lmao
austere talon
and how would toString() turn it into a string
limber skiff
and toString is accessing the inner toString
austere talon
right
limber skiff
the actual string value
austere talon
anyway i dont like this tbh
its weird
you rely on it doing some string operation or toString
its really hacky imo
limber skiff
do you want to throw error instead
austere talon
idk what a good default behaviour is tbh
limber skiff
like
limber skiff
idk what a good default behaviour is tbh
the other behavior is the ugly Reflect.get error
heavy cedar
when i tried it out it was like:
the target was 12321321123 and the prop was Symbol.toPrimitive
and i wanted to return obj without the reflect.get
but the return type was supposed to be a function (i think) so i just wrapped it in ()=>
oh yeah that makes more sense
i noticed it would proxylazy the primitive as well but i thought it was normal behaviour so i just only looked at primitives
mb
i made ur change
thanks for helping me
limber skiff
when i tried it out it was like:
the target was 12321321123 and the prop was Sym...
yeah the function it wanted the toPrimitive one
though idk if we are gonna merge it cuz as ven said it's weird for the primitives to become a proxied function
heavy cedar
though idk if we are gonna merge it cuz as ven said it's weird for the primitive...
oh ok
i thought it was allowed bc of this
// meow here will also be a lazy
// `const { meow } = findByPropsLazy("meow");`
like couldn't meow originally be a primitive but since it's lazy it'd be a proxy
is it not supposed to be allowed
limber skiff
yeah but for primitives it doesnt work well
heavy cedar
so is the ideal move to disallow this like u said (throw error) and fix startuptimings using the same tick thing instead
do u want me to try fixing startuptimings still?
limber skiff
okay throw the error
and let me show you how to fix startup timings super easy
that should fix it prob
limber skiff
yyeah it does
rugged spire
@austere talon you should set server icon to the rainbow vencord icon
limber skiff
u should prob make the pr since i didn't rly do anything lol
nah
do it
and put in the same pr
rugged spire
i should probably be posting in #🌺-regulars
charred monolithBOT
charred monolithBOT
limber skiff
good
quick isle
what's the "correct" way to dev vencord? i've just been using vesktop and running pnpm run watch
shell shuttle
every time i update i do pnpm build and pmpn inject
verbal pumice
what's the "correct" way to dev vencord? i've just been using vesktop and runnin...
yeah that's fine
quick isle
yeah that's fine
if thats the best way then maybe it should be added to the contributing docs
austere talon
what's the "correct" way to dev vencord? i've just been using vesktop and runnin...
that works, it's what i use as well
or you can just inject your dev build into normal discord desktop
docs are getting overhauled soon
quick isle
oh nice
limber skiff
@austere talon can I merge this, unless you are against the find accepting an array of string or something https://github.com/Vendicated/Vencord/pull/2283
limber skiff
why tho
regex is not efficient
strings are more than enough
this is like the first case a module only has generic strings which need more than one to match properly
and it's still efficient
let me show you the module lmao
// [EXTRACTED] WebpackModule434479
// WARNING: This module was extracted to be more easily readable.
// This module is NOT ACTUALLY USED! This means putting breakpoints will have NO EFFECT!!
0,
function(e, t, n) {
"use strict";
n.r(t);
var l = n("735250")
, a = n("470079")
, s = n("803997")
, i = n.n(s)
, r = n("481060")
, o = n("858752")
, u = n("294639")
, d = n("697908");
t.default = a.forwardRef(function(e, t) {
let {renderIcon: n, text: a, selected: s, badge: c, showUnread: f=!1, ...h} = e;
return (0,
l.jsxs)(r.Clickable, {
...h,
innerRef: t,
tag: "li",
className: i()(u.containerDefault, d.wrapper, {
[d.modeSelected]: s
}),
children: [f ? (0,
l.jsx)("div", {
className: i()(d.unread, d.unreadImportant)
}) : null, (0,
l.jsx)("div", {
className: d.link,
children: (0,
l.jsxs)("div", {
className: o.content,
children: [(0,
l.jsx)("div", {
className: d.iconContainer,
children: n(d.icon)
}), (0,
l.jsx)("div", {
className: d.name,
children: a
}), c]
})
})]
})
})
}
//# sourceURL=ExtractedWebpackModule434479
it's what does this
and for obvious reasons the classes it uses are the same as the normal channels do
so this ends up only having generic stuff which all other modules have
but having find as an array let me match 2 strings which only this module has both
austere talon
honestly it doesn't seem like u need to actually patch this module
you add your own component after , c right
c is passed via badge prop
limber skiff
yep
austere talon
you can patch the parent and change badge to an array with your element
limber skiff
hmm I see
but at the same time, it doesn't hurt to allow find to be an array
and we can still enforce a single find always
I think this is something in the future will have to be done either way
for a case
so why not now
very minimal changes, the hardest part was the patch helper lmao (to interpret the array)
charred monolithBOT
median rapids
why is it rare
referenced message is only provided over gw iirc
so if you're going back through msg history unless it's cached it's gonna be unavailable
heavy cedar
so if you're going back through msg history unless it's cached it's gonna be una...
yo that's what i was about to say
lol
heavy cedar
i had the comment loaded up
median rapids
charred monolithBOT
charred monolithBOT
Fulfills Vencord/plugin-requests#199
Main feature is changing the timer until your status gets set to idle (or preventing auto-idle forever)
There's also a "grace period" where it'll let you stay idle, even if you come back to Discord
Once you click "Stay idle", you ...
median rapids
whar
@heavy cedar afk: true is required for mobile notifications to be sent if you have an active session elsewhere
heavy cedar
<@421405303951851520> `afk: true` is required for mobile notifications to be sen...
yeah i was planning to let it fire the idle event after 10 minutes like normal
and instead cancelling the actual status change
i rly hope mobile notifs don't check for the status to see if it's idle
heavy cedar
yeah i think a lot of these are like a "this is cool" thing instead of being useful
like the streampreview one
rugged spire
yes
median rapids
i rly hope mobile notifs don't check for the status to see if it's idle
no
also afk != idle
if you're only affecting the auto idle change that's fine
notifications are determined by the afk parameter
heavy cedar
if you're only affecting the auto idle change that's fine
i didn't touch afk at all (i was originally just patching the part where it dispatches IDLE)
hm maybe i should've tested with my phone first before editing stuff
ok i'm just gonna revert to what i had before and then test it with my phone later
median rapids
or did i underestand it wrong
whar
as long as this is still dispatched
and set to true
after the afk timeout
you're fine
heavy cedar
surely the latest one overrides the previous one
fun fact: i did not know about dev mode until now
🥲
median rapids
yes
charred monolithBOT
glass jasper
vee is merging PRs
look forward to when mine is merged
rugged spire
which one
glass jasper
showBadgesInChat#2302
shell shuttle
YIPPIE!!!!
i'm really glad this was merged
because now i can finally add more emotes to my server with ease
glass jasper
we sit here waiting for mine to be merged #2302
limber skiff
lol
jagged reef
we sit here waiting for mine to be merged #2302
We're in the death straits
shell shuttle
i have pinnk name cuz im cool 
jagged reef
no more blue name now yellow name
gg
glass jasper
bruh
jagged reef
we had a deal
rugged spire
i will merge into my fork soon maybe idk
jagged reef
in all seriousness, it's a great plugin
glass jasper
in all seriousness, it's a great plugin
thank you <33
rugged spire
i love finally not having to cherry pick the dev contant commit into new branches
rugged spire
github pr UI is stupid
shell shuttle
ohhh
rugged spire
there are 2 edit buttons
the body of your first message
and the title and other information
i have worried "ono i cant rename this PR" today due to this shit UX
i mean
it also applies to issues
it was an issue I had the problem with
austere talon
huh refinedgithub?
shell shuttle
huh refinedgithub?
yep
austere talon
what does it have to do with it
shell shuttle
got it a few days ago
everytime i try to discard changes to a file
it gives me that error
i didnt know it was related to refinedgithunb
austere talon
ohhhhh
the discard button
i thought u were getting that on the edit button
yeah discard changes is a refinedgithub feature
just fix ur token
rugged spire
how often is dev merged into main
rugged spire
glass jasper
every 2 hours
i’d believe it
charred monolithBOT
sooo this pr seems to patch the Guild thingie row component and check if props.text is GuildHome, then renders its own component
you could just directly patch the parent instead. the component takes a badge property that renders exactly in the position you want. you could just use that property and have a much cleaner patch without the hacky find for the super tiny generic module
limber skiff
@austere talon should I change the patch but keep the array find stuff
austere talon
please add a comment saying that
otherwise someone might see it during refactor and remove it thinking its a "bug"
limber skiff
aight
austere talon
it seems whoever wrote this ui code has no idea how react works, so i recommend learning basic react first with the official react guide
glass jasper
it seems whoever wrote this ui code has no idea how react works, so i recommend ...
that wasn’t me, that was left from the old pr
shell shuttle
vennie eye
charred monolithBOT
for me these two classes are on the same element, so this doesn't actually work
what works for me is changing line 11:
- .messagelogger-deleted-attachment,
+ .messagelogger-deleted-attachment:not([class*="hiddenAttachment_"]),
duplicate of https://github.com/Vendicated/Vencord/pull/2021
you just added half a megabyte of code (bundled & minified). please don't introduce new dependencies so carelessly
spark pivot
we love 3 dependencies adding 21 vencords to the bundle
rugged spire
what the fuck
median rapids
now it's almost a modern hello world example
charred monolithBOT
jagged reef
a
charred monolithBOT
glass jasper
^ I fucked up an accident closed this and now it’s not letting me reopen it so I’m gonna have to just open up a whole new one
brazen bone
@austere talon I think you should make up your mind on that one
austere talon
did i give u suggestion to change it to that
past me is stupid in the head ignore them
what a stupid idiot 
sorry lmao
brazen bone
But it's the non-Webpack version that should be done there, since it doesn't do any webpack stuff (but does access another webpack-lazy object)?
austere talon
yes non webpack version
i mean it doesn't matter really
but yeah xd
the outside lazy is already tracked on its own
brazen bone
Also is rebase+force-push supposed to mess up the commit list in the pr timeline?
austere talon
Hard to keep track of which projects prefer rebase vs merge :/
there are projects that prefer rebase in prs??
why
it makes code review inconvenient
rugged spire
there are projects that prefer rebase in prs??
corporate professionalism bullshit
austere talon
doubt
if u force push it messes up app the review comments and makes it hard to figure out what changes you made after review
rugged spire
if u force push it messes up app the review comments and makes it hard to figur...
horror
austere talon
like usually i review then check the later commit to only review the changes
if u rebase and force push it forces me to read the entire code again
austere talon
if u do prs right (aka one single feature per pr), then you want it as only one commit anyway, so you should squash
as such rebasing during the pr is pointless cause it will be rebased in the end anyway
i always squash + rebase prs so it doesn't matter whether you have clean commits or not
a lot of the time i commit shit as random keyboard smash or other stuff cause it's gonna get squashed anyway
charred monolithBOT
rugged spire
a lot of the time i commit shit as random keyboard smash or other stuff cause it...
horror
odd heath
lyric comet
where does PinDMs look inside the vesktop dir to get currently pinned dms?
before the category update it would look for channel ids inside settings/settings.json under json "plugins": { "PinDMs":{ "pinnedDMs": "ids-here" }, },
but now the json file is unaffected by pinning dms or creating categories
sorry if this considered a stupid question, im not really good at reading js/ts :(
brazen bone
Why would that be in vesktop dir? Somewhere in localstorage would make more sense (probably via DataStore)
rugged spire
horror
using datastore for that
WHY
yop it uses datastore
devs will make DataStore sync list api
charred monolithBOT
charred monolithBOT
Discord as of today disabled lootboxes, so i made this plugin that enables them back
shell shuttle
grrrrr
charred monolithBOT
glass jasper
correct if i’m wrong and i’m slightly sleep deprived so i might be, But won’t discord notice activity on an api that shouldn’t have activity on it and get very suspicious
mortal fractal
correct if i’m wrong and i’m slightly sleep deprived so i might be, But won’t di...
unless the api is set to ignore all checks and instantly suspend you for using it, no
trying to verify your email while already having a verified email used to do that but it wasnt meant to and was fixed
charred monolithBOT
It adds a blank space to the end of the messages sent by the user, so that the height of the emojis (if the message only contains emojis) is reduced as if there was text in the message.
- The character can be changed in the settings.
- The character isn't added if the message doesn't contain any content (e.g. only an attachment) or if it has any links.
Enabled:
Disabled:
charred monolithBOT
tepid knoll
must merge now
add the same channel message sound first or else u will explode /j
limber skiff
likely would need to inject into overlay too to fix that
disable dm call idle has an issue that because of that too
I just never tried to fix it yet
(primarily because first I need to find how to inject in the overlay)
austere talon
its a different process and diffferent browser window
need to edit src/main/patcher.ts
inside the BrowserWindow constructor you need to detect overlay from the properties and override the preload with ours
then inside preload you need to add special handling for overlay
or maybe create a second vencord preload script (now have to update the updater, the horror)
its a lot of effort
tepid knoll
i dont think its a big deal for like the custom sounds one cuz i can simply just disable the overlay i was mostly just curious about it
limber skiff
does it actually need special handling for overlay
austere talon
oh thats u
tepid knoll
ye
austere talon
does it actually need special handling for overlay
well it's a different process and a lot of stuff might not be available i think
we likely wouldnt want to run the entirety of vencord in there
limber skiff
it's the same discord browser window, but with __OVERLAY__ set to true
patching everything wouldn't make a difference honestly
anyways look at #🔧-discord-changes
shell shuttle
tepid knoll
nitro only tho
i might be gaslighting myself but didnt they do some sort of custom sound thing before but it forced u to use server soundboard stuff
lime stone
fakenitro
tepid knoll
apparently its per guild only atm
so individual servers can have their own custom notification sound i guess?
which is probably why its also nitro only cuz u dont set anything really client side oh well
charred monolithBOT
aight it won't affect mobile notifications now (it'll respect the setting in vanilla discord)
you can see here:
^ I'm online (disabled auto-idle) but I'm afk
Also changed the "grace period" thing to this:
shell shuttle
bruh
shell shuttle
wgats the icon look like
magic agate
this one? or this one
shell shuttle
dawn plover
who would want to replace this..
shell shuttle
who would want to replace this..
thats what im sayin
magic agate
idk its fine it took me a bit to get used to not being the original discord icon but honestly i like gay vc better
charred monolithBOT
wary dew
```js
flux: {
SOME_EVENT(event) {
}
}
```
Ah, would it be in the plugin constructor?
charred monolithBOT
glass jasper
I can feel that my pr is abouta be merged
Speaking merged need to finish that plugin so that i can the pr
glass jasper
@jagged reef PR is made
jagged reef
W
magic agate
do i have to do something to pass the test workflow or do i just have to wait on someone maintainer tagged to doo it
jagged reef
do i have to do something to pass the `test` workflow or do i just have to wait ...
If you haven’t had a merge yet, it doesn’t auto test
limber skiff
which one do you want
verbal pumice
oh, is that to save resources
its to prevent randoms from coming in and replacing the workflow with something malicious
but yeah just ask someone like ^^ to run it for you
magic agate
glass jasper
@shell shuttle what does “LGTM” mean?
shell shuttle
<@1167275288036655133> what does “LGTM” mean?
looks good to me
shell shuttle
am i allowed to make reviews and comments like this cuz i don't wanna sound like a nerd or minimod
glass jasper
looks good to me
I have never heard that before, that’s a new one
shell shuttle
I have never heard that before, that’s a new one
i learned it recently too
glass jasper
@jagged reef Yeah the two devs that made it seem too be quite good at this and they made a really good plugin
austere talon
oh, is that to save resources
the reason is cause people kept abusing github actions to mine crypto currency and i think pr workflow runs take up resources from the target repo
magic agate
"LGTM" also stands for 'let's get this money' if you are cool
jagged reef
the reason is cause people kept abusing github actions to mine crypto currency a...
Lmfao
shell shuttle
the reason is cause people kept abusing github actions to mine crypto currency a...
glass jasper
<:blehhhhhh:1223209921621786684>
spark pivot
"LGTM" also stands for 'let's get this money' if you are cool
Ngl I always thought it meant “let’s get this merged”
😭
magic agate
hahaha my coworkers would have liked that
charred monolithBOT
heavy cedar
yeah i tried it a few days ago too and it showed it correctly
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
austere talon
i have an idea
what if we enabled third party plugins by default
so you don't have to always first enable plugins when you're making them
verbal pumice
is it really worth saving the at most 30 seconds it takes to enable a plugin
austere talon
yes
verbal pumice
don't you only need to do that once and you're done assuming you aren't renaming the plugin
what if it enables a broken plugin and then you have to disable like 10 plugins through console cause you dont know which one is the broken one
shell shuttle
what if we enabled third party plugins by default
i like that idea
magic agate
what if it enables a broken plugin and then you have to disable like 10 plugins ...
binary search!
brazen bone
what if we enabled third party plugins by default
Wouldn't be great for things like my repo which has a dozen plugins in it, some of which aren't useful for anyone except me (and a few not even for me)
brazen bone
But I do hacky stuff to get the folder to work at all, I can workaround that too
You can clone the whole repo into userplugins, or you can grab individual subfolders
crude hearth
Merge
rugged spire
what if we enabled third party plugins by default
how
rugged spire
is it really worth saving the at most 30 seconds it takes to enable a plugin
yes it is 100%
lime stone
how do you know if a plugin is
- 3rd party
- new
checking if it's new is easy
does the settings contain that key
3rd party? just add some flag for things in userplugins ig
rugged spire
what if it's a new plugin just in regular plugins that was just created
charred monolithBOT
odd heath
Why are they using query selectors
rancid dragon
well at least they didnt use nested if statements checking if the query selectors returned an element right
rancid dragon
the (multiple?) empty patches 🔥
odd heath
well at least they didnt use nested if statements checking if the query selector...
About that..
long stream
still wasp
I'm not sure if this is the right channel but how could i export/build an installer for a vencord fork?
still wasp
I don't really know how i can be more specific
I made a fork of vencord and id like to send it to my friend in installer format (cli or visual idrm)
charred monolithBOT
rugged spire
@limber skiff https://github.com/Vendicated/Vencord/commit/5636f9d9797bf64170db56447f4bf38f8fadf169 is causing
Error in handlePush TypeError: patch.find.every is not a function
at patchFactories (patchWebpack.ts:190:42)
at Array.handlePush (patchWebpack.ts:85:13)
at shared.eb18f7955c6b0fd48757.js:1:65
error
how did this make it into dev
Ah.
It's all Vesktop psuedo-plugin stuff
charred monolithBOT
Hi, i fixed the css for the readallnotifications button, making it not transparent and making it towards the center and left and right margin not touch other elements of discord.
here is a image,
Thank you -@golonchy
rugged spire
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/webpack-changes/src/webpack/patchWebp...
**patchWebpack.ts: **Line 280
logger.debug("Function Source:\n", code);
rugged spire
It's all Vesktop psuedo-plugin stuff
Basically wherever ```js
if ((patch.find as string[]).every(f => code.includes(f))
isyou are assuming that patch.find did get patched
It is not patched in the case that custom clients like Vesktop try to inject their own patches
You should patch it here if it isn't patched
rugged spire
if ((Array.isArray(patch.find) ? patch.find : (patch.find = [patch.find])).every(f => code.includes(f))) {
code I am using
or similar
woeful sable
Womp womp, L
woeful sable
💕
woeful sable
charred monolithBOT
MessageLatency
Displays an indicator for messages that took ≥n seconds to send.
NOTE
- This plugin only applies to messages received after opening the channel
- False positives can exist if the user's system clock has drifted.
- Grouped messages only display latency of the first message
Demo
Chat View
Clock -ve Drift
livid heath
must merge asap
shy veldt
pissbot on top
topaz spoke
must merge asap
what is this 💀
livid heath
i wonder what it is
almost as if there are comments and code written
its basically when the nonce is higher than than the message id
which is usually the case when your system clock is ahead of the actual time
i say usually cause nonce can be manually controlled
the plugin is not foolproof
topaz spoke
🍞
austere talon
how did this make it into dev
yes it's broken rn
i will partially revert it
and add a dedicated function for registering patches maybe
limber skiff
how did this make it into dev
could be less rude
I tested a lot before merging, I just don't use vesktop and forget about it
median rapids
could be less rude
smh smh
odd heath
theres at least 4 broken plugins/patches on canary
5
time to have a look at stable (theres 3 broken)
limber skiff
reporter fix when <:blobcatcozy:1026533070955872337>
it's fixed just in another branch
odd heath
oh ic
verbal pumice
ba dum tss
glass jasper
discord really has a vendetta
vendetta reference RIP🪦🕊️
odd heath
i think canary and stable are now equally broken
anyway imma look into fixing spotifycommands and showmeyourname
still wasp
Is blocking discord updates a bad idea?
Or atleast prompting people if they want to update before continuing
That way people could stay on the last working version while things get fixed
odd heath
anyway imma look into fixing spotifycommands and showmeyourname
also viewIcons
btw should there be a PR for each plugin or is it fine to just fix multiple patches in the same PR?
spark pivot
Is blocking discord updates a bad idea?
Not really possible
lime stone
btw should there be a PR for each plugin or is it fine to just fix multiple patc...
probably pr for each plugin
odd heath
Feels like I'm an annoyance if I open multiple one line prs but sure
odd heath
didnt see that one ty
limber skiff
i will partially revert it
you could do that in my pr 🙂
charred monolithBOT
charred monolithBOT
i deliberatyle made it transparent via https://github.com/Vendicated/Vencord/commit/8ab56f5bcfe720b8e6d03f85b5f4ada1a18bfc37 to be less obtrusive
if you think this is now too unnoticeable, you can propose an alternative solution but your current pr is very ugly. it would probably be ideal to make it in a similar style as these. as in, use the same colour and stuff
this pr also hardcod...
austere talon
which pr
limber skiff
webpack changes
lime stone
you can pr as one
it means one commit when it's actually merged though
not great for history
lime stone
ig if it's just small changes it's fine
austere talon
"fix broken patches"
lime stone
i think it's generally best pratice to limit scope of commits
austere talon
if u actually make changes to plugins then yeah one change per pr
but these minor fixes that are essentially just a chore irrelevant to history
can be one pr
limber skiff
ig I can put this in my other pr in the next days
can't now cuz not home
but then I can make it more backwards compatible
austere talon
well
i kinda wouldnt
there's no rush to add this feature
like u added it when it's not even used yet xd
what i propose is to export a function to register patches/entire plugins at runtime
then use that from vesktop
this way we won't ever have backwards compat issues again
so add that and when enough time passed we can start making these breaking changes
limber skiff
like u added it when it's not even used yet xd
I mean it was but then it wasn't needed again
but its also in the scope of the other pr
it shouldn't cause any issues if I do it together
and the pr is needed anyways cause reporter
I don't see a reason not to do it now correctly, so someone in the future doesn't have issues with it
austere talon
btw should there be a PR for each plugin or is it fine to just fix multiple patc...
how's that going?
jagged cloak
out of curiosity whats the use case for this
limber skiff
what i propose is to export a function to register patches/entire plugins at run...
but yeah that can be done
austere talon
I don't see a reason not to do it now correctly, so someone in the future doesn'...
tbh im still unsure about array find
why not just regex
array seems weird
regex more powerful
limber skiff
I don't see a reason why to risk regex
It's easy to find a module with more than one string of it
austere talon
as long as u keep the regex simple it shouldnt cause performance issues
and might even be faster than checking the entire string twice or more
limber skiff
the small ones are hard for a single string
austere talon
but perf doesnt matter that much, im mainly thinking convenience
limber skiff
regex seems overkill and a potential cause of performance
limber skiff
as long as u keep the regex simple it shouldnt cause performance issues
and migh...
hmmm the second point is good
odd heath
how's that going?
I can't figure out how to fix the Spotifycontrols
limber skiff
you won me with the second point
austere talon
I can't figure out how to fix the Spotifycontrols
well the current patch is bad anyway
limber skiff
regex is prob faster than checking 2 times
austere talon
whats way easier is changing eK to our own component
and passing eK as a prop
let me do that
odd heath
ok sure
limber skiff
regex is prob faster than checking 2 times
I will do it in the fut
austere talon
well the current patch is bad anyway
you can tell how old that patch is cause it still uses .{1,3}
i learned a lot since writing that patch and wouldn't write it the same nowadays xd
charred monolithBOT
austere talon
I don't see a reason not to do it now correctly, so someone in the future doesn'...
tbh i just want to fix these issues and merge into main today
thats why i just reverted
austere talon
i fucking hate discord bundler config
tbh matching this is a bitch
maybe i can patch eK component instead
limber skiff
tbh i just want to fix these issues and merge into main today
yeah no worries
I can't do any work on it anyways because I don't have my computer
austere talon
whats way easier is changing `eK` to our own component
lol its so unreadable
limber skiff
remove the escaping on {
its not needed
and helps little
also change +? to *?
in case for some reason that prop is the first one in the future
austere talon
we are so back
limber skiff
if you want to bullet proof too do "jsxs?"
austere talon
i had that but
limber skiff
I mean its okayy
austere talon
and its not necessary cause jsxs means it is a .map()
why would they ever map the profile panel
austere talon
yes
limber skiff
I didn't know
austere talon
it's jsx runtime stuff
limber skiff
what difference does it even make
limber skiff
you could put the .jsxs?) in a look behind
limber skiff
nothing, its only for development
wtf
austere talon
its related to giving errors for missing keys
limber skiff
I see
austere talon
actually ig that's semi plausible
ignore that it should be props: { children: ... }
charred monolithBOT
limber skiff
you also wrote jsx when you should have wrote jsxs lol
charred monolithBOT
austere talon
wow
odd heath
just pr the other fixes in one honestly
Don't have anyy
My skill issue turned out too big for Spotifycontrols and pronoundb
And the other one had a pr already
charred monolithBOT
limber skiff
oh yikes
austere talon
is it just pronoundb left now
odd heath
Ye
austere talon
tbh i wanted to rework pronoundb anyway
odd heath
Also pronoundb has some cors error not sure if that's fixable but you might want to look into that (it's pretty annoying because it comes up a lot)
austere talon
instead of the pronoun source, it could have better tooltips
like if u hover it shows both sources
i think pronoundb might just be bad find
odd heath
It probably is
But without knowing what exactly it patched before I couldn't find anything really
limber skiff
you know what
austere talon
yeah its bad find lol
limber skiff
we should start putting other strings of the mod in every patch
so we can try searching for them and finding what used to be patched
odd heath
Yeah
limber skiff
we should start putting other strings of the mod in every patch
in a comment
charred monolithBOT
austere talon
xd
it was easy to fix
the rest of the diff is just refactor
can u run reporter @limber skiff
and remind me tmrw to merge webpack changes so we can get automatic reporter again xd
limber skiff
uh nop
limber skiff
need to merge into webpack changes
austere talon
oh fun
limber skiff
I don't have my pc
austere talon
okay wait
austere talon
conflicts yayy
frail skyBOT
austere talon
right
limber skiff
haha
frail skyBOT
austere talon
how do i fix this
austere talon
it looks like it works anyway?
limber skiff
how do i fix this
first argument
austere talon
false positive?
limber skiff
it's just a broken find prob
I really doubt it's a false positive
the reporter is working fine
austere talon
Also pronoundb has some cors error not sure if that's fixable but you might want...
wtf is a brownout
limber skiff
unless something changed
austere talon
APIv1 of PronounDB is currently in brownout. Service will resume tomorrow at midnight (UTC), but please be advised APIv1 is deprecated and will be permanently discontinued June 1st, 2024.
Make sure to migrate to APIv2 to avoid further service disruptions. https://pronoundb.org/wiki/api-docs
limber skiff
does openAvatarDecorationModal: match a mod?
and does it have a single chunk loading
limber skiff
if it does screenshot it for me
austere talon
