like
#š¾-core-development
rare shale
crude hearth
javascript dev aaaaaaaaaaaaaaaaaaaaaaaaaaaaa javascript dev
nimble plaza
@austere talon idk if you know but theres no reset vesktop button on macos 
crude hearth
"i personally don't care about 100MB ram usage"
nimble plaza
wheres settings file
austere talon
<@343383572805058560> idk if you know but theres no reset vesktop button on maco...
menu bar bestie
crude hearth
BEN
crude hearth
like whaaaaaaaaaaaaaaaa
austere talon
wdym?
crude hearth
thats how discord ended up
crude hearth
guys people have enough ram its okay for app to use 2gbs of memory
austere talon
stop whining who gives a shit
crude hearth
I personally think if you can block it easier like its in pr
nimble plaza
if a native plugin breaks it just bricks vencord
crude hearth
adding something like adguard would be just unneccesary
nimble plaza
cool
austere talon
if a native plugin breaks it just bricks vencord
wdym breaks
nimble plaza
wdym breaks
wont load at all
crude hearth
eh idc about other stuff as long as it does its job
nimble plaza
austere talon
WHY IS THERE DEFAULT
nimble plaza
IDK
austere talon
wtf are u doing
austere talon
you tell me
nimble plaza
crude hearth
whar
nimble plaza
i took that from spotify thingy
nimble plaza
is there any usecase to get anything other than a function from a native file
bc i can just add a check if its a function
crude hearth
ben
austere talon
bc i can just add a check if its a function
i wouldn't
because it shouldn't have any exports
send the entire file contents
put it on https://hb.vendicated.dev or github gist or smth
nimble plaza
also for some reason my userplugin isnt registering any native things
wait no it only does if i export something
both of them follow the same format
austere talon
whar?
nimble plaza
its the same format as the adblock one
but it doesnt export anything
looking at the built, this is different
idk if thatd do anything
nimble plaza
oki
i mean bandage fix is if (typeof method !== "function") continue; but itd be better to find why its doing that
austere talon
btw this update could also enable invidious plugin to work
nimble plaza
what was wrong with it?
austere talon
the internet problem with it is csp
nimble plaza
ohh
austere talon
previously we would have needed to allow any frame source for it to work
nimble plaza
ill make an easy way to allow native plugins to do csp then :3 im lazy
austere talon
now we could have some native api like
addCspRule("MyPlugin", "frame-src", () => getSettings().invidiousHost)
yeah thats what i was thinking
crude raptor
what is happening
austere talon
same for frame patching
nimble plaza
its really shitty but we could steal code from my ipcPlugins pr for frame patching
shy veldt
drop putt party mod src later insallah
nimble plaza
the codes so bad im not gonna release it
it has a clone of vencord's patcher modified for systemjs
livid heath
dw spoko can cope to insane levels for the sake of datamining
nimble plaza
hacky fix for a reason i dont remember
shy veldt
the codes so bad im not gonna release it
i just need to know how to make the debug menu appear
im trying rn
but failing
i know there was check to prevent opening it on prod if it was in an iframe
nimble plaza
ikr
ocean garden
is there a flux event dispatched or something of the sort when messages are loaded from the messagestore?
shy veldt
LOAD_MESSAGES_SUCCESS is when received from /messages endpoint
ocean garden
also, after modifying message.content from something in message store, dispatching the message_update doesn't refresh them on the UI. Any way to achieve this?
I ideally don't want to be running a navigationrouter.transition to every time I update a message
austere talon
it has a clone of vencord's patcher modified for systemjs <:fear:112622023217697...
WHAT
austere talon
WHY THE WHILE () PROMISE.RESOLVE()
shy veldt
tfw it still doesnt work
austere talon
use a setter to do it without polling 
vencord even has a util for this
onceDefined()
austere talon
you're committing crimes against humanity
nimble plaza
yep
nimble plaza
oh?
ocean garden
Is there a way to implement custom hooks?
ocean garden
my bad, something like presendlistener but for other events
misty raptor
not ur bad iām just dumb and not well versed in all this
ocean garden
it's my first time dabbling with plugins too
misty raptor
what if vencord had a modular plugin system wouldnt that be cool
olive aurora
??
misty raptor
like
instead of needing to install a whole other verison of vencord
and then manually add plugins to a plugin folder and then rebuild the whole tjing
what if u could just add plugin from the ui
even better
plugin index
within vencord ui itself
still rules on getting on the index but its more laxed since its not official vencord
charred monolithBOT
turbid hatch
what if vencord had a modular plugin system wouldnt that be cool
easier said than done
misty raptor
whatās the big issue stopping such
turbid hatch
well
many
first, vencord's plugin architecture is not designed to do dynamic loading
second, plugins are written in typescript
and we aren't going to add a typescript compiler to the mod just to support this because of the heavy amount of complexity, and compiling plugins to be independent of the mod is a bit... eh? it seems odd..
yes you could just write javascript, but also that's awful for typing
third, the security implications and general dev effort for very little gain is a bit pointless
misty raptor
have a plug-in file thatās an archive of the transpiled js files along with other necessary files like css
turbid hatch
fourth, web versions can't support them! where are we going to store them? indexeddb is ideal but is async so we cant use it, and localstorage has a very small storage limit
misty raptor
true...
forgor about web version
how long on average does it take a plug-in to get accepted into the real deal
turbid hatch
depends on complexity and whether or not we're busy
ven has other things besides vencord obviously and as the final reviewer for everything it can take time
i'm full time employed so i can take time to do reviews and there aren't many other reviewers
the community can review PRs to assist the effort but in the end ven has the final say on everything
dusky sonnet
i like the fact that i can sorta trust all the available plugins :D
misty raptor
is there like a consistent update cycle
like do yāall check all the prs every other week or smth
turbid hatch
we make updates as necessary but we have no update cycle due to the aforementioned
if something breaks we go all hands on deck to fix stuff
misty raptor
true
junior olive
third, the security implications and general dev effort for very little gain is ...
"very little gain" debatable
ĀÆ_(ć)_/ĀÆ
charred monolithBOT
Just did a distro update and the AppImage seemed to not like this at all. Piping output and errors to a log resulted in a 400,000 line log instantly. If the cursor was moved inside the Vencord window, errors would increase exponentially.
Rolling back my distribution and things are fine again, but I did just want to send a heads up.
Log:
[suse-appimage-vesktop-erro...
misty raptor
would be nice to be able to opt-in for newer plugins that maybe havenāt been fully quality-control checked but have also been confirmed not to be security risks
but if that would be difficult
junior olive
the big gain of modular plugin loading would be to give users the option to easily try plugins before they're added to the mod itself (or maybe never added and only available as a third party plugin)
no faffing around with dev builds
the typescript compiler is a non issue... you just compile to JS before like every other mod
junior olive
security is fair but other mods have figured that out, architecture sure
but it is not "very little gain"
woeful sable
will there be a feature that allows us to import plugins from github directly, through the client
junior olive
Probably not
dire trench
would be nice to be able to opt-in for newer plugins that maybe havenāt been ful...
true
would be nice
turbid hatch
the big gain of modular plugin loading would be to give users the option to easi...
why if most of the plugins that people want to use are integrated into the mod
most of the ones that aren't are niches or are ones we dont want to add due to conflicts with our own ideology (e.g. MLE)
misty raptor
copy from geode
turbid hatch
would be nice to be able to opt-in for newer plugins that maybe havenāt been ful...
and there would be no point to this
we have to review every PR anyway, and part of that is the quality control step
quality control consists of functionality and code quality
misty raptor
yeah but reviewing for āis there malwareā is significantly easier than āis this a premium high quality thingā
as someone who also reviews mods
for a different mod loader
turbid hatch
reviewing for "is there malware" means we have to test it too to make sure it works fine
because why would we bother checking for a minimum feature set to make sure its not malicious
and then come back to it later
we might as well just do it then
verbal pumice
and then you have to review every update
and then youre overall wasting more time than if you just reviewed it once
misty raptor
thatās what iām sayin
junior olive
Vencord's plugin reviews undeniably take a while (at least right now) and I'm not saying this is anyone's fault but it's a undeniable fact, having modular plugin loading could allow users who want to try plugins waiting for review to be added to use them early
turbid hatch
then PR it, i guess
none of us are interested in writing a modular plugin loader, and even then it might not get added to the mod
we experimented with it before
junior olive
mhm
turbid hatch
it didnt go very well
junior olive
I'm not interested in writing it either but there is more than "very little" gain
misty raptor
even without a modular thingy thing
i checked the pull requests and there are some prs that have gone weeks with no response
maybe iām privileged to not have a 9-5 but i feel like thatās something that could be worked on
jagged cloak
sigh
turbid hatch
community can review PRs already
but we dont really want to have people we dont really trust on the review team
junior olive
Afaict all plugins have to go through review by ven which seems like the real blocker (which is fine..? it is ven's mod after all)
misty raptor
i have no idea how the linux kernel review process works
junior olive
I've gone through that shit before i hate it and it is not the same
turbid hatch
linus reviews everything
misty raptor
i know how the geode review process works
we have like 5 lead people who can all accept mods
junior olive
linus reviews everything
no..?
stuff gets reviewed by trusted subsystem maintainers
merged into their own branch
patent minnow
It's on github
turbid hatch
itsn ot
turbid hatch
that's what i mean
so unless this changed this is how it last worked
patent minnow
You wait to be approved in pull requests
misty raptor
either way
junior olive
I highly doubt he reviews all of it, it's already reviewed by trusted subsystem maintainers
misty raptor
this isnāt linux
turbid hatch
no, but i'm saying our process is modelled similar to it
misty raptor
linux has 50 bajillion prs
turbid hatch
ven reviews everything because it's their mod
stuck finch
the big gain of modular plugin loading would be to give users the option to easi...
imo its like really trivial to add custom plugins the way you already can
turbid hatch
well that's what the linux foundation said 11 years ago
i surprisingly do not keep up with how their model works
i do not contribute to the kernel
but that is what i last heard the process being
misty raptor
https://www.schoenitzer.de/lks/lks_en.html
it would be impossible for him to review every commit in a reasonable time
junior olive
uh huh so i am telling ya
misty raptor
thereās too many commits
turbid hatch
and the point is going over your heads so i will no longer engage in that specific part of the conversation
junior olive
https://www.schoenitzer.de/lks/lks_en.html
it would be impossible for him to re...
this + he would add his sign off to the commit and most don't have that 
misty raptor
itās not going over my head
junior olive
and the point is going over your heads so i will no longer engage in that specif...
nah it's not dw
turbid hatch
you're nitpicking on it and not taking the point that i'm trying to make in that ven has ultimate authority and therefore everything goes through them
junior olive
what I'm hearing is there needs to be a bigger plugin review team 
junior olive
be more like linux, have trusted plugin subsystem maintainers that review them and ven merges
turbid hatch
we already do in some cases
existing plugins require their maintainers to review them whenever a PR affects them most of the time
new plugins require ven's approval explicitly
community can file reviews freely and so can existing contributors and certain specific people who have collaborator rights on the repo
junior olive
community reviews don't do shit towards getting stuff in-mod bc they aren't trusted
turbid hatch
they provide basic quality control for people
junior olive
yes
misty raptor
what if there was a vencord ācommunity editionā where trusted reviewers could merge into that branch
dire trench
community reviews don't do shit towards getting stuff in-mod bc they aren't trus...
true
misty raptor
and then ven picks and chooses for their version of the real vencord
turbid hatch
not many people would* use a branch that we dont make the main one
therefore there's no advantage to us
except now we have to maintain a separate version of the mod and provide support for it
misty raptor
would it really have to have separate maintenance if the only difference is more plugins
turbid hatch
yes, because we have to provide support for plugins not in the main version of the mod
misty raptor
isnt it the plugin devās responsibility to provide support for their plugin
nimble plaza
no
turbid hatch
the plugin dev isn't always here
everyone can provide support for anything
that's part of the charm of our support system, a large group of the contributors here know what each and every plugin does
and even if some dont, they know a large majority
splitting the mod off into different version branches and dynamic plugin loading and whatnot will make us lose that
misty raptor
i already scrapped the dynamic idea
turbid hatch
im using it as an example of why we dont want to do things the way you're suggesting
misty raptor
u could make it so in the beta edition, before plugins get merged to the main repo, itās the devās responsibility
junior olive
So does ven have to review updates to existing plugins or just new plugins
turbid hatch
okay
misty raptor
js like third party plugins
turbid hatch
we already have that
junior olive
that's my question
nimble plaza
So does ven have to review updates to existing plugins or just new plugins
updates
turbid hatch
it's called the dev branch
you can git clone, build, and run the dev version yourself
misty raptor
can i merge my plugin into the dev branch
turbid hatch
you can run it as a plugin yes
charred monolithBOT
turbid hatch
src/userplugins or src/plugins/ if it's one you want to end up PRing
misty raptor
does it have to go through ven to get into the dev branch
nimble plaza
yes
turbid hatch
yes
turbid hatch
you can always fork and merge in dev branch changes if you want in your own copy
misty raptor
was i dooming myself by making a pr on whatever main branch there was
should i switch to dev branch
nimble plaza
just use dev branch in the future
patent minnow
so ven has to review new plugins and updates to existing plugins
Only reviewer left for decor
junior olive
anything added to official vencord goes through ven
well yeah but does ven have to do a in depth review of plugin updates, i've seen nuckyz update plugins w/o ven review(?)
turbid hatch
minor fixes and also ven granted permission here
junior olive
mk
turbid hatch
collaborators can make minor changes, we cant accept full plugins or features unless ven says so
junior olive
.
void echo
...was there ecryption???
austere talon
collaborators can make minor changes, we cant accept full plugins or features un...
eh that's not true
as long as it abides with vencord's quality standard it can be accepted fine
it's just that it's mostly me doing review
austere talon
well yeah but does ven have to do a in depth review of plugin updates, i've seen...
nookies, lewi and megu are collaborators
they can technically merge anything
junior olive
it's just that it's mostly me doing review
yeah that's the problem
that's a lot for one person
turbid hatch
it's just that it's mostly me doing review
i tend to see you as the final say since it is your project so i dont want to just go and merge stuff out of the blue when you havent reviewed
im fairly certain everyone else sees it that way too
(otherwise usercss would've been in ages ago :^)
junior olive
If more people were trusted with reviewing plugin code and functionality leaving Ven the final say of merging it as a idea/scope that could help no?
limber skiff
i tend to see you as the final say since it is your project so i dont want to ju...
same
turbid hatch
If more people were trusted with reviewing plugin code and functionality leaving...
maybe so but we dont really trust a lot of people and a lot of the people we do trust have commitments
junior olive
mhm
austere talon
it's not even just trust
you can't just announce someone as reviewer that's not how it works
anyone can review other people's prs regardless of their involvement in the project
if someone were to do that regularly and leave good reviews they would be made a collaborator in no time
turbid hatch
this is why i mentioned that the community can review PRs earlier
austere talon
turbid hatch
and in fact we should probably encourage that more
austere talon
noone does that tho
dire trench
only person ive seen do that is MrDiamond
austere talon
if someone were to do that regularly and leave good reviews they would be made a...
that's literally what nookies did, he just kept making helpful contributions and such so eventually i made him mod / collaborator
turbid hatch
yip
austere talon
i think the only outside contributors who very actively contribute right now are ryan and autumn
maybe im missing someone, don't be mad if I forgot u š
junior olive
Kasi reviewed decor but never submitted a actual review presumably because we thought it didn't matter
spark pivot
only person ive seen do that is MrDiamond
Very basic but necessary reviews, yes
And Iāve made three prs but they are getting buried lol
limber skiff
what prs did you make
limber skiff
that remembers me we have to see if we can bypass nitro requirement for clipping
doubt it but...
nimble plaza
clipping is clientside no?
spark pivot
We bypassed the stream resolution thing I think clips would be similar
When I had nitro I could not figure out how clipping worked
jagged cloak
i could review more since i know what to watchout for but id probably miss a lot so i don't 
and im probably not the only one that thinks thst way lol
long stream
that remembers me we have to see if we can bypass nitro requirement for clipping
if you force enable the experiment yea it works
at least with basic
not sure about non-nitro
distant flax
not sure about non-nitro
works perfectly
distant flax
yeah there was some time where it was available for everyone and now its behind nitro for some reasno
shy veldt
I suppose they upload to some place
its all local
shy veldt
that remembers me we have to see if we can bypass nitro requirement for clipping
also what nitro requirement
teal halo
that remembers me we have to see if we can bypass nitro requirement for clipping
literally just an if statement
nimble plaza
thats curious
go wrapper surrounding discord that skips host updating and doesnt let it store registry keys
charred monolithBOT
does not work
Invalid Location
The specified location is not a valid Discord install. Make sure you select the base folder.
@austere talon how can i find a entire webpack module as a string
is that allowed in a plugin
charred monolithBOT
does not work
Invalid Location
The specified location is not a valid Discord install. Make sure you select the base folder.
wym
also id assume not allowed, if you need to extract something from it use a patch
nimble plaza
whats the usecase
junior olive
Decor loads 2 diff modal modules to use UI components from and discord broke the create sticker one
I need to extract the module id of said modal's module from somewhere else now
junior olive
No like
they broke my find
they seemingly removed the code that would load the sticker module
(it's still loaded from other places, but the load i was finding is gone)
nimble plaza
then either find it from somewhere else or
junior olive
that's what i'm trying to do
nimble plaza
use a patch to find the module and immediately after do $self.modalModule = exports
or whatever the webpack syntax for that is
junior olive
Okay so
I need to get this stuff:
await n.el("54666").then(n.bind(n, "54666"))
it's only in 2 places in discord without opening any server settings etc
junior olive
just
1s
It's in one React.useCallback in 889701 and I patched the assignment of it but it doesn't work bc the definition isn't called until you go to the sticker picker and click create sticker or some shit
you know i think i can just use the 2nd one
ima cry if i can
junior olive
okay @nimble plaza i think i just need a custom find
the other module it's included in is 77162
a memoized component
can't findByCode or findByProps it
nimble plaza
are you on canary (to know if the module id is the same for me)
nimble plaza
{
find: ".default.Messages.STICKER_PICKER_CREATE_STICKER}",
replacement: {
match: /(openModalLazy.+?)(let{.+?)(\d+)/,
replace: "$1$self.modalModule = $3;$2$3"
}
}```
junior olive
that wouldn't work anyways
nimble plaza
wym
junior olive
because it wouldn't get called until the user clicks whatever runs that async function
junior olive
yes i did
nimble plaza
ah ok
junior olive
i did it w/ a find for a diff module
this was the issue with my original patch to do it
nimble plaza
ah
junior olive
the patch didn't really assign until called
const StickerPickerPreview = findLazy(m => {
const type = m.default?.type;
if (typeof type !== "function") return false;
const s = Function.prototype.toString.call(type);
return s.includes("isDisplayingIndividualStickers");
});
is this find ok
nimble plaza
show
junior olive
show what
junior olive
that is the find
nimble plaza
why Function.prototype.toString.call(type);
junior olive
just doing what vencord's byCode does
junior olive
why does byCode do this
.
junior olive
i basically just needed byCode but on a memoized component
nimble plaza
define memoized https://cdn.discordapp.com/emojis/1140326388830851134.webp?size=48&name=bonk&quality=lossless
junior olive
define memoized https://cdn.discordapp.com/emojis/1140326388830851134.webp?size=...
react.memo
charred monolithBOT
junior olive
because it makes the function a object
nimble plaza
OH
junior olive
the actual function is stored in .type on that object
nimble plaza
ohhhh
austere talon
<@343383572805058560> how can i find a entire webpack module as a string
yes but you shouldnt need it usually
junior olive
yea i did smt else
austere talon
just `(type as Function).toString()`
toString() is not stable
junior olive
```ts
const StickerPickerPreview = findLazy(m => {
const type = m.default?.t...
vee is this ok
austere talon
nimble plaza
oh weird
austere talon
```ts
const StickerPickerPreview = findLazy(m => {
const type = m.default?.t...
const filter = filters.byCode("isDisplayingIndividualStickers");
findLazy(m => m.default?.type && filter(m.default.type));
sure
austere talon
toString() is not stable
it shouldnt matter much but its generally better to not rely on prototypes in js world
junior olive
LMAO
austere talon
same reason you should use
Object.prototype.hasOwnProperty.call(someObj, "banana")
over someObj.hasOwnProperty("banana")
junior olive
THIS FIND BREAKS COMPANION š„
junior olive
yop
torpid thicket
is this in progress? It doesn't seem to work with chat logger enhanced
or fakeprofilethemesandeffects
honest viper
It works with fakeprofilethemesandeffects, I'm currently using both
Can't speak on vc logger though
torpid thicket
It works with fakeprofilethemesandeffects, I'm currently using both
ā [ERROR] No matching export in "src/webpack/common/index.ts" for import "showToast"
src/userplugins/fakeProfileThemesAndEffects/index.tsx:12:40:
12 ā import { Button, FluxDispatcher, Forms, showToast, Switch, Text, Toasts, UserStore, useState } from "@web...
that's not decor's fault lol
torpid thicket
what is it?
junior olive
idk
torpid thicket
It only showed up once I tried to use decor
junior olive
did you add decor as a userplugin
torpid thicket
no
junior olive
weird
torpid thicket
junior olive
idk but it's not decor's fault
torpid thicket
I just git cloned the repo that the pull request was submitted from
wait I know what it is
junior olive
did u clone the right branch
junior olive
yeah.. š
junior olive
make sure you switch branch, install dependencies (decor has additional dependency)
dire trench
It works with fakeprofilethemesandeffects, I'm currently using both
you a real one
dire trench
did you add decor as a userplugin
can things break if a plugin meant to be in src/plugins is put in src/userplugins?
junior olive
kinda
austere talon
can things break if a plugin meant to be in `src/plugins` is put in `src/userplu...
usually not
only if they import other plugins
torpid thicket
make sure you switch branch, install dependencies (decor has additional dependen...
I fixed it
dire trench
```
ā [ERROR] No matching export in "src/webpack/common/index.ts" for import "sh...
cuz here this guy has fakeProfileThemesAndEffects in src/userplugins
and its meant to be in src/plugins
junior olive
2 things, one decor has zustand added as a dev dependency for types, two decor adds 2 icons to the common icons file
torpid thicket
I fixed it
ran wrong command in git and accidentally and created new empty branch š¤¦āāļø
junior olive
it's easier just to say "cant use as userplugin" than "you also need to add zustand@3.7.2 as a dev dependency and add these two icons to the common icons"
torpid thicket
how do I use decor?
torpid thicket
it's easier just to say "cant use as userplugin" than "you also need to add zust...
common icons?
junior olive
enable it -> go to profiles in settings
dire trench
i had to add myself to devs too
so wouldnt there be conflict with someone using both decor and fakeprofilethemesandeffects?
in their current state
torpid thicket
enable it -> go to profiles in settings
eyyyy, it works
pine topaz
https://tenor.com/view/memento-mori-unus-annus-gif-19399232
SAME
junior olive
eyyyy, it works
epic
torpid thicket
vid of fakeprofilethemeandeffects and decor
charred monolithBOT
frail skyBOT
void echo
oops
frail skyBOT
shy veldt
thats literally so good idk what you mean ven ššš„°š„°š
austere talon
why in the world
junior olive
why in the world
wait
i didnt quite look at that review
closely
i did proper if statements for verbosity
why remove the else if tho
dire trench
@austere talon you got an example u could show me?
charred monolithBOT
junior olive
@austere talon the themes tab also uses inviteactions
austere talon
<@343383572805058560> the themes tab also uses inviteactions
oh nah thats now changed to use the component
charred monolithBOT
junior olive
austere talon
ya thats basically the same
vesktop also uses that
maybe extract that util to @utils/discord
cc @cunning canyon
austere talon
btw u dont need to put ur images there, we have an image thread issue
but theyre fine there as well
junior olive
I put them there bc i'm using that for decor assets
that's where guidelines are n shit
austere talon
/(\i===\i\.Section\.PURCHASE\|\|\i===\i\.Section\.PREMIUM_PURCHASE&&\i)(?<=avatarDecoration:(\i).{0,800}?)/
this lookbehind is for matching the varname, right?
austere talon
just use .+? then
junior olive
should i do that rn or do you want to review and i commit it
austere talon
ill review
junior olive
ok
austere talon
youre gonna get a heart attack
austere talon
i'll look at the rest tmrw
junior olive
this seems fine
junior olive
oh no
junior olive
19 -> 38 comments
junior olive
fym not even close
austere talon
nah
austere talon
the one below yes cause
if (ids?.length !== 0)
``` is wrongbut the one i commented on no
junior olive
austere talon
<@343383572805058560> p sure i did this for specific reasons
yes but the proposed code is equivalent :p
austere talon
ya
junior olive
ok this review isn't so bad
austere talon
yeah like i said its just mostly minor things
junior olive
you basically just have ui left now no?
austere talon
probably idk
junior olive
WHY DID GITHUB HIDE REVIEW COMMENTS
austere talon
austere talon
WHY DID GITHUB HIDE REVIEW COMMENTS
LOL
junior olive
yeah ok that's ui prolly
austere talon
bro thinks hes coding java
src/plugins/Decor/lib/ui/modal/idek/thing/Blah.ts
(its fine i just find it funny)
also on a totally unrelated note, im surprised not more people change the license header to include their own name
dapper tiger
hi
austere talon
also on a totally unrelated note, im surprised not more people change the licens...
ig its not really documented anywhere so most people just dont know
junior olive
also on a totally unrelated note, im surprised not more people change the licens...
wait did i do that??
š
austere talon
basically, start() may be called without your CONNECTION_OPEN ever being called (if the user enables the plugin later)
actually on second thought, i think start might NOT be called if your plugin has patches?
austere talon
wait did i do that??
dunno
junior olive
i mightve idk
austere talon
(it's completely redundant cause you already have copyright even if you're not explicitly mentioned. but it's still nice for attribution, so plugin devs are allowed to change the license owner line to anything they want ( i recommend just adding your name to the list ) )
austere talon
btw u dont have to comment fine or ok or whatever, just do it and mark resolved
austere talon
junior olive
yop
austere talon
undefined === SKU_ID will always be false assuming SKU_ID isnt undefined itself
anwywayi sleep now
junior olive
gn
austere talon
actually gonna merge dev first
expect decors merged within the next few days assuming u address feedback (and future feedback) timely
sorry for the wait so far
austere talon
no rush, i'll review the rest tmrw and test it properly then and there mightbe more UX feedback after testing and then once thats addressed it can be merged probably
junior olive
sorry for the wait so far
its ok but i can't cancel the order of rats in your walls sorry
nonrefundable
yk
junior olive
woooow 
austere talon
š
junior olive
fuck u then vee, i hope the rats make u crazy !!!!
austere talon
i wish i could merge all 90 prs rn, i really do
its not that simple unfortunately š
once i hit merge the plugin is suddenly also my responsibility
charred monolithBOT
SuperReactionTweaks
junior olive
i'm unsure ab repeatedly specifying Decor
austere talon
god this reallyneeds fixing soon https://github.com/Vendicated/Vencord/issues/1935
breaking discord pages is unaccpetable
dire trench
edm155
junior olive
i'm unsure ab repeatedly specifying Decor
I think the verbosity is good
austere talon
i'm unsure ab repeatedly specifying Decor
reviews arent binding, just my thoughts
if u disagree, its okay just say so
if u disagree and it starts with nit: then u can just ignore it
junior olive
ok time to go through all of these and do them
main trout
need plugin ideas
junior olive
š«
main trout
Actually
austere talon
huhhh
main trout
Vencord confusion speed run any%
austere talon
high quality contributions are priceless
junior olive
hm..
main trout
high quality contributions are priceless
I need ideas for those š
austere talon
honestly while verbose = horror, self documenting code is also nice
main trout
Actually
void echo
Is there any specific format for the readmes?
austere talon
so i thin kthats fine fiery
junior olive
ok
austere talon
honestly while verbose = horror, self documenting code is also nice
i noticed that the more experienced i got at coding, the longer my variable names got
main trout
austere talon
i used to be a sucker for super short names but verbose names are pretty nice
austere talon
i noticed that the more experienced i got at coding, the longer my variable name...
obv dont take it too far but
const s = ... // young man, KILL YOURSELF!!!!
const size = ... // what size??
const modalSize = ... // what modal??
const pluginModalSize = ... // PERFECT
main trout
junior olive
obv dont take it too far but
```js
const s = ... // young man, KILL YOURSELF!!!!...
i think about var names in the sense of context
austere talon
i think about var names in the sense of context
yeah sure, if this is specifically in like a function openPluginModal and it's relatively short then itsfine
junior olive
like im not gonna call decorAvatarDecoration that inside a decor page it'd just be avatarDecoration (maybe)
austere talon
but still helps imo, especially if the func is longer or just a block somewhere
it always depends on context
junior olive
wait why the fuck did i do this patch like this
holup
ima read the code
hm
why did i do it like that
o
this was before i knew assignments returned and that was partially changed after i did know
@austere talon this is why
ok what if i just
austere talon
the types u mean?
austere talon
just extend the user type for now (though we really gotta update them soon)
junior olive
yea
austere talon
import { User as BananaUser } from "discord-types";
interface User extends BananaUser {
avatarDecoration: { ... }
}
interface AvatarDecoration {
asset: string;
skuId: string;
}
interface UserWithAvatarDecoration extends User {
avatarDecoration: AvatarDecoration;
avatarDecorationData: AvatarDecoration;
}
or that
anyway we should just make our own types package soon
discord-types sooo outdated 
junior olive
i should probably type some of the other places avatar decoration is but EEEEEHHHHH
or i do that
charred monolithBOT
austere talon
btw @limber skiff https://github.com/Vendicated/Vencord/issues/1424
this is like some server subscription shit
idek how it works and dont know any servers where we could test it
void echo
ven are we retroactively adding readmes to the plugins that dont have them?
i can give a hand wth that tmrw if you'd like
junior olive
TO REMOVE DECOR DECORATIONS FROM USERS WHO DIDN'T HAVE THEM ANYMORE
austere talon
ven are we retroactively adding readmes to the plugins that dont have them?
yes
planned
the plan is to make it a community project thing
but i havent gotten around to it yet
junior olive
vee im not doing this
bc the store can have a null entry
which indicates that the user doesn't have a decor decoration and that the client should remove it if the user does have one
junior olive
just looked at the user class btw
limber skiff
btw <@235834946571337729> https://github.com/Vendicated/Vencord/issues/1424
kk I'll look at it
junior olive
i guess i need to set avatarDecorationData
wtf is parseavadecodata
s = e=>"object" == typeof e && null != e && "asset"in e && "string" == typeof e.asset ? "sku_id"in e && "string" == typeof e.sku_id ? {
asset: e.asset,
skuId: e.sku_id
} : "skuId"in e && "string" == typeof e.skuId ? {
asset: e.asset,
skuId: e.skuId
} : {
asset: e.asset
} : null
that is parse avatar decoration data
ok ill update this code
charred monolithBOT
this doesn't seem quite right. shouldPlayBurstReaction expects a number, not a boolean
void echo
what's the default limit on it?
junior olive
yeah how the fuck did that break5
void echo
i got a load to play
mortal fractal
fiery will patch find: "isAvatarDecorationAnimating:" instead of mangling UserStore and getAvatarDecorationURL
junior olive
~~fiery will patch `find: "isAvatarDecorationAnimating:"` instead of mangling Us...
do not
austere talon
that seems fine..??
no
junior olive
i know
junior olive
i swear i had that correct before
junior olive
(?<=BURST_REACTION_EFFECT_PLAY:\i=>{.{50,100})(\i\(\i,\i\))>=\d+
austere talon
ya
junior olive
that seems right
junior olive
~~fiery will patch `find: "isAvatarDecorationAnimating:"` instead of mangling Us...
ima stick with my way
mortal fractal
ima stick with my way
why
i mean the only place its not used is the account panel
junior olive
idk if they use getaviurl in random places
mortal fractal
and tbh im only using it because its a react hook and thus i can add panic support to it easier
austere talon
patching this seems way way cleaner and will solve your memberlist issue too
junior olive
mortal fractal
whats the issue with the member list?
austere talon
cause its a react hook so you can use an effect in there to fetch decors
junior olive
cyn u really had to wait until the last minute to tell me
junior olive
the rats will be released
austere talon
patching this seems way way cleaner and will solve your memberlist issue too
actually yeah using this will make your life sooo much easier, you can literally just use an effect in here that fetches the decor for the user passed
now u dont need all your subscriptions and multiple patches anymore
but yeah thats really a bit late š
mortal fractal
i still think the zustand stuff is overengineered and confuses the fuck out of me
junior olive
im genuinely going to explode
junior olive
i still think the zustand stuff is overengineered and confuses the fuck out of m...
I LIKE ZUSTAND
š
ok what fucking server has that sob
BOOG FUCKING TOWN
mortal fractal
i literally just have a Map with the users and refetch all users every 5 minutes
junior olive
that's what decor used to do minus the refetch bit
austere talon
actually yeah using this will make your life sooo much easier, you can literally...
const DecorCache = new Map<string, string>();
export function useDecors(user: User) {
const update = useForceUpdater();
useEffect(() => {
if (!DecorCache.has(user.id)) fetchDecor().then(d => {
DecorCache.set(user.id, d);
forceUpdate();
});
}, []);
return DecorCache.get(user.id);
}
could be this easy now probably
austere talon
patching this seems way way cleaner and will solve your memberlist issue too
and call that hook from here and use the returned value to patch the decor src
and boom done basically
junior olive
š
austere talon
maybe use an interval like cyn to periodically refetch but imo that's kinda whatever, most people won't update their decor often
junior olive
no
well
guhhhh
this is reengineering the core of the plugin at the very last minute
mortal fractal
how so?
junior olive
this is effectively redoing the actual bit that handles setting decor decors
which isn't a problem
but it is a lil inconvenient at the last minute
mortal fractal
i feel bad now that i didnt bring this up earlier
junior olive
don't u didn't know
I might do a combination solution
this new bit, but w/ flux subscription functionality retained
to a extent
make that handle updating ppls decors
austere talon
```js
const DecorCache = new Map<string, string>();
export function useDecors(u...
you can also store a timestamp in the cache
then upon each request, if the timestamp is too old, trigger a refetch
void echo
fiery am i good to leave u to resolve reaction tweaks
junior olive
yea ill deal with it later
void echo
kk
austere talon
then upon each request, if the timestamp is too old, trigger a refetch
i think that'd be the cleanest
junior olive
tests dont run otherwise
austere talon
and don't uncheck "allow maintainers to edit pr"
austere talon
hes using the main branch in his fork
junior olive
then upon each request, if the timestamp is too old, trigger a refetch
nah
austere talon
github gui let me do it
junior olive
I want to have proper places trigger a refetch
like rn opening the profile will refetch
ideally the popout would too
i hadn't refined those
austere talon
you could have a combination of both
cache age to refresh old decors in chat / member list
and manual refetch on profile open
junior olive
maybee
probably fine
@mortal fractal could you share the hh patch for that thing idk how to do hook patches
mortal fractal
just ensure everything you need to do is before the return and you wont break rule of hooks
austere talon
well you just need to insert ur hook somewhere in their hook before any early returns
we basically said the same thing
mortal fractal
