#๐พ-core-development
1 messages ยท Page 117 of 1
mhm thanks
kazimir
like i said im fixing platform indicators now
ANY OBJECTIONS?
else im adding it
actually hmmm
optimally you'd just be able to destructure
but idk how make work with lazies :(
you'd have to make the proxy return the props as getters i guess?
looks like message decors api is still somehow broken?
ahyeah
huh it's still not letting me create a pr fun
why husk? is this some funny old person?
@limber skiff
@austere talon you'll have to manually merge the commit again
@verbal pumice ur chat badgesare broken because of ^
try again with that
vencord starting to look like vencord again
not for me 
probably reviewdb then?
i removed the limit kasi
what is that
@tidal goblet u can pr now
my theme is borked and fakenitro themes do not work
token blogger
i should waste my 10 euros on nitro /j
horror
got classes working
that looks not very robust, adding some more unique anchor like the old getPremiumSubscription would be a lot better
345d362 fix(vcDoubleClick): update for new discord buil... - D3SOX
i fixed relationshipDB's patch
this does not seem very robust. adding some more unique anchor like the previous isOwner would be much better
m?
its been like this for a minute
lmao github moment
LMAO
the fucked up shit?
lemme try rebasing the branch
o wait its working now
hm using displunger to see the older sources 
wont work
unless you use 2022 build
lol
exactly december 2022
it is unfuckedup shit
because megu cant bother fixing discord.sale
TRUE
can't you find hashes elsewhere?
if people PR fixes to dsale then i will happily merge
there are way too many prs for me to thank individuially but thanks a lot to everyone helping out <3
displunger takes the files from dsale
or the build itself
idk
a
make a ven bot
there is still so much to go
fear
EVEN VESKTOP PATCHESARE BORKEWD
megu ur StartupTimings is also borked
if u want more to fix
ping everyone 
guhh
io mean from what ive seen so far, fixing patches is usually piss easy
no problem <3
just need to make minor changes
pog
so its unironically not that bad
laziness
:3
yes
@nimble plazawho do you wanna marry
@viscid rover
yeah, it doesn't really make a lot of sense
oh my god i forgot rini pr
@jagged pewter
its a draft tho
@olive aurora could u move ur pr to github please
oh no
its too much to handle codeberg as well rn
does rini have a github account
they do
wasn't it deleted
yeah but i fixed multiple of the things they also fixed
anway she fixed ValidUser and PinDms
so thats huge
why isn't it linked anywhere ๐ญ
it will hunt you down

omg all the betterfolders shit broke
its build before they did rspack first time
\j
wait lemme compile a list of explosive plugins
horror
yeah
is commandAPI fixed
if you could, it'd be nice to sort them somehow
yes
like how big they are because bigger plugins are generally more useful IMO

๐ฅฐ
actually the order doesn't really matter because i'm guessing we're going to fix everything before merging to main
AlwaysTrust
BetterFolders
BetterGifAltText
BetterNotesBox
BetterUploadButton
BlurNSFW
ColorSighted
Dearrow
FakeNitro
FavoriteEmojiFirst
ForceOwnerCrown
GreetStickerPicker
IgnoreActivities
ImageZoom
InvisibleChat
MessageLinkEmbeds
MessageLogger
MoreUserTags
NoBlockedMessages
NoPendingCount
NoticesAPI
OnePingPerDM
OpenInApp
PermissionFreeWill
PermissionsViewer
PinDMs
PlatformIndicators
PreviewMessage
RoleColorEverywhere
SendTimestamps
SettingsStoreAPI
ShowAllMessageButtons
ShowHiddenChannels
SilentMessageToggle
SpotifyControls
StartupTimings
Translate
TypingIndicator
TypingTweaks
ValidUser
Vesktop
WebContextMenus
WhoReacted
explosive plugins
Vesktop
my fav plugin
hold on lwt me speedrun waking up
that doesnt count all the busted prs too 
doing alwaystrust
last build before rspack
can we make a gh issue
TO FIX:
BetterFolders
FakeNitro - nookies
IgnoreActivities
MessageLogger
RoleColorEverywhere
ShowHiddenChannels - nookies
UserVoiceShow
can you just clone a specific commit
so its easier to see whats fixed without editing
this will take years
meow
STOP THE FUCKING REM -> PX -> REM
this deliberately renames it so the value of it becomes undefined, which forces it to use the default value, aka yourValue
how is ur org another user
rindetta
if you're fixing any of these, please let me know so i can remove them
Heya! I know you guys are very much busy with fixing things up right now, so don't let me stress you out more, but this commit is like really not cool...
Yes, the web version does have Krisp. However, Krisp is really buggy, at least on my system (Linux, Pipewire, Firefox). I've been told that I sound like Bugs Bunny whenever I enable Krisp, which is not the case with RNNoise. So this commit effectively takes away the only viable noise reduction for me and most likely a bunch of other p...
as i said i wanted to try fixing typingtweaks
dea is fixing onepingperdm
i'm procrastinating though
webpack chunks are fixed right
should be
real
:3
doing alwaystrust
we might bring it back in the future if there is demand, but even its dev told me to remove it (even before it broke)
im gonna sleep again after this but if theres anything left ill give it a try
Fixes: ShowMeYourName, SilentTyping, PinDMs, PlatformIndicators (+ apis), ValidUser
burger pr: https://codeberg.org/Ven/cord/pulls/35
Heya! I know you guys are very much busy with fixing things up right now, so don't let me stress you out more, but this commit is like really not cool...
Yes, the web version does have Krisp. However, Krisp is really buggy, at least on my system (Linux, Pipewire, Firefox). I've been told that I sound like Bugs Bunny whenever I enable Krisp, which is not the case with RNNoise. So this commit effectively takes away the only viable noise reduction for me and most likely a bunch of o...
we might bring it back in the future if there is demand, but even its dev told me to remove it (even before it broke)
Welp, I guess this is my contribution to demand then, just wanted to let you know ^^
Content
Some people find RNNoise better than Krisp, so it would be nice to bring it back
To do so, we would need to better integrate it with Krisp, optimally having a toggle / select between the two
Request Agreement
- [X] I have read the requirements for opening an issue above
Tracking in https://github.com/Vendicated/Vencord/issues/1866 - you can always contribute this yourself if you would like to see it soon
CHANNELTABS JUMPSCARE
virus
Epic Plugin fixes formerly Epic MegaPlugin fixes
because i saw the f and monkey brain went "fix" time to tag
no lmao
u can just discard changes to memberlist and message decors
banana
and platform indicators i semi fixed
wow massive changes dea
wdym?
oh
it should be i
not a
WHY IS GIT NOT MERGING
i was fixing betteruploadbutton but i realized i have no idea hoe it's even suppossed to look now
OH
const TextAndImageSettingsStores = findByPropsLazy("MessageDisplayCompact");
and maybe move to webpack/commons/settingsStores.ts?
this looks pretty sketch. what this actually does is find the first ;return in the file, then walk to Types.ORIGINAL_POSTER. try to avoid using .+? or add an anchor before the return
nit: put these objects on new lines for consistency with the rest of the plugins
okay fixed
@austere talon just woke up ill try to fix typing indicators again idk what component it wants exactly
because there's a single return, the entire module is just the bot tag
true i should edit the comment hold on
sure but i'd still try to make it more specific
for future proofing
fair
I'm working sooo slow
woow they fixed friend invites plugin or me
how nice of them
we passed 24k members
plan worked

should i merge the first batch into main
ye
its [...getStaticPaths(),...channelIds] now, i updated the comment but idk if the match should be fixed
the cool gang
stuff is way more divided into modules now
(this is a good thing)
nya
vee let me sleep
this update made me realize I could remove a few patches in my own plugins so peak
same
bitch like true ? [] : [
c3d14df fix messageLinkEmbeds, moreUserTags (#1859) - sunnniee
b9fe892 Fix PinDMs, SMYN, SilentTyping, ValidUser, Plat... - rniii
okAY GN
gn (rini
GNN RINI
gn rinii
real
ill just merge the first bunch

how r things going just got out of class
going very good
its going well
:3
@austere talon can you add
i expect vencord by the time we get home chop chop
i think i might try and fix this lmao
nookies is working on it
ah
oh no
SpotifyCrack has a broken patch (bad)
badges still gon
wait no
LMAO
that's cuz loadash is no more
HORROR
THE SPAM
๐ญ
WHAT
๐ฅ
WTF
WTF IS IT DOING
what even
pretty sure ven closed a pr
fire thats what
NOWIFIOPEWOPJIKGEWJIOEG
ASFHJJK]
OH NOOOOOO
DEV BRANCH DELETE
YOU DELETED DEV
NO
WAIT
AHAHAHHA
auto delete
WHAT
the horror
NOOOOOOO
๐ญ
DAWG??????
REAL
BLUD?????????
LOL WHAT
decor survived tho ๐ฅ
๐ญ dev branch
ALL THE FIXES GONE ๐ฅ ๐ฅ ๐ฅ ๐ฅ ๐ฅ ๐ฅ ๐ฅ ๐ฅ ๐ฅ ๐ฅ ๐ฅ ๐ฅ ๐ฅ ๐ฅ
๐ญ
time to go and reopen all those PRs
HORROR
ven deleted branch
im gonna reopen them all
@austere talon YOU DELETED DEV BRANCH
anyways this
nope
okay now
HOW
sorry
github auto deletes branch if you merge pr from it
adkjskjaksjf
ohh lmao
github jumpscare
oh, isn't that optional
there's probably a repo setting to do it automatically which you have on
what happened
you probably could set branch protection rule for dev
to prevent deleting
did ven just delete the entire branch where the fixes were supposed to be tested before merging them to main
decor is back we're so back
auto-delete
thanks megu
oh my god I am gonna murder discord
WHY :(
WHY OPENING DEVTOOLS CRASHES MY CLIENT
nuh uh
u deserve it
are you on the elements tab when you open devtools
its using custom dir
(big virus)
HOW DO I PULL A FORCE PUSH
git pull --force
blame vencord
how fix

kinda insane how fast yall can fix stuff 
I HATE vencord
idk why its crashing
HELP MY BRANCHES NEURODIVERGENT
skill issue tbh
its not even going OOM
we got the power of shiggy on our side
probably rebase
when i switched from discord dev to discord canary it fixed itself
all my branches neurodivergent all my apes gone
oh neat
if you quickly click on something that isnt styles element tab will work fine
could exactly three people type please
I am obessed
please fix history
it crashes once it loads the styles tab
I try but even if I open console
vencor
skill issue
no idea why that worked without diverging from dev again but tx
im gonnna,,
i was fixing typing tweaks but chunk explosion
if you want me to give it a try again
done
Please log in again.
I ALREADY DID 10 TIMES
please discord stop nuking token when opening devtools
it's true
the what
VENCORD DOESNT EVEN LOAD
also I tried with that enabled
okay it turns out I was using decade old version of vesktop
i call dibs on blurNSFW
i cannot do it rn because im at school but i will try
it is i think
npoe
nope
it is not
might also work on preview message
Fun one to test
seems easy
i sure wonder why this doesnt work
what is bro waffling about
literally worked

oh wait
its trying to apply the same patch multiple times
why tf
remove startuptimings
going to do greetsticker
consider adding to the list
explode
oh
sp...
is class*=a faster or slower than .a
slower
both are forms of contains checks...
it's $1 and 0
those are references
i need to use google lol
message blogger ๐
if you have a better idea do suggest
okay yeah it does
match: /(?<=\{unviewedTrialCount:(\i),unviewedDiscountCount:(\i)\}.{0,200}\i=)\1\+\2/,
should work
could you also add a comment slightly explaining the regex? just so it's more maintainable
sure
go go go
my ass typing :bd on discord instead of vim and it types ๐
ok well erm its kinda not
ohh
btw
thats a hack
it walks back potentially very very far
?<= after some match walks back
scroll up
the thing im matching might have just been moved to a different module
ah yeah its diff module
it's the array containing the welcome sticker data
pickWelcomeStickerId
look at that func
basically just grabs the array and poasses it to our func
hope its exported
if not, unlucky
all of these plugins have the same patch copypasted
findByProps("WELCOME_STICKERS")
all broken
who tryna fix and turn it into an API
lol
what are they doing?
chat bar buttons
idk why noone ever turned it into a proper api
it's literally the same shit copy pasted into all plugins
the module
lmao
fire
done
fixed
blehh
now the question is
do i
A) make it an API
B) copy paste the fix into every plugin
a
LOUD INCORRECT BUZZER
hmm if so many are using it it'd probably make sense to make it an api
:3
@austere talon can you turn on welcome stickers <3
i guess i could make it
ill make it rn
ah okay
eh actually
ok its real
i'll push the bad fix for now then later make it a proper api
making this api good is a bit more complex since it should also provide some abstraction
all plugins have a very similar component, 80% is boilerplate
so ideally it'd be icon, tooltip and onClick, right?
and maybe onContextMenu
ya
lmao this looks so strange
what determines the order

if you had an api you could have a screen to rearrange them
meowtext menu
file name
at least it's not random
like based on the structure of a map
i wasnt kidding about all plugins having the identical patch copypasted
the fix was litzerally copy pasting my fixed patch into each plugin

cloneDeep needs to STFU
ok i did it
cloneDeep
lodash
are there any soon plans to fix the double server list thingy
watch as they revert it tomorrow 
Draft PR to bring back RNNoise and make it play nicely together with Krisp
Related issue: https://github.com/Vendicated/Vencord/issues/1866
Tasks
- [x] Switch between RNNoise and Krisp in popup
- [ ] Properly style the new popup
- [x] Make noise supression button active when either RNNoise or Krisp are enabled
- [ ] Remove Discord-Native noise supression button
- [ ] Test functionality
I'm personally completely new to development in this project (and development of Discord m...
mm but soon
hmm
what happened to ProtoStores
OHH
FrecencyUserSettingsActionCreators moment
PreloadedUserSettingsActionCreators malware
you are a malware
average java class name (malware)
holy shit java
LOL same joke as me
TO FIX:
BetterFolders
BetterGifAltText
BetterNotesBox
BetterUploadButton
BlurNSFW
ColorSighted
Dearrow
FakeNitro - nookies
IgnoreActivities
MessageLogger
OpenInApp
PermissionFreeWill
PermissionsViewer
RoleColorEverywhere
ShowAllMessageButtons
ShowHiddenChannels - nookies
SpotifyControls
TypingTweaks - toad
Vesktop
WhoReacted
SO LITTLE
i think a few are missing here
those are only the ones that arent lazy loaded
SpotifyCrack
๐
isnt pronoundb supposed to be fixed
fake
robbed
don
wtff that's like nothing
common vencord W
vee will let me push to dev
wtf is discord cooking
wpexs is broken btw
oh
it certainly was
let me pull
it doesnt work for me
merged everything to one file
btw PreloadedUserSettings is now in webpack commons
UserSettingsActionCreators
my thing worked and i didn't have any other "patch had no effect" in console at the time
i cant find these classes its so over
popout
it joever
not sure why this was such an insane regex in the first place, this works just fine for me
?
I will think for some more time
you said it worked for you at the time, so i just fixed the one issue bc it was the only visible one at the time xd
i meant in chat
it's boring creating simple patches
i was wondering what happens if you put regex which takes three hours to evaluate in automod
rust error
(real)
obviously it won't actually cause problems for discord (i hope)
because the expression has more than one condition
(unless they are doing everything on one thread with no timeout)
depends what regex engine
discord automod has a limited subset of regex
I only removed the one that checked for shift hold, not the others
applicationButtonHackl
@austere talon i think like half of vencord plugins might be broken on safari/webkit
the new patch removes all
200002 Regex validation service unavailable. Please try again later.
unrelated to the stuff today
possibly
yes safari isnt really supported
yeahh
you need latest safari
they don't support lookbehinds do they??
older safari doesnt support lookarounds
oh ig they added it neat
Should have kept the other conditions which werent shift hold
you need to update ur macos 
oh since 16.4
wrong
no way
safari is weird
surely you can update it separately
it gets updates seperate from OS
macos is just different
yeah
not for safari
it's weird for a apple system app
safari updates are built in the os update
link i'm lazy
well no
atleast usually
yes but no
@olive aurora didnt ping
older OS' can update to newer safari
fixing ViewIcons rn
i think macOS 11+ can run vencord
need a blud with server pfp
void
@opaque pewter
me
don't say blud
cool
havent pushed yet
liar
no
i have a server pfp
lewi
bros switched to rspack and forgot how to push shit โ๏ธ
fixing whoreacted
th she always had one
oki
blud
if you do need someone with server pfp im here :3
whar
comments are overrated
avatar wrapper for bots?
if your code doesnt explain itself its bad 
how do you expect a patch to explain itself
not sure regex patches are counted under that
i can only make shitcode, i already knew that ๐ฅ ๐ฅ ๐ฅ
genuinely no idea where that is
wait ven great idea
while you're updating it, add crypto miner
ppl have to update for working vencord so you get free crypto mining from almost every user

push the telemetry update to compensate losses

I want webkit based vencord desktop
i just compared it to the old code
vendroid
wtf is that
javacord we will make inshallah
i already found that but wtf

this is what it used to be
vencord but in java swing
I wonder how many days it will take betterdiscord to recover
maybe they are still waiting discord to revert update
i mean
fixing it is easy
but i genuinely have no idea whats that for
OHHH
I THINK I KNOW
h?
nvm i dont
in the cough source it seems to be in UserPopoutHeader
i think it might be the server pfp
the mini one
like
like here
but its not there
ill just remove it for now maybe
im sure someone will complain if its an issue 
Co-authored-by: Nuckyz 61953774+Nuckyz@users.noreply.github.com
Co-authored-by: Vendicated
webhooks and default avatars
OHH yeah
ok
why is there NO event i can subscribe to to find out when a profile popout is opened
๐ญ
unless
when is your brain opened
analytics
omg
for real tho
no way
599493: function(e, t, o) {
"use strict";
e.exports = {
buttonsBackground: "buttonsBackground__0addb",
buttonsBackgroundActive: "buttonsBackgroundActive__5341f",
buttonsContainer: "buttonsContainer_bde73f",
feedback: "feedback__5acd4",
toast: "toast_c6f55a"
}
},
you will review entire change now
css classes?
buttonsBackground clearly
i love git blame
channel warnings shit
- seenActivities: [],
+ seenActivities: new Set,
+ seenNewActivities: {},
+ seenUpdatedActivities: {},
scary stuf
omg
it would be reaaaaaly funny if they pushed a update that broke entire vencord again
so true
send repo alhamdulilah
PlatformIndicators still needs two patches fixes
platformindicators seems to work
im fixing OpenInApp
how bad would it be to just make these return a function that always returns true
yes but 2 patches still borked
oh my god being able to read discord code is insane
finally found out what hashes are for
thats fine
i didnt do them because i dont use those options 
ah okay, that'll make this patch a lot nicer
SAME
thank
lemme translate
so theres a thing called party
the party thing still workign
even though other plugins are not working
the party is ongoing
party is working
too true
i think the tracking blocker breaks this xd
after
since it relies on AnalyticsUtils
ยฏ_(ใ)_/ยฏ
yes lol
im fixing vesktop
yop do
{
find: "AnalyticsActionHandlers.handle",
replacement: {
match: /^.+$/,
replace: "()=>{}",
},
},
this?
im fixing OpenInApp rn
virus
this nukes analytics
this is openMaskedLink
any idea how to find it?
uh what
can i make it un nuke analytics*
i'll just leave it with the rest of the fire
it used to be in same file as MaskedLinkStore but its not anymore
no
not even a little
so that stuff is shared locally
telescope.nvim is so horrible
bc if componentdispatch is relying on it then it's kinda having unintended side effects
found it
but muh fuzzy
nothing important is broken by tracking being yeeted
but i think there's only one piece of code in the tracking that actually sends the HTTP request
when you open the popout it calls AnalyticsUtils.track which then dispatches the event right before sending the HTTP request
LAME
so if you wanted a fix you'd have to change notrack to only patch out the http request stuff






maybe you could inject an extra vc- class

