#๐Ÿ‘พ-core-development

1 messages ยท Page 113 of 1

austere talon
#

thanks anyway autumn

#

๐Ÿ’”

#

wait with merging into main, i wanna first see if anything is mergeable

limber skiff
#

I should have looked before

austere talon
#

are u not subbed to vencord repo

#

i got the email this morning

#

woke up and gotjumpscared by the email

#

ayoo so many broken plugins??

woeful sable
#

free my boy autumn ๐Ÿ˜”

limber skiff
austere talon
#

damn

#

couldntbe me

#

github emailing me 50 times a day is the only way i feel like someone cares about me

#

im just kidding

charred monolithBOT
limber skiff
#

well

#

that was too quick

#

sync speedrun

austere talon
#

maybe its fine

#

but sometimes it goes crazy

#

infinite loop

limber skiff
#

I see

verbal pumice
limber skiff
#

@cunning canyon btw sorry about that

austere talon
#

he will never forgive u

lime stone
#

how do you see anything

limber skiff
#

nono

charred monolithBOT
limber skiff
#

I mean github notifications for email

charred monolithBOT
austere talon
#

horrifying

#

we will soon amend vencords license to state that mantika may not distribute it

#

no longer free software sorry

limber skiff
#

ugh

#

I keep messing git up lmao

austere talon
#

WTF IS THAT CODE

#

DOMMMM

#

im about to dom u if u keep using dom

charred monolithBOT
limber skiff
#

horrible but works

austere talon
#

why tf does match take a string

#

cursed

limber skiff
#

we love that

#

wait how do I even fix that history

#

rebase?

austere talon
#

it doesnt matter

charred monolithBOT
limber skiff
#

aight

frail skyBOT
#
Bad Patches

None

Bad Starts

None

Discord Errors

None

austere talon
limber skiff
#

beautiful

limpid badger
#

Have we finally done it?

austere talon
#

i forgot what all green looks like

#

its been so long

limber skiff
#

ikr

frail skyBOT
#
Bad Patches

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
verbal pumice
#

finally, inner peace

jagged cloak
#

wow

charred monolithBOT
lime stone
# charred monolith

i've already made more progress on my plugin and it supports more ๐Ÿ˜ญ

charred monolithBOT
austere talon
#

is it just me or is the video broken lol

charred monolithBOT
austere talon
#

oh is it hevc

lime stone
austere talon
#

firefox on fedora experience

lime stone
#

๐Ÿ”ฅ

charred monolithBOT
limpid badger
#

What does that have to do with Vencord

#

Vesktop is just discord web

lime stone
#

I can't join other people's games

#

what

dusk blaze
#

I think they mean the ask to join

#

feature

limpid badger
#

Iโ€™m confused

austere talon
#

nah

#

its rich presence stuff

lime stone
#

oh

austere talon
#

i think that requires more than just arrpc

lime stone
#

OH

#

yeah got it

austere talon
#

@mortal forum do you have any knowledge on that?

#

the "ask to join" button on some rich presences

#

is that something arrpc can / will support?

#

i have no idea how that works

#

honestly idek what games have that

#

i think fortnite maybe

#

any fortnite gaymers

charred monolithBOT
lime stone
#

btw discord has a lot of rpc logic in the renderer-side and arrpc copies some of that lol
you might know + i did mention it before, but i'd imagine you might need to uh
copy some more code :D

#

but ducko knows more so...

austere talon
#

it works for me

#

yeah ok

charred monolithBOT
lime stone
austere talon
#

wdym

lime stone
#

instead of a random person

austere talon
#

and it dms

lime stone
#

oh

#

i see

austere talon
#

i just scrolled through the member list til i found someone with a joinable activity

elfin mist
lime stone
#

it took a while

charred monolithBOT
austere talon
#

i mean its just her fork

#

dont think she would care much if u did bad things lol

lime stone
#

what would anyone do anyway lol

#

force push everything away? what is your gain?

  • i have a local copy
austere talon
#

i had no idea that exists

lime stone
#

huh how do you change people's perm level

austere talon
#

wdym

lime stone
#

just has this

lime stone
#

whatever

#

they probably have access to everything lol

charred monolithBOT
obsidian dragon
#

hi uh idk if this is the right place but i wanted to try to make a plugin

charred monolithBOT
austere talon
#

and contributing file

obsidian dragon
#

okay thanks

mortal forum
charred monolithBOT
lime stone
mortal forum
#

what

charred monolithBOT
mortal forum
lime stone
#

let me find an older message

nimble plaza
#

waaaaaa

lime stone
#

i had to find it again

mortal forum
#

you just linked a line?

lime stone
#

start of function

#

regardless of whether the structure of the code is inspired by discord, it does do pretty much the same thing

mortal forum
#

...because it's made to do the same thing?

lime stone
#

i mean obviously yeah

austere talon
#

okay thanks ducko

lime stone
#

what did you think i meant by copy

#

๐Ÿ˜ญ

mortal forum
#

like copy the actual code

lime stone
#

if you didn't know better you would think that

mortal forum
#

me when that is the definition of copy

charred monolithBOT
lime stone
mortal forum
#

me when code made to do same thing does same thing

lime stone
#

so that's basically a copy anyway?

austere talon
#

wdym ๐Ÿ˜ญ there are only so many ways to write websocket code

mortal forum
#

it is like saying discord mods copy each other for doing webpack the same way

lime stone
#

i don't want to argue about what copy means.

mortal forum
#

..you can only do it one way to make it work properly

lime stone
#

seems to be the case here

#

surely you looked at discord's code though?

mortal forum
#

looked yes, copied no lol

#

otherwise it would be way more obvious

lime stone
#

it's pretty hard to see code and write something that doesn't look like you copied it and changed the variable names so the "teacher doesn't notice"

#

but whatever

#

i suppose i was technically wrong

mortal forum
#

that isn't what I did but okay

lime stone
#

i didn't say that, i just meant it often looks like that ๐Ÿ˜ญ

mortal forum
#

lol

#

maybe i should write arrpc is blazingly fast rust ๐Ÿš€

lime stone
#

yes!

mortal forum
#

this is a joke.

lime stone
#

what no

#

it's a great idea!!

#

๐Ÿš€ ๐Ÿš€ ๐Ÿš€

mortal forum
#

obviously i should write it in uh

jagged cloak
#

brainfuck

austere talon
#

cause there's only one way to use websocket

mortal forum
#

websocket makes me sad

#

but also I cannot think of anything better so

lime stone
#

but you are looking at one piece of code and trying to reimplement it
so you might consider that a form of copying

#

but yeah this is networking and you have to achieve the same thing soo...

mortal forum
#

a form of reimplementing ๐ŸšŽ

lime stone
#

i have reimplemented something before and fixed it because the original was broken ๐ŸšŽ

mortal forum
#

discord?

#

๐Ÿ—ฟ

lime stone
#

nop

#

something a bit more obscure ๐Ÿ—ฟ

mortal forum
#

i meant discord itself because it is broken ๐ŸšŽ

charred monolithBOT
#
[Vencord/linux-virtmic] New tag created: v1.3.0
charred monolithBOT
charred monolithBOT
#
[Vencord/venmic] New tag created: v1.4.0
austere talon
#

github so dum

#

it forgor thge first time i pushed the tag

charred monolithBOT
#
[Vencord/Vesktop] branch deleted: virtmic
#
[Vencord/Vesktop] New tag created: v0.4.0
austere talon
#

@limber skiff uh

#

the experiments patch is still needed

#

silly

limber skiff
#

wtf

austere talon
#

if u enable this it breaks search history

limber skiff
#

I tested and it worked without lol

austere talon
#

thats what that patch is for

#

did u have isStaff enabled...

limber skiff
#

ye I have it enabled

austere talon
#

well its broken for me

#

on latest stable

limber skiff
#

odd

#

cherry pick autumn commit lol

austere talon
#

maybe experiment

junior olive
#

@austere talon can I PR a change to vesktop so it releases arm64 Linux builds

austere talon
#

uh

#

do u actually need it

#

sure but idk how useful it is

#

ig why not

junior olive
#

I have 0.3.3 self built rn

olive aurora
#

electron builder sane

#

@โ€Œcookievee fix platform icons

charred monolithBOT
elder garnet
#

could we have an attribute in themeattributes on the html thing at the top like "isMaximized" or something? id really love that for css

charred monolithBOT
austere talon
#

i could swear it is

elder garnet
#

nope :(

austere talon
#

ah

#

what would u use it for

austere talon
elder garnet
olive aurora
#

maximized windows are a social construct

elder garnet
elder garnet
olive aurora
#

what is a titlebar

elder garnet
#

thats an option

nimble plaza
#

who up forking they vesktop ๐Ÿค‘๐Ÿค‘๐Ÿค‘๐Ÿค‘๐Ÿค‘๐Ÿค‘๐Ÿค‘๐Ÿค‘๐Ÿค‘๐Ÿค‘๐Ÿค‘๐Ÿค‘๐Ÿค‘๐Ÿค‘๐Ÿค‘๐Ÿค‘

charred monolithBOT
austere talon
#

why does this person have the most scuffed audio sources

austere talon
junior olive
#

you love audio sourc

#

i wonder what vesktop shows on asahi

austere talon
#

can we add an arm64 venmic build?

topaz thistle
topaz thistle
junior olive
#

isn't it optional?

austere talon
#

yes but why would we ship half broken software

#

if we're adding arm64 support it should be done properly

topaz thistle
austere talon
#

@uneven bolt is that u

#

ya thats them

#

do u need arm64 to build arm64 node addon?

#

or can u build it on amd64

junior olive
#

you should be able to cross compile

uneven bolt
dire trench
#

don't feel like making a pr but this issue with the background overflowing past the border on the Vesktop splash screen can be fixed by adding this to splash.html

body {
  background: transparent;
}

.wrapper {
  background: var(--bg);
}```
austere talon
#

looks like he uses an os matrix and builds on proper arch

topaz thistle
#

that's better than cross compiling

austere talon
#

god his workflow is so complex

uneven bolt
austere talon
#

if we wanna use a matrix we'd need to make every worker upload artifact then download all the artifacts in the final release step

topaz thistle
#

yes please

junior olive
#

that's scuffed i don't think github offers arm runners outside of mac xlarge??

austere talon
#

clearly they do

junior olive
#

So it's probably running under qemu

topaz thistle
#

And then run pw-dump

austere talon
#

oh wait no

#

it does cross compile

#

matrix.arch is only used here

#

so we don't even need a matrix

topaz thistle
austere talon
#

it's just possibly faster

junior olive
#

cross compiling shouldn't be slow though

#

if anything emulating the right platform should be slower

uneven bolt
#

great now the empty sources don't show up anymore concern

austere talon
#

but it doesnt matter much tbh

junior olive
#

hmm

topaz thistle
uneven bolt
topaz thistle
#

I'd like to reproduce it as I think it might be some deeper issue

#

Dump doesn't show anything out of the ordinary

junior olive
#

Will venmic have any issues with 16k page tables?

topaz thistle
#

wdym

junior olive
#

Are there any assumptions of a 4K page table

austere talon
#

dunno

#

shouldnt

uneven bolt
topaz thistle
austere talon
#

electron doesnt work on 16k page arm64 tho

#

it segfaults

#

so it doesnt even matter

topaz thistle
junior olive
#

I literally used it bro

#

They fixed it

uneven bolt
austere talon
junior olive
#

I have vesktop running on fedora on my MacBook

topaz thistle
#

I cant reproduce it, what I tried:

  • Quit Vesktop
  • Start Vesktop
  • Joined VC, started Stream
austere talon
#

i remember trying to run vscode server on my vps

#

oh wait i have 64k not 16k

#

but surely they also fixed 64k

junior olive
austere talon
#

i checked like 1y ago

uneven bolt
#

this is exactly what i did to test it, three times

topaz thistle
#

What's your pipewire version?

uneven bolt
#

i launch it with --ozone-platform-hint=auto --enable-webrtc-pipewire-capturer, if that can matter

uneven bolt
austere talon
#

i dont use it and it still works

topaz thistle
austere talon
#

WHYIS IT SO SLOW

#

my server has gigabit

uneven bolt
#

i'll see if removing it changes anything

austere talon
#

average npm

#

i swear npm limits bandwidth to 1kbps or smth

topaz thistle
austere talon
half shell
austere talon
#

yeah lol

#

disable isStaff patch

junior olive
half shell
austere talon
#

so 64k page size still broken

topaz thistle
#

@austere talon I'll bump the tag after the fix - Is that ok?

half shell
#

will do

austere talon
#

yeah but maybe first check whether it works

#

you can send the .node file and uku can manually replace it locally

topaz thistle
#

Good idea

uneven bolt
#

or a simple patch file i can rebuild it myself if you want

topaz thistle
#

Patch is in the native code I'm not sure how that's built in npm

austere talon
#

oh i didnt know u had venmic build already set up

uneven bolt
austere talon
#

ya

uneven bolt
#

yeah i have linux-virtmic cloned

austere talon
#

replace node_modules/<@&1015072428843601962>encord/venmic/prebuilds/

topaz thistle
#

Here's the node file

austere talon
#

then pnpm start

austere talon
#

yaa

#

discord moment

umbral hedge
#

venmic

#

real

elder garnet
#

when i upload a sticker using fakenitro it displays the image normally and then also adds the fakenitro sticker, just wanted to let ya know

uneven bolt
topaz thistle
#

Wow that's really weird

#

Seems like some nodes are misusing props on your system a little

#

Anyways

#

The fix is not bad

#

I'll push

charred monolithBOT
junior olive
charred monolithBOT
#
[Vencord/venmic] New tag created: v1.5.0
junior olive
austere talon
#

its literally not bro

#

i just showed u....

junior olive
#

Apple uses 16k tho and bc of asahi they've supported that

junior olive
#

All I know is it works for me

austere talon
#

that was electron27

#

freshest of the freshest of electrons

#

it literally was cooked up just 2h ago

#

a baby, one could say

junior olive
#

sad

austere talon
#

anyway

junior olive
#

I guess no consumer platforms support it yet so why bother

austere talon
#

oracle os trolley

#

idk why they even use 64k pages

#

goofy

junior olive
austere talon
#

yaaa

#

still annoying that i couldnt run code server on it

junior olive
#

Yeah

#

Uh wait

#

Is SIGTRAP even the error for page size issues

#

What a bunch of baloney @austere talon

#

they didn't write the 16k patch themselves

topaz thistle
#

Why are the artifacts so huge lmao

austere talon
#

wtf is that screenshot supposed to show

#

tharkigod contributong to chromium???

junior olive
#

Ah okay

#

they don't support 64k pages due to a specific issue and it's a uncommon platform @austere talon

junior olive
junior olive
# junior olive https://chromium-review.googlesource.com/c/chromium/src/+/3545665

"[PA] Support 16kb pagesize on Linux+ARM64

This makes the system pagesize a run-time property.

ARM64 supports 4kb, 16kb, and 64kb page sizes. Previously, only 4kb
was supported by Chromium. This patch adds 16kb support, as is used
for example by Asahi Linux on M1 Macs. The rare 64kb case is still
not supported due to further changes needed to SlotSpanMetadata."

#

Tbh you can't blame them for not supporting it

frail skyBOT
#
Bad Patches

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Starts

None

Discord Errors

None

nimble plaza
#

finally

#

the sounds

#

theyre gone

austere talon
#

HOLY FUCK

#

Best thing I've ever seen in my life

junior olive
#

the voices are gone

charred monolithBOT
dapper tiger
#

@austere talon do you know of how this can be disabled for vencord-desktop-git, since its kinda useless

olive aurora
#

you cant right now

#

but i used to have this on my modified pkgbuild ```sh
prepare() {
cd "$pkgname"

sed -i '/import { checkUpdates } from "updater/main"/d; /checkUpdates();/d' src/main/index.ts
}

#

i guess just sed -i "/checkUpdates/d" src/main/index.ts works

#

@dapper tiger do

dapper tiger
#

what that do

olive aurora
#

it jus stops calling the code thats checking for updates

dapper tiger
#

horror

#

perfhaps i will do

charred monolithBOT
charred monolithBOT
#

@TheKodeToad couple questions about direction:

Upload local file (how should I store the data)

I made it just do the classic "upload and convert/save to data URI" which I think is probably the best option, lemme know if anyone thinks of anything better.

Settings are applied directly instead of being queued

I don't really see this as a problem, only issue being that the "Save" part of the "Save & close" button is technically a bit misleading. I feel like it would take more ef...

charred monolithBOT
charred monolithBOT
#

I made it just do the classic "upload and convert/save to data URI" which I think is probably the best option, lemme know if anyone thinks of anything better.

There's a reason I wasn't sure on the best way to store the data. I think IndexedDB would be better... maybe I could just move all settings there like TextReplace but I thought having the URLs was okay in the settings JSON

gray jetty
#

I know quite a few languages with similar-ish syntax, so i felt pretty confident I could figure it out. + making stuff and just learning while doing it is kinda just the way I learn languages, online courses just dont work for me

lime stone
#

once you know enough languages other languages are pretty easy

gray jetty
#

yea

lime stone
#

you just won't necessarily write them well first try ig

#

lol

lime stone
gray jetty
charred monolithBOT
#

I can see about moving the settings to IndexedDB tmr if I find time/don't forget. As for the other sounds (eg. detune sounds), I can probably just load them on-the-fly like how I did in my PR, that way it always works between additions/removals of sounds. That means they won't show up in the settings menu unless the plugin is enabled though, which admittedly is a little strange. Or that stuff, too, could just be left until after the initial plugin is finished, but that's not up to me ๐Ÿ˜„ .

patent nova
#

@rustic nova hi

#

in ur msg logger enhanced

lime stone
#

WHO'S DAVE

patent nova
#

can u add an option to ignore the muted servers

#

like the bd plugin

austere talon
lime stone
#

poor dave

charred monolithBOT
crude hearth
#

hi crazy dave

charred monolithBOT
#

This pr improves the relationshipnotifier plugin by adding notifications for accepted friend requests or when someone uses your friend invite.
This feature can be helpful as discord web/desktop does not have notification for friend request acceptances/friend invite clicked..

However, enabling "Friends Add" and the "Offline Removals/Adds" settings will trigger a bunch of notifications "___ added you as a friend" due to the plugin syncing with the friend list. That's why the Friends Add opt...

limpid badger
#

Either way, this sounds ok

charred monolithBOT
willow hemlock
#

make a notification plugin where we can change the sound

charred monolithBOT
lime stone
#

oh my god.

dusk blaze
#

?
(i just realized)

uneven bolt
dusk blaze
sour python
#

Hey where should I start if Im looking to make a plugin?

verbal pumice
livid heath
#

looking at other existing plugins really helped me

sour python
#

Alright thanks, Im looking to make key shortcuts for this menu

#

For example if you pressed D when this dialog was open youd delete the message or if you pressed E you could edit it

lime stone
#

hm

#

you can already do that when the message is highlighted

sour python
#

How do you highlight a message?

lime stone
#

tab

#

and up and down keys

sour python
#

I see but I think my idea would be easier

austere talon
#

the normal CLOSE one should already work

sour python
#

CLOSE one?

austere talon
#

ohhh

#

this is wrong

#

try changing it to e.sender.close()

#

@placid hinge

charred monolithBOT
austere talon
#

i think i originally had it as that but for some reason changed it? and forgot to update installer?

#

im not talking to you

sour python
#

Sorry about that

austere talon
#

for some reason I changed it here

#

from e.sender.close to mainWin.close

#

ig it did not work correctly for the mainWin? or smth?

#

I honestly have no idea

#

wtf is a venctrum

sour python
#

Hey is there a way to enable inspecting elements in vencord/discord

sour python
#

AWESOME!

austere talon
#

probably idk

#

so it works to close the updater? does it also work when using from the main window? normally that would be in the windows window controls but you can just test it manually via console

#

huhh

#

why would i change if it works fine

#

I swear there has to be some reason

#

why else would I change it

#

O_o

#

if only I knew what past v had going on in their brain

sour python
#

Thanks for the help spooky

austere talon
#

this channel is more for dicussing prs and such

junior olive
#

based

#

arm platforms my beloved

austere talon
#

well we still need venmic arm64

junior olive
#

yop

#

or we just make you venmic arm64

#

You become venmic

austere talon
#

horror

#

mm --arch option to cmake-js isnt working

#

--CDCMAKE_SYSTEM_PROCESSOR=arm64 also no work

#

well noah will know

austere talon
#

oh @placid hinge now i see why i changed it to mainWin

#

e.sender.close will completely close vesktop

#

when the desired behaviour is to minimise to tray

#

i got smth that might work

#
handle(IpcEvents.CLOSE, e => {
    BrowserWindow.fromWebContents(e.sender)?.close();
});
#

try this

#

works as expected for the main window

#

seems to also work for the updater window

#

if that doesn't work, we could possibly do two ipc channels:
CLOSE_SELF, CLOSE_MAIN_WIN

#

it closes the BrowserWindow itself, not the webContents

#

idk if that also fully closes the webContents?

#

idk how to properly verify

#

it would be bad if some dead updater window background process would still run

charred monolithBOT
gray jetty
#

holy hell im bad at using github, i just spent an hour figuring out how to revert a commit and change a folder name ๐Ÿ’€

sour python
#

It happens.

lime stone
gray jetty
sour python
#

how would you get the last commits hash? (from CLI)

charred monolithBOT
charred monolithBOT
charred monolithBOT
topaz thistle
#

ayyy

#

The arm workflow only took 2hours lmao

#

at least it's working holy fuck

charred monolithBOT
topaz thistle
#

I don't think you can cache that because the thing that takes so long running docker through qemu

charred monolithBOT
#

However, enabling "Friends Add" and the "Offline Removals/Adds" settings will trigger a bunch of notifications "___ added you as a friend" due to the plugin syncing with the friend list. That's why the Friends Add option is toggled off by default
seems like this is pretty hit or miss, but it only happened once, so marked it as ready for review. we can always improve it later on

topaz thistle
#

might wanna give it a go, because if I try I'll definetely hang myself

lucid lynx
#

is it possible to enable Windows' do not disturb from a Vencord plugin? i'm curious cuz it'd be very useful personally

#

so that DMs aren't leaked as an example

topaz thistle
#

I don't think so as that'd probably require access to native apis

lucid lynx
#

that sucks

topaz thistle
#

But if you just want to prevent desktop notifications from discord there's surely a way

normal lodge
#

:)

charred monolithBOT
lucid lynx
#

obviously not ideal (as u have other apps like telegram) but it'd be better than nothing

austere talon
#

So yes it's possible

charred monolithBOT
charred monolithBOT
charred monolithBOT
#

shiggy.gif is now a local file inside static instead of making a web request, not sure if this saves time but if something ever happens to the emoji for some reason it won't bork things
updated the name field in package.json from VencordDesktop to vencord-desktop, because package.json is really weird about capitalization in the name field.
appBadge.ts - changed if (count === -1) to if (count < 0), this should make sure if the count was -2 (somehow) then it would still work fine

of co...

woeful sable
#

this?

austere talon
#

no

woeful sable
#

it couldve just been leveraging an old bug where if you right clicked on the sound instead of left clicking it played regardless

austere talon
#

it is believed to be impossible for several reasons

#

so it would surprise me a lot if that person is actually saying the truth

#

there is a vencord plugin for it but it only works on web and vesktop, not discord desktop

#

it works by just playing the sound through ur microphone

woeful sable
#

all I know is that it went away when discord messed with the api a bit

#

and suddenly the glitch was gone

austere talon
#

inb4 the plugin is local only lol

austere talon
#

it's not in mainline vencord

woeful sable
#

oh fair

austere talon
#

HOLY SHIT I NEED TO LOOK AT COBU PRS

woeful sable
#

it would be nice if vesktop (or other releases of vencord) had a way to load arbitrary plugins but i am not smart enough to do that

austere talon
#

they do

#

you just need to build from source

woeful sable
#

well yeah i know that

#

I mean without building from source

#

every time

austere talon
#

no

#

vencord doesn't function that way

gray jetty
# woeful sable I mean without building from source

don't think you'd be able to do it without rebuilding it with every change unless vesktop heavily modifies vencord. Can always do 'pnpm watch' tho, it watches for changes and builds automatically, might give u pretty much the same experience as not having to build, cause it'll just do it in the background

woeful sable
#

yeah the architecture of vencord seemingly is that it registers all of the plugins on build and incorporates them into the final build, it would be possible to add plugin loading, but at some point it becomes really unnecessary

charred monolithBOT
austere talon
#

that plugin is really irresponsible

#

sending such bad requests can potentially have risks for your account

topaz thistle
charred monolithBOT
austere talon
topaz thistle
jagged cloak
#

rako used replugged cant believe them

charred monolithBOT
charred monolithBOT
frail skyBOT
#
Bad Patches

None

Bad Starts

None

Discord Errors

None

nimble plaza
#

the voices

#

theyre gone

frail skyBOT
#
Bad Patches

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
mortal fractal
olive aurora
#

there already is

#

ven is just an airhead

#

๐Ÿ’”

austere talon
# charred monolith

the fact that there are multiple firerox entries means separate pulse audio targets

#

so it most likely is possible to have per tab or per window screenshare

charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
#

it will share audio for all Firefox instances combined. separating per window is out of scope for now

Even then you can't really separate out browser audio because browsers are already multiprocess as is, audio will be streamed out of all instances no matter the window video is being captured from.

Chrome and Firefox spawn different nodes for each tab, so it should work ^^

venmic currently provides all the information required to differentiate between tabs, however the information ...

charred monolithBOT
charred monolithBOT
charred monolithBOT
#

Hello, after installing Vencord Via AppImage, I've noticed that if I use a desktop integration tool, my VM doesn't put them in the same icon (so VMClass)
In the build section of the package.json I've added StartupVMClass as it's what's expected for most desktop environment (I didn't removed VMClass as I don't really know if its useful or not for other things.)

Also it's weird that there are two Icons shipped. like if the app image one has it's own bundled and the app another one.

But i...

#

Hello, after installing Vencord Via AppImage, I've noticed that if I use a desktop integration tool, my VM doesn't put them in the same icon (so VMClass)
In the build section of the package.json I've added StartupVMClass as it's what's expected for most desktop environment (I didn't removed VMClass as I don't really know if its useful or not for other things.)

Also it's weird that there are two Icons shipped. like if the app image one has it's own bundled and the app another one.

B...

turbid hatch
#

eh?

#

wasn't this already fixed?

charred monolithBOT
charred monolithBOT
austere talon
#

probably wayland capturer bug lol

#

if anything

charred monolithBOT
topaz thistle
#

FUCK

#

Wrong fedora version in the dockerfile husk

charred monolithBOT
topaz thistle
#

Second time's the charm blobcatcozy

charred monolithBOT
charred monolithBOT
austere talon
#

works on my machine

charred monolithBOT
charred monolithBOT
nimble plaza
#

this person reeeally likes making winget packages for ppl who dont want them /lmao

#

??????????

topaz thistle
#

Holy fuck non merged

#

Ouch

charred monolithBOT
lime stone
#

they have 99 merged

#

i somehow have 106 merged ๐Ÿ˜ญ

#

do i not have a life

austere talon
#

@turbid hatch

#

it's right here

turbid hatch
#

im confused

#

what's the problem?

#

is it not submitted yet?

austere talon
turbid hatch
#

oh

austere talon
#

there's no pr

turbid hatch
#

its because github died

#

when it tried to submit

#

Caused by: java.io.IOException: /10.1.0.46:48554: GOAWAY received

austere talon
#

guh

turbid hatch
#

this is why i set it up as a manual action

#

as well

#

it'll take a couple days

#

for it to become the latest

#

but it should submit the pr now

charred monolithBOT
turbid hatch
#

yeah @austere talon just github being dumb, it did it first time

#

yeah its okay, its just that the

#

action failed!

#

oh well not bothered

#

but it seems like github had a massive fit

#

funnily enough this action has failed every time we've ran it

#

there seems to be a bug in this

#

strange

#

i'll have a look

topaz thistle
#

HOLY FUCK ITS WORKING

turbid hatch
#

wouldnt using artifacts be better for that by the way

#

storing a gig in the cache seems off

topaz thistle
#

Uhm well maybe we could also upload it as an artifact but I think the cache stays valid for way longer than artifacts

charred monolithBOT
#
[Vencord/Vesktop] New branch created: ci/pin-winget-higher
turbid hatch
#

i'll just automerge it

#

there's nothing to review here

#

it's just me bumping the sha to the latest commit

charred monolithBOT
turbid hatch
#

i'll rerun the action again and it should finish up correctly for once

charred monolithBOT
#
[Vencord/Vesktop] branch deleted: ci/pin-winget-higher
turbid hatch
#

there we go

#

it finished properly now

#

it seems like whatever they used to use for autoupdating has been removed

topaz thistle
#

nvm artifacts last longer than caches

#

I'll also upload an artifact of the images

#

we should probably also store them somewhere because if we don't release every 90 days they'll expire as well

turbid hatch
#

use github packages

#

oh wait that's quite expensive actually isnt it

#

hm

topaz thistle
#

Yes

turbid hatch
#

oh no its not

topaz thistle
#

We need more than 500mb

turbid hatch
#

its free for public repositories

#

private repositories have restrictions

#

yeah use packages

#

if we encounter issues or we start racking up a charge we can find another way

#

i'll take the hit for that if it costs money

topaz thistle
#

Where does it state that you get more than 500mb in public repos?

#

Ah

turbid hatch
#

the fact it says

topaz thistle
#

It just says private at the top

turbid hatch
#

"is free for public repositories"

#

and then the entire paid bit is "private repositories"

#

:P

topaz thistle
#

Bruh I did not read the banner lmao

turbid hatch
#

but yes use artifacts for transferring between actions, using cache seems wrong

#

and then use packages for uploading persistently

#

well

#

hm

#

i suppose if the cache works then leave it

#

is it just for transferring build data?

topaz thistle
#

Kind of

turbid hatch
#

let me take a read of your workflow

topaz thistle
#

Yes do that

turbid hatch
#

publish right?

topaz thistle
#

yep

turbid hatch
#

heh nice emojis

#

cute

#

i see an issue

#

unless this is intentional

charred monolithBOT
turbid hatch
#

you will never rebuild the docker images after they've been built once

topaz thistle
#

That's intentional

turbid hatch
#

alright

topaz thistle
#

Look at the docker image

turbid hatch
#

im just reading the workflow atm

topaz thistle
#

It's just a basic fedora:38 image with build dependencies pre installed

turbid hatch
#

gimme a minute

topaz thistle
#

We cache that because building the image takes over 1 hour on arm

turbid hatch
#

you dont need to pull the arm image for an x64 builder

#

and vice versa

topaz thistle
#

I need to, because otherwise its a cache miss

turbid hatch
#

really?

#

that's odd

topaz thistle
#

I had it like that literally 2 commits ago yeah

turbid hatch
#

hm

#

i didnt think that would happen

#

using artifacts might be more appropriate then

topaz thistle
#

same lol

turbid hatch
#

because otherwise we're pulling data essentially for the sake of it

#

and that's useless

topaz thistle
#

yep but I'd prefer something that's permanent, can we use github packages if we already have a publish config in the package json?

#

also it's probably going to clash with the current npmignore

turbid hatch
#

hm

#

you can publish the builder images to packages, sure

#

it'll be persistent enough

#

just make sure to make it rebuild if they ever go poof

#

that seems like the most appropriate solution from my standpoint

topaz thistle
#

Really not sure how I can set it up with npm when we already have an npmignore and publish config

turbid hatch
#

in this case, you dont need to

topaz thistle
#

Huh?

turbid hatch
#

use docker/build-push-action

#

it's like pushing to a container registry

#

in fact, you are

topaz thistle
#

Ah and that can also publish to github packages? That's neat

turbid hatch
#

github packages services the github container registry

#

if you've ever used it

#

so you can publish directly using actions

#

no need to faff with tar files or whatevs

topaz thistle
#

Can I skip the build with that as well?

turbid hatch
#

you can poke it to check for the image's existence yes

#

just use standard docker actions to do so

#

here, better than me explaining

#

here's how to do it in actions

topaz thistle
#

Not possible with this action but your workflow seems to be a good pattern for your use case.

#

Can you use docker push to push to github packages?

turbid hatch
#

yes

#

if you choose to not use the action directly you can always do it from the cli

#

ghcr is a real container registry

topaz thistle
#

ah alr thanks will try to set it up

turbid hatch
#
echo $PAT | docker login ghcr.io --username phanatic --password-stdin
docker tag app ghcr.io/phanatic/app:1.0.0
docker push ghcr.io/phanatic/app:1.0.0
junior olive
turbid hatch
#

thats what we were checking for

junior olive
#

no it's not

turbid hatch
#

y.

#

yes.

#

yes it is.

junior olive
#

no.. it's not..

topaz thistle
junior olive
#

i am using it, in a private repo, for free

turbid hatch
#

you get

#

part of it

#

for free

#

you do not get

#

a lot

topaz thistle
#

You can use a GITHUB_TOKEN in a GitHub Actions workflow to delete or restore a package using the REST API, i

Found it

turbid hatch
#

please read

#

before

#

you

#

comment

#

thank

#

you

#

and also we're an organisation with no subscription

#

so we don't get it for free in private repos

junior olive
#

i'm using it in a org with no subscription

#

wait how the fuck am i using it then

turbid hatch
#

well good for you

#

that's what their pricing says

#

i've been billed every time i've used it in a private org

#

check your subscriptions

junior olive
#

oh shit

#

nope no costs

#

I have pro but my org doesn't so no idea how this is working out

#

anyways venmic isn't private is it?

turbid hatch
#

no

#

that's why we're using it

junior olive
#

yea so why worry about the private costs

turbid hatch
#

we're

#

not

#

that's the

#

point

#

i dont quite understand why you've joined in on this with no context

turbid hatch
junior olive
#

Seemed like you thought packages is entirely unusable in private repos but it's not

turbid hatch
#

no

turbid hatch
#

quite literally post the payment page

#

right after here

junior olive
#

bro relax

austere talon
turbid hatch
#

im very chill actually! if you think i'm pissed off then you don't know me

junior olive
turbid hatch
#

yeah i do that when im being sarcastic or something's awfully obvious

junior olive
#

ยฏ_(ใƒ„)_/ยฏ

#

my bad, i shoulda read more ig

turbid hatch
#

that is the correct conclusion to have established, thank you for understanding

charred monolithBOT
topaz thistle
#

@turbid hatch Do GitHub Packages stay up indefinetly?

turbid hatch
#

yes

topaz thistle
#

Awesome

turbid hatch
#

since it's a package registry the stuff you publish there is persistent

junior olive
#

the way github markets packages limits is so confusing icl

turbid hatch
#

is it?

#

"GitHub Packages is a platform for hosting and managing packages" seems pretty obvious to me, but idk

junior olive
#

packages limits

turbid hatch
#

oh, yeah i do agree with that

#

they should just use a table for both

charred monolithBOT
junior olive
#

see that adds to the point i was ab to make like

turbid hatch
#

but eh, i think the big "is free for public repositories" also does the job

junior olive
#

you gotta read really closely

turbid hatch
junior olive
#

which humans frankly do not

turbid hatch
#

who knows

junior olive
#

the split-pane of free for public and private is unclear and makes me think the limit of tables is the free limits for public repos