#๐พ-core-development
1 messages ยท Page 113 of 1
I should have looked before
are u not subbed to vencord repo
i got the email this morning
woke up and gotjumpscared by the email
ayoo so many broken plugins??
free my boy autumn ๐
I have email disabled lol
damn
couldntbe me
github emailing me 50 times a day is the only way i feel like someone cares about me
im just kidding
I see
narrator: ven is, indeed, not kidding
@cunning canyon btw sorry about that
he will never forgive u
nono
I mean github notifications for email
horrifying
we will soon amend vencords license to state that mantika may not distribute it
no longer free software sorry
imo having a setting for this is pointless
6c1b8b0 Fix MessageDecorationsAPI - Nuckyz
5a0b2ee Fix FakeNitro patch - Nuckyz
fe60a72 Fix NoPendingCount patch - Nuckyz
3c18c28 Merge branch 'dev' of https://github.com/Vendic... - Nuckyz
horrible but works
it doesnt matter
aight
f659c46 FakeNitro: Add app icon customization (#1822) - zImPatrick
you silly goober
channelToAffect: {
None
None
None
beautiful
Have we finally done it?
ikr
None
None
None
wow
use \i to match identifiers instead of .{1,2}
match: /var (\i)=(\{.+?\});/g,
this match should also be made a bit more specific
availableSounds = settings.store.showDetuneSounds ? Object.keys(names) : Object.keys(names).filter(name => !name.includes("detune"));
return replacement?.link;
why not use proper methods? they're shorter
async start() {
#1765
why another effort? :sob:
fada76e PlatformIndicators: make size same as other mem... - mctaylors
i've already made more progress on my plugin and it supports more ๐ญ
you should use SelectedChannelStore.getChannelId() instead
// TODO: Still need to fetch for member list
(or just complete it?)
this is kinda an anti pattern. could just do smth like
const decor = user && store.get(user.id);
if (!decor) return user;
...
Oh! I didnโt even notice yours Iโm sorry. Looking at it, it hasnโt really moved in more than two weeks, do you still plan to work on it? @TheKodeToad
is it just me or is the video broken lol
I do, I've just been uh
doing things
I can give you permissions on the repo if you want to help
oh is it hevc
(nah, i've been doing literally nothing)
firefox on fedora experience
it tells me I need to download discord app
Did he mean activities?
Iโm confused
oh
i think that requires more than just arrpc
@mortal forum do you have any knowledge on that?
the "ask to join" button on some rich presences
is that something arrpc can / will support?
i have no idea how that works
honestly idek what games have that
i think fortnite maybe
any fortnite gaymers
No need for perms I can just PR to your branch. If I find time Iโll see about tackling some of the TODO stuff you have listed there ๐
btw discord has a lot of rpc logic in the renderer-side and arrpc copies some of that lol
you might know + i did mention it before, but i'd imagine you might need to uh
copy some more code :D
but ducko knows more so...
IDK what normal people normally do but i think it's more convenient to directly push instead of having two levels of PR lol
why don't you dm ungfella
wdym
instead of a random person
i just scrolled through the member list til i found someone with a joinable activity

it took a while
i'm not sure if implementing this is possible, as it might require some RPC api that arrpc does not implement
Haha probably but if it were me I wouldnโt give write access for something to someone I donโt know, totally up to you though I donโt mind either way
what would anyone do anyway lol
force push everything away? what is your gain?
- i have a local copy
and this exists which shows all force pushes https://github.com/TheKodeToad/ToadMod/activity
im gonna be fully honest
i had no idea that exists
huh how do you change people's perm level
wdym
just has this
triage, write, maintain
whatever
they probably have access to everything lol
hi uh idk if this is the right place but i wanted to try to make a plugin
cjeck docs folder on github
and contributing file
okay thanks
arrpc doesn't copy any code what
Hey, I'm having a problem where Vesktop doesn't ask for permission to use my microphone. Unlike discord, i never got the prompt in the first place so i am unable to grant the permission. Help appreciated, thanks.
well it looks very similar to Discord's code
what
where, how
let me find an older message
i had to find it again
you just linked a line?
start of function
regardless of whether the structure of the code is inspired by discord, it does do pretty much the same thing
...because it's made to do the same thing?
i mean obviously yeah
okay thanks ducko
like copy the actual code
if you didn't know better you would think that
me when that is the definition of copy
this depends on https://github.com/OpenAsar/arrpc/issues/18, which will most likely never be implemented
me when code made to do same thing does same thing
so that's basically a copy anyway?
wdym ๐ญ there are only so many ways to write websocket code
it is like saying discord mods copy each other for doing webpack the same way
i don't want to argue about what copy means.
..you can only do it one way to make it work properly
it's pretty hard to see code and write something that doesn't look like you copied it and changed the variable names so the "teacher doesn't notice"
but whatever
i suppose i was technically wrong
that isn't what I did but okay
i didn't say that, i just meant it often looks like that ๐ญ
yes!
this is a joke.
obviously i should write it in uh
brainfuck
idk how to break this to you but every websocket code in existence looks similar
cause there's only one way to use websocket

but you are looking at one piece of code and trying to reimplement it
so you might consider that a form of copying
but yeah this is networking and you have to achieve the same thing soo...
a form of reimplementing ๐
i have reimplemented something before and fixed it because the original was broken ๐
i meant discord itself because it is broken ๐
cce0577 package.json: add more metadata; make linux only - Vendicated
hi @uku3lig, could you try again now and see if your issue is fixed?
works flawlessly, thank you very much!
please see if this is fixed on 0.4.0
Closing as fixed. Please reopen if this is still an issue on 0.4.0
Fixes issue where Owner Crown doesn't display in GDMs
wtf
if u enable this it breaks search history
I tested and it worked without lol
ye I have it enabled
maybe experiment
@austere talon can I PR a change to vesktop so it releases arm64 Linux builds
Asahi Linux users & Raspberry Pi users
I have 0.3.3 self built rn
is there really no better way to do this less verbose??
Afaik no, I tried one target with the inner target as a array of strings but builder just errored, it's only allowed to be a string
After updating to V0.4.0 ArRPC stopped working for me
relaunching didn't work;
https://github.com/Vencord/Vesktop/assets/126973723/b19ca854-6471-4053-b177-f117921d2e13
clicking the retry button also didn't work.
I tried downgrading to 0.3.3, which solved the issue, confirming it only happens on 0.40
https://github.com/Vencord/Vesktop/assets/126973723/9132523b-6f0e-40...
could we have an attribute in themeattributes on the html thing at the top like "isMaximized" or something? id really love that for css
disable the plugin it's obsolete
is that not a thing already?
i could swear it is
yeah i was thinking of app-focused
my title/winbar snippet that remove the title and moves the window buttons into the top bar
maximized windows are a social construct
yes but you cant move the window with this since i removed the bar that would do that 
what is a titlebar
thats an option
disable the plugin it's obsolete
That seemed to solve my issue, Thank you!
For users having the same problem, here's how to disable it
https://github.com/Vencord/Vesktop/assets/126973723/1f5a99a6-e954-4213-be3e-81ecad212e01
who up forking they vesktop ๐ค๐ค๐ค๐ค๐ค๐ค๐ค๐ค๐ค๐ค๐ค๐ค๐ค๐ค๐ค๐ค
since 0.4.0, multiple empty audio sources show up in the picker (on linux), see attached screenshot
this pr fixes it by checking if the strings are falsy, lmk if there is a better way do it
why does this person have the most scuffed audio sources
@topaz thistle should this check be done on c++ side?
also this would require arm64 venmic
can we add an arm64 venmic build?
Hm I'm curious on how they even show up
Yes
isn't it optional?
yes but why would we ship half broken software
if we're adding arm64 support it should be done properly
The nodes are required to have application.name and node.name, which should be set and not null
๐
@uneven bolt is that u
ya thats them
do u need arm64 to build arm64 node addon?
or can u build it on amd64
you should be able to cross compile
yeah hi
don't feel like making a pr but this issue with the background overflowing past the border on the Vesktop splash screen can be fixed by adding this to splash.html
body {
background: transparent;
}
.wrapper {
background: var(--bg);
}```
looks like he uses an os matrix and builds on proper arch
that's better than cross compiling
god his workflow is so complex
do you want another pw-dump?
if we wanna use a matrix we'd need to make every worker upload artifact then download all the artifacts in the final release step
yes please
that's scuffed i don't think github offers arm runners outside of mac xlarge??
clearly they do
So it's probably running under qemu
Make sure the null names are showing in Discord
And then run pw-dump
oh wait no
it does cross compile
matrix.arch is only used here
so we don't even need a matrix
https://github.com/Vencord/venmic/blob/main/src/patchbay.impl.cpp#L289 Yeah this shouldn't be happening unless some programs seriously misuse the node props
it's just possibly faster
cross compiling shouldn't be slow though
if anything emulating the right platform should be slower
great now the empty sources don't show up anymore 
i meant building amd64 then arm is possibly slower than building parallely
but it doesnt matter much tbh
hmm
Please let me know when you're able to reproduce this, would really like to know what's causing that
it seems to happen only after i stream for a first time
here's the pw-dump
Could you try to find out which applications in particular are causing it?
I'd like to reproduce it as I think it might be some deeper issue
Dump doesn't show anything out of the ordinary
Will venmic have any issues with 16k page tables?
wdym
Are there any assumptions of a 4K page table
it seems to happen with any app, it first appeared when i was playing gd (through wine) but it also happens on firefox (running natively on wayland) and pipewire-alsa apps (osu!)
no
electron doesnt work on 16k page arm64 tho
it segfaults
so it doesnt even matter
Alright will check for myself, give me a second

when??
I have vesktop running on fedora on my MacBook
I cant reproduce it, what I tried:
- Quit Vesktop
- Start Vesktop
- Joined VC, started Stream
i remember trying to run vscode server on my vps
oh wait i have 64k not 16k
but surely they also fixed 64k
Ages ago they backported the fix

i checked like 1y ago
this is exactly what i did to test it, three times
What's your pipewire version?
i launch it with --ozone-platform-hint=auto --enable-webrtc-pipewire-capturer, if that can matter
0.3.82
the second one is obsolete now im pretty sure
i dont use it and it still works
Hm
oh
i'll see if removing it changes anything
Still can't reproduce - Even with the same flags.
I'll push a "fix" to venmic, please let me know if that fixes it (If it doesn't maybe something in Vesktop goes wrong)
brooo
WAIT IS THAT WHY MY SEARCH HISTORY HAS BEEN BROKEN FOR AGES
Works on my 16k machine

so 64k page size still broken
@austere talon I'll bump the tag after the fix - Is that ok?
will do
yeah but maybe first check whether it works
you can send the .node file and uku can manually replace it locally
Good idea
or a simple patch file i can rebuild it myself if you want
Patch is in the native code I'm not sure how that's built in npm
oh i didnt know u had venmic build already set up
isn't it just pnpm i and then copy the .node file over?
ya
yeah i have linux-virtmic cloned
replace node_modules/<@&1015072428843601962>encord/venmic/prebuilds/
then pnpm start
epic ping
when i upload a sticker using fakenitro it displays the image normally and then also adds the fakenitro sticker, just wanted to let ya know
it seems to have worked
Wow that's really weird
Seems like some nodes are misusing props on your system a little
Anyways
The fix is not bad
I'll push
It should be fine
I can't find anything about whether it got fixed too or not
Apple uses 16k tho and bc of asahi they've supported that
did u update it idk :(
All I know is it works for me
that was electron27
freshest of the freshest of electrons
it literally was cooked up just 2h ago
a baby, one could say
sad
anyway
I guess no consumer platforms support it yet so why bother
Yeah but that's server and not really consumer environment in the same sense yk
Yeah
Uh wait
Is SIGTRAP even the error for page size issues
What a bunch of baloney @austere talon
they didn't write the 16k patch themselves
Why are the artifacts so huge lmao
Ah okay
they don't support 64k pages due to a specific issue and it's a uncommon platform @austere talon
Some mf on chromium team not wanting to write support for 16k pages on Linux
"[PA] Support 16kb pagesize on Linux+ARM64
This makes the system pagesize a run-time property.
ARM64 supports 4kb, 16kb, and 64kb page sizes. Previously, only 4kb
was supported by Chromium. This patch adds 16kb support, as is used
for example by Asahi Linux on M1 Macs. The rare 64kb case is still
not supported due to further changes needed to SlotSpanMetadata."
Tbh you can't blame them for not supporting it
None
None
None
None
None
None
the voices are gone
@austere talon do you know of how this can be disabled for vencord-desktop-git, since its kinda useless
you cant right now
but i used to have this on my modified pkgbuild ```sh
prepare() {
cd "$pkgname"
sed -i '/import { checkUpdates } from "updater/main"/d; /checkUpdates();/d' src/main/index.ts
}
i guess just sed -i "/checkUpdates/d" src/main/index.ts works
@dapper tiger do
what that do
it jus stops calling the code thats checking for updates
The updater close button currently closes the main window. This PR makes it actually close the updater.
A few things to consider:
- Should the splash colors setting be renamed if the updater also adapts to the theme?
- Should the success/danger/link colors also be extracted from Discord web?
https://github.com/Vencord/Vesktop/assets/22896890/55444009-2113-457d-886d-cf08ceeda3e1
still occurs, also happens if ran as admin
@TheKodeToad couple questions about direction:
Upload local file (how should I store the data)
I made it just do the classic "upload and convert/save to data URI" which I think is probably the best option, lemme know if anyone thinks of anything better.
Settings are applied directly instead of being queued
I don't really see this as a problem, only issue being that the "Save" part of the "Save & close" button is technically a bit misleading. I feel like it would take more ef...
Enable the April Fools' 2023 experiment to see them in settings.
that's what the detune was for
I made it just do the classic "upload and convert/save to data URI" which I think is probably the best option, lemme know if anyone thinks of anything better.
There's a reason I wasn't sure on the best way to store the data. I think IndexedDB would be better... maybe I could just move all settings there like TextReplace but I thought having the URLs was okay in the settings JSON
I know quite a few languages with similar-ish syntax, so i felt pretty confident I could figure it out. + making stuff and just learning while doing it is kinda just the way I learn languages, online courses just dont work for me
once you know enough languages other languages are pretty easy
yea
(unless you're going from a million garbage collected languages to C, C++ or Rust)
thats why i kept it simple, so i didnt accidentally try to commit crappy code lol
I can see about moving the settings to IndexedDB tmr if I find time/don't forget. As for the other sounds (eg. detune sounds), I can probably just load them on-the-fly like how I did in my PR, that way it always works between additions/removals of sounds. That means they won't show up in the settings menu unless the plugin is enabled though, which admittedly is a little strange. Or that stuff, too, could just be left until after the initial plugin is finished, but that's not up to me ๐ .
I might be able to figure it out, but my idea was to - if a sound is enabled - use the default sound instead of the soundpacks'
WHO'S DAVE
poor dave
hi crazy dave
This pr improves the relationshipnotifier plugin by adding notifications for accepted friend requests or when someone uses your friend invite.
This feature can be helpful as discord web/desktop does not have notification for friend request acceptances/friend invite clicked..
However, enabling "Friends Add" and the "Offline Removals/Adds" settings will trigger a bunch of notifications "___ added you as a friend" due to the plugin syncing with the friend list. That's why the Friends Add opt...
It does? I could be wrong but years ago, it was existing
Either way, this sounds ok
make a notification plugin where we can change the sound
good idea
oh my god.
?
(i just realized)
if you see this, your -git is NOT up to date
toad already started doing it
https://github.com/Vendicated/Vencord/pull/1765#issuecomment-1774041788
Hey where should I start if Im looking to make a plugin?
https://github.com/Vendicated/Vencord/blob/main/CONTRIBUTING.md it's a bit outdated though
looking at other existing plugins really helped me
and ^ that too
Alright thanks, Im looking to make key shortcuts for this menu
For example if you pressed D when this dialog was open youd delete the message or if you pressed E you could edit it
How do you highlight a message?
I see but I think my idea would be easier
i don't think this is a good way to do this
the normal CLOSE one should already work
CLOSE one?
ohhh
this is wrong
try changing it to e.sender.close()
@placid hinge
i think i originally had it as that but for some reason changed it? and forgot to update installer?
im not talking to you
Sorry about that
for some reason I changed it here
from e.sender.close to mainWin.close
ig it did not work correctly for the mainWin? or smth?
I honestly have no idea
wtf is a venctrum
Hey is there a way to enable inspecting elements in vencord/discord
ctrl shift i
AWESOME!
probably idk
so it works to close the updater? does it also work when using from the main window? normally that would be in the windows window controls but you can just test it manually via console
huhh
why would i change if it works fine
I swear there has to be some reason
why else would I change it
O_o
if only I knew what past v had going on in their brain
Thanks for the help spooky
you're probably better off asking in #๐งฉ-plugin-development btw
this channel is more for dicussing prs and such
["checkUpdates", "Check for updates", "Automatically check for Vesktop updates", true]
well we still need venmic arm64
horror
mm --arch option to cmake-js isnt working
--CDCMAKE_SYSTEM_PROCESSOR=arm64 also no work
well noah will know
oh @placid hinge now i see why i changed it to mainWin
e.sender.close will completely close vesktop
when the desired behaviour is to minimise to tray
i got smth that might work
handle(IpcEvents.CLOSE, e => {
BrowserWindow.fromWebContents(e.sender)?.close();
});
try this
works as expected for the main window
seems to also work for the updater window
if that doesn't work, we could possibly do two ipc channels:
CLOSE_SELF, CLOSE_MAIN_WIN
it closes the BrowserWindow itself, not the webContents
idk if that also fully closes the webContents?
idk how to properly verify
it would be bad if some dead updater window background process would still run
holy hell im bad at using github, i just spent an hour figuring out how to revert a commit and change a folder name ๐
It happens.
git revert [commit hash]
mv folder_name new_folder_name
git add :/
git commit -m "Changed folder name"
yeah i figured that out eventually, was tryna do it on the website, only realised its only possible thru cli or desktop after like, 50 mins lmao
how would you get the last commits hash? (from CLI)
I don't think you can cache that because the thing that takes so long running docker through qemu
However, enabling "Friends Add" and the "Offline Removals/Adds" settings will trigger a bunch of notifications "___ added you as a friend" due to the plugin syncing with the friend list. That's why the Friends Add option is toggled off by default
seems like this is pretty hit or miss, but it only happened once, so marked it as ready for review. we can always improve it later on
might wanna give it a go, because if I try I'll definetely hang myself
is it possible to enable Windows' do not disturb from a Vencord plugin? i'm curious cuz it'd be very useful personally
so that DMs aren't leaked as an example
I don't think so as that'd probably require access to native apis
that sucks
But if you just want to prevent desktop notifications from discord there's surely a way
:)
bump, the lack of this + volumebooster not existing is making it hard to hear my quiet friends :(
that could also work
obviously not ideal (as u have other apps like telegram) but it'd be better than nothing
u can always use ipc
So yes it's possible
i recommend putting everyone on 50% and just making vesktop louder, then you can just put individual people higher
shiggy.gif is now a local file inside static instead of making a web request, not sure if this saves time but if something ever happens to the emoji for some reason it won't bork things
updated the name field in package.json from VencordDesktop to vencord-desktop, because package.json is really weird about capitalization in the name field.
appBadge.ts - changed if (count === -1) to if (count < 0), this should make sure if the count was -2 (somehow) then it would still work fine
of co...
this breaks everyone's settings
I am coming from Replugged and there is a plugin there that can enable all soundboards so I know this is possible. This is the one feature I miss from Replugged.
oops, completely forgot that settings relied on that, let me fix that rq
no
it couldve just been leveraging an old bug where if you right clicked on the sound instead of left clicking it played regardless
it is believed to be impossible for several reasons
so it would surprise me a lot if that person is actually saying the truth
there is a vencord plugin for it but it only works on web and vesktop, not discord desktop
it works by just playing the sound through ur microphone
all I know is that it went away when discord messed with the api a bit
and suddenly the glitch was gone
inb4 the plugin is local only lol
what is the plugin called?
it's not in mainline vencord
oh fair
HOLY SHIT I NEED TO LOOK AT COBU PRS
it would be nice if vesktop (or other releases of vencord) had a way to load arbitrary plugins but i am not smart enough to do that
don't think you'd be able to do it without rebuilding it with every change unless vesktop heavily modifies vencord. Can always do 'pnpm watch' tho, it watches for changes and builds automatically, might give u pretty much the same experience as not having to build, cause it'll just do it in the background
yeah the architecture of vencord seemingly is that it registers all of the plugins on build and incorporates them into the final build, it would be possible to add plugin loading, but at some point it becomes really unnecessary
It is part of this plugin, It will let me use sounds from other servers, one thing it can't do is use sounds if the server doesn't have enough boosts.
like the description of it says, it does not give you any nitro features, they are restricted server side. it's only playing the sounds for you locally, other people cannot hear them. open the devtools while doing it and look for red errors, there will most likely be many 403, 401 or 400 api errors
figured lol
that plugin is really irresponsible
sending such bad requests can potentially have risks for your account
Soundux integration
Ah you are right, it does play but there is a 403 in the console every time I play it.
Soundux plugin when
Might actually be plausible when I finish the new version (it will offer a rest-api to control it)
Currently the streaming dialog defaults to none, and with 20 "Firefox" options to choose from things get difficult.
Game activity doesn't work. Playing Dead by Daylight for example doesn't give me the "Playing: Dead by daylight" status in servers, etc.
It seems to only work for rich presence titles.
OS: Arch Linux
Using Release 0.4.0
the duplicates are a bug that will be fixed next update. choosing audio is actually not a simple task because electron only gives us the window title, not any more info like the app name or pid
does it work on stock discord?
Though it sometimes picks up other strange things like pv-bwrap, pressure-vessel things and wine64-preloader. Unsure if it works on Windows.
Ah. Would it be a good idea to display the window titles in the audio section then (or is this broken)? If I have multiple firefox windows with different tabs they still only show "Firefox".
it will share audio for all Firefox instances combined. separating per window is out of scope for now
None
None
None
None
None
None
it will share audio for all Firefox instances combined. separating per window is out of scope for now
Even then you can't really separate out browser audio because browsers are already multiprocess as is, audio will be streamed out of all instances no matter the window video is being captured from.
add webhook smh
the fact that there are multiple firerox entries means separate pulse audio targets
so it most likely is possible to have per tab or per window screenshare
it will share audio for all Firefox instances combined. separating per window is out of scope for now
Would actually be possible with the current venmic code if the user would want to tough (just mentioning it here)
it will share audio for all Firefox instances combined. separating per window is out of scope for now
Even then you can't really separate out browser audio because browsers are already multiprocess as is, audio will be streamed out of all instances no matter the window video is being captured from.
Chrome and Firefox spawn different nodes for each tab, so it should work ^^
venmic currently provides all the information required to differentiate between tabs, however the information ...
This looks better on some themes and doesn't on others. Unfortunately, there isn't really a way to find the actual Discord button styles without hardcoding class names and injecting fake HTML, so maybe keep the buttons as-is?
Increases paddings and margins and also makes the profile scrollable
Hello, after installing Vencord Via AppImage, I've noticed that if I use a desktop integration tool, my VM doesn't put them in the same icon (so VMClass)
In the build section of the package.json I've added StartupVMClass as it's what's expected for most desktop environment (I didn't removed VMClass as I don't really know if its useful or not for other things.)
Also it's weird that there are two Icons shipped. like if the app image one has it's own bundled and the app another one.
But i...
Hello, after installing Vencord Via AppImage, I've noticed that if I use a desktop integration tool, my VM doesn't put them in the same icon (so VMClass)
In the build section of the package.json I've added StartupVMClass as it's what's expected for most desktop environment (I didn't removed VMClass as I don't really know if its useful or not for other things.)
Also it's weird that there are two Icons shipped. like if the app image one has it's own bundled and the app another one.
B...
putting everyone on 50% without a global toggle option sounds like a surefire way to get blasted when you join somewhere you haven't been before/people you haven't set to 50% before
that is a viable bandaid though, used that before on base discord
Discord has a toggle for automatic gain control. It currently has no effect on vesktop though. it would be great to implement it
Screenshare stops updating the image when resizing the streamed window.
Info:
Ptb 239402 (d5844b3)
Vencord 544edce (Vesktop V0.4.0)
Electron 27.0.0
Chromium 118.0.5993.54
Windows 10 64-Bit <- Thats a lie. I'm using Arch, btw.
WM: KWin (Wayland)
Can everyone please pray that this shit works first try
FUCK
Wrong fedora version in the dockerfile 
Second time's the charm 
working on a ui to replace the command, marked as draft for now
this person reeeally likes making winget packages for ppl who dont want them /lmao
??????????
@turbid hatch
it's right here
oh
there's no pr
its because github died
when it tried to submit
Caused by: java.io.IOException: /10.1.0.46:48554: GOAWAY received
guh
this is why i set it up as a manual action
as well
it'll take a couple days
for it to become the latest
but it should submit the pr now
yeah @austere talon just github being dumb, it did it first time
yeah its okay, its just that the
action failed!
oh well not bothered
but it seems like github had a massive fit
funnily enough this action has failed every time we've ran it
there seems to be a bug in this
strange
i'll have a look
wouldnt using artifacts be better for that by the way
storing a gig in the cache seems off
Uhm well maybe we could also upload it as an artifact but I think the cache stays valid for way longer than artifacts
25156ad ci: pin wgr to new version - lewisakura
i'll just automerge it
there's nothing to review here
it's just me bumping the sha to the latest commit
i'll rerun the action again and it should finish up correctly for once
there we go
it finished properly now
it seems like whatever they used to use for autoupdating has been removed
nvm artifacts last longer than caches
I'll also upload an artifact of the images
we should probably also store them somewhere because if we don't release every 90 days they'll expire as well
Yes
oh no its not
We need more than 500mb
its free for public repositories
private repositories have restrictions
yeah use packages
if we encounter issues or we start racking up a charge we can find another way
i'll take the hit for that if it costs money
the fact it says
It just says private at the top
"is free for public repositories"
and then the entire paid bit is "private repositories"
:P
Bruh I did not read the banner lmao
but yes use artifacts for transferring between actions, using cache seems wrong
and then use packages for uploading persistently
well
hm
i suppose if the cache works then leave it
is it just for transferring build data?
Kind of
let me take a read of your workflow
Yes do that
publish right?
yep
you will never rebuild the docker images after they've been built once
That's intentional
alright
Look at the docker image
im just reading the workflow atm
It's just a basic fedora:38 image with build dependencies pre installed
gimme a minute
We cache that because building the image takes over 1 hour on arm
you dont need to pull the arm image for an x64 builder
and vice versa
I need to, because otherwise its a cache miss
I had it like that literally 2 commits ago yeah
hm
i didnt think that would happen
using artifacts might be more appropriate then
same lol
because otherwise we're pulling data essentially for the sake of it
and that's useless
yep but I'd prefer something that's permanent, can we use github packages if we already have a publish config in the package json?
also it's probably going to clash with the current npmignore
hm
you can publish the builder images to packages, sure
it'll be persistent enough
just make sure to make it rebuild if they ever go poof
that seems like the most appropriate solution from my standpoint
Really not sure how I can set it up with npm when we already have an npmignore and publish config
in this case, you dont need to
Huh?
use docker/build-push-action
it's like pushing to a container registry
in fact, you are
Ah and that can also publish to github packages? That's neat
github packages services the github container registry
ghcr.io/... you might've seen it as
if you've ever used it
so you can publish directly using actions
no need to faff with tar files or whatevs
Can I skip the build with that as well?
you can poke it to check for the image's existence yes
just use standard docker actions to do so
here, better than me explaining
here's how to do it in actions
Not possible with this action but your workflow seems to be a good pattern for your use case.
Can you use docker push to push to github packages?
yes
if you choose to not use the action directly you can always do it from the cli
ghcr is a real container registry
ah alr thanks will try to set it up
echo $PAT | docker login ghcr.io --username phanatic --password-stdin
docker tag app ghcr.io/phanatic/app:1.0.0
docker push ghcr.io/phanatic/app:1.0.0

u can use packages in private repos, just not for some weird legacy type of priv repo
yes but its paid
thats what we were checking for
no it's not
no.. it's not..
What about the login when using it in the venmic repo?
i am using it, in a private repo, for free
You can use a GITHUB_TOKEN in a GitHub Actions workflow to delete or restore a package using the REST API, i
Found it
please read
before
you
comment
thank
you
and also we're an organisation with no subscription
so we don't get it for free in private repos
well good for you
that's what their pricing says
i've been billed every time i've used it in a private org
check your subscriptions
oh shit
nope no costs
I have pro but my org doesn't so no idea how this is working out
anyways venmic isn't private is it?
yea so why worry about the private costs
we're
not
that's the
point
i dont quite understand why you've joined in on this with no context

^^^^
Seemed like you thought packages is entirely unusable in private repos but it's not
no
^^^^
quite literally post the payment page
right after here
bro relax
im very chill actually! if you think i'm pissed off then you don't know me
it's the way you're typing
yeah i do that when im being sarcastic or something's awfully obvious
that is the correct conclusion to have established, thank you for understanding
@turbid hatch Do GitHub Packages stay up indefinetly?
yes
Awesome
since it's a package registry the stuff you publish there is persistent
the way github markets packages limits is so confusing icl
is it?

"GitHub Packages is a platform for hosting and managing packages" seems pretty obvious to me, but idk
packages limits
see that adds to the point i was ab to make like
but eh, i think the big "is free for public repositories" also does the job
you gotta read really closely

which humans frankly do not
who knows
the split-pane of free for public and private is unclear and makes me think the limit of tables is the free limits for public repos




