same thing
#๐พ-core-development
torn knot
torn knot
can you send me your plugin? (like a zip file or a repo)
junior olive
https://github.com/FieryFlames/Vencord/tree/decor/src/plugins/decor
I can figure out getting said fancy file input myself, I already do something similar, I'm just waiting to see if vap still has their find for it
shy veldt
fancey
torn knot
junior olive
the plugin adds those to said file lol
lofty helm
<@224565309133029379> your wait is over ig
Thanks
lime stone
it wasn't me
lime stone
it was done by AutumnVN and it's merged
junior olive
the plugin adds those to said file lol
You're not gonna be able to take decor out and put it in your fork in it's current state. And the plugin is mostly useless right now because I haven't added the file input and finished the create decoration flow .-.
woeful sable
#rules message rule 9
lofty helm
https://discord.com/channels/1015060230222131221/1015074670963335219/10465473937...
What does that plugin do
junior olive
the file doesn't exist
yes it does, it's missing those two exports because my branch adds those
torn knot
junior olive
look at the path.. it's not in my plugin
junior olive
the two exports that are failing are from the webpack common components/icons
...
Not in my plugin
I added two icons to the common icons file and because you didnt copy that file to your branch too it fails to import them
frail tree
how?
torn knot
I got the selector
but you need to open something that loads its module first
or you can just make it from scratch
junior olive
but you need to open something that loads its module first
This is why I was waiting for vap.. I was wondering if he still had the code to load the module
junior olive
I've already had to do it once for a load of the decoration components, I can probably do it again
torn knot
cause I might need it
junior olive
Kind of.. you can find the bit that loads the chunks and modules and regex the various ids out and recreate it
torn knot
my workaround for this is having to open settings at least once to load the module if it's not loaded
junior olive
look at decor's requireDecorationModules util
Anyways, don't worry about doing it for the file input. I'll figure it out tomorrow when I'm up
torn knot
pretty convincing
from here it will return a file object, like the actual filepicker\
here is the plugin with the filepicker
it won't let me send the 2 files changed individually
the only files changed are style.css and the creator modal
nimble plaza
moving pr to github for hacktoberfest :3
nimble plaza
why does this have colorways commits uhh
cunning canyon
moving pr to github for hacktoberfest :3
uhh but vencord repo is not in hacktoberfest
nimble plaza
oh whale
austere talon
i can just add it
austere talon
moving pr to github for hacktoberfest :3
do you really care about their digital badges
nimble plaza
fair
austere talon
nooo that wasn't a "don't do hacktoberfest" ๐ญ
i was just curious if you really cared
i can add the hacktobafest tag if you want :3
austere talon
no it's all digital ๐ญ
such a shame but I get why they can't send 500k free shirts
cunning canyon
ven did u forget to revert shiki + invis chat to web, since we dropped firefox
austere talon
no
chrome also does not allow remote code
if you want to bring them back you need to refactor them for web to embed dependencies
similar to monaco and rnnoise
nimble plaza
reposting since it got purged
is there any real reason to keep rnnoise anymore? since krisp is on web now
austere talon
kinda
@spark cove wanted to refactor it to give you the choice between krisp and rnnoise
nimble plaza
oo
austere talon
cause apparently for some people rnnoise is better
anyway i personally think just removing it is simpler and I doubt many people will care
obsidian oyster
Is it possible to have a plugin that would check if a user is in a voice channel and if they aren't to reconnect them?
austere talon
no
obsidian oyster
I would need a discord bot for that right?
I tried a py script that used the user token to login and verify connectivity to the vc using the channel ID and reconnect if not connected, but user tokens are not accepted by discords api per the TOS. Didn't know that until I tried to run the script and got a 401 unauthorized error
austere talon
Is it possible to have a plugin that would check if a user is in a voice channel...
if by "a user" you mean yourself then yes
obsidian oyster
yes by user I mean myself. long story short, a friends discord has leaderboards and im trying to be at the top of hours active in it, but they know im trying to do this and disconnect me from calls if im the only one there lol
obsidian oyster
if by "a user" you mean yourself then yes
but if it is possible for myself, how would I go about starting that? Clearly I wouldn't need a user token as the plugin runs when discord launches, Im assuming I can use similar logic to the call length plugin as that starts a timer once connected to a voice channel. but the reconnecting feature is where i get lost
austere talon
your use case is against our rules
obsidian oyster
ah so nevermind
I did not know that, my bad
that would fall into the category of selfbotting huh
lime stone
yes by user I mean myself. long story short, a friends discord has leaderboards ...
lol that's pretty funny but you'd probably get into to trouble if you were automatically reconnecting (and i believe it's selfbotting so discord may terminate/tempban you)
obsidian oyster
Yeah reconnecting myself is where the issue comes in lol cause thats requiring something else to "login" as myself and reconnect me and then logout. Not worth losing my account over I'll just grind the hours manually lmfao
torn knot
why does this have colorways commits uhh
?
cunning canyon
their pr
torn knot
how'd I mess with someone's pr?
cunning canyon
they mess it themself ig
austere talon
how'd I mess with someone's pr?
banned for messing with other people's prs ๐
torn knot
oh boy
turbid hatch
fuck me
i'm going to actually explode
if i have to do any more work on this pr
because of merge conflicts
and not because of bugfixes or whatever
its actually annoying me how git cant resolve this and github forces me to manually resolve it
the thing is i dont actually know what git is doing
to break it this bad
because in the merge editor the incoming side is completely blank
so i'm just blindly accepting the current and then working out what's changed
woeful sable
@turbid hatch can you add 
turbid hatch
another time
toxic bough
Will anyone ever add a avatar decoration / profile effect plugin?
woeful sable
okii
turbid hatch
because we have the ability to find when a role changes
woeful sable
Will anyone ever add a avatar decoration / profile effect plugin?
being worked on
oh
toxic bough
being worked on
Oo okay, thanks.
charred monolithBOT
charred monolithBOT
turbid hatch
^ it's just getting a bit frustrating that i can't progress with any features/changes because i need a review, and my only maintenance to this PR is that i have to go through git commit history on files that no longer exist on this branch to work out how to merge it
@verbal pumice is the mac issue on channeltabs still there?
verbal pumice
yeah
turbid hatch
hm
verbal pumice
haven't touched it since and cant test
turbid hatch
i think @olive barn can help u out with that
once it's fixed i think we can merge it in
(after review ofc)
austere talon
still waiting for BD to add it
there's not much point in us adding it until they also support it
turbid hatch
i dont think it matters if BD adds it 
we can at least encourage people to try and make themes for it
then they'll also be BD-ready when they add the feature
cause it'd be cool to see less and less :root { /* config... */ } and more usercss based gui
(also it might prod them to hurry up on their support)
nimble plaza
haven't touched it since and cant test
what issue should i look for
turbid hatch
run channeltabs on mac, apparently that should be enough to cause the bug
turbid hatch
it's because channeltabs can't account for the mac controls atm
so sunnie needs to know how to account for them and needs a tester
nimble plaza
@verbal pumice this look good?
or should it be more left
this is 80px padding-left on .vc-channeltabs-inner-container
austere talon
jumpscare
turbid hatch
yeah i struggled going through colorways
(hence my comment about adding linebreaks)
nimble plaza
lemme find how to make it apply a class on macos then
verbal pumice
doesnt the body have a specific class dependent on platform
austere talon
doesnt the body have a specific class dependent on platform
it does yeah
.platform-osx or smth like that
nimble plaza
turbid hatch
is that because you already have a padding-left
oh wait
no your selector is wrong
turbid hatch
yeah
austere talon
yeah?
turbid hatch
other way around means an element with platform-osx under the innercontainer
verbal pumice
`.platform-osx .vc-channeltabs-inner-container` works
wait no
turbid hatch
but html is the one with the class
austere talon
.child .parent has never worked in css
turbid hatch
css selectors are order sensitive
verbal pumice
inner container is used for both tabs and bookmarks so thatll add padding to both
why did i not add a separate class
turbid hatch
although i think html.platform-osx ... is probably a better idea for clarity
turbid hatch
easy fix though
austere talon
discord doesn't do that either
austere talon
wdym
austere talon
at the start
turbid hatch
got what you mean
nimble plaza
aanyways easy fix is just css .platform-osx .vc-channeltabs-inner-container { padding-left: 80px; }
with whatever the new class you add is
:3
turbid hatch
i thought you meant they dont put it on html
but now i understand
xd
is 80 the amount of spacing they add?
verbal pumice
aanyways easy fix is just ```css
.platform-osx .vc-channeltabs-inner-container {...
like do i do that now or
nimble plaza
this is 72px
turbid hatch
try 72
turbid hatch
like do i do that now or
ye, add it to your style rules with whatever the tabbar container is
turbid hatch
and change it to 72 whilst ur at it
looks better xd
hm
shame the traffic lights dont line up
wonder if thats something we can change
nimble plaza
.platform-osx .vc-channeltabs-container:nth-child(1) {
padding-left: 72px;
}```
this works if u dont wanna add a new classdouble height titlebars are a norm on OSX so probs not
verbal pumice
```css
.platform-osx .vc-channeltabs-container:nth-child(1) {
padding-left: ...
ig
imo this is better than 2 identical classes but what does everyone else here think
turbid hatch
you dont have to dupe the style rule
turbid hatch
.vc-channeltabs-container, .vc-channeltabs-tab-container
verbal pumice
oh right
turbid hatch
annoyingly i think to move the traffic lights further down we have to edit how the window gets created
its not a big deal but i dont think its worth it
nimble plaza
WHAT DID I DO
turbid hatch
annoyingly i think to move the traffic lights further down we have to edit how t...
have to set hiddenInset instead of hidden, but it might move the lights down too far so it would look off either way, it'd have to be tested
verbal pumice
ok pushed
nimble plaza
verbal pumice
i went fucking insane over trying to disable the discord bind
i probably should but like dont have the mental capacity rn
nimble plaza
lmao dwdw
verbal pumice
sdfbghjhkasfhjagdfhj
nodevtoolswarning didnt do its job and logged me out and when i logged back in bookmarks shat themselves
verbal pumice
it should work
blazing dome
permission to copy the cli.go file from the old installer into the new one?
nimble plaza
oh it saves the bookmarks per account
verbal pumice
nodevtoolswarning didnt do its job and logged me out and when i logged back in b...
oh its because datastore as a whole exploded
not my fault
woo
charred monolithBOT
nimble plaza
just pulled again, looks good
actually wait
its just a bit too far right
65px looks good
verbal pumice
done
fleet depot
oh yeah am i the only one getting this sometimes
โ _Pat&quality=lossless
quality=lossless
austere talon
nodevtoolswarning didnt do its job and logged me out and when i logged back in b...
not possible
verbal pumice
not possible
vesktop decided to just nuke local storage outta nowhere
i reinstalled and its fine so idrc
austere talon
vesktop decided to just nuke local storage outta nowhere
when that happens just close and fully reopen
it happens when you have a dead instance still lingering
normally when you start vesktop from source
hazy kindle
(yk what would be cool imho? if vencord showed on <@&1026534353167208489>sโ profiles which plugins they made/ contributed to)
austere talon
someone already suggested that once
hazy kindle
might be motivating to contribute as well
verbal pumice
would probably be a pain to go back for all the old entries
as well as the discussion of what counts and what doesn't
probably not worth it
limpid badger
I wonderโฆ what happened here
junior olive
You can't use regex in finds can you?
austere talon
You can't use regex in finds can you?
no
nimble plaza
send module id
junior olive
I got a find but I'm haivng other problems now
I can't findByCode it
I don't really want to regex replace it
junior olive
yeah 1s getting id
nimble plaza
oki
junior olive
863979
I want to extract Promise.all([n.e(40532), n.e(56729), n.e(82761)]).then(n.bind(n, 856729))];
I found a working find: {filteredStickers
crude hearth
I want to extract `Promise.all([n.e(40532), n.e(56729), n.e(82761)]).then(n.bind...
why tho
what are you even trying to do
crude hearth
why dont you just get module via findByProps
junior olive
because the module isn't loaded
junior olive
i cant
crude hearth
also that module returns react component
junior olive
the user would need to go to that specific place before the chunks get downloaded and loaded
i'm trying to get those chunks downloaded and loaded in a entirely different place
crude hearth
wait is that module input chat box
junior olive
no
junior olive
which module are you even talking about
junior olive
it's a load of stuff
not just that
ctrlf {filteredStickers
I want to extract the promise down there to load the create sticker modal that has a component i want
crude hearth
basically you want this
junior olive
yes i am trying to load the module that contains that, as it depends on the module that has that file input, causing it to load, and then i can patch that module and extract that file input
I don't want the modal itself I just want to load the modal
crude hearth
tbh just recreate components at this point
junior olive
i mean maybe but if it can be loaded why not
I've already done it once for another module that I needed the components from way more
crude hearth
i mean maybe but if it can be loaded why not
I mean maybe but I just think your way of doing it is horror
regex matching webpack.require picking module ids
and loading
junior olive
it's the best I can do
If I'm doing it for another module I more desperately need the components from I may as well stick with it for this
wtvr ill recreate it
@nimble plaza i found a better place to extract the ids from
i froze patch helpr
torn knot
I think a github review got f*ed
mortal fractal
@torn knot because the reviewed files are changed
torn knot
I see
spark cove
anyway i personally think just removing it is simpler and I doubt many people wi...
REMOVE
torn knot
Well, I just hope that my actual changes that I made just now didn't break
mortal fractal
not testing them 
torn knot
UHHHH
spark cove
Command
austere talon
WHAT
spark cove
Slash command
charred monolithBOT
spark cove
Slash remove
Bloat
All my code is basically like barf
That will eventually be sweeped up
And mopped
And drowned in anti biotics
spark cove
Lest it get any worse
I can't believe it
Dear God
Could you be more subtle next time
And I'll take the bait cus
For the very first time in my life
I'm fixin to bite
austere talon
there we go
animated png or png reads weirdly
junior olive
it was written at 4am 
junior olive
It requires the AvatarDecorationModal when opening the decor modal, and then requires the CreateStickerModal once the user opens create
it's so seamless
torn knot
I turned my webpack chunk & module extractor into a utility <:blobcatcozy:108510...
sauce?
spark pivot
strings are for nerds
yeah just 's' + 'h' + 'i' + 'g'
junior olive
sauce?
import { wreq } from "@webpack";
export default async function extractAndRequireModuleIds(code: Function | string) {
const chunksAndModule = [...code.toString().match(/(Promise.all.+?\)\))/)?.[1].matchAll(/[0-9]+/g) ?? []];
const ids = chunksAndModule.map(m => parseInt(m[0]));
const module = ids.pop()!;
return Promise.all(ids.map(i => wreq.e(i))).then(wreq.bind(wreq, module));
}
that Promise.all regex looks a bit dangerous
woeful sable
It requires the AvatarDecorationModal when opening the decor modal, and then req...
do you still have to hover over your pfp to update the decor?
austere talon
what that regex actually means is find the first Promise.all, then go as far as you need to find )))
junior olive
do you still have to hover over your pfp to update the decor?
that's only visual
for that page only
junior olive
what that regex actually means is find the first Promise.all, then go as far as ...
I know, in both cases it's fine tho
woeful sable
when itโs finished will it automatically update?
junior olive
it matches the .then's double parenthesis
woeful sable
or is it destined to do that
austere talon
I know, in both cases it's fine tho
it really isn't
junior olive
when itโs finished will it automatically update?
when u go out of settings it will update in the app
junior olive
it really isn't
in my two cases
woeful sable
also having โaddโ at the end still feels weird
junior olive
the regex can be made safer 100%
junior olive
also having โaddโ at the end still feels weird
keeping it like this for now
woeful sable
idk if thatโs just me
either way itโs great as it is!! youโve done a great job
junior olive
@austere talon here i'll make a better regex
woeful sable
also maybe make them the same colour for consistency
junior olive
@austere talon how is
Promise.all.+?]\)\.then\(.+?\)\)
not rlly sure how to make it safer
charred monolithBOT
Also tried on Arch and got this message after choosing what to share :
Along with this error :
Screensharing (without audio) is working though
(Tested on Hyprland 0.30.0 and i3 4.22)
torn knot
please send the finished snippet once you finalize it, as I was looking for something simmilar for a long time
charred monolithBOT
Also tried on Arch and got this message after choosing what to share :
Along with this error :
Screensharing (without audio) is working though
(Tested on Hyprland 0.30.0 and i3 4.22)
This probably happens because the virtmic code was updated and this PR ...
austere talon
<@343383572805058560> how is
```Promise.all.+?]\)\.then\(.+?\)\)```
that's no better
like i said this will find the very first Promise.all in the file then match everything up to the ending
do not use .+
junior olive
What should I use instead
It seems to match exactly what I want it to..
It's not being run on files its being run on individual functions
the ? makes it lazy and stops at the first ))
austere talon
Promise.all random ass code that has nothing to do with what you want to match Promise.all([]).then(blah))
try it on this
junior olive
yes it matches that but the chances of the funcs it's being ran on containing that are slim
but okay
how can it be made better? I don't know
quaint sapphire
I turned my webpack chunk & module extractor into a utility <:blobcatcozy:108510...
neat
austere talon
how can it be made better? I don't know
by not using .+
junior olive
but what do i use instead
austere talon
/Promise\.all\(\[(\i\.\i\(\d+\),?\)+\]\)\.then/
now you don't even need to match a second time
quaint sapphire
I really don't like how vencord has custom regex codes
makes it hard to test online
I always use \w+ instead of \i
junior olive
```js
/Promise\.all\(\[(\i\.\i\(\d+\),?\)+\]\)\.then/
```
this is error but im trying to fix
austere talon
I really don't like how vencord has custom regex codes
so you'd rather want to type [A-Za-z_$][\w_$]* every time
quaint sapphire
I only type \w+
they are minified so special chars are rare
quaint sapphire
doesn't \w+ match _?
austere talon
it's equally common as normal letters
quaint sapphire
_ is matched
$ is not matched, which makes sense
most of the time \w+ is enough
I haven't had the need to not use it
I do believe you that there are variables that it won't match
but \i feels more greedy than \w+
and I don't like being greedy in regex
quaint sapphire
its not "greedier"
It is looking for more candidate matches, or am I wrong?
junior olive
(group is getting overwritten?)
quaint sapphire
(group is getting overwritten?)
Uhh, regex is not meant for sub-patterns like that, or so I believe
You either match the entire thing, or individually the IDs inside
junior olive
guhh
austere talon
It is looking for more candidate matches, or am I wrong?
? it precisely matches Javascript identifiers
your regex matches a subset of javascript identifiers
quaint sapphire
Which is less greedy
austere talon
(group is getting overwritten?)
wrap it in a second group
junior olive
wrap what in a 2nd group
olive aurora
on tetr.io theres a random line of code that uses cjk characters as identifiers
clearly not enough
austere talon
on tetr.io theres a random line of code that uses cjk characters as identifiers
actually we don't include those so even \i doesn't match all identifiers
it matches all normal identifiers
austere talon
Which is less greedy
that makes no sense
that's like saying /a/ is better than /\w/ for text matching cause its less greedy
olive aurora
actually we don't include those so even \i doesn't match all identifiers
its insane cuz the rest of the file is minified normally
osk trolling
quaint sapphire
meanwhile swift allowing variables to be emojis
quaint sapphire
that makes no sense
It matches 100% of the inputs I want
And is more optimal than \i since it ain't as powerful
junior olive
Promise\.all\(\[(?:\i\.\i\((\d+)\),?)+\]\).then\(\i\.bind\(\i,(\d+)\)\)
what do i wrap in a 2nd group 
austere talon
okay keep yapping
olive aurora
no it doesnt because identifier names can change between versions
austere talon
`Promise\.all\(\[(?:\i\.\i\((\d+)\),?)+\]\).then\(\i\.bind\(\i,(\d+)\)\)`
what d...
the part u want
arjix trying not to start prolonged arguments over the most meaningless nothingburger
junior olive
it just captures it again vee
and also that promise.all could have any amt of chunks
so hm
austere talon
the entire body pal
junior olive
so i do need to match a 2nd time?
austere talon
probably
quaint sapphire
I did not start an argument, I merely stated how annoying \i is since it is an unofficial extension
I did not say that \i is worse than \w+, but that \w+ is enough for my needs, and it is more efficient since it ain't as powerful as \i
junior olive
what do we think of this
quaint sapphire
when my regex gets broken bc of that, I'll update it to use \i
junior olive
i'll make the matchAll match the chunk ids
austere talon
match only the body
junior olive
the array?
austere talon
yes
limber skiff
I did not start an argument, I merely stated how annoying `\i` is since it is an...
when 0.1 ms patches aren't efficient ๐ฉ
quaint sapphire
@junior olive can ya give me the link to the module?
my pc is lagging so much that I do not dare open the devtools
junior olive
isTryItOutFlow;
quaint sapphire
the link...
quaint sapphire
thx
out of this, what do you need?
Promise.all([n.e(40532),n.e(29392),n.e(39685),n.e(47007),n.e(79249),n.e(69876),n.e(79913),n.e(19493),n.e(64466),n.e(92465),n.e(10675),n.e(73679),n.e(87440),n.e(73177),n.e(67874)]).then(n.bind(n,788533))]
i'm working on the regex dw
quaint sapphire
only the list?
quaint sapphire
cause you also capture the bind after
junior olive
yes I need the id in there
export default async function extractAndRequireModuleIds(code: Function | string) {
const chunksAndModule = code.toString()
.match(/Promise\.all\(\[((?:\i\.\i\(\d+\),?)+)\]\).then\(\i\.bind\(\i,(\d+)\)\)/);
const chunkIds = Array.from(chunksAndModule?.[1]
.matchAll(/(?:\i\.\i\((\d+)\),?)/)!)
.map(m => parseInt(m[0]));
const moduleId = parseInt(chunksAndModule?.[2]!);
return Promise.all(chunkIds.map(i => wreq.e(i))).then(wreq.bind(wreq, moduleId));
}
time to test this
limber skiff
doesnt the code have more than one chunk load
cuz if it does you should prob put an anchor to just require the one you need
aka SOME_TEXT_BEHIND_WHAT_YOU_NEED.+?<the normal match>
oh
junior olive
I presume the module needs both chunks, and i'm trying to make it generic so i can reuse it (as i already am)
limber skiff
you are making it generic
quaint sapphire
it takes in the function I believe
junior olive
mmmmmm oh boy why is chunksAndModule null
wait is \i available when using regex like this
limber skiff
yes
use the canonicalizeMatch function
it accepts the regex with \i and returns the normal one
junior olive
thanks
quaint sapphire
```ts
export default async function extractAndRequireModuleIds(code: Function | ...
the 2nd regex should be safe to replace with just (\d+)
or \((\d+)\) to not capture the last one as well
ur first regex acts like a guard, so it is safe
charred monolithBOT
junior olive
ok i got it working
export default async function extractAndRequireModuleIds(code: Function | string) {
const chunksAndModule = code.toString()
.match(canonicalizeMatch(/Promise\.all\(\[((?:\i\.\i\(\d+\),?)+)\]\).then\(\i\.bind\(\i,(\d+)\)\)/));
const chunks = chunksAndModule?.[1].matchAll(/(\d+)/g);
const chunkIds = Array.from(chunks ?? []).map(c => parseInt(c[0]!));
const moduleId = parseInt(chunksAndModule?.[2]!);
return Promise.all(chunkIds.map(i => wreq.e(i))).then(wreq.bind(wreq, moduleId));
}
^
junior olive
I don't need that
quaint sapphire
oh yeah
junior olive
I have a capture group for the array contents yeah
quaint sapphire
bre?
spark cove
so we can annihilation that patch
junior olive
still works (very nicely)
spark cove
thing
quaint sapphire
damn you
spark cove
i was explaining it but my brain stopped now i need to shower
quaint sapphire
limber skiff
so we can annihilation that patch
wha
spark cove
eslint patch
limber skiff
oh
spark cove
that allows \i
junior olive
import { canonicalizeMatch } from "@utils/patches";
import { wreq } from "@webpack";
export default async function extractAndRequireModuleIds(code: Function | string) {
const chunksAndModule = code.toString()
.match(canonicalizeMatch(/Promise\.all\(\[((?:\i\.\i\(\d+\),?)+)\]\).then\(\i\.bind\(\i,(\d+)\)\)/));
if (!chunksAndModule) throw new Error("Couldn't extract anything of relevance");
else if (!chunksAndModule[1]) throw new Error("Couldn't extract any chunk requires");
else if (!chunksAndModule[2]) throw new Error("Couldn't extract module ID");
const chunkIds = Array.from(chunksAndModule[1].matchAll(/(\d+)/g)).map(cId => parseInt(cId[0]));
const moduleId = parseInt(chunksAndModule[2]);
return Promise.all(chunkIds.map(i => wreq.e(i))).then(wreq.bind(wreq, moduleId));
}
cleaned it up, i think this turned out very nicely
quaint sapphire
would be nice if we had custom error classes
junior olive
can we not make those?
quaint sapphire
we can
junior olive
or are u saying i should add
quaint sapphire
eh
junior olive
it can be added later
quaint sapphire
more of a "ven should consider it" thing
crude hearth
```ts
import { canonicalizeMatch } from "@utils/patches";
import { wreq } from "...
I have a feeling of that ,in 3 days while reviewing ven will come and say "wt* is this"
quaint sapphire
Hey Turkish lad @crude hearth
crude hearth
hi
crude hearth
normal
crude hearth
I heard ur currency is shit
it is since few years ago
but everyone is kinda getting used to it
limber skiff
```ts
import { canonicalizeMatch } from "@utils/patches";
import { wreq } from "...
make a Logger and use that
quaint sapphire
currency here aint shit, but the local prices are shit
limber skiff
then you can have a title like ModuleLoader idk
junior olive
If ven wants to move this into vencord utils then sure
but rn it's decor plugin util
quaint sapphire
make a Logger and use that
the consumer should still handle them errors, or are you suggeting the logger to be ontop of that?
junior olive
quaint sapphire
maybe add a logger if the error is unhandled
junior olive
https://github.com/Vendicated/Vencord/pull/910/commits/0e2d6bb5912f0bf1969252704...
(commit adding this util)
junior olive
I'm down to move it into a generic util i just don't know if ven wants that
limber skiff
tbh to make it generic we need that anchor thing I said
and have it be optional
in the case it is needed
junior olive
idk what ur talking abt anchor thing
quaint sapphire
tbh to make it generic we need that anchor thing I said
the consumer still needs to find the function that contains the IDs
junior olive
yep
limber skiff
doesnt the code have more than one chunk load
this
quaint sapphire
it doesn't scan all modules
junior olive
we can't really pick and choose what chunks to load
quaint sapphire
doesnt the code have more than one chunk load
hmm
is there an exported function that does that?
limber skiff
a module can have more than one of those
junior olive
it's best just to assume module needs all defined chunk loads
limber skiff
you didnt understand what I mean
limber skiff
the same module can have more than one Promise.all and the rest of the stuff that loads chunks
charred monolithBOT
quaint sapphire
I do understand, but I disagree ๐
limber skiff
in that case the generic function needs a way to select the right one
junior olive
..you find the function to extract a single promise.all load from
the consumer handles getting the func that handles loading a module
quaint sapphire
the same module can have more than one Promise.all and the rest of the stuff tha...
but the module is not what the function accepts !?
limber skiff
oh wait
quaint sapphire
it accepts an exported function
limber skiff
are those always behind a single function
limber skiff
it accepts an exported function
that's not true some chunk loaders arent exported
junior olive
What i've seen is you can find multiple funcs with the same promise.all load
junior olive
that's not true some chunk loaders arent exported
yep
i had to deal with that: https://github.com/Vendicated/Vencord/pull/910/commits/0e2d6bb5912f0bf19692527041d185f0435196c3#diff-b6696714e736bf768510134b07e4ccbddda92680456d724e4746d06fed7fb6fcR94-R130
quaint sapphire
What i've seen is you can find multiple funcs with the same promise.all load
heh
I really wonder how the discord source code actually looks like
wish they shipped the sourcemaps
junior olive
i need to figure out this file input now
limber skiff
I mean behind the scenes it's all normal imports
webpack does the magic of making chunks very likely
quaint sapphire
i need to figure out this file input now <:blobcatcozy:1085109204576112662>
I assume you can re-use discord's component for that, well, dunno where it is
junior olive
quaint sapphire
(by hijacking another one)
junior olive
im looking at src rn to figure out
quaint sapphire
me when it aint loaded 
junior olive
yep!
that's why i have the extract and require
ok yeah it works
i had a typo in a prop lol
quaint sapphire
what does that even mean?
olive aurora
what are they on
limpid badger
Yeah Iโm confused
quaint sapphire
sees issue
says no and closes the issue
doesn't elaborate
charred monolithBOT
limpid badger
Huh
quaint sapphire
aliucord jumpscare
limpid badger
Ahh I just had to open
limpid badger
aliucord jumpscare
Since that fork
charred monolithBOT
quaint sapphire
Since that fork
since what fork?
charred monolithBOT
quaint sapphire
its the purge
quaint sapphire
@austere talon just archive the repo
austere talon
no
limpid badger
Will there be a scoop package for Vesktop? I recently switched from winget to scoop and I am actually more comfortable using it compared to winget
charred monolithBOT
austere talon
Will there be a scoop package for Vesktop? I recently switched from winget to sc...
if you make it
junior olive
Rest in peace ven aliucord plugins
charred monolithBOT
austere talon
the purge is done
quaint sapphire
Will there be a scoop package for Vesktop? I recently switched from winget to sc...
scoop follows the philosophy of only having portable programs, which is nice (there are third party repos with non-portable programs tho)
meanwhile with winget...it updated some programs that I had an older version on purpose, like OpenVPN, that was a pain to debug
limpid badger
scoop follows the philosophy of only having portable programs, which is nice (th...
Tbh It kind of fits me since Iโm that man who always prefer portable programs than non-portable
limpid badger
meanwhile with winget...it updated some programs that I had an older version on ...
Fr
quaint sapphire
Tbh It kind of fits me since Iโm that man who always prefer portable programs th...
it also doesn't pollute ur PATH, since it adds shims
I learnt that the PATH has a length limit the hard way
hazy kindle
whar?
as shown in that ss, rn every plugin has a list of contributors.
i was talking about adding the reverse: Every contributorโs profile having a list of their plugins
hazy kindle
i often pop up peopleโs profiles (contributors or not). With this feature, i would prbly open contributorโs profiles all the time until ik their plugins by heart lol
quaint sapphire
as shown in that ss, rn every plugin has a list of contributors.
i was talking a...
I'd rather prefer a search filter in the plugins page to filter by author
Would be less intrusive and a more obvious place to have it
hazy kindle
what would you use it for?
hazy kindle
for my use case that would be way too much effort
(i think)
opening settings is slow on my pc
quaint sapphire
Effort to use or code?
hazy kindle
use
hazy kindle
plus the typing and whatnot. Vs. literally a single click
quaint sapphire
Maybe you can add a "Show all plugins made by this user" button that opens the settings page with the filter enabled
hazy kindle
yeah, that would be a good compromise
a nice thing about the search filter would be that you could also use it to look up colabs, e.g. which plugins did ven and lewi do together? โ author:ven author:lewi
quaint sapphire
It's just that plugins don't have a logo or smth, so it would be kinda empty to have them in the profile modal
Plus you may want to enable a plugin by that user, but doing that from the profile modal feels off
quaint sapphire
a nice thing about the search filter would be that you could also use it to look...
Yee
quaint sapphire
If you make a search component that supports that I'll 100% steal it for another plugin I am too lazy to complete
hazy kindle
Plus you may want to enable a plugin by that user, but doing that from the profi...
lol yeah, hadnโt thought of that, i still like that idea tho haha, but maybe too odd for mainstream yeah
hazy kindle
It's just that plugins don't have a logo or smth, so it would be kinda empty to ...
not sure wym by empty. Do you mean dry? With only the plugin names
if anything ig it could be too full/cluttered, imagine venโs profile haha
but imho that would be ok if itโs at the bottom, like the ReviewDB reviews may-they-rest-in-peace
quaint sapphire
Maybe you can add a "Show all plugins made by this user" button that opens the s...
I think making the button similar to the "join vc" button (well, it is the VC name) would be nice
austere talon
i feel like having an extra tab might feel a little crammed, especially if you also have mutual groups
so we could make the vencord contrib badge open ur page on click
austere talon
i feel like having an extra tab might feel a little crammed, especially if you a...
already crammed enough
quaint sapphire
@austere talon can I get teal role back ๐
jagged cloak
Aktivitat
quaint sapphire
Using discord with a local locale?
hazy kindle
already crammed enough
yeah i feel ya
quaint sapphire
Using discord with a local locale?
Ven is wild
hazy kindle
i was thinking server profile anyway (1 click instead of 2) (also like reviewdb)
hazy kindle
so we could make the vencord contrib badge open ur page on click
that would be sensible, and fine for me, but maybe a waste of implementation effort, as few ppl would prbly guess that function (unless thereโs a hint)
side note, not all contribers have the badge
example: @fleet depot
quaint sapphire
lots use not english
Ig I am too used to exclusively using English in anything tech related
austere talon
side note, not all contribers have the badge
example: <@364536918362554368>
because they havent made any plugins
hazy kindle
why do they have the role then?
austere talon
because they're a contributor?
quaint sapphire
They could have contributed to the core of vencord
austere talon
not every contribution is a plugin
junior olive
i don't have contributor
hazy kindle
makes sense
junior olive
hazy kindle
i don't have contributor
then what are you even doing with your life!
quaint sapphire
Most of my contributions were not in plugins funnily enough
austere talon
for simplicity purposes, vencord considers anyone a contributor who's listed in Devs
so if you never add yourself there, you're not considered a contributor
austere talon
you have to beg
jagged cloak
get on ur hands and knees
hazy kindle
ayy congrats epic contributor @junior olive ๐ฆพ
junior olive
VENNY VENCORD I AM ON MY HANDS AND KNEES BEGGING YOU PLEASE GIVE ME contributor (epic) ROLE IN THE VENCORD SERVER I WILL OWE YOU ALL MY LIFE
quaint sapphire
@austere talon plz gib the teal role ๐ญ
junior olive
thank u venny vencord
jagged cloak
u are bambik
hazy kindle
bambik
junior olive
gentlemen, one at a time single file line please
quaint sapphire
I was never banned from the server, I foolishly left it on my own
hazy kindle
oh, contriber profiles might also be good, plausibly even more priority, on vencord.dev โ then the devs can link that in their portfolios
austere talon
gentlemen, one at a time single file line please
hot
quaint sapphire
gentlemen, one at a time single file line please
Time to use my steam decors
junior olive
fr
jagged cloak
i will upload troller.txt as decor
Hm, it looks like that file might've been a virus. Instead of cooking up trouble, try cooking up a Beet-Pickled Deviled Eggs: https://www.thekitchn.com/recipe-beet-pickled-deviled-eggs-151550
for example its the eicar text
quaint sapphire
@junior olive might wanna look at steam's avatar decorations
If it's possible to have them stolen then it would be nice to include them as built-in or smth
junior olive
<@890228870559698955> might wanna look at steam's avatar decorations
If it's po...
I've been using them for testing
I don't think I really want to include them built in because tbh they don't work very well due to being square
austere talon
does steam let u just download them
quaint sapphire
I've been using them for testing
AvatarDecorRepo when?
junior olive
yeah from the site
austere talon
I don't think I really want to include them built in because tbh they don't work...
(also licensing issues)
junior olive
(also licensing issues)
that too
quaint sapphire
(also licensing issues)
Scraping at runtime for the win
austere talon
will everyone have to upload their own decor or will there be a way to browse all already uploaded decors and pick any of them
the latter would be neat
junior olive
upload your own, but there's gonna be preset sets that u can pick from (and in the future I may add the ability to pick from a list of public ones made public by their creators)
quaint sapphire
@austere talon ven listening to not cute music? (I don't know the song)
austere talon
maybe make it so that when you upload a decor, there's a checkbox make public | this will allow anyone to find and use your decoration and if you check it you need to enter a description / tags
junior olive
Yeah that'll be a a down the line update
austere talon
maybe make it so that when you upload a decor, there's a checkbox `make public |...
and then you could either have a website or in client where you can browse all public decors and search by description/tag
that'd be neat
junior olive
For now decorations will be private with the exception of presets (hoping to have a community pack at launch via collaboration with a artist in the client modding community)
junior olive
and then you could either have a website or in client where you can browse all p...
in client ๐ช
yeah ven that sounds good but I'm gonna worry about that down the line
a future feature
austere talon
yop
hazy kindle
into a bright feature future
austere talon
<@343383572805058560> ven listening to not cute music? (I don't know the song)
black metal
woeful sable
and then you could either have a website or in client where you can browse all p...
upvote
still wanting shiggy decor
austere talon
black metal
listen to this tho it's very pretty
junior olive
still wanting shiggy decor
make transparent ill use for testing
woeful sable
on ios canโt
hazy kindle
listen to this tho it's very pretty
i was promised black metal and what is this
austere talon
ios L
woeful sable
fr
hazy kindle
i rest my case
austere talon
its just the intro to the album
junior olive
vennnn why is formdata broken
hazy kindle
a
austere talon
i was promised black metal and what is this
album stream
their label uploaded it super weird, they combine two songs into one video instead of either having one video per song or one video for the entire album
hazy kindle
๐ a little satanism in the evening never hurt anybody
junior olive
What the fuckk
austere talon
๐ a little satanism in the evening never hurt anybody
they're not actually
austere talon
vennnn why is formdata broken
fixx
woeful sable
@austere talon
austere talon
yes
hazy kindle
they're not actually
(ah ig i jumped to conclusions from Anrufung and Teufel in the same line)
hazy kindle
oh thatโs the double song upload
woeful sable
it could be like the server @dusk hill has where you request a badge and mods have to approve or is that what your going for
still then youโd need dedicated staff
dusk hill
UserEffects soon
junior olive
it could be like the server <@347096063569559553> has where you request a badge ...
that's what i have lol
junior olive
UserEffects soon
decor feature eventually
woeful sable
how would that even be implemented unless you have template
dusk hill
im having a essential chrisis rn
dusk hill
junior olive
are u doing custom profile effects or
dusk hill
custom profile effects
junior olive
bc i was hoping to add that to decor in the future
dusk hill
oof
woeful sable
canโt wait to see the atrocities people make
dusk hill
ong
i cant seem to be able to actually set this up
i can set the ones discord already has but the ones i added ๐ค
junior olive
fixed the flow
toxic bough
UserEffects soon
What is that!?!?
dusk hill
a effect
charred monolithBOT
toxic bough
I hope someone makes a free profile effect / avatar decoration plugin.
That'd be nice
junior olive
yeah decor has profile effects on the to-do
we rlly shouldnt have 2 competing effect plugin
toxic bough
Ooo
dusk hill
we rlly shouldnt have 2 competing effect plugin
yeah
woeful sable
fixed the flow
would it not be better it request via server bot first than to do that
dusk hill
but the one im working on is on replugged
junior olive
would it not be better it request via server bot first than to do that
wym
woeful sable
sorry autocorrect
junior olive
I think it makes sense
woeful sable
like go to the server, request decor, wait for approval then enable via plugin
junior olive
user creates from their client -> request goes to private channel - > request is approved -> it becomes their active decoration
junior olive
like go to the server, request decor, wait for approval then enable via plugin
requesting via a discord server is icky
woeful sable
mmm true
at least when a users decor has been approved could it show a message at the top of the client saying it has been approved
example, when a user has been removed from a. guild the green bar shows
or maybe a popup message
iโll show in a second
junior olive
at least when a users decor has been approved could it show a message at the top...
Maybe but that'd require a considerable amount more code
woeful sable
i suppose
charred monolithBOT
woeful sable
junior olive
yeah that'd be neat
@austere talon does vencord have apis to make a banner like that
woeful sable
check the โrelationship notifierโ plugin
lime stone
meanwhile swift allowing variables to be emojis
why do we live in a world where swift allows variables to be emojis but discord doesn't allow captital letters in usernames
charred monolithBOT
half notch
i hope this free decos plugin doesnt get stuck in PR hell 
junior olive
@austere talon do you think you could start reviewing it? The only missing feature is presets and I'd rather start squashing review notes
actually hmmmmmm
maybe i should fix decor updates
a start on reviewing it would be nice
there's only 2 more things
presets and switching fetching decorations for other users to timezonedb-style
austere talon
@topaz thistle would you like me to just publish 1.0.0 to npm?
limpid badger
i hope this free decos plugin doesnt get stuck in PR hell <:Prayge:1037913642143...
and i'm still waiting for channel tabs 
austere talon
it's still not finished, is it?
you can just use a devbuild until it's ready / eventually merged
limpid badger
i mean it seems fine
topaz thistle
<@349609234985517057> would you like me to just publish 1.0.0 to npm?
Yep
austere talon
alright
so, new PatchBay() throws if no pipewire right
is everything lazily initialised once i call the constructor for the first time, or should i lazy import the entire module?
topaz thistle
so, new PatchBay() throws if no pipewire right
Yes
topaz thistle
is everything lazily initialised once i call the constructor for the first time,...
The first
austere talon
so simply importing the module won't initialise a bunch of pipewire stuff?
topaz thistle
Yes
austere talon
neat
how do i figure out the discord webrtc stream name
is it always the same?
it seems to just be "Chromium"
topaz thistle
I think discords voice chat output is always WEBRTC something
The chromium thing is only notification sounds
topaz thistle
i set it to chromium
As include?
midnight raven
yeah
topaz thistle
Hm can you run pw-cli ls Node
topaz thistle
I guess 90 is discord here, what does pw-dump 90 print?
midnight raven
a lot jeez
topaz thistle
Yeah I know
midnight raven
topaz thistle
Ah
Two things
It should work with the official discord client as that usually has WEBRTC as the voice chat audio
I can give you the application name and Id in list
Would that help?
midnight raven
yeah i have confirmed that link("Chromium", "exclude") works for system audio and doesn't include discord
topaz thistle
I can give you the application name and Id in `list`
Can you check if the process Id that pipewire has is the same as the one of Vesktop?
topaz thistle
Eh
Wait
Yes
Could very well be a subprocess considering it's chrome
If so can you figure out if that process belongs to Vekstop?
midnight raven
well i restarted discord so it changed but
vee 25666 3.6 0.4 34235080 68176 pts/0 Sl+ 01:50 0:10 /home/vee/Coding/Vesktop/node_modules/electron/dist/electron --type=utility --utility-sub-type=audio.mojom.AudioService --lang=en-GB --service-sandbox-type=none --enable-crash-reporter=5202b306-7f8e-4b0e-9759-5b4adec4e909,no_channel --user-data-dir=/home/vee/.config/VencordDesktop --shared-files=v8_context_snapshot_data:100 --field-trial-handle=0,i,10662465288986271862,12928842484402543385,262144 --enable-features=WaylandWindowDecorations --disable-features=HardwareMediaKeyHandling,MediaSessionService,SpareRendererForSitePerProcess,WidgetLayering,WinRetrieveSuggestionsOnlyOnDemand
this is the one
i think
that is
id 68, type PipeWire:Interface:Node/3
object.serial = "772"
factory.id = "6"
client.id = "82"
client.api = "pipewire-pulse"
application.name = "Chromium"
node.name = "Chromium"
media.class = "Stream/Output/Audio"
Does the process Id from pw-dump match?
midnight raven
yes
"props": {
"adapt.follower.spa-node": "",
"application.icon-name": "chromium-browser",
"application.language": "en_GB.UTF-8",
"application.name": "Chromium",
"application.process.binary": "electron",
"application.process.host": "vendingmachine",
"application.process.id": 25666,
"application.process.machine-id": "3f7a4b6efc23421cbc2744660539dc57",
"application.process.user": "vee",
"audio.adapt.follower": "",
"client.api": "pipewire-pulse",
"client.id": 82,
"clock.quantum-limit": 8192,
"factory.id": 6,
"factory.mode": "split",
"library.name": "audioconvert/libspa-audioconvert",
"media.class": "Stream/Output/Audio",
"media.name": "Playback",
"node.autoconnect": true,
"node.latency": "512/48000",
"node.name": "Chromium",
"node.rate": "1/48000",
"node.want-driver": true,
"object.id": 68,
"object.register": false,
"object.serial": 772,
"pulse.attr.maxlength": 4194304,
"pulse.attr.minreq": 2048,
"pulse.attr.prebuf": 6152,
"pulse.attr.tlength": 8192,
"pulse.server.type": "unix",
"stream.is-live": true,
"window.x11.display": ":0"
},
If so I can push an update tomorrow that will also give you the process Id when calling list
Nice
Do you need just the process Id or do you want to have the application name as well?
midnight raven
If so I can push an update tomorrow that will also give you the process Id when ...
and link will also take process id?
topaz thistle
I can add support for that yeah
midnight raven
also perhaps the app name might change if packaged, keep in mind i'm running via electron directly
topaz thistle
So just process Id then right?
I'll go to sleep now but if you don't have any objections I'll make list Return both node name as well as process Id and allow link to take an id as well
You may want to test if the process Id approach would work for the official discord client as well
midnight raven
ohh i see
topaz thistle
It has "WEBRTC <something>" as the node name when in voice chat
midnight raven
"props": {
"adapt.follower.spa-node": "",
"application.icon-name": "chromium-browser",
"application.language": "en_GB.UTF-8",
"application.name": "Chromium",
"application.process.binary": "vencorddesktop",
"application.process.host": "vendingmachine",
"application.process.id": 27450,
"application.process.machine-id": "3f7a4b6efc23421cbc2744660539dc57",
"application.process.user": "vee",
"audio.adapt.follower": "",
"client.api": "pipewire-pulse",
"client.id": 70,
"clock.quantum-limit": 8192,
"factory.id": 6,
"factory.mode": "split",
"library.name": "audioconvert/libspa-audioconvert",
"media.class": "Stream/Output/Audio",
"media.name": "Playback",
"node.autoconnect": true,
"node.latency": "512/48000",
"node.name": "Chromium",
"node.rate": "1/48000",
"node.want-driver": true,
"object.id": 65,
"object.register": false,
"object.serial": 872,
"pulse.attr.maxlength": 4194304,
"pulse.attr.minreq": 2048,
"pulse.attr.prebuf": 6152,
"pulse.attr.tlength": 8192,
"pulse.server.type": "unix",
"stream.is-live": true,
"window.x11.display": ":0"
}
note application.process.binary
this is when packaged
topaz thistle
Yeah I know, it was previously electron that's why I thought it wasn't too applicable
But we can also use that
Whatever you prefer
midnight raven
it's only electron when running directly without packaging
i think it's fine to have it semi broken when running unpackaged considering that's only for development
topaz thistle
Alright so we'll go with the binary prop then?
If so we'd have to figure out how to tell link wether or not you gave it a binary or node name
midnight raven
so some options:
- allow excluding by application.process.binary
- allow linking by id and return id, application.name and application.process.binary in list()
topaz thistle
so some options:
- allow excluding by application.process.binary
- allow linking...
I think the latter approach would be nice
midnight raven
alright, that works
i might just try to add it myself real quick, it should probably be pretty easy
midnight raven
really? would it not just be editing the place where it creates the object array and changing that to an object then adding those additional props?
ig you might pass some of these across different functions
topaz thistle
Should we change the signature of link to
link(target: { name: string } | { id: number}. , mode: ...) or something along those lines?