#👾-core-development
charred monolithBOT
glass cedar
cunning bobcat
manti
jagged cloak
semantic
charred monolithBOT
austere talon
we could also add snippets and stuff to it
austere talon
OKAY
austere talon
okay iwill stop spamming commits now
u love
You can now install the Vencord vscode extension from https://marketplace.visualstudio.com/items?itemName=Vendicated.vencord-companion which is basically PatchHelper but inside vscode
It adds "Test Find" on any webpack finds that will test whether your filter finds exactly one module (and not more or none)
It adds "Test Patch" on any patches you define in definePlugin() that will test that your find is unique and your match and replace works and compiles correctly
To use it you also need to compile Vencord with DEV (aka pnpm build --watch or pnpm buildWeb --watch) and enable the "DevCompanion" plugin. Then just start Discord after vscode (or right click the user settings cog and click "Reconnect Dev Companion")
charred monolithBOT
quick ibex
more spam commits
austere talon
im done now 
charred monolithBOT
spark cove
@austere talon im looking at companion
this is kinda sick
typescript parsing is build into vscode so its really easy to do
also typescript's builtin typeguards are so epic
hazy kindle
this is kinda sick
is that vsc?
spark cove
no thats github
i was saying that the code there is cool and concise for how much it does with the AST
hazy kindle
this is kinda sick
i love
spark cove
yea real
hazy kindle
yooo what you can click any symbol to get listed all the places it’s referenced. Proper IDE shizzle! Very epic!!
charred monolithBOT
charred monolithBOT
hazy kindle
^ that’sa me
austere talon
typescript parsing is build into vscode so its really easy to do
?
you're telling me I don't need to use typescript dependency?
I tried to mark typescript dependency as external but it didn't work
austere talon
maybe it is a thing idk
didn't find anything tho
but I think if we do this we can't add vscode stuff
cause its running entirely in typescript context
spark cove
yea fair
austere talon
mmmn but then you have to somehow make the typescript plugin have like 0 access to vscode and somehow return data via for example diagnostics
tawny cipher
charred monolithBOT
verbal pumice
unborn garnet
charred monolithBOT
charred monolithBOT
charred monolithBOT
I literally could've just added a "Hide album art if empty" toggle. Apparently nobody felt the desire to work with me to get it done.
It would be nice to have the ability to rotate server count in ServerListIndicators plugin's options, so it would work with Horizontal Server List
Right now it looks like this:
I brought it up several times and asked you to make it configurable. If you're just gonna ignore that and refuse to collaborate, then that's your fault, nothing I can do
woeful sable
😭
charred monolithBOT
Discord Account
No response
What happens when the bug or crash occurs?
Hidden blocked messages still trigger the unread messages indicator (red line/highlighted channel name), even with the "Completely ignores (recent) incoming messages from blocked users (locally)."-Setting enabled.
What is the expected behaviour?
Don't show the unread message indicator if th...
charred monolithBOT
An additional option for platform indicators to show an active platform inside/instead of the user status icon, discord already does this for mobile, so why not do it for other platforms too?
what I imagine this would look like instead:
this however would only be able ...
charred monolithBOT
Discord Account
woliver99#6280
What happens when the bug or crash occurs?
Message logger shows edited messages by me and bots while I have them disabled in the settings
What is the expected behaviour?
It should hide messages from me and bots that were ed...
charred monolithBOT
austere talon
what if we added two new functions to the plugin definition schema:
snapshot(): string;
restore(snapshot: string): void;
the use case is that any data store in DataStore isn't backed up but might be desired for plugins like custom tags and similar that store user data there. The snapshot function should return a json string of the data the plugin has stored, restore gets that json back later to restore settings. this way we could include more stuff in settings backups
this will only be necessary for plugins that use DataStore or other ways of persisting data and is not necessary for plugins that just use settings
turbid hatch
how'd it interact with cloud settings?
its definitely a nice idea nonetheless
@austere talon
austere talon
Well that should also be included
turbid hatch
cause it just uses the settings export as if you were backing up settings i suppose it works without any changes
so i suppose there's not really any extra development effort needed to get them to sync across clients which is nice
charred monolithBOT
lime stone
charred monolithBOT
charred monolithBOT
We can just add an edge case though, and get the guild_id this way
umbral hedge
❓
umbral hedge
hmmm
limber skiff
@austere talon please review https://github.com/Vendicated/Vencord/pull/587 🙏
umbral hedge
I feel like game activity toggle should be combined with ignoreactivities 
since they kinda conflict
limber skiff
not really
umbral hedge
?
this seems like game activity toggle with some extra steps (having to go in settings)
limber skiff
game activity toggle is to add a shortcut to a discord setting
ignore activities is totally different, it lets you select which activities to ignore
charred monolithBOT
spark cove
what if we added two new functions to the plugin definition schema:
```ts
snaps...
im back into coding feels again
maybe i should pr this along with good typings for DataStore
charred monolithBOT
charred monolithBOT
Description: Allows you to perform multiple actions on an entire channel (move, mute, disconnect, etc.)
austere talon
that pr is interesting
webpack search inside functions, manually sending requests etc T_T
i will tell u how to fix tmrw
spark cove
i will tell u how to fix tmrw
you will leave the three semicolons at the end
also can i hop on ow
spark cove
I hopped off
F
charred monolithBOT
charred monolithBOT
charred monolithBOT
Use discussions please. This has also already been suggested multiple times
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
turbid hatch
oh wait
i could use a function here couldn't i
then just conditionally apply the .id if it's a channelId prop rather than a channel prop
jagged cloak
I always forget to build
limber skiff
le typo
charred monolithBOT
turbid hatch
oh i guess it was changed on stable finally
charred monolithBOT
limber skiff
charred monolithBOT
charred monolithBOT
Title says all, something like this:
woeful sable
volume above 100% is desktop only feature
it did work tho i was literally using it in the browser yesterday
limber skiff
@austere talon what do you think of this? https://github.com/Vendicated/Vencord/pull/568/commits/0817ffc9f0ea224a5b630d03e576ce40f9f65b26
charred monolithBOT
zinc dock
it did work tho i was literally using it in the browser yesterday
yup i even tested with a music bot to make sure and it does work
zinc dock
#1015408930060501033 message if youre talking about this person, maybe its cuz they were using it on armcord idk
charred monolithBOT
charred monolithBOT
austere talon
@limber skiff
for some reason this took like 5 seconds to load commits and branches
austere talon
see how long it takes
limber skiff
oh my
austere talon
literally 10 seconds
austere talon
its because i have many remotes added
is git fetch necessary?
maybe without the --all?
without --all it only takes 1 second
@limber skiff
austere talon
yes it takes long
just remove -all
so it only uses origin
unless theres a good reason to use all?
austere talon
maybe instead of the disabled select we can instead have some sort of loading indicator
or change "dev-branch" to "loading branches..."
limber skiff
it's very fast for me
austere talon
yes because you only have one remote
limber skiff
yeah
austere talon
as i said why not just
- git fetch --all
+ git fetch
--all
Fetch all remotes.
limber skiff
faster cuz I'm on mobile
austere talon
i dont see a need to fetch anything but origin?
limber skiff
ya ya it's fine
austere talon
ok done
ye now its relatively fast
git ls-remote is slow too tho
so getting commit info also kinda slow mm
limber skiff
that one should be kept tho
austere talon
ye
limber skiff
also can you try to find what's wrong with the publish workflow
the heck is that font
austere talon
???
limber skiff
lmao what
limber skiff
okay that's doable
austere talon
???
WAIT I KNOW
basically
those files were renamed in case
to give all files consistent case
but those branches have the old names
but windows has a case insensitive file system so if i checked that old branch out there's now a conflict
and one of them will get lost
limber skiff
so dumb
austere talon
- notification close button is brokey
- the dropdown goes next line when you change it
??? why does only dev-branch stay in the same line
limber skiff
1) notification close button is brokey
2) the dropdown goes next line when you c...
cuz you switched to a branch with old css
lol
austere talon
ye but
it doesnt reload the css does it
oh wait it does lmfao
ok fair enough
youre right yeah
thats so hilarious
i forgot devbuilds have css watcher
limber skiff
ye
austere talon
i think the fact that switching branches makes the ui seemingly freeze for a few seconds is bad UX
maybe some sort of loading animation would be nice
does discord have any?
I'm thinking of some modal with spinner
and is a standalone install less slow
cause worse UX only in dev build is whatever ig
limber skiff
we will steal typing indicator
limber skiff
and is a standalone install less slow
nope, it's probably slower actually
austere talon
why
limber skiff
cuz it downloads new files
austere talon
Vencord Updater 404: Not Found - https://api.github.com/repos/Vendicated/Vencord/compare/c53ce1b...latest-release
austere talon
what is that supposed to be
austere talon
not a real branch just use git tags
limber skiff
hmmm
the logic I was doing was: for git install we will have main branch and latest-release
limber skiff
main will be for dev, latest-release for stable updates
austere talon
https://api.github.com/repos/Vendicated/Vencord/compare/v1.0.4...v1.0.6
this works
limber skiff
then for standalone we will have main which will be devbuild, and tags
austere talon
main will be for dev, latest-release for stable updates
latest-release isn't needed
limber skiff
oh
austere talon
as I said use tags
gusty axle
uhhh im pretty sure this isnt normal
limber skiff
no?
austere talon
for which you can just use github api
limber skiff
I want to have a stable branch for git install too
austere talon
uhhh im pretty sure this isnt normal
don't use npm it sucks ass
austere talon
I want to have a stable branch for git install too
why
gusty axle
use yarn?
austere talon
just make them use main branch
limber skiff
cuz personally I use git for all my installs, but I want to use the stable branch for one of my clients
gusty axle
oh im stupid didnt see it
thanks
also just making sure, that i have to recompile every time i want to try/test my new plugin?
austere talon
anyway you can just use git describe to get the latest tag @limber skiff
austere talon
also just making sure, that i have to recompile every time i want to try/test my...
yes but you can just use the watch mode, again read documentation
gusty axle
i guess the other issue is im compiling in WSL2
but im on windows discord install
so i need to manually copy over the patched files
austere talon
try git describe --abbrev=0
limber skiff
this is the latest
limber skiff
oh
gusty axle
u need to do a git fetch remote with tags? if you're working off your own fork
austere talon
git describe --tags $(git rev-list --tags --max-count=1)
@limber skiff try this
or just
git tag --sort=committerdate
and then get the last line
limber skiff
or just
```sh
git tag --sort=committerdate
```
this is nice
@austere talon can you help with the workflow error
gusty axle
im looking at the messageAPI and it looks like it only gets the message contents. Is there a way to get the rest of the message metadata? user name and their nickname? im trying to get it so that people's nicknames are appended to their actual name in brackets
charred monolithBOT
limber skiff
im looking at the messageAPI and it looks like it only gets the message contents...
messagesAPI is for sending and editing messages only
austere talon
https://github.com/Vendicated/Vencord/actions/runs/4452328192
likely indent related
yaml is like python and requires consistent indentation
theres literal errors xd
limber skiff
it's automatic
or maybe not
I think it was just creating an action cuz it had error
no action so no error
austere talon
i dont like that this is copy pasted 3 times
limber skiff
lol
austere talon
why not make that its own job and make the other jobs depend on its success
limber skiff
true
austere talon
needs
you can move all the duplicated setup to a separate job
then use needs
i can do that rn
limber skiff
dang that was quick
limber skiff
ye
austere talon
just copy paste the part into a new job, remove it from 3 other places and copy paste needs: setup 3 times xd
gusty axle
messagesAPI is for sending and editing messages only
is there a way to replace all usernames everywhere that is in a guild (server)? 🤔 to append nickname? im currently looking at the message api...
limber skiff
latest-release will be a fake branch that points to the latest tag
limber skiff
is there a way to replace all usernames everywhere that is in a guild (server)? ...
sorry cant help you rn
austere talon
is there a way to replace all usernames everywhere that is in a guild (server)? ...
many ways to do so
gusty axle
many ways to do so
im having a look and i dont see any obvious libraries to do that
austere talon
- patch the component that renders usernames
- patch GuildMemberStore.getNick
- patch whatever else may be relevant
gusty axle
quite hard becasue i cant find any documentation :')
on any of the libraries/functions to use
austere talon
because there is none
you're working with minified proprietary code
@turbid hatch im testing your cloud sync rn (sorry for taking a bit)
i was really confused by this
gusty axle
because there is none
ah ok :')
austere talon
i think everything but the enable cloud button should be hidden when it's off
or at least in some other way it should be more erm idk good word
i think the confusing part to me was that there's a Deauthorize button when i never authorised in the first place
the 3 buttons bit also looks strange, i think making the buttons all take 33% width (don't actually, use display grid) would look nicer
i think removing this permission isn't possible while still getting the id? if so, thats okay, otherwise maybe remove it
austere talon
i think everything but the enable cloud button should be hidden when it's off
maybe only show Deauthorize if you have it enabled & authorised
turbid hatch
<@96269247411400704> im testing your cloud sync rn (sorry for taking a bit)
no worries
turbid hatch
i think removing this permission isn't possible while still getting the id? if s...
unfortunately not :<
turbid hatch
i think everything but the enable cloud button should be hidden when it's off
oh hidden?
i can do that yeah
i thought disabling would've been the better UX but if hiding is a better choice i can do that
austere talon
well maybe not everything
but at least the deauth button shouldnt be shown imo
and it made me think the backend url is also disabled
turbid hatch
thats fair
i wanted to avoid reflows though because reflows yucky bad UX bad bad
hmm..
ill see what i can do with that
austere talon
thats true i agree
turbid hatch
the 3 buttons bit also looks strange, i think making the buttons all take 33% wi...
yeah i was actually going to have 4 and then realised it was redundant
austere talon
but i still think the button being there is confusing
is there even any reason we need a deauthorize button?
why not just make disabling it deauthorize
austere talon
~~me~~
for testing purposes
but once its in prod i dont think anyone will toggle it many times xd
and the oauth flow is really smooth
turbid hatch
austere talon
TREUE
turbid hatch
alright lets see here
turbid hatch
and the oauth flow is really smooth
🙏
i spent a lot of time trying to make it right without it allowing you to do stupid shit in the meantime
austere talon
i think "enable cloud integration" sounds kinda weird but i get what youre trying to do (be extensible for more future cloud features)
turbid hatch
ye
austere talon
maybe add a paragraph that explains the entire thing first
turbid hatch
i wasnt quite sure how to word it, i actually wanted your input on it
gusty axle
- patch the component that renders usernames
- patch GuildMemberStore.getNick
- ...
having a look at the patch guildmemberstore.getnick because the other 2 seem annoying for now. is patching getnick needed because it looks like its only being used by the vencord plugins?
austere talon
"Vencord comes with a cloud integration that adds goodies like settings sync across devices. It respects your privacy and you can even selfhost it!"
something like that perhaps
and maybe also add a link to https://vencord.vendicated.dev and that page will then have more info
(i kind of want to get vencord.dev but i also don't want to waste 10 bucks on it)
austere talon
having a look at the patch guildmemberstore.getnick because the other 2 seem ann...
search for just .getNick
Discord's code is minified so their variable will be called something like pz not GuildMemberStore
turbid hatch
(i kind of want to get vencord.dev but i also don't want to waste 10 bucks on it...
i'll buy it if you want
idm
austere talon
nono
then i'd be wasting your 10 bucks which isn't any better :P
i think vencord.vendicated.dev is fine?
turbid hatch
"Vencord comes with a cloud integration that adds goodies like settings sync acr...
should respects your privacy be a link to the WIP privacy page?
austere talon
sure
frail skyBOT
turbid hatch
i think vencord.vendicated.dev is fine?
its fine for now ye
austere talon
hi vencord reporter
turbid hatch
if we ever want to do a proper website though we might wanna get a domain for it
gusty axle
Discord's code is minified so their variable will be called something like pz no...
ah ok thank you
austere talon
let's also design a basic landing page maybe? We could maybe even make a general purpose Vencord site similar to https://replugged.dev
austere talon
ye
turbid hatch
hot
austere talon
u can use Vencord's Link component
i dont remember what it does but its a small wrapper around a
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/main/src/components/Link.tsx#L25-L36
**Link.tsx: **Lines 25-36
export function Link(props: React.PropsWithChildren<Props>) {
if (props.disabled) {
props.style ??= {};
props.style.pointerEvents = "none";
props["aria-disabled"] = true;
}
return (
<a role="link" target="_blank" {...props}>
{props.children}
</a>
);
}
ah
turbid hatch
ah i'll use that
frail skyBOT
turbid hatch
that looks better
<Forms.FormText variant="text-md/normal" className={Margins.bottom20}>
Vencord comes with a cloud integration that adds goodies like settings sync across devices. It
<Link href="https://vencord.vendicated.dev/privacy">respects your privacy</Link> and you can even
<Link href="https://github.com/Vencord/Backend">selfhost it</Link>!
</Forms.FormText>
something like that i guess xd
austere talon
i love the insanity that is react typing https://github.com/Vendicated/Vencord/blob/main/src/components/Link.tsx#L21
grave mangoBOT
i love the insanity that is react typing https://github.com/Vendicated/Vencord/b...
**Link.tsx: **Line 21
interface Props extends React.DetailedHTMLProps<React.AnchorHTMLAttributes<HTMLAnchorElement>, HTMLAnchorElement> {
me when extends React.DetailedHTMLProps<React.AnchorHTMLAttributes<HTMLAnchorElement>, HTMLAnchorElement>
austere talon
actually i think there's a shortcut for that but whatever
btw maybe add instructions here xd
austere talon
btw forget about having html file in the backend
I would probably make a dedicated repo for website and make it with astro
and the backend would only cover /api
austere talon
and maybe we can make https://vencord.vendicated.dev/api/v1 redirect you to the vencord home page
turbid hatch
ah got it
austere talon
still versioning?
yeah yeah i still think versioning is a good idea
turbid hatch
ye i see what you mean
alr let me do tihs
so the deauth button is gone and i've added that description with the links
austere talon
haha no rush we first gotta make homepage
austere talon
i would just make it a pretty simple site with
- / just as landing page describing vencord a bit and having installation instructions
- /plugins being a list of all plugins. Perhaps we could add images but that'd be effort
- /cloud being the cloud landing page with basic info
- /privacy privacy policy for the cloud
smth like that
i think Astro is best for that
austere talon
i would just make it a pretty simple site with
- / just as landing page describi...
perhaps we could also make something like https://replugged.dev/contributors
turbid hatch
yeah definitely
we could serve badges over the API like that too if we wanted, though maybe just donators
austere talon
pick your fighter
turbid hatch
anyone but db
polar abyss
devilbro ain't got shi on anyone
austere talon
i would just make it a pretty simple site with
- / just as landing page describi...
AND DOCS
how could i forget
markdown mdx go brrrr
then we can yeet docs from github
austere talon
perhaps we could also make something like https://replugged.dev/contributors
we could have their plugins similar to here
turbid hatch
ah and then also add previews?
austere talon
image previews for plugin would be cool tbh
swift fjord
perhaps we could also make something like https://replugged.dev/contributors
im on that page
love
austere talon
but oh god i do not want to take 100 screenshots
turbid hatch
make the devs do it
austere talon
WHY DONT I HAVE PFP
turbid hatch
swift fjord
don't know why they don't use the gh api for that page though
austere talon
lol what did u do
austere talon
lmao
just use repeat
grid-template-columns: repeat(3, 1fr);
i think it works like this
turbid hatch
.vc-cloud-settings-sync-grid {
display: grid;
grid-template-columns: repeat(3, 1fr);
grid-gap: 1em;
}
turbid hatch
it does
turbid hatch
cuz i had it as
1fr 1fr 1fr
and then as yuo were telling me to convert it
i had already converted it
xd
fiery jungle
<@295190422244950017> who will win
HORROR
turbid hatch
pushed the grid
swift fjord
i think they mostly use the username route
polar abyss
we could have their plugins similar to here
https://www.youtube.com/watch?v=htGfnF1zN4g yoink this hover effect for it, it look good 
It serves no purpose but it look good
austere talon
just steal vercel site
polar abyss
just steal vercel site
or that
swift fjord
i think they mostly use the username route
docs only show the username one
austere talon
vercel site is seggs but at the same time i think its a bit too dark
it looks hot but its not that pleasant to read
polar abyss
vercel site is seggs but at the same time i think its a bit too dark
change color
problem solved
austere talon
also it looks low contrast does it not
swift fjord
no
polar abyss
also it looks low contrast does it not
not really
polar abyss
that's just gray
the whole's thing isn't low contrast
it's because of the gray color that it looks so
swift fjord
they could use a lighter grey
polar abyss
yeah
swift fjord
other than that it's fine
polar abyss
it needs more shiggy aswell
turbid hatch
@austere talon just thought
there's actually no real reason why a user should need to deauth
austere talon
ig
turbid hatch
and a dev can always just deauth through editing the uhh
indexeddb
ill leave the method there for now but it can just treeshake itself away
austere talon
btw
have you handled the case that a user manually deauthorises
by removing it in the authorised apps tab
oh wait that's not relevant is it
turbid hatch
the backend doesnt use the oauth app beyond the initial auth, if they remove it it has no meaning
xd
austere talon
cause we only use it initially and then don't use the token anymore
yeah I just remember
wait maybe we can just death right after then?
turbid hatch
p much
austere talon
DEATH THEM
turbid hatch
wait maybe we can just death right after then?
deauth in this context btw means just deleting the secret
xd
austere talon
I mean deauthorise the application
turbid hatch
up to you, personally i dont think its something we should worry about
austere talon
I'm not sure it's a good idea to give discord a list of users that use vencord xd
I mean technically they could just check this servers members but yeah
I forgot, did u do any encryption now?
no right
turbid hatch
no encryption, just zlib
turbid hatch
I'm not sure it's a good idea to give discord a list of users that use vencord x...
ah true
but yeah if they wanted to do that they can just chekc members xd
also ill be honest powercord did this too iirc
cause i have an oauth app with them
austere talon
btw do we even need to manually compress with fflate
doesn't browser have that inbuilt
gzip and deflate
turbid hatch
it's compressed when its written to redis
austere talon
just gotta set some headers
turbid hatch
its not just for transport
cause i basically just stream the request body to redis for storage
turbid hatch
hmmm
austere talon
I just found out this is a thing https://developer.mozilla.org/en-US/docs/Web/API/Compression_Streams_API
of course fucking Firefox doesn't support it
but electron does
austere talon
but yeah I think at least for getting data from the server the browser can auto uncompress it
if you set content encoding header
austere talon
yeah
if you use zlib
so the browser can handle uncompress, we just need to do compress
could even have something like
if (IS_WEB) {
require("fflate").compress()
} else {
// use compression streams
}```A little-known feature of HTTP (although, whether this is standard behavior depends on who you ask) is that you can start receiving the response while you're still sending the request. However, it's so little-known, that it isn't well supported by servers, and isn't supported by any browser.
wtf
turbid hatch
could even have something like
```js
if (IS_WEB) {
require("fflate").compres...
will that shake ?
austere talon
ye
turbid hatch
oh hot okay
austere talon
that's why the require inside IS_WEB
technically speaking if the library is properly treeshakable you can also top level import it but most libraries aren't or have some side effects so its best to keep it inside the if
austere talon
no typings
EWWW
limber skiff
also switch to latest-release branch cuz there is an issue I want you to fix since you know better
this
it shouldnt be here
austere talon
ig
austere talon
also switch to latest-release branch cuz there is an issue I want you to fix sin...
wdym
limber skiff
ok so when you switch to latest-release it checkouts the v1.1.1 tag
the last commit of that tag is bump to v1.1.1
it shouldnt mark that as an update available
cuz it's already done
limber skiff
turbid hatch
austere talon
were u on crack when u wrote this @limber skiff
austere talon
can i rewrite that entire function
i think i know how to do it better and also i wanna use a Set for the awaitAllChunks
limber skiff
If you keep it's functionality the same yeah
austere talon
also
ur function will return false if you call it with duplicate ids
ill fix that too
limber skiff
true
austere talon
couldnt find a better way
why not you just do this?
you want chunks of 100 right
forgot this after loop
limber skiff
that works lol
limber skiff
originally I wanted to await everything to arrive
limber skiff
cant u just useStateFromStores
I guess I could
austere talon
i prefer to use casts for things like this or explicitly named types
const x: VerboseType = blah() // you dont see actual code, only fairly useless type
const x = blah() as VerboseType // you see actual code first, type is secondary
type Foo = VerboseType;
const x: Foo = blah() // also alright
ah
austere talon
```ts
const x: VerboseType = blah() // you dont see actual code, only fairly use...
obviously preference but i also think this is the most logical approach
austere talon
yeah I think the middle option is not really needed, that's fine @olive vapor
gusty axle
random thought but would happen if two different plugins, use a patch on the same function but replace them with different return/code
olive vapor
oh okay that was quick
austere talon
random thought but would happen if two different plugins, use a patch on the sam...
they'd be incompatible
I don't think looking up art on google or similar services is a good idea
gusty axle
hmmm ok so only one plugin could be enabled at a time
austere talon
you might just get unlucky and pull porn or some other fucked up shit
if there's a service with moderated artworks then sure but I don't think there's any that will have stuff lastfm doesn't?
olive vapor
I don't think looking up art on google or similar services is a good idea
yeah, but it would be an option for the user. plus, i don't plan on implementing it right now (or at all?), just a potential update / idea for the future.
- if the user cared, i'm pretty sure adding album art on last.fm doesn't require approval.
austere talon
if there's a service with moderated artworks then sure but I don't think there's...
maybe soundcloud
austere talon
+ if the user cared, i'm pretty sure adding album art on last.fm doesn't require...
that's true but it's still way safer than say Google images
charred monolithBOT
olive vapor
just said google images as a general idea. again, don't plan to implement it, just opening up the possibility.
charred monolithBOT
olive vapor
yeah I think the middle option is not really needed, that's fine <@1579176651622...
ready for review
limber skiff
I removed requestGuildMembers @austere talon https://github.com/Vendicated/Vencord/pull/477
limber skiff
funny
tidal cloud
maybe soundcloud
ytm?
quaint sapphire
i havent seen anything more than "lewd" on ytm
most lewd I've seen is
which is pretty tame
actually I could say I've seen more lewd covers, but i cant really remember them
turbid hatch
actually I could say I've seen more lewd covers, but i cant really remember them
psycho albums are lewder
quaint sapphire
Point is, I haven't seen anything on the naked side of things in a cover
turbid hatch
oh that's what you're looking for?
one sec
death grips no love deep web @quaint sapphire
quaint sapphire
That's a Minecraft pickaxe shaft lol
turbid hatch
honestly just
quaint sapphire
Tf is that embed image?
turbid hatch
its when the UK government enforced a legal order to ban a page on wikipedia because one of the images was perceived as
well
read the subtitle on the page
anyway im not keeping that list there
cause someone's gonna stumble on it by accident
but yeah there's quite a few
charred monolithBOT
quick ibex
most lewd I've seen is
Oni Inc FUCK OFF
I also know some near-gore album covers, but those are horrifying
charred monolithBOT
austere talon
I also know some near-gore album covers, but those are horrifying
ive seen guro album covers
anime gore + nudity
quick ibex
The album cover I was thinking of is a suicide, blurred, and it has anime characters pointing at the body
charred monolithBOT
austere talon
anime gore + nudity
"Dehumanizing Itatrain Worship" on spotify / last fm
quick ibex
oh wow that is horrifying
quick ibex
The album cover I was thinking of is a suicide, blurred, and it has anime charac...
Suicide song by yung rare ig
austere talon
austere talon
when using ssr, does it cache the response?
say i want to make a ssr page that fetches github api
does every single request to that site trigger that fetch? Or does astro ssr somehow cache the rendered page
turbid hatch
does every single request to that site trigger that fetch? Or does astro ssr som...
if the content is static you can instruct it to prerender
export const prerender = true; in your module script
so you can mix the prerendered content with ssred content
charred monolithBOT
austere talon
ye
i know
but i do want to ssr it
just not every request
lets say i want to cache it for 30 minutes or smth like that
if within 30 minutes the same endpoint is visited again it sends the already built version
i want server side cache, not per user cache
charred monolithBOT
austere talon
@limber skiff maybe this is best rewritten with lookbehind? instead of quantifier
limber skiff
let me try
turbid hatch
if within 30 minutes the same endpoint is visited again it sends the already bui...
i can see the use case im just trying to work out if its feasible
this could be something done with a cdn but obviously thats $$$
you could set up varnish in front to cache the specific endpoints you're talking about to reduce load on astro
or use nginx to inject cache control headers that expire after 30 minutes (however that violates your no user cache desire)
both would work
austere talon
this could be something done with a cdn but obviously thats $$$
I think if I use something like vercel it can do this automatically
austere talon
I don't really care about server load I mostly care about not spamming github and similar
turbid hatch
you just have to send a cache-control
austere talon
austere talon
vercel has edge caching you can configure
I'm not so sure if I wanna use vercel or smth like that yet tho
currently I use node adapter
turbid hatch
either way, varnish or vercel/edge, i think we've got a solution ^^
austere talon
basically 90% of routes will be pre rendered, I just want one that auto generates contributors
and maybe plugins list
turbid hatch
yip
if you're hosting on vps, id suggest varnish, i can write the configs for that
otherwise yeah most edge networks can do the caching for you
turbid hatch
lmao yeah
austere talon
varnish looks cool
turbid hatch
yeah its great