DataStore is non blocking and has the great benefit that it's not json
#๐พ-core-development
austere talon
so you can store arbitrary data and objects there even if they aren't json serialisable
quaint sapphire
quaint sapphire
do you think that this is ok?
i didnt want to first get and then set if it did not exist, so i used the update method
oldValue is undefined according to the doc
*if missing
uhh, kinda useless tbh
since typescript will force me to type guard it every time
so it is redundant
quaint sapphire
I actually find this plugin useful since I have many foreign friends around the globe
so yeah
datastore is indeed nice
oof, it will say timezone removed no matter what in that snippet
crude hearth
datastore is indeed nice
tbh I think we can void that code completly
and stick to modals 
crude hearth
some people prefer commands
idk
quaint sapphire
its not like you are forced to use them
crude hearth
like in my latest commit i added this (thanks to arjix)
actually you can disable this
so you have a point
hmm also this looks ugly if people have statuses written
it looks like part of the status
quaint sapphire
this was entirely written by github copilot
quaint sapphire
it looks like part of the status
we could change the font or use italics
ok fully migrated to the data store
@crude hearth can i have push access to your fork?
crude hearth
<@287555395151593473> can i have push access to your fork?
how do I do that hm
quaint sapphire
ArjixWasTaken
quaint sapphire
got it
yeah
lmao
i am not toxic anymore lol
Pog
working on batch fetch
@fiery jungle why is it a POST? shouldn't it be a GET?
no data is modified after all
is it so that the ids are sent in the body instead of the query params?
weird design choice imo
fiery jungle
is it so that the ids are sent in the body instead of the query params?
yeah
i didnt really think of query params atm
doesnt matter though
quaint sapphire
@fiery jungle im getting 404s, please help
(it re-tries every 3 seconds)
no response is given
just 404
quaint sapphire
is it even sending the request?
quaint sapphire
only for linking to the website
kk
maybe its bc you dont handle preflight requests or smth? im confused af
fiery jungle
we should be
quaint sapphire
austere talon
FIX CORS @fiery jungle
cunning bobcat
UNFIX CORS
charred monolithBOT
quaint sapphire
@fiery jungle why not found?
i did login
is the bulk just broken?
oooh
the content type header is at fault
quaint sapphire
Really weird
frail sky
quaint sapphire
Lmao, I did make it retry only after 15 seconds
So not that bad
But still wtf is going on?
Anyways, tomo I'll make the modals
Actually, does it really have to be a modal?
We could just add a drop-down in-place when you click edit
charred monolithBOT
quaint sapphire
If it is done well it will feel like a native discord feature
charred monolithBOT
crude hearth
If it is done well it will feel like a native discord feature
it probably will in future
if we make it good enough discord developers will steal code from us
charred monolithBOT
quaint sapphire
@crude hearth
when you click the edit icon, it lets you pick a timezone, clicking the edit button again saves the timezone, and delete does what you expect it to
quaint sapphire
(it deletes the timezone from the db)
also when you click the time, it tells the timezone
with a toast
@crude hearth you can now check this off
quaint sapphire
๐
@crude hearth can you move all the inline styles I have to conditional classes?
crude hearth
not now
charred monolithBOT
Screenshots:
User Modal
Message
quaint sapphire
@crude hearth two out of the three conversations can be marked as resolved
crude hearth
<@287555395151593473> two out of the three conversations can be marked as resolv...
which ones
turbid hatch
@spark cove time to write vencordbot so we can do /assign user
quaint sapphire
which ones
in the order they appear in code, lol
all the ones except the "set own timezone thingy"
quaint sapphire
I resolved all of them
lmao, actually that works as well, cause the last one doesnt matter
since we link the link
turbid hatch
well if i was to do it, itd be so that it could auto-assign reviewers for plugins that they own (based on the actual contributor field in the file?) or so that anyone who's an admin can authorize the auto checks or whatever
spark cove
@turbid hatch how does this work
turbid hatch
in backup / restore
there should be some dev buttons
click authorize to set it up
forgor is to deauthorize yourself
sync to cloud will upload your current settings
sync from will pull them down
spark cove
i will backup my settings one sec
turbid hatch
the other button doesnt work atm cuz i broke it
turbid hatch
it should 404 initially cause you dont have anything up there
the request works, the logging bit doesnt
404s are definitely intentional though when you dont initially have any settings data
spark cove
ohh
crude hearth
WHAT
quaint sapphire
hooks dont work if you return before them
all returns must be made after all the hooks
if a hook is not called consistently it wont work
crude hearth
hooks dont work if you return before them
they dont have to work
spark cove
@turbid hatch whats the E2E encryption for
crude hearth
if user is null you dont do anything
spark cove
oh
turbid hatch
using fflate
turbid hatch
xd
charred monolithBOT
spark cove
oh lol silly
turbid hatch
but yes i presume the intent is to validate it
spark cove
im moving fetch logic into a class so just making sure
spark cove
i hope
turbid hatch
mwah
spark cove
which one because a lot of what im doing could probably apply to it as well xd
spark cove
OAuth2AuthorizeModal
turbid hatch
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/bad96b78879f296d5b9e7adacb03756b0f584...
**Utils.tsx: **Lines 42-72
openModal((props: any) =>
<OAuth2AuthorizeModal
{...props}
scopes={["identify"]}
responseType="code"
redirectUri="https://manti.vendicated.dev/URauth"
permissions={0n}
clientId="915703782174752809"
cancelCompletesFlow={false}
callback={async (u: string) => {
try {
const url = new URL(u);
url.searchParams.append("returnType", "json");
url.searchParams.append("clientMod", "vencord");
const res = await fetch(url, {
headers: new Headers({ Accept: "application/json" })
});
const { token, status } = await res.json();
if (status === 0) {
Settings.plugins.ReviewDB.token = token;
showToast("Successfully logged in!");
callback?.();
} else if (res.status === 1) {
showToast("An Error occurred while logging in.");
}
} catch (e) {
new Logger("ReviewDB").error("Failed to authorise", e);
}
}}
/>
);
epic
turbid hatch
i dont particularly care about them
spark cove
i figured it could have been a security thing
spark cove
xdxd
quaint sapphire
you can align it urself!
crude hearth
you can align it urself!
TRUE
fiery jungle
@quaint sapphire can you remove me from the screenshot on github
quaint sapphire
Sure
fiery jungle
thank
austere talon
<@674710789138939916> can you remove me from the screenshot on github
lol why
fiery jungle
i dont want my discord that public
no need
theres a reason i dont put my discord anywhere
also my tz trolley
commits only have gmt-7
spark cove
vencord plugin that is enabled by default that opens profile modal for Devs.rushii
crude hearth
<@674710789138939916> can you remove me from the screenshot on github
Shyyyy
Rusher dont be shy
fiery jungle
nop
rigid venture
@austere talon here but idk how to check for blocked setting and blocked users without making it more complicated than it is
austere talon
you're doing wrong
rigid venture
yeah
austere talon
const myId = UserStore.getCurrentUser().id;
const typingUsersArray = Object.keys(typingUsers).filter(id => id !== myId && !RelationshipStore.isBlocked(id))```this is what u want
austere talon
<@343383572805058560> here but idk how to check for blocked setting and blocked...
when you make a proper function body with {} u need a return
rigid venture
sure but i need to check for setting too
austere talon
just do that then silly
rigid venture
HOW
cunning bobcat
๐
cunning bobcat
&& !store.whatever.includes(id) im pretty sure
rigid venture
shhhh
cunning bobcat
depends how you did it
austere talon
const myId = UserStore.getCurrentUser().id;
const typingUsersArray = Object.keys(typingUsers).filter(id => id !== myId && !(RelationshipStore.isBlocked(id) && settings.store.hideBlocked))```oh that
rigid venture
true
austere talon
silly fawna
rigid venture
be nice
cunning bobcat
fawn will never be not silly
rigid venture
also i added the brackets when i was trying to add the blocked too then left it
it's okay
why can i not request two reviewrs at the same time
quaint sapphire
<@343383572805058560> here but idk how to check for blocked setting and blocked...
webstorm?
hey @austere talon, ever thought of leaving a new review on the timedones PR?
crude hearth
@austere talon REVIEW
austere talon
whats up with people closing and opening new prs
turbid hatch
whats up with people closing and opening new prs
one way to find out
@supple turtle hoi! why close and open pr
supple turtle
idk, but this warning is a little late
supple turtle
next time i won't
charred monolithBOT
charred monolithBOT
rigid venture
@austere talon merge literallyt right now
charred monolithBOT
crude hearth
@quaint sapphire i fixed ur design
quick ibex
@shut dome depressing status :(
shut dome
Death is not friendly. It's dark, black where you look at it. You're all alone. But it's no different when you're alive, right? No matter how many relationships we seem to have, we're all alone. - Misaki Mei
solemn spoke
i have only one thing to say: fuck life's purpose. it doesn't have one, so just don't care and enjoy as much as you can
quaint sapphire
Death is wholesome, w/o death you wouldn't enjoy life. /s (ofc it is not wholesome, but it aint dark)
quaint sapphire
<@674710789138939916> i fixed ur design
yippee?
solemn spoke
Death is wholesome, w/o death you wouldn't enjoy life. /s (ofc it is not wholeso...
that was too dark
quaint sapphire
how is that dark?
charred monolithBOT
quaint sapphire
- worrying about smth you cant change is a waste of time and energy, so you should instead focus on living your best life
- if you were immortal, there would be no incentive for you to enjoy life
crude hearth
i have only one thing to say: fuck life's purpose. it doesn't have one, so just ...
thats the worst thing I heard today
what you said is like supporting drugs
crude hearth
@austere talon REVIEW
charred monolithBOT
charred monolithBOT
solemn spoke
agreed
charred monolithBOT
verbal pumice
now that vencord has it's own switch component instead of using the discord one can't boolean setting options be made to use switches now
umbral hedge
ye
austere talon
wha
they could already use switches before
megu just decided to implement it this way because idk why
umbral hedge
megu just decided to implement it this way because idk why
the old switches were gross and wouldn't work how I wanted them to
austere talon
the old switches were gross and wouldn't work how I wanted them to
๐ค
umbral hedge
cant remember exactly but it was probably because of all the extra styling they added on top that couldn't be removed
probably the same reason I didn't want to use them originally on the plugin list
charred monolithBOT
limber skiff
@vagrant topaz we are talking about different modules lol
the one I point has like the same thing
are you sure yours is the correct one?
it doesn't have an iconType
the old code patched the one with it
I haven't tested
either way my the current match and replace would work
let me test
okay yeah yours is the one that works
@vagrant topaz you just have to change the find to the one you put
I just tried this and it worked
||a||||a||||a||||a||||a||||a||||a||||a||
||a||||a||||a||||a||||a||||a||||a||||a||
@vagrant topaz Implement this fix on revealAllSpoilers too
patches: [
{
find: ".removeObscurity=function",
replacement: {
match: /\.removeObscurity=function\((.\i)\){/,
replace: ".removeObscurity=function($1){$self.reveal($1);"
}
}
],
yeah
just so both plugins get fixed
limber skiff
ehhh
another pr just for that?
kinda meh
oh guh I made a typo there
remove this dot
ye
you can rename the pr too
insane
yes
that's our custom syntax
it gets transformed into something else
huh
this
[A-Za-z_$][\\w$]*
it's for matching discord variable names
woeful sable
i love
spark cove
its just weird that its opinionated by default
im sure u can turn off it's linter as a whole
umbral hedge
you will add 10mb of timezones
austere talon
by using a standardised tool rather than reimplementing the wheel using their own proprietary tool?
quaint sapphire
I do sound overly dramatic, but rushii being so confident that I stole the timezones from a package made me act up
cause in fact, I put in effort to gather that list
@austere talon in your opinion, is fetching the list of timezones, on every single restart, the way to go?
austere talon
why would you need a list of timezones
quaint sapphire
...
austere talon
?
quaint sapphire
how do you even think this works?
austere talon
let the user type the timezone lol
quaint sapphire
and another reason for the list, is to verify that the timezone is correct
austere talon
why would anyone want a drop down with hundreds of options
crude hearth
why would you need a list of timezones
because api updated to use timezone strings ๐
crude hearth
let the user type the timezone lol
so bad ux
turbid hatch
a dropdown is worse
quaint sapphire
using a drop down with hundreds of options is bad ux
you expect every fucking user to know the goddamn timezone string?
crude hearth
if you country starts with E just go straight down
turbid hatch
verbal pumice
its ordered by name
if it has thousands of entries its bad ux no matter how its sorted
quaint sapphire
you expect every fucking user to know the goddamn timezone string?
who would expect that GMT-2 is actually Etc/GMT+2?
crude hearth
if it has thousands of entries its bad ux no matter how its sorted
it only has like 200
quaint sapphire
nobody
austere talon
don't use GMT+2
umbral hedge
add the fancy timezone selector map
crude hearth
you expect every fucking user to know the goddamn timezone string?
^ I second this
austere talon
it only has like 200
Still bad
crude hearth
I wouldnt wanna look at wikipedia just to set timezone
quaint sapphire
i too would like a search bar, but that is discord's fault
umbral hedge
https://discord.coffee/6YPDwZz.png
I prefer this
verbal pumice
zamn
quaint sapphire
the argument is "why would you need a list"
turbid hatch
then it went from that to a discussion of UX
once you demonstrated what the list was for
yes, i agree having the list is good for validation
but the way its being presented as a list of choices to the user is hell
quaint sapphire
ven asking why we need a list when he most likely hasnt even seen the plugin is what made me mad
crude hearth
but the way its being presented as a list of choices to the user is hell
its better than just giving users input box imo
turbid hatch
no, i dont want to memorise my timezone string either, but neither do i want to scroll through 200 odd options just to find mine
or another person's
quaint sapphire
an input box to filter out the list is great
but not already implemented by discord
turbid hatch
nor do i understand what every single timezone string corrolates to
umbral hedge
discord has a list of countries built in
use that and then make a api call to get the timezone when ur configuring it? idk
quaint sapphire
i have no need for a list of countries
unless you want it to be a two step process
verbal pumice
input box with auto complete is better than list imo
quaint sapphire
selecting the country and then the city
austere talon
fuck you ven
stop being an asshole lol
verbal pumice
who would expect that GMT-2 is actually `Etc/GMT+2`?
exept for this
crude hearth
input box with auto complete is better than list imo
the question is ,is there autocomplete input box
quaint sapphire
we use a select box
so he does not mean that
actually, why is the discord select so bad?
umbral hedge
discord has select boxes you can type into
what do you mean then
quaint sapphire
the default browser select has search built-in
quaint sapphire
discord has select boxes you can type into
what do you mean then
gib
umbral hedge
im pretty sure we use it somewhere
quaint sapphire
is it a param to the component or smth?
umbral hedge
idk its been aaages
verbal pumice
settings has search, that?
verbal pumice
yeah im stupid
turbid hatch
one moment
quaint sapphire
settings has search, that?
https://www.w3schools.com/tags/tryit.asp?filename=tryhtml_select
if you click the select, and start typing, it marks a matching option
austere talon
I'm still not a fan of including it like that in discord
quaint sapphire
I'm still not a fan of including it like that in discord
the list?
austere talon
I would do a plain text input and if you think users don't know timezones, you can link them to a site like https://kevinnovak.github.io/Time-Zone-Picker/
turbid hatch
also it doesnt work on discord selects
quaint sapphire
I would do a plain text input and if you think users don't know timezones, you c...
sorry but if we are being honest, the users are too dumb for that
umbral hedge
yeah that map was what i was referring to earlier
i see users failing at doing that
xd
verbal pumice
sorry but if we are being honest, the users are too dumb for that
+1
quaint sapphire
thats really bad
i didnt say it is great, but still better than a plain select w/o search
crude hearth
I would do a plain text input and if you think users don't know timezones, you c...
you know how dumb users are
turbid hatch
@umbral hedge cant seem to find what you're looking for in @webpack/common
crude hearth
they will manage to miswrite
umbral hedge
<@545581357812678656> cant seem to find what you're looking for in @webpack/comm...
yeah idk where it went
turbid hatch
custom component?
umbral hedge
I definitely used it once
quaint sapphire
I could make my own select if you prefer that
austere talon
they will manage to miswrite
and then you just tell them that the timezone they entered is invalid? I don't get the problem
turbid hatch
^ which CTI is a valid use case for
crude hearth
and then you just tell them that the timezone they entered is invalid? I don't g...
possible but still
for each person you wanna set timezone
redirecting to website
I dont support that
bad ux
turbid hatch
then make it not a requirement
umbral hedge
ah there's a searchable option for <Select>
turbid hatch
to do so
charred monolithBOT
quaint sapphire
and then you just tell them that the timezone they entered is invalid? I don't g...
by try/catching it?
actually, why doesn't js expose the built-in timezones?
fr
turbid hatch
discord are u ok
does discord itself use it anywhere?
also
you can
Intl.supportedValuesOf('timeZone');
umbral hedge
aha there's a component called SearchableSelect
turbid hatch
lol
it returns every timezone supported by Intl
so now including the list is a non-issue because you dont need it
quaint sapphire
`Intl.supportedValuesOf('timeZone');`
turbid hatch
what is that running on
quaint sapphire
default discord
turbid hatch
stable?
turbid hatch
fucking pieces of shit
can they just
upgrade to electron 17
cause it works great there
quaint sapphire
https://discord.coffee/8U8QKnV.png
umbral hedge
search for --icons-width
seems like its the SearchableSelect component
spent ages just looking for unique code to find it by 
quaint sapphire
ok what if we conditionally load the list if Intl does not have the list (due to electron being old)?
quaint sapphire
list is still included in bundle
im talking about fetching it at runtime...
quaint sapphire
like many dependencies
umbral hedge
suing discord to get them to upgrade electron
austere talon
https://discord.coffee/8U8QKnV.png
Also see how this list has way more values than your list
another reason I dislike hardcoding a list
quaint sapphire
Also see how this list has way more values than your list
my list is TimezoneDB + timezone offsets
umbral hedge
I wonder when discord is actually gonna update stable electron ver
quaint sapphire
that list is most likely a lot more cities
turbid hatch
it does seem to have cities
quaint sapphire
when their HQ explodes
turbid hatch
e.g. America/Dawson and America/Dawson_Creek
identical offsets but unique timezones
umbral hedge
yeah but like
turbid hatch
dawson is yukon time and dawson creek is mountain standard time
umbral hedge
if Europe/London is valid then America/Dawson_Creek should be too
quaint sapphire
if Europe/London is valid then America/Dawson_Creek should be too
im all for that, but using cities as timezones is a bit meh
turbid hatch
lmao
umbral hedge
the map method is way better
quaint sapphire
what if you are in the same timezone as Europe/London, but you dont live in the UK?
turbid hatch
there's multiple timezones listed under GMT/UTC
quaint sapphire
why not just Etc/GMT?
turbid hatch
because DST exists
quaint sapphire
like, i never get that
umbral hedge
timezones hell
austere talon
why not just `Etc/GMT`?
because those don't account for so many factors?
turbid hatch
if you hardcode it to GMT
quaint sapphire
because those don't account for so many factors?
fuck them cities
quaint sapphire
what happens when Europe/London becomes GMT+1
we all die
quaint sapphire
guess we will die
turbid hatch
it also happens in multiple timezones around the world at different times due to various reasons
what about the +8:30 offset or whatever it is
quaint sapphire
timezones hell
umbral hedge
tbh we could really oversimplify the timezone picker and do what ven said and send people there
visit this link to get your timezone name
show map
select location
copy this value into vencord
ez
austere talon
if someone doesn't know their timezone name they also won't find it in a dropdown
austere talon
- who doesn't know their timezone
turbid hatch
or GMT
quaint sapphire
please watch this
i wont, cause I have watched almost every video from that channel
austere talon
99% of people just need to type their continent and capital city
umbral hedge
pull in the map JS remotely like we do with shiki and have it appear in the settings form
turbid hatch
well thats your own downfall i guess, cuz the entire video is about how painful dealing with timezones is and how to do the UX for them
quaint sapphire
well thats your own downfall i guess, cuz the entire video is about how painful ...
downfall? lmao
turbid hatch
yes, im trying to give you a resource on the issues with dealing with timezones and the UI/UX that have already been attempted and failed
quaint sapphire
dont give me anything, manti should fix it https://cdn.discordapp.com/emojis/932622403845099550.webp?size=48&quality=lossless
umbral hedge
pull in the map JS remotely like we do with shiki and have it appear in the sett...
if someone doesn't give a reason against this, then my vote is for this xd
turbid hatch
good for me
umbral hedge
if it only downloads the code when you open that plugin's settings then I don't see an issue with size, and its decent UX
quaint sapphire
if someone doesn't give a reason against this, then my vote is for this xd
...i literally suggested it a few messages above
quaint sapphire
ok what if we conditionally load the list if Intl does not have the list (due to...
^
turbid hatch
yeah that was a bit vague
quaint sapphire
indeed
umbral hedge
ah yeah that was not quite the same
turbid hatch
i originally thought it meant you include it in the bundle, not load it remotely
quaint sapphire
"conditionally load" is the key point
umbral hedge
yeah same
turbid hatch
yeah but you can conditionally load stuff from the bundle as well
it wasnt clear
anyway
quaint sapphire
yeah but you can conditionally load stuff from the bundle as well
but there is no reason to
turbid hatch
regardless
umbral hedge
but ya my vote is with pulling the map bundle when you open the timezonedb settings
quaint sapphire
would be stupid
turbid hatch
(there are valid reasons e.g. patching for behaviour differences but that's for another time)
quaint sapphire
(there are valid reasons e.g. patching for behaviour differences but that's for ...
oh well
quaint sapphire
but ya my vote is with pulling the map bundle when you open the timezonedb setti...
the 400+ items list or the list I made?
umbral hedge
no, this thing http://kevalbhatt.github.io/timezone-picker/
quaint sapphire
jquery
umbral hedge
I remember doing image zones on youtube banners back in the old days
arguably we could just load the SVG
or
the one ven sent, they dont use jquery much (why the hell do they even import that shit)
we'd barely have to change anything honestly
quaint sapphire
https://www.w3schools.com/html/html_images_imagemap.asp
i remember websites using images instead of html
turbid hatch
anyway so this searchableselect thing
umbral hedge
ye
turbid hatch
is it just select with an extra prop
umbral hedge
nah thats the old one
umbral hedge
search for `--icons-width`
.
umbral hedge
its props seem to be basically the same as normal select
umbral hedge
<:husk:1026532993923293184> has json
https://github.com/kevalbhatt/timezone-pick...
yeah but the difference is we're only pulling in the map when you open the plugin settings
its not really a biggie i think
turbid hatch
yeah it looks about the same
in fact it might be the same
id have to compare each prop but from a quick glance yeah
umbral hedge
- we can remove that when discord finally gets their act together and updates electron
ah actually no bc they have coords in that json
turbid hatch
so adding it as a component it should just be
umbral hedge
nvm
turbid hatch
like
umbral hedge
umbral hedge
so adding it as a component it should just be
should be similar to the existing settings components we use
turbid hatch
export const SearchableSelect = waitForComponent<t.Select>("SearchableSelect", filters.byCode("--icons-width"));
more or less
fiery jungle
why is this still a debate
default to electrons timezone in a full drop down list
I literally did it for the tzdb website
umbral hedge
ig
you probably want more filters than that but yeah
turbid hatch
yeah i'll probably just copy the select filters and stick icons-width on the end
umbral hedge
why is this still a debate
default to electrons timezone in a full drop down lis...
our current debate is about adding a map
umbral hedge
because people are too stupid to search for "Europe/London"
fiery jungle
that's so dumb
umbral hedge
have you seen discord mod users
quaint sapphire
because people are too stupid to search for "Europe/London"
no, people are too stupid to type it the exact way it is
turbid hatch
why is this still a debate
default to electrons timezone in a full drop down lis...
re second point, we cant
because electron 13 doesnt have the right method
lol
fiery jungle
bruh
turbid hatch
electron 17 does though
quaint sapphire
discord does not use 17 tho
turbid hatch
canary does
fiery jungle
just do it anyways
canary is on newer isn't it
turbid hatch
canary is on 22 now actually
fiery jungle
it's gonna happen eventually
default to nothing if the method from electron 17 doesn't work
fiery jungle
shipping a data set of timezones by geolocation is so bad
fiery jungle
oh great idea
surely someone has made a website to find your tz based on geolocation on a map
just link to that instead of shipping it
quaint sapphire
has both select and map
crude hearth
because people are too stupid to search for "Europe/London"
yes it has to be a list
quaint sapphire
oh great idea
surely someone has made a website to find your tz based on geoloca...
or we can just use it directly...
fiery jungle
shipping a data set of timezones by geolocation is so bad
^
fiery jungle
wheres the data loaded from
austere talon
default to nothing if the method from electron 17 doesn't work
yeah I think this is pretty sensible, have a text input and add autocomplete if that method is available
you can also just display the current timezone to the user so they can give it to their friends or smth
umbral hedge
yeah we found an autocomplete component
austere talon
Intl.DateTimeFormat().resolvedOptions().timeZone
should work for getting current timezone
quaint sapphire
instead of giving current timezone, you could just set the timezone on TimezoneDB
fiery jungle
you cant set for other users
quaint sapphire
why would the other user give you the timezone instead of setting it?
quaint sapphire
youre thinking that everyone uses specifically a client mod and tzdb
everyone I know does so
fiery jungle
just gzip it or something and decode when you need
its gonna go down to a single kb
fiery jungle
everyone I know does so
thats uniquely you
quaint sapphire
thats uniquely you
I am everyone I know? thats dark
fiery jungle
no
quaint sapphire
Works on my machine life
fiery jungle
youre the only one in that situation
barely anyone i know actually uses remote tzdb
quaint sapphire
what about client mods?
fiery jungle
that too
turbid hatch
i tried "popoutPosition", "autoFocus", "maxVisibleItems", "--icons-width" and just the last one and it couldnt find the component
which is annoying
quaint sapphire
youre the only one in that situation
barely anyone i know actually uses remote t...
nobody I know uses tzdb, but if they use this plugin they will come to know of it
quaint sapphire
i wont do anything lol
manti https://cdn.discordapp.com/emojis/932622403845099550.webp?size=48&quality=lossless
turbid hatch
fiery jungle
just gzip it or something and decode when you need
its gonna go down to a single...
@austere talon
turbid hatch
well it can definitely find it
austere talon
https://discord.coffee/7nFSBu4.png
epic filter fail
austere talon
<@343383572805058560>
what
turbid hatch
i mean the filter works :<
crude hearth
i wont do anything lol
manti https://cdn.discordapp.com/emojis/93262240384509955...
DEATH
fiery jungle
where do you get it then from 
fiery jungle
does electron have a list
austere talon
so i need to use a different filter
show cod
turbid hatch
// export const Select = waitForComponent<t.Select>("Select", filters.byCode("optionClassName", "popoutPosition", "autoFocus", "maxVisibleItems"));
export const Select = waitForComponent<t.Select>("Select", filters.byCode("popoutPosition", "autoFocus", "maxVisibleItems", "--icons-width"));
literally what u said earlier
turbid hatch
i was hoping that'd do it
cuz --icons-width only points to this searchableselect component
quaint sapphire
I will force ven
so this will never be done?
austere talon
```typescript
// export const Select = waitForComponent<t.Select>("Select", filt...
why did u comment out 1 did it not work
turbid hatch
(btw im only reexporting it as Select to test)
no thats the original
:P
i was using it as reference
turbid hatch
to test this component
austere talon
you're confusing me xd
turbid hatch
this is the SearchableSelect thing megu found
quaint sapphire
so why are u changing it wha
to not update the imports ofc
turbid hatch
im testing it by reexporting it as select since it has the same props
crude hearth
we will find something
turbid hatch
so i can play with it
crude hearth
I will force chatgpt to write me a good component
austere talon
oh it's a different thing
umbral hedge
the old select component had a searchable prop but the new one doesn't
austere talon
not Select
turbid hatch
ye
umbral hedge
the new Select component was split into Select and SearchableSelect
crude hearth
also wth are we discussing rn
turbid hatch
but its the same as the Select component from our standpoint, just with different functionality
crude hearth
select component or 10kb timezone file
quaint sapphire
also wth are we discussing rn
ยฏ_(ใ)_/ยฏ
umbral hedge
select component or 10kb timezone file
both at once
turbid hatch
its strange though that just the last filter doesnt work
fiery jungle
literally what u said earlier
huh??
turbid hatch
do you know where discord uses it @umbral hedge ?
umbral hedge
uhh
umbral hedge
address form, guild community settings, in interaction components (autocomplete ig), user settings game activity component
yeah in community settings
turbid hatch
community settings?
umbral hedge
you can type in these
turbid hatch
huh, guess that works
turbid hatch
weird
it should be able to find it
maybe its because its in a forwardref?
although that doesnt make much sense
austere talon
austere talon
maybe its because its in a forwardref?
yes
umbral hedge
pretty sure thats what we use mapMangled or whatever for
austere talon
const filter = wp.filters.byCode("popoutPosition", "autoFocus", "maxVisibleItems", "--icons-width")
find(m => m.render && filter(m.render))
that is the component
turbid hatch
well i tried doing this
export const Select = waitForComponent<t.Select>("Select", m => {
if (typeof m !== "function") return false;
return m.render && filters.byCode("popoutPosition", "autoFocus", "maxVisibleItems", "--icons-width")(m.render);
});
which got me nowhere
austere talon
because its not a function
turbid hatch
this is true!
it doesnt seem to respect default values though
actually wait ive never fiddled with those
hold on
https://discord.coffee/9UQqQiB.png okay yeah this is gonna take some fiddling
xd
so select -> onChange
it seems
which i guess makes sense
austere talon
just read code to see what it takes
quaint sapphire
manti will update
turbid hatch
i think ive gotten every meaningful option out of it
the rest seem to be a bit jank or dont make much sense
charred monolithBOT
charred monolithBOT
crude hearth
UNFAIR
IT DIDNT EVEN PASS 6 MONTH PULL REQUEST WAIT TIME
@umbral hedge REVERT
And OPEN PR LIKE OTHER USERS
crude hearth
Nop
charred monolithBOT
Adds notifications for the following:
- Friend Added
- Friend Removed
- Outgoing Friend Request Created
- Outgoing Friend Request Cancelled
- Incoming Friend Request Created
- Incoming Friend Request Cancelled
- Block added
- Block removed
On click, it opens the target user's profile.
TODO:
- [ ] Allow each notification to be enabled/disabled
crude hearth
Now wait 6-8 months depending on vens psychology
umbral hedge
I will review and merge it myself 
also reviewing PRs is a ballache, you can hardly blame him
crude hearth
I will review and merge it myself <:blobcatcozy:1026533070955872337>
Merge mine too
Just a single click
Do it without ven noticing
umbral hedge
xd
so ugly
i will do settings rewrite in 3 million years
I think I prefer doing it like this
crude hearth
Sad
crude hearth
Lov
umbral hedge
ok its done i think
supple turtle
๐ข๐ข๐ข
unborn garnet
the new select component has multiselect btw
how
turbid hatch
because its not the legacy select component
its the new one with search and stuff
unborn garnet
ooh
charred monolithBOT
umbral hedge
it was a rare moment of adhd "oh fuck I can program suddenly after ages of not being able to do anything"
I won't be very sad if it gets dropped
quaint sapphire
Yours is more compact code-wise
Maybe see if both plugins can be combined in a way?
(If yours is lacking features)
umbral hedge
yeah they seem to have guild/channel notifs as well
I'd prefer to move that into my PR bc it feels cleaner but that's just personal preference
oh they also have offline notifs
thats's pretty neat
charred monolithBOT
Discord Account
A user#8169
What is it that you'd like to see?
If a moderator mentions a channel that it does not exist, Discord will display as ๐ No acess. It would be cool if it did display the name of the channel
Request Agreement
- [X] This is not a plugin request
quaint sapphire
I'd prefer to move that into my PR bc it feels cleaner but that's just personal ...
It does feel cleaner for me as well
Maybe ping the author
umbral hedge
I want to reimplement their stuff in this style but I also don't wanna mess with their efforts xd
cunning bobcat
charred monolithBOT
this isn't a permanent fix, as one day the experiment might disappear, but in the meantime you can do this:
somber ginkgo
@austere talon merges any pull requests challenge (impossible)
umbral hedge
simply pay ven a reasonable salary
austere talon
200000โฌ
opaque pewter
money cant buy friendship merge my pr
did u kno megu is sponsoring vendy
umbral hedge
and vendy sponsors me
cunning bobcat
fake
verbal pumice
do not the webviewcord
austere talon
wha
turbid hatch
i think they mean that themes depend on the checked class to apply switch coloring
but because vencord's custom switches dont have that, they dont get the coloring
so they look different from the rest of the switches
charred monolithBOT
charred monolithBOT
charred monolithBOT
