'
#👾-core-development
swift fjord
bad
limber skiff
charred monolithBOT
limber skiff
you will also merge this ven, trust my patches 😉
charred monolithBOT
elfin dew
rigid venture
mrowt
charred monolithBOT
charred monolithBOT
rare escarp
charred monolithBOT
limber skiff
I only now was able to see that #assets was hidden 
charred monolithBOT
limber skiff
epic megu help
umbral hedge
limber skiff
is the rtc connecting issue too?
limber skiff
dang
limber skiff
it's so strange it happens more with fakenitro
austere talon
there's no correlation I tried with fake nitro on and off and managed to reproduce it both times
limber skiff
yeah I never tested
umbral hedge
people jump to blame client mods
limber skiff
just noticed more people blaming it and figured it kinda happened to me too
solemn spoke
we will make a voice fix lol
charred monolithBOT
charred monolithBOT
limber skiff
goodluck ven
limber skiff
for now we can keep that setting
and if you could just make completely sure message logger works for me you can merge it
I'm not on pc anymore
actually eh no need to test
there is no way it's not working
I'm using both moment and timestamp on showhiddenchannels
I just made message logger import them from common
charred monolithBOT
charred monolithBOT
limber skiff
so beautiful 😭
austere talon
noleeks
limber skiff
hmmm
discord does not like channels that you can't view but can connect
you can click this and it opens the window
limber skiff
you can click this and it opens the window
gonna have to find where the logic that decides if those buttons will show up is
charred monolithBOT
the installer chooses older directory which has an installation of discord bd which didn't go away upon using the bd installer to uninstall.
charred monolithBOT
charred monolithBOT
umbral hedge
austere talon
god typing these is pain
umbral hedge
I can probably help with that xd
charred monolithBOT
umbral hedge
umbral hedge
wym
austere talon
l = mt(e, [
"type",
"className",
"disabled",
"selectable",
"children",
"style",
]),
what does this do
is this like propsExceptThoseKeys
umbral hedge
what component
austere talon
FormText
umbral hedge
looks like it's just a replacement for the spread operator?
const FormText = ({type, className, disabled, etc..., ...props}) => {}```are those passed down to Text or smth
umbral hedge
yeah
austere talon
husking
umbral hedge
it adds classname and style, and just {...props}
why not do /** @default {FormText.Types.DEFAULT} */
i think that works at least
umbral hedge
xd
austere talon
needs to be inside ComponentType<>
charred monolithBOT
austere talon
okay fixed them
umbral hedge
austere talon
now gotta type all of the rest
umbral hedge
charred monolithBOT
umbral hedge
improb
umbral hedge
makeWaitFor
austere talon
- minified react error undefined isnt component type blah blah
+ Could not find Button
le simple
umbral hedge
austere talon
i found issue with that
umbral hedge
o?
austere talon
some components have props
umbral hedge
wdym
isn't the user supposed to provide the props anyways
austere talon
this should fix
austere talon
wdym
isn't the user supposed to provide the props anyways
Button.Sizes.SMALL
Button becomes LazyComponent which doesnt have SIzes prop
austere talon
this should fix
.
umbral hedge
charred monolithBOT
umbral hedge
le epic fix moment
austere talon
yop u love
umbral hedge
love
austere talon
doesnt seem to make a performance difference
even though every component is wrapped in a function now
umbral hedge
MORE
austere talon
did a funny
type FluxEvents = "MESSAGE_CREATE" | "ACTIVITY_INVITE_MODAL_OPEN" | "ACTIVITY_INVITE_MODAL_CLOSE" | "SHOW_KEYBOARD_SHORTCUTS" | "HIDE_KEYBOARD_SHORTCUTS" | "APPLICATION_COMMAND_SET_ACTIVE_COMMAND" | "CONNECTION_OPEN" | "CONNECTION_CLOSED" | "AUDIO_SET_MODE" | "PREMIUM_PAYMENT_MODAL_OPEN" | "PREMIUM_PAYMENT_MODAL_CLOSE" | "MESSAGE_LENGTH_UPSELL" | "POST_CONNECTION_OPEN" | "CHANNEL_SELECT" | "AGE_GATE_MODAL_OPEN" | "AGE_GATE_MODAL_CLOSE" | "AGE_GATE_SUCCESS_MODAL_OPEN" | "AGE_GATE_FAILURE_MODAL_OPEN" | "WINDOW_FOCUS" | "APP_STATE_UPDATE" | "LOGIN_SUCCESS" | "RTC_CONNECTION_VIDEO" | "AUDIO_SET_LOCAL_VIDEO_DISABLED" | "VOICE_CHANNEL_SELECT" | "CONNECTIONS_GRID_MODAL_SHOW" | "CONNECTIONS_GRID_MODAL_HIDE" | "LOGOUT" | "CHANNEL_DELETE" | "UNVERIFIED_GAME_UPDATE" | "GAME_ICON_UPDATE" | "CHECK_LAUNCHABLE_GAME" | "POGGERMODE_SETTINGS_UPDATE" | "POGGERMODE_TEMPORARILY_DISABLED" | "CHANNEL_CALL_POPOUT_WINDOW_OPEN" | "RTC_DEBUG_POPOUT_WINDOW_OPEN" | "PROFILE_CUSTOMIZATION_OPEN_PREVIEW_MODAL" | "MESSAGE_UPDATE" | "MESSAGE_DELETE" | "SPEAKING" | "GUILD_CREATE" | "CHANNEL_CREATE" | "RPC_NOTIFICATION_CREATE" | "ACTIVITY_JOIN" | "ACTIVITY_PIP_MODE_UPDATE" | "THERMAL_STATE_CHANGE" | "ACTIVITY_SCREEN_ORIENTATION_UPDATE" | "RELATIONSHIP_ADD" | "RELATIONSHIP_REMOVE" | "PRESENCE_UPDATES" | "PRESENCES_REPLACE" | "LOBBY_UPDATE" | "LOBBY_DELETE" | "LOBBY_MEMBER_CONNECT" | "LOBBY_MEMBER_UPDATE" | "LOBBY_MEMBER_DISCONNECT" | "LOBBY_MESSAGE" | "ENTITLEMENT_CREATE" | "ENTITLEMENT_DELETE" | "USER_ACHIEVEMENT_UPDATE" | "VOICE_CHANNEL_EFFECT_SEND" | "VOICE_STATE_UPDATES" | "SPEAK_TEXT" | "SPEAK_MESSAGE" | "STOP_SPEAKING" | "AUDIO_TOGGLE_SELF_DEAF" | "USER_SETTINGS_PROTO_UPDATE" | "USER_PROFILE_MODAL_OPEN" | "USER_PROFILE_MODAL_CLOSE" | "USER_REQUIRED_ACTION_UPDATE" | "CURRENT_USER_UPDATE" | "USER_SETTINGS_PROTO_ENQUEUE_UPDATE" | "USER_SETTINGS_PROTO_LOAD_IF_NECESSARY" | "IDLE" | "MESSAGE_REACTION_ADD" | "MESSAGE_REACTION_REMOVE" | "SIDEBAR_VIEW_CHANNEL" | "LAYER_PUSH" | "GUILD_FEED_ITEM_READ_ACK" | "STREAM_WATCH" | "STREAM_START" | "STREAM_CREATE" | "STREAM_UPDATE" | "STREAM_DELETE" | "STREAM_CLOSE" | "CALL_UPDATE" | "CHANNEL_UPDATES" | "MEDIA_ENGINE_VIDEO_STATE_CHANGED" | "RTC_CONNECTION_STATE" | "TYPING_STOP" | "TYPING_STOP_LOCAL" | "PREMIUM_REQUIRED_MODAL_OPEN" | "PREMIUM_REQUIRED_MODAL_CLOSE" | "OVERLAY_SET_INPUT_LOCKED" | "QUICKSWITCHER_SHOW" | "QUICKSWITCHER_HIDE" | "EMBEDDED_ACTIVITY_LAUNCH_FAIL" | "EMBEDDED_ACTIVITY_OPEN" | "EMBEDDED_ACTIVITY_CLOSE" | "EMBEDDED_ACTIVITY_INBOUND_UPDATE" | "EMBEDDED_ACTIVITY_DEFERRED_OPEN" | "RPC_APP_DISCONNECTED" | "STREAM_STOP" | "RUNNING_GAMES_CHANGE" | "MEDIA_ENGINE_SET_DESKTOP_SOURCE" | "MEDIA_ENGINE_PERMISSION" | "START_SESSION" | "CALL_CREATE" | "CALL_DELETE" | "AUDIO_TOGGLE_SELF_MUTE" | "AUDIO_TOGGLE_LOCAL_MUTE" | "PURCHASE_CONFIRMATION_MODAL_OPEN" | "PURCHASE_CONFIRMATION_MODAL_CLOSE" | "ANALYTICS_FEED_ITEM_SEEN" | "ANALYTICS_FEED_ITEM_UNSEEN" | "ANALYTICS_FEED_FLUSH" | "DRAWER_OPEN" | "DRAWER_CLOSE" | "EMBEDDED_ACTIVITY_FETCH_SHELF_SUCCESS" | "EMBEDDED_ACTIVITY_FETCH_SHELF_FAIL" | "INVITE_MODAL_OPEN" | "INVITE_MODAL_CLOSE" | "ACCESSIBILITY_SUPPORT_CHANGED" | "ACCESSIBILITY_COLORBLIND_TOGGLE" | "ACCESSIBILITY_SET_SATURATION";
owo
umbral hedge
hm?
umbral hedge
pain
umbral hedge
maybe we should map the string to a type (containing the data the event sends/receives)
and just get people to add them as they get used, rather than having lots of redundant ones
also jesus thats a lot
austere talon
i mean this is pretty useful
umbral hedge
true..
austere talon
and this
umbral hedge
i mean its not like it'll get compiled into prod so there isn't much harm
definitely put it in its own file though xdd
austere talon
i dont get one thing
umbral hedge
m?
austere talon
umbral hedge
i guess it treats "async" functions differently
austere talon
whats wrong here
idgi
why is it missing that prop
i will porobably just not the type
it pointless
umbral hedge
whats the type of Dispatcher.subscribe
charred monolithBOT
umbral hedge
that
austere talon
i just typed the event as any
no point typing that it has type property
not really useful
umbral hedge
true
austere talon
Hmmmm im really curious why Discord performs so poorly
central event handler that sequentially handles 1400 different events: 
umbral hedge
limber skiff
🤨
umbral hedge
nuckyz exploding prod
limber skiff
yes
charred monolithBOT
umbral hedge
moo
charred monolithBOT
austere talon
okay done i think
well besides
TODO: Type rest of components
if anyone wanst to help with that
charred monolithBOT
limber skiff
fixed in
charred monolithBOT
limber skiff
ultra poggers
charred monolithBOT
limber skiff
we love
austere talon
u will love fully typed components
charred monolithBOT
limber skiff
among
umbral hedge
39 commits
merging main into branch moment
solemn spoke
lol
charred monolithBOT
charred monolithBOT
crude hearth
we love broken webview version
same thing was causing my aliucord authorization thingy to crash
charred monolithBOT
charred monolithBOT
This adds a toggle switch to the Vencord settings next to the frameless window toggle that allows the user to make their client have a transparent background.
The point of this setting is for custom themes that make use of being transparent, an example of this is my own custom theme as seen here:
This that might be interesting to improve upon this is the ability to change th...
verbal pumice
Update README.md has to be the best feature added
charred monolithBOT
Discord Account
Aleister#3982
What happens when the bug or crash occurs?
Updated once again an hour ago and when i click on a reaction i dont see it highlighted as reacted and the number doesnt change but when I hover over it it shows i've reacted.
1 react (not mine):
2 react (reacted and it doesnt update)
fair mantle
bruh
woeful sable
co-authored-by fail
limber skiff
you gotta remove this from the end
charred monolithBOT
charred monolithBOT
pure ledge
i will review prs tmrw
h
charred monolithBOT
charred monolithBOT
somber ginkgo
waiting on merge 
rustic nova
doesn't discord store the size of gifs
thanks that helped
somber ginkgo
@austere talon merge 460 im dying
charred monolithBOT
charred monolithBOT
charred monolithBOT
woeful sable
limber skiff
@dapper tiger you will make it use friend nicknames on dms too
dapper tiger
how
also i didnt even know friend nicknames were a feature
i thought they were just abandoned experiment
limber skiff
they released it
I can help you test it if you need
add me, set a friend nickname for me and I will type for you
limber skiff
aight
dapper tiger
@austere talon whats !
limber skiff
non null assertion
dapper tiger
guildId could be null though
wouldnt it be better to not perform getNick when its null
limber skiff
yeah but I guess it will return undefined in that case
so you can just ignore it
idk that's ven suggestion
dapper tiger
guhh
dapper tiger
austere talon
yeah but I guess it will return undefined in that case
yes
it covers the case that guild id is null
charred monolithBOT
charred monolithBOT
umbral hedge
golden gulch
why in the world
verbal pumice
what the fuck why
dapper tiger
@austere talon i make plugin that uploads to file host
would you love
oh my god quit playing ow
addiction
dapper tiger
why
dapper tiger
try having no nitro for 48 years
austere talon
hop on sharex
somber ginkgo
sharex bad
hop on flameshot
dapper tiger
nop
somber ginkgo
hop on 
limber skiff
@austere talon guh you will merge https://github.com/Vendicated/Vencord/pull/460
limber skiff
EW AGAIN
dapper tiger
love
austere talon
<@343383572805058560> guh you will merge https://github.com/Vendicated/Vencord/p...
why didnt u figure it out with moment
wasnt moment literally made for this
limber skiff
It doesn't work
I spent an hour trying to do it with moment
No matter what settings I tried to apply it kept making 5 seconds turn into a few seconds
which is not what I want
austere talon
limber skiff
I don't want time like that
limber skiff
I want it to be 47 minutes and 18 seconds
limber skiff
moment can likely do it
Yes I know I looked at something called durations
and I as I said it refused to work the way I wanted
limber skiff
I still need to add commas and the "and"
like if something isn't exact it's gonna be for example 2 years, 4 months, 1 day, 5 hours, 7 minutes and 8 seconds
austere talon
var dur = wp.Common.moment.duration(182810281)
var didFunny = false;
console.log(["years", "months", "weeks", "days", "hours", "minutes", "seconds"].reduce((full, unit, i, arr) => {
const x = dur[unit]();
if (x > 0 || didFunny) {
if (didFunny)
full += unit === "seconds" ? ", and " : ", ";
full += `${x} ${unit}`;
didFunny = true;
}
return full;
}, ""))
just use this
2 days, 2 hours, 46 minutes, and 50 seconds
result
limber skiff
uhh to be honest I made chat gpt make it
I was lazy
ok hold on I will switch to it
austere talon
actually u dont need the didFunny
limber skiff
grr you aren't supposed to only add the and after seconds
austere talon
function formatTime(ms: number) {
const dur = moment.duration(ms);
return ["years", "months", "weeks", "days", "hours", "minutes", "seconds"].reduce((res, unit) => {
const x = dur[unit]();
if (x > 0 || res.length) {
if (res.length)
res+= unit === "seconds" ? ", and " : ", ";
res+= `${x} ${unit}`;
didFunny = true;
}
return res;
}, "")
}
it's supposed to always end with end
austere talon
wdym
limber skiff
2 hours and 1 minute
umbral hedge
wp.Common.moment().fromNow()
limber skiff
SO DUMB
limber skiff
let me turn on my pc
limber skiff
do a time that would output exactly 2 hours and 1 minute
austere talon
```js
function formatTime(ms: number) {
const dur = moment.duration(ms);
ret...
idk if this is fully correct but probably
limber skiff
🤨
austere talon
if u dont want the 0 seconds u can just alter it
but it feels weird to have gaps
like 2 weeks and 3 minutes would feel weird imo
i prefer 2 weeks, 0 days, and 3 minutes
limber skiff
aight
limber skiff
I will make one simple change to only add s if it's different than 1
limber skiff
yeah
eh can you do it for me and change on my branch
it's probably faster than me doing it
austere talon
function formatTime(ms: number) {
const dur = moment.duration(ms);
return ["years", "months", "weeks", "days", "hours", "minutes", "seconds"].reduce((res, unit) => {
const x = dur[unit]();
if (x > 0 || res.length) {
if (res.length)
res+= unit === "seconds" ? ", and " : ", ";
res+= `${x} ${x === 1 ? unit.slice(0, -1) : unit}`;
didFunny = true;
}
return res;
}, "")
}
ok sure
umbral hedge
then merge it
never
limber skiff
```js
function formatTime(ms: number) {
const dur = moment.duration(ms);
ret...
oop you left a didFunny there
umbral hedge
umbral hedge
function(props) {
const { x, y, z } = props;
}```0
umbral hedge
the 0
limber skiff
😰
austere talon
im fixing rn
const { foo: { bar } = {} } = {}
jumpscare
it dosnt work for voice channels
@limber skiff
umbral hedge
umbral hedge
austere talon
bro i cant find a channel to test formatDuration
austere talon
because you're misusing react
you should never call react components as plain functions
it will break hooks and other things
limber skiff
austere talon
always use React.createElement or jsx
austere talon
btw the asset url is safe to use
the path is just md5 hash of the file
so stable
umbral hedge
limber skiff
It did change once
limber skiff
that's why I kept a comment saying exactly where it is found
austere talon
jumpscare
btw this is how it will look if it errors
not pretty but not worth it to make it look better
I removed the noop
limber skiff
aight
austere talon
cause error info is more useful than nothing rendered
limber skiff
true
austere talon
I would only noop if it's either not very relevant (not in the foreground, like a button in the chat bar) or very small so having a codeblock would be ugly
limber skiff
👍
charred monolithBOT
cunning bobcat
github mail trolls again
golden gulch
if only discord was decent and supported multi level blockquotes
cunning bobcat
you say that, as if anything with discord is decent
limber skiff
ain't no way
I swear why does when I test it everything works correctly
what I changed about it shouldn't have changed the functionality
@austere talon I will cry discord does not like to show me the issues when I test
I didn't touch the path?
🤨
lmao I don't know how that happened
austere talon
u will fix
austere talon
has someone tested https://github.com/Vendicated/Vencord/pull/450
it looks good mostly
but testing that kinda pain
limber skiff
thanks
austere talon
bad
austere talon
uh
mm
u will fix
why didn't it cut off hours and minutes
epic regex fail
Also wtf is 1 week 7 days lmao
limber skiff
it's all broken
charred monolithBOT
somber ginkgo
502'd
austere talon
github needs to stop doing this man
spark cove
github needs to 502 internally so that *** turns into real token
charred monolithBOT
pure ledge
please speedrun merge 🙏
austere talon
could just use permament notification then
see pr i just opened for what it will look like approximately
austere talon
well its not done yet
pure ledge
when its done then
solemn spoke
i wonder why a notification API if discord has a toast api
solemn spoke
i wonder why a notification API if discord has a toast api
considering even more that it accepts custom components
austere talon
it sucks
austere talon
green
austere talon
WDYM IT STILL FAILED
spark cove
oh wait thats line number
same
charred monolithBOT
umbral hedge
soon: "changed font to best font - Vendicated"
best font being https://github.com/MeguminSama/megufont
woeful sable
Your mom
spark cove
i think i was anticipating other things to be dismissable but
spark cove
not neede
spark cove
/* eslint-disable consistent-return */
i can prob remove this
if i merge
cus ven sent that rule to oblivion
umbral hedge
lerp
charred monolithBOT
charred monolithBOT
charred monolithBOT
frail skyBOT
frail skyBOT
charred monolithBOT
solemn spoke
ig he meant which installed version of discord he should install Vencord to
austere talon
why the hell is this here
Problem? 
jagged cloak
users when they forget this is venchOrd server first and Vencord second
cunning bobcat
i just linked a bunch of my stuff
me omw to star and fork all your repos
umbral hedge
charred monolithBOT
charred monolithBOT
VencordInstaller.exe
charred monolithBOT
seems like the "this song won't be playable" doesn't work for albums
it is also not very intuitive right now, so a tooltip might also help
also idk what happened here but
charred monolithBOT
solemn spoke
argh. i was about to answer it and then it was closed
anyways, heres my planned answer: its not "why you can run with sudo", it is "why you HAVE to run with sudo". discord and other programs (and flatpaks installed without the --user flag) are stored in a folder on the root of the directory, that needs sudo to access, meaning that no apps can be installed, edited or removed without sudo. on windows it is stored in AppData _(mostly)_, a place inside the user's directory.
spark cove
TRUEE
solemn spoke
why does that webhook (i assume)
sends daily reports
instead of just doing their reports in github or smth
and doing when a commit is sent
so it doesn't spam this channel
spark cove
so that it catches discord updates
woeful sable
no it does that every so often to see if there are any updates needed
solemn spoke
ah
wait what?
wdym by updates?
like if it does an check at a specific time to see if the patches are still working on the latest changes to discord
limber skiff
changes to discord code that broke our plugins
solemn spoke
like if it does an check at a specific time to see if the patches are still work...
or if there is some internal client that needs to be updated every so often
spark cove
like if it does an check at a specific time to see if the patches are still work...
idk if its a specific time but its every so often
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/main/.github/workflows/reportBrokenPl...
**reportBrokenPlugins.yml: **Lines 1-6
name: Test Patches
on:
workflow_dispatch:
schedule:
# Every day at midnight
- cron: 0 0 * * *
ah
charred monolithBOT
limber skiff
what if we make richerCider depend on timebarallcomponents
so it applies that patch too
maybe turn that into an api 
charred monolithBOT
charred monolithBOT
charred monolithBOT
woeful sable
@austere talon what if I supersede that PR by a plugin that lets u change activity types or names of any activity
cuz I literally use the latter already
charred monolithBOT
pure nexus
<@191621342473224192> what do u think
We're primarily making this to expand on later with Cider 2.x as we wanna add a few more things to it once we're ready to implement
We have animated artwork being worked on for RPC so that'll make the cut in there for example, we also want to add our own similar “Spotify Embed” and playback controls down the road.
charred monolithBOT
charred monolithBOT