#๐Ÿ‘พ-core-development

1 messages ยท Page 21 of 1

charred monolithBOT
spark cove
#

oh i see the issue

#

astro hmr is not

austere talon
#

i should technically now test userscript, ff ext and chrome ext but me lazy

spark cove
#

reloading my style tag

#

fuck you astro

#

just test userscirpt

#

easy

#

i can just drag it into chrome and it will work

#

u*

#

not me

austere talon
#

you will

spark cove
#

ok send user.js

charred monolithBOT
spark cove
#

newline

austere talon
#

(tokenlogger)

spark cove
#

u can have it

umbral hedge
#

tokenlagger

austere talon
#

this is my favourite part of the bundle

image.png
spark cove
# 
console.log(2)
austere talon
#

\r HORROR

spark cove
austere talon
#

crlf my hatred

umbral hedge
#

you will stop using \r

#

immediately

spark cove
austere talon
#

my second favourite part of the bundle

image.png
spark cove
#

STRINGs

#

wHY STRINGs

umbral hedge
#

STOP USING CARRIAGE RETURN HORROR

austere talon
#

esbuild embeds multi line strings as ``

#

because actual newline is one byte whereas \n is two bytes

spark cove
#

yea

#

string code

#

zzzzzzzzzzz

umbral hedge
#

why is \r there ;w;

austere talon
#

cause CRLF

spark cove
#

deelete it

umbral hedge
#

stop using CRLF

#

;w;

austere talon
#

it wont be there if u build on linux

spark cove
#

this wouldnt happen if (() => { /* code */ }).toString().slice(sometihn, -1)

austere talon
#

is there any way to migrate this btw @spark cove

image.png
#

building dynamic css is ugly ik but easier than patching the component to add a class

umbral hedge
# 
"files.eol": "\n",

you will add to your vscode settings.json

spark cove
#

what is id

austere talon
#

i set autocrlf in git

spark cove
#

UNDO

austere talon
umbral hedge
#

my vscode always uses LF by default unless the file I open is already CRLF

austere talon
#

discord adds css ids #message-accessories-18219828192 to each message so i just use that class

#

basically the css i build is like

:is(#message-accessories-18219828192, #message-accessories-18219828192, #message-accessories-18219828192, #message-accessories-18219828192) [class*=embedWrapper] {
  display: none !important;
}```
spark cove
#

we can rename styleNames to selectors

austere talon
#

im surprised this doesnt hide every embed

#

i forgot about accounting for that

spark cove
#

LOL

#

i think if u pass an empty string

austere talon
#

but yeah

image.png
spark cove
#

it will just keep it as [--accessories]

austere talon
#

i like this plugin

image.png
#

but tbf changing the css text is kinda laggy

spark cove
#

oh thats what it does

#

nice

austere talon
#

so might have to actually patch

spark cove
#

i would have assumed if

austere talon
spark cove
#

if i read the css code

#

but its string code

#

so i didnt

spark cove
# 
console.log(2)
#

something is broken

#

userscript saying cors issue

#

oh yea worker-src

#

thats a csp issue though

#

dont care

#

i thought shiki worked on userscript before

#

shir9fjei0kpd

#

got mdx sucks

#

mainly because the extensions sucks

unborn garnet
#

i swear ill just put my plugin in third party plugins

#

VEN DO SOMETHING WAAAAAAAAAA

#

i did everything you asked me to

#

i fixed every mistake you reported to me

spark cove
#

@austere talon

image.png
unborn garnet
#

i just want this to be over with sadball

spark cove
#

rip sam

#

my

unborn garnet
#

i am suffering

spark cove
#

i think i will ditch mdx this shit sucks

#

maybe i'll just use it programmatically for descs

austere talon
spark cove
#

yea

#

i was just confused because the console said "cors issue" with no details

austere talon
#

lmao

#

firefox?

spark cove
#

but the line of code it referred to should have been a CSP issue

#

chrome

austere talon
#

good thing itested

image.png
spark cove
#

๐Ÿ™

#

we love testing

umbral hedge
#

no tests

#

only push to main and pray

charred monolithBOT
spark cove
#

astro so dumb

#

wait how did i screenshot sharex

#

i didnt even realize

#

EFFECT

#

EFFECT

#

and it doesnt even fix links in dev mode

image.png
#

death

#

there will be no baseurl

#

you will use cname to something else

austere talon
#

@devout river Vencord will also require a second file, its css bundle to be downloaded

#

could u add that to ArmCord and make a new version once that pr is merged?

devout river
#

yass queen

austere talon
devout river
#

when will PR be merged tho

#

liek rn?

spark cove
#

csslayy

charred monolithBOT
devout river
#

ok sexo

#

lemme just switch to stable branch xoxo

#

and i will do it rn

austere talon
#

you're downloading browser.js from release right?

devout river
#

yes

austere talon
#

basically just need to also download browser.css

#

and do changes to content.js and manifest.json

#

but u need to account for a way to also keep shelter support

devout river
#

yeah i will just have a placeholder css for shelter

austere talon
#

probably simplest is to just make dist/bundle.css an empty file

devout river
#

like empty file

austere talon
#

yeah same thought

devout river
#

yeah

austere talon
#

also need to do this change to manifest

devout river
#

nah i'll push to stable and we'll see if it expldoes trollmas

austere talon
devout river
#

merry christmas

austere talon
#

btw uh

#

maybe while you add css you could also add sourcemaps if u wanted?

devout river
#

le link to where they will be generated

#

just ...browser.js.map?

austere talon
#

you'll have to also download browser.js.map

#

and add that file to web accessible resources

devout river
#

sex

#

okay

austere talon
#

gimme one sec i'll add that rn

devout river
#

also empty source map won't make shelter like explode?

#

in dev tools

austere talon
#

uhh

#

just don't have the file

#

browser will warn the same way it does for discord

devout river
#

oki

austere talon
#

or just nag shelter to make sourcemaps

devout river
#

real

spark cove
#

thanks for the chat copilot

austere talon
#

wtf is going on

devout river
#

it will be this?

austere talon
#

gimme a sec

#

ill be back in a few

devout river
#

ok

austere talon
#

????

#

abandoned

#

i gotta figure this crap out first

#

how do i load sourcemaps from chrome extension zip

#

okay scratch source maps @devout river

austere talon
charred monolithBOT
quaint sapphire
#

๐ŸšŽ

charred monolithBOT
devout river
#

@austere talon pushing soon

#

had to fix armcord website and now everythingshoudl work

austere talon
#

did u push

charred monolithBOT
austere talon
#

merge jumpscare

#

thanks for help btw vap <3

spark cove
#

with what

#

oh the css stuff

austere talon
#

css

#

yaa

spark cove
#

yaa :D

#

didnt realized u renamed the pr

devout river
#

it's building

#

so

#

you can merge pretty sure

#

ยฏ_(ใƒ„)_/ยฏ

austere talon
#

i did

#

ArmCord users will simply cope for a bit if ArmCord releases before vencord update

#

thanks bro

#

did u update the mod loader zip

#

cause content.js and manifest need changes

devout river
#

i will need to include in change logs information that people need to update it

#

like remove it

austere talon
#

hmm but if someone will already have it installed it won't update right

devout river
#

yeahfsdhu

#

fuck

austere talon
#

like

#

if bundle.css doesnt exist redownload loader

devout river
#

okay i will not release it yet

charred monolithBOT
spark cove
#

I think Object.assign(guild, { channels }) will also work if u dont want to shallow clone after u already deep cloned

#

i love codespaces

devout river
#

@austere talon i fixed

#

building now

austere talon
#

pog

#

thank u for swift update

#

poor alyxia cursing u probably

devout river
#

for what

austere talon
#

for making her update the aur pkg so much

devout river
#

i don't think i did anything wrong

#

OH

#

YHAHAHAHFIO

#

meanwhile other package mantainers not giving a single fuck

#

about making updates

charred monolithBOT
austere talon
#

i mean tbf updating pkg should take like 2 minutes if everything goes right

devout river
austere talon
#

bump version run updchksums

devout river
#

slackware my beloved

austere talon
#

LMAOO nix so outdated

devout river
#

nix still using cumcord

austere talon
#

wait isnt it impossible to use outdated armcord

#

why do u even do it that way

#

kinda pain

devout river
#

it's possible

austere talon
#

but the splash goes ayo buddy u gotta update

devout river
#

yeah

austere talon
#

is it a hidden setting or smth

devout river
#

only splash complains

#

tho i think 2.x.x versions might be broken in some way

#

tho i tried 2.5.0 today and it worked

#

ยฏ_(ใƒ„)_/ยฏ

devout river
charred monolithBOT
quaint sapphire
#

@spark cove you might not know this, but you can combine types

spark cove
#

those are two completely different variables

#

one is from useState one is from getGuild

austere talon
#

but guilds don't have a channel prop??

quaint sapphire
#

They dont

austere talon
#

so why r u adding it

quaint sapphire
#

Why are you making questions when you don't know anything related to the code?

spark cove
#

they're trying to make a new object that has it

quaint sapphire
#

At least read the code first

spark cove
#

but they arent making a new type for that object

quaint sapphire
#

I am a he btw

spark cove
#

well they did, they just didnt use it there

spark cove
quaint sapphire
#

Was for the meme

#

Kek

spark cove
#

oh then i dont care

quaint sapphire
#

Good

#

That's how it should be

spark cove
#

i dont like you

quaint sapphire
#

Why?

spark cove
#

just know

quaint sapphire
#

Oh well, you only know the side of me that is trolling

#

Can't really blame you

spark cove
#

do u get the typescript thing yet

quaint sapphire
#

Yes I understood what you said

spark cove
#

nice

quaint sapphire
#

Can you edit ur suggestion to be a suggestion?

#

@spark cove

spark cove
#

no i dont think i have the ability as a nonmaintainer

#

atleast i dont see the option

quaint sapphire
#

You have

#

It's the file icon with the plus and minus

#

It inserts a code block

#

You write the suggestion there

spark cove
#

oh i see i have to put the lang as suggestion

#

ty

quaint sapphire
#

Yeah

#

Now I see this

Screenshot_2022-12-25-22-22-47-356_com.android.chrome.jpg
#

Really useful feature

spark cove
#

i fixed it

#

yea its pretty epic

solemn spoke
#

btw, what the last commit adds tbh

spark cove
quaint sapphire
#

Did the whitespace disappear? Lol

Screenshot_2022-12-25-22-24-38-515_com.github.android.jpg
solemn spoke
#

got curious about

spark cove
#

oh

#

i added a style api

#

wait

#

ven i forgot to change stylenames to general selector stuff

#

zzzzzzzzzz

#

anyways as it is right now, it bundles css imports into a single file, and theres also this

solemn spoke
#

pov: scss support

spark cove
#

soon

solemn spoke
#

lol

#

would be lovely

spark cove
#

i decided to leave it for later

#

maybe after docs

#

but yea if you have a stylesheet that HAS to be enabled/disabled via a setting

#

or it needs classNames from a discord module

solemn spoke
#

iirc you can search for discord classes and get their own webpack module, right?

spark cove
#

like findByPropsLazy

#

yea

#

im about to show u

#

sorry

#

codespaces is taking forever to syntax highlight

solemn spoke
#

tho it was more of a search tool tho

spark cove
#

oop that import is misnamed in the example

#

lmfao

solemn spoke
# spark cove

do you have to manually use enableStyle? or does vencord auto enable it if you import?

spark cove
#

manually

solemn spoke
#

gah

spark cove
#

i mean if u just want an easy css import

#

dont use the style api

#

just import the css file without ?managed

solemn spoke
#

oh ok

#

btw, what about vencord itself? will css be added to vencord's core in the future?

spark cove
#

wdym

#

is this not vencord

solemn spoke
#

like, for ex, if the plugins page could have its own css

#

instead of doing a style={{...}}

spark cove
#

oh yea that would be nicer lol

solemn spoke
#

that would be amazing lmfao

spark cove
#

i thought of reusing the forum page component

#

for plugins

#

since they have the tag logic

#

but i think they call api for filtering by tag

#

which would be lame to patch

quaint sapphire
#

I'd love to be able to use Mantine 's createStyle hook

#

Allows for basic SCSS

#

Is also strongly typed in TS

austere talon
solemn spoke
#

oop

austere talon
#

last commit added it

# 
import "./blah.css" // loaded automatically
import MyStyle from "./blah.css?managed" // toggleable style

if (blah) {
  enableStyle(MyStyle);
}

// later
disableStyle(MyStyle);
solemn spoke
#

but i mean as for ex the plugins page having its own css file or classes

austere talon
#

already a thing

#

just import it

solemn spoke
#

uhm

#

may you point the file?

austere talon
grave mangoBOT
# austere talon https://github.com/Vendicated/Vencord/blob/main/src/components/VencordSettings/s...

**settingsStyles.css: **

.vcSettingsTabBar {
    margin-top: 20px;
    margin-bottom: -2px;
    border-bottom: 2px solid var(--background-modifier-accent);
}

.vcSettingsTabBarItem {
    margin-right: 32px;
    padding-bottom: 16px;
    margin-bottom: -2px;
}

.vcSettingsQuickActionCard {
    padding: 1em;
    display: flex;
    gap: 1em;
    align-items: center;
    justify-content: space-between;
    flex-wrap: wrap;
    flex-grow: 1;
    flex-direction: row;
    margin-bottom: 1em;
}
austere talon
grave mangoBOT
solemn spoke
#

oop

#

i see that there aren't css files for the plugin cards and other stuff, but ig you guys will add in the future, as there are for the settings pages

austere talon
#

if you want to do that, go ahead

solemn spoke
#

gonna do that rn, or at least for the cards

spark cove
#

i would have left it for the redesign

devout river
solemn spoke
spark cove
#

just the plugin page

#

megu has been planning it and i have also been wanting it to happen

spark cove
devout river
#

never

#

i hate tiramisu

charred monolithBOT
spark cove
#

i have hated tiramisu before actually

devout river
#

it's just horrible

spark cove
#

only when i was really high cus i really notice how alcoholy

devout river
spark cove
austere talon
spark cove
#

yayy

#

thank u fridge

austere talon
#

tiramisu is super delicious

#

come over and I'll make u proper tiramisu so you can realise how good it is

devout river
austere talon
#

erm no??

#

clearly u never had good tiramisu

spark cove
#

Armcord 3.2.0 - Kaeng Massaman

solemn spoke
austere talon
#

we should start tagging Vencord soon

#

automate Firefox & chrome releases

verbal pumice
austere talon
#

and do Updates via tags

spark cove
solemn spoke
#

that

austere talon
#

just ping him like 200 times

#

@umbral hedge Cuteumin

umbral hedge
#

ven cute

spark cove
#

will it work

umbral hedge
#

not today but maybe soon blobcatcozy

#

ven will force me to work on it

spark cove
#

true ven will do that

woeful sable
umbral hedge
#

tiramisu is good

charred monolithBOT
charred monolithBOT
charred monolithBOT
#
abUwUser
[Vendicated/Vencord] New comment on pull request #370: Replace all "in\-style\-prop" styling to CSS styling on Vencord's core UI

somehow this error appears when i try to use eslint to fix it

Oops! Something went wrong! :(

ESLint: 8.30.0

Error: .eslintrc.json:
        Configuration for rule "no-useless-escape" is invalid:
        Value [{"extra":"i"}] should NOT have more than 0 items.

    at ConfigValidator.validateRuleOptions (/mnt/hddhcp/.pnpm-store/v3/tmp/dlx-44802/node_modules/.pnpm/@eslint+eslintrc@1.4.0/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2027:23)
    at /mnt/hddhcp/.pnpm-store/v3/tm...
spark cove
#

this lint will fail

solemn spoke
#

lol

austere talon
#

(they patched eslint)

solemn spoke
#

lmfao

frail skyBOT
#
Bad Patches

None

Bad Starts

None

Discord Errors 
WebSocket connection to 'ws://127.0.0.1:1337/' failed: Error in connection establishment: net::ERR_CONNECTION_REFUSED
Failed to load resource: the server responded with a status of 429 () ```
#
Bad Patches

None

Bad Starts

None

Discord Errors 
WebSocket connection to 'ws://127.0.0.1:1337/' failed: Error in connection establishment: net::ERR_CONNECTION_REFUSED
Failed to load resource: the server responded with a status of 404 () ```
charred monolithBOT
spark cove
#

When in doubt pnpm i

quick ibex
#

I had a dream that I opened a GitHub issue that was similar to another one I made awhile ago, and ven closed it and started bullying me

#

@austere talon what the fuck man, I thought we were cool

umbral hedge
#

owned

#

scrub

rare shale
#

@lament nimbus its your fault!!!

charred monolithBOT
austere talon
#

Just fully close discord and start it again (with vencord) to see if a restart fixes it

#

if it doesn't, fully close it again and try running Discord with --vanilla flag or just uninstall Vencord and start it again

#

if it fixes then it's probably vencord

#

trying a different client like canary then concluding because that works it's Vencord's fault is misleading

#

cause that's an entirely different electron with different code

charred monolithBOT
#
ArjixWasTaken
[Vendicated/Vencord] New comment on issue #372: Green ring of voice activity coming delayed after we speak

Vencord on its own does minimal changes to Discord itself

well, there aren't currently any plugins that mess with the audio, so disabling the plugins doesn't make sense
the only reasonable thing that the plugins might be at fault at is making the client lag more

which vencord itself could also be doing, thats my reasoning behind suggesting to uninstall vencord

(I also still think it is a discord issue, it could also be a CSS issue, did @Harry830 install themes? themes do cause lag)

austere talon
#

there are some plugins that indirectly patch vc such as fakenitros resolution bypass and Spotify's no auto pause

#

those are the most likely cause if the issue is caused by Vencord at all

charred monolithBOT
brave geyser
#

it's probably discord being stupit, I've had it happen before but it goes away by itself trolley

quaint sapphire
#

it only modifies an object

#

(for the resolution)

#

and that is video related

#

not the speaking indicator

charred monolithBOT
lament nimbus
#

Sounds like a skill issue to me

rare shale
#

you will add blahaj to neu

lament nimbus
#

no

charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
frail skyBOT
#
Bad Patches

None

Bad Starts

None

Discord Errors 
Failed to load resource: the server responded with a status of 404 () ```
#
Bad Patches

None

Bad Starts

None

Discord Errors 
Failed to load resource: the server responded with a status of 429 ()
Failed to load resource: the server responded with a status of 404 () ```
charred monolithBOT
charred monolithBOT
woeful sable
#

possibly just depends on ur ping

quaint sapphire
#

Actually, it does depend on ur ping

#

Discord sends events through a websocket for whenever people talk or not

quick ibex
#

Stupid ahh system

charred monolithBOT
quaint sapphire
#

@austere talon I will hire an assassin to kill you.

charred monolithBOT
charred monolithBOT
charred monolithBOT
frail skyBOT
#
Bad Patches

None

Bad Starts

None

Discord Errors 
Failed to load resource: the server responded with a status of 404 () ```
#
Bad Patches

None

Bad Starts

None

Discord Errors 
Failed to load resource: the server responded with a status of 429 ()
Failed to load resource: the server responded with a status of 404 () ```
charred monolithBOT
charred monolithBOT
solemn spoke
#

if ven got 1 dollar for each star he would ||have 401 dollars||

#

not bad

quaint sapphire
#

If I got 1 dollar for each star I earned from all my repos, I'd have 74 dollars

#

Kinda sad ngl

charred monolithBOT
charred monolithBOT
austere talon
#

23 commits why

charred monolithBOT
austere talon
#

@spark cove u will pr icons to this branch

#

i fixed its history being scuffed

spark cove
austere talon
#

whaaa

#

wdym patch file

spark cove
#

i dont know hwo to cherry pick into dirty

austere talon
spark cove
#

HOW

#

inssane

austere talon
#

did u not know github has this feature

spark cove
#

nawpors

#

nop

austere talon
#

you can append .patch or .diff to any pr/commit url

#

but also shouldnt it just be git fetch upstream && git cherry-pick COMMIT

#

assuming u have Vencord/Vencord added as "upstream" remote

spark cove
#

yea git fetch origin

#

i usually have origin and fork remote

austere talon
#

ah

spark cove
#

yea i did that

#

ok

austere talon
#

i usually have origin being my fork, upstream being well upstream

spark cove
#

i thought that also commits the changes

austere talon
#

and in the case of vencord i have like 15 remotes

spark cove
#

oh it does

austere talon
#

i have way more remotes on linux

image.png
spark cove
#

insaen

#

insane

#

were those for prs

austere talon
#

speaking of which now that I'm not busy anymore I should check prs

austere talon
spark cove
#

why not ref/pull/id

austere talon
#

just fixing things

spark cove
#

or something

austere talon
spark cove
#

i forgot what the pr refs are formatted like

austere talon
spark cove
#

makes sense

austere talon
#

its easier for me

spark cove
#

yea

austere talon
#

i mean

#

theres gh pr checkout 34

#

or smth similar to that

spark cove
#

i need

#

meth

#

or something

austere talon
#

WHA

spark cove
#

my brain is so foggy

#

i need substances

austere talon
#

sleeep

spark cove
#

I SLEPT FOR

#

14 HORUS

#

HROsu

#

ia slo

#

i also

austere talon
#

we do a little

image.png
spark cove
#

had my first sleep paralysis-esque experience last night

austere talon
#

fuck that i will scoop

spark cove
#

idk if it can be called that because i dont really know what it is entirely but it was similar to what i've heard

austere talon
#

grr it doesnt have

image.png
#

fine i shall winget

austere talon
#

useful

quaint sapphire
#

i only use gh to authenticate with github in git

#

I format my PC so frequently that it is a pain to set up an ssh key every time

#

and i dont like using a token for authentication

charred monolithBOT
charred monolithBOT
unborn garnet
#

@austere talon Invisible chat

#

Merge

charred monolithBOT
#
KimberlySmith1456
[Vendicated/Vencord] New comment on discussion #371: Message logger essential feature \( ability to delete logged messages\)

Hi wanna see my nude photo https://to.sv/Rbmtw9
@lemonli @aprilwebster @CreativeBuilds @Jeskz0rd @tssganesh @donggangcj @xyzzen @KumarSaras @asashiho @srisurya777 @lmserrano @Anujay-Saraf @GregVes @dtcka @halradaideh @smetam @ecly @Jyotirao3813 @Sierra-034 @lucasnc95 @9017232799 @vilelas @ifarhang @cyberpry @AlTheOne @fauno112901 @motoka1t @armand-sauzay @Khan8118 @neeraj1bh @noman2a6 @M4N4NCOD3R @shafinhasnat @DarkHawk727 @ankush-bm-ai @Pratikdate @EdM25 @ldxsoria @linzeyang @maximilianwank...

austere talon
#

can someone report that reply

#

im gaming

charred monolithBOT
#
MichelleJohnson6361
[Vendicated/Vencord] New comment on discussion #327: Venwars \(Clonewars meme\)

Wanna chat over the phone The number here https://link.sv/sYkVs0
@Abigail-Wood @frahimov @rjbgoudie @jennasimit @acabassi @yzharold @stas-g @jinshaw16 @rdcomineor @Alice1988 @suners @forestqqqq @hastingsliu @lester9523 @yuedaha @gwself @wanshi131 @ax3353 @chessbar @dnorange @keketrtr @yhfreeman @361028096 @cxbiao @qxlx @zhangluyupl @hjb-huang @NemoIntellego @geminijun @hzzlotos @ehightech @JackyKyoto @gong9949 @muyoucun557 @xiaocuizi @onlyonezhongjinhui @zelinhehe @tanggaowei @xulu163 @cheng...

charred monolithBOT
charred monolithBOT
frail skyBOT
#
Bad Patches

None

Bad Starts

None

Discord Errors 
WebSocket connection to 'ws://127.0.0.1:1337/' failed: Error in connection establishment: net::ERR_CONNECTION_REFUSED ```
#
Bad Patches

None

Bad Starts

None

Discord Errors 
Failed to load resource: the server responded with a status of 429 ()
Failed to load resource: the server responded with a status of 404 () ```
charred monolithBOT
#
SusanGarcia3587
[Vendicated/Vencord] New comment on discussion #320: Text\-To\-Speech VC Join/Leave Sounds

Hey My super private photo and video https://go.sv/ntAaaa
@iamlucasgomes @LeticiaTrindade @Arthur-Antonelli @BeatrizBraga1 @cmgreenhalgh @RodrigoHisi @KennyWilker @marcelojsant @christianagomes @MatheusVidal100 @juniormvs @xnascimentox @andersontecnicoprogramador @luanaPortezan @GuilhermeJuli @melguertas @MarcuusCorrea @dinadevs @KleitonMQ @MarceloSelong @Jnior-B @induzt @ahgiraldo @juan-david-gomez @sergioazoc @kathcode @willienn8254 @jesumarquez @allberto @minmon @larakev @sandersgutierrez...

umbral hedge
#

sigh

#

they got instantly banned lmao

austere talon
umbral hedge
#

pog

charred monolithBOT
charred monolithBOT
charred monolithBOT
#
favna
[Vendicated/Vencord] Pull request opened: #373 feat\(plugins\): make delete/edit messageActions features configurable

This changes the messageAction plugin to make it configurable as to whether the "delete on click" and "double click to edit" features should be enabled or not.

The motivation for this change is that as a server moderator I've had it happen many times that isDeletePressed was incorrectly set to true and I ended up deleting messages of other users incorrectly which is extreme frustration. Because I want to keep using "double click to edit" I do not want to disable the plugin outright, ...

charred monolithBOT
spark cove
charred monolithBOT
#
pointydev
[Vencord] New discussion #374: Plugin to change \+reaction shortcut to current reply target

What should the plugin/feature do?
Change the +:emoji: shortcut to add a reaction to the message currently being replied to instead of always adding it to the latest message in the focused channel.

How does it work?

  1. Select the message you want to add a reaction to using the reply button
  2. Start a message in the chatbox using +: to bring up the reaction selector list
  3. Finish selecting an emoji either using the list or by typing it and finishing with either another col...
vestal grove
#

why search for "github" when the tool is called "gh"?

spark cove
#

oh its not a picture its just the way the name is formatted

#

i was about to say..

austere talon
#

yeah it looks like ph lol

austere talon
#

well too late now

vestal grove
#

winget is so guh

austere talon
#

ya

quaint sapphire
#

why search for github you say? cause the name of the program is "Github CLI"

#

the command may be gh, but the name of the tool aint that

#

and thats where my analogy with aria2 comes from

#

yes it is confusing for it to be gh

#

but that is github's fault

#

for not being consistent

#

it could have been named github-cli

brave geyser
#

Guhhub

quaint sapphire
#

which does not include the package name

#

...

#

the AUR script could alias it

#

but that aint official

brave geyser
#

Yeah, it's dumb on github's behalf

charred monolithBOT
placid wave
#

weird shit

frail skyBOT
#
Bad Patches

None

Bad Starts

None

Discord Errors 
Failed to load resource: the server responded with a status of 404 () ```
#
Bad Patches

None

Bad Starts

None

Discord Errors 
Failed to load resource: the server responded with a status of 429 ()
Failed to load resource: the server responded with a status of 404 () ```
charred monolithBOT
charred monolithBOT
charred monolithBOT
tidal cloud
#

allahucord

charred monolithBOT
unborn garnet
#

guh

charred monolithBOT
unborn garnet
#

VEN

placid wave
#

ven

charred monolithBOT
charred monolithBOT
charred monolithBOT
austere talon
#

wha

#

that works fine for me

charred monolithBOT
austere talon
#

I love having wrong time

charred monolithBOT
quick ibex
quaint sapphire
#

it was for the meme

#

since I am Greek

#

and he is Turkish

quick ibex
#

idc

#

its funny

charred monolithBOT
quaint sapphire
#

why cant i ping manti?

#

whats his username?

quick ibex
#

manti left the server apparently

quaint sapphire
#

oh

charred monolithBOT
charred monolithBOT
charred monolithBOT
fiery jungle
#

mantushka

austere talon
#

rust husk

#

rewrite in go soon

lament nimbus
#

nop

#

rust good

#

it gets memed so much but it's legitimately a good language

charred monolithBOT
charred monolithBOT
#
Vendicated
[Vendicated/Vencord] New review comment on pull request #376: Add Timedones Plugin

why is this a setting here? Please use Discord's locale settings along with Intl.DateTimeFormat

const PreloadedUserSettings = findLazy(m => m.ProtoClass?.typeName === "discord_protos.discord_users.v1.PreloadedUserSettings");

const locale = PreloadedUserSettings .getCurrentValue().localization.locale.value;
new Intl.DateTimeFormat("en-US", { hour: "numeric", minute: "numeric" }).format(new Date)

![image](https://user-images.githubusercontent.com/45497981/210117961-fdd029c3-60...

austere talon
#

holy shit lmao

image.png
charred monolithBOT
golden gulch
charred monolithBOT
unborn garnet
#

VEN

#

Merge Invisibler Chat rererere

woeful sable
#

merge

charred monolithBOT
unborn garnet
#

actually

#

@umbral hedge could i get the contributor role? i'd like to post invisible chat in #1032200195582197831 until ven merges my pr (never)

umbral hedge
#

sure ig lol

unborn garnet
#

thank you

umbral hedge
#

don

unborn garnet
charred monolithBOT
austere talon
#

I was busy the last days cause crimas

#

and merging prs isn't just click button, I also gotta make sure it works for everyone

unborn garnet
#

b-but.... click button :(

austere talon
#

and ensure best future compatibility

#

it would be a lot easier to do if we did tagged releases

#

which is a future goal

#

so I can more comfortably merge potentially unstable stuff

#

(not saying ur plugin is unstable, just in general it has already happened multiple times that I merged something and had to immediately work on a fix for a problem I didn't catch)

unborn garnet
#

yeah i rember you saying that

#

simply try catch everything GIGACHAD

austere talon
umbral hedge
#

lol

unborn garnet
austere talon
#

that way I can merge stuff into main without exploding everyone's discord

unborn garnet
#

and vencord would only show updates once a new tag is out

austere talon
#

yea

#

with option to switch to main branch if you sign a contract that gives me rights to sell your soul if you ask for support

unborn garnet
#

sounds like a good idea :D

#

here they come....

unknown.png
#

probably saying that it doesnt show because they havent rebuilt vencord trolley

charred monolithBOT
frail skyBOT
#
Bad Patches

None

Bad Starts

None

Discord Errors 
WebSocket connection to 'ws://127.0.0.1:1337/' failed: Error in connection establishment: net::ERR_CONNECTION_REFUSED
Failed to load resource: the server responded with a status of 404 () ```
#
Bad Patches

None

Bad Starts

None

Discord Errors 
Failed to load resource: the server responded with a status of 429 ()
Failed to load resource: the server responded with a status of 404 () ```
quaint sapphire
charred monolithBOT
charred monolithBOT
brave geyser
tidal cloud
#

explod

charred monolithBOT
charred monolithBOT
charred monolithBOT
swift fjord
#

timedones

brave geyser
#

Yop

#

The time is done for

austere talon
#

what are your thoughts on refactoring @webpack/commons to a categorised folder?

# 
import { useState } from "@webpack/common/react"
import { CopyIcon } from "@webpack/common/components"
import { UserStore } from "@webpack/common/stores"
#

something like that

#

Pros:

  • Cleaner
  • Better structured
  • Less insane webpack commons files

Cons:

  • More imports / boilerplate

Anything else?

quaint sapphire
#

I'm also fine with

import { React: { useState } } from "@webpack/common";
austere talon
#

that's not valid import syntax unfortunately

quaint sapphire
#

huh?

#

oh

#

i remember smth like that existing tho

umbral hedge
#

I wish it was valid

#

you can do it with destructuring objects, but not esm imports

#

which is why you can do it with require()

quaint sapphire
quaint sapphire
#

yeah i was doing it with require in the past

#

forgor

austere talon
#

for some ungodly reason import isn't just normal js destructuring

#

so you can't nest

#

which is pain

#

esm so bad

quaint sapphire
#

can't we make a plugin for that?

austere talon
#

no

quaint sapphire
#

wdym no?

austere talon
#

I mean you could make a plugin for your compiler but your ide and typescript and everything else will shit itself

quaint sapphire
#

hmm

#

it should work for the import function

#

although that is async

umbral hedge
#

ye

charred monolithBOT
charred monolithBOT
austere talon
#

you will not hardcode e

umbral hedge
#

you will e

woeful sable
#

e

charred monolithBOT
frail skyBOT
#
Bad Patches

None

Bad Starts

None

Discord Errors 
WebSocket connection to 'ws://127.0.0.1:1337/' failed: Error in connection establishment: net::ERR_CONNECTION_REFUSED ```
#
Bad Patches

None

Bad Starts

None

Discord Errors 
Failed to load resource: the server responded with a status of 429 ()
Failed to load resource: the server responded with a status of 404 () ```
charred monolithBOT
limber skiff
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
brave geyser
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
frail skyBOT
#
Bad Patches

None

Bad Starts

None

Discord Errors 
Failed to load resource: the server responded with a status of 429 ()
Failed to load resource: the server responded with a status of 404 () ```
charred monolithBOT
frail skyBOT
#
Bad Patches

None

Bad Starts

None

Discord Errors 
Failed to load resource: the server responded with a status of 429 ()
Failed to load resource: the server responded with a status of 404 () ```
charred monolithBOT
long heart
#

very github, so commit

#

i approve

quaint sapphire
#

@austere talon I beg of you, can you merge my PR?
It's been so long

#

Poor css snippet manager

#

If you have a reason to not merge then tell me

#

I hate this silence

jagged cloak
#

timedones

charred monolithBOT
charred monolithBOT
charred monolithBOT
brave geyser
#

Mantushka will explode

azure jay
#

ven will merge moretags

unborn garnet
#

ven will merge Invisible Chat

solemn spoke
#

ven will merge the 20+ prs that for some reason are still up

#

i never saw a repo with more prs than issues

#

unless it is something specific like a repo with both low issues and pr numbers

unborn garnet
#

correction: he checks prs, puts up a bunch of change requests and disappears from the face of the earth when they are solved

tidal cloud
solemn spoke
#

normal to have more prs?

#

like, gimme an example except any gnome project

tidal cloud
#

i can recall at one point flask's github having zero issues open

solemn spoke
#

whos flask

quaint sapphire
#

Lol

#

It's a python library

tidal cloud
#

yeah

#

but anyways reviewing > changes > repeat takes time

quaint sapphire
#

Lies

solemn spoke
#

i mean, in my case i can do changes in like two hours

quaint sapphire
#

10 min max to review 300 lines of code in vencord

tidal cloud
solemn spoke
#

reviewing is like the biggest process, but its more because of the devs having to give 2% of their attention for a pr

solemn spoke
quaint sapphire
#

But that doesn't speed up anything

solemn spoke
#

but rly, i think what takes time is the gap between the changes and review, because the dev has to remember thay your pr exists

brave geyser
#

And has to remember to check PRS instead of playing ow2 24/7 trolley

tidal cloud
#

ven is sweaty valorant player

quaint sapphire
#

cause we spam it with comments

solemn spoke
#

agreed, but still he does not reply

quaint sapphire
#

cause ven is dum dum

verbal pumice
#

me after realizing that the maintainers have a life

brave geyser
tidal cloud
#

ven should work on vencord atleast 25hrs a day

brave geyser
#

Nop

#

36hrs a day minimum