worse than telegram android devs code after he had 1 liter of vodka
#๐พ-core-development
fiery jungle
good
fiery jungle
that's still bad
austere talon
i will LazyComponent dw
fiery jungle
yop
charred monolithBOT
austere talon
mantika loves fetching same thing ten times
less bad
i willl fix the rest later 
mantika needs to learn about formatter
austere talon
i fixed ur pr @crude hearth
you will figure out why pfps are broken now
i didnt change anything about them
oh wait i know why pfps broken im dum
keen lance
Fake news
austere talon
@fiery jungle
fiery jungle
LOOOOVE
charred monolithBOT
lament nimbus
A story in two parts
austere talon
average mantika pr
you can spend days fixing stuff and it's still gonna go bad once you merge
alpine acorn
what's reviewdb
frail skyBOT
zinc solstice
thank you, I can now leave actual reviews or just spam โcumโ on creatableโs
jagged cloak
charred monolithBOT
austere talon
that was fairly straight forward
why do people hate so much on manifest v3
it's fine
manipulating headers is even easier now
quick ibex
why do people hate so much on manifest v3
Think its related to it possibly being abused to get rid of ad blockers
At least, I think thats were a lot of the hate comes from
austere talon
adblockers can work just fine
quick ibex
Idk
austere talon
you can still block requests and stuff, it's just via json now
quick ibex
Watched a video, thats what i understood
austere talon
ig it's a bit more limited but it's fine tbh
quick ibex
probably fear mongering
Ill stick with firefox for the meanwhile
Have no problem with it, why change?
austere talon
btw in v3 you can't run remote code from extensions
which is good imo
all code will have to be bundled with extension
makes it safer for users
Because Manivest V3 only allows extensions to run 30,000 rules and most ad block extensions would need the capacity to run at least 300,000 rules to work effectively. In this context, a โruleโ would be a mechanism that blocks a specific HTTP address.
I see
so Google could fix this by allowing infinite rules
I mean
you can make rules have regex filter
so it could just compile all domains into a massive regex
and it would work probably
swift fjord
swift fjord
just write a converter that just does some basic concatenation
swift fjord
why
austere talon
they are only deprecated in node, not browser
swift fjord
they've been "deprecated" in node for a while now too
austere talon
the browser doesnt deprecate them
swift fjord
i know
lament nimbus
you can still block requests and stuff, it's just via json now
Which is the issue, it's much easier and wayyy better if you can just do it all dynamically
Good adblockers load dynamic rule lists and load user rules, which is extremely hard to do with the declarative method
austere talon
its not
you can set rules with js
chrome.declarativeNetRequest.updateDynamicRules({
addRules: [
bleh
]
})```
brave geyser
charred monolithBOT
austere talon
woeful sable
crude hearth
INSANE
@austere talon you were husking me and calling me insane when I did that 2 weeks ago
money changes people
brave geyser
Fr
umbral hedge
<:trolley:1024751352028602449>
lmao why'd you leave all the blank ones in there
austere talon
why not
austere talon
<@343383572805058560> you were husking me and calling me insane when I did that ...
because noone will donate to insane art gallery
crude hearth
because noone will donate to insane art gallery
it was aliucord plugins repo
austere talon
you are not a very good artist sorry
crude hearth
horrrorr
quick ibex
wtf
brave geyser
brave geyser
this will be you
I will buy this masterpiece
quick ibex
@austere talonhonestly id check if your locks work
umbral hedge
<@343383572805058560>honestly id check if your locks work
@austere talon unlock ur door for me
brave geyser
and me
quick ibex
brave geyser
I brought some glass shards
umbral hedge
I brought some flowers
austere talon
umbral hedge
charred monolithBOT
swift fjord
shill
austere talon
problem?
frail skyBOT
austere talon
Good
charred monolithBOT
made a dictionary plugin with urban dictionary's api.
very cool!
(embed would be even cooler!)
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
crude hearth
wth where are all these people coming from
austere talon
brazil
charred monolithBOT
frail skyBOT
verbal pumice
not showing edits moment
austere talon
are u aware this is already a thing via the inbox tab? @woeful sable
charred monolithBOT
woeful sable
are u aware this is already a thing via the inbox tab? <@456226577798135808>
inbox tab?
woeful sable
this doesn't do all servers you are in no?
and it's not that convenient either alot of my friends asked me to make that button ๐
woeful sable
yeah
also i'm pretty sure like 90% of discord users doesn't even know about the inbox feature
i didn't even know about that thing even though i use discord everyday all day since 2019 ๐
woeful sable
yeah that's true
but it's still not as accessible as mine 
my friends still want my button 
@austere talon cmonnnnnnn
i also need that api for my other plugins
so it's a win win
austere talon
explains why you're using namespaces
woeful sable
GODDAMNIT
austere talon
we don't really do that in typescript
namespaces in typescript are like ancient from before export/import were a thing
woeful sable
are you kidding me
i thought they were new
๐ญ
i mean it's still a cool thing to wrap things
cuz i don't know better ways off my mind
austere talon
basically you can already make custom namespaces via import if you just export top level functions
export function addServerListItem();
// single function import
import { addServerListItem } from "blah"
// import as namespace
import * as ServerListItemNameSpace from "blah"```im gonna be genuine i even used that without noticing i did namespace just like "automatically" and when i realized it was already working and i was like "oh js\ts has namespaces what?"
austere talon
woeful sable
yeah
but what like
if i have
ObjectTick
and i wanna make it like Object::Tick
so like just "context" thing
i used namespace
but what would someone do in ts for that
i just wanted to "wrap" those functions if that makes sense
throwing functions in the plugin like that looks like absolute mess to me
austere talon
that's why you make it an api
in the api folder
look at how the other apis look
woeful sable
i thought itโs a but unnecessary to make it an api for such a small thing
austere talon
nah its fine
could you please do that? Migrate it to the api directory and use top level exports instead of namespaces
other than that it looks good
thank you
woeful sable
alright ill be on it soon
quaint sapphire
i thought itโs a but unnecessary to make it an api for such a small thing
Nah, adding more APIs even if no plugin uses them is fine
Cause a future plugin might profit off it
And also, unused APIs are disabled, so no impact on performance
(not like there would be any real impact either way)
quick ibex
^^^^
austere talon
thanks thanks I'll see in a bit
charred monolithBOT
austere talon
Holy shit it's joel Windows 7
umbral hedge
REAL
charred monolithBOT
woeful sable
@austere talon @austere talon
i will stab you in your sleep
austere talon
i will look in a seccccc
charred monolithBOT
frail skyBOT
charred monolithBOT
charred monolithBOT
austere talon
it wasn't done yet
woeful sable
austere talon
Hahaha this is what I get for not working on a clean base
verbal pumice
lmao gj
austere talon
haha guess it's released now
it works but the issue is that it doesn't show reactions until you hover / reload the message
idk how to fix
verbal pumice
dispatch MESSAGE_UPDATE once you're done with adding the images?
i did that in message link embeds and it works most of the time
austere talon
I don't add anything
I just render my own component
the issue is that const reactions = ReactionStore.getReactions(message.channel_id, message.id, emoji);
returns no users even when there are ones
verbal pumice
oh
austere talon
I tried subscribing to like message update and to changes on the store but neither work
@vagrant topaz did u have that same problem
woeful sable
why does commandsAPI and serverlistAPI turn back on each time i restart ๐ฟ
quick ibex
woeful sable
so homosexual
austere talon
why does commandsAPI and serverlistAPI turn back on each time i restart ๐ฟ
wdym
woeful sable
@woeful sable there's always #1032200195582197831
you have a point
but uhhh
i dunno ig
austere talon
thats not really viable for now
btw @verbal pumice why do u even still use embeds in the message link plugin
its nicer to just embed the actual message
woeful sable
@austere talon so do you want to close the pr or
austere talon
uh nah
quick ibex
ven is gonna let it sit there for over a month, then say "bruh wtf" and pr it with a small patch
woeful sable
well i made this plugin mainly for a friend of mine who asked for it alot but it's gonna be a pain to explain him how to build it ๐
quick ibex
true story โข๏ธ
austere talon
why would u leave it hanging there then ๐
cause im not speedy gonzales who can review in 2 milliseconds?
woeful sable
and wtf is speedy gonzales
quick ibex
a character
woeful sable
and wtf is speedy gonzales
what the fuck
austere talon
the fastest mouse in mexico
quick ibex
Known for being fast
woeful sable
oh you didn't do the capture groups
@austere talon
i need a more specific regex because i use the variable names
i capture them in the regex
alright pushed
woeful sable
@austere talon
it works fine for me
there's plainText but it would just be @VendingMachine#8485
so yeah i think rawText is enough
btw does the plugin auto build?
austere talon
wdym
woeful sable
the plugin list*
woeful sable
what a meaning full commit goddamnit
austere talon
btw u missed the entire point of using .{1,3}
woeful sable
austere talon
u just set it to .{4}
the point of that is that minified names can be anything between 1 and 3 chars
so .{1,3} is more robust than .
woeful sable
i thouhg they are uhh "static"
austere talon
and like
dt.OX could later become a.DOA
woeful sable
so if a thing is 2 letters it will stay two letters
woeful sable
so dt.OX would be .{1,3}\..{1,3} am i correct
austere talon
either that or i just do .{1,10} usually
but gotta be careful with .{1,3} cause it will also match unrelated chars so u also gotta have boundaries around them
like
foo(x.BY,{```yeah yeah i get that
austere talon
should be \(.{1,10},\{
brave geyser
Electron
austere talon
anyway should probably make MessagePopover api soon
like api for adding stuff here
brave geyser
brave geyser
No clue
charred monolithBOT
woeful sable
better be ready cuz i have two more plugins!!
dm typing indicator and platform icons
austere talon
platform icons woud be awesome
for dm typing indicators you mean like typing dots on dm channels?
why not make it do guilds too
woeful sable
no
austere talon
btwi forgot to give u contrib why didnt u say smth xd
tame pecan
dm typing indicator and platform icons
YESSSSSSSSSS
woeful sable
platform icons is wip
tame pecan
i can tell
austere talon
use git correctly
woeful sable
dm is done prety much
austere talon
dont ever make features on main branch
you should always check out feature branch
then pr from feature branch
for next feature go back to main first, pull latest changes from upstream then make another feature branch
austere talon
just reset
woeful sable
how does one reset pls help
austere talon
git remote add upstream git@github.com:Vendiated/Vencord
git fetch upstream
git reset --hard upstream/main```this assumes u use ssh
woeful sable
YESSSSSSSSSS
im actually happy someone likes those plugins or wants them like me ๐
tame pecan
im actually happy someone likes those plugins or wants them like me ๐
because theyre useful
but i moved from bd
shits laggy
austere talon
then to make develop multiple plugins at once:
git checkout -b platform-indicators
# do some changes and commit and push and stuff
# later to make another feature before first one is merged
git checkout main
git pull upstream main
git checkout -b my-other-feature
then you can switch between your features by just git checkout branch
woeful sable
do i just delete and refork
austere talon
NO
woeful sable
bruh what
austere talon
```js
git remote add upstream git@github.com:Vendiated/Vencord
git fetch upstrea...
do this
austere talon
```js
git remote add upstream git@github.com:Vendiated/Vencord
git fetch upstrea...
this resets it
woeful sable
it didn't
tame pecan
woeful sable
look at this crap
github can so pissy i swear
why i can't just sfull sync with main repo
bruh
i wanna discard those commits
quick ibex
bro if you struggle using commandline use github desktop
austere talon
why do u care what ur github looks like
doesnt really matter
anyway you need to force push to delete those commits
just do the reset like i said then git push --force origin main
austere talon
```js
git remote add upstream git@github.com:Vendiated/Vencord
git fetch upstrea...
do this
then force push
holy shit lmao
tame pecan
another vencord upd
fiery jungle
holy shit lmao
why am i in there twice 
austere talon
wtf I just looked at the original plugin
why do they include so many pointless libraries
entire fetch library and rpc client
woeful sable
I'll be honest it was hell to figure out because of that
I tried not making too much of a mess either
austere talon
additionally - I would like to note that connecting to the RPC api via WebSocket does not work
what does that mean?
what rpc api are you trying to connect to
woeful sable
the uhh localhost one
austere talon
Also good music taste 
love tuyu
austere talon
the uhh localhost one
like discords?
woeful sable
yeah
austere talon
doing that is the worst way anyway, the dispatcher method is the best way
it would be cool if that plugin could somehow work without requiring a last.fm key
maybe they have "public" keys you can use instead
like twitter
woeful sable
doesn't seem to be, sadly
austere talon
by public I mean tokens the official websites use when you're not logged in
btw why not use listening instead of playing?
it's kinda sus because that gives away you're using a mod so it should be a switch if added but that would be cool
woeful sable
hmm maybe
I didn't even try because I was kind of scared it could trigger something but probably wont
also just checked lastfm and it's pre-rendered or something
no api requests
austere talon
im also looking and theres a bunch of requests
im trying to check if any of them are what we need
woeful sable
this is a heavy one but i made a different branch finally
austere talon
you're right it does SSR
woeful sable
the alternative would be to scrape the webpage which ehhh
you only receive typing events for the current server opened and dms
not all servers
so doing it for the current server is kinda pointless imo
oh yeah I had that too
austere talon
https://www.last.fm/user/USER/library?_pjax=%23content gives u html and you could easily scrape it:
class="
image-overlay-playlink-link
js-playlink
"
href="https://www.youtube.com/watch?v=ZfXU1qmOOyc"
target="_blank"
data-playlink-affiliate="youtube"
data-youtube-id="ZfXU1qmOOyc"
data-youtube-url="https://www.youtube.com/watch?v=ZfXU1qmOOyc"
data-track-name="Uncertain"
data-track-url="/music/A+Light+in+the+Dark/_/Uncertain"
data-artist-name="A Light in the Dark"
data-artist-url="/music/A+Light+in+the+Dark"
title="Play on YouTube"
data-analytics-action="FeaturedTrackPlayTrackOnPage"
data-analytics-label="youtube"
but i prefer the api version
so lets use that
god i hate server side rendering
things like google trans, virustotal, twitter etc all have "public" api keys you can just yoink
woeful sable
oh I should try adding the timestamp thing
austere talon
last fm doesn't do times does it? already mentioned it earlier and people were saying it doesnt
woeful sable
it doesn't do for the currently playing track
on other tracks there's a date attribute that's when it was scrobbled
austere talon
yeah but u cant really calculate how far the user is in
like u have no way of knowing
woeful sable
yeah true
austere talon
the best you could do is do like
lastScrobbleTimeAgo - lastScrobbleLength but what if the user seeked to a different time
umbral hedge
yea
woeful sable
prob best not to then
austere talon
what player r u using anyway
lament nimbus
Play music is still a thing?
It got rebranded to yt music
lament nimbus
yeah merged ig not rebranded
woeful sable
it was dimden's but now it's my own
austere talon
ah oke
woeful sable
austere talon
just to make sure it doesn't get deleted somewhere along the way
woeful sable
iirc I didn't cache because that function seems to cache already (or at least with external urls it doesn't re-request things)
austere talon
oh also it'd be helpful to add instructions how to get an api key, you can do that by adding settingsAboutComponent to ur plugin that returns a react component
austere talon
iirc I didn't cache because that function seems to cache already (or at least wi...
ah okay
woeful sable
ven check my pr when u kan 
also i suggest maybe get rid of the devs constant and instead just check if a person has the contrib role from this server?
austere talon
no?
whats wrong with the devs constant
and not everyone will be on this server
can u show the dm typing indicator
woeful sable
.
limber skiff
+0 yes
austere talon
i would bring back the original counter also
like make it show ๐ฎ๐น 9 pfp pf pfp
woeful sable
did changes just now
should I try setting it to LISTENING? also added a check for the plugin's applicationId in case that works
austere talon
should I try setting it to `LISTENING`? also added a check for the plugin's appl...
as an option imo
austere talon
oh shit it works
yea but its kinda sus cause thats like a dead giveaway to everyone youre using a mod
charred monolithBOT
woeful sable
oh oops i thought i had fixed imports already
crude hearth
we need youtube music rich presence plugin
woeful sable
if you use webscrobbler this works with that
austere talon
just use the lastfm one
crude hearth
but I think stupit google doesnt have a api for yt music
crude hearth
just use the lastfm one
how
austere talon
u could have included token logger and bitcoin miner in this commit and i wouldnt have noticed
quick ibex
Im gonna work on a multi-music rich rpc client when I am done with my current project
austere talon
W
crude hearth
u could have included token logger and bitcoin miner in this commit and i wouldn...
I will do this on my next pr
charred monolithBOT
I pushed the Urban Dictionary plugin to the forked repo but it doesn't show the commits here (Probably because I deleted the previous fork ๐ข).
I'm not sure if I need to make another PR or not.
Please let me know what should I do :)
This is the plugin for now:
charred monolithBOT
A plugin that let you search for words' definitions (from Urban Dictionary) without leaving Discord.
limber skiff
got reaction counts to show working
patches: [{
find: ",reactionRef:",
replacement: {
match: /((.)=(.{1,3})\.hideCount)(,.+?reactionCount.+?\}\))/,
replace: "$1,whoReactedProps=$3$4,$2?null:Vencord.Plugins.plugins.WhoReacted.renderUsers(whoReactedProps)"
}
}],
austere talon
lmfao
wait
it's only renderering 4 pfps
even tho 5 reactions
inb4 max is exclusive max?
limber skiff
oh wait
hold on that might not be what I wanted to show
oh
my fix worked I think
yeah it did
I'm gonna make a pr
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/main/src/plugins/whoReacted.tsx#L81-L...
**whoReacted.tsx: **Lines 81-89
users={users}
count={users.length}
guildId={ChannelStore.getChannel(message.channel_id)?.guild_id}
renderIcon={false}
max={5}
showDefaultAvatarsForNullUsers
showUserPopout
renderMoreUsers={makeRenderMoreUsers(users)}
/>
like is the max exclusive
have u tried that
cause I think that's what might be happening
austere talon
all good
woeful sable
good luck making a commit with the same sha sum just to troll some vencord users
frail skyBOT
woeful sable
mf dipped before reviewing my pr
austere talon
it is a specific commit hash but still dum
how
it's impossible for her to change that code
cause its pinned to a specific commit
unless you can find a sha1 collision for a valid git object with malicious code
which is virtually impossible
charred monolithBOT
brave geyser
verbal pumice
are you ever so confused an edit just works you quadruple check you actually saved the file
woeful sable
@austere talon check my pr mff
austere talon
i rebased ur pr @fiery jungle
woeful sable
ill stab ven
woeful sable
austere talon
lol i forgot to submit review again
someone make an extension to submit review automatically on page leave
woeful sable
@austere talon wdym use jsx
austere talon
someone make an extension to submit review automatically on page leave
hope this gets added
fiery jungle
i rebased ur pr <@295190422244950017>
what does that do
fiery jungle
btw u forked webext right
yeah
austere talon
now no longer merge conflict
fiery jungle
oh ok
austere talon
i kinda deleted all ur commits in the process
fiery jungle
guhhh
fiery jungle
are my changes to the build scripts still there
austere talon
are my changes to the build scripts still there
yeah i think i redid everything
fiery jungle
good
I'll finish up later
austere talon
look at pr
firefox is broken cause they dont support manifest v3 yet
even tho they promised v3 in early 2022????
fiery jungle
switch back to v2
austere talon
firefox will explode
fiery jungle
there's no point in v3 right now
austere talon
there is
fiery jungle
why
austere talon
v2 is deprecated and v3 is easier to maintain and more performant
either bring back v2 alongside v3 for firefox or tell firefox users to explode until mozilla adds v3
fiery jungle
explod
austere talon
lol he deleted his pr again
austere talon
later bro, gonna shower now then I gotta do homework
cosmic quail
lol he deleted his pr again
merged and it closed the pr, reopned it tho lol
charred monolithBOT
woeful sable
review prs or stab
austere talon
cope
woeful sable
trol
quick ibex
@woeful sable more descriptive title?
woeful sable
oh sorry I'll edit in a bit
austere talon
so many prs im explode
rigid venture
charred monolithBOT
it only works if both start and end timestamps are set which apparently not a lot of rpc clients do
if only start is set it will render normally
and if only end is set same as above but w remaining instead of elapsed
frail skyBOT
austere talon
lmaooo arrpc moment
fiery jungle
love
tropic wagon
vendy bask in the horror
limber skiff
you really need someone to help you review
this is turning into too much for a single person
dawn coyote
tl;dr, ENTER doesnt create a new line in github but submits the issue
woeful sable
@austere talon i addressed all my stuff
austere talon
variable component is kinda out of scope for settings imo, but you can make a custom component and make it yourself
multi text component definitely a good idea
btw if youre making custom tags, I actually already made semi finished custom tags as well
lolz looks like that branch got deleted at some point
anyway you shouldn't store tags in settings anyway
cause settings potentially have very low storage limit (in browsers)
you should instead use the DataStore api
austere talon
<@343383572805058560> i addressed all my stuff
๐ gonna take a look
@dawn coyote
dawn coyote
cause settings potentially have very low storage limit (in browsers)
what I made wasn't really intended to public anyway, I just wanted it for myself because I am too lazy to type out certain things over and over again
dawn coyote
Well if I have the time I maybe will try to make my own component for that
austere talon
why do u even wanna make settings ui, would be way easier for u to just do it via commands
. /tags add/list/delete
/thetagname
dawn coyote
because I didnt think of it lmao
dawn coyote
sure
dawn coyote
It's just kind annoying for me to always go trough other plugins to see how stuff works
charred monolithBOT
austere talon
there u go
dawn coyote
dawn coyote
.1
Hello,
Thank you for bringing this issue to our attention. We've initiated an investigation based on the information that you provided and we'll take appropriate action based on our findings. Please note that for privacy reasons, we're not able to share the specifics of the action taken, if any.
We truly appreciate your efforts in helping us to keep Discord a safe and friendly environment.
Sincerely,
Discord Trust & Safety
brave geyser
dawn coyote
lol
austere talon
its cause of a change i made
charred monolithBOT
austere talon
okay there we go
charred monolithBOT
austere talon
my bad lol
woeful sable
check the other plugin now
@austere talon sets delete function requires object ref
so i had to convert to array and use .find
which works wackly
charred monolithBOT
austere talon
I mean
quick ibex
ven said "does it work"
austere talon
does the userscript updater support it
woeful sable
does the userscript updater support it
it seems to
woeful sable
austere talon
lmao why did u u check giving me permission to push to that branch
now u gotta click merge button yourself
woeful sable
i didnt click shit
austere talon
I mean u gotta click funny button in pr
woeful sable
maybe refined github automatically uncheked that
woeful sable
I mean u gotta click funny button in pr
i did click da btn now
austere talon
maybe refined github automatically uncheked that
nah
woeful sable
it is very substantial
i have created automatic update functionality for the user script
charred monolithBOT
austere talon
too lazy to test rn
woeful sable
virus
austere talon
someone test IMMEDIATELY
austere talon
yeah
charred monolithBOT
austere talon
i should make it restart
woeful sable
mf accept the dm indicator
tame escarp
"i builded it"
HAHAHHA THEY HAVE A TOKEN STEALER FORKED
insane
"Add files via upload" is the sign of fantastic programming skill
cosmic quail
lmao
tame escarp
YANDEX BROWSER
๐
lmao they kill cors and csp i think
insane
lmao to get the token they just eval a snippet with webpack
THAT USES WEBPACKJSONP
๐๐๐๐๐๐
they also use xhr
maiden elk
HAHAHHA THEY HAVE A TOKEN STEALER FORKED
igna moment
umbral hedge
<@545581357812678656> did you finish css modules
well I did and then we decided to do scss instead and I've paused it there
umbral hedge
one day
woeful sable
silly ven
@austere talon accept typing and this mf
i wanna live my life on main branch again
john ill stab you
brave geyser
Noo
woeful sable
ur a kemo hater
brave geyser
Nop
brave geyser
brave geyser
Keto lover
charred monolithBOT