fixed the conflict
#๐พ-core-development
limber skiff
austere talon
no
Read the last 2 lines
anyway that issue shouldn't be hard to fix
process.env.ELECTRON_DISABLE_SECURITY_WARNINGS = 'true';
slap this in patcher and enjoy 
protocol.registerSchemesAsPrivileged([
{ scheme: 'http', privileges: { standard: true, bypassCSP: true, allowServiceWorkers: true, supportFetchAPI: true, corsEnabled: true, stream: true } },
{ scheme: 'https', privileges: { standard: true, bypassCSP: true, allowServiceWorkers: true, supportFetchAPI: true, corsEnabled: true, stream: true } },
{ scheme: 'mailto', privileges: { standard: true } },
]);
this also works
lament nimbus
Uh
Wha
Two of those things didn't happen, and the other two are pointless
The as T doesn't even work iirc
I tried messing with the types before
austere talon
Two of those things didn't happen, and the other two are pointless
you love hacktoberfest spam
oh god this guy opened multiple prs
lament nimbus
Lmao they are doing it in the web editor
austere talon
wtf is that second pr lmfao
lament nimbus
Doubt it builds lmao
charred monolithBOT
lament nimbus
You should add invalid or spam tags
quick ibex
austere talon
You should add invalid or spam tags
idk bro he made his github a few months ago I feel like he's actually trying, just has no idea what he's doing
quick ibex
What the fuck
verbal pumice
based
quick ibex
lament nimbus
Me after I dick shit pussy your mother:
verbal pumice
Me after I dick shit pussy your mother:
you cannot say that!!!! that is an insult!!!!
lament nimbus
you cannot say that!!!! that is an insult!!!!
my bad
me after I money coin btc your eth:
austere talon
lmaoo
quick ibex
Me when pneb prs my repo
lament nimbus
Yeah I'll fix all that stuff after I'm done with the user popout
I have a handful of unpushed changes
austere talon
ah alright
austere talon
Also why are those forced to upper case anyway?
some people have weird ocd that they want everything in all lowercase
maybe add a third format that makes everything lowercase
I know some servers where a bot auto lowercases everyone's name lmao
or even owner doing it manually
golden gulch
the original pronoundb plugin keeps those strings capitalized (not that we have to follow it exactly)
rigid venture
https://github.com/top-gg/go-sdk/pull/11
is that a bot
umbral hedge
fear
golden gulch
rebases >>>>> merge
rare shale
@austere talon does this even have a chance of being merged or should i just put it as a third party plugin
umbral hedge
sound changer is valid
austere talon
btw
lament nimbus
why is nea here
austere talon
theres a module that exports a sound map lmao
mortal fractal
this
rare shale
why is nea here
because i shove her everywhere i go
mortal fractal
theres a module that exports a sound map lmao
it calls to require other modules but that logic can probably be reworked to call a function in the plugin
mortal fractal
umbral hedge
mortal fractal
thanks megu
umbral hedge
austere talon
lmao thats such a weird hack
mortal fractal
it is
austere talon
browser moment
mortal fractal
its a common hack
mortal fractal
yeah cause mozilla are fucking idiots
umbral hedge
mortal fractal
and think its harmful to have the clipboard api be a thing
rare shale
now implement that in https://exhq.gay/beta
mortal fractal
implement it yourself 
umbral hedge
rare shale
my head hurts
austere talon
its right here
mortal fractal
is there a type for react components?
umbral hedge
for components, JSX.Element, for children it's supposed to be React.ReactNode
(React.ReactNode accepts things like fragments iirc)
austere talon
var sounds = Vencord.Util.proxyLazy(() => {
const DJ = find(m => m.resolve && m.keys && m.id && typeof m === "function" && m.keys()[0].endsWith(".mp3"))
return Object.fromEntries(DJ.keys().map(sound => [sound.slice(2), DJ(sound)]))
})
console.log(sounds["call_ringing.mp3"])
@rare shale
umbral hedge
discord still has soundpacks code lmao
mortal fractal
yes
rare shale
```js
var sounds = Vencord.Util.proxyLazy(() => {
const DJ = find(m => m.res...
what do i do with this :3
mortal fractal
umbral hedge
cringe it isn't exported
mortal fractal
why not just patch this
austere talon
that too
rare shale
ive written so much shit today i genuinely wanna throw up
mortal fractal
merely an issue of skill
rare shale
can you make a pr or add to my code or something
umbral hedge
charred monolithBOT
austere talon
someone with idb knowledge check if this is okay please
tame escarp
is there a good reason to write your own wrapper instead of using idb-keyval or smth @austere talon?
tame escarp
lmao
austere talon
i didn't know of its existence, I only saw other wrappers and those are insanely bloated, that's why I implemented my own logic
tame escarp
lmao rip
austere talon
i discovered idb-keyval
and uhh
they literally stole my code I'm gonna DMCA
(on a more serious note their code is basically identical to mine)
tame escarp
L bozo
quick ibex
Message the owner to take it down ig
charred monolithBOT
austere talon
there done @tame escarp
woeful sable
bro put a license ๐
austere talon
bro put a license ๐
because you have to?
austere talon
I DIDNT MEAN LITERALLY COPY THEIR CODE
but i want the store to have a custom name
it offers no better way
tame escarp
guhh i guess
austere talon
also there's nothing wrong with copypasting source code trolley
tame escarp
can you not just like wrap around the functions
tame escarp
your sanity
austere talon
its fine
charred monolithBOT
charred monolithBOT
austere talon
is there a less cursed way to do this
i tried
/**
* jsdoc
*/
export * as Foo from "foo"```
and ```js
import * as Foo from "foo"
export {
/**
* jsdoc
*/
Foo
}```neither of these work
charred monolithBOT
vestal grove
it offers no better way
ven when he uses an old version of idb-keyval for no reason
(latest has custom names but whatever)
((literally just openDB('name')))
austere talon
I am aware
but now u have to pass it to every function
const db = await openDb("ye")
get("key", db)
unusable
I could make wrappers like someone else said but why would I do that when simply editing source code is easier
vestal grove
because it's a terrible idea, but who am i to attempt discouraging you
quick ibex
austere talon
how is it a terrible idea
quick ibex
HD trolley jumpscare
austere talon
name one reason why it's a terrible idea
umbral hedge
explode
vestal grove
you're locking yourself to an old version and it's difficult to update
vestal grove
what exactly is the downside of using the other one
austere talon
none
but it's bigger and more complex
idb-keyval works fine and I have no problem with modifying it
golden gulch
idb's readme also suggests using idb-keyval if all you're doing is key based stuff
mortal fractal
@austere talon is there a way to match the module as a whole or no
umbral hedge
i only found the one
mortal fractal
if i can grab the entire module by document.queryCommandEnabled("copy")||document.queryCommandSupported("copy") and then take the exported function by .default.copy(
mortal fractal
the button in the bottom left
austere talon
if i can grab the entire module by `document.queryCommandEnabled("copy")||docume...
yes
umbral hedge
mapMangledModule
austere talon
const Clipboard = mapMangledModuleLazy("string search", {
cope: filters.byCode(".default.coy(")
})
Clipboard.cope()```cope
grave mangoBOT
example https://github.com/Vendicated/Vencord/blob/main/src/utils/modal.tsx#L41-...
**modal.tsx: **Lines 41-47
export const Modals = mapMangledModuleLazy(".onAnimationEnd,", {
ModalRoot: filters.byCode("headerIdIsManaged:"),
ModalHeader: filters.byCode("children", "separator", "wrap", "NO_WRAP", "grow", "shrink", "id", "header"),
ModalContent: filters.byCode("scrollerRef", "content", "className", "children"),
ModalFooter: filters.byCode("HORIZONTAL_REVERSE", "START", "STRETCH", "NO_WRAP", "footerSeparator"),
ModalCloseButton: filters.byCode("closeWithCircleBackground", "hideOnFullscreen"),
});
is this valid: SUPPORTS_COPY: x => typeof x === "boolean",
austere talon
yea
the filter it expects is just (m) => boolean
I wonder when supports copy would be false
umbral hedge
sorry I only use Internet Explorerโข๏ธ 8
mortal fractal
I wonder when supports copy would be false
when document.queryCommandEnabled("copy")||document.queryCommandSupported("copy") returns false
austere talon
oh
when would that be false
lmao
that explains why I never heard of that function before
mortal fractal
pushed changes
umbral hedge
my favourite function exported from ClipboardUtils.web.tsx
umbral hedge
no clue
umbral hedge
yeah
mortal fractal
message accessories api done, time to pr https://toaster.sh/i/c03yotro.png
austere talon
balls
mortal fractal
i am uncreative with test strings
austere talon
nono I get it I use balls too
vestal grove
I use cock
umbral hedge
balls
charred monolithBOT
woeful sable
cock
austere talon
isn't object type like empty object with no props
umbral hedge
Record<string, any> my beloved
mortal fractal
Record<string, any> my beloved
i am new to typescript thank you
umbral hedge
np
umbral hedge
xd
tame escarp
when can i type array as Record<number, any> ๐
umbral hedge
you can
austere talon
tame escarp
GUH
vestal grove
^
austere talon
bro has never heard of an arraylike
woeful sable
when can i type array as `Record<number, any>` ๐
when a mommy and a daddy love each other very much
umbral hedge
Arrays are actually objects anyways
austere talon
ArrayLike = object with length property and possibly integer indexes
vestal grove
yop
umbral hedge
you love typeof []
mortal fractal
its why you have to do Array.isArray instead of typeof
umbral hedge
yea
tame escarp
no i know that but like
i figured that TS wouldn't like me doing that for some reason ๐
tame escarp
time to PR to change array types to this in vencord
lament nimbus
@austere talon https://github.com/Vendicated/Vencord/pull/115 you will merge
charred monolithBOT
jagged cloak
works for me ig
charred monolithBOT
jagged cloak
mortal fractal
halcyon salmon
lmao
charred monolithBOT
mortal fractal
@austere talon look at this shit lmfao
austere talon
<a:KEKW:831706994897190922> https://toaster.sh/i/nujv2t78.png
hot
gonna use
lmao wtf
he just renamed and removed everything
and removed license info
mortal fractal
hf!linvite Ks6ncwqxH8
grave mangoBOT
hf!linvite Ks6ncwqxH8
9 online 
17 members
austere talon
dmca time? 
quick ibex
dmca time? <:bruh:1000822281301409792>
seems like they follow license info
austere talon
they don't
they removed the entire licensing section from readme
this is why you add license headers to every file
lmao
github lines support when @mortal fractal
lol they switched from esbuild to webpack
amazing
limber skiff
changing the license moment 
charred monolithBOT
quick ibex
BRO THEY CHANGED THE FUCKING LICENCE
charred monolithBOT
half shell
Lmaoooo
jagged cloak
kek https://github.com/AlphaCord/AlphaCord/commit/f388d2a72e58c1ec50309b6a1db74b...
LOl why
tharkicord moment
is this made by tharki actually hold on
dkd
charred monolithBOT
Ah yes, another thing, when I click the Open QuickCSS FIle button in the inPrivate tab, the window that pops up is blank, not because the adress is about:blank as that also happens outside inPrivate windows, but it has no contents or text fields, it's just empty.
Like this:
austere talon
lol it nuked the userscript header
maiden fog
ven loves https://github.com/google/addlicense
austere talon
eslint plugin more useful
charred monolithBOT
charred monolithBOT
charred monolithBOT
opaque pewter
watafak no array at
deft cobalt
yes.
austere talon
be nice
fierce gale
github have scary people
charred monolithBOT
golden gulch
you love to see reverting upstream commits instead of merging/rebasing them into your pr
austere talon
charred monolithBOT
deft cobalt
why im so stupid :<
charred monolithBOT
woeful sable
zamn
woeful sable
are you done
austere talon
ye
limber skiff
just let people customize the url to anything they want 
charred monolithBOT
austere talon
what
woeful sable
how df do i go back
austere talon
without -b
woeful sable
oh its git switch
tidal cloud
because kyza
woeful sable
where kyzamode plugin
jagged cloak
i too Vencord Installer
umbral hedge
true
verbal pumice
can you not waitFor a module if you provide your own FilterFn instead of a prop array or am i just stuoid
jagged cloak
jk i had stupid shidd in dev so it didnt pick up anything
installer should probably error propely though instead of exploding the Vencord Installer
umbral hedge
can you not `waitFor` a module if you provide your own `FilterFn` instead of a p...
you can
umbral hedge
can you not `waitFor` a module if you provide your own `FilterFn` instead of a p...
the filters.byProps and stuff just generate functions
limber skiff
good eslint rule
austere talon
good plugin
verbal pumice
guess im just really stupid
austere talon
trollage
use lazyWebpack
go into src/webpack/patchWebpack.ts and on line 104 change <3 => <=3
fathom herald
explode
austere talon
what the fuck is that
limber skiff
ยฏ_(ใ)_/ยฏ
rancid dragon
what the hell is an activity
limber skiff
like playing games
umbral hedge
horror
limber skiff
lmao
umbral hedge
xd
austere talon
would it be less horror to make ur own
umbral hedge
what's the purpose of this function
seems kinda useless vs just calling DataStore.set(...) and just ignoring the result
austere talon
seems kinda useless vs just calling DataStore.set(...) and just ignoring the res...
technically this way of doing it is better for debugging
but yeah youre not wrong
umbral hedge
xd
austere talon
i hate how i need to manually approve workflow runs
is that actually a securty concern?
can u show an updated screenshot @tropic wagon
umbral hedge
I mean if the workflow doesn't have a gh token or anything then its not a problem
but otherwise ppl can abuse it to leak your creds
I've approved a few workflows as well xd
austere talon
but otherwise ppl can abuse it to leak your creds
highly doubt that
if the pull request is from a different repo then it'll use that repos tokens
i think
umbral hedge
hm
austere talon
I don't think Microsoft would have a feature that could let others steal ur tokens
fathom herald
that is perfectly centered oh my
golden gulch
if the pull request is from a different repo then it'll use that repos tokens
only if the workflow is running within thet repo, which it wouldn't be since it's a pr on your repo
umbral hedge
ebic
golden gulch
and it makes sense to use your repo's tokens in case you have external integrations, like setting PRs up on a staging instance or something
people won't have those secrets on their own repos
tropic wagon
quick ibex
your github is a different kind of fucked
charred monolithBOT
TypeError: Cannot read property 'localeCompare' of undefined
at VencordRenderer:31
at Array.sort ()
at VencordRenderer:31
at Object.useMemo (WebpackModule364448:2)
at Object.t.useMemo (62be08f0b264e26179c8.js:1642)
at VencordRenderer:31
at ua (WebpackModule364448:2)
at $s (WebpackModule364448:2)
at ku (WebpackModule...
austere talon
- you can type globals via
ts declare const prettier: type - don't pollute the global, use https://www.unpkg.com/browse/prettier@2.7.1/esm/standalone.mjs:
const prettier = await import("https://www.unpkg.com/browse/prettier@2.7.1/esm/standalone.mjs");```@halcyon salmon
anyway I will sleep I can help u more tmrw
halcyon salmon
kk
charred monolithBOT
Alright, i added a small model when you try to select an hidden channel.
The topic section doesn't appear if there is no topic.
charred monolithBOT
this is a mockup that i screenshotted from my browser
it works well to show what i mean just pretend that each tab is a different setting and you get it
tame escarp
my guy screenshotted his browser tabbar ๐
and showed his full name ๐
and has 3ds modding guides up for some reason ๐
actually it might not even be 3ds
i think it's dsi
so why do they have twilight menu up ๐
austere talon
@light crag why do you have two accounts btw
austere talon
why do you have the same name
light crag
cause we're friend (and we found cool duck pics)
swift horizon
๐ฆ
tidal cloud
average bencord user
austere talon
@light crag it still tries to navigate to hidden channels
which leads to a 403 api request and fucks up the member list
light crag
****
swift horizon
~~You had one job~~
๐ฟ
light crag
๐ญ
swift horizon
swift horizon
๐ซก
austere talon
anyway uh
this is probably what u need
it's the only thing in discord that calls selectChannel(
just hook into this and check if that channel is hidden
if it is, show modal and return early
then u can alos remove ur selectChannel patch
charred monolithBOT
Discord has a method for this
could you please show a screenshot also?
Not sure about the Text variants, I just copied the style from the topic info
New view after resolving conflicts:
austere talon
oh yeah i was gonna look but my browser cucked me
charred monolithBOT
hot pecan
suck it echo
rare shale
i will unconsentually do terrible things to you
halcyon salmon
oh yeah i was gonna look but my browser cucked me
bad browser
austere talon
bad browser <:trolley:1024751352028602449>
lmaoo its not their fault
verbal pumice
...is this normal
verbal pumice
yeah thats what i meant
it did a funny
seems to have fixed itself after closing and reopening cmd but still
quick ibex
i will unconsentually do terrible things to you
Bro
rare shale
dw nea is my e-onahole
fair mantle
facts
quick ibex
@hot pecan yo, i made NoCanaryMessageLinks and saw you pushed an update to it before I could add my name to the copyright part of the header. How should I list your name in there?
hot pecan
wdy,m copyright header
oh you mean just
replace the * Copyright (c) 2022 Vendicated and contributors
quick ibex
replace the * Copyright (c) 2022 Vendicated and contributors
yeah
what name do i put for you
just nea? or...
hot pecan
Linnea Grรคf
quick ibex
Alright
hot pecan
if you want i can also post my full residential address
quick ibex
Nah
charred monolithBOT
austere talon
standalon
quick ibex
standalon
umbral hedge
standalon
austere talon
ya
quick ibex
Perfect
charred monolithBOT
lament nimbus
Ven did you check the user agent actually gets sent
limber skiff
Is this going to be reviewed or should I go to the react approach https://github.com/Vendicated/Vencord/pull/142
tbh it's just a lot of simple regex to manipulate the components
austere talon
Ven did you check the user agent actually gets sent
?
requests to github are sent with node https
that doesn't have the chromium limitations
charred monolithBOT
austere talon
i also updated pronoundb
charred monolithBOT
austere talon
Electron is weird
y
i renamed all the virtual modules to have @ prefix
git-hash -> @git-hash
idk why i didnt do that from the start
lament nimbus
y
They literally took nodejs and chromium, slapped them together, and now you have a "desktop app"
lament nimbus
i renamed all the virtual modules to have @ prefix
Why @
@ is usually used for scopes
austere talon
the processes can actually interact and share data
what else do u like better
umbral hedge
we're using @ for @components so it might get confusing
austere talon
there
umbral hedge
meow
austere talon
my favourite virtual module is
import pkg from "~fileContent/../package.json";
it just gives u the content of that file as a string
github is drunk again
charred monolithBOT
charred monolithBOT
austere talon
do these look like this? @umbral hedge
umbral hedge
ye
austere talon
mm
austere talon
umbral hedge
lmao why can i edit your reviews
umbral hedge
huh
lament nimbus
literally 1984
umbral hedge
gonna change all of ur comments to im cute
keen lance
charred monolithBOT
austere talon
oh god
why not just put a script in the repo
that reads the files and does a super basic regex search
lament nimbus
or just use the already existing esbuild stuff to read plugins
hot pecan
or just actually load the files
quick ibex
Bad script
You guys cant read
austere talon
Well you could just run it yeah
but you gotta run it with electron lmao
oh actually uh
just make a js file that imports @plugins
and does the readme generation
but actually I would push the generated stuff to a private gist on my account
so it doesn't spam repo with 3 trillion commits
lament nimbus
so it doesn't spam repo with 3 trillion commits
just make people with new plugins run the script
so it changes with prs
lament nimbus
just make a js file that imports @plugins
yes thats what I was talking about
light crag
i closed it in favor of https://github.com/Vendicated/Vencord/pull/146
austere talon
oh i see
charred monolithBOT
light crag
it has the same changes + more
quick ibex
just make people with new plugins run the script
bro fr thinks people will actually do that
lament nimbus
bro fr thinks people will actually do that
make
And if you really don't want to then make gh CI check that
austere talon
do u think we should have non minified releases of Vencord as well
lament nimbus
Do you have source maps setup
austere talon
yes
quick ibex
oh wtf
austere talon
not for renderer tho
quick ibex
you minify builds
austere talon
well
the default build is minified with no source maps
the build with pnpm watch is non minified with sourcemaps
i wonder if using https:// url for sourcemaps in renderer file would work
yes right?
the issue with that is that it would fetch bad sourcemaps for outdated builds
umbral hedge
hopefully
austere talon
i never thought of that
because the only other solution i know was inline sourcemaps
which is ugly cause it bloats size a lot
umbral hedge
ah so its uh
vencord://./path/to/file.js
needs to be relative apparently
thats how webpack does it
umbral hedge
mayb
umbral hedge
austere talon
mmmh
esbuild doesn't have an api for custom sourcemap url
oh
i can use external with footer
owo
quick ibex
just make a js file that imports @plugins
How the fuck do I import ts variables
austere talon
what
quick ibex
I genuinely cant figure out how to use ts
quick ibex
bru
austere talon
horror
umbral hedge
horror
lament nimbus
horror
umbral hedge
yay
austere talon
but still meh stacktrace
umbral hedge
I just think the sourcemaps aren't configured properly lol
umbral hedge
o
umbral hedge
then whats the problem, just the stack trace?
austere talon
so good enough for me