[ARCHIVED] JDev Garages - Forked with new QBox Exports and Core Reworking

[radiant lark]

I know that Tony and a few others were helping JDev with the garages, but it has since gone unmaintained for a little bit of time, so hopefully this allows for more people to use it with the public release of the new core.

https://github.com/xViperAG/qbx_garages

[fervent shell]

[tepid dagger]

good fork just shit code which is the original repos fault

[livid cape]

how we can make it works with renewed-vehiclekeys ?

[radiant lark]

If you would like for me to PR it I will.

[tepid dagger]

Please add support for Renewed Vehiclekeys the best vehicle script to exsist on this planet.

[livid cape]

^^ 👍

[radiant lark]

[livid cape]

ty very much

[dusty trench]

true

[fervent onyx]

I'm using renewed qb-phone and the default qbx_garage and it was working then I switch to this garage but unfortunately I can't view vehicles from garage app anymore. Here's the error. Any idea?

[dusty trench]

simple prob with simple error 🙂

chk phone fxmanifest

if the oxlib init missing

[radiant lark]

It's either one of two things. You're missing ox_lib, or I just need to comment it out temporarily.

It's the call for locales in the shared file.

[fervent onyx]

Thank you, I'll try that.

[fervent onyx]

Thank you! But I have ox_lib since I'm using qbox recipe.

[fervent shell]

Imagine using lib locales

[fervent onyx]

shared_scripts {
    'config.lua',
    'shared/shared.lua',
    --'@qb-apartments/config.lua',
    '@qbx_garages/config.lua',
    '@ox_lib/init.lua'
}

I have it on my phone script.

[dusty trench]

then chk the line no 2 whats there

[fervent onyx]

It's lib.locale()

[dusty trench]

@fervent onyx remove it

[short python]

good job @radiant lark thanks for doing it ♥️

[fervent onyx]

Sorry, I've been asking too many questions 😅 I've been reading and if I understand correctly, ox_fuel doesn't have getfuel and setfuel. How should I modify the script to make it compatible?

[fervent shell]

idk read the docs

[radiant lark]

Just change the Config.Fuel to false.

[fervent onyx]

Thank you, the error seems to be fixed now.

[unreal dome]

Hey viper, I found a couple of typo, one export wrongly written and a ped instead of cache.ped tomorrow I will try a per to fix

[radiant lark]

I'll take a look through.

[unreal dome]

PR done

[merry carbon]

Is there a good fix for server side spawning vehicles and getting properties to apply correctly? I get this error sorta randomly

[tepid dagger]

Force the ped into the driver seat

Issue is that there the client dosnt have entity control

[merry carbon]

that plus bumping the delay a bit before firing the UpdateSpawnedVehicle seems to do it

[tepid dagger]

I couldnt tell ya how the resource works as its a complete fucking mess due to the original code.

but yeah just make sure you only set vehicle properties if the client has control (which they always do when they are in the driver seat)

[merry carbon]

Looking through the ox_lib docs it says not to use NetworkRequestControlOfEntity but i had tried that as well and it seemed to work without forcing the ped into the driver seat. I also tried using the 'ox_lib:setVehicleProperties' client event but that seemed wonky too

[tepid dagger]

NetworkRequestControlOfEntity is super fucking bad, but what else are we supposed to do with cfx poor documentation and lack of server side natives.

[radiant lark]

I've only had that error once, other than that it's kinda ironed itself out.

[livid cape]

i must change anything on brazzers-fakeplates so i can use it with garages ?

[unreal dome]

It will be very difficult to use brazzers-fakeplates with ox_inventory. You have to modify all sql query to modify metadata of trunk and glovebox of the vehicle otherwise you will not see items inside when you change the plate.

[livid cape]

i have fixed that i found a post on their discord

[radiant lark]

Actually that's not the case at all. I'll make a pull and edit the fakeplates.

[fervent onyx]

I'm trying to make it work with npwd, I tried using the default garage and it does work with it. But with this garage script, I can't view my vehicles. Any idea?

[radiant lark]

go into the fxmanifest and change qb-garages to qbx_garages.

What is this npwd_qb_garages?

Ah yes, here we are:

Change this:

shared_scripts {
    '@qb-garages/config.lua',
  }

to this

shared_scripts {
    '@qbx_garages/config.lua',
  }

[radiant lark]

@unreal dome @livid cape

Here's the updated Fakeplates for QBox.

https://github.com/xViperAG/brazzers-fakeplates

[fervent shell]

why is the name something i can't even say

[radiant lark]

Because Manny did it LOL That's a question to ask him

[unreal dome]

Thank you I will test it

[unreal dome]

Tested but I couldn't have it to work. The following error appear and I cannot understand where it is generated

in the manifest there is a typo '@bx_core/import.lua' and there is no 'shared/*.lua'

[slender widget]

using the latest recipe im having an issue. it works great before i update qbx resources.

[fervent shell]

try and not comparing nil and a number!

[slender widget]

idk how to fix that yet, should i wait for his update?
if (veh and dist <= Config.VehicleParkDistance and Config.AllowParkingFromOutsideVehicle) or IsPedInAnyVehicle(cache.ped, false) then

[fervent shell]

i would guess either one of the two configs doesn't exist

check for that

[slender widget]

in configs? it does exist.

Config.AllowParkingAnyonesVehicle = false -- Allow anyones vehicle to be stored in the garage, if false, only vehicles you own can be stored in the garage (supports only public garages)
Config.AllowParkingFromOutsideVehicle = true -- Allow parking from outside the vehicle, if false, you have to be inside the vehicle to park it
Config.VehicleParkDistance = 2.0 -- Distance from the player to the vehicle to park it, radial option will dissapear beyond this distance

[fervent shell]

hhmm then dist is nil wich is no good

the easy temporary fix is to just change to veh and dist and dist <= ..

[slender widget]

i was able to park my vehicle but adding the latest commits which
'@qbx_core/modules/utils.lua',
'@qbx_core/modules/playerdata.lua',
but now i received this error, should i revert it back?

[slender widget]

should i follow this instead?

[fervent shell]

ye probably easier

[slender widget]

i just realized that the script doesn't really work perfectly and this error already persist before i send a message here

i guess that
'@qbx_core/modules/utils.lua',
'@qbx_core/modules/playerdata.lua',
is should be implement right?

[fervent shell]

no modules

[oak seal]

With an the most recent qbx update I am getting the following errors:

SCRIPT ERROR: @qbx_garages/client/main.lua:895: attempt to index a nil value (global 'QBX')

SCRIPT ERROR: @qbx_garages/client/main.lua:375: attempt to compare nil with number

[merry carbon]

gotta change the imports to the new ones. something like this
https://github.com/Qbox-project/qbx_vehiclekeys/commit/5818d271c3c1231f7955e16184038cc12a3dd6f7

[oak seal]

Thank you, that issue solved. When going to pull a car out of the garage, this error is showing. Not familiar with this on ox_lib..

ref^7 (^5@ox_lib/resource/vehicleProperties/client.lua^7:290)
UpdateSpawnedVehicle^7 (^5@qbx_garages/client/main.lua^7:666)
handler^7 (^5@qbx_garages/client/main.lua^7:787)

SCRIPT ERROR: @qbx_garages/client/main.lua:666:
An error occurred while calling export `setVehicleProperties` in resource `ox_lib`:

[merry carbon]

you need to set the config option to stuff the player into the car otherwise it won't gain control of the entity

[oak seal]

This fixed the error. Thank you for the assistance.

[radiant lark]

I've updated it so that it works properly with the latest core updates.

[slender widget]

if u got disconnected while your vehicle is outside, once you reconnect you can't get keys anymore.

[radiant lark]

That was my mistake. Fixing it now.

Pushed new.

[slender widget]

thanks, seems the error is fixed now. but still if u got disconnected while your vehicle is outside, once you reconnect you can't get keys anymore, the vehicle will go to the impound but the one you had before you got disconnected still exists.

[radiant lark]

Interesting. The keys should be saved to the server side, Might want to restart server.

[slender widget]

i actually did already, but i'll retry again.

[slender widget]

yep, i can confirm that even if i restart the problem persists.

[slender widget]

this happens with the default qbx_garages too, it might not be your script but the qbx_vehiclekeys

[radiant lark]

Just pushed a new update for the resource, so it should allow for a lot more stability, as well as a push towards better coding practices.

[civic agate]

this happens on script start up and i cant store a vehicle but the table in the config has not been edited

[radiant lark]

Got it fixewd, pushing pr now

[civic agate]

thank you

[civic agate]

now i get this when pulling a car out of the garage

[radiant lark]

Yeah that I don't know how to fix as I'm not having any issues where that is concerned and I do not know how to replicate it at the moment...

[tame goblet]

would you like a video of us doing the action. and the error popping up?

[radiant lark]

I know exactly where the error is occurring, however I don't know how to replicate jt on my end. I can try to manipulate it in some way in the code but there is only so much I can do.

[tame goblet]

can you jump in a voice call?

[radiant lark]

Not at the moment. Sorru

[tame goblet]

thats fine. just trying to see why its not working dont want to switch scripts.. its clean and the parking lots is huge for us

[radiant lark]

Gonna be updating to lib soon. Just gotta sit down and make sure everything is set with all the separate functions and I'll post the update.

[radiant lark]

Pushed the new update:

https://github.com/xViperAG/qbx_garages

What was added?

• Added qbx Lib Functions and removed all old functions in favor of new ones
• Attempted to clean up the script a little more
• Added Trunk Items into the Vehicle Spawner (for Job Based Spawning)
• Added More Locales
• Removed all old qbx_radialmenu exports in favor of lib.Radial Functions.
• Fixed Garage SQL due to originally being fixed for qb-core and jim-mechanic.

[merry minnow]

how do I connect garages and xt-pdextras, I tried it myself, it doesn't work, the vehicle always appears, can't be saved here

[radiant lark]

Not sure what the issue might be.

[merry minnow]

So to connect, what must be changed? I just followed what was in the config and it didn't work

[ashen comet]

how to make it with E button instead radial menu?

[radiant lark]

Use https://github.com/Qbox-Project/qbx_garages

[ashen comet]

i want to use ur resource but with E button

it is posible?

[radiant lark]

I don't plan on adding E support. Just use regular qbx.

[ashen comet]

idk why my radialmenu can't appeare parking menu or open garage

[radiant lark]

Is that ox Radial or qb-radialmenu

[merry carbon]

that looks like ox based on color and the pie slices

[radiant lark]

Yeah I know I have it hard-coded to be lib.addRadialItem and so on.

[ashen comet]

it's qbx_radialmenu np style.. but parking menu and open garage appeare in ox radial

[oak seal]

When a vehicle is spawned server-side, and the vehicle ends up disappearing or is lost, what state is that vehicle given? I am trying to define a specific state (for example 3) for cars that get sent to the depot.

[naive hare]

does this have an admincar command?

[merry carbon]

that would be in qbx_adminmenu. you could add the code to any resource by using this as an example https://github.com/Qbox-project/qbx_adminmenu/blob/5ed2795b49b489fffca3243db3e5efcb6c014fdb/server/commands.lua#L40-L76

[naive hare]

ah sound thanks

[radiant pecan]

anyone else having the issue when you put the car away it gives the notifaction saying Vehicle Stored but than after the car dissapears it reappears but also shows in the garage so you can technically dupe the car?

[violet veldt]

not getting keys when taking out the vehicle

anyone else also facing this issue?

[radiant lark]

#UnsupportedResource

[tepid dagger]

#SupportItThenBruh

[radiant lark]

https://tenor.com/view/yes-man-no-man-no-gif-7347715096894588969