MiniMessage support for the whole plugin

[ornate pasture]

Hello, it seems the plugin is still missing MiniMessage support, you can barely work with the legacy color codes, and if you have custom fonts with glyphs its basically unusable.

I have created a fork of the plugin where i changed all the legacy strings with Components, however im not too satisfied with my current implementation so i would redo it, @outer dawn sorry for pinging but what are your plans and thoughts about this? Have you been working on any MiniMessage implementation yet?

[high fox]

👍

[ornate pasture]

@carmine swift Forgive me for pinging but maybe you know more about the topic, i already finished initial minimessage support, now im expanding it over to the GUI titles and fixing some formatting issues, the legacy formatting is also working btw so it shouldnt break anything

[ornate pasture]

Also it would be extremely easier to implement if the plugin dropped spigot support so i can rely on paper's bundled adventure functions

like having access to meta.displayName(Component)

[ornate pasture]

Here are my current changes: https://github.com/Chronoken/mcpets/commit/0393c9bbd36752f230c4815e9b3369f1b1925ec7

Like i said before, i tested it with legacy and minimessage formatting (even in a single text string like Name: &aGreen <red>red <italic>Italic) and it works perfectly fine

@outer dawn Pinging once more for attention dont kill me pls 🙏

[ornate pasture]

Did further improvements + lots of cleanup

testing it first before i commit

@high fox would you be willing to test it too?

if you are already using MCPets 4.1.10 or 4.1.11 it should work perfect since it should support the legacy colors

[ornate pasture]

https://github.com/Chronoken/mcpets/commit/ff5356ff885ee49576d925d5d31ec7012d80d21a

[high fox]

I can't test it right now, but it shouldn't be a problem in the next few days :)

[ornate pasture]

Fixed an issue with renaming and maxNicknameLength

Tested myself and works properly so far

https://github.com/Nocsy-Workshop/mcpets/pull/78
PR ready

[ornate pasture]

Here is a jar for testing, with all the PR changes

[ornate pasture]

@carmine swift @outer dawn i even fixed the bug that required everyone to set the sync=true in MythicMobs model mechanic for ModelEngine if you used it on a wolf mob
Can i get more attention here on this?

the bug was described in this thread: https://discord.com/channels/1008385318434648145/1384994220984762408

added the fix to my PR: https://github.com/Nocsy-Workshop/mcpets/pull/78

[carmine swift]

I've requested a review from copilot, can you look at the potential issues? I'll be validating it afterwards and perform the merge 🙂 thanks for your contribution!

[ornate pasture]

I already did

I didnt really change anything here except for collapsing the if statement

so i think we can ignore it?

This i will correct right now

This seems to be invalid, i tested the hex replacement and it works fine, so i think the copilot just doesnt see it, as for the malformed MiniMessage, i also tested it out, but i can add the try/catch just for safety

Same here as above

[carmine swift]

The point made by Copilot is the output of the method being always "condition failed". I guess the output should be successful when the displayname has been set

[carmine swift]

if you tested it and it works fine with your method, I think this is simply an hallucination we can ignore indeed

[ornate pasture]

ill make the adjustements in a few mins, testing everything once again to be sure

    public SkillResult castAtEntity(SkillMetadata data, AbstractEntity target) {
        Entity petEntity = BukkitAdapter.adapt(target);
        Pet pet = Pet.getFromEntity(petEntity);
        if (pet == null) return SkillResult.CONDITION_FAILED;
        pet.setDisplayName(petName, save);

        return SkillResult.SUCCESS;
    }
``` that should do it for the MM PetNameMechanic

Okay it seems i must've missed it, the #hex replacement isnt working

fixing it rn

i was using <#hex> to test it, but it was without the <> for the legacy colors

[ornate pasture]

@carmine swift Done

[ornate pasture]

Will you trigger another copilot review?

[carmine swift]

PR merged! thanks for the contribution 🙂

[ornate pasture]

Ill be testing it on my production server but if there are any issues or bugs i will try to fix asap

thanks very much for accepting ❤️

The version should be bumped to MCPets-4.1.12 and a jar released

[ornate pasture]

@carmine swift Sorry, i added some missing stuff in a new PR + i bumped the version to 4.1.12
https://github.com/Nocsy-Workshop/mcpets/pull/79

• i forgot about pet names

[carmine swift]

I believe bumping the API version prevents former builds to work

Is 1.21 mandatory?

[ornate pasture]

well in the pom.xml 1.21 is specified

and it was announced that it supports 1.21 only

in #🦦｜mcpets-builds

[carmine swift]

that does not enforce a specific JAR tho, contrary to the plugin.yml

[carmine swift]

fair enough, I'll merge it

[ornate pasture]

also when it comes to pet names i tested this <rainbow>TEST&cRED#ff00ffNAME<red>RED and it fully works:

[carmine swift]

Would you be interested in becoming a maintainer maybe? You seem invested in the plugin's usage

[ornate pasture]

i wouldnt mind, i use the plugin a lot and i dont want to switch to another

so im more than happy to continue improving it

[carmine swift]

I'll add you to the maintainers then

please contact toffy if you want to have more impact at the community's scale

I'm retired now

[ornate pasture]

okay, thanks again for everything ❤️

[carmine swift]

thank you actually for maintaining MCPets 🙂 I invited you on Github

I'm unsure how to manage the spigot page yet, as I would need others to be able to push updates. If you have any suggestion let me know!

[ornate pasture]

well

i would ditch spigot in favour of modrinth / hangar

they are more popular

[carmine swift]

If you would like to maintain an official release of MCPets there or a fork, feel free to do so 🙂

You can see with Toffy for any partner up!

even on spigot actually

[outer dawn]

Would be helpfull 🙏

I can't seem to find the time to do more than small updates and bug fixes

[ornate pasture]

i can take care of it