The Thunder Manifestation Boss area doesnt open after the cutscene from the "Seirai Stormchasers" quest plays.
where in the files should i be looking for opening that area ? is it with a sceneID or something like that ?
#Thunder Manifestation Boss area
next zodiac
scenic heath
Anything that opens/changes as a result of quests is going to be called in LUA
Anything that happens as a direct result of a quest will be in that quest lua, since that's how it's telling the game that whatever is supposed to happen, should happen
next zodiac
yes i understand i reached to BinOutput\Quest\72158 (the quest to unlock the boss is 7215801) but i cant seem to understand what exactly changes that rock to be a platform
this is the finishExec for that quest it should play the scene and unlock the area
is it the "QUEST_EXEC_MODIFY_CLIMATE_AREA" ?
my bad the quest that displays the cutscene is 7215802
scenic heath
if it changes the terrain/resting objects in the world then that's going to be scenetags
scenic heath
Yes
next zodiac
the quest doesnt seem to throw errors
scenic heath
probably because there isn't an error, more likely just not handled at all
run in debug mode if you want full logs on that info that isn't errors specifically
ex. the log on an exec not triggering is a debug, not an err: https://github.com/Grasscutters/Grasscutter/blob/development/src/main/java/emu/grasscutter/game/quest/QuestSystem.java#L109
questexec lists scenetag handle as missing: https://github.com/Grasscutters/Grasscutter/blob/development/src/main/java/emu/grasscutter/game/quest/enums/QuestExec.java#L62
and sure enough in execs, scene tag is missing: https://github.com/Grasscutters/Grasscutter/tree/development/src/main/java/emu/grasscutter/game/quest/exec
next zodiac
oh its not handled at all 
scenic heath
that's part of why I added scenetag command, because previously scenetags were simply hardcoded
scenic heath
the handling is already there,
https://github.com/Grasscutters/Grasscutter/blob/development/src/main/java/emu/grasscutter/scripts/ScriptLib.java#L301
it just needs the exec to be made and to call it
next zodiac
oh okay let me give it a try then maybe i can contribute 
scenic heath
Nice, I implemented the handling in scriptlib at the time, thought it would be enough. Didn't even look at execs back then (I don't play quests) but it should be really easy to add
should only need like 3 lines to just grab info from the call, then call the scriptlib with it, and return success
next zodiac
Okay made it
no need to call scriptlib actually can just call the function that is call inside scriptlib function directly as the getprogressmanager is available from quest
thank you
how can i contribute btw ? do i open a pull request to AIO or grasscutters directly ?
scenic heath
You could do both, or just to upstream (main GC) repo. If you do it on main only I'll just end up pulling it over to my aio repo anyways
next zodiac
okay i opened a pull request and i also added DelSceneTag since it is missing as well
scenic heath
Nice
next zodiac
im not sure how to make the pull request take 1 commit only so i just made it take 2 fixes in one pull request.
this fix and my previous fix for the filters on invertgation monsters rewards
hope thats okay xd