#Adding costumes through give command

15 messages · Page 1 of 1 (latest)

sullen void
#

I'm not sure if it's happening on the current release of Grasscutter, but as I've tested it through YuFanXing's fork of it, it didn't work.

I've also found some records of discord chats in this server mentioning the issue.

It seems like line 19 of ItemUseGainCostume.java should be changed to
if (GameData.getAvatarCostumeDataItemIdMap().containsKey(params.usedItemId)) {
to make give command work, and exception checks for scene is required for the constructor of EntityAvatar to make avatar selection work.

I'm writing it here since I'm a noob and I don't wanna mess up your project, but I'll make a PR if needed.

still skiff
#

Costumes work as intended in latest grasscutter (which is for 3.2 - gc 1.4.4) with latest 3.2 resources. I would recommend against using forks to test things like this as they don't reflect current grasscutter (issues with a fork should be brought up with the fork, not with grasscutter)

sullen void
#

Thanks for taking your time to test the stuff 😄 That's exactly why I posted it here instead of direct PR.
It might worth taking a look since YuFanXing's PR seems to be getting accepted tho.

still skiff
#

I would hope things like that would be caught and fixed prior to a merge, but if it isn't working in the fork I would recommend you outline the issue and your findings on fixing it in the PR or the issues page for the fork. That way if it is something that was just overlooked it can get fixed there - it looks like the PR has been trying to fix those sorts of bugs that were introduced with updating to 3.3, so a little heads up there would likely be appreciated

sullen void
#

Yeap you're right. I should leave a comment there before the merge.

#

Ohh wait damn I'm just dumb

still skiff
#

Yes except the 3.2 branch (for 3.2 game/grasscutter), and I would usually recommend that one or tamilpp's repo but since tamil's has been run through the ringer of dmca recently yuuki res are great

sullen void
# 
        "skinId": 200301,
        "KJIAKOKHKBO": 2,
        "nameTextMapHash": 1504245738,
        "descTextMapHash": 3529954098,
        "itemId": 340001,
        "characterId": 10000003,
        "jsonName": "Avatar_Lady_Sword_QinCostumeSea",
        "DFLECMBEBKA": 9215865218573512220,
        "NLFKNEIPADH": 17992774763103845215,
        "BILHGPLPHPH": 2693372009414780113,
        "FAEALPPCLJK": 16220654252350373708,
        "quality": 4,
        "GAKJDLMBFHJ": "UI_AvatarIcon_QinCostumeSea",
        "sideIconName": "UI_AvatarIcon_Side_QinCostumeSea",
        "ENPOAHAHBPN": 7856783315815955830
    },
# 
        "EMHIFNAHCOA": 200301,
        "BPFFKCBDIGI": 2,
        "nameTextMapHash": 1504245738,
        "descTextMapHash": 3529954098,
        "itemId": 340001,
        "DHIPGFMDBEN": 10000003,
        "jsonName": "Avatar_Lady_Sword_QinCostumeSea",
        "PDKOJNHALEA": 9215865218573512220,
        "DABMFAPBLMA": 17992774763103845215,
        "BBMFPCDNMND": 2693372009414780113,
        "GKGCIBMKJIH": 16220654252350373708,
        "AEBIGPPLCFF": 4,
        "NGDIFAOMOHA": "UI_AvatarIcon_QinCostumeSea",
        "sideIconName": "UI_AvatarIcon_Side_QinCostumeSea",
        "LHOBJKLEJNC": 7856783315815955830
    },
#

So it's not a problem in the code actually

#

🤦‍♂️

#

The resources were not fully decrypted

#

lmao sorry I'm new to this stuff