#feat: add support for list of permission...
1 messages · Page 1 of 1 (latest)
Hi @knotty cape, I ran the test locally and debugged it. The error happens because the LinkedEntrances array is sorted differently than expected due to concurrency. We can update the test to pass. We're also working on pagination in lookup entity and subject with @lofty oar, so we can merge your PR with those changes.
i will update the PR shortly, also we can track the rest through Pr page on Github
thanks a lot for your time and contribution!
ohh , okk thanks got it
Hi @sage meadow any update on this , I see pagination changes are merged in master branch
Hi @knotty cape, i will merge this week
okk thanks , let me know if some change required would be more thn happy to do
@sage meadow just bumping the msg if we can pls proceed here
Hi @knotty cape, I have updated your pr recently. we will review it and merge today if everything is fine. thank you for your contribution again!
okk thanks a lot
please let me know also If I need to do anything
Hi @sage meadow is there any update pls
Hi @knotty cape, i updated the pr and reviewed. but now there are some small conflicts. let me ask tolga and reply to you.
also, we prefer to add new endpoint/api instead of changing one. can you update the pr accordingly?
Ohh sure will update on weekend
Update :- I have done the changes , But I need to fix few things and also little bit refactor , It was turned out to be a big change so it may take few more days for me
Hi @sage meadow I have refactored and fixed most of test cases , all test cases are working for old lookup API but for new API 2 test cases are failing (returning duplicate permission or some extra permission)and I feel its due to race condition , If i pass single permission in list in that case even these are also working, I tried debugging and i feel its in bulk.ExecuteRequests function somewhere. Can you pls take a look into it
Helo @sage meadow Did you got a chance to review it ?
Hi @knotty cape, yes I took a look at it. I will make some updates this weekend.