Mahact agent lifted my own token

[solemn hedge]

Followed winnus diplo with agent, my own cc got lifted. Actually cost our argent player custo because he thought winnu fleet was locked down a turn later

[sinful whale]

I've seen a similar issue in my game where the agent was used in a system that only had the target player's token. The target player's token was not lifted.

[gaunt fable]

It's broken here https://github.com/AsyncTI4/TI4_map_generator_bot/pull/3145/files#diff-e66b19ff2c73a2af6874aea6040d5707fa43af90479be77159584d327720a8f6L2250. No idea what the point of that change is @thorn fractal ?

[thorn fractal]

Ok so fix it 🙂

[solemn hedge]

Happened again this round. So seems to be a reocurring thing. Ill leave you guys to the fingerpointing 👀

[gaunt fable]

I will 😅 Was just perplexed about the reason for that change.

[thorn fractal]

I think it was just formatting, but idk, can't really take a look right now

[gaunt fable]

Player was overridden because with mahact agent, it's not player who is removing, but the player we get from buttonId-faction instead, so this made it be removed from mahact themselves.

But that method is such a mess already 🙃

I know I've read it many times before trying to understand wth is happening.

[thorn fractal]

That's why I wanted to make the mahact player a separate variable because it was hard to follow 😭

Looks like I just got mahact / player backwards tho, oopsie

[hybrid walrus]

This has been happening to me all week as well

happened just now

[gaunt fable]

I have a fix ready. Will push tomorrow. 👍

[hybrid walrus]

epic, can safely play the OP faction without drawing too much attention to the OPness

it's OP enough already

[boreal delta]

It's actually a very flexible method though. Lotta reusability in that

[boreal delta]

Smh it removes a players CC from the board. If mahact is usin their agent, then the player who's CC is being removed needs to change from the player who initiated the call to someone else. What's so hard to follow about that