Bot forgot For votes

[astral pasture]

see screenshot - immediately prior to my vote, Ghosts voted 4 for. After my vote, it's forgotten.

(in pbd458). Timestamp of the Ghosts vote is 3:40 AM my time, so 6h40m or so prior to my vote.

[silent rock]

#1093162827683987476 message

My view, lining up with bot-log

14:40pm, vote happens
14:57pm, bot restarts with a backup at 14:55 and then map save at 14:57, another backup at 15:00

No bot restarts since
Next vote at 21:19

[silent rock]

backup at 22:00 shows this

backup at 15:00 still had ghost_4 in the save file, so bot restart did not cause this

[brisk compass]

Yeah Im thinking my code is logically flawed somewhere

Im gonna figure it out today

When I wake up

[low dome]

we also noticed this flaw in pbd155c agenda yesterday, me (ghosts) gave 12 votes FOR, afterwhich xxcha gave another 8 votes FOR but the xxcha votes were not added.

[brisk compass]

I think I get it, I was saving it in a rather weird way

Pushing a fix for it now. Was really simple fix, just some silly logic I was doing with the saving

Using ; as both a marker for in between player votes, and as a saving marker in between outcomes, so then it would split the saved string up into many different parts rather that by outcome. Just changed the marker for saving to : instead

[brisk compass]

Where do you find this stuff btw Prisoner?

Seems very useful

[astral pasture]

@brisk compass @silent rock btw it didn’t auto resolve this vote after that bug - it just reported the final voter abstaining, didn’t repeat the vote count and didn’t offer to resolve.

[brisk compass]

Was this recently?

Like today

[astral pasture]

3h45m ago, same pbd as above

[brisk compass]

Yeah, I seemed to have pushed a fix for a different bug recently that stymied a lot of ongoing votes

[brisk compass]

Since I changed how it read incoming changes, it cant read the changes that were already saved in that old bad format, so that's why a lot of ongoing votes were interrupted in their resolution