#Requesting a review for a PR that adds support for Partial Indexes. what process should I follow?

1 messages · Page 1 of 1 (latest)

earnest orbit
#

Hi Prisma team!

I’m the contributor who submitted a PR to add support for Partial Indexes:
https://github.com/prisma/prisma-engines/pull/5749

However, several days have passed and my PR hasn’t been reviewed yet, nor has it gone through the GitHub workflow tests. According to the Prisma Contribution Guidelines, contributors are advised to consult with the Prisma team before submitting a large PR. Unfortunately, I wasn’t aware of this guideline at the time.

Previously, I had solved and merged an issue (https://github.com/prisma/prisma-engines/issues/5615
), but during that contribution I didn’t consult the Contribution Guidelines either, so I wasn’t aware of this process back then. As a result, I submitted this large PR without prior discussion as well.

That said, I strongly believe this feature has significant support from the community, and it is also a feature I personally care a great deal about. If the Prisma team would be willing to kindly review my PR and consider merging it, I would be more than happy to help maintain this feature going forward and address any feedback or concerns.

Thank you very much for your time and consideration.

GitHub

Summary
This PR implements support for partial indexes (also known as filtered indexes) in Prisma Schema Language. Partial indexes allow creating indexes that only include rows matching a specific ...

cerulean hatchBOT
#

You decided to hold for human wisdom. We'll chime in soon! Meanwhile, #ask-ai is there if you need a quick second opinion.

daring wave
#

I have shared this with the team internally. Thanks for the PR.

Team will get back to you on the PR