Error(Context, InternalError) vs Error(Auth, InvalidAction) | Stellar Developers | Page 1

minor jungle Nov 9, 2023, 4:57 PM

#

I'm updating the SDK with latest Env and it appears that there are some changes to the error codes we're seeing in tests.

We're starting to see Error(Context, InternalError) when we used to see Error(Auth, InvalidAction).

Is that expected?

cc @haughty cliff

#

Ignore this. 🤦🏻‍♂️

haughty cliff Nov 9, 2023, 4:58 PM

#

will do

#

but FWIW we currently incorrectly map all the errors during authentication flow to auth errors, which isn't correct. but that's addressed only in https://github.com/stellar/rs-soroban-env/pull/1185 (not merged)

minor jungle Nov 9, 2023, 5:11 PM

#

Ok. I'm not sure I'm the right person to do this upgrade. I've been slowly churning through subtle changes in env that I don't have context on.

#

I said ignore this because for a second I thought this was related to something else. But nope. Seems like auth tests in SDK are inconsistently failing. Will keep digging.

haughty cliff Nov 9, 2023, 5:14 PM

#

ugh, internal errors are concerning

minor jungle Nov 9, 2023, 5:14 PM

#

The internal error in one case I stepped through said there was no LedgerInfo in the host 😕 .

#

But then I ran the individual tests in isolation and they passed.

haughty cliff Nov 9, 2023, 5:15 PM

#

I recall there were changes around getting the current contract id - maybe we haven't accounted for some state that occurs in tests

#

that's even worse though, maybe some features diverge?

minor jungle Nov 9, 2023, 6:33 PM

#

I disabled some tests, and now the other tests pass consistently.

#

Maybe I've had an issue where my environment has had stale something... It seems to be fine now.

#Error(Context, InternalError) vs Error(Auth, InvalidAction)