#CustomAccountInterface out of date?

2 messages · Page 1 of 1 (latest)

mighty osprey
#

In the stellar-xdr the values to be passed for auth are:

struct SorobanAddressCredentials
{
    SCAddress address;
    int64 nonce;
    uint32 signatureExpirationLedger;    
    SCVal signature;
};

Ref: https://github.com/stellar/stellar-xdr/blob/f2f213cf502c73cdac5bb8aa59de9102494e965e/Stellar-transaction.x#L542C8-L548

But it seems we still specify the custom account interface as:

pub trait CustomAccountInterface {
    type Signature;
    type Error: Into<Error>;

    fn __check_auth(
        env: Env,
        signature_payload: BytesN<32>,
        signatures: Vec<Self::Signature>,
        auth_contexts: Vec<Context>
    ) -> Result<(), Self::Error>;
}

Ref: https://docs.rs/soroban-sdk/20.0.0-rc2/soroban_sdk/auth/trait.CustomAccountInterface.html

The signatures is a Vec<Self::Signature> but should probably be Self::Signature.

Wdyt @lusty fjord ?

GitHub

Staging area for future version of Stellar XDR. Contribute to stellar/stellar-xdr development by creating an account on GitHub.

lusty fjord
#

I mean, this is just and scval and could be whatever value convertible to scval. but just changing to Signature would be less confusing indeed