#8.3.8 introduces a breaking change to openContextModal()

8 messages · Page 1 of 1 (latest)

steady pulsar
#

model is no longer a valid prop, seems to be replaced by modelKey/modelId.

The documentation does not reflect this change - https://mantine.dev/x/modals/

Change introduced in PR: https://github.com/mantinedev/mantine/pull/8439

Type error: Object literal may only specify known properties, but 'modal' does not exist in type '{ modalKey: string; } & Partial<Omit<ModalProps, "opened">> & { modalId?: string | undefined; } & { innerProps: any; } & DataAttributes'. Did you mean to write 'mod'?

  683 |                       const aiId = form.getValues("id");
  684 |                       openContextModal({
> 685 |                         modal: "secrets",
      |                         ^
#

8.3.8 introduces a breaking change to openContextModal()

swift parrot
#

Thanks for reporting, I'll change it back to modal in the next patch

light ravine
#

Not only that. Also any custom type for the modal identifier leads to errors on all calls with id property. Yesterday I created an issue for both cases: https://github.com/mantinedev/mantine/issues/8458

When do you plan to release a hotfix for this?

GitHub

Dependencies check up I have verified that I use latest version of all @mantine/* packages What version of @mantine/* packages do you have in package.json? 8.3.8 What package has an issue? @mantine...

zinc mortar
light ravine
zinc mortar
swift parrot