Isaac - Invoices | Stripe Developers | Page 1

lusty talon Jun 3, 2022, 11:48 PM

#

Hi 👋

#

Can you share a request ID?

#

For the Upcoming Invoice request?

gentle gull Jun 3, 2022, 11:50 PM

#

Sure thing! The one in which the tax is not updated to match the new incoming tax rate?

lusty talon Jun 3, 2022, 11:52 PM

#

Yup, that one

gentle gull Jun 3, 2022, 11:52 PM

#

Here's a request ID for a call in which the tax is not overridden: req_Rvk9SWrgDd4gbl

#

For good measure, here's a request ID in which the subscription does not have a default tax rate set and passing in the subscription_default_tax_rates works as expected: req_VIZXg65TqR8hY7

lusty talon Jun 3, 2022, 11:57 PM

#

Okay so you're not seeing the really high tax rate being applied in your upcoming invoice request?

#

We don't store payloads on GET requests so I can't see it

gentle gull Jun 4, 2022, 12:02 AM

#

Ah– haha yeah that's Chicago for you, and no it is not coming back. The customer's originally applied tax rate is in a state without sales tax, and so it should go from tax 0 to tax $29.

lusty talon Jun 4, 2022, 12:03 AM

#

The TaxRate record that is associated with that initial API request has this: percentage — 102500

#

Which is what I though seemed high

gentle gull Jun 4, 2022, 12:04 AM

#

Yeah, that's actually correct. It should be about 10.25% in the end

#

Which I do see as correct in the dashboard

#

Is there anything I can provide from the response payload to help clarify?

lusty talon Jun 4, 2022, 12:08 AM

#

I'm trying to reproduce the requests on my end

gentle gull Jun 4, 2022, 12:09 AM

#

Sweet, I really appreciate the help. Been pulling my hair out for the last hour and a half on this one!

lavish oriole Jun 4, 2022, 12:12 AM

#

@gentle gull Here's what I tried
1/ Create a subscription with a tax rate of 10%
2/ Look at upcoming invoice, see 10% tax rate
2/ Look at upcoming invoice with a different tax rate for 20% and see the 20% tax rate calculated

right now it seems to work as expected for me

#

oh wait

gentle gull Jun 4, 2022, 12:14 AM

#

Interesting. This is with default_tax_rates on the new subscription set?

lavish oriole Jun 4, 2022, 12:14 AM

#

are you mixing things up?

gentle gull Jun 4, 2022, 12:15 AM

#

Possibly!

lavish oriole Jun 4, 2022, 12:15 AM

#

you set default_tax_rates on the subscription item

#

and then you try to override it globally on the subscription which wouldn't work

gentle gull Jun 4, 2022, 12:16 AM

#

Huh. We're creating these using subscription schedules which might've lead to the confusion. Am I able to override tax on a subscriptions line item?

lavish oriole Jun 4, 2022, 12:17 AM

#

https://stripe.com/docs/api/invoices/upcoming#upcoming_invoice-subscription_items-tax_rates

gentle gull Jun 4, 2022, 12:17 AM

#

Ah shoot I see it now– default_tax_rates is a key on the phase object.

#

For the subscription schedule.

#

Thank you so much @lavish oriole , @lusty talon – I think this gets me moving!

lavish oriole Jun 4, 2022, 12:18 AM

#

Yay!

#

I might have misread your logs sorry

#

yeah okay my assumption was wrong

#

Still, schedules should have nothing to do with it and it works totally fine for me

gentle gull Jun 4, 2022, 12:21 AM

#

Interesting.

lavish oriole Jun 4, 2022, 12:21 AM

#

I mean I'm sure there's confusion somewhere. Can you share exact end to end code?

gentle gull Jun 4, 2022, 12:21 AM

#

Happy to. One moment.

#

Previewing upcoming invoice:

const options = {};
if (coupon) options.coupon = coupon.id;
if (taxRate) options.subscription_default_tax_rates = [taxRate];
if (subscription) options.subscription = subscriptionID;
if (price) options.subscription_items = [{ price }];

try {
  const invoice = await stripeClient.invoices.retrieveUpcoming({
    customer: stripeCustomer.id,
    ...options
  });
  const preview = mapDictionary(FROM_STRIPE_INVOICE_DICT, invoice);

  return {
    ...preview,
    isTrialEligible
  };
} catch (err) {
  if (err.statusCode === 404) throw new NotFoundError('Preview invoice could not found');
  throw err;
}

#

If it helps, subscription creation:

if (isTrialEligible) options.trial = true;
if (isTrialEligible) options.end_date = getUnixTime(addDays(new Date(), 7));
if (paymentMethod) options.default_payment_method = paymentMethod;
if (taxRate) options.default_tax_rates = [taxRate];

const schedule = await stripeClient.subscriptionSchedules.create({
  customer: stripeCustomer.id,
  expand: ['subscription', 'subscription.latest_invoice', 'subscription.latest_invoice.discounts'],
  start_date: 'now',
  default_settings: {
    default_payment_method: options.default_payment_method
  },
  phases: [{
    items: [{
      price
    }],
    ...options
  }]
});

return mapDictionary(FROM_STRIPE_SUBSCRIPTION_DICT, { ...schedule.subscription, schedule });

lavish oriole Jun 4, 2022, 12:26 AM

#

ack thanks, I'm really confused by half your code 😅

gentle gull Jun 4, 2022, 12:27 AM

#

Haha yeah it's the result of several developers touching the same files. I can clean this up / simplify if that's helpful, but this is exactly as we do it!

lavish oriole Jun 4, 2022, 12:27 AM

#

okay can you just give me the raw JSON output of the invoice upcoming?

#

I want to see it for myself

gentle gull Jun 4, 2022, 12:27 AM

#

Sure thing.

#

📎 Non-updating_Tax_Result.json

lavish oriole Jun 4, 2022, 12:30 AM

#

thanks looking

gentle gull Jun 4, 2022, 12:31 AM

#

Made with this cURL, for reference, which is a replica of what the API would do:

curl -v https://api.stripe.com/v1/invoices/upcoming\?customer\=cus_LkF3Tvfj8xo2zh\&subscription\=sub_1L2kaSHHHT1qJ1rwzqT38utV\&subscription_default_tax_rates\[\]\=txr_1KvpZ1HHHT1qJ1rweqh8uKK4 \
  -u sk_test_...

lavish oriole Jun 4, 2022, 12:31 AM

#

did you just make that request right now?

#

or is it cached from before

#

okay

gentle gull Jun 4, 2022, 12:31 AM

#

A few minutes ago.

lavish oriole Jun 4, 2022, 12:31 AM

#

are you sure? I don't see any request for this

gentle gull Jun 4, 2022, 12:32 AM

#

I'll do it again if that helps, sure.

lavish oriole Jun 4, 2022, 12:32 AM

#

ah wait it's from like 50 minutes ago

#

that's why

#

I was looking at the past 3 minutes of logs since you have so many

gentle gull Jun 4, 2022, 12:32 AM

#

Haha yeah we have a lot of testing going on.

#

I ran the request again.

#

Via cURL, anyhow.

lavish oriole Jun 4, 2022, 12:33 AM

#

perfect cna I get the JSON?

gentle gull Jun 4, 2022, 12:33 AM

#

Sure, it's the same as before though.

lavish oriole Jun 4, 2022, 12:33 AM

#

just to be super sure 🙂

gentle gull Jun 4, 2022, 12:34 AM

#

Tada!

📎 Non_updating_tax_rate_again.json

lavish oriole Jun 4, 2022, 12:35 AM

#

okay clearly it doesn't care about your tax rate in your call and it works for mine

gentle gull Jun 4, 2022, 12:35 AM

#

Ignore the address change on the customer, 1828 is the actual street number made in both requests, I changed it 123 for sanitization in the first JSON file (though it doesn't reveal anything as the rest of the address is fake)

lavish oriole Jun 4, 2022, 12:36 AM

#

either it's a weird schedule thing, or it's the tax rate being 0 which I haven't tried

#

give me a few minutes

gentle gull Jun 4, 2022, 12:36 AM

#

I suspect it's the schedule, though I haven't tested that.

#

Would be pretty funny if the 0% tax rate to 10.25% rate was somehow an issue, though.

lavish oriole Jun 4, 2022, 12:38 AM

#

I mean there's clearly a bug, not sure which one I want to figure out is true 😅

#

Okay I tried with a schedule, still works. Tried with a 0% tax rate, still works totally fine too. What the heck

#

oh wait you are doing a ton of stuff to that poor schedule

#

for example it has more future phases too

#

Okay I think this is more an issue that the subscription is managed by a schedule and your next phase is resetting the default tax rate so we're taking that into account

#

Yeah I'm sorry I don't have anything obvious right now and your schedule has been updated many times and I'm totally losing myself trying to make sense of this 😦

#

Really sorry but we both need to run too. @gentle gull can you write in via https://support.stripe.com/contact/email and mention my name (koopajah)? I'll find it and try to have someone on my team chase this down for you

#Isaac - Invoices