#krustyflakes-ios
1 messages · Page 1 of 1 (latest)
I'll make sure the stripe pod is consistent locally and over the CI, seems like its a matter of text size within the form
I don't have a lot of experience with this, but I've started looking in case I find anything!
thank you, these screen shots show how the text within the forms is different and it changes the height
Sorry if these are really basic questions (don't know much about snapshot tests) - other than you checking the pod locally vs over the CI, are there any other possible differences between the two?
Is it also easy for you to try this w/o a UIStackView to see if that's part of the problem?
we've had this implemented for a couple of months and it has never given us any problem
i guess my question was more if you guys had made any changes to UI
or updates to account for accesibility or anything like that
Looking in to this. Will get back with what I hear
And to clarify, this implementation was not changed in any way yesterday when this started failing?
@reef aspen I do see this recent-ish commit (https://github.com/stripe/stripe-ios/commit/c33267a53b501ffe0d1100fcc331593b8e6a02fa) which seem to have made some small UI fixes that may affect snapshots
…#242)
-
Changed card scanning view close button to Circular button
-
Made formview scan card button smaller
-
Changed form view scan card button, update snapshots
thank you