#oleg_csp-bug

1 messages ยท Page 1 of 1 (latest)

balmy minnowBOT
#

๐Ÿ‘‹ Welcome to your new thread!

โฒ๏ธ We'll be here soon! Typically we respond in a few minutes, but sometimes we might take a bit longer if the server is busy or if you have a particularly tricky question.

โฑ๏ธ We close idle threads, which makes them read-only. Once a thread is closed it won't be reopened, but you can always start a new thread if you have another question.

๐Ÿ”— This thread will always be available, even after it's closed. You can find it again using Discord's search, or you can save this link: https://discord.com/channels/841573134531821608/1245509389155303496

๐Ÿ“ Have more to share? Add more details, code, screenshots, videos, etc. below.

hot raven
#

@rich sigil do you have a URL I can look at it live?

rich sigil
#

I saw you had helped with this in the past

hot raven
#

yep that rings a bell

#

Can you give me a test account I can use? I'm not going to sign up for a real account with my real email

rich sigil
#

One sec

hot raven
#

sure! I'll flag internally in parallel

rich sigil
hot raven
#

perfect, do you know when it started?

rich sigil
#

I think about a couple hours ago

hot raven
#

Do you know if this is linked to AddressElement on your page? I'm not clear from your code if you preload it or not

#

oleg_csp-bug

rich sigil
#

Sorry - we use AddressElement and CardElement so probably one of those

hot raven
#

thanks!

rich sigil
#

Just took a look - https://docs.stripe.com/security/guide?csp=csp-js still doesn't say that js.stripe.js should be in connect-src, so this does seem unintentional.
While it's innocuous, it did start paging our SRE team due to all these errors and it's the second time there's a regression - would be great if y'all can put some safeguards in place once fixed so it doesn't keep happening ๐Ÿ™

hot raven
#

I'd recommend adding js.stripe.js in your CSP in that case. We definitely will investigate but we don't consider that error the kind of thing someone should page over at least (though I get why you would)

rich sigil
#

Yup, we added it in our CSP for now again. We have alerts for elevated CSP violations in place just to make sure there aren't fatal issues that might prevent customers from being able to check out

#

Thanks for investigating

hot raven
#

Sure thing and sorry for the hassle. I'll push internally to get this better implemented so that it doesn't leak regularly

rich sigil
#

Np. It doesn't seem cause any functional issues. Thanks!

hot raven
#

@rich sigil issue should be resolved!

#

thanks again for raising quickly and providing a repro ๐Ÿ™‚

rich sigil
#

Awesome, thanks!